Friday, 2019-11-15

*** igordc has quit IRC00:24
*** igordc has joined #zuul00:25
*** rfolco has joined #zuul00:31
*** igordc has quit IRC00:32
*** tosky has quit IRC00:59
*** sgw has joined #zuul01:01
*** rfolco has quit IRC01:06
*** webknjaz has quit IRC01:11
*** gundalow has quit IRC01:11
*** mnasiadka has quit IRC01:11
*** webknjaz has joined #zuul01:11
*** tributarian has quit IRC01:11
*** guilhermesp has quit IRC01:11
*** kmalloc has quit IRC01:12
*** wxy-xiyuan has quit IRC01:12
*** iamweswilson has quit IRC01:12
*** mnasiadka has joined #zuul01:12
*** ofosos has quit IRC01:12
*** wxy-xiyuan has joined #zuul01:13
*** iamweswilson has joined #zuul01:13
*** tributarian has joined #zuul01:13
*** kmalloc has joined #zuul01:13
*** guilhermesp has joined #zuul01:13
*** gundalow has joined #zuul01:13
SpamapSgreetings zuulians. I am working on securing my zuul-web from any access (not just privileged) using JWT's. It seems, however, that only the privileged things currently check the JWT. Has anyone worked on perhaps having a default auth setting, so that somebody can basically require all Zuul API access to be authenticated?01:28
*** rlandy|rover|bia is now known as rlandy|rover01:56
*** rlandy|rover has quit IRC01:59
*** openstackstatus has joined #zuul02:04
*** ChanServ sets mode: +v openstackstatus02:04
openstackgerritIan Wienand proposed zuul/nodepool master: [wip] move openstack testing to use containerised daemon  https://review.opendev.org/69346402:52
*** igordc has joined #zuul02:53
*** bhavikdbavishi has joined #zuul02:59
*** bhavikdbavishi1 has joined #zuul03:24
*** bhavikdbavishi has quit IRC03:25
*** bhavikdbavishi1 is now known as bhavikdbavishi03:26
*** raukadah is now known as chandankumar04:21
openstackgerritIan Wienand proposed zuul/nodepool master: Dockerfile: create APP_DIR  https://review.opendev.org/69364605:12
openstackgerritIan Wienand proposed zuul/nodepool master: docker: Base nodepool images on diskimage-builder base image  https://review.opendev.org/69417705:12
openstackgerritIan Wienand proposed zuul/nodepool master: [wip] move openstack testing to use containerised daemon  https://review.opendev.org/69346405:12
ianwso it's a bit annoying that it seems holding a node doesn't also hold the parent dependencies05:14
ianwthis means the intermediate registry disappears05:14
*** swest has joined #zuul06:09
*** gouthamr_ has joined #zuul06:35
*** jpena|off has quit IRC06:37
*** homeski has quit IRC06:39
*** shanemcd has quit IRC06:39
*** mgoddard has quit IRC06:39
*** gouthamr has quit IRC06:39
*** decimuscorvinus has quit IRC06:39
*** fdegir has quit IRC06:39
*** sileht has quit IRC06:39
*** evrardjp has quit IRC06:39
*** tobias-urdin has quit IRC06:39
*** openstackstatus has quit IRC06:40
*** tobias-urdin has joined #zuul06:42
*** jpena|off has joined #zuul06:48
*** shanemcd has joined #zuul06:48
*** mgoddard has joined #zuul06:48
*** decimuscorvinus has joined #zuul06:48
*** fdegir has joined #zuul06:48
*** sileht has joined #zuul06:48
*** evrardjp has joined #zuul06:48
*** jpena|off has quit IRC07:15
*** shanemcd has quit IRC07:15
*** mgoddard has quit IRC07:15
*** decimuscorvinus has quit IRC07:15
*** fdegir has quit IRC07:15
*** sileht has quit IRC07:15
*** evrardjp has quit IRC07:15
*** jpena|off has joined #zuul07:16
*** shanemcd has joined #zuul07:16
*** mgoddard has joined #zuul07:16
*** decimuscorvinus has joined #zuul07:16
*** fdegir has joined #zuul07:16
*** sileht has joined #zuul07:16
*** evrardjp has joined #zuul07:16
coldtomhi, i'm interested in helping to write a gitlab driver for zuul, anything that needs doing?08:10
AJaegercoldtom: there's already some working going on, see https://review.opendev.org/694346 . best talk with Fabien (not sure what's his nic is)08:13
fbocoldtom: hi I'm tracking the tasks for the Gitlab driver here https://storyboard.openstack.org/#!/story/200663208:25
fboand the current open reviews are https://review.opendev.org/#/q/topic:gitlab+(status:open+OR+status:merged)+project:zuul/zuul08:25
fboany help is obviously welcome :)08:26
coldtomthanks! i'll get up to speed on the current work first :)08:27
fbocode review, live testing, implementing pending tasks, advices (I'm not a gitlab user, so I might miss some important key points regarding the intergration with Zuul)08:28
fbocoldtom: great do not hesitate to ping me if needed08:29
*** saneax has joined #zuul08:32
*** themroc has joined #zuul08:34
*** tosky has joined #zuul08:39
*** jpena|off is now known as jpena08:47
*** jangutter has joined #zuul08:56
*** saneax has quit IRC10:07
*** bhavikdbavishi has quit IRC11:12
*** jpena is now known as jpena|lunch12:00
*** bhavikdbavishi has joined #zuul12:30
*** jangutter has quit IRC12:33
*** rfolco has joined #zuul12:59
*** rlandy has joined #zuul13:03
*** bhavikdbavishi1 has joined #zuul13:04
*** rlandy is now known as rlandy|ruck13:04
*** bhavikdbavishi has quit IRC13:06
*** bhavikdbavishi1 is now known as bhavikdbavishi13:06
*** rfolco is now known as rfolco_pto13:08
*** bhavikdbavishi has quit IRC13:14
*** jangutter has joined #zuul13:20
*** rfolco_pto has quit IRC13:33
*** jpena|lunch is now known as jpena14:01
openstackgerritSimon Westphahl proposed zuul/zuul master: Fix issue search in FakeGithubClient  https://review.opendev.org/69455314:24
tobiashpabelanger: this is related to your search issues thing ^14:28
pabelanger++14:30
*** chandankumar is now known as raukadah14:39
*** jangutter has quit IRC15:00
*** avass has joined #zuul15:05
*** rlandy|ruck has quit IRC15:15
*** saneax has joined #zuul15:17
avassregarding this: https://review.opendev.org/#/c/691114/6/roles/install-go/tasks/main.yaml@3 would it be a good idea to download the archive to {{ zuul.executor.work_dir }} and then unarchiving it instead?15:19
pabelangeravass: you can use tmpfile to create tmp safe file15:40
pabelangertempfile*15:41
avassah yeah that makes sense15:44
avasspabelanger: I'm adding a check to see if it's already installed aswell. Do we want to override any pre-existing versions or add a variable that needs to be set to force the version?16:04
pabelangeravass: maybe add it, if we run into it? I don't think we do that today in other jobs16:05
pabelangerIIRC, tempfile should deal with conflicts however16:05
*** armstrongs has joined #zuul16:05
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Adds go jobs and roles.  https://review.opendev.org/69111416:09
armstrongshey guys quick question on nodepool i have /var/lib/nodepool/.aws and have this content in my aws config file. http://paste.openstack.org/show/786190/ this means that nodepool spins up boxes in that fixed account. We have a user that wants to use another aws account to launch nodepool instances, how would we configure nodepool config from zuul to16:09
armstrongscontrol the account it picks to launch instances if we specified multiple accounts in the .aws file?16:09
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Adds go jobs and roles.  https://review.opendev.org/69111416:11
*** jamesmcarthur has joined #zuul16:12
pabelangerarmstrongs: with openstack, we have a single clouds.yaml file, which contains all the credentials. For aws, I assume that doesn't work right?16:12
pabelangerI guess it would be boto3 that managed that16:13
pabelangerbut, if you could add multiple credtials into that file, you could create new providers pre aws credentials16:13
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Adds go jobs and roles.  https://review.opendev.org/69111416:14
*** EmilienM is now known as EmilienM|PTO16:16
avassThat should be ready for review now :)16:16
armstrongspabelanger: I think i can put multiple creds in the file. I just don't know how to select the entry from zuul. How do you do it with openstack to call the specific cred in the clouds.yaml16:17
pabelangerarmstrongs: yah, we setup nodepool with the specific cloud config: https://zuul-ci.org/docs/nodepool/configuration.html#attr-providers.[openstack].cloud16:18
*** jamesmcarthur has quit IRC16:19
pabelangerthen you'd create a specific label for the images there16:19
pabelangerthen, in zuul, set up a new nodeset to just target those nodes16:19
pabelangerusually in openstack (and ansible) we don't have specific region for testings to help avoid outages. We'd rather have more places to run generic nodes16:19
pabelangerbut sometimes, you cannot avoid that16:20
*** jamesmcarthur has joined #zuul16:20
*** jamesmcarthur has quit IRC16:21
pabelangerarmstrongs: https://zuul-ci.org/docs/nodepool/configuration.html#attr-providers.[aws].profile-name looks to be the aws setting16:21
armstrongsso does the provider name map to the cloud name in the clouds.yaml16:21
armstrongsah perfect16:22
pabelangerno, that can be what ever you want. In openstack, it is cloud value that must match16:22
armstrongsthank you16:22
pabelanger++16:22
armstrongsprofile looks like it may work16:22
pabelangerlet me know how it goes, we in ansible are going to do more aws stuff16:22
armstrongsi wish i was using openstack :(16:22
armstrongsmiss the boot times16:22
*** michael-beaver has joined #zuul16:22
pabelangeryah, I am not looking forward to using AWS. But need to demo it16:23
avassmust be nice to live in cloud world ;)16:24
pabelangerit's been a struggle at times, to get where we are for network appliance testing. But I am happy how well it is working16:26
*** hashar has joined #zuul16:28
*** saneax has quit IRC16:29
*** jamesmcarthur has joined #zuul16:36
*** jamesmcarthur has quit IRC17:07
*** hashar has quit IRC17:22
*** hashar has joined #zuul17:22
*** hashar has quit IRC17:39
*** jpena is now known as jpena|off17:58
*** armstrongs has quit IRC18:37
openstackgerritDavid Shrewsbury proposed zuul/zuul master: WIP: test  https://review.opendev.org/69461918:55
openstackgerritDavid Shrewsbury proposed zuul/zuul master: WIP: test  https://review.opendev.org/69461918:55
*** pcaruana has quit IRC18:56
*** tosky has quit IRC19:14
*** themroc has quit IRC19:23
tristanCShrews: thanks, so if the executor copies the inventory to the test node, then that fix makes sense to me19:28
Shrewsit was the easiest way to fix it. not sure if it's the best way19:28
Shrewstrying to decipher the 2.8 post failure now19:28
*** ssbarnea has joined #zuul19:30
Shrewshrm, ara is failing19:31
tristanCShrews: could you share the log of the failure?19:38
ShrewstristanC: http://paste.openstack.org/show/786214/   that's all there is. i don't know how to debug that19:38
Shrewsmay have to enlist dmsimard19:39
dmsimardohai19:40
dmsimardthe irony is that there might've been more data in the ara report :D19:40
Shrewsohai dmsimard. i thought i'd have to say your name 3 times before you would appear  :)19:41
Shrewsbeetlejuice-like19:41
dmsimardonce is usually good :p19:45
dmsimardeven the json doesn't have any more output than that -- if there's a failure there's usually /at least/ a trace that gives us a lead on what the issue might have been19:46
tristanCShrews: perhaps from the executor log there is more info?19:46
openstackgerritDavid Moreau Simard proposed zuul/zuul master: DNM: Get output from ara command  https://review.opendev.org/69462219:48
dmsimardShrews: ^ let's see if this gives us a hint19:48
Shrewsnope, nothing more in the executor log19:50
Shrewsdmsimard: *fingers crossed*19:51
dmsimardif it reproduces we can recover the sqlite database to see what's up19:53
Shrewsi would've thought that info would show up in stderr or stdout ansible output19:53
dmsimardit should, yeah19:54
Shrewsdmsimard: i also set a hold request for that job on your change19:56
Shrewsin case we need to poke at it with a sharp, pointy stick19:57
dmsimardsure19:57
Shrewsoh, except now it won't fail. lol19:58
dmsimardreally long overdue to upgrade zuul's ara to 1.x19:58
dmsimardI added an ignore_errors though19:58
Shrewsyeah, i'm going to just recheck my change19:59
*** lennyb has quit IRC20:00
dmsimardactually it just failed again and there's really no output20:01
dmsimardhowever, we can tell from the rsync just after that it does render /some/ files so it crashes somewhere in the middle20:02
Shrewsoh, that's interesting20:03
* Shrews checks held nodes20:04
dmsimardalready looking :p20:04
dmsimardit does exit 1 without any output20:07
dmsimardinteresting20:07
Shrewsdmsimard: is there not an option for more output? running that command just silently exits20:07
Shrewsyeah20:07
dmsimardadding --debug picks up a trace20:08
dmsimardit's failing to render the result for "Print binary data"20:08
* Shrews lets the expert dig20:08
dmsimardhttp://paste.openstack.org/show/786215/20:08
Shrewscommand: echo -e '\x80abc'20:09
dmsimardso this task: https://opendev.org/zuul/zuul/src/branch/master/playbooks/zuul-stream/fixtures/test-stream.yaml#L5420:09
Shrewsis the command20:09
dmsimardanother thing to add to the integration tests :/20:10
Shrews\o/20:11
Shrewsdmsimard: do we still need the held node?20:12
Shrewsor do you want to verify locally first?20:12
dmsimardlet me pick up the database so I can reproduce locally20:12
Shrewssure20:13
dmsimardok all good20:14
openstackgerritDavid Moreau Simard proposed zuul/zuul master: DNM: Test zuul-stream-functional with ara 1.2  https://review.opendev.org/69462220:18
Shrewsk, thx20:21
dmsimardso the real error is "UnicodeEncodeError: 'utf-8' codec can't encode character '\udc80' in position 2453: surrogates not allowed"20:22
dmsimardencoding and decoding makes me sad20:22
Shrewsif that works, we'll probably need to combine our fixes into a single review20:24
dmsimardupgrading ara to 1.2 might require a bit more work than that but I'm curious to see if 1.2 chokes on that binary output as well20:25
dmsimardalso kind of weird that it only triggers against 2.8 and not before20:25
fungii wonder if that's a regression of the fix for https://bugs.python.org/issue10114 years ago20:26
fungiwhere is that exception getting raised?20:26
dmsimardfungi: it's by ara when trying to render the web result page for a task that runs: echo -e '\x80abc'20:27
fungiand the raw bytearray output is being fed to .encode() i guess?20:29
dmsimardI'm not sure yet :)20:30
fungiahh, okay, sorry i assumed you had a traceback20:30
dmsimardfungi: I do but the ara webapp is nowhere in the traceback http://paste.openstack.org/raw/786216/20:32
dmsimardhunting where it's from20:32
Shrewsthis does make me wonder if we should reconsider when we run the zuul-stream-functional tests. we currently run them when only select files are touched. we apparently haven't run them for a long while, allowing issues to creep in.20:32
dmsimardShrews: ah, the test nodes are running py35 and 1.2 is >=py36 so it ended up failing20:33
fungiit's worth noting that we shouldn't assume all raw shell command output is able to get represented in utf-820:33
fungifrom the traceback it looks like it's flask handling that data20:34
Shrewsdmsimard: ah, maybe that was the reason for the version limit20:34
dmsimardfungi: yeah there are tests for non-ascii characters but not binary20:35
dmsimardso it's a good test to have20:35
*** yolanda has quit IRC20:35
dmsimardflask renders the result just fine .. it's werkzeug that seems sad about it20:39
*** yolanda has joined #zuul20:43
fungiyeah, but that traceback shows flask is calling werkzeug20:54
dmsimardbelieve I've found a fix21:04
dmsimardShrews: that binary string task makes ansible-lint sad too.21:20
dmsimardah nevermind, unrelated error21:21
dmsimardfix in ara is https://review.opendev.org/#/c/694627/21:30
dmsimardI could probably tag a dot release sometime next week when the fix lands21:30
dmsimardadded a test to 1.2.0 and it doesn't have the bug \o/21:48
Shrewsdmsimard: thx!22:28
*** michael-beaver has quit IRC22:52
*** armstrongs has joined #zuul23:03
*** armstrongs has quit IRC23:12
*** jamesmcarthur has joined #zuul23:18
*** Goneri has quit IRC23:41
*** jamesmcarthur has quit IRC23:43
*** jamesmcarthur has joined #zuul23:47
*** jamesmcarthur has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!