Friday, 2019-09-20

*** mattw4 has quit IRC00:00
*** igordc has quit IRC00:10
*** jamesmcarthur has joined #zuul00:21
*** jamesmcarthur has quit IRC00:30
openstackgerritKerby proposed zuul/nodepool master: AWS driver: add ability to determine AMI id using filters  https://review.opendev.org/68320500:37
openstackgerritKerby proposed zuul/nodepool master: AWS driver: add ability to determine AMI id using filters  https://review.opendev.org/68320500:52
*** swest has quit IRC01:35
*** swest has joined #zuul01:51
*** jamesmcarthur has joined #zuul01:54
*** jamesmcarthur has quit IRC02:15
*** noorul has joined #zuul02:18
*** jamesmcarthur has joined #zuul02:26
*** roman_g has quit IRC02:34
noorulHow do I specify multi tenant configuration in zuul main.yaml?02:36
*** rlandy|bbl is now known as rlandy02:37
*** bhavikdbavishi has joined #zuul02:49
funginoorul: just add another - tenant: to the top level list, see https://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml for an example02:52
*** bhavikdbavishi1 has joined #zuul02:52
*** jamesmcarthur has quit IRC02:52
fungithat file has 4 tenants defined currently02:52
*** jamesmcarthur has joined #zuul02:54
*** bhavikdbavishi has quit IRC02:54
*** bhavikdbavishi1 is now known as bhavikdbavishi02:54
noorulfungi: Thank you02:54
noorulfungi: Is it possible to specify cross tenant dependency in the job?02:54
noorulfungi: I mean required-projects attribute of job02:55
fungibuilds don't cross tenants, so i'm not sure what you mean. a tenant can include the same repositories and job definitions as another tenant if that's what you're asking02:56
fungior stated differently, a repository can be present in multiple tenants02:56
fungithough it's strongly suggested that a given project only be gated by one tenant, even if it appears in multiple tenants02:57
fungihaving pipelines in more than one tenant fight over which one should merge changes for the same project would get messy02:57
noorulfungi: I agree02:58
noorulbut in our organization there is a separation of repos by projects on bitbucket02:59
noorulSay, project1 has p1repo1 p1repo2 p1repo302:59
noorulproject2 has p2repo1 p2repo2 p2repo302:59
noorulSo, if I define two tenants for each project as project1 and project203:00
noorulCan a job defined in p1repo1 use p2prepo1 in required-projects ?03:01
fungiyes, but to do that you need to add p2prepo1 to the list of projects in your project1 tenant03:02
fungi(terminology is a little confusing, but it sounds like you're mapping bitbucket repos to zuul projects, and bitbucket projects to zuul tenants)03:02
noorulIsn't that correct?03:03
fungii can only assume it's correct for you03:03
noorulWhat was the reason behind introducing tenant concept?03:03
fungithe ability to have one zuul serve multiple organizations which want to have isolation from each other03:04
noorulOh I see03:05
*** rfolco has quit IRC03:05
noorulHere we have multiple bitbucket projects for different programs inside the organization03:05
noorulI am trying to map tenant to a program03:06
fungifor example, opendev's zuul deployment has a "zuul" tenant which serves the zuul community and an "openstack" tenant which serves the openstack community. they each have their own project lists, pipelines and so on, but that doesn't mean they can't both use jobs or refs from some of the same repositories03:06
noorulFrom zuul docs03:09
noorulA project corresponds to a source code repository with which Zuul is configured to interact.03:09
fungifor example, in that main.yaml i linked, the zuul tenant's untrusted projects include openstack/openstacksdk but is "includes" an empty list from that project, indicating it doesn't even load job configuration, but can still be used for depends-on relationships and required-projects entries in jobs used by the zuul tenant. that same openstack/openstacksdk project also appears in the openstack tenant but with no03:10
fungisuch restrictions03:10
fungion the other hand, in the opendev tenant, the zuul/zuul project is listed with include: [job, secret, nodeset] so the opendev tenant will load jobs, secrets and nodesets from that project even though it's also included unrestricted in the zuul tenant03:12
fungithere are quite a few examples in that file of projects appearing in more than one tenant, with different restrictions and for varying reasons03:13
noorulToo many things to learn03:14
noorulIf I use project using include, will it be gated together?03:18
noorulI mean will depends-on work?03:18
*** jamesmcarthur has quit IRC03:18
*** jamesmcarthur has joined #zuul03:18
fungiyes, if all you want is to be able to use depends-on and required-projects with a project which is being gated in a different tenant, the include with the [] (empty list) should be sufficient03:19
fungiand will still prevent that tenant from loading any job, role or nodeset definitions from the project03:19
*** jamesmcarthur has quit IRC03:22
fungiand yeah, it's definitely more to learn, but you only really need to know about it if you're going to be running with multiple tenants and trying to share things between them03:22
*** jamesmcarthur has joined #zuul03:22
fungii wouldn't personally suggest multiple tenants unless you really need significant isolation between them though. you can still rely on zuul's usual per-project keying and project self-control to allow different teams in an organization to collaborate across projects while retain control of their projects03:24
fungias long as sharing a common set of trusted/config repositories among them is acceptable03:25
fungi(for example, you could put your zuul administrators in control of the config repository for the tenant, but still allow departments to put job configuration of their own in the projects they control)03:26
*** jamesmcarthur has quit IRC03:26
fungithe opendev deployment only recently became multi-tenant, prior to that we had ~2k projects managed by possibly hundreds of teams all coexisting happily in a single tenant03:27
*** noorul has quit IRC03:27
*** noorul has joined #zuul03:28
fungithe main thing which drove us to wanting additional tenants was so we could define separate sets of pipelines with different kinds of rules specific to each tenant03:28
noorulThank you!03:29
noorulI think I should go with one tenant, even though there are two separate projects in bitbucket03:31
noorulIt it will make it simple03:31
noorulMaybe later just in case required can be moved out03:31
*** rlandy has quit IRC03:38
fungisounds like a decent plan03:41
*** jamesmcarthur has joined #zuul04:10
*** swest has quit IRC04:32
*** jamesmcarthur has quit IRC04:41
*** noorul has quit IRC05:16
*** noorul has joined #zuul05:16
*** swest has joined #zuul05:22
*** pcaruana has joined #zuul05:28
noorulmordred shared http://paste.openstack.org/show/777615/ example. But for me it fails with05:31
noorulextra keys not allowed @ data['branch']05:31
noorulfungi: ^^05:40
noorulOh document says it is branches05:50
*** pcaruana has quit IRC05:53
*** gtema has joined #zuul06:03
*** avass has joined #zuul06:04
*** gtema has quit IRC06:11
*** zbr is now known as zbr|ruck06:48
*** tosky has joined #zuul07:18
*** yolanda has quit IRC07:21
*** yolanda has joined #zuul07:23
*** yolanda has quit IRC07:32
*** hashar has joined #zuul07:34
*** jpena|off is now known as jpena07:42
*** jamesmcarthur has joined #zuul07:43
*** jamesmcarthur has quit IRC07:47
*** yolanda has joined #zuul07:47
*** sileht has quit IRC07:49
*** sileht has joined #zuul07:50
*** sileht has quit IRC07:51
*** sileht has joined #zuul07:51
*** noorul has quit IRC08:25
*** noorul has joined #zuul08:26
*** noorul has quit IRC08:32
*** noorul has joined #zuul08:35
*** roman_g has joined #zuul08:44
*** pcaruana has joined #zuul09:12
*** igordc has joined #zuul09:15
*** igordc has quit IRC09:20
*** igordc has joined #zuul09:39
*** gtema_ has joined #zuul09:43
*** sean-k-mooney has quit IRC09:57
*** bhavikdbavishi has quit IRC09:57
recheck[so-zuul] Is there any relationship between Zuul and tox for openstack project? → https://stackoverflow.com/questions/58026167/is-there-any-relationship-between-zuul-and-tox-for-openstack-project10:10
*** hashar has quit IRC10:28
*** pcaruana has quit IRC10:56
*** hashar has joined #zuul10:56
*** jpena is now known as jpena|lunch11:01
*** panda is now known as panda|lunch11:03
openstackgerritJan Kubovy proposed zuul/zuul master: Github connection timeout configuration  https://review.opendev.org/68336611:24
*** igordc has quit IRC11:26
*** pcaruana has joined #zuul11:29
*** Miouge has quit IRC11:29
*** Miouge has joined #zuul11:31
*** chandankumar is now known as raukadah11:33
*** pcaruana has quit IRC11:42
*** pcaruana has joined #zuul11:42
*** dmellado has quit IRC11:45
*** dmellado has joined #zuul11:48
*** jpena|lunch is now known as jpena11:53
*** jamesmcarthur has joined #zuul12:13
*** panda|lunch is now known as panda12:16
noorulWhere should I put project specific roles?12:18
*** Miouge has quit IRC12:19
*** Miouge has joined #zuul12:22
*** jamesmcarthur has quit IRC12:29
*** jamesmcarthur has joined #zuul12:30
*** jamesmcarthur has quit IRC12:35
*** rlandy has joined #zuul12:38
*** gtema_ has quit IRC12:39
funginoorul: they can go in the projects they're specific to, or in a central shared repository if you prefer12:39
*** rfolco has joined #zuul12:46
noorulfungi: Should the roles folder be at the root ?12:47
*** fdegir has quit IRC12:47
*** fdegir has joined #zuul12:47
avassnoorul: yep12:48
avassnoorul: https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse_roles.html#role-search-path12:49
avassnoorul: actually depends on where you put the playbook files12:49
funginoorul: also the 4th paragraph of https://zuul-ci.org/docs/zuul/user/config.html#attr-job.roles talks about directory structure for including roles12:50
*** jamesmcarthur has joined #zuul12:55
noorulThanks12:55
*** jamesmcarthur has quit IRC13:02
*** jamesmcarthur has joined #zuul13:03
*** jamesmcarthur has quit IRC13:08
*** jamesmcarthur has joined #zuul13:24
Shrewsoh for crying out loud. https://review.opendev.org/683250 didn't work???13:26
mordredShrews: it's because of crazypants13:28
Shrewszuul.GerritConnection: Received: 404 Not found: test1~master~I431c9604ff5f8c3243ed1d2b6fcc7d16a4fb31dc13:28
Shrewsgah, same error13:28
mordredShrews: (honestly, I don't know what's up with that run - I rechecked it - the child patch worked fine)13:28
Shrewsmordred: it was supposed to fix that ^^^13:28
mordredShrews: yeah? but like - why did the child patch work?13:28
Shrewsmordred: i don't see a child13:29
mordredShrews: https://review.opendev.org/#/c/68300613:29
Shrewsoh13:29
Shrewsi was thinking "parent" when reading "child"13:30
mordredShrews: there's really no difference13:30
Shrewsmordred: yeah, i dunno man13:30
Shrewsmordred: corvus: ah ha13:31
Shrewsrelease 1.25.5 released 12 hours ago13:32
noorulI am getting the following error13:32
noorulhttp://paste.openstack.org/show/778045/13:32
Shrewsand that only blocks 1.25.413:32
noorulI added a role in the repo and used it in the playbook13:34
Shrewsmordred: perhaps we should change that to urllib3<=1.25.3 ?13:34
openstackgerritDavid Shrewsbury proposed zuul/zuul master: Don't use urllib3 1.25.4  https://review.opendev.org/68325013:35
avassShrews: mordred: That looks similar to a bug I reported for gertty, is it the encoding of '~' characters?13:37
fungiavass: yes13:37
Shrewsavass: yes. see the github link in the requirements.txt change13:37
avassJust saw the github link13:37
noorulfungi: http://paste.openstack.org/show/778045/13:40
mordredShrews: jeeze13:41
noorulNeed help in figuring out http://paste.openstack.org/show/778045/13:51
funginoorul: "ERROR! no action detected in task. [...] name: Run test infrastructure"13:51
fungidoes that task have an action?13:51
noorulhttp://paste.openstack.org/show/778046/13:52
noorulThis is test job http://paste.openstack.org/show/778047/13:54
fungiis "debug" a valid task?13:56
fungii'm afraid i'm a bit out of my depth there13:56
avassYep13:56
noorulExample says so: https://docs.ansible.com/ansible/latest/modules/docker_compose_module.html13:56
avasscould it be the '---' at the beginning of the file?13:57
noorulTrying without it13:58
fungithat shouldn't matter, i don't think. there's an implicit --- at the start of any yaml document13:58
fungiso including an explicit one results in the same parsed data as far as i'm aware13:58
avassthen I would guess the '  name: Run test infrastructure'13:58
avassis the cause13:58
fungiwell, not necessarily, ansible's error said "...may be elsewhere in the file depending on the exact syntax problem"13:59
fungibut at any rate, it seems like ansible is complaining that the play isn't syntactically correct14:00
noorulRemoving name did not help14:01
noorulThis is the latest http://paste.openstack.org/show/778048/14:02
mordrednoorul: on line 17 - are those actually backticks? If so - can you try removing them14:03
noorultrying14:04
noorulNo luck :(14:06
mordredhrm14:06
*** openstackgerrit has quit IRC14:06
noorulLet me try the first step14:07
fungiyeah, maybe it can be bisected by reducing the number of tasks initially, or starting with a noop task of some sort14:09
noorulStarted with a debug msg14:10
noorulI think there is some other issue14:11
noorulhttp://paste.openstack.org/show/778051/14:11
noorulI now have that alone14:11
fungii wonder if the "did not meet host_list requirements...did not meet script requirements" warnings are related, or expected14:12
* noorul is lost14:13
noorulThis is the playbook http://paste.openstack.org/show/778052/14:15
noorulThis is the roles main.yaml14:15
noorulb14:15
noorulhttp://paste.openstack.org/show/778053/14:15
fungihttps://github.com/ansible/ansible/issues/48859 seems to suggest the "did not meet <foo> requirements" messages are benign noise14:16
fungithat last paste looks like a playbook not a role?14:19
fungiat least i'm not used to seeing a role yaml file contain a hosts: or tasks: key14:19
fungii thought the top-level object in the yaml file was just a list and each element a task unto itself14:20
*** hashar has quit IRC14:20
fungibut i'll admit i have at best a tenuous grasp of the various ways these things can be defined in ansible14:20
*** hashar has joined #zuul14:21
Shrewswhy does the role main.yaml specify hosts? i don't think you can do that14:22
fungiyeah, that's basically what i was asking14:23
Shrewsnoorul: you might find it helpful to first test your roles outside of zuul before deploying them14:23
fungiit looks like a playbook and not a role14:23
Shrewssubstitute strings for zuul vars, etc14:23
Shrewsthe role in http://paste.openstack.org/show/778053/ is especially easy to test that way14:24
corvusi looked back across the pastes, and maybe i missed it, but i couldn't find a paste which actually contained the excerpted text from the error.14:24
*** noorul has quit IRC14:25
*** noorul has joined #zuul14:25
*** openstackgerrit has joined #zuul14:26
openstackgerritJames E. Blair proposed zuul/zuul master: Fix gerrit errors from production  https://review.opendev.org/68300614:26
fungiwhat noorul said initially was that http://paste.openstack.org/show/778045/ was the error and http://paste.openstack.org/show/778046/ the (playbook?) associated with that error14:26
corvusfungi: right.  where is "Run test infrastructure" in 778046?14:27
fungiline 314:27
corvusfungi: ah thank you :)14:27
fungibut now i'm starting to wonder that playbook-looking file was actually referenced as a role not a playbook14:28
noorulfungi: You are right14:28
noorulcorvus: Any idea when bitbucket plugin will get merged?14:29
corvusyes, that file is a playbook, presumably ac/monitoring/playbooks/testjob.yaml but the error it cites is for a role at ac/monitoring/roles/test-infra/tasks/main.yml14:29
Shrewsi think that "name: Run test infrastructure" defined below "hosts:" is also wrong14:29
corvusShrews: playbooks can have names14:29
corvusbut playbooks can't be used as roles14:29
corvusShrews: er, plays can have names14:30
corvusit looks like a valid playbook, but not a valid task list14:30
Shrewsi have never seen that14:30
funginoorul: so it sounds like you need to restructure that main.yaml content as a role... drop the hosts and tasks keys and move the task definitions to be the top-level list elements in that file instead14:30
noorulNow I have this in the role14:31
noorulhttp://paste.openstack.org/show/778054/14:31
noorulFingers crossed14:31
funginoorul: that looks more like what i would expect in a role, yes14:31
noorulNo luck :(14:32
noorulhttp://paste.openstack.org/show/778055/14:33
corvusnoorul: regarding merging the driver, i don't believe the review comments have been addressed.  that needs to happen first.  if ofosos isn't able to, you may feel free to do so as followup changes.14:33
ofososcorvus: I was sick the last two weeks, I'll try to make some time this weekend. I wouldn't mind if noorul works on some stuff14:34
noorulofosos: I can try dependent PR14:35
noorulofosos: Glad you are back14:35
corvusofosos: sorry to hear that, hope you're feeling better.  your health is more important than the bitbucket driver :)14:35
ofososAnd today I spent the day debugging some janky ethernet cabling in our open workshop :(14:35
ofososThat said, I can now sit next to the 3d printer and work on Zuul, without seeing my internet connection drop out every 2 minutes.14:36
noorulI am stuck with this role stuff :(14:37
corvusmy desk is also right next to the 3d printer; but it's a small office so i'm next to everything really14:37
funginoorul: maybe it doesn't recognize the docker_compose task... https://docs.ansible.com/ansible/latest/modules/docker_compose_module.html suggests before ansible 2.8 it was called docker_service instead. what version of ansible is zuul using for that job?14:38
ofososnoorul: the problem with the dependent pipeline not merging properly is this: we fetch a "generation id" from bitbucket for each pr, the we test, merge number one, by passing the generation id. As soon as that happens, the generation of the second pr is invalid, because the target branch changed. Now to make this happen we need to wiggle the fetch of this id closer to the merge action.14:39
corvusnoorul, fungi: zuul uses ansible 2.7 by default currently: https://zuul-ci.org/docs/zuul/user/config.html#attr-job.ansible-version14:40
ofososIdeally it needs to move to the reporter. That would eliminate that problem.14:40
ofososThe problem with the workshop is that, we're kind of small and still a young institution and if you don't repair the cabling yourself, nobody will do it.14:41
noorulOh I see14:41
noorulcorvus: What do you recommend? 2.7 or 2.8 ?14:42
noorulAssuming there could be a reason why 2.8 is not default14:42
corvusnoorul: we're just slow about upgrading; use whichever works in your environment (is most compatible with other tooling).14:43
funginoorul: the proposed change to switch the default to 2.8 is https://review.opendev.org/67669514:43
corvuspabelanger: ^ i wonder if we should consider adding 'min-ansible-version' for cases like this?  so folks could set a minimum and not have to worry about unpinning14:44
*** mattw4 has joined #zuul14:45
*** mattw4 has quit IRC14:46
*** mattw4 has joined #zuul14:46
*** mattw4 has quit IRC14:48
*** mattw4 has joined #zuul14:48
corvusclarkb: when you awaken, can you review https://review.opendev.org/683006 ? i'd really like to restart opendev with that and the autohold stuff today14:51
corvusoh, wait, clarkb is going to a wedding or something14:52
openstackgerritMerged zuul/zuul master: Don't use urllib3 1.25.4  https://review.opendev.org/68325014:52
corvusfungi, Shrews: could you take a look at  https://review.opendev.org/683006 ?  it fixes broken master so is moderately urgent14:53
Shrewsyes14:54
corvusi've approved the autohold stack again14:55
noorulAnsible pinning worked14:58
noorulWoo14:58
fungi683006 lgtm14:58
noorulThank you all for the support14:59
noorulZuul team rocks14:59
corvusnoorul: \o/14:59
corvuswe now have a 13-deep gate queue... that's like nova territory :)14:59
fungilike nova territory if there were no other openstack projects ;)15:02
*** jamesmcarthur has quit IRC15:05
*** jamesmcarthur has joined #zuul15:07
Shrewsif we want to add to it, this nodepool builder fix would be nice to have: https://review.opendev.org/68185715:09
*** bhavikdbavishi has joined #zuul15:11
corvusShrews: +2 with comment15:21
maxamillionhell all, random question but is there any type of "visualization" in Zuul that's similar to Jenkins Blue Ocean?15:23
*** mattw4 has quit IRC15:24
maxamillionoh, the Ara Report ... swank15:24
maxamillionnvm me, this is great :)15:24
Shrewscorvus: oh, good point15:37
openstackgerritJames E. Blair proposed zuul/zuul-registry master: Add README and license  https://review.opendev.org/68342615:38
*** jamesmcarthur has quit IRC15:38
noorulofosos: Have you deployed zuul in production?15:39
openstackgerritDavid Shrewsbury proposed zuul/nodepool master: Do not overwrite image upload ZK data on delete  https://review.opendev.org/68185715:41
openstackgerritDavid Shrewsbury proposed zuul/nodepool master: Do not overwrite image upload ZK data on delete  https://review.opendev.org/68185715:43
*** jamesmcarthur has joined #zuul15:43
fungimaxamillion: also the "console" tab on the build detail pages15:43
maxamillionfungi: +1 thanks15:43
*** jamesmcarthur has quit IRC15:45
*** sgw has quit IRC15:49
*** armstrongs has joined #zuul15:51
*** jamesmcarthur has joined #zuul15:54
*** noorul has quit IRC15:56
armstrongshey guys, quick question i have an .zuul.yaml file for my ansible role which lives in the directory of my role. The .zuul.yaml is in my ansible-role top level directory structure. I want to spin up a nodepool vm and execute that role on the target nodepool server. What is the best way to set-up the zuul.yaml config to achieve that? How do i tell15:56
armstrongszuul to execute the current workspaces role?15:56
openstackgerritMerged zuul/zuul master: Store autohold requests in zookeeper  https://review.opendev.org/66111415:58
openstackgerritMerged zuul/zuul master: Add caching of autohold requests  https://review.opendev.org/66341215:58
*** noorul has joined #zuul15:59
noorulofosos: hi16:01
*** jamesmcarthur_ has joined #zuul16:04
*** jamesmcarthur has quit IRC16:07
noorulhostname:port combination in path is creating lot of problem for me16:08
corvusarmstrongs: make a playbook in the same repo that invokes your role, then create a zuul job that specifies that playbook as the "run" playbook for the job, then add that job to that project's pipeline config.16:10
corvusarmstrongs: everything after writing the playbook happens in your role's .zuul.yaml16:11
corvusarmstrongs: the .zuul.yaml for that might look like this: https://etherpad.openstack.org/p/qwWCzT1OJf16:12
armstrongsso the bit i wasnt getting is how zuul knows that the current workspace role is a role in the playbook16:12
corvusarmstrongs: ah, good question -- if a project16:12
corvusgrr16:12
corvusarmstrongs: ah, good question -- if the project looks like it might be an ansible role, or a collection of roles, it automatically adds it to the ansible role path16:12
ofososnoorul: hi16:13
corvusarmstrongs: there's a whole bunch of text about it here: https://zuul-ci.org/docs/zuul/user/config.html#attr-job.roles  see specifically the last paragraph of that section16:13
armstrongsso i just call in my run playbook the role name of the project i added to untrusted projects and it will link16:13
armstrongsyeah but does that not need to be under  repo with a roles folder to work16:14
corvusarmstrongs: if it's the *current* project (ie, the project of the change under test) it's automatically added; if it's a different project, list the project under roles (that's the first few paragraphs of that section)16:14
corvusarmstrongs: it doesn't have to have a roles dir -- zuul also looks for 'tasks/main.yaml' to see if the project itself is one role16:15
corvusarmstrongs: that's described in paragraph 4 :)16:15
armstrongsit is my current project i wana run .zuul.yaml is at the tasks folder level16:15
armstrongsin current workspace/project16:15
corvusyou should definitely read the whole section :)16:15
armstrongsyeah haha16:15
armstrongssorry for being a noob16:16
armstrongs:)16:16
corvusno worries, there's a lot of docs :)16:17
fungidoes the ansible 2.5 removal change need advance warning on the ml before we approve it, or has that already happened? presuambly folks will want to know that they need to move any remaining jobs off 2.5 before upgrading16:18
*** pcaruana has quit IRC16:19
noorulIs there any way to remove hostname and port combination from the path16:19
noorul?16:19
noorulhttp://paste.openstack.org/show/778141/16:19
noorulI tried canonical_hostname, but it not only worked, stopped working stuff16:20
corvusnoorul: that's how it should be done16:21
corvusso if that didn't work, there are bugs somewhere (perhaps incomplete support in the bb driver?)16:21
corvusfungi: good question -- i think we've done this before, what did we do then?16:21
* fungi will research16:24
corvusfungi: it looks like 91f10d21bdfd09891d382b800debeb8142b605f0 is the last time we dropped support for an ansible version, and that was when we only supported one16:25
corvusso this must be the first time we're dropping a version from a range16:25
ofososnoorul: from which path do you want to remove it?16:27
fungicorvus: yeah, that's what i'm finding too. still, i'll hunt for messaging around that timeframe16:27
AJaegercorvus: want to merge https://review.opendev.org/567696 - "Allow upload-logs to toggle compression of console logs" ? Or better wait?16:28
ofososnoorul: yes, we're running Zuul in production, now deploying 2-3 project using it.16:30
corvusAJaeger: lgtm16:30
corvusfungi: i think i'm happy with the release note in 650431 as messaging.16:30
*** jpena is now known as jpena|off16:31
corvusfungi: if someone wants to send a note to -announce saying "hey we're merging this change, it'll be in the next release" that sounds like a fine idea.  but i don't feel it's strictly required.16:32
fungiyeah, i'm not finding any advance warning from when we switched from 2.4 to 2.5. i agree this is slightly different since it's the first time we've removed an ansible since the multi-ansible implementation, but the result is still similar (probably even less impactful)16:33
fungiokay, just wanted to be sure i wasn't jumping the gun of i approved it16:33
corvusShrews: autohold got this error uploading the image to dockerhub:16:36
corvus2019-09-20 16:32:23.986559 | ubuntu-bionic | received unexpected HTTP status: 502 Bad Gateway16:36
*** sgw has joined #zuul16:37
*** mattw4 has joined #zuul16:38
ofososcorvus: what's the idea behind 67751016:41
noorulWhat is the best practice in placing playbooks folder in a project?16:41
ofosos?16:41
corvusofosos: i'm not sure i recall anymore -- i think we were having a conversation and i pushed that up as an illustration of how to convert one of the jobs that's using the fake gerrit to use the fake bitbucket16:43
armstrongscorvus: got that working thanks. Seeing something weird though on the new console output it isn't showing the failure in the logs the failure entry is missing, can see it on ara report and txt output logs though16:45
corvusarmstrongs: 2 questions: 1: are you running at least the latest release, and 2: is the log public or can you paste the relevant section of job-output.json?16:46
corvus(we merged some fixes to that recently, but could have missed a case)16:47
armstrongsim running Zuul version: 3.10.2.dev23 b53b6bad16:47
armstrongsi can paste the output of job-output.json16:48
armstrongs2secs16:48
funginoorul: jobs refer to playbooks by their path within a repo, so the structure is fairly freeform. in our projects we just create a directory called "playbooks" at the top level of the git repository's worktree and then organize playbooks in individual subdirectories within that, loosely naming the playbook files themselves based on the phases they're called from (pre.yaml, run.yaml...)16:48
pabelangercorvus: maybe, seems like something to explore. So far, each time we (zuul.a.c) have switch to newer version of ansible, this have continued to work. Which avoids the need to  have a mix of ansible versions for jobs over trying to keep all jobs the same version.16:49
pabelangerhowever, I'd just be infavor of upgrading to 2.8 by default16:49
pabelangergiven 2.9 is a few weeks away16:49
fungipabelanger: on a related note, looks like we marked ansible 2.5 as deprecated in https://review.openstack.org/631930 which merged along with the multi-ansible implementation back i march, so that's 6 months... should we be updating 2.6 to say "deprecated" with the removal of 2.5?16:49
pabelangermaxamillion: yah, ara and zuul web is getting better each day16:49
pabelangerfungi: sounds like a good idea16:50
pabelangercan do that when I rebase the review16:50
openstackgerritMark Meyer proposed zuul/zuul master: Change reporter pr_version handling  https://review.opendev.org/68358816:50
fungipabelanger: does it need rebasing?16:50
fungilooked like it was passing16:50
pabelanger676695 has merge conflict16:50
fungiahh16:51
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Retry pushes to dockerhub  https://review.opendev.org/68358916:51
corvusShrews: ^16:51
pabelangersame with 674854, can rebase whole stack, adding deprecated info for 2.616:51
pabelangerhopefully rc1 is out today16:51
pabelangerwill rebase then16:51
fungiawesome16:51
ofososnoorul: do you still have the dependent pipeline setup handy? I would like to test 683588 with this, I think it will make it work.16:52
ofososJust pushed, wait for the tests...16:52
fungipabelanger: i think with the discovery that we're marking the oldest supported ansible as "deprecated" in the ansible config, that seems like a nice machine-readable signal deployers can rely on and filter for to identify jobs which need to be switched to newer ansible versions soon16:53
openstackgerritJames E. Blair proposed zuul/zuul-registry master: Add README, license, and Zuul config  https://review.opendev.org/68342616:53
ofososI was unsure how to handle this, but basically we can reload the pr_version in the reporter. You can configure Bitbucket to remove acknowledgement on a code push and this will still work (as in: no merge) in this case.16:53
*** igordc has joined #zuul16:55
*** armstrongs has quit IRC16:57
*** armstrongs has joined #zuul16:58
*** armstrongs has quit IRC16:58
ofososDoes anybody have the zuul tenant url on zuul.openstack.org I forgot it againt16:59
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: Allow upload-logs to toggle compression of console logs  https://review.opendev.org/56769617:00
*** armstrongs has joined #zuul17:00
pabelangerfungi: ++ agree17:00
fungiofosos: you want zuul.opendev.org17:01
ofososfungi: you're a lifesaver :)17:01
fungizuul.openstack.org is a whitelabeled view of the openstack tenant on the zuul.opendev.org deployment17:01
openstackgerritAndreas Jaeger proposed zuul/zuul-jobs master: Allow upload-logs to toggle compression of console logs  https://review.opendev.org/56769617:04
pabelangercorvus: AJaeger: I'm maybe thinking our upload-logs patch for gzip support, should also have a test. But won't get to that today. should have time at fest next week17:04
*** hashar has quit IRC17:06
noorulofosos: In the middle of migrating a project to zuul17:07
openstackgerritMerged zuul/nodepool master: Reduce upload threads in tests from 4 to 1  https://review.opendev.org/68297717:09
noorulofosos: I am wondering how are tests passing without that change?17:09
ofososEasy, like I explained: You're merging PR1, that works, then you're merging PR2 with the old 'pr_version' variable which is now outdated (because you merged PR1), and that fails.17:10
ofosos'pr_version' is a Bitbucket variable, that signifies the PR version for every PR. We have to pull the new 'pr_version' in the reporter and magically everything works.17:11
ofososThat only happens with the dependent pipeline.17:11
ofososnoorul: understood?17:12
noorulofosos: That is the not the scenario17:13
ofososThen what's the scenario?17:13
noorulofosos: PR1 and PR2 approved simultaneously17:13
ofososYes?17:13
ofososWe're talking about merging.17:13
noorulofosos: Both enters the gate queue17:13
ofososYes17:13
ofososAnd then one after the other gets approved. That is what I'm talking about17:14
ofosos^ gets merged17:14
noorulofosos: Actually PR2 has a change on the same line of PR117:14
noorulofosos: PR2 job should not run17:14
noorulThat was the scenario I was talking about long back17:14
noorulI haven't re-looked at it lately17:15
ofososI think we fixed this with changing the branch variable. I'm talking about the problems after that.17:15
noorulI am not able to recollect17:16
noorulI am off to bed now17:16
noorulI will catch you up later17:16
ofososnoorul: good night17:16
ofososI do have a Bitbucket server in my private lab now and can test. Let's see. I'll probably fire it up tomorrow.17:17
openstackgerritPaul Belanger proposed zuul/zuul master: Remove support for ansible 2.5  https://review.opendev.org/65043117:18
openstackgerritPaul Belanger proposed zuul/zuul master: Switch ansible_default to 2.8  https://review.opendev.org/67669517:18
openstackgerritPaul Belanger proposed zuul/zuul master: WIP: Support Ansible 2.9  https://review.opendev.org/67485417:18
Shrewscorvus: i'm beginning to rethink my preference on having mulitple, easily reviewable changes vs. one massive change  :/17:20
corvusShrews: it's really helping us find bugs17:21
corvusShrews: if we get really annoyed, we can squash it (review then squash is always an option)17:22
*** noorul has quit IRC17:22
openstackgerritPaul Belanger proposed zuul/zuul master: Switch ansible_default to 2.8  https://review.opendev.org/67669517:22
openstackgerritPaul Belanger proposed zuul/zuul master: WIP: Support Ansible 2.9  https://review.opendev.org/67485417:22
pabelangerfungi: 2.6 now marked deprecated, with reno notes too17:22
fungithanks pabelanger!17:25
pabelangerthank you!17:25
openstackgerritMark Meyer proposed zuul/zuul master: Change reporter pr_version handling  https://review.opendev.org/68358817:26
*** roman_g has quit IRC17:31
*** sgw has quit IRC17:33
corvusarmstrongs sent me some debugging output privately and i think we've come up with a reproducer for that problem17:39
corvusi think https://review.opendev.org/683598 reproduces it -- you can see the output here https://zuul.opendev.org/t/openstack/build/3d35f38b57584ba6adfabcfd5f5230b3/log/job-output.json#4507 and here https://zuul.opendev.org/t/openstack/build/3d35f38b57584ba6adfabcfd5f5230b3/console17:39
corvusbut based on https://zuul.opendev.org/t/openstack/build/3d35f38b57584ba6adfabcfd5f5230b3/log/job-output.txt#289 we should see something17:40
AJaegerwhen do we want to update opendev's instance of Zuul to newer ansible? https://review.opendev.org/#/c/676697/1 proposes to update to 2.717:40
AJaegernote that once 676695 merges, we move to 2.8 as well - without 67669717:41
AJaegersince we use 2.7 already, 676697 looks safe, isn't it?17:42
AJaegerlog files show we use 2.7.917:43
pabelangeryah, that should be a noop and protects us if we merge the 2.8 bump into zuul (git) and for some reason we restart zuul.o.o. That would switch everything to 2.817:44
pabelangerbut, i do think we should move opendev to 2.817:44
pabelangerhowever, openstack project likely needs some time?17:44
pabelangeractually, now that I think of it17:45
pabelangerif opendev base job is 2.8, and openstack parent to it, doesn't those jobs also move to 2.8 too?17:45
pabelangeror do we do split ansible-playbook pre run phase17:45
pabelangerdoesn't look like it17:46
pabelangeris, in case of opendev, we might need to lock step min version of ansible across all tenants17:47
*** sgw has joined #zuul17:47
*** tosky_ has joined #zuul17:48
pabelangerHmm, yah, I think we need to test that. Not sure what will happen if we bump opendev tenant, and say openstack stays on 2.717:49
*** tosky is now known as Guest8725917:51
*** tosky_ is now known as tosky17:51
AJaegerinteresting, pabelanger - I removed my +2 and wait for tests17:51
*** Guest87259 has quit IRC17:52
pabelangerAJaeger: I could also be wrong :)17:52
corvuspabelanger: where do base jobs come in to play?  i thought all the changes were updating default-ansible-version17:52
pabelangeryah, I think 676697 is safe today17:52
corvus(yes, if we set ansible-version on base, it would affect all tenants, but that's not what 676697 does)17:52
pabelangerwas saying, if we decide to just upgrade opendev to 2.8, I think we might also need to do all other tenants17:53
pabelanger+117:53
pabelangerhowever17:54
pabelangerit is possible, that is a job is using 2.6 or 2.5 some place, 676697 will upgrade them to 2.717:54
pabelangerright?17:54
corvus697 will only affect jobs which don't specify a version17:55
pabelangerokay cool17:55
AJaegerso, should we merge 697 - or don't need it?17:57
*** armstrongs has quit IRC18:01
corvusAJaeger: it won't be necessary if we merge 676695 instead18:07
AJaeger695 means we switch to 2.8 - are we ready for that?18:08
* AJaeger is not deep enough into ansible to answer that...18:08
corvusit's past time for zuul to make the switch18:09
fungiyeah, 2.9 is nearly upon us18:09
pabelangerI think 2.8 is stable, but I didn't dig into openstack jobs to ensure things are compat18:09
pabelangerhaven't seen any new issues so far18:09
Shrewsperhaps we should begin setting the expectation that our version of ansible used in openstack will bump up just after each release of openstack?18:16
*** NBorg has joined #zuul18:19
*** igordc has quit IRC18:20
pabelangerYah (when working on openstack-infra) we'd try to do that, like image upgrades or job changes at start of cycle. But always a fair bit of work to coordinate that across all projects, in an effort to minimize breakages.  For 2.8 switch, tried to ensure zuul tenant was good (after zuul.a.c), but can't give the same guarentee nothing will break for openstack. So, +1 for bump, but unless someone in openstack keeps18:21
pabelangereye on it (I know most here do) but also a good time to ask the openstask community (or TC) to assist.18:21
openstackgerritMerged zuul/zuul master: Pagure - handle Pull Request tags (labels) metadata  https://review.opendev.org/68105018:22
openstackgerritPaul Belanger proposed zuul/zuul master: WIP: Support Ansible 2.9  https://review.opendev.org/67485418:25
pabelangerupdated for ansible 2.9.0rc118:26
*** igordc has joined #zuul18:26
*** snapiri has quit IRC18:26
*** snapiri has joined #zuul18:27
openstackgerritMerged zuul/zuul master: Pagure - reference pipelines add open: True requirement  https://review.opendev.org/68125218:29
*** avass is now known as Guest4760518:31
*** avass has joined #zuul18:31
openstackgerritPaul Belanger proposed zuul/zuul master: Remove support for ansible 2.5  https://review.opendev.org/65043118:32
openstackgerritPaul Belanger proposed zuul/zuul master: Switch ansible_default to 2.8  https://review.opendev.org/67669518:32
openstackgerritPaul Belanger proposed zuul/zuul master: WIP: Support Ansible 2.9  https://review.opendev.org/67485418:32
corvusmhu isn't here,  but tests.unit.test_web.TestTenantScopedWebApi.test_dequeue looks like a flaky test18:35
corvusShrews: ^ i've seen it fail our changes a couple of times18:36
corvusi think we're going to need to fix that18:36
corvusit has a sleep() in it, which is almost certainly the crux of the problem18:36
corvusi'll take a look after lunch if no one else beats me to it18:36
pabelangerI'm just looking at https://zuul.opendev.org/t/zuul/status and the gate pipeline, and noticed that zuul-upload-image has only run for the first change in the queue. Is there a semaphore on that job, which stops the next patch in the queue from also running it?18:38
pabelangeror, just lacking nodes18:38
corvuspabelanger: no, but there's an artifact dependency (it builds container images).  however the second change is just waiting on nodes18:38
pabelangerokay, cool18:39
corvusa potential optimization would be to tell zuul that it's going to rebuild all of the artifacts it depends on, so in this particular case, it doesn't need to wait18:39
corvus(if there were a nodepool or python-base change ahead of it, it would need to wait)18:39
pabelangerk18:39
corvusthis is likely to be a common situation, so it's probably worth brainstorming a way to do that18:40
corvusbut right now, it just knows that changes ahead of it build container images, and it uses container images18:40
pabelangerokay, understand now. Thanks!18:41
corvusmaybe we could do that by saying that the jobs, when run on zuul changes, require "python-base-container-images" and "nodepool-container-images" and they provide "zuul-container-images", and likewise swap that for the jobs when run on nodepool18:41
pabelangerthere we go, next change started running zuul-upload-image job18:43
corvusonce it pauses, the third can start18:43
pabelangerk18:43
pabelangermaybe I'll look more into this stuff on plane, haven't had chance to use it too much18:43
corvuspabelanger: if you have a quick sec, can you look at https://review.opendev.org/683589 ?18:44
pabelangersure, just about to relocate home18:44
pabelanger+318:45
pabelangerheading out again for few hours!18:46
pabelangersee everything this weekend, going to ansiblefest18:46
Shrewscorvus: not even a comment on why that sleep() is there.  grrr...18:50
gouthamrhi, quick question, does zuul not persist jobs/results from a dequeued change?18:53
gouthamri just abandoned a change in openstack/manila, and zuul was done running atleast 2 of the 4 jobs it had for that change, i expected to find the logs in the build history18:54
gouthamrjust wondering if this is an incorrect expectation :)18:55
ShrewsI'm also leaving a bit early today. Everyone have a good weekend, and safe travels if you're heading out for 'fest.18:57
openstackgerritMerged zuul/zuul master: Pagure - handles pull-request.closed event  https://review.opendev.org/68127919:00
openstackgerritMerged zuul/zuul-jobs master: Retry pushes to dockerhub  https://review.opendev.org/68358919:02
fungigouthamr: the builds are only recorded when their buildset is reported19:04
fungigouthamr: the data is written to an sql database as a reporter, similar to how it writes results into gerrit comments19:04
fungiso if not all jobs complete, none are recorded19:05
*** avass has quit IRC19:05
fungithere's been some discussion of ways to change that so that builds are recorded into the database individually as they finish, independent of their buildset, but that would be a somewhat significant overhaul19:06
*** avass has joined #zuul19:06
fungion the other hand, it would allow us to link to build result pages for completed builds in the status display for items whose buildsets are not yet complete, so it would be a compelling improvement19:07
gouthamroh.. ty fungi - makes sense, there's this cornercase desire i share with TheJulia to see logs from dropped runs for completed jobs, is there any way to retrieve those - they're already in swift somewhere?19:08
*** jamesmcarthur_ has quit IRC19:10
*** igordc has quit IRC19:13
fungigouthamr: i might be able to find it. what was the change you abandoned? and what pipeline was it being tested in?19:13
fungithough continued discussion of this particular request is probably more appropriate in #openstack-infra19:14
gouthamrfungi: ack, TheJulia hangs out there, so yes...19:15
*** bhavikdbavishi has quit IRC19:17
openstackgerritMerged zuul/zuul master: Add autohold-info CLI command  https://review.opendev.org/66248719:19
*** igordc has joined #zuul19:19
*** jamesmcarthur has joined #zuul19:20
*** tbarron has joined #zuul19:20
*** jamesmcarthur has quit IRC19:23
openstackgerritMerged zuul/zuul master: Record held node IDs with autohold request  https://review.opendev.org/66249819:48
avasscorvus: so we talked about having multiple reusable workspaces for static nodes when you and mordred were in Gothenburg19:50
avasscorvus: looking at the source for static provider it looks like it should be possible to have multiple entries of the same node name with differing users or ports since it identified them as namedtuples19:51
avasscorvus: so is there anything else that could require the node names to be unique? not able to test it at the moment19:52
avasscorvus: otherwise it looks like the documentation is a bit misleading since the node name+user+port is what needs to be unique19:55
*** hashar has joined #zuul19:55
openstackgerritMerged zuul/zuul master: Add scheduler config options for hold expiration  https://review.opendev.org/68267520:17
corvusavass: i agree that looks like what the implementation does and the docs are misleading.  we should see if there's a functional test that confirms that behavior, and if not, write one, and then update the docs.20:20
*** jamesmcarthur has joined #zuul20:27
fungizuul-maint: i switched https://storyboard.openstack.org/#!/story/2006526 to public since it's referenced in the release notes for 3.10.220:27
corvusfungi: thx20:27
*** jamesmcarthur has quit IRC20:27
fungii also tagged it zuul-security in case we're still doing that20:27
avasscorvus: alright, I think I can look into it a bit more on monday20:28
openstackgerritMerged zuul/zuul master: Mark nodes as USED when deleting autohold  https://review.opendev.org/66406020:37
*** avass has quit IRC20:52
openstackgerritMerged zuul/zuul master: Auto-delete expired autohold requests  https://review.opendev.org/66376220:59
*** jamesmcarthur has joined #zuul21:00
*** jamesmcarthur has quit IRC21:03
*** rfolco has quit IRC21:08
openstackgerritMerged zuul/zuul master: Add autohold delete/info commands to web API  https://review.opendev.org/67905721:20
*** rlandy has quit IRC21:25
NBorgIs there a way to generate jobs for a pipeline dynamically? An easy workaround is to write a script that generates the jobs and the pipeline, but it is always nice to not have to commit generated content.21:33
openstackgerritPaul Belanger proposed zuul/zuul master: WIP: Support Ansible 2.9  https://review.opendev.org/67485421:39
SpamapSNBorg: it's not the first time that has been requested, but no.21:39
openstackgerritMerged zuul/zuul master: Remove outdated TODO  https://review.opendev.org/68242121:43
*** hashar has quit IRC21:46
daniel2Why did all openstack projects move from github to opendev?21:56
SpamapSthey were never intentionally on github. ;)21:58
NBorgSpamapS: Ok, then I'm not missing something in the docs. Thanks.21:58
SpamapSdaniel2: https://mako.cc/writing/hill-free_tools.html  <-- but otherwise, this.21:59
daniel2ah.  I'm curious if it's possible to mirror the gitea repos in a private gitlab instance, or another gitea instance.  We used to have a local mirror of the github openstack repos to improve speed when building images.22:00
SpamapSThe canonical home for the code is review.opendev.org, not opendev.org22:04
fungidaniel2: should be just as easy to mirror from gitea as github. it's all git protocol anyway22:04
SpamapSand yeah, same thing really.22:05
fungidaniel2: also, the official openstack repos (the ones you find in https://opendev.org/openstack/ that is) are still being mirrored to https://github.com/openstack/ anyway22:06
fungiand some projects who moved out of the openstack namespace are mirroring their repositories to various orgs on github, but some aren't (notably, the things in https://opendev.org/zuul/ for example)22:07
fungiwhat's temporarily confusing is some of the stuff which moved out of the openstack namespace in opendev hasn't had its corresponding dead github mirror copies clearly archived22:13
tristanCsoftwarefactory-project.io's Zuul now has 1775 projects in its tenants configuration :-)22:18
fungithat's basically the same order of magnitude as opendev (2132 at present count, not including gerrit built-in repos)22:20
tristanCfungi: though http://zuul.opendev.org/tenants lists less22:21
fungigood point. we have a bunch of retired repos in opendev22:22
fungii was looking at gerrit ls-projects22:22
SpamapStristanC: nice22:23
fungiso not counting opendev's retired repos, sf is larger!22:23
tristanCwell, our zuul does include quite a few project's from opendev.org for rdo's third party ci too22:24
openstackgerritMerged zuul/zuul master: Fix gerrit errors from production  https://review.opendev.org/68300622:24
fungialso i wonder if that double-counts repos presented into more than one tenant22:25
tristanCfungi: tenant's list does include duplicate across tenant22:25
tristanCfor good measure, here are the telegraf metrics of the host running the zuul scheduler: https://softwarefactory-project.io/grafana/?orgId=1&var-datasource=default&var-server=zs.softwarefactory-project.io&var-inter=$__auto_interval_inter22:27
*** mgoddard has quit IRC23:17
*** mgoddard has joined #zuul23:19
*** tosky has quit IRC23:28
*** mattw4 has quit IRC23:48
*** rfolco has joined #zuul23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!