Monday, 2019-08-12

*** yolanda has quit IRC00:12
*** yolanda has joined #zuul00:13
*** jamesmcarthur has joined #zuul00:45
*** jamesmcarthur has quit IRC01:13
*** jamesmcarthur has joined #zuul01:20
*** jamesmcarthur has quit IRC01:30
*** jamesmcarthur has joined #zuul02:12
*** yolanda has quit IRC02:32
*** yolanda has joined #zuul02:37
*** jamesmcarthur has quit IRC02:38
*** yolanda has quit IRC02:43
*** yolanda has joined #zuul02:44
*** jamesmcarthur has joined #zuul02:47
*** rfolco has quit IRC02:49
*** jamesmcarthur has quit IRC02:56
*** jamesmcarthur has joined #zuul02:59
*** yolanda has quit IRC03:17
*** yolanda has joined #zuul03:22
*** jamesmcarthur has quit IRC03:25
*** toabctl has quit IRC04:21
*** toabctl has joined #zuul04:24
*** bhavikdbavishi has joined #zuul05:00
*** raukadah is now known as chkumar|ruck05:10
*** sshnaidm is now known as sshnaidm|afk05:29
*** pcaruana has joined #zuul05:29
*** pcaruana has quit IRC05:37
*** bhavikdbavishi1 has joined #zuul05:38
*** bhavikdbavishi has quit IRC05:40
*** bhavikdbavishi1 is now known as bhavikdbavishi05:40
*** bjackman has joined #zuul05:42
*** jamesmcarthur has joined #zuul05:47
*** pcaruana has joined #zuul05:50
*** jamesmcarthur has quit IRC06:03
*** jamesmcarthur has joined #zuul06:06
*** jamesmcarthur has quit IRC06:21
*** jamesmcarthur has joined #zuul06:45
*** AJaeger has quit IRC06:47
*** jamesmcarthur_ has joined #zuul06:51
*** jamesmcarthur_ has quit IRC06:53
*** jamesmcarthur_ has joined #zuul06:53
*** jamesmcarthur_ has quit IRC06:53
*** jamesmcarthur_ has joined #zuul06:54
*** jamesmcarthur has quit IRC06:54
*** jamesmcarthur_ has quit IRC07:04
*** AJaeger has joined #zuul07:04
*** jamesmcarthur has joined #zuul07:05
*** saneax has joined #zuul07:09
*** jamesmcarthur has quit IRC07:10
*** tosky has joined #zuul07:17
*** bjackman has quit IRC07:17
*** bjackman has joined #zuul07:18
*** jpena|off is now known as jpena07:25
*** themroc has joined #zuul07:29
*** panda has quit IRC07:30
*** panda has joined #zuul07:33
*** zbr is now known as zbr|flu07:47
*** fbo has joined #zuul07:47
*** saneax has quit IRC08:42
*** AJaeger has quit IRC08:42
*** persia has quit IRC08:42
*** mordred has joined #zuul08:43
*** AJaeger has joined #zuul08:43
*** saneax has joined #zuul08:43
*** openstackgerrit has quit IRC08:45
*** persia has joined #zuul08:47
*** irclogbot_0 has quit IRC08:49
*** irclogbot_3 has joined #zuul08:53
*** sshnaidm|afk is now known as sshnaidm09:52
*** bhavikdbavishi has quit IRC10:22
*** bhavikdbavishi has joined #zuul10:24
*** bhavikdbavishi has quit IRC10:33
*** bhavikdbavishi has joined #zuul10:36
*** pcaruana has quit IRC10:43
*** pcaruana has joined #zuul10:43
*** bjackman has quit IRC11:13
*** electrofelix has joined #zuul11:23
*** jpena is now known as jpena|lunch11:40
ianwtobiash: could you do me a favour and check in on https://github.com/philpep/testinfra/issues/479 about installing the opendev-zuul github app.  i think i'm saying the right thing, and i think we're setup system-config wise correctly to run the jobs, but it's my first journey down this particular road11:41
ianwif/when i get it worked out, i might write a bit of a user-focused guide on github integration11:41
tobiashianw: sounds correct11:45
tobiashdoes the owner know about zuul?11:45
ianwtobiash: yes, we've discussed it before; they want some testing against ansible devel branch which we can provide easily11:48
tobiashah cool11:48
ianwtobiash: oh, and thanks :)11:48
ianwtobiash: once the app is installed ... if zuul was started without it, will it "reconnect" ... i was looking at it and it seems to poll the available apps at start but not sure if it re-polls11:49
ianwsorry, the app threads poll the available projects11:49
ianw(i.e. currently we get 2019-08-01 14:50:25,604 ERROR zuul.GithubConnection: No installation ID available for project philpep/testinfra)11:49
tobiashianw: you might need a reconfigure of zuul11:49
ianwok, good to know, thanks11:50
*** tributarian has joined #zuul11:52
*** rlandy has joined #zuul12:00
*** rlandy is now known as rlandy|rover12:00
*** rfolco has joined #zuul12:03
*** aprice has quit IRC12:14
*** aprice has joined #zuul12:14
*** iamweswilson has quit IRC12:15
*** iamweswilson has joined #zuul12:15
*** jpena|lunch is now known as jpena12:30
*** electrofelix has quit IRC12:37
*** themroc has quit IRC12:41
*** electrofelix has joined #zuul12:47
zbr|flucan zuul pass tags to ansible when running jobs?13:05
zbr|fluianw: i am also interested about a zuul integration with github, i already have few repos where I would like to test it.13:06
pabelangerzbr|flu: not today, but should be able to support if somebody was to add it13:10
zbr|flupabelanger: ok. for the moment i will stick to travis and azure-pipelines for github projects, they both have very good integrations.13:11
pabelangerzbr|flu: I mean, if that is the only thing stopping you from migrating to zuul. can whip up a change for it13:13
zbr|flupabelanger: my only concerns are regarding UX for those trying to make a small contribution. If would work I have no constraints to migrate some of my projects to zuul: like selinux or pytest-molecule. I cannot speak for molecule itself as I do not have the power to make decisions there. Still, gundalow returned today, so thinks may get moving.13:17
zbr|flupersonally I would prefer to play with a test (or small) project, with multiple CI in parallel, so we would assure it works well.13:17
*** frickler has quit IRC13:18
*** chkumar|ruck is now known as raukadah13:30
corvusmordred: can you +3 https://review.opendev.org/673327 ?13:51
corvusthat will get the log stuff moving13:51
corvusclarkb: ^13:52
clarkbcorvus: is that ready now?14:00
corvusclarkb: yeah, we sent the deprecation notice 2 weeks ago14:00
corvushttp://lists.zuul-ci.org/pipermail/zuul-announce/2019-July/000046.html14:00
clarkbcorvus: looks like it hit a merge conflict14:05
*** openstackgerrit has joined #zuul14:05
openstackgerritTristan Cacqueray proposed zuul/zuul master: config: add tenant.toDict() method and REST endpoint  https://review.opendev.org/62134414:05
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Remove download_artifact_name parameter  https://review.opendev.org/67332714:11
corvusclarkb: ^ still look good?14:11
*** tributarian has quit IRC14:12
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Use human-readable names for artifact returns  https://review.opendev.org/67238214:13
corvusthat one got caught up in the whitespace addition patch14:13
clarkbyup looks like AJaeger and I both got it14:14
corvusclarkb: can you get https://review.opendev.org/672382 while you're at it?14:15
clarkbDone14:18
corvusthis isn't quite as time-sensitive, but i'd like to get topic:zuul-release merged before the next release.  they're all easy docs changes.14:22
corvussomething weird happened with the tests on that, which i haven't debugged yet, but if those could get another +2, i'll figure out what needs to happen to merge them14:23
corvusi'd like to make a release after they land and we verify everything is okay with the url reporting switch in opendev14:23
*** tributarian has joined #zuul14:28
openstackgerritMerged zuul/zuul-jobs master: Remove download_artifact_name parameter  https://review.opendev.org/67332714:30
fungiwhat's up with the failures on 675411? does anybody know yet?14:33
clarkbcorvus said he would debug if that stack got reviews14:33
clarkbI have +2'd that stack now along with tobiash14:33
clarkbcorvus: ^ fyu14:34
fungisee, that's what i get for trying to skim scrollback in an airport gate area14:34
fungii should know better, and read closer ;)14:34
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Collect container logs from test-registry job  https://review.opendev.org/67592615:00
*** mattw4 has joined #zuul15:01
*** mattw4 has quit IRC15:06
openstackgerritMerged zuul/zuul-jobs master: Use human-readable names for artifact returns  https://review.opendev.org/67238215:07
tobiashcorvus, Shrews: I have an interesting question/challenge regarding nodepool images. We're in transition of moving workload away from ceph onto nvme disks. So with this workflow a new image gets first copied onto the compute node if it's not yet cached there.15:16
tobiashthe problem we face there is the size of the images (up to 160gb)15:16
tobiashwhich makes it problematic to just upload the image and then use it for all new nodes (this would kill just ceph and the network)15:17
tobiashcorvus, Shrews: what do you think about a hook in nodepool that gets called after the upload and before the first usage?15:18
corvusclarkb, fungi: you may have input ^15:18
tobiashthis could enable two use cases: first it makes it possible to validate the image itself by a script to make sure it can be booted, second it could facilitate our use case by carefully pre-populating the image to all compute nodes before nodepool uses the image15:19
clarkbyou mean have nova callback to nodepool to tell it when it is safe to usethe image?15:19
clarkbfwiw I believe boot from volume is meantto address this problem15:20
tobiashI mean adding an optional hook into nodepool itself that calls a shell script that can do whatever15:20
tobiashand based on the return code treat the image upload as success and else as failed15:21
tobiashclarkb: we explicitly go awai from boot from volume because of ceph (it is a severe scalability issue for our workload)15:21
tobiashwe just need a way to distribute the imaged in a controlled way to the compute nodes15:22
tobiashour idea here is to create temporary vms using anti affinity to pre-populate the image cache15:22
tobiashso tldr the idea is to add an optional post-upload script into the nodepool image config that can do such things15:24
corvusclarkb: this sounds like something we dealt with in infra-cloud; but my recollection is that we dealt with it by making sure we used qcow instead of raw images, and eliminating an extra layer of caching on the hypervisors?  so maybe that still doesn't help with a 160G image?15:25
corvus(my memory of this is pretty fuzzy though)15:25
tobiashwe will switch to qcow but this will bring down our image size from 160gb to 100gb which still requires special thought15:26
corvustobiash: assuming no one has better ideas about how to avoid the need in the first place, a hook sounds reasonable to me15:28
tobiashcorvus: cool, I'll look into that15:28
tobiashthanks15:28
mordredyeah - I think a hook seems reasonable - let's deployers handle cases that are specific to their env15:28
mordreds/let's/lets/15:28
clarkbcorvus: ya in infracloud we were uploading qcoes then told nova not to convert them to raw15:29
clarkbas that was an extra set of data to move around15:29
corvusyeah that was it15:30
corvustobiash: ^ you may want to be aware of that when you switch15:30
clarkbI have no objections to a sanity checker nodepool exec15:31
tobiashyeah, we're planning to switch to qcow and I have the expectation that this makes it better as well15:31
tobiashbut given our image sizes I'm pretty sure we still need some pre-popuplation before spawning 100 jobs15:31
corvussounds likely15:31
tobiashthanks for confirming that qcow is the right way :)15:33
tobiash(plus post-upload hook)15:33
*** AJaeger is now known as AJaeger_15:51
*** jpena is now known as jpena|off15:53
corvusregarding the registry-related errors on those doc changes -- it looks like somehow one of the layers that was pushed into the intermediate registry is bad16:05
corvusthe build that pushed it did not report any errors, but i can reproduce the issue when fetching it.16:06
corvusthe push did not happen anywhere near the time that the garbage collection cron runs, so it seems unlikely to be corruption caused by that16:06
corvusit might be worth trying to see if we can find the object for that layer in swift, just to see if there's anything interesting about it.  i'm not sure how difficult that will be16:07
*** bhavikdbavishi has quit IRC16:08
*** bhavikdbavishi has joined #zuul16:10
corvusit's a 0 byte object in swift16:19
corvusi'll see if i can dig up some logs from the intermediate registry16:20
mordredcorvus: WEIRD16:21
*** hwangbo has joined #zuul16:23
corvusi'm not seeing anything obvious in the registry log16:31
corvusi'm not sure what else to debug here.  either the registry failed to store the layer, or swift deleted the data.  i lean toward the first option.16:32
corvusit might be the case that the swift backend for the docker registry is not 100% reliable16:32
mordred:(16:34
corvusin happier news, the 'report the zuul url' change is in place in opendev -- here's an example: https://review.opendev.org/#/c/675923/16:35
openstackgerritJames E. Blair proposed zuul/zuul master: Revert "Try out reporting the build page"  https://review.opendev.org/67594216:37
corvuswe can clean that up now ^16:37
clarkbcorvus: in that revert do you want to leave off those success urls for npm html?16:38
clarkband rely on hte build page to link to the artifacts instead?16:38
corvusclarkb: we could go either way -- the build page is still going to get reported, the success-url just determines what that status page links to at this point.16:40
clarkbcorvus: ok I +2'd it with that note16:41
clarkbwill let you decide if you want to change it or approve it16:41
clarkbas for the intermediate registry do we delete the image that is in there?16:41
corvusclarkb: i think we'll get another set of builds/images as the parent changes merge, so those changes should get unstuck16:43
*** armstrongs has joined #zuul16:55
corvuswow, i'm seeing a bunch of test timeouts16:56
openstackgerritMerged zuul/zuul-jobs master: Collect container logs from test-registry job  https://review.opendev.org/67592616:58
corvus2 runs in ovh-bhs1 took >1h, 1 run in gra1 took 1h, 1 run in rax-dfw took 54m16:58
corvuslast week the same job took 45m in limenstone and rax-ord16:59
corvusGitPython==2.1.13  ->  GitPython==3.0.017:01
corvusgood news is it works, the bad news is (if my theory is right) it's 1.5x slower17:03
openstackgerritJames E. Blair proposed zuul/zuul master: Cap GitPython <3.0.0  https://review.opendev.org/67599117:04
openstackgerritJames E. Blair proposed zuul/zuul master: Add release note for Pagure driver  https://review.opendev.org/67541017:04
openstackgerritJames E. Blair proposed zuul/zuul master: Move admin-rules setting in tenants doc  https://review.opendev.org/67541117:05
openstackgerritJames E. Blair proposed zuul/zuul master: Make auth docs more boring  https://review.opendev.org/67541217:05
openstackgerritJames E. Blair proposed zuul/zuul master: Don't capitalize Token in docs  https://review.opendev.org/67541317:05
corvusi went ahead and rebased that docs stack on it, so we'll get lots of data17:05
*** mattw4 has joined #zuul17:10
mordredcorvus: I hope your theory isn't right17:14
corvusyeah.  i'm not sure what we should do if it is.17:14
*** electrofelix has quit IRC17:21
*** saneax has quit IRC17:46
fungitobiash: the other thing we did, which is probably also obvious and therefore not especially helpful advice, is to devote as much network bandwidth as possible to the interfaces compute hosts use to communicate with wherever the original images are stored17:47
*** jamesmcarthur has joined #zuul17:53
fungiallison price at osf just brought this bit of praise to my attention: https://twitter.com/gposton/status/115902771412205977917:55
*** sgw has quit IRC18:03
corvus\o/18:05
fungiword is spreading (somehow, somewhere!)18:06
mordredyay!18:14
mordredI have liked the posts18:15
mordredhopefully doing so is an action that has positive impact18:15
*** jamesmcarthur has quit IRC18:30
*** jamesmcarthur has joined #zuul18:32
tobiashfungi: yes, we have separated nics for storage and user traffic18:33
*** jamesmcarthur has quit IRC18:34
*** jamesmcarthur has joined #zuul18:34
tristanCzbr|flu: here is a story for ansible tag in zuul job: https://storyboard.openstack.org/#!/story/200135318:50
*** jamesmcarthur has quit IRC19:08
SpamapStristanC: neat. My workaround for that has been to break everything up into roles and includable/importable playbooks and compose. Tags are pretty nice though, if you prefer a more monolithic playbook style.19:12
*** igordc has joined #zuul19:26
*** igordc has quit IRC19:41
corvusmordred, clarkb, tobiash: good/bad news -- it does look like gitpython3 caused the 1.5x slowdown.  i think we should merge https://review.opendev.org/675991 and start figuring out why19:45
tobiashyay19:46
clarkbI'm good woth capping to work aroubd it for now19:46
*** bhavikdbavishi has quit IRC19:49
tristanCcorvus: are we still expecting a zuul release this week?19:54
corvustristanC: yes, i haven't heard of any issues with the build page reporting in opendev (we made the switch a couple hours ago).  assuming that is still the case, once we merge everthing under "topic:zuul-release" (mostly some docs changes) i think we'll be ready19:55
corvusmaybe tomorrow or wednesday?19:55
tristanCcorvus: excellent, thanks a lot!19:56
corvusi opened an issue with gitpython: https://github.com/gitpython-developers/GitPython/issues/90619:57
corvusi've confirmed that the single unit test tests.unit.test_merger_repo.TestMergerRepo.test_ensure_cloned takes 1.57x under gitpython 320:06
corvusso i think that's a pretty good narrow and reproducible test case20:07
*** igordc has joined #zuul20:11
corvuslooking at the timestamps in those tests, a simple repo reset takes 43ms under 2, and 60ms under 3.  so the 1.5 factor is still holding20:14
openstackgerritMerged zuul/zuul master: Cap GitPython <3.0.0  https://review.opendev.org/67599120:36
corvusit's looking like maybe the number of git process executions has ~doubled20:39
corvusbased on running some simple ops through yappi20:39
corvusoh yeah, there's tons of extra 'git rev-parse' invocations20:41
SpamapSbingo20:42
corvusugh, 2/3 of the git blame commands i'm running are just showing pep8 changes20:52
*** pcaruana has quit IRC20:56
*** mattw4 has quit IRC21:03
*** mattw4 has joined #zuul21:04
corvusway more than 2/321:16
corvusevery thread i pull ends at a pep8 patch21:16
corvusfinally -- i think this is the problem: https://github.com/gitpython-developers/GitPython/pull/808/files21:24
corvusspecifically: https://github.com/gitpython-developers/GitPython/pull/894/files#diff-c276fc3c4df38382ec884e59657b869dR450-R45821:27
corvusthat causes a bunch of extra rev-parse calls21:28
*** mattw4 has quit IRC21:31
*** mattw4 has joined #zuul21:32
*** mattw4 has quit IRC21:38
*** mattw4 has joined #zuul21:39
*** tosky has quit IRC21:55
corvustristanC: https://review.opendev.org/675461 might be interesting to you when you have a sec (low importance)22:16
clarkbcorvus: is the git repo config file not implied to be at the git_dir + /config?22:21
clarkbI guess I had assumed that assumption was always true22:21
clarkbalso I'm not quite sure I understand how git rev-parse config is supposed to do something use ful there22:22
clarkboh its --git-path22:25
openstackgerritMerged zuul/zuul master: Add release note for Pagure driver  https://review.opendev.org/67541022:26
openstackgerritMerged zuul/zuul master: Move admin-rules setting in tenants doc  https://review.opendev.org/67541122:34
openstackgerritMerged zuul/zuul master: Make auth docs more boring  https://review.opendev.org/67541222:58
*** mattw4 has quit IRC23:00
*** mattw4 has joined #zuul23:00
*** rlandy|rover is now known as rlandy|rover|bbl23:12
openstackgerritMerged zuul/zuul master: Revert "Try out reporting the build page"  https://review.opendev.org/67594223:31
*** armstrongs has quit IRC23:40
*** mattw4 has quit IRC23:48

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!