Wednesday, 2019-07-31

fungiwill give it a shot00:00
funginot sure why but loading zuul-preview urls is taking me a while00:02
fungicorvus: woo! i get a lovely pop-up error on the build page now00:03
fungiNetwork Error (Unable to fetch URL, check your network connectivity, browser plugins, and ad-blockers) http://logs.openstack.org/10/673710/1/gate/openstack-zuul-jobs-linters/c1081dc/zuul-manifest.json00:03
fungiit doesn't persist, vanishes after some 15-20 seconds (i will try again and time it)00:04
fungiactually, it does seem to stick around this time (the first two times i tested it disappeared fairly soon but was there long enough to read)00:06
fungimay also have been related to keypresses or changes in window focus00:07
funginope, tried it again but didn't touch a thing after it started to load, and the error message vanished after 10 seconds00:08
fungiso... not sure what's up with that but a huge improvement nonetheless00:08
*** armstrongs has joined #zuul00:14
*** armstrongs has quit IRC00:24
corvusfungi: yeah, i think the popup things are designed to do that; we could probably change the timing.  also, yay!00:47
fungiawesome00:53
*** jamesmcarthur has joined #zuul01:35
openstackgerritMerged zuul/nodepool master: Enable debug logs for openstack-functional tests  https://review.opendev.org/67241202:28
openstackgerritMerged zuul/zuul master: Add change replacement field in doc for start-message  https://review.opendev.org/66597402:34
*** jamesmcarthur has quit IRC02:38
openstackgerritMerged zuul/zuul master: Improve error reporting for zuul dequeue  https://review.opendev.org/66981302:43
*** jamesmcarthur has joined #zuul02:45
*** wxy-xiyuan has joined #zuul03:15
*** jamesmcarthur has quit IRC03:22
*** jamesmcarthur has joined #zuul03:23
*** jamesmcarthur has quit IRC03:27
*** bhavikdbavishi has joined #zuul03:30
*** bhavikdbavishi1 has joined #zuul03:35
*** bhavikdbavishi has quit IRC03:36
*** bhavikdbavishi1 is now known as bhavikdbavishi03:36
*** jamesmcarthur has joined #zuul03:53
*** jamesmcarthur has quit IRC04:00
*** jank has joined #zuul04:09
SpamapSmordred:oh hell yes04:12
SpamapS(re: logs UI)04:12
*** jamesmcarthur has joined #zuul04:30
*** jamesmcarthur has quit IRC04:38
*** sanjayu_ has joined #zuul04:45
*** themroc has joined #zuul05:12
*** themroc has quit IRC05:17
*** jamesmcarthur has joined #zuul05:34
*** jamesmcarthur has quit IRC05:39
*** threestrands has joined #zuul05:44
*** raukadah is now known as chandankumar06:04
*** jamesmcarthur has joined #zuul06:08
*** jamesmcarthur has quit IRC06:15
*** themroc has joined #zuul06:32
*** sanjayu_ has quit IRC06:32
*** themroc has quit IRC06:37
*** jamesmcarthur has joined #zuul06:57
*** jamesmcarthur has quit IRC07:03
*** tosky has joined #zuul07:12
*** themroc has joined #zuul07:15
*** pcaruana has quit IRC07:35
*** jpena|off is now known as jpena07:37
*** igordc has joined #zuul07:37
*** igordc has quit IRC07:38
*** mhu has joined #zuul08:02
*** electrofelix has joined #zuul08:03
*** pcaruana has joined #zuul08:13
*** mhu has quit IRC08:29
*** mhu1 has joined #zuul08:31
*** threestrands has quit IRC08:48
*** panda has quit IRC08:58
*** panda has joined #zuul08:59
*** mhu1 has quit IRC09:01
*** rfolco|ruck has joined #zuul09:17
*** mhu has joined #zuul09:36
*** sshnaidm|afk is now known as sshnaidm09:42
*** mhu has quit IRC10:03
*** jank has quit IRC10:10
*** hwangbo has quit IRC10:38
*** pcaruana has quit IRC10:45
*** sanjayu_ has joined #zuul11:07
*** jank has joined #zuul11:08
*** gtema_ has joined #zuul11:23
*** jpena is now known as jpena|lunch11:31
*** sanjayu_ has quit IRC11:50
*** jank has quit IRC11:54
*** pcaruana has joined #zuul12:10
*** rlandy has joined #zuul12:11
*** AshBullock has joined #zuul12:19
*** chandankumar has quit IRC12:27
*** chandankumar has joined #zuul12:28
*** jpena|lunch is now known as jpena12:31
*** AshBullock has quit IRC12:33
*** jamesmcarthur has joined #zuul12:46
*** jank has joined #zuul12:52
*** jank has quit IRC12:56
*** zxiiro has quit IRC13:16
*** zxiiro has joined #zuul13:18
*** jamesmcarthur has quit IRC13:55
*** jeliu_ has joined #zuul14:18
*** michael-beaver has joined #zuul14:24
corvusmordred: can you review https://review.opendev.org/673707 and https://review.opendev.org/673605 ?14:43
AJaegermorning corvus , want to merge the mirror documentation from https://review.opendev.org/669948 ? I can +2A if you want - Note that tobiash gave +2 but had a question, maybe as followup14:43
corvusclarkb: can you review https://review.opendev.org/673680 https://review.opendev.org/673688 and https://review.opendev.org/673707 ?14:43
corvusAJaeger, tobiash: that's a good question, and i don't know how to answer it since i don't have any experience with authenticated mirrors14:44
corvusanything that we put in that variable will be available to all jobs, so you have to trust them with that14:44
tobiashcorvus: I think that's mostly mirror type specific, some need a .netrc, some can be configured via e.g. pip config14:45
corvusbut then, i imagine that any mirror auth would be trivially recoverable by a job no matter what (eg just echo $HTTP_PROXY vars, regardless of how they are set)14:45
tobiashthat's true14:45
tobiashthat's the downside and unavoidable when working with authed stuff14:46
corvustobiash: so if we're okay putting auth information in that variable, then i think the structure can accomodate it... here, i'll write a comment on the change to illustrate14:46
tobiashcorvus: I think that makes sense14:47
tobiashone crazy idea for paranoid people would be to proxy the requests through a build specific proxy that authenticates against the real mirror...14:48
tobiashs/build/buildset14:48
corvusyeah, in that case, they should probably not use the site-wide variable14:49
AJaegercorvus: want to move this as is now and followup - or iterate on the change?14:50
corvusthey could have a job with a secret that sets up the buildset proxy, and then a role that uses the buildset credentials in the target jobs14:50
corvusAJaeger: let me finish up my comment on the change and make sure we're on the same page.  i don't think we have to solve everything, but i do want to make sure we aren't painting ourselves into a corner.14:50
AJaegersure14:51
corvustobiash, AJaeger: okay, updated -- take a look at that and tell me if it's sufficient14:53
tobiashcorvus: exactly like I would do it14:54
mordredclarkb: I approved https://review.opendev.org/#/c/673605 but left a comment for the future learning and edification14:55
mordredcorvus: (might be worth reading and deciding if we want to make a hard and fast rule about that with the linter)14:56
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302014:57
AJaegercorvus: will +2A now...14:57
corvusmordred: i left a followup question on that professor mordred14:57
mordredcorvus: I have responded14:59
corvussorry my question wasn't clear14:59
corvusis your recommendation to use "let x = null" if you don't have a value to assign it at the time?15:00
corvus(the fact that there is no initial value is why i suggested var instead of let in the first place)15:00
corvusoh, or are you saying just use "let x" with no assignment?15:01
mordredyes. you can totally do let x with no assignment15:02
corvusthat never would have occurred to me.  that is bonghits.15:02
corvusmordred: thanks for the edification!  i have learned learnings.15:02
mordredcorvus: you can ALSO do let x = null15:03
mordredalthough there is a difference - let x ; console.log(x) produces "undefined" - while let x = null ; console.log(x) produces "null"15:03
clarkbmordred: fwiw the jsx docs seem to use var exclusively15:03
clarkbnot sure if jsx has different var declaration semantics than js though15:04
mordredclarkb: it's probably just historical - jsx predates es615:04
openstackgerritTobias Henkel proposed zuul/zuul master: Optionally allow zoned executors to process unzoned jobs  https://review.opendev.org/67384015:11
openstackgerritMerged zuul/zuul-jobs master: Add mirror_info documentation  https://review.opendev.org/66994815:11
openstackgerritMonty Taylor proposed zuul/zuul master: Add linter rule disallowing use of var  https://review.opendev.org/67384115:13
mordredcorvus: ^^ if we want to enforce let-only - that's how we do it.15:16
tobiashmordred: when you have time it would be great if you could re-review https://review.opendev.org/652114 (smart reconfiguration). I had to rebase it to fix a merge conflict in the tests.15:18
*** jamesmcarthur has joined #zuul15:18
tobiashmaybe some github users are interested in squash merge support? https://review.opendev.org/661096 and parent15:20
tobiashSpamapS: ^15:20
mordredtobiash: all lgtm!15:24
tobiashcool :)15:25
tobiashthanks~15:25
openstackgerritMerged zuul/zuul master: js: correct action names  https://review.opendev.org/67368015:38
*** hwangbo has joined #zuul15:38
*** jamesmcarthur has quit IRC15:44
openstackgerritJames E. Blair proposed zuul/zuul master: Always record the log_url in sql reporter  https://review.opendev.org/67385815:46
*** bhavikdbavishi has quit IRC15:48
openstackgerritJeff Liu proposed zuul/zuul-operator master: Add telnet to Docker Image  https://review.opendev.org/67279115:49
openstackgerritMerged zuul/zuul master: js: don't transform json logfiles  https://review.opendev.org/67368815:50
openstackgerritJames E. Blair proposed zuul/zuul master: Handle artifacts without metadata on build page  https://review.opendev.org/67386015:56
openstackgerritJames E. Blair proposed zuul/zuul master: Handle artifacts without metadata on build page  https://review.opendev.org/67386016:00
openstackgerritJames E. Blair proposed zuul/zuul master: Try out reporting the build page  https://review.opendev.org/67386316:12
openstackgerritMerged zuul/zuul master: Cleanup extra /'s in manifest render view  https://review.opendev.org/67360516:17
*** electrofelix has quit IRC16:22
openstackgerritJames E. Blair proposed zuul/zuul master: Try out reporting the build page  https://review.opendev.org/67386316:24
corvusjeliu_: https://review.opendev.org/673020 passes!16:30
corvustristanC, mordred: ^ that change, the parent, and dependency should all be ready for review16:30
jeliu_corvus: :D !!!16:31
corvustristanC: we worked out how to use the buildset registry with k8s in that series; the short version is that we basically just configured docker on the k8s node in the way that we normally do for the buildset registry (it was mostly a matter of finding the right config file locations), and since k8s has docker do the image pulls, it works as normal.16:32
corvustristanC: maybe that approach will work for openshift?  if not, there's other things to explore.16:33
tristanCcorvus: i haven't looked into openshift^Wokd configuration yet, it should be possible to make the internal registry pull from a provided registry, not sure how easy that is though16:35
*** chandankumar is now known as raukadah16:36
*** igordc has joined #zuul16:36
mordredjeliu_: that all looks great, awesome!16:37
*** jamesmcarthur has joined #zuul16:38
*** panda has quit IRC16:39
jeliu_mordred: thanks!!16:40
openstackgerritMerged zuul/zuul master: Attempt to report CORS and related errors  https://review.opendev.org/67370716:41
*** panda has joined #zuul16:41
openstackgerritMerged zuul/zuul-operator master: Verify Operator Pod Running  https://review.opendev.org/67039516:47
*** jpena is now known as jpena|off16:57
*** gtema_ has quit IRC16:58
*** jamesmcarthur has quit IRC17:00
*** sshnaidm is now known as sshnaidm|afk17:00
openstackgerritMerged zuul/zuul-jobs master: Add auth config to kubelet user for buildset registries  https://review.opendev.org/67335117:01
openstackgerritMerged zuul/zuul master: Allow to select the merge method in Github  https://review.opendev.org/61794917:15
openstackgerritJames E. Blair proposed zuul/zuul master: Try out reporting the build page  https://review.opendev.org/67386317:16
*** gtema has joined #zuul17:18
openstackgerritMerged zuul/zuul master: Support squash merge in Github  https://review.opendev.org/66109617:20
toskycan I test a change against zuul/zuul-jobs, or is it a protected repository? I thought I remembered, but it looks like I have forgotten it17:25
fungizuul/zuul-jobs is a regular untrusted repository, so depends-on and the like work fine with it17:28
*** themroc has quit IRC17:29
toskythanks17:32
*** igordc has quit IRC17:32
fungiat least assuming you're asking about the opendev deployment of zuul17:32
fungii can't speak to whether other deployments of zuul might have it set as a trusted config repository (though that seems unlikely)17:33
toskythe opendev deployment, luckily17:33
clarkbtosky: fungi the one gotcha is if the roles are used by a job in a config repo. for example roles consumed by base17:37
clarkbupdates to those won't be self testing via the base job which is why we have base-test, you can update base-test all you want then reparent to that job to test17:38
toskyoh, I see; no, luckily my test job is a leaf17:39
openstackgerritMerged zuul/zuul master: Builds page - Fix bad labels display  https://review.opendev.org/67297317:40
openstackgerritLuigi Toscano proposed zuul/zuul-jobs master: fetch-subunit-output: collect additional subunit files  https://review.opendev.org/67388517:49
openstackgerritLuigi Toscano proposed zuul/zuul-jobs master: fetch-subunit-output: collect additional subunit files  https://review.opendev.org/67388517:49
*** sgw has quit IRC17:53
openstackgerritMerged zuul/zuul master: Fix reference pipelines syntax coloration for Pagure driver  https://review.opendev.org/67267717:57
fungijust a heads up, zuul is being removed from the cncf's "cloud-native landscape" owing to not having a viable github mirror any longer: https://github.com/cncf/landscape/pull/133518:08
fungii'm not especially concerned by that, but figured some folks may want to be aware of the change18:08
*** altlogbot_2 has quit IRC18:19
*** altlogbot_3 has joined #zuul18:21
mordredfungi, corvus: what do you think about responding to that with: http://paste.openstack.org/show/755187/18:23
openstackgerritMerged zuul/zuul master: Return dependency cycle failure to user  https://review.opendev.org/67248718:24
corvusmordred: personally, i don't think it requires a response18:25
fungimordred: meh. they've made it quite clear in previous exchanges that they're disinterested in tracking things outside github/twitter, but at one point said they would consider accepting patches of those were to a queryable api which listed activity metrics and "star/like/favorite" counts18:26
mordredfungi, corvus: good point - I'll just let it lie18:28
fungihow many stars something has is apparently a big deal in cncf land, they even use that measure to determine whether they're willing to accept a project into the cncf18:28
clarkbthe best part is there are companies from which you can buy stars18:28
clarkb<1USD/star too last I saw18:28
fungiat very reasonable prices, yes18:28
* fungi has no idea what a reasonable price for github stars is, but figures that must be one18:29
mordredI've always 'enjoyed' that "market cap" is one of the things they show18:29
mordredon a tracker showing open source projects18:29
*** gtema has quit IRC18:32
*** hwangbo has quit IRC18:36
*** igordc has joined #zuul18:36
openstackgerritMerged zuul/zuul master: Add Authorization Rules configuration  https://review.opendev.org/63985518:43
openstackgerritMerged zuul/zuul master: Web: plug the authorization engine  https://review.opendev.org/64088419:12
corvussee the future, today!  in  https://review.opendev.org/67386319:13
clarkbcorvus: can you set that per pipeline instead? wouldn't that be easier?19:15
corvusclarkb: no the pipelines only have success messages, not urls19:16
fungithat's slick!19:16
fungialso the error message is working like a charm19:16
clarkbcorvus: ah19:17
AJaegercorvus: in the past, it was one click to see html of docs - now it's one, scroll to bottom, another one - after figuring out that "docs_site" is the one I need to click on.19:18
AJaegerthere's a missing "/" on http://zuul.opendev.org/t/zuul/build/c40fbfc746ac4790bd7f56b147b168ba#logs19:19
AJaegerlink is http://zuul.opendev.org/t/zuul/build/c40fbfc746ac4790bd7f56b147b168badocs/ - should probably be a "/" before docs, shouldn't it?19:19
clarkboh hrm did my fix break that?19:20
corvusAJaeger: yeah, i'm planning for that to say "Docs preview site" in the future, so it's a little more obvious; that's waiting on https://review.opendev.org/672382 and parent19:20
clarkbugh19:20
clarkbhrm actually do we sometimes have a trailing / in the log url and sometimes not?19:20
clarkbtaht would explain it19:20
AJaegercorvus: yeah, that will help.19:21
corvusAJaeger: but yes, it'll be 2 clicks.  it's unfortunate, but i think unavoidable.  so i'm trying to make it as easy as possible to get to the second click19:21
corvusclarkb: hrm.  maybe we should normalize that in this change?  https://review.opendev.org/67385819:22
AJaegerhttp://zuul.opendev.org/t/zuul/build/45e9c8b97e1c44f695bea64350330705/log/job-output.txt looks broken to me, why is there html in it?19:22
corvuswe could try to handle both cases everywhere, or we could just have zuul assert that log urls always end with /19:22
clarkbcorvus: normalizing it probably isn't the worst thing19:22
fungii like the normalization idea19:23
clarkband force a trailing / ?19:23
corvusAJaeger: i have no idea what's up with that (also, when i followed the deep link, i got an error when it was trying to fetch the manifest)19:24
*** pabelanger has joined #zuul19:25
pabelangeryah, bouncer is back online19:25
fungipabelanger: did you catch the "big red error" on the zuul build pages now if privacy badger is blocking the fetches from logs.o.o?19:26
fungiit's snazzy19:26
openstackgerritJames E. Blair proposed zuul/zuul master: Always record the log_url in sql reporter  https://review.opendev.org/67385819:28
corvusk, that fixes tests and adds a trailing / if missing19:28
pabelangerfungi: yes, I see red X with 'network error check plugins, etc19:29
corvusAJaeger, clarkb: also the raw link for job-output.txt doesn't seem to link to logs.o.o19:29
corvusis that because of the lack of trailing / ?19:30
pabelangerfungi: however, privacy badger is green19:30
pabelangernot complaining about something being blocked19:30
corvusoh...19:30
corvusha19:30
corvusit's the success-url19:30
corvus673863 isn't going to fully work until we restart with 67385819:31
fungipabelanger: might be you're hitting https?19:31
corvusbecause it's going to try to fetch the manifest and logfiles from itself rather than the logserver, because the log_url is set to itself19:31
pabelangerfungi: yes, using https://zuul.o.o19:32
fungipabelanger: that's the issue. switch to http://19:32
pabelangerif I completely disable privacy badger, it still is blocked19:32
pabelangeroh19:32
fungiright now logs.o.o is only http19:33
pabelangerk19:33
fungiand your browser will automatically block http fetches from an https page19:33
pabelangeryah19:33
pabelangerokay cool, that explains it19:33
fungithe plan is to add a logs.opendev.org vhost with letsencrypt supplied https cert19:35
fungiand then we can pull from there in zuul.opendev.org19:35
fungiof course, that will likely also make your privacy badger go green because it's no longer requesting data from an openstack.org domain19:36
pabelangerack, thanks for info19:37
pabelangerjlk: do you think it is still possible to get a new release of github3.py? re: https://github.com/sigmavirus24/github3.py/issues/95119:37
openstackgerritLuigi Toscano proposed zuul/zuul-jobs master: fetch-subunit-output: collect additional subunit files  https://review.opendev.org/67388519:38
openstackgerritMerged zuul/zuul master: Handle artifacts without metadata on build page  https://review.opendev.org/67386019:48
pabelangerFYI: https://review.opendev.org/673304/ switches the zuul tenant to use ansible 2.8 for jobs. I did my best to test out all our jobs, but figure if we want to merge it we should prepare for chance of a job failing.  But, think that is pretty low19:50
fungiis 2.8 a less disruptive update than 2.7 was?19:51
fungithough now i don't recall what we ran into with 2.719:51
pabelangeryah, I haven't seen any issue with 2.8 so far19:52
pabelanger2.7 was pretty good too19:52
pabelangerthey are getting better and making releases more stable19:52
*** tributarian has joined #zuul20:24
clarkbcorvus: note on the sql reporter change, but lgtm20:33
clarkbit just failed unitesting, fun20:36
*** fdegir has quit IRC21:07
openstackgerritJames E. Blair proposed zuul/zuul master: Always record the log_url in sql reporter  https://review.opendev.org/67385821:24
corvusclarkb: i think that should get it21:25
*** jeliu_ has quit IRC21:45
*** tosky has quit IRC22:13
*** rlandy is now known as rlandy|bbl22:19
*** armstrongs has joined #zuul22:24
*** armstrongs has quit IRC22:37
openstackgerritMerged zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302022:50
*** threestrands has joined #zuul22:55
*** panda has quit IRC23:03
*** panda has joined #zuul23:04
*** cixx_ has joined #zuul23:10
*** cixx has quit IRC23:13
*** jamesmcarthur has joined #zuul23:22
openstackgerritMerged zuul/zuul master: Always record the log_url in sql reporter  https://review.opendev.org/67385823:40

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!