Friday, 2019-07-26

*** jamesmcarthur has joined #zuul00:03
*** mattw4 has quit IRC00:03
*** jamesmcarthur has quit IRC00:06
*** jamesmcarthur has joined #zuul00:06
*** yolanda has quit IRC00:20
*** igordc has quit IRC00:45
*** swest has quit IRC01:20
*** jamesmcarthur has quit IRC01:30
*** swest has joined #zuul01:35
*** migi has quit IRC02:32
*** bjackman has joined #zuul02:48
*** jamesmcarthur has joined #zuul02:59
*** EmilienM|pto is now known as EmilienM03:01
*** bhavikdbavishi has joined #zuul03:13
*** bjackman has quit IRC03:15
*** bjackman has joined #zuul03:25
*** michael-beaver has quit IRC03:32
*** bhavikdbavishi1 has joined #zuul03:46
*** bhavikdbavishi has quit IRC03:48
*** bhavikdbavishi1 is now known as bhavikdbavishi03:48
*** jamesmcarthur has quit IRC04:32
*** swest has quit IRC04:34
*** swest has joined #zuul05:18
*** swest has joined #zuul05:20
*** zbr has joined #zuul05:44
*** jamesmcarthur has joined #zuul05:45
*** jamesmcarthur has quit IRC06:33
*** rlandy has joined #zuul06:47
*** jpena|off is now known as jpena06:51
*** jpena is now known as jpena|mtg06:51
*** raukadah is now known as chandankumar06:51
*** bhavikdbavishi has quit IRC07:26
*** tosky has joined #zuul07:34
*** pcaruana has joined #zuul07:44
*** bhavikdbavishi has joined #zuul07:54
*** bhavikdbavishi has quit IRC08:47
*** bhavikdbavishi has joined #zuul08:56
*** bhavikdbavishi has quit IRC09:17
*** arxcruz is now known as arxcruz|off09:32
*** bjackman has quit IRC09:45
openstackgerritSimon Westphahl proposed zuul/zuul master: Spec for allowing circular dependencies  https://review.opendev.org/64330909:49
*** rlandy has quit IRC10:03
*** EmilienM has quit IRC11:27
*** EmilienM has joined #zuul11:28
*** swest has quit IRC11:34
*** irclogbot_3 has quit IRC11:53
*** irclogbot_0 has joined #zuul11:56
*** bhavikdbavishi has joined #zuul12:07
*** bhavikdbavishi1 has joined #zuul12:09
*** bhavikdbavishi has quit IRC12:11
*** bhavikdbavishi1 is now known as bhavikdbavishi12:11
openstackgerritTristan Cacqueray proposed zuul/zuul master: manager: specify report failure in logs  https://review.opendev.org/67176012:31
*** jpena|mtg is now known as jpena|off12:47
openstackgerritFabien Boucher proposed zuul/zuul master: Builds page - Fix bad labels display  https://review.opendev.org/67297312:59
*** bhavikdbavishi has quit IRC12:59
mordredcorvus: I haven't started playing with react-lazylog yet this morning - but if it does 80% of what we need, maybe we can either subclass it (?? does that work) or fork it, improve it and offer those back upstream - I also like the "able to load large files without crashing the browser"13:05
*** bhavikdbavishi has joined #zuul13:18
*** jpena|off is now known as jpena13:19
*** bhavikdbavishi has quit IRC13:35
*** michael-beaver has joined #zuul13:38
*** jpena is now known as jpena|off13:38
Shrewscorvus: would like your eyes on https://review.opendev.org/672196 since you have a similar change up13:59
mordredShrews: oh- which is corvus'?14:03
Shrewsmordred: https://review.opendev.org/66617714:11
mordredShrews: ah - nod14:13
corvusShrews, ianw: thanks -- i have only a minor, but important _ vs - suggestion on that14:19
corvusand yeah, i think ianw's change clears the path for mine14:20
Shrewsah yeah. consistency ftw14:20
mordredcorvus: I agree with your suggestion14:20
pabelangerOooh, 672196 is a welcome change14:21
corvusoh lazylog is from moz14:22
openstackgerritJames E. Blair proposed zuul/zuul master: Add react-lazylog package  https://review.opendev.org/67298814:23
corvusthat just adds the package; haven't used it yet14:24
*** bhavikdbavishi has joined #zuul14:25
*** jeliu_ has joined #zuul14:33
openstackgerritJames E. Blair proposed zuul/zuul master: WIP: try lazylog  https://review.opendev.org/67299114:34
corvusmordred: hrm, that should do it.  i'm not seeing any output though.  it is fetching the logfile and rendering the container div.  just no log lines14:35
mordredhrm indeed14:36
mordredcorvus: maybe the auto height and width can't figure themselves out?14:38
corvusyep that's it14:38
corvusstuck in a div with explicit numbers and it worked14:38
mordredwoot14:39
openstackgerritGraham Hayes proposed zuul/nodepool master: Implement an Azure driver  https://review.opendev.org/55443214:39
mordred(obviously figuring out how to make it more reactive to the surrounding container is probably a better bet - but we can sort that out independently I'm sure)14:39
corvusyeah... height: 100% isn't working...14:40
*** jamesmcarthur has joined #zuul14:43
*** chandankumar is now known as raukadah14:48
*** openstackgerrit has quit IRC14:51
*** openstackgerrit has joined #zuul14:52
openstackgerritJames E. Blair proposed zuul/zuul master: WIP: try lazylog  https://review.opendev.org/67299114:52
corvusokay, that will actually show you something14:53
corvusmordred: on the plus side: line numbers, highlighting if you click on a line, and ansi parsing.  on the minus side: no severity handling, doesn't seem to generate anchors for deep linking, blanks when i scroll.14:56
clarkbif you ^F does it search the whole document or only what is rendered?14:57
corvusthat last one sounds minory, but is really kind of crippling14:57
clarkbthis is my biggest gripe with travis style logs (hard to search)14:58
corvusclarkb: whole thing14:58
corvusokay, the scrolling/blank thing has to do with whether it's rendered a part before and how fast i scroll15:00
corvusif you don't scroll too fast, it's normalish15:00
corvuswe'd also need to figure out horizontal scrolling, since the interesting part of our logs start about 600 pixels from the left15:03
corvusi think we can do the line anchor stuff ourself15:04
corvusbasically, when the highlight changes, update the url fragment; and when the page loads, use the url fragment to set the highlighted line15:05
mordredyeah15:05
mordredcorvus: looking through the code, it seems like making a pluggable line parser (right now it just hardcode calls ansiparse) would be where we'd want to do things like severity handling15:08
mordredhttps://github.com/mozilla-frontend-infra/react-lazylog/blob/master/src/components/LazyLog/index.jsx#L561 <-- but ... that's in the "renderRow" method which isn't super big - so maybe a subclass of Lazylog that overrides renderRow wouldn't be super terrible15:10
*** bhavikdbavishi has quit IRC15:10
corvusmordred: yeah, i was also looking at formatPart... i think we could use that to highlight severity by color, but i don't think we can use it to filter out lines15:14
corvusi think we'd have to override renderRow for that15:14
mordredyeah. and possibly make a subclass of Line on which we can store the severity property15:14
corvusmordred, clarkb: http://logs.openstack.org/91/672991/2/check/zuul-build-dashboard/0a9397a/npm/html/status  is ready if you want to try it15:16
*** jamesmcarthur has quit IRC15:17
mordredthe highlighting is nice15:17
clarkbcorvus: looks like the last row(s) at the bottom of job-output.txt are cut off by the horizontal scroll bar?15:17
clarkband ^F doesn't seem to search the whole document for me15:18
mordredyou have a horizontal scroll bar?15:18
clarkbmordred: if I scroll to the bottom I do15:18
clarkbit isn't there at the top15:18
mordredah15:18
clarkb(or in the middle)15:18
clarkbother oddity is the window size isn't to the bottom of my page (this is the thing I had to modify to update xterm so maybe same bug we are working around there?)15:19
mordredfinger swiping scrolls horizontally everywhere - so that works. I agree on ^F15:19
mordredclarkb: for now the div is set to a static size because size='auto' didn't work15:20
clarkbmordred: ya I think that is known to break with xterm15:20
clarkblet me get a link to the code I had to modify for updating xterm that handles this15:20
mordredcool15:20
clarkbhttps://opendev.org/zuul/zuul/src/branch/master/web/src/pages/Stream.jsx#L65-L8115:21
*** jamesmcarthur has joined #zuul15:21
corvusi also agree about ^F i'm not sure what i was seeing before... perhaps i happened to be searching for something that was in the overscan buffer15:22
clarkbthe general functionality seems to work well. Once loaded the document is quick to scroll (maybe even faster than when you view the raw log directly in the browser?)15:22
corvusyou can go back to http://logs.openstack.org/39/672839/1/check/zuul-build-dashboard/6d2cae9/npm/html/ and compare15:22
clarkbthe horizontal scroll bar seems to show up when I scroll to the last line. It also covers that last line15:25
clarkbhowever it doesn't have a the little scroll position bar (the inner indicator bar). Could be this is some other type of artifact that looks like a scrollbar15:26
corvusthere's an option to add an extra line, may take care of that last part15:26
*** noorul has joined #zuul15:41
noorulhi15:41
noorulDoes Zuul has driver for Atlassian Stash?15:41
corvusnoorul: no, but there's a bitbucket driver in progress15:51
noorulcorvus: Is it in usable state?15:53
noorulcorvus: Is there pull request or review?15:53
corvusnoorul: close -- the patch series starts here: https://review.opendev.org/657837   ofosos has been working on it15:54
corvusclarkb, mordred: i'm feeling like there's too much to do with lazylog and i kinda want to try adding severity to the simple stuff i have in 672839.  i'm not opposed to it if someone wants to tackle it, but i'm not convinced it's enough of a win to spend several days getting the basics working.16:00
corvus(too lazy for lazylog)16:01
openstackgerritGraham Hayes proposed zuul/nodepool master: Implement an Azure driver  https://review.opendev.org/55443216:01
clarkbI'll have to defer to you on that as I have no idea how to judge effort in js16:01
pabelangerWe just upgraded zuul executors for zuul.a.c to use ansible 2.8.3, so far we've had zero issues using ansible 2.8. I'd like to see how I could help make that the default choice for zuul now.  IIRC, we'd need to make the switch in opendev too first16:03
corvuspabelanger: i don't think we need to switch opendev first.  it's just another zuul user.  however, it might be good to do so in order to find out if it's really a good idea to switch the default.  if opendev has problems, other folks may.16:06
pabelangeractually, we could switch zuul tenant16:06
corvusyeah, could do one tenant at a time16:06
pabelangerack, let me propose that and see what happens16:07
pabelangerbut yah, would be nice to have another zuul on 2.816:07
pabelangerI'll send out ML post asking16:07
corvus++16:07
*** jamesmcarthur has quit IRC16:15
*** jamesmcarthur has joined #zuul16:16
*** mattw4 has joined #zuul16:17
*** jamesmcarthur has quit IRC16:21
*** noorul has quit IRC16:23
mordredcorvus: I agree re: too much re: lazylog16:25
mordredcorvus: I think it might could be a nice project for someone in the future - but it seems like it'll be a project16:25
corvusyeah.  if/when someone rips out what i'm writing now and replaces it with that because it's awesome, i'll cheer16:26
*** jamesmcarthur has joined #zuul16:31
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: DNM: Switch unitests to use base-test  https://review.opendev.org/67301416:35
*** jamesmcarthur has quit IRC16:36
*** jamesmcarthur has joined #zuul16:36
openstackgerritPaul Belanger proposed zuul/nodepool master: DNM: testing ansible 2.8 jobs  https://review.opendev.org/67301516:36
jeliu_te16:36
jeliu_^accident16:37
openstackgerritPaul Belanger proposed zuul/zuul master: DNM: testing ansible 2.8 jobs  https://review.opendev.org/67301616:37
openstackgerritJames E. Blair proposed zuul/zuul master: Add severity filtering to logs  https://review.opendev.org/67283916:46
corvusclarkb, mordred: ^ the downside compared to osla is that the client has to download the whole file; the upside is that it's now really fast switching between severity levels.16:47
openstackgerritJames E. Blair proposed zuul/zuul master: Add severity filtering to logs  https://review.opendev.org/67283916:49
corvusalso, line numbers are stable even if you change severity levels16:53
*** mattw4 has quit IRC16:54
*** hwangbo has joined #zuul16:55
*** mattw4 has joined #zuul16:58
corvusmordred, clarkb: http://logs.openstack.org/39/672839/3/check/zuul-build-dashboard/582cbe1/npm/html/status is the latest17:00
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302017:01
corvusmordred, clarkb: http://logs.openstack.org/39/672839/3/check/zuul-build-dashboard/582cbe1/npm/html17:01
corvussorry :)17:01
clarkbthat fixes the bottom scroll bar and ^F for me17:01
corvusclarkb: that's my simple version, not lazylog17:02
corvusclarkb: what do you think of the severity filtering?17:02
clarkbyup I know just pointing out your thing addresses the problems I had with the last one17:02
*** jangutter has quit IRC17:02
corvusah k17:02
clarkblet me find a log file that has severity in it17:02
clarkbseems to work on nova compute logs17:03
corvuslibvirt is the crazy big log right?17:05
clarkbyes, but I don't remember if it does severity?17:05
corvusit does have severity, but i don't think the osla regexes will catch it17:06
fungiwell, mysql query log was the insanely big one, but we convinced folks to turn that back off17:06
corvusthe libvirt log is slow to appear, but it does work for me17:06
*** jamesmcarthur has quit IRC17:08
*** igordc has joined #zuul17:34
*** igordc has quit IRC17:36
*** igordc has joined #zuul17:36
*** electrofelix has quit IRC17:38
*** mattw4 has quit IRC18:02
*** mattw4 has joined #zuul18:02
*** mattw4 has quit IRC18:46
*** mattw4 has joined #zuul18:51
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: DNM: Switch unitests to use base-test  https://review.opendev.org/67301419:15
openstackgerritPaul Belanger proposed zuul/zuul master: DNM: testing ansible 2.8 jobs  https://review.opendev.org/67301619:18
openstackgerritPaul Belanger proposed zuul/nodepool master: DNM: testing ansible 2.8 jobs  https://review.opendev.org/67301519:18
*** igordc has quit IRC19:37
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302019:50
openstackgerritJeff Liu proposed zuul/zuul-operator master: Verify Operator Pod Running  https://review.opendev.org/67039519:55
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302019:55
openstackgerritJames E. Blair proposed zuul/zuul master: Colorize log severity  https://review.opendev.org/67310320:09
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302020:09
*** igordc has joined #zuul20:10
openstackgerritPaul Belanger proposed zuul/nodepool master: DNM: testing ansible 2.8 jobs  https://review.opendev.org/67301520:11
*** sgw has joined #zuul20:12
pabelanger2.8 jobs looks to be working in zuul tenant, however because we don't have a zuul tenant base job, it's a little harder to ensure all jobs have ansible-version set to 2.820:14
pabelangerwhich means, even if we wanted to move to 2.8, we'd have to solve that issue first20:15
pabelangerotherwise, changing it in opendev base job, also affects other tenants20:15
pabelangerit also looks like we are running 2.8.0, not latest 2.8.320:16
pabelangerhaven't looked why yet20:16
corvuspabelanger: you can set the default on a per-tenant basis20:18
corvushttps://zuul-ci.org/docs/zuul/admin/tenants.html#attr-tenant.default-ansible-version20:19
pabelangerOh, that would work too. Forgot, I was thinking setting it via job20:20
pabelangerthanks!20:20
openstackgerritJames E. Blair proposed zuul/zuul master: Add raw links to log manifest  https://review.opendev.org/67310420:25
openstackgerritJames E. Blair proposed zuul/zuul master: Rename view to logfile  https://review.opendev.org/67310520:25
*** jeliu_ has quit IRC20:26
corvusmordred, clarkb, tristanC: ^ i think that about wraps it up.  i'm going to stop doing new development on that.  i think we can review/modify/merge at will.20:27
mordredcorvus: sweet!20:30
*** jeliu_ has joined #zuul20:31
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302020:47
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302021:02
*** rfolco|rover has quit IRC21:30
openstackgerritJeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test  https://review.opendev.org/67302021:30
*** jeliu_ has quit IRC21:50
*** mattw4 has quit IRC21:53
*** jamesmcarthur has joined #zuul21:55
*** jamesmcarthur has quit IRC22:15
*** michael-beaver has quit IRC22:27
*** mattw4 has joined #zuul22:38
*** jamesmcarthur has joined #zuul22:45
*** jamesmcarthur has quit IRC23:00
*** jamesmcarthur has joined #zuul23:10
*** tosky has quit IRC23:31
*** jamesmcarthur has quit IRC23:42
*** mattw4 has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!