*** jamesmcarthur has joined #zuul | 00:03 | |
*** mattw4 has quit IRC | 00:03 | |
*** jamesmcarthur has quit IRC | 00:06 | |
*** jamesmcarthur has joined #zuul | 00:06 | |
*** yolanda has quit IRC | 00:20 | |
*** igordc has quit IRC | 00:45 | |
*** swest has quit IRC | 01:20 | |
*** jamesmcarthur has quit IRC | 01:30 | |
*** swest has joined #zuul | 01:35 | |
*** migi has quit IRC | 02:32 | |
*** bjackman has joined #zuul | 02:48 | |
*** jamesmcarthur has joined #zuul | 02:59 | |
*** EmilienM|pto is now known as EmilienM | 03:01 | |
*** bhavikdbavishi has joined #zuul | 03:13 | |
*** bjackman has quit IRC | 03:15 | |
*** bjackman has joined #zuul | 03:25 | |
*** michael-beaver has quit IRC | 03:32 | |
*** bhavikdbavishi1 has joined #zuul | 03:46 | |
*** bhavikdbavishi has quit IRC | 03:48 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:48 | |
*** jamesmcarthur has quit IRC | 04:32 | |
*** swest has quit IRC | 04:34 | |
*** swest has joined #zuul | 05:18 | |
*** swest has joined #zuul | 05:20 | |
*** zbr has joined #zuul | 05:44 | |
*** jamesmcarthur has joined #zuul | 05:45 | |
*** jamesmcarthur has quit IRC | 06:33 | |
*** rlandy has joined #zuul | 06:47 | |
*** jpena|off is now known as jpena | 06:51 | |
*** jpena is now known as jpena|mtg | 06:51 | |
*** raukadah is now known as chandankumar | 06:51 | |
*** bhavikdbavishi has quit IRC | 07:26 | |
*** tosky has joined #zuul | 07:34 | |
*** pcaruana has joined #zuul | 07:44 | |
*** bhavikdbavishi has joined #zuul | 07:54 | |
*** bhavikdbavishi has quit IRC | 08:47 | |
*** bhavikdbavishi has joined #zuul | 08:56 | |
*** bhavikdbavishi has quit IRC | 09:17 | |
*** arxcruz is now known as arxcruz|off | 09:32 | |
*** bjackman has quit IRC | 09:45 | |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Spec for allowing circular dependencies https://review.opendev.org/643309 | 09:49 |
---|---|---|
*** rlandy has quit IRC | 10:03 | |
*** EmilienM has quit IRC | 11:27 | |
*** EmilienM has joined #zuul | 11:28 | |
*** swest has quit IRC | 11:34 | |
*** irclogbot_3 has quit IRC | 11:53 | |
*** irclogbot_0 has joined #zuul | 11:56 | |
*** bhavikdbavishi has joined #zuul | 12:07 | |
*** bhavikdbavishi1 has joined #zuul | 12:09 | |
*** bhavikdbavishi has quit IRC | 12:11 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 12:11 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: manager: specify report failure in logs https://review.opendev.org/671760 | 12:31 |
*** jpena|mtg is now known as jpena|off | 12:47 | |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Builds page - Fix bad labels display https://review.opendev.org/672973 | 12:59 |
*** bhavikdbavishi has quit IRC | 12:59 | |
mordred | corvus: I haven't started playing with react-lazylog yet this morning - but if it does 80% of what we need, maybe we can either subclass it (?? does that work) or fork it, improve it and offer those back upstream - I also like the "able to load large files without crashing the browser" | 13:05 |
*** bhavikdbavishi has joined #zuul | 13:18 | |
*** jpena|off is now known as jpena | 13:19 | |
*** bhavikdbavishi has quit IRC | 13:35 | |
*** michael-beaver has joined #zuul | 13:38 | |
*** jpena is now known as jpena|off | 13:38 | |
Shrews | corvus: would like your eyes on https://review.opendev.org/672196 since you have a similar change up | 13:59 |
mordred | Shrews: oh- which is corvus'? | 14:03 |
Shrews | mordred: https://review.opendev.org/666177 | 14:11 |
mordred | Shrews: ah - nod | 14:13 |
corvus | Shrews, ianw: thanks -- i have only a minor, but important _ vs - suggestion on that | 14:19 |
corvus | and yeah, i think ianw's change clears the path for mine | 14:20 |
Shrews | ah yeah. consistency ftw | 14:20 |
mordred | corvus: I agree with your suggestion | 14:20 |
pabelanger | Oooh, 672196 is a welcome change | 14:21 |
corvus | oh lazylog is from moz | 14:22 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Add react-lazylog package https://review.opendev.org/672988 | 14:23 |
corvus | that just adds the package; haven't used it yet | 14:24 |
*** bhavikdbavishi has joined #zuul | 14:25 | |
*** jeliu_ has joined #zuul | 14:33 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: try lazylog https://review.opendev.org/672991 | 14:34 |
corvus | mordred: hrm, that should do it. i'm not seeing any output though. it is fetching the logfile and rendering the container div. just no log lines | 14:35 |
mordred | hrm indeed | 14:36 |
mordred | corvus: maybe the auto height and width can't figure themselves out? | 14:38 |
corvus | yep that's it | 14:38 |
corvus | stuck in a div with explicit numbers and it worked | 14:38 |
mordred | woot | 14:39 |
openstackgerrit | Graham Hayes proposed zuul/nodepool master: Implement an Azure driver https://review.opendev.org/554432 | 14:39 |
mordred | (obviously figuring out how to make it more reactive to the surrounding container is probably a better bet - but we can sort that out independently I'm sure) | 14:39 |
corvus | yeah... height: 100% isn't working... | 14:40 |
*** jamesmcarthur has joined #zuul | 14:43 | |
*** chandankumar is now known as raukadah | 14:48 | |
*** openstackgerrit has quit IRC | 14:51 | |
*** openstackgerrit has joined #zuul | 14:52 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: try lazylog https://review.opendev.org/672991 | 14:52 |
corvus | okay, that will actually show you something | 14:53 |
corvus | mordred: on the plus side: line numbers, highlighting if you click on a line, and ansi parsing. on the minus side: no severity handling, doesn't seem to generate anchors for deep linking, blanks when i scroll. | 14:56 |
clarkb | if you ^F does it search the whole document or only what is rendered? | 14:57 |
corvus | that last one sounds minory, but is really kind of crippling | 14:57 |
clarkb | this is my biggest gripe with travis style logs (hard to search) | 14:58 |
corvus | clarkb: whole thing | 14:58 |
corvus | okay, the scrolling/blank thing has to do with whether it's rendered a part before and how fast i scroll | 15:00 |
corvus | if you don't scroll too fast, it's normalish | 15:00 |
corvus | we'd also need to figure out horizontal scrolling, since the interesting part of our logs start about 600 pixels from the left | 15:03 |
corvus | i think we can do the line anchor stuff ourself | 15:04 |
corvus | basically, when the highlight changes, update the url fragment; and when the page loads, use the url fragment to set the highlighted line | 15:05 |
mordred | yeah | 15:05 |
mordred | corvus: looking through the code, it seems like making a pluggable line parser (right now it just hardcode calls ansiparse) would be where we'd want to do things like severity handling | 15:08 |
mordred | https://github.com/mozilla-frontend-infra/react-lazylog/blob/master/src/components/LazyLog/index.jsx#L561 <-- but ... that's in the "renderRow" method which isn't super big - so maybe a subclass of Lazylog that overrides renderRow wouldn't be super terrible | 15:10 |
*** bhavikdbavishi has quit IRC | 15:10 | |
corvus | mordred: yeah, i was also looking at formatPart... i think we could use that to highlight severity by color, but i don't think we can use it to filter out lines | 15:14 |
corvus | i think we'd have to override renderRow for that | 15:14 |
mordred | yeah. and possibly make a subclass of Line on which we can store the severity property | 15:14 |
corvus | mordred, clarkb: http://logs.openstack.org/91/672991/2/check/zuul-build-dashboard/0a9397a/npm/html/status is ready if you want to try it | 15:16 |
*** jamesmcarthur has quit IRC | 15:17 | |
mordred | the highlighting is nice | 15:17 |
clarkb | corvus: looks like the last row(s) at the bottom of job-output.txt are cut off by the horizontal scroll bar? | 15:17 |
clarkb | and ^F doesn't seem to search the whole document for me | 15:18 |
mordred | you have a horizontal scroll bar? | 15:18 |
clarkb | mordred: if I scroll to the bottom I do | 15:18 |
clarkb | it isn't there at the top | 15:18 |
mordred | ah | 15:18 |
clarkb | (or in the middle) | 15:18 |
clarkb | other oddity is the window size isn't to the bottom of my page (this is the thing I had to modify to update xterm so maybe same bug we are working around there?) | 15:19 |
mordred | finger swiping scrolls horizontally everywhere - so that works. I agree on ^F | 15:19 |
mordred | clarkb: for now the div is set to a static size because size='auto' didn't work | 15:20 |
clarkb | mordred: ya I think that is known to break with xterm | 15:20 |
clarkb | let me get a link to the code I had to modify for updating xterm that handles this | 15:20 |
mordred | cool | 15:20 |
clarkb | https://opendev.org/zuul/zuul/src/branch/master/web/src/pages/Stream.jsx#L65-L81 | 15:21 |
*** jamesmcarthur has joined #zuul | 15:21 | |
corvus | i also agree about ^F i'm not sure what i was seeing before... perhaps i happened to be searching for something that was in the overscan buffer | 15:22 |
clarkb | the general functionality seems to work well. Once loaded the document is quick to scroll (maybe even faster than when you view the raw log directly in the browser?) | 15:22 |
corvus | you can go back to http://logs.openstack.org/39/672839/1/check/zuul-build-dashboard/6d2cae9/npm/html/ and compare | 15:22 |
clarkb | the horizontal scroll bar seems to show up when I scroll to the last line. It also covers that last line | 15:25 |
clarkb | however it doesn't have a the little scroll position bar (the inner indicator bar). Could be this is some other type of artifact that looks like a scrollbar | 15:26 |
corvus | there's an option to add an extra line, may take care of that last part | 15:26 |
*** noorul has joined #zuul | 15:41 | |
noorul | hi | 15:41 |
noorul | Does Zuul has driver for Atlassian Stash? | 15:41 |
corvus | noorul: no, but there's a bitbucket driver in progress | 15:51 |
noorul | corvus: Is it in usable state? | 15:53 |
noorul | corvus: Is there pull request or review? | 15:53 |
corvus | noorul: close -- the patch series starts here: https://review.opendev.org/657837 ofosos has been working on it | 15:54 |
corvus | clarkb, mordred: i'm feeling like there's too much to do with lazylog and i kinda want to try adding severity to the simple stuff i have in 672839. i'm not opposed to it if someone wants to tackle it, but i'm not convinced it's enough of a win to spend several days getting the basics working. | 16:00 |
corvus | (too lazy for lazylog) | 16:01 |
openstackgerrit | Graham Hayes proposed zuul/nodepool master: Implement an Azure driver https://review.opendev.org/554432 | 16:01 |
clarkb | I'll have to defer to you on that as I have no idea how to judge effort in js | 16:01 |
pabelanger | We just upgraded zuul executors for zuul.a.c to use ansible 2.8.3, so far we've had zero issues using ansible 2.8. I'd like to see how I could help make that the default choice for zuul now. IIRC, we'd need to make the switch in opendev too first | 16:03 |
corvus | pabelanger: i don't think we need to switch opendev first. it's just another zuul user. however, it might be good to do so in order to find out if it's really a good idea to switch the default. if opendev has problems, other folks may. | 16:06 |
pabelanger | actually, we could switch zuul tenant | 16:06 |
corvus | yeah, could do one tenant at a time | 16:06 |
pabelanger | ack, let me propose that and see what happens | 16:07 |
pabelanger | but yah, would be nice to have another zuul on 2.8 | 16:07 |
pabelanger | I'll send out ML post asking | 16:07 |
corvus | ++ | 16:07 |
*** jamesmcarthur has quit IRC | 16:15 | |
*** jamesmcarthur has joined #zuul | 16:16 | |
*** mattw4 has joined #zuul | 16:17 | |
*** jamesmcarthur has quit IRC | 16:21 | |
*** noorul has quit IRC | 16:23 | |
mordred | corvus: I agree re: too much re: lazylog | 16:25 |
mordred | corvus: I think it might could be a nice project for someone in the future - but it seems like it'll be a project | 16:25 |
corvus | yeah. if/when someone rips out what i'm writing now and replaces it with that because it's awesome, i'll cheer | 16:26 |
*** jamesmcarthur has joined #zuul | 16:31 | |
openstackgerrit | Paul Belanger proposed zuul/zuul-jobs master: DNM: Switch unitests to use base-test https://review.opendev.org/673014 | 16:35 |
*** jamesmcarthur has quit IRC | 16:36 | |
*** jamesmcarthur has joined #zuul | 16:36 | |
openstackgerrit | Paul Belanger proposed zuul/nodepool master: DNM: testing ansible 2.8 jobs https://review.opendev.org/673015 | 16:36 |
jeliu_ | te | 16:36 |
jeliu_ | ^accident | 16:37 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: DNM: testing ansible 2.8 jobs https://review.opendev.org/673016 | 16:37 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Add severity filtering to logs https://review.opendev.org/672839 | 16:46 |
corvus | clarkb, mordred: ^ the downside compared to osla is that the client has to download the whole file; the upside is that it's now really fast switching between severity levels. | 16:47 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Add severity filtering to logs https://review.opendev.org/672839 | 16:49 |
corvus | also, line numbers are stable even if you change severity levels | 16:53 |
*** mattw4 has quit IRC | 16:54 | |
*** hwangbo has joined #zuul | 16:55 | |
*** mattw4 has joined #zuul | 16:58 | |
corvus | mordred, clarkb: http://logs.openstack.org/39/672839/3/check/zuul-build-dashboard/582cbe1/npm/html/status is the latest | 17:00 |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 17:01 |
corvus | mordred, clarkb: http://logs.openstack.org/39/672839/3/check/zuul-build-dashboard/582cbe1/npm/html | 17:01 |
corvus | sorry :) | 17:01 |
clarkb | that fixes the bottom scroll bar and ^F for me | 17:01 |
corvus | clarkb: that's my simple version, not lazylog | 17:02 |
corvus | clarkb: what do you think of the severity filtering? | 17:02 |
clarkb | yup I know just pointing out your thing addresses the problems I had with the last one | 17:02 |
*** jangutter has quit IRC | 17:02 | |
corvus | ah k | 17:02 |
clarkb | let me find a log file that has severity in it | 17:02 |
clarkb | seems to work on nova compute logs | 17:03 |
corvus | libvirt is the crazy big log right? | 17:05 |
clarkb | yes, but I don't remember if it does severity? | 17:05 |
corvus | it does have severity, but i don't think the osla regexes will catch it | 17:06 |
fungi | well, mysql query log was the insanely big one, but we convinced folks to turn that back off | 17:06 |
corvus | the libvirt log is slow to appear, but it does work for me | 17:06 |
*** jamesmcarthur has quit IRC | 17:08 | |
*** igordc has joined #zuul | 17:34 | |
*** igordc has quit IRC | 17:36 | |
*** igordc has joined #zuul | 17:36 | |
*** electrofelix has quit IRC | 17:38 | |
*** mattw4 has quit IRC | 18:02 | |
*** mattw4 has joined #zuul | 18:02 | |
*** mattw4 has quit IRC | 18:46 | |
*** mattw4 has joined #zuul | 18:51 | |
openstackgerrit | Paul Belanger proposed zuul/zuul-jobs master: DNM: Switch unitests to use base-test https://review.opendev.org/673014 | 19:15 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: DNM: testing ansible 2.8 jobs https://review.opendev.org/673016 | 19:18 |
openstackgerrit | Paul Belanger proposed zuul/nodepool master: DNM: testing ansible 2.8 jobs https://review.opendev.org/673015 | 19:18 |
*** igordc has quit IRC | 19:37 | |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 19:50 |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: Verify Operator Pod Running https://review.opendev.org/670395 | 19:55 |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 19:55 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Colorize log severity https://review.opendev.org/673103 | 20:09 |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 20:09 |
*** igordc has joined #zuul | 20:10 | |
openstackgerrit | Paul Belanger proposed zuul/nodepool master: DNM: testing ansible 2.8 jobs https://review.opendev.org/673015 | 20:11 |
*** sgw has joined #zuul | 20:12 | |
pabelanger | 2.8 jobs looks to be working in zuul tenant, however because we don't have a zuul tenant base job, it's a little harder to ensure all jobs have ansible-version set to 2.8 | 20:14 |
pabelanger | which means, even if we wanted to move to 2.8, we'd have to solve that issue first | 20:15 |
pabelanger | otherwise, changing it in opendev base job, also affects other tenants | 20:15 |
pabelanger | it also looks like we are running 2.8.0, not latest 2.8.3 | 20:16 |
pabelanger | haven't looked why yet | 20:16 |
corvus | pabelanger: you can set the default on a per-tenant basis | 20:18 |
corvus | https://zuul-ci.org/docs/zuul/admin/tenants.html#attr-tenant.default-ansible-version | 20:19 |
pabelanger | Oh, that would work too. Forgot, I was thinking setting it via job | 20:20 |
pabelanger | thanks! | 20:20 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Add raw links to log manifest https://review.opendev.org/673104 | 20:25 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Rename view to logfile https://review.opendev.org/673105 | 20:25 |
*** jeliu_ has quit IRC | 20:26 | |
corvus | mordred, clarkb, tristanC: ^ i think that about wraps it up. i'm going to stop doing new development on that. i think we can review/modify/merge at will. | 20:27 |
mordred | corvus: sweet! | 20:30 |
*** jeliu_ has joined #zuul | 20:31 | |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 20:47 |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 21:02 |
*** rfolco|rover has quit IRC | 21:30 | |
openstackgerrit | Jeff Liu proposed zuul/zuul-operator master: use opendev image building system for zuul-operator test https://review.opendev.org/673020 | 21:30 |
*** jeliu_ has quit IRC | 21:50 | |
*** mattw4 has quit IRC | 21:53 | |
*** jamesmcarthur has joined #zuul | 21:55 | |
*** jamesmcarthur has quit IRC | 22:15 | |
*** michael-beaver has quit IRC | 22:27 | |
*** mattw4 has joined #zuul | 22:38 | |
*** jamesmcarthur has joined #zuul | 22:45 | |
*** jamesmcarthur has quit IRC | 23:00 | |
*** jamesmcarthur has joined #zuul | 23:10 | |
*** tosky has quit IRC | 23:31 | |
*** jamesmcarthur has quit IRC | 23:42 | |
*** mattw4 has quit IRC | 23:45 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!