Friday, 2019-06-21

SpamapScorvus:neat! thanks00:11
fungicorvus: i agree that sounds like it could save a lot of idle time for both the builder and devstack00:16
*** mattw4 has quit IRC00:19
*** mattw4 has joined #zuul00:22
*** mattw4 has quit IRC00:47
*** michael-beaver has quit IRC01:39
*** mattw4 has joined #zuul01:57
openstackgerritIan Wienand proposed zuul/zuul-jobs master: Add reboot-host role  https://review.opendev.org/66674801:58
*** zer0c00l_ has joined #zuul02:28
zer0c00l_I have a cluster with nova-network, keystoneauth/nodepool seems to be having trouble talking to it02:29
zer0c00l_http://paste.openstack.org/show/753241/02:29
*** kevinluuuuu has quit IRC02:32
zer0c00l_Seems like cleanupLeakedPorts eventually leads to keystoneauth's service_discovery network endpoint and fails02:32
zer0c00l_This is one of those old clusters still running nova-net :(02:33
*** bhavikdbavishi has joined #zuul03:24
*** bhavikdbavishi1 has joined #zuul03:34
*** bhavikdbavishi has quit IRC03:36
*** bhavikdbavishi1 is now known as bhavikdbavishi03:36
*** mattw4 has quit IRC04:39
*** migi has quit IRC04:44
*** mhu has quit IRC04:44
*** mhu has joined #zuul04:44
*** ianw is now known as ianw_pto04:44
*** pcaruana has joined #zuul04:45
openstackgerritTobias Henkel proposed zuul/zuul master: Filter out unprotected branches from builds if excluded  https://review.opendev.org/66666405:48
*** gtema has joined #zuul06:15
flaper87tobiash: I'm trying to install a python package in zuul's python env. I can't find what's the right python env I should install this package on T_T06:25
flaper87Should I just use the pip ansible module and delegate to localhost?06:25
tobiashflaper87: you need one in the ansible context?06:28
flaper87tobiash: yes06:31
tobiashflaper87: there are some variables you can set during installation time to add additional packages to the ansible venvs: https://zuul-ci.org/docs/zuul/admin/installation.html?highlight=ansible_extra_packages#ansible06:33
flaper87tobiash: a-ha, interesting. I assume this can be set in the pod06:34
flaper87and that zuul-ansible-manage will run at startup06:34
flaper87thanks06:34
tobiashif you use the official images zuul-manage-ansible has been run during image creation06:35
tobiashso you probably need to either add another layer that calls it again in the image or add your own startup script that runs it during startup06:36
flaper87perfect, thanks06:37
*** gtema has quit IRC06:44
flaper87tobiash: that worked, thanks!06:46
*** saneax has joined #zuul06:46
flaper87do you know what user is used to run ansible? The same as the zuul process?06:46
*** saneax has quit IRC07:08
tobiashyes, should be07:09
tobiashmhu: I've posted a question on https://review.opendev.org/57690707:09
*** gtema has joined #zuul07:11
*** mhu has quit IRC07:27
*** mhu has joined #zuul07:27
openstackgerritMark Meyer proposed zuul/zuul master: Extend event reporting  https://review.opendev.org/66213407:36
*** jpena|off is now known as jpena07:37
*** saneax has joined #zuul07:51
*** hashar has joined #zuul08:09
*** jangutter has joined #zuul08:24
*** hashar has quit IRC08:53
openstackgerritMatthieu Huin proposed zuul/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.opendev.org/57690708:56
*** hashar has joined #zuul08:57
openstackgerritMatthieu Huin proposed zuul/zuul master: Allow operator to generate auth tokens through the CLI  https://review.opendev.org/63619709:03
*** spsurya has joined #zuul10:07
*** gtema has quit IRC10:11
*** gtema_ has joined #zuul10:11
openstackgerritMatthieu Huin proposed zuul/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.opendev.org/57690710:38
openstackgerritMatthieu Huin proposed zuul/zuul master: Allow operator to generate auth tokens through the CLI  https://review.opendev.org/63619710:39
openstackgerritMatthieu Huin proposed zuul/zuul master: Zuul CLI: allow access via REST  https://review.opendev.org/63631510:40
*** jpena is now known as jpena|lunch11:26
*** pwhalen has quit IRC11:41
*** gtema_ has quit IRC11:54
*** gtema_ has joined #zuul11:55
*** EmilienM is now known as EvilienM11:59
*** gtema_ has quit IRC12:13
*** gtema_ has joined #zuul12:26
openstackgerritMatthieu Huin proposed zuul/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.opendev.org/57690712:35
*** rlandy has joined #zuul12:36
openstackgerritMatthieu Huin proposed zuul/zuul master: Allow operator to generate auth tokens through the CLI  https://review.opendev.org/63619712:36
openstackgerritMatthieu Huin proposed zuul/zuul master: Zuul CLI: allow access via REST  https://review.opendev.org/63631512:36
*** jamielennox has quit IRC12:41
*** michael-beaver has joined #zuul12:55
*** jpena|lunch is now known as jpena12:59
*** rfolco has joined #zuul13:02
fungiso... we've (opendev) got a report from one of our openstack providers that nodepool seems to be "cleaning up" newly allocated ports while waiting for the associated instances to be scheduled... the theory is that the request causes neutron to allocate a port in a "down" state, but if it takes >3 minutes for the corresponding instance to be scheduled to a host and created then nodepool assumes the port is13:10
fungileaked and deletes it. does this seem likely to anyone more versed in https://review.opendev.org/609829 and the related changes which followed it?13:10
*** gtema_ has quit IRC13:20
openstackgerritMatthieu Huin proposed zuul/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.opendev.org/57690713:21
*** jeliu_ has joined #zuul13:29
*** gtema_ has joined #zuul13:32
*** bhavikdbavishi has quit IRC13:43
tobiashfungi: afaik it cleans them after 7 minutes13:44
tobiashWhich might not be enough in some cases13:44
tobiashOh it is 3 minutes13:46
tobiashwe should probably increase that interval13:47
*** jamesmcarthur has joined #zuul13:58
fungii guess we don't have any convenient way to be able to tell if a port is preallocated and still waiting on an instance request which is in progress13:58
fungimordred probably can explain all the terribleness happening with that13:59
flaper87Is there a built-in auth management in zuul-web?14:03
flaper87if not I'd prolly configure basic auth on nginx and just skip auth for the webhook endpoint (not sure if that's even possible)14:03
corvusflaper87: no built-in auth; using a web server auth module is the way to go14:11
*** jamesmcarthur has quit IRC14:18
flaper87corvus: roger that14:25
tobiashfungi: that's correct, thats why we sweep every three minutes over all down ports and clean up the ones that we already know14:26
clarkbtobiash: fungi: does that rely on a 3 minute timer or an age field on the port14:27
clarkbI wonder if we can sweep often but delay deletion until port age is much older14:28
tobiashit's a 3 minute periodic task in nodepool itself14:28
clarkb(30 minutes maybe?)14:28
flaper87corvus: what would be the endpoint to leave out of auth so that github can send webhooks?14:29
flaper87I guess the one I put in the app14:29
flaper87dumb question14:29
tobiashyepp ;)14:30
openstackgerritMatthieu Huin proposed zuul/zuul master: Allow operator to generate auth tokens through the CLI  https://review.opendev.org/63619714:31
openstackgerritMatthieu Huin proposed zuul/zuul master: Zuul CLI: allow access via REST  https://review.opendev.org/63631514:33
corvusclarkb, tobiash, fungi: yeah, it's a sort of mark/sweep -- it checks every 3m and the port has to be down the current check and prev check.14:36
tobiashcorvus: I think port leaks are typically not that dramatically so we could increase that to let's say 10 minutes?14:37
corvusk, i'll make a patch14:38
fungithanks corvus!14:39
openstackgerritJames E. Blair proposed zuul/nodepool master: Increase port cleanup interval  https://review.opendev.org/66685214:40
openstackgerritMatthieu Huin proposed zuul/zuul master: Add Authorization Rules configuration  https://review.opendev.org/63985514:42
*** jangutter has quit IRC15:09
*** hashar has quit IRC15:14
clarkbcatching up, it appears we made a zuul release. Did we end up reverting the parallel github api requests or fixing that properly?15:15
tobiashParallel is still reverted, reimplementing is on my todo list15:17
clarkbok no rush. I'm just catching up on the status of a few of the things I was following before taking most of the week off :)15:19
*** hashar has joined #zuul15:26
tobiashBut we still landed a bunch of improvements to the github driver15:28
*** saneax has quit IRC15:33
*** saneax has joined #zuul15:33
*** saneax has quit IRC15:45
openstackgerritJames E. Blair proposed zuul/nodepool master: DNM: fail devstack jobs  https://review.opendev.org/66688015:46
*** clarkb has quit IRC15:53
*** jamesmcarthur has joined #zuul15:56
*** jpena is now known as jpena|off16:01
openstackgerritMerged zuul/nodepool master: Increase port cleanup interval  https://review.opendev.org/66685216:01
*** clarkb has joined #zuul16:05
*** panda is now known as panda-pto16:08
openstackgerritTobias Henkel proposed zuul/zuul master: Add command processor to zuul-web  https://review.opendev.org/66630716:11
openstackgerritTobias Henkel proposed zuul/zuul master: Add repl server for debug purposes  https://review.opendev.org/57996216:12
*** mattw4 has joined #zuul16:21
*** mgoddard has quit IRC16:24
*** mgoddard has joined #zuul16:24
*** spsurya has quit IRC16:24
*** mattw4 has quit IRC16:27
*** mattw4 has joined #zuul16:28
*** pwhalen has joined #zuul16:31
SpamapShas anyone ever asked for or worked on a way to change the hard coded "roles/" path to something one can set on the job configuration?16:42
SpamapSI have a giant pile of roles in a sub-directory because monorepo... but I want to use them from another repo.16:42
SpamapSwas thinking  roles: - {zuul: {name: Project/Name path: auto/ansible/roles}}16:43
corvusSpamapS: we're trying to be compatible with ansible here16:43
*** jamesmcarthur has quit IRC16:44
SpamapSIt's a bit inflexible though. The default is fine, but for me.. I'm having to extract all the roles from the monorepo into a 3rd repo...16:44
SpamapSanyway, have to run afk.. but something to ponder.16:44
fungimaybe if this corresponded to a new feature of upstream ansible where it could be configured to look for additional role paths?16:49
corvusSpamapS: the end result is that those roles will be easier to share if they aren't buried deep in a repo, and sharing is the ultimate goal.  basically, you can put roles anywhere you want in a repo as long as they're used for playbooks in that repo, but if you want to share those roles with other repos, we take cues from ansible about how to do that, so we don't invent zuul-specific ways of sharing roles.16:49
corvusso the current system mimics what you see on galaxy.  mazer has more advanced ideas about collections of roles, perhaps there is opportunity there.16:49
corvusfungi: you can tell ansible to look anywhere for roles, so this is more about following the lead of galaxy and mazer regarding sharing roles16:50
fungiahh16:51
*** jeliu_ has quit IRC16:55
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502317:07
*** jamesmcarthur has joined #zuul17:07
dmsimardSpamapS: haven't tested this with Zuul but Ansible roles can be called by their path relative to the root of ANSIBLE_ROLES_PATH17:09
dmsimardso, for example, you might have roles nested like "roles/infra/install-docker", "roles/dev/bootstrap"17:10
dmsimardbut then, the roles as written in your playbooks must be called "infra/install-docker", "dev/bootstrap"17:10
dmsimardwhereas you might otherwise have had "roles/install-docker", "roles/bootstrap" and called them as "install-docker" and "bootstrap"17:11
*** jamesmcarthur has quit IRC17:23
*** igordc has joined #zuul17:25
*** hashar has quit IRC17:25
mattw4Does anyone know why the executor container would have an old version of my (untrusted) jobs repo?  I thought it refreshed its copy in /var/lib/zuul/executor-git on every job run.17:51
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502317:53
*** jeliu_ has joined #zuul18:15
SpamapSdmsimard: that's interesting, but the path I have is {repo}/auto/ansible/roles18:16
SpamapSAnd I couldn't care less about Ansible's norms for my purposes, as these roles will never be shared with anybody but us (the ones we share with the world are at https://github.com/GoodMoney/goodmoney-zuul-roles), but I appreciate the desire to align. I18:17
SpamapSThe other option is a symlink from roles -> auto/ansible/roles in the repo where I want them to live.18:18
SpamapSbut being monorepo-ish... paths matter a lot.. so I don't do it lightly.18:18
SpamapSWould much rather that I can just specify the sub-path.18:19
*** jeliu_ has quit IRC18:20
*** jeliu_ has joined #zuul18:21
pabelangercollections is the new hotness, I believe there is more flexability there18:26
SpamapSWhy isn't there flexibility in roles path though? You're already building a roles path with   x/y/z/roles:a/b/c/roles18:26
SpamapSSeems a bit rigid to enforce that it has to be {repo}/roles18:27
SpamapSAlso, just from my perspective.. I don't find roles all that sharable outside limited contexts like zuul jobs. :-P18:27
*** gtema_ has quit IRC18:29
SpamapSI'll propose a patch, and we can discuss from there. :)18:38
corvusmattw4: the content in /var/lib/zuul/executor-git isn't really meant to be directly used; it may have the latest content without actually checking it out.  what ultimately matters is what it puts into the build directory.  you can see the refs and shas that it checks out for the build in the executor debug log if there's a question.18:58
fungiyeah, the date of the checkout in the /var/lib/zuul/executor-git tree is likely an artifact of when it was cloned and nothing more19:00
fungii wonder if that could just be replaced by a bare git repo with no worktree?19:00
corvusfungi: we need to perform merge ops19:04
corvusthat requires a working tree19:05
corvusbut we don't make any attempt to leave it in a sensible state.  if you cd into it and do a 'git log', you might see the current tip of master, or you might see the result of a speculative merge commit of a 3 month old change on a stable branch.19:06
fungiokay, so it'll be left in whatever state was required by the last merge (which could involve relatively ancient commits)19:14
fungii suppose we *could* divorce the worktree to some other temporary path separate from the gitdir and clean it up with something along the lines of the `git worktree remove` command19:16
fungionce it's state is not in use19:17
fungier, its19:17
openstackgerritArun S A G proposed zuul/nodepool master: Clouds running nova-network won't have public network endpoints  https://review.opendev.org/66690519:18
*** EvilienM is now known as EmilienM19:39
*** gtema_ has joined #zuul19:45
mattw4corvus: Thanks for the response.  I figured the executor-git dir was some kind of staging dir, but at least it had my latest commit.  What I don't understand is why my new job, defined in that latest commit, is not available in the Zuul jobs listing page at <zuul_ip>:9000/t/example_tenant/jobs.  Any idea why that listing would be stale?20:17
corvusmattw4: the executor should notice changes to zuul jobs in repos it knows about.  it should receive the event from the merge, decide that it might contain a config update, and reload the config for the tenant.  you can check the scheduler logs to see if that happened or if something went wrong.20:20
mattw4will do corvus, thanks again!20:20
corvusmattw4: if there was an error in the config, it may be staying with the old one.  if it just missed the event, you can run "zuul-scheduler full-reconfigure" to force it to reload.20:21
*** rfolco has quit IRC20:25
fungialso if it missed that event due to a fluke, then the next event for that tenant should catch it up20:26
mattw4corvus, fungi: I'm seeing my "recheck" trigger fly by in the main log so I think it's catching the trigger, but I'm stumped as to why my jobs listing doesn't have my newly defined jobs20:28
fungimattw4: when you visit the status page in a web browser, do you see a small "bell" icon in the top-right corner?20:30
fungi(that only appears if there are configuration errors detected by the scheduler)20:32
mattw4fungi: yeah, there are a lot of them :/  Where is the correct place to fix the "Unknown project opendev.org/openstack/devstack" error?  I have it listed in my tenant config as an untrusted project20:32
corvusmattw4: that's the right way to fix that, did you do a full reconfiguration or restart after adding it?20:33
mattw4corvus: I have tried both20:34
corvusmattw4: it may be worth reading the scheduler log when it starts to see if it mentions anything about opendev.org/openstack/devstack20:35
mattw4corvus: is it correct to list projects in tenant config as you have above^?  i.e. opendev.org/openstack/devstack instead of openstack/devstack ?20:36
fungiis opendev.org the name of your opendev connection?20:36
corvusmattw4: in the tenant config, it should just be 'openstack/devstack', but underneath a connection to opendev20:36
mattw4fungi: yep20:36
corvusmattw4: just like https://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L7920:37
mattw4corvus: yeah, that's ithe pattern I'm using.  Checking reference you linked...20:37
*** gtema_ has quit IRC20:44
mattw4in my job definitions, should I preface my required-projects with their connection name? e.g. is "required-projects: - opendev.org/openstack/devstack" correct or should I drop the leading opendev.org?20:45
fungii think you need to specify the connection name unless they're listed in the same connection20:52
mattw4thanks fungi20:56
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502321:02
*** jeliu_ has quit IRC21:12
*** pcaruana has quit IRC21:16
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502321:16
*** openstackgerrit has quit IRC21:33
*** persia_ is now known as persia21:45
*** openstackgerrit has joined #zuul22:06
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502322:06
mattw4Does anyone know why, if I have projects included in my tenant config and they are showing up in the Zuul web page "projects" list, why am I getting config errors like "Unknown project opendev.org/openstack/devstack"?? I'm really stumped on this one22:16
mattw4It seems like my issue above^ should be solved with the correct "include:" in tenant config.22:16
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502322:41
corvusmattw4: if you click on the devstack project in the projects list, what is the name you see on the resulting page?22:42
corvusmattw4: eg where it says "opendev.org/airship/airship-in-a-bottle" on this page: http://zuul.openstack.org/project/airship/airship-in-a-bottle22:43
mattw4corvus: when I click on openstack/devstack in the projects list, it opens a page with the header 'review.opendev.org/openstack/devstack', but the page is empty22:45
corvusmattw4: i think you're missing the "canonical_hostname" setting in your zuul.conf file: https://zuul-ci.org/docs/zuul/admin/drivers/gerrit.html#attr-%3Cgerrit%20connection%3E.canonical_hostname22:45
mattw4corvus: I sure am!  Is that a new setting?  I don't remember seeing it a few weeks ago when I set up my Zuul22:46
corvusmattw4: set canonical_hostname=opendev.org for that connection...22:46
mattw4corvus: I should stop and start the containers after that, right?  I never remember when I need to restart...22:47
corvusmattw4: it's not new, but it's not usually needed.  it is needed for opendev.22:47
corvusmattw4: yes, that requires a restart of the scheduler22:47
corvusmattw4: zuul currently thinks the name of that project is "review.opendev.org/openstack/devstack" after the change and restart, it will know it as "opendev.org/openstack/devstack" so it should match22:48
mattw4corvus: gotcha...I think I'm still repairing configuration from the domain switchover.22:48
mattw4that makes a lot of sense with the issues I've been seeing today22:49
corvuswell, the same problem would have happened before, just would have been "review.openstack.org" vs "git.openstack.org"22:49
mattw4Thanks corvus!  The project listings seem "complete" like the airship example you sent me!22:52
*** rlandy has quit IRC23:00
*** igordc has quit IRC23:02
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502323:29
*** jamesmcarthur has joined #zuul23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!