SpamapS | we are partially monorepo... so projects is like, 6, but if we weren't monorepo it'd probably be 15. | 00:09 |
---|---|---|
*** mattw4 has quit IRC | 00:22 | |
*** fdegir has quit IRC | 00:31 | |
*** fdegir has joined #zuul | 00:32 | |
*** michael-beaver has quit IRC | 00:35 | |
*** jamesmcarthur has quit IRC | 00:46 | |
guilhermesp | Hehe no worries fungi :) | 01:32 |
*** bhavikdbavishi has joined #zuul | 02:48 | |
*** mgoddard has quit IRC | 02:48 | |
*** bhavikdbavishi has quit IRC | 02:52 | |
*** mgoddard has joined #zuul | 03:01 | |
*** tristanC has quit IRC | 03:01 | |
*** tristanC has joined #zuul | 03:04 | |
*** mattw4 has joined #zuul | 03:09 | |
*** bhavikdbavishi has joined #zuul | 03:10 | |
*** threestrands has joined #zuul | 04:05 | |
*** mattw4 has quit IRC | 04:29 | |
*** pcaruana has joined #zuul | 04:56 | |
openstackgerrit | Joshua Hesketh proposed zuul/zuul master: Expose date time as facts https://review.opendev.org/664674 | 05:06 |
*** saneax has joined #zuul | 05:10 | |
*** saneax has quit IRC | 05:19 | |
*** raukadah is now known as chandankumar | 05:21 | |
*** johnsom has quit IRC | 05:36 | |
*** jtanner has quit IRC | 05:36 | |
*** hogepodge has quit IRC | 05:36 | |
*** jtanner has joined #zuul | 05:37 | |
*** hogepodge has joined #zuul | 05:38 | |
*** johnsom has joined #zuul | 05:38 | |
*** gtema has joined #zuul | 06:27 | |
*** igordc has quit IRC | 06:32 | |
*** flepied has quit IRC | 07:05 | |
*** saneax has joined #zuul | 07:33 | |
*** threestrands has quit IRC | 07:36 | |
*** jangutter has joined #zuul | 07:38 | |
*** jpena|off is now known as jpena | 07:43 | |
*** spsurya has joined #zuul | 08:01 | |
*** jpena has quit IRC | 08:15 | |
*** jpena has joined #zuul | 08:44 | |
*** kevinluuuuu has joined #zuul | 08:55 | |
*** bhavikdbavishi has quit IRC | 09:01 | |
*** sshnaidm|afk is now known as sshnaidm | 09:04 | |
*** bjackman has joined #zuul | 09:24 | |
*** panda|off is now known as panda | 09:30 | |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Add missing doc for pipeline start-message https://review.opendev.org/665930 | 09:45 |
*** hashar has joined #zuul | 10:02 | |
*** saneax has quit IRC | 10:06 | |
*** saneax has joined #zuul | 10:07 | |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Add missing start-message in pipeline config schema https://review.opendev.org/665936 | 10:12 |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Add missing doc for pipeline start-message https://review.opendev.org/665930 | 10:13 |
*** gtema has quit IRC | 10:18 | |
*** gtema_ has joined #zuul | 10:18 | |
*** gtema_ is now known as gtema | 10:18 | |
*** gtema has quit IRC | 11:25 | |
*** hashar has quit IRC | 11:27 | |
*** bhavikdbavishi has joined #zuul | 11:28 | |
*** jpena is now known as jpena|lunch | 11:32 | |
*** bhavikdbavishi has quit IRC | 11:35 | |
*** bhavikdbavishi has joined #zuul | 11:42 | |
*** gtema has joined #zuul | 11:51 | |
*** rfolco has joined #zuul | 11:59 | |
openstackgerrit | Jean-Philippe Evrard proposed zuul/zuul master: Expose date time as facts https://review.opendev.org/664674 | 12:19 |
*** pwhalen has joined #zuul | 12:24 | |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Add support for item.change for pipeline start-message formater https://review.opendev.org/665968 | 12:35 |
*** hashar has joined #zuul | 12:37 | |
*** rlandy has joined #zuul | 12:40 | |
*** jpena|lunch is now known as jpena | 12:40 | |
fbo | Hi, one of our Zuul user would like to get a message on Gerrit when jobs for a change start. The message should contain a link to the buildset status. | 12:43 |
fbo | I succeded to set that start-message: Build started. Ephemeral buildset status {status_url}/{pipeline.tenant.name}/status/change/{change.number},{change.patchset}. in the pipeline definition | 12:44 |
fbo | But I had to hack a bit, so here are the needed changes in Zuul: https://review.opendev.org/#/q/topic:start-message+(status:open+OR+status:merged) | 12:45 |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Add change replacement field in doc for start-message https://review.opendev.org/665974 | 12:47 |
openstackgerrit | Mark Meyer proposed zuul/zuul master: Extend event reporting https://review.opendev.org/662134 | 12:57 |
*** pcaruana has quit IRC | 13:37 | |
*** bhavikdbavishi has quit IRC | 13:39 | |
*** pcaruana has joined #zuul | 13:54 | |
*** michael-beaver has joined #zuul | 13:56 | |
*** bhavikdbavishi has joined #zuul | 14:07 | |
*** chandankumar is now known as raukadah | 14:10 | |
*** ianychoi_ is now known as ianychoi | 14:26 | |
*** bhavikdbavishi has quit IRC | 14:29 | |
*** hashar has quit IRC | 14:31 | |
*** jamesmcarthur has joined #zuul | 14:31 | |
*** hashar has joined #zuul | 14:47 | |
Shrews | \o/ finally got my zuul t-shirt today. now if i could just learn the secret handshake.... | 14:50 |
openstackgerrit | Mark Meyer proposed zuul/zuul master: Extend event reporting https://review.opendev.org/662134 | 14:51 |
fungi | Shrews: i thought it was a secret milkshake? | 14:53 |
*** mattw4 has joined #zuul | 14:54 | |
*** mattw4 has quit IRC | 14:54 | |
*** mattw4 has joined #zuul | 14:55 | |
mordred | mmm. milkshake | 14:58 |
*** jamesmcarthur_ has joined #zuul | 14:59 | |
*** mattw4 has quit IRC | 15:01 | |
*** spsurya has quit IRC | 15:01 | |
*** jamesmcarthur has quit IRC | 15:02 | |
*** bhavikdbavishi has joined #zuul | 15:09 | |
*** zbr|ruck is now known as zbr|brb | 15:34 | |
*** michael-beaver has quit IRC | 15:39 | |
*** mgagne has quit IRC | 15:39 | |
corvus | tobiash: can you take another look at https://review.opendev.org/665186 ? | 15:39 |
*** kklimonda has quit IRC | 15:39 | |
*** michael-beaver has joined #zuul | 15:40 | |
*** kklimonda has joined #zuul | 15:41 | |
*** mgagne has joined #zuul | 15:42 | |
*** mattw4 has joined #zuul | 15:44 | |
*** mattw4 has quit IRC | 15:46 | |
tobiash | Lgtm | 15:50 |
openstackgerrit | James E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job https://review.opendev.org/665023 | 15:51 |
*** hashar has quit IRC | 15:57 | |
*** mattw4 has joined #zuul | 15:58 | |
*** saneax has quit IRC | 15:59 | |
*** pcaruana has quit IRC | 16:01 | |
*** igordc has joined #zuul | 16:03 | |
*** andreykurilin has joined #zuul | 16:03 | |
andreykurilin | hi folks! Does it possible (and how if yes) to use encrypted secret as an environment variable for tox job? | 16:04 |
fungi | andreykurilin: zuul secrets are exposed as ansible variables, so you ought to be able to add one to the environment dict for a shell or command task such as the one you use to invoke tox | 16:16 |
fungi | andreykurilin: you probably also need to make sure your tox.ini is configured to whitelist that variable through its environment filter | 16:17 |
fungi | andreykurilin: as an aside, i'd be wary of putting secrets in environment variables as those have a tendency to get logged in places. i think we avoid including the environment fact collection though that's worth verifying. also you probably want to make sure tox doesn't log the values of environment variables | 16:18 |
andreykurilin | fungi: thank you for answers! Now I know how to workaround my task | 16:27 |
*** gtema has quit IRC | 16:35 | |
*** zbr|brb is now known as zbr|ruck | 16:38 | |
SpamapS | andreykurilin: o/ | 16:40 |
andreykurilin | hi Clint! How is it going? | 16:41 |
*** pcaruana has joined #zuul | 16:45 | |
openstackgerrit | Merged zuul/zuul master: Change default job_dir location https://review.opendev.org/665186 | 16:47 |
*** igordc has quit IRC | 16:49 | |
openstackgerrit | Merged zuul/zuul master: Make git repo leak check advisory in TestExecutor https://review.opendev.org/665764 | 16:50 |
*** panda has quit IRC | 16:56 | |
*** jamesmcarthur_ has quit IRC | 16:57 | |
pabelanger | tobiash: corvus: I've +3 the github-api stack at https://review.opendev.org/665504/ (only +2 here currently). Did we want to do a control merge on it and schedule restart on opendev.org? I'll have to look to see when we could apply into zuul.a.c, I don't we can do today | 16:59 |
pabelanger | clarkb: fyi^ | 16:59 |
corvus | pabelanger: i'd like to wait until tobiash finishes up his new work on parallel before restarting to test that | 16:59 |
corvus | i think we can merge what's there now though | 16:59 |
*** jamesmcarthur has joined #zuul | 16:59 | |
pabelanger | okay, cool | 17:00 |
pabelanger | I forgot about the parallel bits | 17:00 |
pabelanger | +A | 17:00 |
*** altlogbot_0 has quit IRC | 17:00 | |
*** panda has joined #zuul | 17:01 | |
*** irclogbot_3 has quit IRC | 17:01 | |
*** altlogbot_0 has joined #zuul | 17:02 | |
*** irclogbot_1 has joined #zuul | 17:04 | |
*** jamesmcarthur has quit IRC | 17:04 | |
openstackgerrit | Merged zuul/zuul master: Pagure driver - https://pagure.io/pagure/ https://review.opendev.org/604404 | 17:05 |
corvus | fbo: \o/ | 17:05 |
*** corvus is now known as thecount | 17:06 | |
thecount | three code review systems, ha! ha! ha! | 17:06 |
*** thecount is now known as corvus | 17:06 | |
mordred | fbo: nice work! | 17:06 |
SpamapS | let the driver-palooza continue! | 17:09 |
corvus | if we can merge the bb driver soon, then the drivers/time graph is going to be exponential.... we could have support for millions of code review systems by next year if the trend continues. | 17:15 |
mordred | corvus: I see no flaws in your logic | 17:16 |
fungi | somebody needs to make a chart. it's not real if there's no chart | 17:16 |
corvus | yeah, you just can't argue with statistics like that. | 17:16 |
mordred | fungi: do you think a pi chart would be best? | 17:16 |
fungi | oof | 17:16 |
fungi | that would be one mean, mean graph | 17:18 |
*** bhavikdbavishi has quit IRC | 17:19 | |
*** jamesmcarthur has joined #zuul | 17:28 | |
*** jamesmcarthur has quit IRC | 17:33 | |
*** igordc has joined #zuul | 17:35 | |
*** jpena is now known as jpena|off | 17:43 | |
openstackgerrit | Merged zuul/zuul master: Remove unused user_id from github client https://review.opendev.org/665504 | 17:46 |
*** jamesmcarthur has joined #zuul | 17:52 | |
openstackgerrit | Merged zuul/zuul master: Rework GitHub rate limit handling https://review.opendev.org/665505 | 18:15 |
openstackgerrit | Merged zuul/zuul master: Switch getPullBySha to using the search api https://review.opendev.org/665469 | 18:27 |
*** hashar has joined #zuul | 18:30 | |
fungi | are 665506,665507,665511 all we're waiting to merge before we restart opendev's zuul to burn things in? | 18:35 |
corvus | fungi: tobiash has some more work he's planning on doing related to parallelization; i'd prefer to wait for that before we restart/burn | 18:35 |
fungi | got it. didn't know whether it was just those | 18:35 |
corvus | yeah, those are all safe and fine to merge (and if we have to restart on them, cool), but they're not as interesting from the perspective of testing new behavior at scale until the parallelization stuff arrives | 18:36 |
fungi | makes sense | 18:36 |
fungi | so the restart is a ways off still in that case | 18:36 |
corvus | yep, i'm guessing not today :) | 18:37 |
fungi | as in not in the next couple hours | 18:37 |
fungi | sure | 18:37 |
corvus | oh, and 663015 should be fine to merge | 18:37 |
fungi | yeah, i was more worried about approving more changes if we were about to restart stuff | 18:37 |
tobiash | corvus: it will take me a few days probably due to operational tasks during the last days | 18:37 |
fungi | didn't want to add further delays | 18:37 |
corvus | tobiash: ack, no rush. i'll look into doing a release on the revert commit | 18:38 |
fungi | tobiash: i don't think we're in any hurry, and thanks! | 18:38 |
corvus | that way we'll have a release pretty close to what we're running now, then pagure and new github calls will go in the next | 18:39 |
tobiash | ++ | 18:39 |
fungi | makes sense, yes | 18:39 |
corvus | wow, so sourcing openrc requires bash, apparently: http://logs.openstack.org/23/665023/12/check/nodepool-functional-openstack/213c734/ara-report/result/8b05002e-531b-4f0f-9783-b98e04c96d43/ | 18:40 |
* fungi sighs at more bashisms | 18:41 | |
fungi | the shebang should say bash if it's not posix bourne compliant | 18:41 |
fungi | ahh, it does | 18:42 |
fungi | https://opendev.org/openstack/devstack/src/branch/master/openrc#L1 | 18:42 |
fungi | though somewhat indirectly | 18:42 |
fungi | but i guess sourcing it doesn't hit the shebang | 18:42 |
fungi | and since that's the way the file is expected to be used, that shebang is merely informational | 18:43 |
corvus | yep. color me surprised :) | 18:45 |
fungi | part of me is tempted to propose a posix translation of that file, but there are a *lot* of bashisms in it, so not sure it's a worthwhile use of my time | 18:45 |
corvus | yeah, i can tell ansible to use bash for this. <shrug> | 18:45 |
*** pcaruana has quit IRC | 18:45 | |
fungi | some could be fixed by invoking test by name, some with if/else conditionals for the default substitutions | 18:46 |
openstackgerrit | James E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job https://review.opendev.org/665023 | 18:47 |
mordred | corvus: whatcha sourcing an openrc for? | 18:51 |
openstackgerrit | Merged zuul/zuul master: Add central retry handling for github requests https://review.opendev.org/665506 | 18:52 |
mordred | corvus: ah - I see in the backscroll. well - fwiw, devstack creates clouds.yaml files, and python-openstackclient knows how to use them | 18:53 |
mordred | but what you've got there should work | 18:55 |
corvus | mordred: i'm trying to untangle the nodepool functional job from devstack. it's currently implemented as a plugin. i need openstack to be a black box that nodepool consumes. that way we can move nodepool to the zuul tenant without bringing devstack along with it. | 19:03 |
corvus | mordred: i think it'll be easiest to port over these shell commands for now, and then we can look at using the os_ modules afterwords? | 19:03 |
mordred | corvus: ++ | 19:04 |
mordred | makes sense | 19:04 |
*** pcaruana has joined #zuul | 19:05 | |
dmsimard | btw someone mentioned that https://github.com/openstack-infra/zuul is still a thing and is out of date | 19:07 |
*** jamesmcarthur has quit IRC | 19:08 | |
fungi | yeah, that's part of what's under discussion in the infra meeting action items | 19:09 |
openstackgerrit | Merged zuul/zuul master: Cleanup specialized retry in _process_event https://review.opendev.org/665507 | 19:16 |
mordred | fungi: have we covered retiring old mirror repos? | 19:16 |
fungi | mordred: yeah, that's why we're getting additional folks added to the openstack org on gh, but we need to do similar things with openstack-infra org i guess | 19:18 |
mordred | fungi: yeah. or - since it's openstack-infra - I'd imagine we'd want to just push up a "this repo is retired, please see opendev.org/opendev/foo" commit to each github.com/openstack-infra repo and then click the archive button | 19:19 |
fungi | mordred: or delete and just put a description on the org? no idea | 19:19 |
mordred | fungi: yeah. $something | 19:19 |
mordred | fungi: probably any choice is superior to leaving an out of date copy with no indication it's out of date :) | 19:20 |
fungi | yes | 19:20 |
*** panda has quit IRC | 19:33 | |
openstackgerrit | Merged zuul/zuul master: Eliminate two github requests per _updateChange https://review.opendev.org/665511 | 19:38 |
*** panda has joined #zuul | 19:43 | |
openstackgerrit | Merged zuul/zuul master: Expose date time as facts https://review.opendev.org/664674 | 19:52 |
*** gfhellma has joined #zuul | 19:53 | |
*** gfhellma_ has joined #zuul | 19:58 | |
*** jamesmcarthur has joined #zuul | 20:01 | |
*** gfhellma has quit IRC | 20:02 | |
openstackgerrit | Merged zuul/zuul master: Mount tmpfs on ansible tmp dir https://review.opendev.org/663015 | 20:12 |
*** gfhellma has joined #zuul | 20:20 | |
*** gfhellma_ has quit IRC | 20:23 | |
evgenyl | Hi everyone, for Zuul executor I can specify `private_key_file` which seems to be used for both, cloning the repos and accessing the VMs, if this is the case, can I specify paths to two different keys? | 20:40 |
fungi | evgenyl: having not managed a zuul which uses authenticated clone urls, i wasn't even aware that key got reused for cloning in such cases | 20:43 |
pabelanger | tobiash: so back to my comment yesterday about delayed events in github, I confirmed that each event will have a updated_at field, which seems to link up to the Recent Deliveries tab under your github app. | 20:43 |
pabelanger | tobiash: I think we could then calculate the diff, from when zuul got the event and updated_at, then emit to stasd for tracking | 20:43 |
fungi | evgenyl: i take it in your deployment you're cloning repositories which require authentication because they're not generally public? | 20:43 |
pabelanger | to help show how delayed the system is, because of delay due to github | 20:44 |
evgenyl | fungi: I have a mix of private and public repositories, I'm thinking about configuring ssh to use a specific key for particular hostname, not sure if this would work though. | 20:47 |
pabelanger | you can configure sskey per connection | 20:48 |
pabelanger | if you need different ones | 20:48 |
fungi | evgenyl: ahh, actually it looks like our zuul does clone over ssh, so uses the connection sshkey setting for both cloning and commenting/voting | 20:49 |
fungi | and our executor private_key_file is not set to the same path as our connection sshkey | 20:51 |
corvus | i believe the quick-start intentionally uses different keys for those roles too, to provide a good example | 20:51 |
fungi | evgenyl: https://zuul-ci.org/docs/zuul/admin/drivers/gerrit.html?highlight=sshkey#attr-%3Cgerrit%20connection%3E.sshkey | 20:52 |
fungi | (other connection drivers have similar parameters) | 20:53 |
evgenyl | fungi: corvus pabelanger Alright, let me double-check my configs, thank you! | 20:53 |
pabelanger | yup, can confirm github uses sshkey to clone, even with public | 20:53 |
pabelanger | never tried private, thankfully | 20:53 |
pabelanger | :) | 20:53 |
tobiash | pabelanger: in this case we should also track the processing time in the github driver | 20:54 |
fungi | it never dawned on me that we were accessing public repositories over authenticated channels with our deployment. or more likely i was aware at various points in the past and have forgotten | 20:54 |
corvus | in gerrit it's more reliable | 20:58 |
fungi | more reliable than the built-in httpd gerrit provides i guess | 20:59 |
fungi | or rather that its jvm provides anyway | 21:00 |
*** rfolco has quit IRC | 21:01 | |
corvus | you can also put the user in a group which gives it guaranteed access, even if all the other connection slots are used | 21:01 |
fungi | oh, right. i always seem to forget about the "batch" priority option | 21:03 |
fungi | though the documentation seems to indicate that "interactive" priority is higher than "batch" | 21:05 |
fungi | i guess the idea is that batch priority tools are likely to run wild and so interactive users are put in their own thread pool so they're not starved out by non-interactive users, but i suppose that effect cuts both ways on a busy server with tons of interactive users? | 21:08 |
evgenyl | So I did have some problem with config & ssh keys, after fixing it, it seems to work well now. | 21:11 |
evgenyl | Just a quick question, is there a way to parse custom parameters to Ansible via zuul configs? E.g. I need to specify `ansible_python_interpreter=/usr/bin/python3` | 21:11 |
corvus | evgenyl: that's actually just an inventory variable, so you can set it in any of the usual ways in zuul | 21:13 |
corvus | evgenyl: (job.vars, job.host-vars, job.group-vars... etc) | 21:13 |
evgenyl | corvus: Oh, awesome, thank you! | 21:13 |
corvus | evgenyl: here's a live example: https://opendev.org/opendev/system-config/src/branch/master/.zuul.yaml#L372-L374 | 21:14 |
corvus | evgenyl: also, note that we have landed (and are about to release) a feature that lets nodepool specify where the python interpreter is for an image, so jobs shouldn't need to include that anymore once nodepool configs are updated to use that. | 21:15 |
evgenyl | Can I specify these vars for a project vs job? | 21:15 |
corvus | evgenyl: yes, you can do that either at the project level ( https://zuul-ci.org/docs/zuul/user/config.html#attr-project.vars ) or project-pipeline level | 21:16 |
*** jamesmcarthur has quit IRC | 21:17 | |
evgenyl | corvus: Thanks again, you saved a lot of time for me :) | 21:17 |
corvus | \o/ | 21:17 |
*** hashar has quit IRC | 21:29 | |
*** mattw4 has quit IRC | 22:00 | |
*** gfhellma_ has joined #zuul | 22:00 | |
*** mattw4 has joined #zuul | 22:01 | |
*** gfhellma has quit IRC | 22:04 | |
corvus | in the nodepool functional tests, we install dib as a dependency in the virtualenv that we create for nodepool, but i do not believe that we use it; instead, i think we rely on devstack's behavior which installs python packages globally. it is not clear to me that the nodepool builder works with dib in a venv. | 22:07 |
*** evgenyl has quit IRC | 22:12 | |
openstackgerrit | James E. Blair proposed zuul/nodepool master: Use the DIB installed in the virtualenv if running there https://review.opendev.org/666177 | 22:18 |
*** evgenyl has joined #zuul | 22:19 | |
openstackgerrit | James E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job https://review.opendev.org/665023 | 22:20 |
*** gfhellma_ has quit IRC | 22:25 | |
*** gfhellma_ has joined #zuul | 22:28 | |
*** rlandy has quit IRC | 23:21 | |
*** shachar has quit IRC | 23:22 | |
*** shachar has joined #zuul | 23:23 | |
*** gfhellma_ has quit IRC | 23:31 | |
*** gfhellma_ has joined #zuul | 23:42 | |
*** gfhellma_ has quit IRC | 23:49 | |
*** gfhellma_ has joined #zuul | 23:50 | |
*** gfhellma_ has quit IRC | 23:57 | |
*** mattw4 has quit IRC | 23:58 | |
*** michael-beaver has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!