Tuesday, 2019-06-18

SpamapSwe are partially monorepo... so projects is like, 6, but if we weren't monorepo it'd probably be 15.00:09
*** mattw4 has quit IRC00:22
*** fdegir has quit IRC00:31
*** fdegir has joined #zuul00:32
*** michael-beaver has quit IRC00:35
*** jamesmcarthur has quit IRC00:46
guilhermespHehe no worries fungi  :)01:32
*** bhavikdbavishi has joined #zuul02:48
*** mgoddard has quit IRC02:48
*** bhavikdbavishi has quit IRC02:52
*** mgoddard has joined #zuul03:01
*** tristanC has quit IRC03:01
*** tristanC has joined #zuul03:04
*** mattw4 has joined #zuul03:09
*** bhavikdbavishi has joined #zuul03:10
*** threestrands has joined #zuul04:05
*** mattw4 has quit IRC04:29
*** pcaruana has joined #zuul04:56
openstackgerritJoshua Hesketh proposed zuul/zuul master: Expose date time as facts  https://review.opendev.org/66467405:06
*** saneax has joined #zuul05:10
*** saneax has quit IRC05:19
*** raukadah is now known as chandankumar05:21
*** johnsom has quit IRC05:36
*** jtanner has quit IRC05:36
*** hogepodge has quit IRC05:36
*** jtanner has joined #zuul05:37
*** hogepodge has joined #zuul05:38
*** johnsom has joined #zuul05:38
*** gtema has joined #zuul06:27
*** igordc has quit IRC06:32
*** flepied has quit IRC07:05
*** saneax has joined #zuul07:33
*** threestrands has quit IRC07:36
*** jangutter has joined #zuul07:38
*** jpena|off is now known as jpena07:43
*** spsurya has joined #zuul08:01
*** jpena has quit IRC08:15
*** jpena has joined #zuul08:44
*** kevinluuuuu has joined #zuul08:55
*** bhavikdbavishi has quit IRC09:01
*** sshnaidm|afk is now known as sshnaidm09:04
*** bjackman has joined #zuul09:24
*** panda|off is now known as panda09:30
openstackgerritFabien Boucher proposed zuul/zuul master: Add missing doc for pipeline start-message  https://review.opendev.org/66593009:45
*** hashar has joined #zuul10:02
*** saneax has quit IRC10:06
*** saneax has joined #zuul10:07
openstackgerritFabien Boucher proposed zuul/zuul master: Add missing start-message in pipeline config schema  https://review.opendev.org/66593610:12
openstackgerritFabien Boucher proposed zuul/zuul master: Add missing doc for pipeline start-message  https://review.opendev.org/66593010:13
*** gtema has quit IRC10:18
*** gtema_ has joined #zuul10:18
*** gtema_ is now known as gtema10:18
*** gtema has quit IRC11:25
*** hashar has quit IRC11:27
*** bhavikdbavishi has joined #zuul11:28
*** jpena is now known as jpena|lunch11:32
*** bhavikdbavishi has quit IRC11:35
*** bhavikdbavishi has joined #zuul11:42
*** gtema has joined #zuul11:51
*** rfolco has joined #zuul11:59
openstackgerritJean-Philippe Evrard proposed zuul/zuul master: Expose date time as facts  https://review.opendev.org/66467412:19
*** pwhalen has joined #zuul12:24
openstackgerritFabien Boucher proposed zuul/zuul master: Add support for item.change for pipeline start-message formater  https://review.opendev.org/66596812:35
*** hashar has joined #zuul12:37
*** rlandy has joined #zuul12:40
*** jpena|lunch is now known as jpena12:40
fboHi, one of our Zuul user would like to get a message on Gerrit when jobs for a change start. The message should contain a link to the buildset status.12:43
fboI succeded to set that start-message: Build started. Ephemeral buildset status {status_url}/{pipeline.tenant.name}/status/change/{change.number},{change.patchset}. in the pipeline definition12:44
fboBut I had to hack a bit, so here are the needed changes in Zuul: https://review.opendev.org/#/q/topic:start-message+(status:open+OR+status:merged)12:45
openstackgerritFabien Boucher proposed zuul/zuul master: Add change replacement field in doc for start-message  https://review.opendev.org/66597412:47
openstackgerritMark Meyer proposed zuul/zuul master: Extend event reporting  https://review.opendev.org/66213412:57
*** pcaruana has quit IRC13:37
*** bhavikdbavishi has quit IRC13:39
*** pcaruana has joined #zuul13:54
*** michael-beaver has joined #zuul13:56
*** bhavikdbavishi has joined #zuul14:07
*** chandankumar is now known as raukadah14:10
*** ianychoi_ is now known as ianychoi14:26
*** bhavikdbavishi has quit IRC14:29
*** hashar has quit IRC14:31
*** jamesmcarthur has joined #zuul14:31
*** hashar has joined #zuul14:47
Shrews\o/  finally got my zuul t-shirt today. now if i could just learn the secret handshake....14:50
openstackgerritMark Meyer proposed zuul/zuul master: Extend event reporting  https://review.opendev.org/66213414:51
fungiShrews: i thought it was a secret milkshake?14:53
*** mattw4 has joined #zuul14:54
*** mattw4 has quit IRC14:54
*** mattw4 has joined #zuul14:55
mordredmmm. milkshake14:58
*** jamesmcarthur_ has joined #zuul14:59
*** mattw4 has quit IRC15:01
*** spsurya has quit IRC15:01
*** jamesmcarthur has quit IRC15:02
*** bhavikdbavishi has joined #zuul15:09
*** zbr|ruck is now known as zbr|brb15:34
*** michael-beaver has quit IRC15:39
*** mgagne has quit IRC15:39
corvustobiash: can you take another look at https://review.opendev.org/665186 ?15:39
*** kklimonda has quit IRC15:39
*** michael-beaver has joined #zuul15:40
*** kklimonda has joined #zuul15:41
*** mgagne has joined #zuul15:42
*** mattw4 has joined #zuul15:44
*** mattw4 has quit IRC15:46
tobiashLgtm15:50
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502315:51
*** hashar has quit IRC15:57
*** mattw4 has joined #zuul15:58
*** saneax has quit IRC15:59
*** pcaruana has quit IRC16:01
*** igordc has joined #zuul16:03
*** andreykurilin has joined #zuul16:03
andreykurilinhi folks! Does it possible (and how if yes) to use encrypted secret as an environment variable for tox job?16:04
fungiandreykurilin: zuul secrets are exposed as ansible variables, so you ought to be able to add one to the environment dict for a shell or command task such as the one you use to invoke tox16:16
fungiandreykurilin: you probably also need to make sure your tox.ini is configured to whitelist that variable through its environment filter16:17
fungiandreykurilin: as an aside, i'd be wary of putting secrets in environment variables as those have a tendency to get logged in places. i think we avoid including the environment fact collection though that's worth verifying. also you probably want to make sure tox doesn't log the values of environment variables16:18
andreykurilinfungi: thank you for answers! Now I know how to workaround my task16:27
*** gtema has quit IRC16:35
*** zbr|brb is now known as zbr|ruck16:38
SpamapSandreykurilin: o/16:40
andreykurilinhi Clint! How is it going?16:41
*** pcaruana has joined #zuul16:45
openstackgerritMerged zuul/zuul master: Change default job_dir location  https://review.opendev.org/66518616:47
*** igordc has quit IRC16:49
openstackgerritMerged zuul/zuul master: Make git repo leak check advisory in TestExecutor  https://review.opendev.org/66576416:50
*** panda has quit IRC16:56
*** jamesmcarthur_ has quit IRC16:57
pabelangertobiash: corvus: I've +3 the github-api stack at https://review.opendev.org/665504/ (only +2 here currently). Did we want to do a control merge on it and schedule restart on opendev.org?  I'll have to look to see when we could apply into zuul.a.c, I don't we can do today16:59
pabelangerclarkb: fyi^16:59
corvuspabelanger: i'd like to wait until tobiash finishes up his new work on parallel before restarting to test that16:59
corvusi think we can merge what's there now though16:59
*** jamesmcarthur has joined #zuul16:59
pabelangerokay, cool17:00
pabelangerI forgot about the parallel bits17:00
pabelanger+A17:00
*** altlogbot_0 has quit IRC17:00
*** panda has joined #zuul17:01
*** irclogbot_3 has quit IRC17:01
*** altlogbot_0 has joined #zuul17:02
*** irclogbot_1 has joined #zuul17:04
*** jamesmcarthur has quit IRC17:04
openstackgerritMerged zuul/zuul master: Pagure driver - https://pagure.io/pagure/  https://review.opendev.org/60440417:05
corvusfbo: \o/17:05
*** corvus is now known as thecount17:06
thecountthree code review systems, ha! ha! ha!17:06
*** thecount is now known as corvus17:06
mordredfbo: nice work!17:06
SpamapSlet the driver-palooza continue!17:09
corvusif we can merge the bb driver soon, then the drivers/time graph is going to be exponential.... we could have support for millions of code review systems by next year if the trend continues.17:15
mordredcorvus: I see no flaws in your logic17:16
fungisomebody needs to make a chart. it's not real if there's no chart17:16
corvusyeah, you just can't argue with statistics like that.17:16
mordredfungi: do you think a pi chart would be best?17:16
fungioof17:16
fungithat would be one mean, mean graph17:18
*** bhavikdbavishi has quit IRC17:19
*** jamesmcarthur has joined #zuul17:28
*** jamesmcarthur has quit IRC17:33
*** igordc has joined #zuul17:35
*** jpena is now known as jpena|off17:43
openstackgerritMerged zuul/zuul master: Remove unused user_id from github client  https://review.opendev.org/66550417:46
*** jamesmcarthur has joined #zuul17:52
openstackgerritMerged zuul/zuul master: Rework GitHub rate limit handling  https://review.opendev.org/66550518:15
openstackgerritMerged zuul/zuul master: Switch getPullBySha to using the search api  https://review.opendev.org/66546918:27
*** hashar has joined #zuul18:30
fungiare 665506,665507,665511 all we're waiting to merge before we restart opendev's zuul to burn things in?18:35
corvusfungi: tobiash has some more work he's planning on doing related to parallelization; i'd prefer to wait for that before we restart/burn18:35
fungigot it. didn't know whether it was just those18:35
corvusyeah, those are all safe and fine to merge (and if we have to restart on them, cool), but they're not as interesting from the perspective of testing new behavior at scale until the parallelization stuff arrives18:36
fungimakes sense18:36
fungiso the restart is a ways off still in that case18:36
corvusyep, i'm guessing not today :)18:37
fungias in not in the next couple hours18:37
fungisure18:37
corvusoh, and 663015 should be fine to merge18:37
fungiyeah, i was more worried about approving more changes if we were about to restart stuff18:37
tobiashcorvus: it will take me a few days probably due to operational tasks during the last days18:37
fungididn't want to add further delays18:37
corvustobiash: ack, no rush.  i'll look into doing a release on the revert commit18:38
fungitobiash: i don't think we're in any hurry, and thanks!18:38
corvusthat way we'll have a release pretty close to what we're running now, then pagure and new github calls will go in the next18:39
tobiash++18:39
fungimakes sense, yes18:39
corvuswow, so sourcing openrc requires bash, apparently: http://logs.openstack.org/23/665023/12/check/nodepool-functional-openstack/213c734/ara-report/result/8b05002e-531b-4f0f-9783-b98e04c96d43/18:40
* fungi sighs at more bashisms18:41
fungithe shebang should say bash if it's not posix bourne compliant18:41
fungiahh, it does18:42
fungihttps://opendev.org/openstack/devstack/src/branch/master/openrc#L118:42
fungithough somewhat indirectly18:42
fungibut i guess sourcing it doesn't hit the shebang18:42
fungiand since that's the way the file is expected to be used, that shebang is merely informational18:43
corvusyep.  color me surprised :)18:45
fungipart of me is tempted to propose a posix translation of that file, but there are a *lot* of bashisms in it, so not sure it's a worthwhile use of my time18:45
corvusyeah, i can tell ansible to use bash for this.  <shrug>18:45
*** pcaruana has quit IRC18:45
fungisome could be fixed by invoking test by name, some with if/else conditionals for the default substitutions18:46
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502318:47
mordredcorvus: whatcha sourcing an openrc for?18:51
openstackgerritMerged zuul/zuul master: Add central retry handling for github requests  https://review.opendev.org/66550618:52
mordredcorvus: ah - I see in the backscroll. well - fwiw, devstack creates clouds.yaml files, and python-openstackclient knows how to use them18:53
mordredbut what you've got there should work18:55
corvusmordred: i'm trying to untangle the nodepool functional job from devstack.  it's currently implemented as a plugin.  i need openstack to be a black box that nodepool consumes.  that way we can move nodepool to the zuul tenant without bringing devstack along with it.19:03
corvusmordred: i think it'll be easiest to port over these shell commands for now, and then we can look at using the os_ modules afterwords?19:03
mordredcorvus: ++19:04
mordredmakes sense19:04
*** pcaruana has joined #zuul19:05
dmsimardbtw someone mentioned that https://github.com/openstack-infra/zuul is still a thing and is out of date19:07
*** jamesmcarthur has quit IRC19:08
fungiyeah, that's part of what's under discussion in the infra meeting action items19:09
openstackgerritMerged zuul/zuul master: Cleanup specialized retry in _process_event  https://review.opendev.org/66550719:16
mordredfungi: have we covered retiring old mirror repos?19:16
fungimordred: yeah, that's why we're getting additional folks added to the openstack org on gh, but we need to do similar things with openstack-infra org i guess19:18
mordredfungi: yeah. or - since it's openstack-infra - I'd imagine we'd want to just push up a "this repo is retired, please see opendev.org/opendev/foo" commit to each github.com/openstack-infra repo and then click the archive button19:19
fungimordred: or delete and just put a description on the org? no idea19:19
mordredfungi: yeah. $something19:19
mordredfungi: probably any choice is superior to leaving an out of date copy with no indication it's out of date :)19:20
fungiyes19:20
*** panda has quit IRC19:33
openstackgerritMerged zuul/zuul master: Eliminate two github requests per _updateChange  https://review.opendev.org/66551119:38
*** panda has joined #zuul19:43
openstackgerritMerged zuul/zuul master: Expose date time as facts  https://review.opendev.org/66467419:52
*** gfhellma has joined #zuul19:53
*** gfhellma_ has joined #zuul19:58
*** jamesmcarthur has joined #zuul20:01
*** gfhellma has quit IRC20:02
openstackgerritMerged zuul/zuul master: Mount tmpfs on ansible tmp dir  https://review.opendev.org/66301520:12
*** gfhellma has joined #zuul20:20
*** gfhellma_ has quit IRC20:23
evgenylHi everyone, for Zuul executor I can specify `private_key_file` which seems to be used for both, cloning the repos and accessing the VMs, if this is the case, can I specify paths to two different keys?20:40
fungievgenyl: having not managed a zuul which uses authenticated clone urls, i wasn't even aware that key got reused for cloning in such cases20:43
pabelangertobiash: so back to my comment yesterday about delayed events in github, I confirmed that each event will have a updated_at field, which seems to link up to the Recent Deliveries tab under your github app.20:43
pabelangertobiash: I think we could then calculate the diff, from when zuul got the event and updated_at, then emit to stasd for tracking20:43
fungievgenyl: i take it in your deployment you're cloning repositories which require authentication because they're not generally public?20:43
pabelangerto help show how delayed the system is, because of delay due to github20:44
evgenylfungi: I have a mix of private and public repositories, I'm thinking about configuring ssh to use a specific key for particular hostname, not sure if this would work though.20:47
pabelangeryou can configure sskey per connection20:48
pabelangerif you need different ones20:48
fungievgenyl: ahh, actually it looks like our zuul does clone over ssh, so uses the connection sshkey setting for both cloning and commenting/voting20:49
fungiand our executor private_key_file is not set to the same path as our connection sshkey20:51
corvusi believe the quick-start intentionally uses different keys for those roles too, to provide a good example20:51
fungievgenyl: https://zuul-ci.org/docs/zuul/admin/drivers/gerrit.html?highlight=sshkey#attr-%3Cgerrit%20connection%3E.sshkey20:52
fungi(other connection drivers have similar parameters)20:53
evgenylfungi: corvus pabelanger Alright, let me double-check my configs, thank you!20:53
pabelangeryup, can confirm github uses sshkey to clone, even with public20:53
pabelangernever tried private, thankfully20:53
pabelanger:)20:53
tobiashpabelanger: in this case we should also track the processing time in the github driver20:54
fungiit never dawned on me that we were accessing public repositories over authenticated channels with our deployment. or more likely i was aware at various points in the past and have forgotten20:54
corvusin gerrit it's more reliable20:58
fungimore reliable than the built-in httpd gerrit provides i guess20:59
fungior rather that its jvm provides anyway21:00
*** rfolco has quit IRC21:01
corvusyou can also put the user in a group which gives it guaranteed access, even if all the other connection slots are used21:01
fungioh, right. i always seem to forget about the "batch" priority option21:03
fungithough the documentation seems to indicate that "interactive" priority is higher than "batch"21:05
fungii guess the idea is that batch priority tools are likely to run wild and so interactive users are put in their own thread pool so they're not starved out by non-interactive users, but i suppose that effect cuts both ways on a busy server with tons of interactive users?21:08
evgenylSo I did have some problem with config & ssh keys, after fixing it, it seems to work well now.21:11
evgenylJust a quick question, is there a way to parse custom parameters to Ansible via zuul configs? E.g. I need to specify `ansible_python_interpreter=/usr/bin/python3`21:11
corvusevgenyl: that's actually just an inventory variable, so you can set it in any of the usual ways in zuul21:13
corvusevgenyl: (job.vars, job.host-vars, job.group-vars... etc)21:13
evgenylcorvus: Oh, awesome, thank you!21:13
corvusevgenyl: here's a live example: https://opendev.org/opendev/system-config/src/branch/master/.zuul.yaml#L372-L37421:14
corvusevgenyl: also, note that we have landed (and are about to release) a feature that lets nodepool specify where the python interpreter is for an image, so jobs shouldn't need to include that anymore once nodepool configs are updated to use that.21:15
evgenylCan I specify these vars for a project vs job?21:15
corvusevgenyl: yes, you can do that either at the project level ( https://zuul-ci.org/docs/zuul/user/config.html#attr-project.vars ) or project-pipeline level21:16
*** jamesmcarthur has quit IRC21:17
evgenylcorvus: Thanks again, you saved a lot of time for me :)21:17
corvus\o/21:17
*** hashar has quit IRC21:29
*** mattw4 has quit IRC22:00
*** gfhellma_ has joined #zuul22:00
*** mattw4 has joined #zuul22:01
*** gfhellma has quit IRC22:04
corvusin the nodepool functional tests, we install dib as a dependency in the virtualenv that we create for nodepool, but i do not believe that we use it; instead, i think we rely on devstack's behavior which installs python packages globally.  it is not clear to me that the nodepool builder works with dib in a venv.22:07
*** evgenyl has quit IRC22:12
openstackgerritJames E. Blair proposed zuul/nodepool master: Use the DIB installed in the virtualenv if running there  https://review.opendev.org/66617722:18
*** evgenyl has joined #zuul22:19
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: new devstack-based functional job  https://review.opendev.org/66502322:20
*** gfhellma_ has quit IRC22:25
*** gfhellma_ has joined #zuul22:28
*** rlandy has quit IRC23:21
*** shachar has quit IRC23:22
*** shachar has joined #zuul23:23
*** gfhellma_ has quit IRC23:31
*** gfhellma_ has joined #zuul23:42
*** gfhellma_ has quit IRC23:49
*** gfhellma_ has joined #zuul23:50
*** gfhellma_ has quit IRC23:57
*** mattw4 has quit IRC23:58
*** michael-beaver has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!