*** mattw4 has quit IRC | 00:02 | |
*** jangutter has joined #zuul | 00:06 | |
*** jangutter has quit IRC | 00:11 | |
SpamapS | mordred: Is it just because it taints all the existing pep8-shrunk code? | 00:15 |
---|---|---|
SpamapS | because I kind of see their point in choosing 88 | 00:15 |
mordred | SpamapS: no - it's because it's hard to deal with in standard sized windows | 00:16 |
mordred | or for peopel with smaller monitors | 00:16 |
mordred | 80 column terminal windows are a thing | 00:16 |
mordred | their point is "88 made files shorter" - which has no value | 00:17 |
SpamapS | shorter file means shorter diff | 00:17 |
SpamapS | that's something | 00:17 |
mordred | shrug | 00:17 |
mordred | xterm and/or gnome-terminal, with no additional config, launch 80 columns | 00:18 |
SpamapS | And even on my 14" X1 I'm typicaly at more like 160 chars wide than 80. | 00:18 |
SpamapS | And I like BIG fonts. | 00:18 |
mordred | that means that ona standard machine with a standard config, I can open a standard terminal window and edit a file in a standard editor and not have weird line wrapping issues | 00:18 |
SpamapS | Yeah that seems... as weak as the shorter file thing. ;) | 00:18 |
SpamapS | It's logical, but I don't think it outweighs the benefits of having black run w/ defaults. | 00:19 |
SpamapS | That said.. | 00:19 |
SpamapS | it's a big rock decision | 00:19 |
SpamapS | and that's never easy | 00:19 |
mordred | my choice would be to not use black if that was the only choice | 00:19 |
mordred | it is not valuable enough to me to make me change literally everything about how I work with editors and terminal windows | 00:19 |
SpamapS | RPG never had these problems. ;) | 00:19 |
mordred | hahaha | 00:19 |
* SpamapS learned RPG for a minute | 00:20 | |
SpamapS | "column 4 is for conditions" | 00:20 |
mordred | luckily - it's not required to submit to their arbitrary decision to change the arbitrary width to a senselessly different slightly larger arbitrary width | 00:20 |
mordred | and the benefits can be gained without the significant usability downside | 00:21 |
mordred | SpamapS: did you see the zork source code? | 00:21 |
mordred | SpamapS: it's written in a old lisp dialect that uses < instead of ( ! | 00:22 |
mordred | https://github.com/historicalsource/zork/blob/master/dung.mud | 00:22 |
SpamapS | we set our internal width to 100 chars... It feels kind of freeing. ;) | 00:22 |
mordred | I would not be able to work there | 00:22 |
mordred | but I'm happy you're happy | 00:23 |
SpamapS | Pretty sure a quick patch to .xresources and you're good ;) | 00:23 |
mordred | shrug. I think long lines are incredibly rude | 00:23 |
mordred | but - really, it's not worth arguing about | 00:23 |
SpamapS | I do think lower line length limits results in better code modularity. | 00:24 |
mordred | I've given up on thinking that computers will ever remain enjoyable or that usability concerns from anyone will ever be given attention | 00:24 |
SpamapS | You don't get the nested conditional hell | 00:24 |
mordred | or fun java names :) | 00:24 |
SpamapS | so, I just wasted like, all day, because I had `region: us-east-1` in my nodepool.yaml and the AWS driver uses `region-name:` ... | 00:25 |
SpamapS | Do the other providers validate the keys in the provider entries? | 00:25 |
mordred | SpamapS: DOH | 00:25 |
mordred | SpamapS: I feel likey they do? | 00:25 |
SpamapS | would have been nice to get an eh-splosion at parse time rather than node launch. | 00:25 |
mordred | yeah. especially since they're known values | 00:25 |
SpamapS | ya... | 00:26 |
SpamapS | but the good news is.. multi-region works. :) | 00:26 |
mordred | SpamapS: although - I've been considering a patch to openstacksdk to accept both region and region-name - because Shrews and I had the inverse of those problem the other day | 00:26 |
mordred | \o/ | 00:26 |
SpamapS | haha yeah | 00:26 |
SpamapS | boto3 wants region_name | 00:27 |
SpamapS | so it makes sense for the AWS driver | 00:27 |
mordred | totes | 00:27 |
mordred | I think it's the right choice for nodepool - and that nodepool should throw a nice validation error | 00:28 |
pabelanger | so, looking at http://git.zuul-ci.org/cgit/zuul-jobs/tree/roles/htmlify-logs/library/htmlify.py would people object to adding multi-line select support? eg: http://foo#L12-15 ? | 00:38 |
pabelanger | just had a request for that from ansible molecule team | 00:39 |
pabelanger | Follow question, any ideas where I can go learn how to do that in javascript :) | 00:39 |
tristanC | pabelanger: fwiw i already proposed multi-line selection here: https://review.openstack.org/#/c/580891/ | 00:41 |
pabelanger | tristanC: looking | 00:41 |
mordred | pabelanger: I find the best way to learn javascript is to say "hey tristanC" | 00:41 |
mordred | pabelanger: oh - that's for os_loganalyze. we'll need to to port that in to htmlify | 00:43 |
pabelanger | tristanC: cool thanks! so it looks like we could update htmlify-logs to do some of that too. Since that role is based on os_loganalyize | 00:43 |
pabelanger | mordred: yah! | 00:43 |
pabelanger | thanks! I'll maybe try working on that tomorrow | 00:44 |
corvus | friendly reminder about the future-of-logs spec: https://review.openstack.org/648714 | 00:45 |
pabelanger | thanks, I haven't had a chance to read. Will do so tomorrow too | 00:46 |
tristanC | would it possible to get a review of https://review.openstack.org/637670 please? | 00:47 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add triggers information to pipeline list https://review.openstack.org/637670 | 00:55 |
tristanC | corvus: thanks! | 00:55 |
*** swest has quit IRC | 01:26 | |
*** swest has joined #zuul | 01:40 | |
*** bhavikdbavishi1 has joined #zuul | 01:59 | |
*** bhavikdbavishi has quit IRC | 01:59 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 01:59 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: honor allowed-labels setting in the REST API https://review.openstack.org/653895 | 02:01 |
*** jangutter has joined #zuul | 02:07 | |
*** jangutter has quit IRC | 02:12 | |
*** jamesmcarthur has joined #zuul | 02:48 | |
*** jamesmcarthur has quit IRC | 02:53 | |
*** jamesmcarthur has joined #zuul | 02:58 | |
*** irclogbot_0 has quit IRC | 03:05 | |
*** edmondsw has quit IRC | 03:08 | |
*** irclogbot_2 has joined #zuul | 03:10 | |
*** jamesmcarthur has quit IRC | 03:32 | |
*** bhavikdbavishi has quit IRC | 03:58 | |
*** bhavikdbavishi has joined #zuul | 04:00 | |
*** jamesmcarthur has joined #zuul | 04:01 | |
*** jangutter has joined #zuul | 04:08 | |
*** jamesmcarthur has quit IRC | 04:08 | |
*** jangutter has quit IRC | 04:12 | |
*** bhavikdbavishi1 has joined #zuul | 04:36 | |
*** bhavikdbavishi has quit IRC | 04:37 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 04:37 | |
*** jamesmcarthur has joined #zuul | 04:44 | |
*** jamesmcarthur has quit IRC | 04:48 | |
*** jamesmcarthur has joined #zuul | 05:21 | |
*** jamesmcarthur has quit IRC | 05:27 | |
*** jangutter has joined #zuul | 06:09 | |
*** jangutter has quit IRC | 06:13 | |
*** jamesmcarthur has joined #zuul | 06:23 | |
*** jamesmcarthur has quit IRC | 06:28 | |
*** chandankumar is now known as raukadah | 06:40 | |
*** jamesmcarthur has joined #zuul | 06:45 | |
*** jamesmcarthur has quit IRC | 06:51 | |
*** pcaruana has joined #zuul | 07:12 | |
*** yolanda_ has joined #zuul | 07:24 | |
*** bhavikdbavishi has quit IRC | 07:25 | |
*** bhavikdbavishi has joined #zuul | 07:25 | |
*** jamesmcarthur has joined #zuul | 07:27 | |
*** jamesmcarthur has quit IRC | 07:32 | |
*** hashar has joined #zuul | 07:44 | |
*** bhavikdbavishi has quit IRC | 07:54 | |
*** bhavikdbavishi has joined #zuul | 08:00 | |
*** jangutter has joined #zuul | 08:10 | |
*** jamesmcarthur has joined #zuul | 08:12 | |
*** jangutter has quit IRC | 08:14 | |
*** jamesmcarthur has quit IRC | 08:17 | |
*** bhavikdbavishi has quit IRC | 08:18 | |
*** electrofelix has joined #zuul | 08:32 | |
*** raukadah has quit IRC | 09:15 | |
*** chandankumar has joined #zuul | 09:16 | |
*** jamesmcarthur has joined #zuul | 10:11 | |
*** pcaruana has quit IRC | 10:17 | |
*** jamesmcarthur has quit IRC | 10:18 | |
*** jamesmcarthur has joined #zuul | 10:23 | |
*** jamesmcarthur has quit IRC | 10:27 | |
*** bhavikdbavishi has joined #zuul | 10:30 | |
*** hashar is now known as hasharLunch | 10:37 | |
*** jamesmcarthur has joined #zuul | 10:54 | |
*** jamesmcarthur has quit IRC | 10:59 | |
*** hasharLunch is now known as hashar | 11:15 | |
*** hashar has quit IRC | 11:30 | |
*** hashar has joined #zuul | 11:31 | |
*** hashar has quit IRC | 11:35 | |
*** hashar has joined #zuul | 11:39 | |
*** edmondsw has joined #zuul | 11:51 | |
*** jangutter has joined #zuul | 12:08 | |
*** jangutter has quit IRC | 12:12 | |
*** sajauddin has joined #zuul | 12:24 | |
sajauddin | I work for Openstack CI on Power (Power KVM CI). I am trying to setup up ZuulV3, so that we can upgrade from Zuul V2 to V3. Already installed Zuul, looking for documentation which can help me in configuring dependent modules like ansible playbooks, nodepool, pipeline/jobs etc Currently following Zuul official documentation... it is a bit confusing. If anyone has any documentation related to Zuul V3, please share. | 12:24 |
*** bhavikdbavishi has quit IRC | 12:40 | |
*** sajauddin has quit IRC | 12:40 | |
*** bhavikdbavishi has joined #zuul | 12:41 | |
*** jamesmcarthur has joined #zuul | 12:55 | |
*** jamesmcarthur has quit IRC | 13:00 | |
*** jamesmcarthur has joined #zuul | 13:01 | |
*** jamesmcarthur has quit IRC | 13:11 | |
*** jamesmcarthur has joined #zuul | 13:24 | |
*** jamesmcarthur has quit IRC | 13:35 | |
SpamapS | Turns out the schemas in nodepool are only used in the config-validate subcommand... | 13:40 |
*** jamesmcarthur has joined #zuul | 13:47 | |
mordred | SpamapS: ah, yes | 13:50 |
*** jamesmcarthur has quit IRC | 13:52 | |
*** jamesmcarthur has joined #zuul | 13:55 | |
*** jamesmcarthur has quit IRC | 13:59 | |
*** jangutter has joined #zuul | 14:09 | |
*** jamesmcarthur has joined #zuul | 14:13 | |
*** jangutter has quit IRC | 14:14 | |
*** jamesmcarthur has quit IRC | 14:18 | |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Ensure config is always validated https://review.openstack.org/653953 | 14:35 |
SpamapS | mordred:^ This fixes that | 14:35 |
mordred | SpamapS: I believe we actually didn't do that on purpose - becuase if we bomb-out on bad config, then rolling out config file changes can cause the whole service to go down - I believe we run config-validate on config files in the gate | 14:37 |
SpamapS | mordred: That's not realy how anybody expects daemons to behave though.. right? | 14:38 |
SpamapS | And the config-validate check you're talking about will still guard against it. | 14:38 |
mordred | SpamapS: I may not be following your pronouns | 14:39 |
SpamapS | The situation you don't want is that you HUP nodepool-launcher and everything goes down. | 14:39 |
SpamapS | You can still config-validate before you do that. | 14:39 |
mordred | ah - yes. | 14:39 |
mordred | thanks - those words are easier to follow :) | 14:39 |
SpamapS | But most folks would expect that when they try to start a daemon that has an invalid configuration, it would not start up. | 14:40 |
SpamapS | It's certainly an assumption I made. | 14:40 |
SpamapS | and wasted a crapton of time for me because I didn't even know config-validate existed.. :-P | 14:40 |
SpamapS | and #MAGIC made things work for a while. | 14:41 |
SpamapS | And in a container world.. you don't throw away your old containers until the new ones work anyway. | 14:42 |
SpamapS | So a crashing nodepool-launcher with a bad config in kubernetes will just result in the old one staying around forever. | 14:42 |
*** jamesmcarthur has joined #zuul | 14:55 | |
electrofelix | testing out the zuul docker compose env from behind a proxy, how does one set a proxy for a particular type of node that is inherited by the job running in that environment? Or is this a modify the ansible definition of a job? | 14:56 |
mordred | electrofelix: I believe tobiash does things with proxies, so might have some good insights | 14:59 |
*** jamesmcarthur has quit IRC | 15:05 | |
*** jamesmcarthur has joined #zuul | 15:06 | |
electrofelix | mordred: hopefully, I'd thought that ansible tasks would pick up the env on the remote host, guessing probably had to workaround that in the past | 15:06 |
-openstackstatus- NOTICE: Gerrit is offline for several hours starting at 15:00 UTC to perform the opendev migration; see http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005011.html | 15:07 | |
*** ChanServ changes topic to "Gerrit is offline for several hours starting at 15:00 UTC to perform the opendev migration; see http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005011.html" | 15:07 | |
tobiash | electrofelix: can you be more precise? Connecting from the executor via proxy to a node or downloading stuff via proxy on the node? | 15:24 |
electrofelix | tobiash: latter, I'm currently looking at fudging it a bit by injecting the proxy env variables into ~/.ssh/environment and configuring the ssh in the node container to enable PermitUserEnvironment to see if ansible can pick it up, believe it's the problem of non-interactive shel | 15:25 |
*** hashar has quit IRC | 15:25 | |
*** jamesmcarthur has quit IRC | 15:30 | |
*** jamesmcarthur has joined #zuul | 15:31 | |
electrofelix | tobiash mordred: rebuilding with a node-Dockerfile that enables PermitUserEnvironment for sshd works for the compose env | 15:33 |
electrofelix | I suspect the same issue tripped me up when trying out software-factory, the runc based node possibly doesn't have the proxies set in the environment in a way that is picked up by a non-interactive ssh connection which is the default for ansible | 15:36 |
*** tjgresha has joined #zuul | 15:40 | |
*** jangutter has joined #zuul | 16:10 | |
*** jangutter has quit IRC | 16:14 | |
*** mgoddard has quit IRC | 16:34 | |
*** mgoddard has joined #zuul | 16:35 | |
*** electrofelix has quit IRC | 16:36 | |
*** mgoddard has quit IRC | 16:44 | |
*** mgoddard has joined #zuul | 16:45 | |
*** mattw4 has joined #zuul | 16:48 | |
*** jamesmcarthur has quit IRC | 17:40 | |
mattw4 | Hi there #zuul, does anyone have a minute to talk about secrets? Seriously though, I am trying to setup Zuul and stumped on how to store secrets, apparently all in public repos | 17:48 |
clarkb | mattw4: many of us are busy in the middle of a great big git repo reorganization. But have you seen the docs? and have you seen the zuul/tools/encrypt-secret tool? | 17:50 |
clarkb | (that script name might not be right) | 17:50 |
clarkb | basically zuul creates private keys for every repo. It then publishes the public key for the repos. You fetch the public key and encrypt locally and push the result into the repo | 17:51 |
clarkb | that tool/ dir script will do that for you | 17:51 |
mattw4 | clarkb, yep, I think I've read everything on Secrets, Encryption, and have successfully used the encrypt_secrets.py | 17:51 |
mattw4 | clarkb, so you just publish that secret config in your repo's Zuul config? | 17:52 |
clarkb | yup the resulting cipher text goes into your .zuul.yaml as a secret | 17:52 |
clarkb | then playbooks in that repo will have access to the secret decrypted data when zuul executes them (as ansible variables) | 17:53 |
mattw4 | That's what I figured from the docs, but publishing ssh_username along with an (encrypted0 private key is making me nervous. I figured I must be missing something | 17:53 |
clarkb | usernames are not typically private data | 17:54 |
clarkb | (though you can encrypt that too if you like) | 17:54 |
mattw4 | that's a good point | 17:54 |
mattw4 | thank you for your time clarkb | 17:55 |
*** jamesmcarthur has joined #zuul | 17:55 | |
*** jamesmcarthur has quit IRC | 17:55 | |
mattw4 | clarkb: one more question if you have a second: can you point out any "live" examples of this configuration? | 17:56 |
clarkb | I can point you to our configs, but due to the mentioned git repo migration the urls may not always be accessible | 17:57 |
clarkb | https://git.openstack.org/cgit/opendev/ | 17:57 |
clarkb | er | 17:57 |
clarkb | that is incomplete | 17:57 |
clarkb | https://git.openstack.org/cgit/opendev/base-jobs/tree/zuul.yaml#n25 | 17:57 |
mattw4 | clarkb, understood and appreciated!! | 17:57 |
tjgresha | good stuff | 17:58 |
*** jangutter has joined #zuul | 18:11 | |
*** jangutter has quit IRC | 18:15 | |
*** edmondsw has quit IRC | 18:33 | |
*** edmondsw_ has joined #zuul | 18:35 | |
*** rf0lc0 has joined #zuul | 18:43 | |
*** rfolco has quit IRC | 18:46 | |
*** jamesmcarthur has joined #zuul | 19:45 | |
*** jangutter has joined #zuul | 20:12 | |
*** jamesmcarthur has quit IRC | 20:14 | |
*** jangutter has quit IRC | 20:16 | |
*** ianw_pto is now known as ianw | 21:37 | |
*** jamesmcarthur has joined #zuul | 21:53 | |
*** jamesmcarthur has quit IRC | 21:58 | |
*** jamesmcarthur has joined #zuul | 22:00 | |
*** jangutter has joined #zuul | 22:12 | |
*** jangutter has quit IRC | 22:17 | |
*** jamesmcarthur has quit IRC | 22:49 | |
*** jamesmcarthur has joined #zuul | 22:56 | |
*** jamesmcarthur has quit IRC | 23:11 | |
*** mattw4 has quit IRC | 23:12 | |
*** jamesmcarthur has joined #zuul | 23:18 | |
*** jamesmcarthur has quit IRC | 23:28 | |
*** jamesmcarthur has joined #zuul | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!