| SpamapS | gah... still racey and ineffective | 00:20 |
|---|---|---|
| *** zxiiro is now known as zxiiro-away | 00:20 | |
| *** jamesmcarthur has quit IRC | 00:24 | |
| tristanC | what can cause a retry_limit failure to result in a finger log_url? | 00:28 |
| clarkb | tristanC: that happens when the log url isnt overwritten by the post playbooks zuul return | 00:29 |
| clarkb | I like to debug those by grepping the executor log | 00:30 |
| clarkb | you can grep ueing the uuid in the finger url | 00:30 |
| tristanC | oh, so the base post-run is executed even when the base pre-run failed right? | 00:37 |
| openstackgerrit | Merged openstack-infra/nodepool master: Use yaml.safe_load instead of load https://review.openstack.org/648436 | 00:38 |
| tristanC | clarkb: thanks, i'll grep then | 00:41 |
| *** jamesmcarthur has joined #zuul | 00:55 | |
| *** jamesmcarthur has joined #zuul | 00:56 | |
| tristanC | it seems like a broken python on the test node results in indeterminate pre-run which short-cut the post-run phase. | 00:56 |
| *** pwhalen has quit IRC | 01:12 | |
| *** toabctl has quit IRC | 01:12 | |
| *** kklimonda has quit IRC | 01:12 | |
| *** kklimonda has joined #zuul | 01:12 | |
| jhesketh | corvus: thanks for the reviews on the runner set, I'll try and address them today or tomorrow | 01:56 |
| *** spsurya has joined #zuul | 02:12 | |
| *** bhavikdbavishi has joined #zuul | 02:26 | |
| *** bhavikdbavishi has quit IRC | 02:30 | |
| *** jamesmcarthur has quit IRC | 02:31 | |
| *** bhavikdbavishi has joined #zuul | 02:37 | |
| *** jamesmcarthur has joined #zuul | 03:01 | |
| openstackgerrit | Merged openstack-infra/zuul master: Add web / fingergw connections for components graph https://review.openstack.org/645852 | 05:03 |
| *** bjackman has joined #zuul | 05:18 | |
| bjackman | tobiash, mordred sorry I had to run last night - yes I am running the latest Gerrit | 05:18 |
| bjackman | I also think there is an issue with the search for patches depending on an updated patch | 05:19 |
| bjackman | I posted a fix for that a few months ago because the URL format was different, but either my fix is now outdated or it was broken to begin with | 05:19 |
| bjackman | Really hoping I can get some time to get up and running to fix it again soon but not sure! | 05:19 |
| bjackman | (Sorry I'm not being clear - I'm talking about when patch A "Depends-On" patch B, patch B fails tests, then a new patchset is uploaded and it now passes. Patch A doesn't get re-tested) | 05:21 |
| *** toabctl has joined #zuul | 05:21 | |
| tristanC | bjackman: i think that's expected, change using depends-on doesn't get re-tested when the dependencies gets updated | 05:27 |
| tristanC | bjackman: however, if A is approved, then when B is approved, A should be enter the gate automatically. I remember fixing that for gerrit 2.14 already... | 05:28 |
| *** quiquell|off is now known as quiquell | 05:42 | |
| bjackman | tristanC, Oh that's right - I was actually thinking of when B is approved. I have seen examples where B actually gets merged but A doesn't regate. But I haven't had time to fully investigate yet, it could be something wrong in my config | 05:56 |
| bjackman | My original fix for 2.16 was f605862a4d "Fix "reverse" Depends-On detection with new Gerrit URL schema" | 05:58 |
| *** hashar has joined #zuul | 06:01 | |
| tristanC | bjackman: fwiw, here was the fix for 2.14: https://review.openstack.org/577154 | 06:11 |
| *** hashar has joined #zuul | 06:13 | |
| *** adam_g has joined #zuul | 06:24 | |
| *** bhavikdbavishi1 has joined #zuul | 06:32 | |
| *** bhavikdbavishi has quit IRC | 06:33 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:33 | |
| *** pcaruana has joined #zuul | 06:36 | |
| *** pcaruana has quit IRC | 06:38 | |
| *** pcaruana has joined #zuul | 06:38 | |
| *** gtema has joined #zuul | 06:42 | |
| *** jpena|off is now known as jpena | 06:55 | |
| *** quiquell is now known as quiquell|brb | 06:56 | |
| openstackgerrit | Merged openstack-infra/nodepool master: Use opendev docker jobs https://review.openstack.org/649465 | 07:03 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Slide presentation for Zuul's OIP Confirmation https://review.openstack.org/649356 | 07:17 |
| *** shachar has quit IRC | 07:30 | |
| *** yolanda has joined #zuul | 07:33 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Slide presentation for Zuul's OIP Confirmation https://review.openstack.org/649356 | 07:41 |
| *** snapiri has joined #zuul | 07:46 | |
| *** quiquell|brb is now known as quiquell | 07:53 | |
| *** lennyb has joined #zuul | 08:04 | |
| sshnaidm|rover | is there a way to pass "Depends-On" via job definition in zuul? | 08:38 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add tags to jobs list https://review.openstack.org/633654 | 08:39 |
| mordred | sshnaidm|rover: those words don't quite make sense to my brain - depends-on is about saying a given change depends on another change. could you maybe say some additional or different words about what you're wanting? | 08:44 |
| sshnaidm|rover | mordred, yeah, I want to run specific job which will clone always the same change | 08:46 |
| sshnaidm|rover | mordred, for example there is a change on repo A, and job on repo B that has A in "Required projects" | 08:47 |
| sshnaidm|rover | mordred, like override-checkout, just with specific change, not branch | 08:47 |
| *** hashar has quit IRC | 08:48 | |
| mordred | oh - weird - so - like, if, for a period of time, _all_ changes coming in to repo B were essentially going to need to depends-on that chagne in repo A | 08:48 |
| sshnaidm|rover | mordred, well, the longer I think about it, the more weird it seems.. Can be override-checkout not a branch, but a gerrit refspec? | 08:50 |
| sshnaidm|rover | mordred, ok, ignore it, just was thinking loudly :D | 08:51 |
| mordred | :) | 08:51 |
| mordred | sshnaidm|rover: in any case - no, there is no facility for doing such a thing currently. I'm not sure if adding the ability would be desirable - would definitely want to get corvus input on that one, and I'm certain he'd want to understand the use-case (I can almost imagine one or two use cases where someone could find themselves in such a scenario, but I'd be making stuff up) | 08:52 |
| mordred | it sounds like an awkward scenario to be in for the developers of B - but we all know devs get themselves into awkward scenarios all the time :) | 08:52 |
| fbo | mordred: hi, yes for Pagure the last known blocking issue has been resolved. Last PS have the inline description updated. Now the driver is usable with the current pagure.io instance. | 08:56 |
| fbo | mordred: I plan to showcase the driver to Pagure devs next week :) | 08:56 |
| mordred | fbo: SWEET! | 08:57 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions https://review.openstack.org/576907 | 09:28 |
| *** bhavikdbavishi has quit IRC | 09:30 | |
| *** electrofelix has joined #zuul | 09:49 | |
| *** jpena has quit IRC | 10:16 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Allow operator to generate auth tokens through the CLI https://review.openstack.org/636197 | 10:23 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul CLI: allow access via REST https://review.openstack.org/636315 | 10:24 |
| *** sshnaidm|rover is now known as sshnaidm|bbl | 10:27 | |
| *** jpena has joined #zuul | 10:28 | |
| bjackman | Is there a way to set up a docker-compose file that just builds all the images from the Zuul source and runs them? | 10:29 |
| bjackman | Or is there perhaps a way to run 'docker build' from the root of the Zuul tree in such a way that each of the generated images gets the proper name? | 10:30 |
| bjackman | (sorry, just remembered when I last investigated this I actually figured it out - just need to run muliple "docker build" commands with different --target and --tag params | 10:36 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Add Authorization Rules configuration https://review.openstack.org/639855 | 10:39 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine https://review.openstack.org/640884 | 10:41 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 10:43 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 10:43 |
| *** quiquell is now known as quiquell|lunch | 10:48 | |
| *** jpena is now known as jpena|lunch | 11:02 | |
| *** gtema has quit IRC | 11:17 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Add Authorization Rules configuration https://review.openstack.org/639855 | 11:18 |
| *** quiquell|lunch is now known as quiquell | 11:24 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine https://review.openstack.org/640884 | 11:31 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 11:32 |
| *** rlandy has joined #zuul | 11:55 | |
| *** bhavikdbavishi has joined #zuul | 11:59 | |
| *** jpena|lunch is now known as jpena | 12:02 | |
| *** pwhalen has joined #zuul | 12:08 | |
| *** odyssey4me has quit IRC | 12:12 | |
| *** quiquell is now known as quiquell|brb | 12:13 | |
| bjackman | Does anyone know why I might be getting this exception in my zuul-web? https://paste.gnome.org/pbtpwiisd When I try to stream logs from a running job | 12:23 |
| *** odyssey4me has joined #zuul | 12:26 | |
| *** jamesmcarthur has quit IRC | 12:26 | |
| *** jamesmcarthur has joined #zuul | 12:27 | |
| *** jamesmcarthur has quit IRC | 12:36 | |
| *** jamesmcarthur_ has joined #zuul | 12:43 | |
| *** quiquell|brb is now known as quiquell | 12:54 | |
| *** bjackman has quit IRC | 12:57 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 12:59 |
| *** sshnaidm|bbl is now known as sshnaidm | 13:03 | |
| *** gtema has joined #zuul | 13:03 | |
| *** gtema has quit IRC | 13:07 | |
| *** gtema has joined #zuul | 13:08 | |
| *** bhavikdbavishi has quit IRC | 13:27 | |
| *** shachar has joined #zuul | 13:53 | |
| *** yolanda has quit IRC | 13:55 | |
| *** snapiri has quit IRC | 13:56 | |
| openstackgerrit | Stephen Finucane proposed openstack-infra/zuul master: tox: Integrate tox-docker https://review.openstack.org/649041 | 14:05 |
| *** yolanda has joined #zuul | 14:12 | |
| *** swest has quit IRC | 14:24 | |
| *** bjackman has joined #zuul | 14:31 | |
| corvus | pabelanger: you'll want to review https://review.openstack.org/649427 | 14:35 |
| openstackgerrit | Merged openstack-infra/nodepool master: Make local dib file cleanup method a static method https://review.openstack.org/649166 | 14:35 |
| pabelanger | looking | 14:37 |
| pabelanger | +3 thanks! | 14:39 |
| *** bhavikdbavishi has joined #zuul | 14:39 | |
| Shrews | corvus: did you want to take a look at https://review.openstack.org/647599 before I recheck it? | 14:39 |
| corvus | Shrews: it was on my list to review today...but feel free to go ahead and recheck it... i'll have enough time :) | 14:42 |
| Shrews | corvus: i'll just wait. don't want it to merge before you've looked | 14:44 |
| pabelanger | tobiash: corvus: I also left a comment on 648865 about commit message | 14:45 |
| openstackgerrit | Nicolas Hicher proposed openstack-infra/zuul-jobs master: Propose submit-logstash role to export logs https://review.openstack.org/649426 | 14:45 |
| *** yolanda has quit IRC | 14:50 | |
| corvus | Shrews: i was thinking we could probably actualy reset the zk connection in the test, but the mock is probably just as good; +2 | 14:51 |
| *** bhavikdbavishi has quit IRC | 14:51 | |
| *** bhavikdbavishi has joined #zuul | 14:51 | |
| *** yolanda has joined #zuul | 14:57 | |
| Shrews | corvus: that would affect all the tests since they share a zk connection | 14:57 |
| Shrews | oh wait.. maybe they don't | 14:58 |
| Shrews | i forget they each have a different chroot. anyway... | 14:59 |
| Shrews | i'll try it out on nb01 after it merges | 15:00 |
| openstackgerrit | Merged openstack-infra/zuul master: Prepend path with bin dir of ansible virtualenv https://review.openstack.org/649427 | 15:09 |
| bjackman | Managed to spend a little time tracking down the Depends-On issue with latest Gerrit, seems the issue is with the "gerrit query" command generated by simpleQuery in getChangesDependingOn | 15:12 |
| bjackman | https://paste.gnome.org/piwvkqbfq | 15:13 |
| bjackman | I initially thought it was caused by missing quotes, but I modified the code to add them and still got the same error from Gerrit: line 1:15 mismatched input \u0027:\u0027 expecting \u0027)\u0027 | 15:13 |
| bjackman | (\u0027 is the ' character) | 15:14 |
| bjackman | But now I gotta head, hopefully can get back to this in the next few days! | 15:14 |
| corvus | bjackman: it could be that we're not expecting there to be a port number in there and that needs extra escaping | 15:15 |
| corvus | (ie, it's usually "gerrit/1008" not "gerrit:8080/1008", and the extra colon trips up gerrit's parser) | 15:16 |
| bjackman | corvus, ah yeah good point | 15:16 |
| bjackman | In my actual deployment there isn't a port number in the URL so I suspect there is a 2nd issue behind this one | 15:17 |
| bjackman | But haven't taken the time to track down the error in the logs yet | 15:17 |
| pabelanger | Question around removing a project from zuul, I looked at our documentation and didn't see anything specific. is there anything I need to worry about before doing so? For example, should I move the project in tenant config to not load any configuration from the project, then remove? Or remove any in-tree jobs and set to noop? | 15:18 |
| *** swest has joined #zuul | 15:18 | |
| corvus | pabelanger: i can't think of why any special steps would be necessary (unless you were planning on adding it back later) | 15:19 |
| *** bjackman has quit IRC | 15:19 | |
| pabelanger | corvus: okay, thanks! | 15:19 |
| *** bjackman has joined #zuul | 15:19 | |
| corvus | bjackman: it looks like that url comes from gerrit itself, so it's probably just whatever gerrit is configured with as its own url | 15:20 |
| corvus | bjackman: this one: https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#http | 15:21 |
| clarkb | pabelanger: openstack sets jobs to noop on the project so t jat we can merge the retirement commit the we remove the project from zuuls config. I believe the retiremwnt commit shakes out any usersof jobs | 15:21 |
| openstackgerrit | Merged openstack-infra/zuul master: Add link to builds in job page https://review.openstack.org/648864 | 15:22 |
| *** swest has quit IRC | 15:22 | |
| corvus | bjackman: so i'd say: 1) if you don't need a port in your environment, you can update that config setting and it should work, and 2) regardless of that, we should support that in zuul and fix the escaping | 15:23 |
| pabelanger | clarkb: yah, project in this case is being moved between 2 zuuls. Maybe it is better to just unload all zuul configuration from the project, then add it back one in new zuul. | 15:27 |
| pabelanger | little more work, but should unload everything from zuul A | 15:27 |
| corvus | pabelanger: yeah, i'd get rid of the in-tree config in that case | 15:28 |
| pabelanger | kk | 15:28 |
| bjackman | corvus, ah yeah, I mean the environment I'm testing in has a port (I'm using a modified version of the Getting Started Guide docker-compose file) but in the ultimate deployment environment (where the Depends-On also isn't working properl) there is no port in the URL | 15:29 |
| *** bhavikdbavishi has quit IRC | 15:36 | |
| *** swest has joined #zuul | 15:37 | |
| *** quiquell is now known as quiquell|off | 15:38 | |
| *** rlandy is now known as rlandy|ruck | 15:40 | |
| *** jamesmcarthur_ has quit IRC | 15:53 | |
| *** bhavikdbavishi has joined #zuul | 15:58 | |
| *** bhavikdbavishi has quit IRC | 16:05 | |
| *** bhavikdbavishi has joined #zuul | 16:06 | |
| fungi | sshnaidm: is the job-wide depends-on question in service of that thing you were trying to do a while back to hard-code a checkout of one project to always use a specific unmerged gerrit change? | 16:08 |
| sshnaidm | fungi, the second one mostly | 16:09 |
| sshnaidm | fungi, to define a job that will have specific unmerged gerrit change in it | 16:10 |
| fungi | i thought you were going to solve that by just carrying a patch file in the git tree and applying it locally during the job | 16:10 |
| fungi | rather than using gerrit as a place to store code modifications indefinitely | 16:10 |
| sshnaidm | fungi, well, yeah, I thought about options to have it in job definition, but seems like ugly.. | 16:10 |
| sshnaidm | fungi, maybe it's unclear w/o context, but it's CI job that installs zuul, gerrit, etc and configure a "one-time" job to run, and I'm interested to have this jog to grab some changes sometimes | 16:11 |
| openstackgerrit | Merged openstack-infra/nodepool master: Fix for image build leaks https://review.openstack.org/647599 | 16:12 |
| sshnaidm | fungi, maybe sometimes it could be a good option for Zuul CI itself.. | 16:12 |
| *** jamesmcarthur has joined #zuul | 16:12 | |
| sshnaidm | as we can detect some integration problems | 16:13 |
| *** jpena is now known as jpena|off | 16:14 | |
| fungi | we do already have ci jobs which install zuul and gerrit and test them together, if you need to borrow inspiration from them | 16:14 |
| *** jamesmcarthur has quit IRC | 16:15 | |
| sshnaidm | fungi, cool, where can I see it? | 16:16 |
| fungi | sshnaidm: https://git.zuul-ci.org/cgit/zuul/tree/.zuul.yaml#n77 | 16:19 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Use the buildset registry in zuul-quick-start https://review.openstack.org/649467 | 16:20 |
| *** jamesmcarthur has joined #zuul | 16:23 | |
| corvus | pabelanger, fungi: can you review https://review.openstack.org/649456 so i can continue work on the new tenant? | 16:23 |
| pabelanger | +3 | 16:26 |
| *** gtema has quit IRC | 16:32 | |
| openstackgerrit | Merged openstack-infra/zuul-sphinx master: Run opendev-release-python on release https://review.openstack.org/649456 | 16:35 |
| *** spsurya has quit IRC | 16:46 | |
| corvus | i'd like to tag zuul-sphinx 0.4.1 at e44c1ba815a7285d28c1dcbd01b6967455d6cb97 | 16:46 |
| corvus | no changes, but it is a different commit than 0.4.1 -- just to exercise the release machinery | 16:47 |
| corvus | fungi, clarkb, tobiash, pabelanger: any objections? | 16:47 |
| clarkb | do you mean 0.4.2? | 16:48 |
| corvus | oh, yes, sorry -- to be clear, i want to tag e44c1ba815a7285d28c1dcbd01b6967455d6cb97 as 0.4.1, which is a different commit than 0.4.0, the current latest release | 16:49 |
| corvus | (it's one commit later, it's just .zuul.yaml changes) | 16:50 |
| clarkb | wfm | 16:50 |
| *** jamesmcarthur has quit IRC | 16:52 | |
| fungi | ahh, so it's the commit immediately following the one tagged 0.4.0 in the master branch history | 16:52 |
| fungi | yeah, looks sane to me | 16:53 |
| *** jamesmcarthur has joined #zuul | 16:56 | |
| *** hashar has joined #zuul | 16:58 | |
| mordred | ++ | 17:00 |
| mordred | Shrews: I'm on a plane, so my ability to have useful conversations is limited - but it might be worthwhile to chat with corvus about the metric naming stuff | 17:07 |
| corvus | oh, yeah, there was something about us flapping on that? | 17:07 |
| mordred | yeah. I've peronally waffled in both directions on this topic - so I'm honestly interested in whatever synthesis of thoughts humans have | 17:08 |
| Shrews | corvus: yeah. nodepool used to do metric names with '.' in them. ianw put up a change to make them all camelcase a while back. allowing the new openstacksdk to report the metrics would move us back to using '.' | 17:08 |
| Shrews | for the tl;dr of it | 17:09 |
| corvus | do you have a link to ianw's change? | 17:10 |
| Shrews | i'm working with mordred on an idea to allow a user of openstacksdk to specify a name formatting function, but that's taking a bit of rearchitecting | 17:10 |
| * Shrews looks | 17:10 | |
| corvus | https://review.openstack.org/605898 is it that? | 17:11 |
| Shrews | corvus: https://review.openstack.org/605898 | 17:11 |
| Shrews | bah | 17:11 |
| corvus | Shrews: so to take an example from that change, would ComputePostOsVolumesBoot would become compute.POST.os-volumes_boot ? | 17:15 |
| Shrews | i'm not entirely certain what it would now become under new openstacksdk. mordred? | 17:15 |
| Shrews | i think he had something in the release note | 17:16 |
| corvus | there's a second change that's relevant to the historical record: https://review.openstack.org/585397 | 17:16 |
| Shrews | https://review.openstack.org/#/c/640643/6/releasenotes/notes/task-manager-replaced-12e4b3a0108f9358.yaml | 17:16 |
| corvus | so 585397 changed nodepool from compute.POST.os-volumes_boot to ComputePostOs-volumes_boot then 605898 changed it to ComputePostOsVolumesBoot | 17:17 |
| corvus | 585397 describes the dot separated as openstacksdk-style, and the camelcase-with-punctuation as shade-style... | 17:18 |
| corvus | so i think question #1 is: which thing does the new version of opensdk use? camelcase-with-punctuation (ComputePostOs-volumes_boot) or dot-separated (compute.POST.os-volumes_boot) ? | 17:19 |
| corvus | er, openstacksdk | 17:19 |
| Shrews | based on the release note i pasted, i'm assuming the latter, but mordred should probably confirm | 17:20 |
| corvus | Shrews: i agree, let's take that as the provisional answer to #1 | 17:20 |
| corvus | question #2 is, i think, are we okay with that in nodepool? since we're going all the way back to that form, we're effectively reverting both changes to nodepool (mordred's 585397 and ianw's 605898). neither commit message describes any *problems* with a given syntax, so it's hard to say how necessary each change is. ianw's promotes some consistency (in that there are no separators), but it may not be as | 17:24 |
| corvus | necessary in the dot form. the dot form does cause a deeper hierarchy of keys. there's a *minor* benefit to that in that it allows someone to easily sum all of the "compute" calls, but i'm not sure how useful that is in practice. there isn't really a downside to having a deeper hierarchy, from what i can see. | 17:24 |
| corvus | so i think the way i'm leaning is that i'm probably not going to get too worked up over the format changing again, but let's check with ianw who is more intimately acquanted with using these keys in grafana dashboards to see if that format will pose a logistical problem. | 17:25 |
| Shrews | my concern would be forcing folks to update their graphing stuff, but yeah, let's see what ianw says too | 17:25 |
| corvus | Shrews: the docs part of https://review.openstack.org/640643 also agrees with your assesment of the new format | 17:26 |
| corvus | that change looks like the best way to record this too -- so let's ask ianw (and anyone else interested) to review that | 17:27 |
| *** spsurya has joined #zuul | 17:27 | |
| Shrews | ++ | 17:29 |
| corvus | i left a +2 with a note on that change | 17:29 |
| openstackgerrit | Merged openstack-infra/nodepool master: Pin openstacsksdk to <0.27.0 https://review.openstack.org/649254 | 17:29 |
| mordred | corvus, Shrews: yes - the sdk is emitting dot-form. I believe the other changes were to ensure we were continuing to match the original nodepool camelcase form | 17:29 |
| mordred | also yay internet is back | 17:30 |
| *** jamesmcarthur has quit IRC | 17:35 | |
| *** bjackman has quit IRC | 17:45 | |
| *** electrofelix has quit IRC | 17:50 | |
| *** themroc has joined #zuul | 17:53 | |
| tobiash | corvus, pabelanger: hrm, I could swear that I pushed a PS on 648865 that switches to tristanC's suggestion | 17:53 |
| tobiash | actuall I don't know why I pushed up PS3 | 17:54 |
| tobiash | that as by accident... | 17:54 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Use a more visible selection color https://review.openstack.org/648865 | 17:56 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Use a more visible selection color https://review.openstack.org/648865 | 17:57 |
| *** bhavikdbavishi has quit IRC | 18:08 | |
| *** bjackman has joined #zuul | 18:10 | |
| *** hashar is now known as hasharStoryTales | 18:11 | |
| *** jamesmcarthur has joined #zuul | 18:17 | |
| *** bjackman has quit IRC | 18:18 | |
| corvus | tobiash: yay code review works! :) | 18:20 |
| tobiash | yepp :) | 18:20 |
| *** jamesmcarthur has quit IRC | 18:21 | |
| pabelanger | tobiash: any pointers on pgup / pgfn for xterm.js? I'm going to try and write a patch for it. | 18:25 |
| tobiash | pabelanger: did you set the focus on the terminal? | 18:25 |
| pabelanger | tobiash: you mean, click it with mouse? | 18:26 |
| tobiash | yes | 18:26 |
| pabelanger | yah, ctrl+pgup doesn't work | 18:26 |
| pabelanger | sorry | 18:26 |
| pabelanger | shift+pgup | 18:26 |
| tobiash | hrm, maybe you need to hook into the key pressed event | 18:30 |
| *** jamesmcarthur has joined #zuul | 18:31 | |
| pabelanger | k, will try and figure it out | 18:31 |
| tobiash | https://github.com/xtermjs/xterm.js/issues/181 | 18:31 |
| tobiash | pabelanger: maybe it's because I disabled stdin | 18:32 |
| tobiash | that might block scrolling as well | 18:33 |
| pabelanger | Oh, maybe | 18:33 |
| pabelanger | tobiash: was there a reason to disable it? | 18:34 |
| tobiash | I first used attach to attach it to the websocket and I didn't want xterm to send stuff to the websocket | 18:34 |
| pabelanger | k | 18:38 |
| tobiash | pabelanger: it works again if I comment out term.attachCustomKeyEventHandler(function () {return false}) | 18:40 |
| tobiash | but I don't know anymore why I added this | 18:41 |
| pabelanger | tobiash: wonder if we should add it back, but only whitelist the keys we actually want | 18:43 |
| tobiash | maybe, I think I wanted to prevent that it 'steals' some key events from the browser window | 18:44 |
| tobiash | but I don't know which anymore | 18:44 |
| tobiash | pabelanger: I don't find any issues locally with this, so we could just remove it and if any issues come up add it with a whitelist | 18:47 |
| pabelanger | tobiash: wfm | 18:47 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Remove custom key handler from xterm https://review.openstack.org/649694 | 18:53 |
| *** sshnaidm is now known as sshnaidm|off | 19:00 | |
| tobiash | pabelanger: I think this was the issue for the addition of that handler: https://github.com/xtermjs/xterm.js/issues/1868 | 19:06 |
| *** hasharStoryTales is now known as hashar | 19:13 | |
| *** sshnaidm_ has joined #zuul | 19:36 | |
| *** sshnaidm|off has quit IRC | 19:36 | |
| corvus | the good news is that the 0.4.1 release job succeeded; the bad news is that it didn't actually upload the release to pypi. details. | 19:46 |
| corvus | 19:49 < openstackgerrit> James E. Blair proposed opendev/base-jobs master: Actually upload to pypi in the python release job https://review.openstack.org/649712 | 19:49 |
| corvus | let's try again with that ^ | 19:49 |
| *** jamesmcarthur has quit IRC | 19:55 | |
| *** themroc has quit IRC | 20:03 | |
| *** mrhillsman is now known as mrhillsman_bbiab | 20:11 | |
| clarkb | mordred: corvus fungi (and anyoen else really) I left a few more notes on https://review.openstack.org/#/c/649356/ but it is looking quite good | 20:12 |
| fungi | thanks! | 20:20 |
| pabelanger | so, I've been trying to figure out why one of my nodepool-builders is having trouble running the nodepool cmd. Every so often, it just seems to have for 60 seconds, before eventually running. Talking with mnaser (he suggested I run it under strace), I eventually caught it hanging on /dev/random: http://paste.openstack.org/show/748831/ is it possible the VM is just running out of entropy? | 20:23 |
| clarkb | pabelanger: yes it is possible. Do you run with haveged? | 20:24 |
| pabelanger | clarkb: I do not, that was going to be my first thing to install and try again | 20:24 |
| pabelanger | mostly wanted to check here first before doing so :) | 20:25 |
| *** jamesmcarthur has joined #zuul | 20:33 | |
| *** hashar has quit IRC | 20:35 | |
| *** jamesmcarthur has quit IRC | 20:39 | |
| *** jamesmcarthur has joined #zuul | 20:41 | |
| clarkb | pabelanger: ya VMs are nororiously bad at having entropy so tools like haveged help a lot | 20:50 |
| pabelanger | clarkb: yah, I think this is going to be the fix. Thanks for the help. | 20:53 |
| clarkb | on https://review.openstack.org/#/c/649356/ aiui we are expected to provide a link to that sometime tomorrow. Should we go ahead and merge something today so that we have a link ready? or do we want to use the logs server link? | 20:58 |
| *** spsurya has quit IRC | 20:59 | |
| corvus | i think we can merge that and do followups | 21:00 |
| corvus | i'm not going to get hung up on perfecting the content in an advance copy of material for an informal presentation :) | 21:01 |
| corvus | clarkb: you're free to +3 | 21:01 |
| clarkb | ok thanks | 21:02 |
| corvus | i've re-enqueued the release job | 21:02 |
| clarkb | I think we probably do want to make the note about the CoC more official somewhere on the website or in the code? At least i'm not seeing if we've already done that | 21:02 |
| clarkb | but otherwise ya I think its msotly just going to be minor stuff | 21:02 |
| corvus | clarkb: i think if you want to add that to the website or the governance section of the manual it's fine | 21:03 |
| clarkb | ok I'll work on a patch for that | 21:03 |
| mordred | clarkb: I've got one - one sec | 21:04 |
| clarkb | oh even better. Shoudl I unapprove the change too? | 21:04 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Add note to community page about code of conduct https://review.openstack.org/649730 | 21:04 |
| mordred | nope. it's a separate patch | 21:04 |
| clarkb | cool it is on its way in | 21:04 |
| mordred | \o/ | 21:05 |
| mordred | I think then we can point jimmy at the url to it - and maybe instead of him making a pdf to send to board members, we can just send them that link too | 21:05 |
| clarkb | mordred: yup I recently confirmed that they would be happy wioth that plan | 21:05 |
| clarkb | I think "pdf" here means "somethign I can open on my computer" | 21:06 |
| mordred | sweet | 21:06 |
| *** pcaruana has quit IRC | 21:06 | |
| openstackgerrit | Merged openstack-infra/zuul-website master: Slide presentation for Zuul's OIP Confirmation https://review.openstack.org/649356 | 21:08 |
| corvus | all right! https://pypi.org/project/zuul-sphinx/ 0.4.1 published | 21:10 |
| corvus | that's with the new opendev jobs | 21:10 |
| corvus | so i think the only "weird" thing left to deal with is the javascript content publish job on zuul itself | 21:10 |
| openstackgerrit | Merged openstack-infra/zuul-website master: Add note to community page about code of conduct https://review.openstack.org/649730 | 21:12 |
| corvus | that happens on merge though, not release, so we can iteratively work on it fairly easily | 21:26 |
| corvus | clarkb: https://zuul-ci.org/confirmation/ is live if you want to pass that on | 21:56 |
| clarkb | corvus: yup fungi already passed it on. thanks | 21:56 |
| corvus | i'm trying to decide if i should push ahead on moving the other zuul projects this week, or wait until i'm back in a week+ | 22:03 |
| *** rlandy|ruck is now known as rlandy | 22:08 | |
| *** rlandy is now known as rlandy|bbl | 22:09 | |
| corvus | there could be a little disruption, but i think now that we've got the confirmation deck in, i think we can probably handle that? | 22:11 |
| clarkb | zuul-jobs is probably the trickiest to move? | 22:13 |
| corvus | ah, yeah, we'll need a plan for that since its jobs are in openstack-zuul-jobs right now | 22:13 |
| *** jamesmcarthur has quit IRC | 22:14 | |
| clarkb | the other repos should be mostly straightforward I expect | 22:14 |
| clarkb | since they are largely self contained | 22:14 |
| corvus | where does the javascript content get published? | 22:14 |
| corvus | ah it's this one: http://zuul.openstack.org/job/publish-openstack-javascript-content | 22:15 |
| corvus | which is problematic since opendev doesn't have a tarballs site (yet) | 22:15 |
| corvus | so that's 2 things to address before we move the rest. i guess that's that question answered. :) | 22:16 |
| clarkb | http://tarballs.openstack.org/zuul/zuul-content-latest.tar.gz that tarball? | 22:17 |
| corvus | i think so | 22:19 |
| corvus | mordred or clarkb: can one of you weigh in on https://review.openstack.org/644392 ? it's a behavior change which i think is desirable (even necessary), and even more so the more times i see skipped jobs due to hiccups in the requirements phase | 22:24 |
| clarkb | hrm ya I found taht skipped case to be quite confusing when I ran into it | 22:25 |
| clarkb | I'll review the change | 22:25 |
| *** jamesmcarthur has joined #zuul | 22:32 | |
| openstackgerrit | Merged openstack-infra/zuul master: Fail jobs when requirements not met https://review.openstack.org/644392 | 23:31 |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: Add Debian Buster boot tests https://review.openstack.org/649214 | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!