| tristanC | jhesketh: here is the rebase of zuul-runner on the multi-ansible stack, just a few 'ansible_version' variables needed to be copied from executor.py to common.py | 00:00 |
|---|---|---|
| tristanC | pabelanger: zuul-maint: please, what are the next steps for https://review.openstack.org/632620 ? (to use build-sshkey on one-slot static node) | 00:14 |
| *** jamesmcarthur has joined #zuul | 00:58 | |
| jhesketh | tristanC: that's great, thanks :-) | 01:17 |
| *** wxy-xiyuan has joined #zuul | 01:25 | |
| *** jamesmcarthur has quit IRC | 01:45 | |
| *** jamesmcarthur has joined #zuul | 01:55 | |
| *** jamesmcarthur has quit IRC | 02:06 | |
| *** jamesmcarthur_ has joined #zuul | 02:06 | |
| tristanC | jhesketh: oops, fixing the test now | 02:10 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: Get executor job params https://review.openstack.org/607078 | 02:22 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: Separate out executor server from runner https://review.openstack.org/607079 | 02:22 |
| *** irclogbot_3 has quit IRC | 02:23 | |
| *** edmondsw has quit IRC | 02:26 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 02:30 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 02:40 |
| *** jamesmcarthur_ has quit IRC | 02:59 | |
| SpamapS | tristanC: thank you so much for working on zuul-runner. I'll really try to get some reviews in on that stack soon. | 03:01 |
| * SpamapS keeps saying that... :-P | 03:02 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 03:09 |
| tristanC | SpamapS: that would be appreciated, especially the first few patches that are tricky to rebase each time | 03:11 |
| tristanC | similarly for zookeeper auth, i had to resetup my cluster again to update the recent review, would be nice to get this merged too | 03:12 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 03:48 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 04:01 |
| *** daniel2 has quit IRC | 04:05 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: config: use yaml.safe_load instead of load https://review.openstack.org/643849 | 04:14 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 04:18 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 04:24 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 04:35 |
| *** daniel2 has joined #zuul | 04:40 | |
| *** daniel2 has quit IRC | 04:41 | |
| *** daniel3 has joined #zuul | 04:41 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 04:48 |
| *** bjackman has joined #zuul | 05:02 | |
| *** daniel3 is now known as daniel2 | 05:11 | |
| *** daniel2 has quit IRC | 05:22 | |
| *** daniel2 has joined #zuul | 05:30 | |
| *** daniel2 has quit IRC | 05:37 | |
| *** daniel2 has joined #zuul | 05:38 | |
| *** bjackman has quit IRC | 05:41 | |
| *** daniel2 has quit IRC | 05:45 | |
| *** daniel3 has joined #zuul | 05:45 | |
| *** bjackman has joined #zuul | 05:45 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: rewrite refreshable and filters with higher order component https://review.openstack.org/643856 | 05:56 |
| *** saneax has joined #zuul | 05:57 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 06:06 |
| *** swest has quit IRC | 06:24 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 06:25 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: rewrite refreshable and filters with higher order component https://review.openstack.org/643856 | 06:54 |
| *** swest has joined #zuul | 06:54 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth https://review.openstack.org/619155 | 06:56 |
| *** AJaeger has quit IRC | 07:03 | |
| *** AJaeger has joined #zuul | 07:07 | |
| openstackgerrit | Merged openstack-infra/zuul master: Manage ansible installations within zuul https://review.openstack.org/631930 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Validate ansible installations on startup https://review.openstack.org/637418 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Make ansible version configurable https://review.openstack.org/637422 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Install ansible during executor startup if needed https://review.openstack.org/640644 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Run tox remote concurrent https://review.openstack.org/640654 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Support ansible 2.6 https://review.openstack.org/631931 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Support ansible 2.7 https://review.openstack.org/631932 | 07:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Switch default ansible version to 2.7 https://review.openstack.org/637424 | 07:16 |
| *** pcaruana has joined #zuul | 07:19 | |
| tristanC | tobiash: nice work! | 07:24 |
| tobiash | tristanC: thanks :) | 07:24 |
| *** markwork has joined #zuul | 07:27 | |
| *** swest has quit IRC | 07:34 | |
| *** bjackman has quit IRC | 07:46 | |
| *** bjackman has joined #zuul | 07:46 | |
| *** swest has joined #zuul | 07:49 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: manifest: add ansible-config.conf https://review.openstack.org/643872 | 07:56 |
| tristanC | tobiash: ^ may be needed for pip install | 07:56 |
| tobiash | +2 | 07:57 |
| *** bjackman has quit IRC | 08:00 | |
| *** bjackman has joined #zuul | 08:02 | |
| openstackgerrit | Merged openstack-infra/zuul master: Support common ansible dependencies https://review.openstack.org/643534 | 08:20 |
| openstackgerrit | Merged openstack-infra/zuul master: Add missing docs for zuul-manage-ansible https://review.openstack.org/643544 | 08:22 |
| openstackgerrit | Merged openstack-infra/zuul master: ansible-config: add common extra dependencies https://review.openstack.org/643537 | 08:23 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: manifest: add zuul/ansible and ansible-config.conf https://review.openstack.org/643872 | 08:27 |
| tristanC | tobiash: actually we also need zuul/ansible/*, my install was missing the 2.*/ directory which only contains links | 08:27 |
| *** jpena|off is now known as jpena | 08:29 | |
| *** lennyb has joined #zuul | 08:31 | |
| *** themroc has joined #zuul | 08:38 | |
| *** sshnaidm|afk is now known as sshnaidm|rover | 08:42 | |
| *** gtema has joined #zuul | 08:47 | |
| *** hashar has joined #zuul | 08:51 | |
| openstackgerrit | Merged openstack-infra/zuul master: Install virtualenv from source https://review.openstack.org/643655 | 08:55 |
| *** rfolco has joined #zuul | 09:34 | |
| *** saneax has quit IRC | 10:57 | |
| *** gtema has quit IRC | 11:32 | |
| *** gtema has joined #zuul | 11:46 | |
| *** edmondsw has joined #zuul | 11:50 | |
| *** rlandy has joined #zuul | 12:01 | |
| *** saneax has joined #zuul | 12:11 | |
| *** pcaruana|afk| has joined #zuul | 12:54 | |
| *** pcaruana has quit IRC | 12:56 | |
| *** jpena is now known as jpena|lunch | 12:57 | |
| *** bjackman has quit IRC | 13:02 | |
| openstackgerrit | Merged openstack-infra/zuul master: manifest: add zuul/ansible and ansible-config.conf https://review.openstack.org/643872 | 13:02 |
| mordred | tobiash: \o/ yay for multi-ansible!!! | 13:40 |
| mordred | tobiash: I just had a terrible idea which you may have already had. add "zuul" as a special verision of ansible that can be requested - which will create an on-demand virtualenv for the job installing ansible from a git repo zuul has cloned for the job and then use that virtualenv for any untrusted playbooks | 13:46 |
| tobiash | mordred: you mean on-demand ansible installation? | 13:47 |
| mordred | it could be useful for testing ansible PRs themselves, but also for people who might be carrying a local ansible copy with modifications somehow | 13:47 |
| mordred | tobiash: yeah - but not into a system location - in this case into the jobdir | 13:48 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Whitelist ansible_python_interpreter for add_host https://review.openstack.org/643726 | 13:48 |
| tobiash | hrm, for the second use case we might want to make the ansible list configurable | 13:48 |
| *** pcaruana|afk| has quit IRC | 13:48 | |
| tobiash | and the first use case would defeat the ansible plugin protection | 13:49 |
| pabelanger | mordred: tobiash: ^mind reviewing again, that allows us to change ansible python interpreter with add_host. Trying to do CD from zuul on python3 only host | 13:49 |
| mordred | tobiash: well, yes- for the second case I think it's important to only use the jobdir venv for untrusted - and it's likely only an option if we were decide to drop our plugin protection and rely on the bubblewrap isolation layer | 13:51 |
| mordred | I mean for the first | 13:51 |
| mordred | or probably for both | 13:52 |
| corvus | pabelanger: any reason you're not using the zuul ssh key for CD? | 13:52 |
| tobiash | mordred: yes, but that still opens the door for arbitrary code execution | 13:52 |
| tobiash | mordred: so if we agree to only rely on bwrap, that would be ok | 13:53 |
| pabelanger | corvus: I am | 13:53 |
| pabelanger | corvus: I just don't have python2 on the remote host | 13:53 |
| corvus | pabelanger: oh, i get what you're doing, sorry. | 13:53 |
| pabelanger | np! | 13:53 |
| pabelanger | I also finally got zuul_console working, if people are intersted in the logs: https://object-storage-ca-ymq-1.vexxhost.net/v1/a0b4156a37f9453eb4ec7db5422272df/logs/19/1953f77b43583325df74ee6520dc22f1f224c48a/post/windmill-config-deploy/4c8b15e/ | 13:54 |
| pabelanger | CD zuul works very well! :D | 13:54 |
| mordred | pabelanger: \o/ | 13:55 |
| mordred | tobiash: yeah. | 13:55 |
| mordred | tobiash: I think it would need some special-casing in the executor anyway, so I'm not sure if the specific usecase would justify the logic in the executor - but it could allow for the removal of cases of ansible-running-ansible for testing zuul+ansible together too - so MAYBE it's worth considering | 13:56 |
| *** jpena|lunch is now known as jpena | 14:04 | |
| *** dkehn has joined #zuul | 14:05 | |
| *** gtema has quit IRC | 14:14 | |
| *** pcaruana has joined #zuul | 14:33 | |
| *** saneax has quit IRC | 14:50 | |
| *** markwork has quit IRC | 14:56 | |
| *** jamesmcarthur has joined #zuul | 15:02 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Tolerate missing project https://review.openstack.org/579872 | 15:10 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: buildset registry: don't put skopeo creds on command line https://review.openstack.org/644241 | 15:11 |
| pabelanger | just seen zuul-build-image fail: http://logs.openstack.org/26/643726/3/check/zuul-build-image/f7e50ef/job-output.txt.gz#_2019-03-18_14_02_58_675516 | 15:11 |
| pabelanger | guess that is related to new multi-ansible | 15:11 |
| pabelanger | No matching distribution found for pyasn1-modules>=0.2.1 (from google-auth>=1.0.1->kubernetes<9.0.0,>=8.0.0->openshift) | 15:12 |
| pabelanger | tobiash: ^ | 15:12 |
| pabelanger | any ideas? | 15:12 |
| tobiash | pabelanger: zuul-build-image was green for all multi-ansible patches, maybe a mirror glitch? | 15:13 |
| tobiash | pabelanger: try a recheck, if that breaks we need to dig deeper | 15:13 |
| pabelanger | wfm | 15:13 |
| corvus | we're not using opendev's mirrors inside the image builds are we? | 15:16 |
| pabelanger | I am not sure | 15:17 |
| pabelanger | I don't think so | 15:17 |
| pabelanger | looks like we are hitting https://files.pythonhosted.org | 15:18 |
| mordred | corvus: using mirrors inside of image builds gets complicated and I'm not sure we've found a solution for that which pleases anybody | 15:21 |
| tobiash | we might also hit a dependency update that broke things | 15:25 |
| tobiash | corvus: when are you planning to upgrade openstack zuul? | 15:26 |
| corvus | tobiash: i pushed up some changes a few mins ago... | 15:31 |
| corvus | https://review.openstack.org/643957 failed tests :( | 15:31 |
| corvus | we could restart without it... | 15:31 |
| tobiash | corvus: do you want me to be around when you're restarting it? | 15:32 |
| tobiash | I'll be afk in about 30 minutes for 1-2 hours probably | 15:32 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Refactor code for unit testing https://review.openstack.org/643666 | 15:33 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 15:33 |
| corvus | tobiash: don't worry about it, i'm sure we can handle anything that comes up (and we can restart a single executor to start) | 15:33 |
| tobiash | k | 15:33 |
| tobiash | corvus: that reminds me about an important detail, we need to think if the restart order matters | 15:34 |
| tobiash | new scheduler -> old executor: I think it should just ignore the requested ansible version | 15:35 |
| tobiash | old scheduler -> new executor: I think it should default to the default ansible version | 15:35 |
| tobiash | so I *think* there will be no problem in that regard | 15:36 |
| corvus | tobiash: it looks like the executor server assumes that ansible_version will be supplied, so i don't think you can run a new executor with an old scheduler | 15:39 |
| tobiash | corvus: oh, we probably should fix that before you restart | 15:39 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Properly handle missing ansible version in executor https://review.openstack.org/644252 | 15:43 |
| tobiash | corvus: I think that should do it ^ | 15:43 |
| corvus | tobiash: thx; mordred ^ | 15:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: Update zuul ansible location https://review.openstack.org/644266 | 16:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: buildset registry: don't put skopeo creds on command line https://review.openstack.org/644241 | 16:13 |
| clarkb | corvus: mordred: if we are going to restart zuul for multi ansible it may also be nice to get https://review.openstack.org/643703 in if we think that change is correct. Will help with the many merges problem pabelanger has noticed | 16:15 |
| pabelanger | clarkb: mordred: https://review.openstack.org/163922/ was also a rebase of old patch from corvus too, which seems to also be related. | 16:16 |
| corvus | clarkb: i agree, though it's going to take me a while to review that (i need to page in some stuff). i think i'd suggest that i put that near the top of my list, and if it merges before we restart, great, but otherwise not block on it. | 16:18 |
| mordred | clarkb, corvus: +2 from me -but I left off +A because I would like corvus to review that one too ... but I also agree it would be nice to get it in if we can | 16:24 |
| mordred | otoh - restarting executors twice in a day isn't like a problem or anything | 16:25 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-base-jobs master: Update zuul ansible location https://review.openstack.org/644277 | 16:26 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Update zuul ansible location https://review.openstack.org/644266 | 16:34 |
| *** themroc has quit IRC | 16:37 | |
| corvus | clarkb, mordred, tobiash: merger change lgtm +3 | 16:38 |
| clarkb | great thanks | 16:38 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: buildset registry: don't put skopeo creds on command line https://review.openstack.org/644241 | 16:39 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 16:51 |
| *** mgoddard has quit IRC | 17:02 | |
| *** mgoddard has joined #zuul | 17:08 | |
| *** gtema has joined #zuul | 17:09 | |
| Shrews | why ship an ubuntu dev library package that contains no actual library? *ugh* | 17:10 |
| tobiash | Shrews: isn't that the common pattern in ubuntu? | 17:13 |
| clarkb | the dev packages are for the headers only right? then you install the non dev package for the actual compiled lib | 17:15 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: buildset registry: fix proxy_port error in push/pull roles https://review.openstack.org/644322 | 17:16 |
| Shrews | there is no compiled lib package for this. you are expected to build it from sources | 17:17 |
| Shrews | although cosmic seems to supply it. so, whatever | 17:18 |
| *** snapiri has quit IRC | 17:19 | |
| tobiash | Ah I see you expected only a src package of gtest | 17:19 |
| clarkb | apparently that is a googleism | 17:21 |
| Shrews | bionic: https://packages.ubuntu.com/bionic/amd64/libgtest-dev/filelist vs cosmic: https://packages.ubuntu.com/cosmic/amd64/libgtest-dev/filelist | 17:21 |
| clarkb | https://askubuntu.com/questions/145887/why-no-library-files-installed-for-google-test has some package history in it | 17:22 |
| *** hashar is now known as hasharAway | 17:33 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: buildset registry: fix proxy_port error in push/pull roles https://review.openstack.org/644322 | 17:35 |
| *** jamesmcarthur has quit IRC | 17:38 | |
| *** jamesmcarthur has joined #zuul | 17:39 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Increase wait time of test_plugins https://review.openstack.org/644375 | 17:42 |
| tobiash | corvus, mordred: I've seen this test case timeouting already twice today ^ | 17:42 |
| openstackgerrit | Merged openstack-infra/zuul master: Don't call the merger for non-live items https://review.openstack.org/643703 | 17:44 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Add foreground option https://review.openstack.org/635649 | 17:46 |
| *** gtema has quit IRC | 17:51 | |
| *** chandankumar is now known as raukadah | 17:51 | |
| *** jpena is now known as jpena|off | 18:06 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-base-jobs master: Update zuul ansible location https://review.openstack.org/644277 | 18:22 |
| openstackgerrit | Merged openstack-infra/zuul master: Whitelist ansible_python_interpreter for add_host https://review.openstack.org/643726 | 18:25 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: WIP: Fail jobs when requirements not met https://review.openstack.org/644392 | 18:37 |
| *** jamesmcarthur has quit IRC | 18:41 | |
| *** hasharAway has quit IRC | 18:44 | |
| *** hasharAway has joined #zuul | 18:45 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/zuul-base-jobs master: Update zuul ansible location https://review.openstack.org/644277 | 18:49 |
| *** saneax has joined #zuul | 18:51 | |
| openstackgerrit | Merged openstack-infra/zuul master: Properly handle missing ansible version in executor https://review.openstack.org/644252 | 18:53 |
| *** jamesmcarthur has joined #zuul | 18:56 | |
| *** daniel3 has quit IRC | 18:56 | |
| *** daniel2 has joined #zuul | 18:56 | |
| pabelanger | corvus: mordred: clarkb: fungi: Do you mind adding https://review.openstack.org/642913/ to your review queue? It allows the zuul group read permissions on scheduler keys, and not abort zuul from starting. thanks! | 18:58 |
| *** jamesmcarthur has quit IRC | 19:00 | |
| *** saneax has quit IRC | 19:00 | |
| fungi | oh, i thought i had reviewed that one already. thanks for the reminder | 19:02 |
| fungi | corvus: hah, just saw your comment on that one after starting to write basically the same | 19:08 |
| corvus | pabelanger, fungi, tobiash: ^ left a question on that. also i think jhesketh's comment about the logic reversal is more-than-nit-worthy :) | 19:08 |
| fungi | though i was going to suggest "not mode%8" | 19:08 |
| fungi | but perhaps that's too opaque | 19:09 |
| corvus | heh, either way :) | 19:09 |
| corvus | pabelanger: grep says there are a lot more occurences of "700" in the source, do they need updating? | 19:09 |
| fungi | specifically, i'm concerned that it'll fail if mode is 0o2750 (same as 0o0750 but with setgid bit) | 19:09 |
| fungi | oh, though i suppose 02750 doesn't make a lot of sense. 02770 would | 19:10 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 19:11 |
| pabelanger | corvus: yah, I wasn't sure how to handle those, right now zuul will load properly, if they are changed to 750, since we only check the top level /var/lib/zuul/keys. | 19:11 |
| pabelanger | my thoughts were to make the changes behind the back of zuul to 0750 on deploy. | 19:12 |
| *** sshnaidm|rover is now known as sshnaidm|afk | 19:13 | |
| fungi | the sane solution here is to probably switch to using a bitmask for comparisons and then create a constant like PRIVATE_MODE which we use in place of hard-coded values throughout the source | 19:13 |
| pabelanger | other wise, if we are okay with updating the to a new default, I can update the change for that too | 19:13 |
| pabelanger | fungi: okay, I'll have to read up on that | 19:13 |
| pabelanger | but agree, we likely need some flag to say we want 0750 or 0700 on directories | 19:14 |
| pabelanger | or 0770 | 19:14 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 19:14 |
| fungi | not really much to read up on. PRIVATE_MODE was just an example name i picked, but idea being you have one central place in the source (or perhaps even exposed as a config option) so that the mode used during file creation is consistent throughout | 19:14 |
| openstackgerrit | Clark Boylan proposed openstack-infra/zuul-base-jobs master: Update zuul ansible location https://review.openstack.org/644277 | 19:15 |
| pabelanger | fungi: ack, understand now | 19:15 |
| fungi | and then using a bitmask instead of just a whitelist of modes is more so that you can indicate the permissions you consider unsafe rather than trying to enumerate every possible mode which could have that risk | 19:15 |
| fungi | so with "mode & 0o7 == 0" or "not mode%8" or whatever, you're basically saying "fail if this is readable, writable or executable/traversable by anyone besides the owning user or group" | 19:17 |
| fungi | though i think python also provides functions which will tell us that too | 19:17 |
| fungi | without needing to implement the mathybits | 19:18 |
| *** jamesmcarthur has joined #zuul | 19:18 | |
| pabelanger | k, I'll dig more into it. Thanks for reviews! | 19:19 |
| pabelanger | need to run an errand for a bit, bbl | 19:19 |
| *** jamesmcarthur has quit IRC | 19:19 | |
| fungi | though as to my earlier concern about failing on 0o2750, looks like we address that earlier in the function with "mode = st.st_mode & 0o777" so we're only actually looking at the last 3 octal digits anyway | 19:20 |
| fungi | (last 12 bits) | 19:20 |
| *** jamesmcarthur has joined #zuul | 19:23 | |
| fungi | but anyway, looks like there's a stat.S_IRWXO we could mask like "if not st.st_mode & stat.S_IRWXO:" | 19:23 |
| fungi | which is basically "if no permission for others" | 19:25 |
| openstackgerrit | Merged openstack-infra/zuul-base-jobs master: Update zuul ansible location https://review.openstack.org/644277 | 19:32 |
| Shrews | tfw things that have not been working all day mysteriously begin to work | 19:34 |
| mordred | Shrews: you must be using m4 | 19:35 |
| Shrews | nope | 19:36 |
| Shrews | mordred: the debian:testing-slim docker image has suddenly decided to supply me the thing i needed. i cannot explain it. maybe they updated something | 19:37 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 19:39 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 19:40 |
| tobiash | mordred: want to +a 644375 for more stable zuul tests? | 19:41 |
| mordred | tobiash: I prefer unstable flaky tests | 19:42 |
| mordred | tobiash: +A | 19:42 |
| tobiash | like me, more fun with rechecks and warmer datacenters ;) | 19:42 |
| mordred | that's right! datacenters are too cold! | 19:43 |
| clarkb | once upon a time we put up curtains for hot and cold aisle separation in a DC I worked in. That dc wasnever cold before that and after it was freezing | 19:48 |
| mordred | once upon a time my job involved needing to go to datacenters. I love cloud. | 19:58 |
| *** jamesmcarthur has quit IRC | 20:00 | |
| dmsimard | datacenters are fun :D | 20:05 |
| *** jamesmcarthur has joined #zuul | 20:09 | |
| *** jamesmcarthur has quit IRC | 20:10 | |
| *** jamesmcarthur has joined #zuul | 20:10 | |
| *** irclogbot_3 has joined #zuul | 20:13 | |
| openstackgerrit | Merged openstack-infra/zuul master: Increase wait time of test_plugins https://review.openstack.org/644375 | 20:15 |
| *** irclogbot_3 has quit IRC | 20:25 | |
| *** irclogbot_3 has joined #zuul | 20:28 | |
| openstackgerrit | David Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Add unit tests https://review.openstack.org/644247 | 20:30 |
| *** pcaruana has quit IRC | 20:54 | |
| pabelanger | Shrews: FYI: https://review.openstack.org/643849/ | 21:13 |
| pabelanger | tristanC: seems to have fixed the possible warning I linked in comment | 21:13 |
| Shrews | pabelanger: +3 | 21:14 |
| pabelanger | danke! | 21:15 |
| *** mgoddard has quit IRC | 21:20 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/zuul-jobs master: Handle no metadata in zuul artifact items https://review.openstack.org/644428 | 21:23 |
| *** mgoddard has joined #zuul | 21:26 | |
| *** irclogbot_3 has quit IRC | 21:26 | |
| *** irclogbot_3 has joined #zuul | 21:29 | |
| openstackgerrit | Merged openstack-infra/nodepool master: config: use yaml.safe_load instead of load https://review.openstack.org/643849 | 21:35 |
| *** hasharAway has quit IRC | 22:03 | |
| *** rfolco has quit IRC | 22:04 | |
| *** daniel2 has quit IRC | 22:23 | |
| *** daniel2 has joined #zuul | 22:23 | |
| corvus | tobiash: does every unit test now install 3 versions of ansible from pypi? | 22:30 |
| corvus | tobiash: i'm running "ttrun -epy36 tests.unit.test_v3.TestProvidesRequires.test_provides_requires_shared_queue_slow" which used to be fast but it looks like it is slow because of that now | 22:38 |
| corvus | tobiash: maybe we should look into installing ansible into venvs inside the .tox/py36 directory and have the test system use those as "pre-installed" ansible envs? | 22:39 |
| openstackgerrit | Merged openstack-infra/zuul master: Wait for command processor thread to stop https://review.openstack.org/641854 | 22:42 |
| *** daniel2 has quit IRC | 22:48 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Fix metadata not passed in provides/requires https://review.openstack.org/644445 | 22:52 |
| *** daniel2 has joined #zuul | 22:53 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Fix metadata not passed in provides/requires https://review.openstack.org/644445 | 22:54 |
| *** daniel2 has quit IRC | 23:04 | |
| *** daniel2 has joined #zuul | 23:05 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Fail jobs when requirements not met https://review.openstack.org/644392 | 23:19 |
| *** jamesmcarthur has quit IRC | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!