Monday, 2019-01-28

tristanCzuul-jobs core, could you please review: https://review.openstack.org/#/c/632620/ . Without this, the add-build-sshkey doesn't work well for static nodes00:16
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: upgrade react-scripts to ^2.0.0  https://review.openstack.org/63190200:35
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: upgrade react-scripts to ^2.0.0  https://review.openstack.org/63190201:15
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: upgrade react and react-scripts to ^2.0.0  https://review.openstack.org/63190201:57
*** bhavikdbavishi has joined #zuul03:02
*** spsurya has joined #zuul04:28
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: switch jobs list to a tree view  https://review.openstack.org/63343706:04
*** quiquell|off is now known as quiquell06:20
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: scheduler: add job's parent name to the rpc job_list method  https://review.openstack.org/57347306:25
*** sshnaidm|off is now known as sshnaidm06:30
*** badboy has joined #zuul06:35
openstackgerritSimon Westphahl proposed openstack-infra/zuul master: List changed files for all commits between refs  https://review.openstack.org/63179707:01
*** chandankumar has quit IRC07:07
*** panda|off is now known as panda07:20
*** chandan_kumar has joined #zuul07:21
*** avass has joined #zuul07:39
openstackgerritRui Chen proposed openstack-infra/zuul master: Avoid using list branches with protected=1 in github driver  https://review.openstack.org/63003807:45
openstackgerritSimon Westphahl proposed openstack-infra/zuul master: List changed files for all commits between refs  https://review.openstack.org/63179707:54
*** pcaruana has joined #zuul08:01
*** chandan_kumar is now known as chandankumar08:02
*** themroc has joined #zuul08:08
*** gtema has joined #zuul08:44
*** electrofelix has joined #zuul08:53
*** jpena|off is now known as jpena08:54
*** luizbag has joined #zuul09:41
*** jesusaur has quit IRC09:45
*** strigazi has joined #zuul09:45
strigazihello, I'm trying to figure this out: http://logs.openstack.org/36/612336/12/check/container-build/a5ac779/ara-report/ Locally it works, but on the ci it fails to fetch the tarball. Any clues?09:47
*** jesusaur has joined #zuul09:51
*** avass has quit IRC09:53
*** bhavikdbavishi has quit IRC09:53
*** AJaeger has quit IRC10:03
badboycan anyone tell why running 'pip install .' once more in Zuul's dir removes web dashboard files?10:04
badboy\/usr/local/lib/python3.6/dist-packages/zuul/web/static is empty after that10:05
*** AJaeger has joined #zuul10:07
jktbadboy: is that a git checkout?10:33
badboyjkt: yes10:33
jktbadboy: dashboard builds need a ton of JS-specific tooling, including node.js and yarn. Do you have that?10:34
jktbadboy: installing from a prebuilt package at pypi does not require that10:35
badboyjkt: when I run 'pip install .' in Zuul git checkout everything works but running the same command once again removes the compiled js for dashboard10:36
jktbadboy: alright, then I cannot help, it's something else than I hit a week or two ago10:38
*** SotK is now known as SotK__10:39
*** SotK_ is now known as SotK10:39
badboyI've created a dirty script for installing Zuul (no errorhandling whatsover): http://paste.openstack.org/show/5VTy8HrJclTXU3WJiT1p/10:44
*** rfolco has joined #zuul10:56
jktbadboy: I was able to get it running with ansible using the openstack's ansible zuul playbooks, https://gerrit.cesnet.cz/plugins/gitiles/ci/ansible-cesnet/+/master/11:03
jktbadboy: I was doing Puppet before, so I took this as an opportunity to get myself familiar with yet another tool, and my TL;DR impression is that it's mostly "okay"11:04
badboyjkt: thank you :)11:13
badboyjkt: regarding your '# TODO: this is buggy, `touch` always updates...' you can use: modification_time: "preserve" & access_time: "preserve"11:40
badboyjkt: https://docs.ansible.com/ansible/latest/modules/file_module.html11:41
*** bhavikdbavishi has joined #zuul11:53
*** gtema has quit IRC11:53
*** gtema has joined #zuul11:53
*** avass has joined #zuul12:02
*** panda is now known as panda|lunch12:07
*** jesusaur has quit IRC12:07
*** jesusaur has joined #zuul12:15
jktbadboy: nice, thanks12:26
jktbadboy: any clue why `pip install` always says that it modifies something when installing zuul? (it doesn't report anything for nodepool...)12:26
*** jpena is now known as jpena|lunch12:31
*** panda|lunch is now known as panda12:33
*** pcaruana has quit IRC12:36
*** pcaruana has joined #zuul12:37
*** jesusaur has quit IRC12:46
*** jesusaur has joined #zuul12:51
*** rlandy has joined #zuul12:54
badboyjkt: no clue, sorry13:10
*** bhavikdbavishi has quit IRC13:10
*** bhavikdbavishi has joined #zuul13:18
sshnaidmif I add required_jobs in job and in its child, is it overwritten or merged in child?13:23
sshnaidmby child I mean inherited13:23
*** jpena|lunch is now known as jpena13:29
*** pcaruana has quit IRC13:32
*** bhavikdbavishi has quit IRC13:37
openstackgerritBenedikt Löffler proposed openstack-infra/zuul master: Report retried builds via sql reporter.  https://review.openstack.org/63350113:40
*** pcaruana has joined #zuul13:50
*** badboy has quit IRC13:58
*** bhavikdbavishi has joined #zuul13:58
*** bhavikdbavishi has quit IRC14:07
pabelangerjkt: you have leaked your private keys for your gerrit connection. You may want to rotate them.14:17
*** gtema has quit IRC14:23
*** bhavikdbavishi has joined #zuul14:34
tobiashyay, we had a scheduler wedge today because a user force-merged a change referencing a non-existing project-template and the post job reporting caused an exception loop blocking all tenants14:44
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix wedged scheduler on force-merge of non-existing template  https://review.openstack.org/63351414:44
tobiashthis is the fix ^14:44
*** quiquell is now known as quiquell|off14:47
pabelangertobiash: we had a periodic job (with semaphore) wedge this weekend also. Think there was a network issue between gearman, scheduler tried to notifiy executor, but didn't reach it. Job looked to be started, but no executor servicing it14:51
pabelangerthen post jobs were blocked because of semaphore14:51
jktpabelanger: did I? Where? I would have sworn that I encrypted them14:51
tobiashpabelanger: maybe you want https://review.openstack.org/63172114:51
pabelangerjkt: line 19314:52
pabelangertobiash: looking14:52
tobiashpabelanger: and https://review.openstack.org/599573 once we have a gear release14:52
pabelangertobiash: https://softwarefactory-project.io/paste/show/1401/ was debug from scheduler, tristanC might have more thoughts. But we didn't actually need to restart scheduler, we could dequeue the change14:54
pabelangersorry, wrong paste14:54
pabelangerhttps://softwarefactory-project.io/paste/show/1403/14:54
jktpabelanger: ah, that is badboy's script, actually14:55
pabelangerjkt: ah, sorry about that14:55
tobiashpabelanger: in your case the gear keepalive would have probably saved you14:58
pabelangertobiash: cool! Agree, networking isn't the best here. Anything blocking the release?15:02
tobiashpabelanger: just doing afaik15:03
pabelangerack, will ask on #openstack-infra now15:04
*** chandankumar is now known as chkumar|out15:08
*** dkehn has joined #zuul15:19
*** swest has quit IRC15:22
openstackgerritBenedikt Löffler proposed openstack-infra/zuul master: Report retried builds via sql reporter.  https://review.openstack.org/63350115:42
*** openstackgerrit has quit IRC15:51
avassso, I deleted a change while it zuul started a job for it and now it's stuck16:02
avassand I can't dequeue it because the change doesn't exist16:02
avassany tips?16:02
pabelangeravass: how did you delete it, in gerrit?16:03
avassyep16:06
avasspabelanger: seems like it solved itself16:06
pabelangeravass: k, I don't think many people delete issues in gerrit, so might be use case not really tested. Good to hear now resolved16:07
pabelangers/issues/changes16:07
*** avass has quit IRC16:27
*** hashar has joined #zuul16:31
*** bhavikdbavishi has quit IRC16:34
*** bhavikdbavishi has joined #zuul16:37
*** dmsimard has quit IRC16:43
*** hashar has quit IRC16:44
*** pcaruana has quit IRC16:47
*** dmsimard has joined #zuul16:48
clarkbis that via a gerrit plugin?16:49
clarkbor does newer gerrit than we run allow you to do that now?16:49
*** dmsimard has quit IRC16:49
*** bhavikdbavishi has quit IRC16:50
*** bhavikdbavishi has joined #zuul16:51
*** dmsimard has joined #zuul16:52
corvustobiash: i was going to put out a last call for reviews on the multi-ansible spec, but the question raised by SpamapS of whether to run the ansible installation during pip install seems like a significant one; did you want to look into that for a little bit first?17:11
*** bhavikdbavishi has quit IRC17:12
*** bhavikdbavishi has joined #zuul17:13
*** dkehn has quit IRC17:15
corvusmaybe we can try to land that next week17:15
tobiashcorvus: I had a look and research on the weekend about this17:23
tobiashcorvus: I managed to run the ansible installation during source based installations which works good in principle17:24
tobiashcorvus: however wheel based installations have no real way of post install hooks (which are needed as the virtualenvs cannot be packaged inside the wheel as they are not relocatable)17:25
tobiashso for wheel based installations we need to call the ansible install script manually17:25
corvustobiash: yeah.  given that, it's probably not worth trying to do it as part of pip install17:25
tobiashbut I'm fine with not supporting managing the installations during startup if you are17:25
corvus(tbh, my experience with doing things with pip/setuptools/etc, is that the less done, the better)17:26
electrofelixFinally getting a chance to look at nodepool (so may make some progress in upgrading to zuulv3 yay!)17:26
corvustobiash: i still think that if we can have install-on-startup without too much effort, then it's worth it to make things easier for new users.17:27
clarkbya wheels will pose a problem there.17:27
electrofelixwe have a problem with our current set up around some limited resources that I'm hoping nodepool can help. I see it has static nodes, but we have a need for a static slave and a dynamic resource that jenkins won't be able to ssh into17:27
corvustobiash: so i still like the idea of having both the external-script or install-on-startup [which does the same thing as external-script] options.17:27
tobiashcorvus: I'm fine with supporting both as it's not really additional effort, but SpamapS point of view was contradicting yours so we need a decision on that ;)17:28
tobiashSpamapS: ^17:28
tobiashcorvus: I already have that external script in place and it works the same during startup17:28
corvuselectrofelix: nodepool can mix and match static/dynamic nodes, but zuulv3 is going to expect to be able to ssh into all of them17:28
tobiashreally supporting both is essentially a few lines of code17:29
electrofelixcorvus: right, hence why I'm thinking that we need a custom driver that could grab a node from the static pool to go along with the limited resource and just return the static node with an additional label that we can use on the Jenkins side to know what data to inject into the job env17:30
electrofelixwe have some resources in AWS and we need an agent attached to Jenkins to act as the launch point for connecting (note we're still Jenkins and I'm hoping this is the first step to allow moving away)17:31
corvustobiash, SpamapS: yeah, I read SpamapS as mostly favoring install-time-install, which i agree would be nice, but if we accept that it's impractical, i think we're left with an external script being the main option that we're all happy with, and "run that script on startup" as being a simple secondary option.17:31
tobiashcorvus, SpamapS: so if we can come up with an agreement on this point, I can update the spec tomorrow17:34
electrofelixCurrently we're allowing for some fixed resources to be provided, e.g. a k8s env in AWS, but we only have a few of them, and still need to start the job from something that has access within the internal network17:34
corvustobiash: might be worth adding your findings about pip in a comment17:34
*** sdake has quit IRC17:34
tobiashto summarize: install-time-install is possible during 'pip install .' (I have that working within tox), but not with wheels17:34
tobiashcorvus: yeah, I'll add a comment about this17:35
clarkbelectrofelix: nodepool can broker the k8s resources directly17:35
clarkb(though I don't know if there is quota management yet)17:35
tobiashfor reference, there is an open issue about wheel compatible post install hooks: https://github.com/pypa/packaging-problems/issues/6417:37
electrofelixclarkb: given the current env we still need a worker to be attached to jenkins that can run stuff against those k8s instances17:37
electrofelixbut not sure how to describe those resources in nodepool so it can handle managing handing them to jenkins along with a worker to run the job without having to have a separate dedicated pool17:37
*** sdake has joined #zuul17:37
electrofelixof static machines17:37
tobiashcorvus: but regarding the installation position I'd agree to install it by default in lib/zuul/...17:39
electrofelixyou could say that both the k8s resources and the machines we have are static, but I'm thinking that the jenkins nodepool plugin cannot consume the k8s resources directly because it can't run an agent on it17:39
tobiashmaybe we could change the default to /var/lib/zuul/... if we're managing ansible at runtime17:39
electrofelixbut if I can work out a way to make this work, then the step to zuulv3 becomes much smaller internally17:40
*** openstackgerrit has joined #zuul17:40
openstackgerritPaul Vinciguerra proposed openstack-infra/zuul master: Identify the gerrit source when logging stream-events errors.  https://review.openstack.org/63356717:40
clarkbelectrofelix: I'm not familiar enough with how the jenkins agent + nodepool v3 stuff works to guide much there but on the zuulv3 side I think you'd simply request the k8s env then the executor would talk to that directly. Maybe you can use the jenkins master's agents as a stand in for the zuul executor there17:42
electrofelixclarkb: that's kind of what I'm hoping for, but I think jenkins will expect to be able to directly ssh to whatever nodepool provides, hence why I'm wondering if we need to go down a custom driver can a driver grab resources from another pool internally to nodepool?17:46
electrofelixmaybe it might be better to put an email together and send it on17:48
electrofelixhave to drop now, meant to start the questions earlier today17:48
*** electrofelix has quit IRC17:48
*** sdake has quit IRC17:51
*** sdake_ has joined #zuul17:52
*** sdake_ has quit IRC17:53
*** bhavikdbavishi has quit IRC18:04
*** themroc has quit IRC18:04
*** jpena is now known as jpena|off18:13
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Amazon EC2 driver  https://review.openstack.org/53555818:13
*** sdake_ has joined #zuul18:13
*** sdake_ is now known as sdkae18:14
openstackgerritMerged openstack-infra/zuul master: Incoming connections over 19885/TCP are needed on nodes  https://review.openstack.org/63324218:18
openstackgerritPaul Vinciguerra proposed openstack-infra/zuul master: Identify the gerrit source when logging stream-events errors.  https://review.openstack.org/63356718:37
*** rfolco has quit IRC19:00
*** spsurya has quit IRC19:14
*** luizbag has quit IRC19:15
openstackgerritTobias Henkel proposed openstack-infra/nodepool master: Amazon EC2 driver  https://review.openstack.org/53555819:19
tobiashSpamapS: fixed test case ^19:19
*** rfolco has joined #zuul19:34
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Amazon EC2 driver  https://review.openstack.org/53555820:08
openstackgerritMerged openstack-infra/zuul master: Use gearman client keepalive  https://review.openstack.org/59957320:09
tobiashcorvus: does gertty have the ability to preview the inline comments in the change view similar to the gerrit ui?20:09
* tobiash is trying to use gertty more often20:10
corvustobiash: yes, if you create an inline comment, it's saved in draft form until you click 'review' on the change.  more or less the same as in the gerrit ui.  except in gertty, the drafts are saved locally in gertty's db; in gerrit they're saved on the server.20:13
corvus(so draft comments don't sync between gerrit<->gertty)20:14
tobiashcorvus: I mean to see all the inline comments in the change overview20:15
tobiashIn gerrit I can expand the inline comments without having to change to the diff screen20:17
corvustobiash: oh, no that hasn't been added yet, but i'd love to have it20:18
tobiashAu, thx20:18
tobiashCurrently I'm switching often between gerrit and gertty, mostly because of this feature ;)20:19
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP add provides/requires support  https://review.openstack.org/63360521:19
openstackgerritPaul Vinciguerra proposed openstack-infra/zuul master: configloader.py: Not all jobs have an .updated attribute.  https://review.openstack.org/63325921:25
*** panda is now known as panda|off21:35
openstackgerritPaul Vinciguerra proposed openstack-infra/zuul master: configloader.py: Not all jobs have an .updated attribute.  https://review.openstack.org/63325921:36
*** panda|off has quit IRC21:54
*** panda has joined #zuul21:56
*** sdkae has quit IRC22:03
*** sdake has joined #zuul22:05
openstackgerritPaul Vinciguerra proposed openstack-infra/zuul master: configloader.py: Not all jobs have an .updated attribute.  https://review.openstack.org/63325922:15
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP add provides/requires support  https://review.openstack.org/63360522:34
*** sdake has quit IRC22:45
*** sdake has joined #zuul22:45
*** sdake has quit IRC22:46
*** sdake has joined #zuul22:48
*** D0han has left #zuul22:50
*** sdake has quit IRC22:57
*** sdake has joined #zuul22:59
*** sdake has quit IRC23:01
*** sdake has joined #zuul23:03
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP add provides/requires support  https://review.openstack.org/63360523:35
*** ianw is now known as ianw_pto23:42

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!