| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add pass-to-parent option for secrets https://review.openstack.org/631670 | 00:05 |
|---|---|---|
| corvus | almost got it in one! i forgot to git add the reno. | 00:05 |
| tristanC | corvus: i made good progress on the zuul-runner local job executor, (it works when the only secret is the log server). Would you mind having a look at the topic:freeze_job please? | 00:14 |
| tristanC | corvus: in particular, to avoid rebase, it would be nice if we could merge https://review.openstack.org/607079 soon. if that's ok with you, i can remove the wip and propose it on origin/master | 00:15 |
| ianw | mordred / anyone: the deps are in for testing dogpile.cache from github as part of the nodepool tests -> https://review.openstack.org/#/c/625457/ . would be cool to get some eyes on that, as I think it's pretty much the first thing using github a devstack dependency | 00:22 |
| ianw | at least in a zuul-ish manner, maybe plugins have hacked together stuff | 00:23 |
| *** rlandy has quit IRC | 00:37 | |
| *** gtema has quit IRC | 00:47 | |
| *** threestrands has quit IRC | 00:59 | |
| fungi | Shrews: i'm tempted to go as long as hurricanes don't interfere (it's that time of year after all). atl is a convenient hour nonstop for me, unlike most destinations | 01:02 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: config: add playbooks to job.toDict() https://review.openstack.org/621343 | 01:41 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: config: add tenant.toDict() method and REST endpoint https://review.openstack.org/621344 | 01:47 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: WIP: Add API endpoint to get frozen jobs https://review.openstack.org/607077 | 01:53 |
| *** sshnaidm has quit IRC | 02:00 | |
| *** openstackgerrit has quit IRC | 02:02 | |
| *** sshnaidm has joined #zuul | 02:05 | |
| *** quiquell|off is now known as quiquell | 06:18 | |
| *** saneax has joined #zuul | 07:05 | |
| *** pcaruana has joined #zuul | 07:25 | |
| *** pcaruana has quit IRC | 07:55 | |
| *** pcaruana has joined #zuul | 07:55 | |
| *** jpena|off is now known as jpena | 07:58 | |
| *** openstackgerrit has joined #zuul | 08:20 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift Pod provider https://review.openstack.org/590335 | 08:20 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/buildsets route https://review.openstack.org/630035 | 08:22 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul-jobs master: Add prepare-workspace-openshift role https://review.openstack.org/631402 | 08:29 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: Implement zookeeper-auth https://review.openstack.org/619156 | 08:30 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: Fix noop job toDict() https://review.openstack.org/630409 | 08:32 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add jobs graph rendering https://review.openstack.org/537869 | 08:37 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: wip: add status graph rendering https://review.openstack.org/610001 | 08:45 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: docs: add job's logs guide https://review.openstack.org/582921 | 08:56 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/buildsets route https://review.openstack.org/630035 | 09:03 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: wip: add status graph rendering https://review.openstack.org/610001 | 09:15 |
| *** panda|off is now known as panda | 09:30 | |
| openstackgerrit | Merged openstack-infra/zuul master: Add action to host results in zuul_json callback https://review.openstack.org/630622 | 09:43 |
| *** avass has joined #zuul | 09:49 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Fix upload-puppetforge role https://review.openstack.org/631194 | 09:51 |
| avass | tobiash: doesn't look like node-attributes are added to ansible | 10:58 |
| *** electrofelix has joined #zuul | 11:01 | |
| *** odyssey4me has joined #zuul | 11:30 | |
| tobiash | avass: ah, ok the node-attributes are currently only used for executor-zones | 12:00 |
| tobiash | corvus, mordred, pabelanger: does it make sense to plumb the node attributes through to the inventory? | 12:01 |
| *** panda is now known as panda|lunch | 12:14 | |
| *** quiquell has quit IRC | 12:19 | |
| *** quiquell has joined #zuul | 12:19 | |
| pabelanger | tobiash: heh, I actually see a bug with node-attributes in zuul, missed a place converting from just attributes it seems | 12:27 |
| pabelanger | tobiash: if we did that, we'd need to scope them under the nodepool dict, since that is where we add other variables | 12:28 |
| pabelanger | tobiash: oh, my mistake, not a bug | 12:30 |
| pabelanger | just lack of coffee | 12:31 |
| *** bjackman has joined #zuul | 12:31 | |
| *** avass is now known as avass|afk | 12:31 | |
| *** jpena is now known as jpena|lunch | 12:35 | |
| *** TheJulia is now known as needssleep | 12:42 | |
| *** panda|lunch is now known as panda | 12:55 | |
| tobiash | corvus, Shrews: shall we revive the port cleanup in nodepool (https://review.openstack.org/614370)? | 13:05 |
| tobiash | I needed to cleanup 150 ports today ;) | 13:05 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Revert "Revert "Cleanup down ports"" https://review.openstack.org/614370 | 13:13 |
| *** jpena|lunch is now known as jpena | 13:26 | |
| Shrews | tobiash: probably so | 13:30 |
| Shrews | we should probably get that in and then schedule a nodepool restart with the config changes and that one | 13:31 |
| tobiash | makes sense | 13:32 |
| Shrews | tobiash: that commit msg says sdk is pinned to >=0.19.0, but i don't see that in requirements.txt | 13:34 |
| Shrews | openstacksdk>=0.17.2,!=0.18.0,!=0.20.0 | 13:34 |
| tobiash | hrm, I guess this went wrong during rebase | 13:35 |
| tobiash | thanks, will change that | 13:35 |
| tobiash | Shrews: or should we go ahead and directly require >=0.21.0 | 13:35 |
| tobiash | because of the dogpile problems end of last yead | 13:35 |
| Shrews | oh, req.txt is changed in that review | 13:36 |
| Shrews | duh | 13:36 |
| *** rlandy has joined #zuul | 13:36 | |
| Shrews | tobiash: i forget the history of the dogpile problems | 13:36 |
| *** avass|afk is now known as avass|fika | 13:37 | |
| tobiash | mordred: what was the openstacksdk release that solved the dogpile problems? | 13:37 |
| *** hashar has joined #zuul | 13:37 | |
| tobiash | the latest one (0.23.0) unpins the dogpile dep | 13:38 |
| Shrews | 0.21.0 avoids the problematic dogpile and then that ^ | 13:39 |
| tobiash | so should we go with >=0.21.0? | 13:42 |
| Shrews | openstacksdk>=0.19.0,!=0.20.0 equates to the same, really | 13:42 |
| Shrews | probably clearer to just change it to >=0.21.0 | 13:43 |
| Shrews | oh, i guess that allows 0.19.0 | 13:44 |
| Shrews | i'm fine with 0.21.0 min | 13:44 |
| Shrews | tobiash: commented inline | 13:48 |
| *** bjackman has quit IRC | 13:54 | |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: List changed files for all commits between refs https://review.openstack.org/631797 | 14:04 |
| *** avass|fika is now known as avass | 14:05 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Revert "Revert "Cleanup down ports"" https://review.openstack.org/614370 | 14:05 |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: List changed files for all commits between refs https://review.openstack.org/631797 | 14:09 |
| *** nhicher has joined #zuul | 14:19 | |
| avass | any way to reload tenant configuration without restarting the containers? | 14:20 |
| tobiash | avass: yes | 14:23 |
| avass | or restarting zuul i mean | 14:23 |
| tobiash | avass: https://zuul-ci.org/docs/zuul/admin/components.html?highlight=full%20reconfigure#operation | 14:23 |
| tobiash | just execute zuul-scheduler full-reconfigure inside the container | 14:24 |
| avass | ah. was looking at the wrong place | 14:24 |
| tobiash | yeah, that is maybe not that easy to find in the docs | 14:26 |
| avass | tobiash: i tried to add another untrusted project but it doesn't look like changes take effect | 14:43 |
| tobiash | avass: you should be able to see the reconfiguration in the scheduler log | 14:44 |
| tobiash | just tail it while triggering the reconfig | 14:44 |
| *** saneax has quit IRC | 14:56 | |
| tobiash | ssbarnea|rover: is this the official list of supported ansible versions? https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#release-status | 15:02 |
| ssbarnea|rover | tobiash: yes | 15:03 |
| tobiash | ssbarnea|rover: thanks, I asked because the listed latest version of 2.5 is outdated | 15:04 |
| ssbarnea|rover | tobiash: is part of the docs, and afaik this is not updated automatically | 15:04 |
| tobiash | ok, thakns | 15:05 |
| ssbarnea|rover | i think there was also a page that included EOL for each version, which could prove more useful. better to ask on #ansible-devel | 15:05 |
| dmsimard | Are we missing anything to land the tenant and project metrics ? https://review.openstack.org/#/c/616306/ | 15:20 |
| dmsimard | Already has a +2 | 15:20 |
| tobiash | well it misses at least another +2 | 15:30 |
| *** quiquell is now known as quiquell|off | 15:30 | |
| dmsimard | (╯°□°）╯︵ ┻━┻ | 15:31 |
| dmsimard | it's friday :p | 15:31 |
| *** avass has quit IRC | 15:49 | |
| Shrews | tobiash: https://review.openstack.org/631391 has the changes from the openshift driver you requested, if you're still around | 15:54 |
| *** pcaruana has quit IRC | 16:00 | |
| tobiash | On the way home, will look later | 16:08 |
| *** chandan_kumar is now known as codemonster | 16:17 | |
| jlk | tobiash: Because of GitHub's UX, I wouldn't do a force push if you've already gotten some review on a PR. A follow up commit is fine. GitHub operates CI at a PR level not at a commit level, for better or worse. | 16:26 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add pass-to-parent option for secrets https://review.openstack.org/631670 | 16:38 |
| corvus | tobiash: ^ fixed your nits and implemented the itertools suggestion | 16:39 |
| *** rlandy is now known as rlandy|brb | 16:39 | |
| corvus | mordred, clarkb: ^ https://review.openstack.org/631670 is ready | 16:39 |
| tobiash | corvus: +2 | 16:45 |
| *** panda is now known as panda|off | 17:01 | |
| *** jpena is now known as jpena|away | 17:01 | |
| *** jpena|away is now known as jpena|off | 17:01 | |
| mordred | tobiash: I keep forgetting about itertools.chain | 17:02 |
| tobiash | Yes, that's neat :) | 17:08 |
| *** codemonster is now known as chandankumar | 17:08 | |
| *** hashar has quit IRC | 17:11 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: WIP Build zuul containers with dockerfile not pbrx https://review.openstack.org/631840 | 17:22 |
| gundalow | <SPAM> We are excited to announce that AnsibleFest Atlanta will be held September 24-26, 2019. Mark your calendars now and sign up to be notified when our early, discounted registration opens in May ansible.com/ansiblefest <SPAM> | 17:30 |
| gundalow | </SPAM></SPAM> | 17:31 |
| jlk | I can't buy tix yet :( | 17:31 |
| jlk | I have budget to spend by end of month | 17:31 |
| mordred | jlk: sad trombone | 17:44 |
| jlk | can't buy because there's no form to buy them | 17:44 |
| jlk | I have money, cannot give it to peoples :D | 17:44 |
| jlk | I'll have new money, but I think the majority of that will be going to Deconstruct conf. | 17:44 |
| clarkb | can you pay yourself then buy the tickets when they are available? I'm sure that sets of red accounting flags | 17:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: docker: add ability to restrict repository names https://review.openstack.org/631848 | 17:45 |
| jlk | I'll get another budget refresh in june/july | 17:45 |
| jlk | clarkb: oh yeah totes. I'll just make a Jesse Conf and yeah.... | 17:46 |
| *** rlandy|brb is now known as rlandy | 17:48 | |
| corvus | jlk: i will sell you a nicely printed gift certificate. my markup is (what i consider to be) entirely reasonable. | 17:50 |
| jlk | LOL | 17:51 |
| corvus | pabelanger: re dockerfiles from -infra; we've also identified that it will probably make multi-ansible support in zuul easier. | 17:53 |
| pabelanger | looking forward to seeing what we come up with | 17:53 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add link to git browser in quickstart https://review.openstack.org/631855 | 18:05 |
| corvus | clarkb: is pass-to-parent on your review queue? https://review.openstack.org/631670 | 18:16 |
| mordred | clarkb: I just put the 2nd +2 on https://review.openstack.org/#/c/631670 - do you want to review before I land? | 18:16 |
| corvus | mordred: jinx | 18:16 |
| clarkb | corvus: ya | 18:16 |
| mordred | jlk: I'll sell you a future option for an ansiblefest ticket | 18:16 |
| mordred | jlk: you can trade it in for an ansiblefest ticket at a later date | 18:17 |
| mordred | jlk: of course, it's possible that the current value of the future might exceed the price of an ansiblefest ticket by the time you trade it in, but it's also possible the price of an ansiblefest ticket technically COULD be higher than the cost of the future | 18:18 |
| mordred | in which case it would be a great investment on your part | 18:18 |
| clarkb | corvus: that is not a small change :) | 18:21 |
| clarkb | mostly tests though | 18:21 |
| corvus | yeah, it's like, all tests :) | 18:21 |
| corvus | there's like 20 lines of actually doing stuff. and another 40 of rejiggering data structures. | 18:22 |
| corvus | (that is, for those wondering, a course at my alma mater: CSC310: Rejiggering Data Structures) | 18:22 |
| mordred | corvus: I'm going to assume you chose that number on purpose to imply a progression from 210 | 18:23 |
| mordred | corvus: and as such I very much appreciate the layers of the joke | 18:23 |
| corvus | ;) | 18:24 |
| clarkb | 210 must've been data structures? | 18:25 |
| clarkb | (was 163 for us) | 18:25 |
| corvus | i think 210 was 'how to program in c++'; i think data structures was a 3xx, maybe 310, but i think they changed the numbers and i'm not sure now. | 18:27 |
| corvus | i, uh, don't have my transcript handy | 18:27 |
| jlk | mordred: any chance you could bundle that up with a bunch of other futures on conference items? I'd like to normalize my risk across a wider set of options. | 18:27 |
| corvus | mordred: be sure to include some sub-prime conferences! | 18:27 |
| mordred | jlk: absolutely! just tell me what kind of budget you've got and I'll sell you as many futures as possible | 18:28 |
| mordred | corvus: oh - when I took it, 210 was data structures | 18:28 |
| Shrews | corvus: heh, we had "rejiggering of the kajiggers" | 18:28 |
| Shrews | but we were a mountain school | 18:28 |
| mordred | Shrews: did the class meet over yonder? | 18:29 |
| corvus | Shrews: wow! i didn't stick around for the post-grad stuff. | 18:29 |
| mordred | corvus: actually, I think the full title was "Data Structures and Abstractions" | 18:29 |
| mordred | corvus: the first time I took it it was taught in scheme and did not include any instruction as to how to actually write code in scheme | 18:31 |
| clarkb | corvus: https://review.openstack.org/#/c/631670/3/tests/unit/test_v3.py code around line 3907. First is the assert history only asserting the previous gate job? I think changes=1,1 refers to the first change not the second (B) change there | 18:31 |
| mordred | well, I thnik there was a one-page quick reference that was handed out | 18:31 |
| clarkb | corvus: second, is "does not allow post-review" I thought we were testing that it requires post review? | 18:31 |
| corvus | clarkb: #1 correct -- change 2,1 never runs, so the assert is the same as line 3886 | 18:32 |
| clarkb | oh I see we are asserting it doesn't go in the list | 18:32 |
| clarkb | ya ok | 18:32 |
| corvus | clarkb: #2 yeah, i think you grok #2 now | 18:32 |
| clarkb | ya the check pipeline does not allow post review changes | 18:32 |
| corvus | clarkb: right. the full message is: Pre-review pipeline check does not allow post-review job trusted-under-untrusted | 18:33 |
| clarkb | corvus: do we also need a test for the case where current job is post review but all parents are not? that should remain as post review right | 18:34 |
| corvus | clarkb: i think that's test_secret_ptp_trusted_untrusted? trusted-under-untrusted | 18:39 |
| corvus | oh, wait i think you mean the opposite of that | 18:39 |
| clarkb | corvus: I'm thinking of unstrusted under trusted which I don't think we cover currently | 18:40 |
| clarkb | ya | 18:40 |
| clarkb | to make sure the child doesn't inherit a trusted state | 18:40 |
| clarkb | (if it would otherwise be untrusted) | 18:40 |
| clarkb | (I don't think the code allows this fwiw, just think we should test it probably) | 18:40 |
| corvus | clarkb: k. i think we cover the non pass-to-parent case in the SecretInherintanceTest above, specifically test_untrusted_secret_inheritance_check | 18:41 |
| corvus | clarkb: i think we can add something that covers the case with PTP:true | 18:41 |
| corvus | i'll do a followup | 18:41 |
| clarkb | corvus: ok I've +2'd there was one other minor thing as well. I think you can approve once you are ready though | 18:42 |
| openstackgerrit | Merged openstack-infra/nodepool master: Fix OpenShift driver typo https://review.openstack.org/631391 | 18:43 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add more testing for pass-to-parent https://review.openstack.org/631862 | 18:47 |
| corvus | clarkb: done ^ | 18:47 |
| *** electrofelix has quit IRC | 19:13 | |
| corvus | clarkb: er, that break doesn't work :) | 20:01 |
| clarkb | corvus: really? | 20:01 |
| corvus | clarkb: because we still need to add the secrets | 20:01 |
| clarkb | oh right we are in a bigger loop | 20:01 |
| clarkb | sorry | 20:01 |
| corvus | clarkb: left inline comment | 20:01 |
| corvus | happily the tests all kinds of failed | 20:01 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add more testing for pass-to-parent https://review.openstack.org/631862 | 20:02 |
| corvus | clarkb: that's just the test add now ^ | 20:02 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: WIP Build zuul containers with dockerfile not pbrx https://review.openstack.org/631840 | 20:09 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Use install-js-tools.sh in Dockerfile https://review.openstack.org/631881 | 20:26 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Use install-js-tools.sh in Dockerfile https://review.openstack.org/631881 | 20:29 |
| openstackgerrit | Merged openstack-infra/zuul master: Convert zuul_return into action plugin https://review.openstack.org/591168 | 20:37 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Use install-js-tools.sh in Dockerfile https://review.openstack.org/631881 | 20:53 |
| openstackgerrit | Merged openstack-infra/zuul master: Add link to git browser in quickstart https://review.openstack.org/631855 | 20:54 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: WIP Build zuul containers with dockerfile not pbrx https://review.openstack.org/631840 | 21:02 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Use install-js-tools.sh in Dockerfile https://review.openstack.org/631881 | 21:02 |
| *** rlandy has quit IRC | 21:25 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: WIP Build zuul containers with dockerfile not pbrx https://review.openstack.org/631840 | 21:36 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: WIP Build zuul containers with dockerfile not pbrx https://review.openstack.org/631840 | 21:52 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: Set ANSIBLE_ACTION_PLUGINS for linters https://review.openstack.org/631897 | 22:48 |
| *** dkehn has joined #zuul | 22:55 | |
| *** hashar has joined #zuul | 23:21 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Set ANSIBLE_ACTION_PLUGINS for linters https://review.openstack.org/631897 | 23:24 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/buildsets route https://review.openstack.org/630035 | 23:26 |
| openstackgerrit | Merged openstack-infra/zuul master: Add pass-to-parent option for secrets https://review.openstack.org/631670 | 23:38 |
| openstackgerrit | Merged openstack-infra/zuul master: Add more testing for pass-to-parent https://review.openstack.org/631862 | 23:38 |
| *** hashar has quit IRC | 23:39 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add buildsets page https://review.openstack.org/630041 | 23:55 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/buildset/{uuid} route https://review.openstack.org/630078 | 23:55 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add buildset page https://review.openstack.org/630079 | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!