| *** studarus has joined #zuul | 00:10 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: Use bindep.txt with devstack https://review.openstack.org/630890 | 00:30 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [wip] Use bionic for functional testing https://review.openstack.org/631102 | 00:30 |
| * SpamapS flips desk over | 00:36 | |
| SpamapS | AWS test works fine when run alone | 00:36 |
| SpamapS | but fails when run via `tox -e py36` | 00:36 |
| clarkb | stale deps? you cna use -r to rebuild the venv | 00:38 |
| clarkb | and if you are running the full suite that could indicate you've got leaky tests interacting iwth each other | 00:38 |
| SpamapS | just did | 00:40 |
| SpamapS | the thing is, the only test that causes this, is the first one that times out | 00:41 |
| SpamapS | I'm running with --analyze-isolation now | 00:41 |
| SpamapS | that could take an hour or two :-P | 00:42 |
| SpamapS | And I'm not sure what it will say | 00:44 |
| SpamapS | but hopefully it finds some kind of bad interaction | 00:44 |
| SpamapS | yep, no interaction found | 01:04 |
| SpamapS | well it seems the problem is something with mock.patch and nodescan | 01:16 |
| * SpamapS digs deeper | 01:16 | |
| *** studarus has quit IRC | 01:21 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Amazon EC2 driver https://review.openstack.org/535558 | 01:35 |
| SpamapS | tristanC: ^ and others ... rebased and fixed the test | 01:35 |
| * SpamapS hopes we can get that driver landed | 01:35 | |
| fungi | it's getting a mention in the zuul spotlight for the osf newsletter going out tomorrow (depending on where in the word you are, later today utc) | 02:00 |
| fungi | s/word/world/ | 02:01 |
| openstackgerrit | Merged openstack-infra/nodepool master: Document default values of runtime arguments https://review.openstack.org/630679 | 02:04 |
| *** threestrands has joined #zuul | 02:13 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [wip] Use bionic for functional testing https://review.openstack.org/631102 | 02:57 |
| Shrews | tristanC: not sure if you saw the comment in here from corvus a few days ago, but waiting to approve 570667 once there is a follow up review for the image-pull doc | 02:59 |
| tristanC | Shrews: oh, thanks for the reminder, i'll have a look soon | 03:06 |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 03:26 |
| sshnaidm | tristanC, trying something like that ^^ | 03:27 |
| *** studarus has joined #zuul | 03:35 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: [wip] Use bionic for functional testing https://review.openstack.org/631102 | 03:41 |
| *** threestrands has quit IRC | 03:42 | |
| *** studarus has quit IRC | 03:50 | |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 04:10 |
| *** threestrands has joined #zuul | 04:11 | |
| *** threestrands has quit IRC | 04:11 | |
| *** bjackman_ has joined #zuul | 04:39 | |
| *** sshnaidm has quit IRC | 04:52 | |
| *** sshnaidm has joined #zuul | 04:55 | |
| *** bjackman__ has joined #zuul | 05:00 | |
| *** bjackman_ has quit IRC | 05:03 | |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: Switch devstack jobs to bionic https://review.openstack.org/631102 | 05:35 |
| *** swest has quit IRC | 06:06 | |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 06:13 |
| *** swest has joined #zuul | 06:20 | |
| *** pcaruana has joined #zuul | 07:12 | |
| *** quiquell|off is now known as quiquell | 07:13 | |
| *** gtema has joined #zuul | 07:36 | |
| *** AJaeger has quit IRC | 07:53 | |
| *** quiquell is now known as quiquell|brb | 07:58 | |
| *** gtema has quit IRC | 08:02 | |
| *** AJaeger has joined #zuul | 08:05 | |
| *** gtema has joined #zuul | 08:10 | |
| *** themroc has joined #zuul | 08:23 | |
| *** quiquell|brb is now known as quiquell | 08:23 | |
| *** gtema has quit IRC | 08:50 | |
| *** gtema has joined #zuul | 08:50 | |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 08:51 |
| *** jpena|off is now known as jpena | 09:01 | |
| *** bjackman__ has quit IRC | 09:15 | |
| *** gtema has quit IRC | 10:01 | |
| *** gtema has joined #zuul | 10:03 | |
| *** hashar has joined #zuul | 10:08 | |
| *** electrofelix has joined #zuul | 10:09 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul-jobs master: install-nodejs: add support for RPM-based OSes https://review.openstack.org/631049 | 10:16 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul-jobs master: install-nodejs: add support for RPM-based OSes https://review.openstack.org/631049 | 10:20 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: WIP: Separate out executor server from runner https://review.openstack.org/607079 | 10:23 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: WIP: runner: implement prep-workspace https://review.openstack.org/607082 | 10:23 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: WIP: runner: add execute sub-command https://review.openstack.org/630944 | 10:23 |
| *** sshnaidm is now known as sshnaidm|afk | 10:28 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul-jobs master: install-nodejs: add support for RPM-based OSes https://review.openstack.org/631049 | 10:33 |
| *** hashar has quit IRC | 10:53 | |
| *** panda|off is now known as panda | 11:13 | |
| openstackgerrit | Tobias Urdin proposed openstack-infra/zuul-jobs master: Fix upload-puppetforge role https://review.openstack.org/631194 | 11:32 |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul-jobs master: install-nodejs: add support for RPM-based OSes https://review.openstack.org/631049 | 11:35 |
| *** tobias-urdin has joined #zuul | 11:39 | |
| tobias-urdin | is it possible to make a zuul post-run playbook separate from another one? like if i have: | 11:40 |
| tobias-urdin | - post-run: | 11:40 |
| tobias-urdin | - play1.yml | 11:40 |
| tobias-urdin | - play2.yml | 11:40 |
| tobias-urdin | if play1 fails it shouldn't skip play2 but still give POST_FAILURE | 11:40 |
| *** gtema has quit IRC | 11:43 | |
| *** gtema has joined #zuul | 11:56 | |
| *** gtema has quit IRC | 12:02 | |
| *** gtema has joined #zuul | 12:04 | |
| tobiash | tobias-urdin: I think zuul should behave exactly like that | 12:11 |
| *** bjackman has joined #zuul | 12:18 | |
| *** panda is now known as panda|lunch | 12:31 | |
| *** jpena is now known as jpena|lunch | 12:35 | |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: Add change message to Zuul vars in inventory https://review.openstack.org/631207 | 12:36 |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: Include PR title in change message https://review.openstack.org/631208 | 12:36 |
| *** sshnaidm|afk is now known as sshnaidm | 12:41 | |
| *** avass has joined #zuul | 12:42 | |
| avass | setting submit: false for gerrit seems to throw an exception http://paste.openstack.org/show/742745/ | 12:42 |
| tobiash | avass: submit is opt-in so if you just don't declare it you have the behavior you want | 12:45 |
| tobiash | but I think catching this case might make sense | 12:46 |
| avass | tobiash: yeah i guessed as much, but seems like it would be better to ignore it if it's set to false | 12:46 |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 12:51 |
| *** electrofelix has quit IRC | 12:58 | |
| *** bjackman has quit IRC | 13:02 | |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: Don't request node nodes for skipped child jobs https://review.openstack.org/631213 | 13:04 |
| openstackgerrit | Simon Westphahl proposed openstack-infra/zuul master: Don't request nodes for skipped child jobs https://review.openstack.org/631213 | 13:05 |
| *** bjackman has joined #zuul | 13:06 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul-jobs master: install-nodejs: add support for RPM-based OSes https://review.openstack.org/631049 | 13:18 |
| *** panda|lunch is now known as panda | 13:28 | |
| *** jpena|lunch is now known as jpena | 13:34 | |
| *** rlandy has joined #zuul | 13:39 | |
| *** bjackman has quit IRC | 13:45 | |
| openstackgerrit | Felix Schmidt proposed openstack-infra/zuul master: Add action to task result in zuul_json callback https://review.openstack.org/630622 | 13:46 |
| openstackgerrit | Felix Schmidt proposed openstack-infra/zuul master: Add action to host results in zuul_json callback https://review.openstack.org/630622 | 14:10 |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 14:37 |
| *** quiquell is now known as quiquell|off | 14:39 | |
| *** ssbarnea|rover has quit IRC | 14:40 | |
| *** ssbarnea|rover has joined #zuul | 14:40 | |
| *** gtema has quit IRC | 14:47 | |
| *** snk has left #zuul | 14:48 | |
| *** gouthamr has quit IRC | 14:54 | |
| *** dmellado has quit IRC | 14:56 | |
| jlk | tobiash: maybe! I haven't been able to pay much attention there lately | 15:31 |
| tobias-urdin | tobiash: ack, thanks for the input :) | 15:37 |
| openstackgerrit | Tobias Urdin proposed openstack-infra/zuul-jobs master: Fix upload-puppetforge role https://review.openstack.org/631194 | 15:39 |
| *** avass has quit IRC | 15:52 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Fix docker image password docstring https://review.openstack.org/631266 | 15:57 |
| sshnaidm | pabelanger, clarkb finally succeded to run "show server", but I don't see there userdata :( http://logs.openstack.org/49/630649/13/check/nodepool-functional-py35/476591d/job-output.txt.gz#_2019-01-16_15_19_12_847328 | 16:13 |
| *** gtema has joined #zuul | 16:14 | |
| sshnaidm | pabelanger, clarkb is --os-cloud devstack-admin right credentials to see it? | 16:15 |
| clarkb | I wonder if osc doesn't show it (the api docs say it is included in the response to admin server GETs though) | 16:15 |
| sshnaidm | clarkb, what else can I try? | 16:17 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Add docker image promotion roles https://review.openstack.org/631078 | 16:17 |
| clarkb | sshnaidm: maybe nova client | 16:18 |
| tobiash | jlk: thanks :) | 16:19 |
| pabelanger | sshnaidm: I also think we lay down clouds.yaml, so shouldn't need to use --os-username | 16:22 |
| clarkb | pabelanger: there are multiple users though | 16:22 |
| sshnaidm | pabelanger, what do you mean? | 16:22 |
| clarkb | one is the regular user and the other is admin iirc | 16:22 |
| pabelanger | sshnaidm: actually, never mind. I see we are still using it for the nova keypair-add logic | 16:23 |
| *** pcaruana has quit IRC | 16:25 | |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 16:32 |
| mordred | corvus: I pushed up a doc fix to your docker roles: 631266 | 16:35 |
| mordred | clarkb: ^^ | 16:35 |
| corvus | mordred: approved | 16:38 |
| *** gouthamr has joined #zuul | 16:45 | |
| openstackgerrit | Tobias Urdin proposed openstack-infra/zuul-jobs master: Use PDK to build puppet module https://review.openstack.org/627534 | 16:57 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Fix docker image password docstring https://review.openstack.org/631266 | 17:01 |
| openstackgerrit | Tobias Urdin proposed openstack-infra/zuul-jobs master: Fix upload-puppetforge role https://review.openstack.org/631194 | 17:06 |
| openstackgerrit | Tobias Urdin proposed openstack-infra/zuul-jobs master: Use PDK to build puppet module https://review.openstack.org/627534 | 17:09 |
| *** gtema has quit IRC | 17:18 | |
| * SpamapS starts the process of adapting AWS/EC2 driver to the config extraction | 17:27 | |
| Shrews | SpamapS: should be pretty straight forward. the changes to the openstack driver are a good model to follow: https://review.openstack.org/#/c/621642/4/nodepool/driver/openstack/config.py | 17:33 |
| SpamapS | Shrews: yeah that's exactly what I'm doing | 17:37 |
| SpamapS | thanks | 17:37 |
| SpamapS | 90% done I think | 17:37 |
| SpamapS | Just in time for my team to start investigating google cloud. ;) | 17:37 |
| *** studarus has joined #zuul | 17:43 | |
| *** themroc has quit IRC | 17:44 | |
| tobiash | Just in time for us to start investigating aws :) | 17:50 |
| pabelanger | Same, was planning on looking at it next week myself | 17:51 |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Amazon EC2 driver https://review.openstack.org/535558 | 17:51 |
| SpamapS | ^^ should finally pass all CI | 17:52 |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 17:54 |
| tobiash | I've created a small terraform script that spins up zuul test vm that runs the whole test suite in a minute. | 17:56 |
| tobiash | Is there interest for sharing it somewhere in the zuul repo? | 17:57 |
| tobiash | That comes with a smal tox wrapper that rsyncs the workspace to the node, runs tox and copies back .stestr | 17:58 |
| openstackgerrit | Merged openstack-infra/zuul master: Fix test_load_governor on large machines https://review.openstack.org/630118 | 18:00 |
| *** jpena is now known as jpena|off | 18:03 | |
| Shrews | SpamapS: a small correction noted | 18:06 |
| pabelanger | yay, upgraded to nodepool 3.4.0 | 18:10 |
| pabelanger | now to try out new zuul exeuctor zones | 18:11 |
| Shrews | SpamapS: oops, 2 now | 18:11 |
| SpamapS | Shrews: thanks for reviewing! | 18:13 |
| SpamapS | getting closer I hope | 18:13 |
| corvus | dmsimard, pabelanger, mordred: can you review https://review.openstack.org/630622 ? | 18:20 |
| openstackgerrit | Merged openstack-infra/zuul master: tests: improve test_web to only provision events when needed https://review.openstack.org/630575 | 18:27 |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 18:48 |
| pabelanger | corvus: +2 | 18:49 |
| *** hashar has joined #zuul | 18:59 | |
| *** studarus has quit IRC | 19:14 | |
| *** gouthamr_ has joined #zuul | 19:16 | |
| *** dmellado has joined #zuul | 19:22 | |
| openstackgerrit | Merged openstack-infra/zuul master: Gracefully close db connections in tests https://review.openstack.org/630471 | 19:23 |
| SpamapS | I wonder if we could get Zuul to click the 'squash this' API action instead of the 'merge this'. | 20:01 |
| SpamapS | (for github) | 20:01 |
| SpamapS | I have a lot of users who are very trained to just tack on commits endlessly during reviews, and then use squash at the end. It actually is probably a much better workflow than force-push. | 20:01 |
| SpamapS | I don't see any practical reason it would invalidate the gating process. Ultimately the merge done in the gate and the squash done after would result in the same content in the repo. | 20:02 |
| clarkb | it might make correlating between github and zuul test jobs more difficult after the fact. And increases the amount of work to make zuul push the commits itself | 20:03 |
| clarkb | but I don't think those are deal breakers | 20:03 |
| pabelanger | Yay, I managed to deploy a zuul, from another zuul. zuul's all the way down | 20:05 |
| tobiash | SpamapS: we probalby should combine this with a squash merge method in the mergers | 20:11 |
| tobiash | There is already a possibility to specify the merge mode in the project pipeline | 20:11 |
| tobiash | This could be plumbed through to the reporter | 20:12 |
| SpamapS | Yeah that'd be great. | 20:27 |
| SpamapS | clarkb: I'd love to implement it as part of zuul-pushes actually | 20:27 |
| SpamapS | But yeah, either way, I think it's going to be needed, or github users will see Zuul as a workflow-impediment. | 20:28 |
| SpamapS | Since right now I have to ask people to force-push a squash, or we land a bunch of fixups. | 20:28 |
| clarkb | I was under the impression that was how github always did it fwiw. Didnt' realize they added feature to do it for you. Seems like I'm still occasionalyl asked to squash things | 20:29 |
| SpamapS | It's a controversial feature. | 20:30 |
| SpamapS | You can turn it off. | 20:30 |
| SpamapS | And many projects do. | 20:30 |
| clarkb | SpamapS: ya seems like people are mad that gerrit encourages that type of workflow so odd that github would do it for you too | 20:30 |
| clarkb | but I guess choice is the important thing there | 20:30 |
| SpamapS | but generally, if you look next to the "Merge" button, there's a down arrow and you can choose "Squash and Merge" | 20:30 |
| clarkb | does it let you edit the commit message? or does it use the PR top comment? | 20:31 |
| SpamapS | The commit message becomes the PR description. | 20:31 |
| SpamapS | It might also add some stuff about the squashed stuff, I haven't used it in a while | 20:31 |
| SpamapS | In general I find that github users are *very* confused that commit messages even exist. | 20:31 |
| SpamapS | It's like "what, who cares? it's just a commit message" | 20:31 |
| SpamapS | And IMO that comes from the fact that they don't have inline comments on commit messgaes like Gerrit does, so it's just some side-metadata thing to them. | 20:32 |
| clarkb | ah | 20:32 |
| SpamapS | (until they need to annotate... ;-) | 20:36 |
| *** hashar has quit IRC | 21:03 | |
| *** rcarrillocruz has quit IRC | 21:35 | |
| fungi | zuul is in the spotlight for the osf newsletter which just went out: http://superuser.openstack.org/articles/inside-open-infrastructure-1-16/ | 21:40 |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 21:45 |
| *** gouthamr has quit IRC | 21:56 | |
| *** gouthamr_ is now known as gouthamr | 21:56 | |
| *** studarus has joined #zuul | 22:06 | |
| sshnaidm | clarkb, pabelanger wrt https://review.openstack.org/#/c/630649/I tried nova request with debug, also to download metadata json, nothing shows "userdata": http://logs.openstack.org/49/630649/17/check/nodepool-functional-py35/e2fbac1/job-output.txt.gz#_2019-01-16_22_17_21_133867 | 22:25 |
| sshnaidm | clarkb, pabelanger so I'm outta ideas how to test it.. | 22:25 |
| clarkb | sshnaidm: https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail is the docs for that | 22:26 |
| clarkb | says it is OS-EXT-SRV-ATTR:user_data | 22:26 |
| sshnaidm | clarkb, damn! it's base64 encoded! | 22:28 |
| clarkb | yes and it is there | 22:28 |
| sshnaidm | clarkb, http://logs.openstack.org/49/630649/16/check/nodepool-functional-py35/28db36c/job-output.txt.gz#_2019-01-16_19_20_30_820316 | 22:28 |
| sshnaidm | arghh, I looked for text | 22:29 |
| clarkb | user data is always base64 in nova aiui | 22:29 |
| clarkb | the client tooling helpfully doest he conversion for you | 22:29 |
| sshnaidm | clarkb, yeah, didn't realize that | 22:29 |
| sshnaidm | clarkb, great, thanks, now it's clear, so checking if we have anything is ok? or need to decode it? | 22:30 |
| clarkb | you might want to decode it and check for some substring just to be sure it came from nodepool | 22:30 |
| clarkb | (also is the base64 data in the osc output?) | 22:30 |
| *** threestrands has joined #zuul | 22:51 | |
| openstackgerrit | Sagi Shnaidman proposed openstack-infra/nodepool master: Support userdata for instances in openstack https://review.openstack.org/630649 | 22:54 |
| *** rlandy is now known as rlandy|bbl | 23:26 | |
| SpamapS | clarkb: just tested and GitHub's squash+merge actually stops to let you edit the commit message. | 23:35 |
| clarkb | nice | 23:35 |
| clarkb | (that is how I would want it to work so good to see they give you that option) | 23:35 |
| SpamapS | speaking of Gerrit | 23:38 |
| SpamapS | I just got a 38" ultra-wide curved monitor and... gertty diffs are *glorious* | 23:38 |
| sshnaidm | clarkb, pabelanger I maked: https://review.openstack.org/#/c/630649/ | 23:43 |
| sshnaidm | ready for review | 23:43 |
| *** sshnaidm is now known as sshnaidm|afk | 23:43 | |
| jlk | it's ... somewhat nice | 23:45 |
| jlk | but it still changes the hash at merge time | 23:45 |
| jlk | (necessary), but there is no CI check for that | 23:46 |
| clarkb | jlk: ya that is a git behavior you can't get around | 23:47 |
| SpamapS | jlk: wouldn't be necessary if github would adopt the git-review/gerrit model for PR's. ;) | 23:48 |
| clarkb | (the new sha1) | 23:48 |
| jlk | yeah yeah | 23:48 |
| jlk | actually I think you can PREDICT what that hash would be before the merge happens | 23:48 |
| SpamapS | I'm surprised we haven't ever gotten around to zuul pushing directly. | 23:49 |
| SpamapS | Which would allow us to control our destiny here. | 23:49 |
| clarkb | jlk: git accounts for the timestamp so if you fake the time you can | 23:49 |
| clarkb | (this is why cherry picking gives you a new sha1 too) | 23:49 |
| mordred | SpamapS: zuul pushing directly is a thing we've wanted to get to - it's also required for implemeting lock-step/circular depends | 23:55 |
| mordred | SpamapS: so I believe it's actually a thing we'll see in the not-too-distant future | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!