Wednesday, 2018-10-31

*** pall is now known as pabelanger00:18
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Update devstack test to Fedora 28  https://review.openstack.org/61437500:21
pabelangerianw: https://review.openstack.org/559211 might be of interest, I could restore if you wanted to take over00:23
ianwpabelanger: oh, heh sorry missed that.  sorry it sat so long, i had it in my head to update dib to native v3 jobs before migrating everything00:27
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Update devstack test to Fedora 28  https://review.openstack.org/61437500:30
*** pabelanger is now known as pall00:33
*** ssbarnea has quit IRC00:52
*** bhavikdbavishi has joined #zuul03:31
*** bhavikdbavishi has quit IRC03:31
*** bhavikdbavishi has joined #zuul03:33
tobiashianw: left a comment on https://review.openstack.org/61407404:56
ianwtobiash: yeah, happy to do more levels.  we have *some* camelcase as the openstacksdk stats get converted to that, but yeah, i think you're right we probably shouldn't introduce new ones04:59
openstackgerritTobias Henkel proposed openstack-infra/zuul-jobs master: Add prepare-workspace-git role  https://review.openstack.org/61303605:11
openstackgerritMerged openstack-infra/zuul-jobs master: Updated bindep to cover for MacOS requirements  https://review.openstack.org/61372705:19
*** pcaruana|elisa| has joined #zuul05:29
*** pcaruana|elisa| has quit IRC05:37
*** swest has joined #zuul05:49
*** bhavikdbavishi has quit IRC05:56
*** bhavikdbavishi has joined #zuul06:08
*** bhavikdbavishi has quit IRC06:38
*** bhavikdbavishi has joined #zuul06:39
*** chkumar|off is now known as chandankumar07:13
openstackgerritMerged openstack-infra/zuul master: Collect docker logs after quick-start run  https://review.openstack.org/61302707:25
*** pcaruana|elisa| has joined #zuul07:45
*** sshnaidm|off is now known as sshnaidm|ruck08:03
*** bhavikdbavishi has quit IRC08:16
*** bhavikdbavishi has joined #zuul08:28
*** ssbarnea has joined #zuul08:40
*** jpena|off is now known as jpena08:52
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Logs stats for nodepool automated cleanup  https://review.openstack.org/61407408:54
*** panda|off is now known as panda09:01
*** hasharAway is now known as hashar09:03
*** pcaruana|elisa| has quit IRC09:13
*** pcaruana|elisa| has joined #zuul09:15
*** bhavikdbavishi has quit IRC09:15
*** bhavikdbavishi has joined #zuul09:16
*** bhavikdbavishi has quit IRC09:47
*** bhavikdbavishi has joined #zuul09:48
*** lennyb has quit IRC09:48
*** lennyb has joined #zuul09:49
*** ianychoi has quit IRC09:51
*** ianychoi has joined #zuul09:52
*** pbrobinson has quit IRC10:05
*** electrofelix has joined #zuul10:07
*** bhavikdbavishi has quit IRC10:11
*** hashar is now known as hasharLunch11:28
*** bhavikdbavishi has joined #zuul11:43
*** pbrobinson has joined #zuul11:54
*** panda is now known as panda|lunch12:15
*** themroc has joined #zuul12:20
*** rlandy has joined #zuul12:38
*** jpena is now known as jpena|lunch12:46
*** sshnaidm|ruck is now known as sshnaidm|bbl12:50
*** bhavikdbavishi has quit IRC12:57
*** panda|lunch is now known as panda13:02
*** lennyb has quit IRC13:10
ssbarneaany zuul guru around? i am wondering how hard it would be to make zuul able to deal with priority queues as described in https://review.openstack.org/#/c/613753/13:24
SpamapSssbarnea: I believe that's already a thing.13:35
ssbarneaSpamapS any hints would be welcomed, preferably as comments on that proposal. At this moment it describes only the reasoning and expected behaviour, I didn't check the technical aspects yet.13:37
ssbarneaif this is possible using proposed idea, or simething similar it would be *super*13:37
SpamapSssbarnea: I think right now, there's a way for admins to bump changes up13:39
* SpamapS is looking for how that's done13:39
SpamapSIIRC there is something, because the scenario described in the spec happens a lot in OpenStack.13:40
SpamapSalmost once per 6 month cycle.13:40
*** goern has quit IRC13:46
SpamapSssbarnea: https://zuul-ci.org/docs/zuul/admin/client.html#promote13:46
*** jpena|lunch is now known as jpena13:48
*** goern has joined #zuul13:56
*** hasharLunch is now known as hashar14:17
corvushi!  anything interesting happen while i was away?14:31
Shrewscorvus: tristanC has the k8s func tests working14:35
corvusyay!14:36
*** themroc has quit IRC14:37
Shrewswell, func "test" (singular). it's a start14:37
*** themroc has joined #zuul14:38
fungicorvus: zuul.openstack.org is running great. should be all clear to tag the pending release!14:43
mordredcorvus: we moved to the zk cluster14:46
mordredcorvus: and also, a bug in openstacksdk combined with the cleanup leaked ports patch in nodepool caused ALL of the ports in one of tobiash's tenants to get deleted (oops)14:47
tobiashfortunately it killed only 300 jobs and nothing of the control plane (which I wisely separated from nodepool)14:49
fungithat cleanup feature got reverted though, right?14:51
mordredit did - but a re-revert is up for review ... https://review.openstack.org/61437014:53
*** ianychoi has quit IRC15:00
*** bhavikdbavishi has joined #zuul15:26
tobiashmordred: this time I'll leave it to you to try this out ;)15:49
mordredtobiash: :)15:57
*** nilashishc has joined #zuul16:09
*** goern has quit IRC16:09
*** bhavikdbavishi has quit IRC16:18
*** bhavikdbavishi has joined #zuul16:19
*** hashar is now known as hasharAway16:27
*** pcaruana|elisa| has quit IRC16:37
openstackgerritMerged openstack-infra/zuul master: Filter file comments for existing files  https://review.openstack.org/61316116:37
*** themroc has quit IRC16:49
*** chandankumar is now known as chkumar|off16:53
*** bhavikdbavishi1 has joined #zuul16:57
*** bhavikdbavishi has quit IRC16:59
*** bhavikdbavishi1 is now known as bhavikdbavishi16:59
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP: support foreign required-projects  https://review.openstack.org/61314317:26
*** pwhalen has quit IRC17:30
*** electrofelix has quit IRC17:38
Shrewshow unfortunate that our experimental nodepool jobs do not capture nodepool logs17:50
Shrewsoh, they do! just named weirdly17:51
*** panda is now known as panda|off17:53
clarkbShrews: are they screen-nodepool?17:53
clarkbif so thats devstack log ahndling sillyness17:53
Shrewsclarkb: yeah17:54
*** jpena is now known as jpena|off18:04
*** bhavikdbavishi has quit IRC18:30
manjeetsHi, I am trying to run standalone zuul with just zuul.conf and tenant_conf, but zuul service start is giving me an error18:40
manjeetsTraceback (most recent call last):18:40
manjeets  File "/usr/local/bin/zuul-executor", line 6, in <module>18:40
manjeets    from zuul.cmd.executor import main18:40
manjeets  File "/usr/local/lib/python2.7/dist-packages/zuul/cmd/__init__.py", line 15818:40
manjeets    class ZuulDaemonApp(ZuulApp, metaclass=abc.ABCMeta):18:40
manjeetsseems like py3 issue ?18:41
corvusmanjeets: yes, zuul only supports python 318:41
corvusspecifically, i think we require at least version 3.518:41
manjeetscorvus, I have py2 and py3 both on vm, how do I force it to run on 3 ?18:42
clarkbyup, there are annotations in the code which 3.4 doesn't understand18:42
corvusmanjeets: if you install it with python3, it should work correctly.  you may need to uninstall it, then install it with "pip3" (depending on your distro)18:43
manjeetsthanks corvus, I think a note should be added to documentation either on quick start where docker-compose example is shown or in zuul setup18:44
manjeetsthat would help18:44
corvusmanjeets: yes, thanks, we should put something here: https://zuul-ci.org/docs/zuul/admin/installation.html18:45
corvusthe docker-compose case should be handled though -- it runs from images with python318:45
manjeetscorvus, docker-compose gave me so many errors so I'm trying simple zuul first https://zuul-ci.org/docs/zuul/admin/installation.html18:46
corvusmanjeets: what errors did you get?18:47
manjeetsI created files manaully on host from where i fired docker-compose18:47
manjeetseven though those files exists but give me an error http://paste.openstack.org/show/733716/18:48
manjeetsException: Unable to read tenant config file at /home/ubuntu/zuul/doc/source/admin/examples/etc_zuul/main.yaml18:48
manjeetscorvus, I also changed the zuul.conf to point at https://review.openstack.org18:48
corvusmanjeets: if you look at http://git.zuul-ci.org/cgit/zuul/tree/doc/source/admin/examples/etc_zuul/zuul.conf you'll see that the path for the tenant config file is /etc/zuul/main.yaml.18:49
manjeetsother issue is sshkey path, I defined the path to key from host which exists but its not able to find that18:49
manjeetshttp://paste.openstack.org/show/733719/18:49
corvusmanjeets: that file is http://git.zuul-ci.org/cgit/zuul/tree/doc/source/admin/examples/etc_zuul/main.yaml18:49
corvusmanjeets: the docker-compose file maps that directory into the container, so you don't need to update the path18:50
corvusmanjeets: just edit the file in place.18:50
corvusmanjeets: (in other words, /home/ubuntu/zuul/doc/source/admin/examples/etc_zuul/ on your VM is mapped into /etc/zuul/ inside the container)18:50
manjeetsoh so I just use /etc/zuul/zuul.conf in conf because of mapping of container path18:51
corvusyep18:51
manjeetsand what about sshkey path ? how's that mapping work ?18:51
corvusmanjeets: the ssh key is probably a similar problem, you'll want to put it in a directory that's mapped into the containers.18:51
corvusmanjeets: you can probably use the etc_zuul or etc_nodepool directories to hold your ssh key18:52
corvusmanjeets: if you look at http://git.zuul-ci.org/cgit/zuul/tree/doc/source/admin/examples/docker-compose.yaml you can see the mappings in there.  for example "./etc_zuul/:/etc/zuul/:z" means "map etc_zuul on the host to /etc/zuul in the container"18:53
manjeetscorvus, so I just put in sshkey in etc_zuul or etc_nodepool and it will be ~/.ssh/id_rsa in container ?18:53
corvusmanjeets: no it would be '/etc/zuul/id_rsa'18:54
corvusmanjeets: (or /etc/nodepool/id_rsa)18:54
manjeetsohk thanks corvus I spent whole yesterday assuming those scripts might be creating another user and key may not exists in that user's ~/.ssh18:55
manjeetsmy bad18:55
corvusmanjeets: you're probably the first person to go past the end of the docker-compose tutorial :)18:56
*** sshnaidm|bbl is now known as sshnaidm|ruck18:57
manjeetscorvus, I think if I figure this docker compose thing, it will make things easy in future, third part ci would be matter of one command, we have 3rd part ci but it has millions of scripts and very hard for new comers to setup and debug18:59
manjeetsthanks for your help19:00
corvusmanjeets: yeah, i think that'll be a good use.  let us know how it goes :)19:01
*** nilashishc has quit IRC19:09
*** rcarrillocruz has joined #zuul19:39
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul-jobs master: Add role to install kubernetes  https://review.openstack.org/60582319:49
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Add tox functional testing for drivers  https://review.openstack.org/60951519:55
*** dmsimard has quit IRC20:05
*** hasharAway has quit IRC20:20
manjeetscorvus, I think I just passed those errors and saw in logs it tried to connect gerrit20:33
manjeetswould it work if I don't define config-project ?20:34
*** caphrim007_ has joined #zuul20:36
manjeetsI was able to see gerrit stream from openstack.org this is cool thanks corvus and clarkb20:42
corvusmanjeets: you'll need a config-project in order to set up your pipelines (ie, the third-party check pipeline you will define)20:43
manjeetscorvus, I have question on that, since that project is separate from review.openstack.org and not available there, can i make pointers to config-project from local repo that's running all this set up20:44
corvusmanjeets: yes, you can use the 'git' driver to do that.20:45
manjeetscool thanks corvus20:45
corvusmanjeets: https://zuul-ci.org/docs/zuul/admin/drivers/git.html20:45
corvusmanjeets: you set it up like a github or gerrit connection, but you can give it a url.  it can be a "file:///" url.20:46
manjeetsgot it thanks !20:47
manjeetsso the comment part goes to main.yaml (like posting comments to a gerrit patch) ? or it should be added test job ?20:51
manjeetscorvus, sorry for asking so many questions but what is this section in zuul.conf for ? http://git.zuul-ci.org/cgit/zuul/tree/doc/source/admin/examples/etc_zuul/zuul.conf#n2321:10
clarkbianw: for https://review.openstack.org/#/c/613196/ is there a sibling change in zuul for consistency?21:11
corvusmanjeets: the comment part goes in the pipeline definition -- like http://git.zuul-ci.org/cgit/zuul/tree/doc/source/admin/examples/zuul-config/zuul.d/pipelines.yaml#n1721:12
caphrim007_hey folks. should this url be working? https://git.zuul-ci.org/openstack-infra/zuul-jobs/21:12
corvusmanjeets: that section is so we can import the zuul-jobs repo.  it isn't used in the docker-compose example yet, but we plan on adding documentation about how to use existing jobs from that repo21:12
clarkbcaphrim007_: https://git.zuul-ci.org/cgit/zuul-jobs/ is the url you are looking for (note the cgit/ not opensatck-infra/ prefix)21:13
corvuscaphrim007_: https://git.zuul-ci.org/zuul-jobs/  should work (no openstack-infra); where did you see that so we can update?21:13
caphrim007_corvus: good question. lemme see if i can find where i saw it21:14
corvus(clarkb and i are both right, dependeng on whether you want to browse or clone)21:14
ianwclarkb: no, i'm not sure zuul is really doing anything similar where the external exception is very closely tied to the internal request21:17
clarkbianw: ah, well I +2'd but didn't approve on the basis of not wanting the two to diverge. Maybe corvus knows if this would be useful in zuul too?21:18
corvusianw: can you catch me up on that?21:18
caphrim007_corvus: I dont think this is where I saw it...perhaps it was some old config I was reading that has since been updated. the only reference i see now is here https://zuul-ci.org/docs/zuul/admin/drivers/git.html in the first sentence21:18
clarkbhttps://review.openstack.org/#/c/613196/ is the change in question21:18
caphrim007_and maybe that ref is correct21:18
ianwcorvus: https://review.openstack.org/#/c/613196/ ; i think the change explains the reasoning in my usual too much detail :)21:18
corvusyes zuul has something like that which i would like to see ported elsewhere in zuul and possibly nodepool21:19
corvuslet me dig it up21:19
corvusianw, clarkb: http://git.zuul-ci.org/cgit/zuul/tree/zuul/executor/server.py#n61421:20
corvusianw, clarkb: the executor creates a logging adaptor for every job, so that you can untangle the output for different jobs21:20
corvusianw, clarkb: we pass that to the merger too, so that merger output is tied to the job as well21:21
manjeetscorvus, http://paste.openstack.org/show/733738/ if I want to run a job on ci-sandbox21:21
manjeetsi think i need to add config-project here in this file21:21
clarkbcorvus: in that case sounds like zuul already does this where helpful so this change to nodepool makes nodepool more consistent21:21
corvusclarkb: but it does it a different way21:22
ianwcorvus: hrm, i'll have to take a closer look, does that handle the multi-line issue thought?  is every line passed to the adapter?21:22
corvusit doesn't specifically change the exception format21:22
corvuser, let me check :)21:23
clarkbya zuul puts it on top of the existing logging formatters, whereas nodepool change uses a special formatter21:23
ianwi was surprised it was such a pain TBH, but i couldn't find a better way to catch each line of the exception traceback21:24
ianwi don't think it quite does -> http://paste.openstack.org/show/733739/21:26
ianwalthough, that doesn't have the [build] bit ...21:26
corvusthat's not using it21:26
corvusnope, it's like the standard logging: http://paste.openstack.org/show/733740/21:28
ianwyeah, i can see where it does the ansible output thing, but not where it catches and prefixes an exception.  my feeling is it wouldn't, because the lines are added in the formatter21:28
corvusi think there are two issues -- identifying different threads/processes in log lines, and having any identifiers on exception lines21:29
ianwyeah.  i think for nodepool the threads/processes thing is fine, the info is in the logging record that comes in21:30
ianwit's just quite annoying that grepping for the request doesn't show you any of the related openstacksdk failures21:30
ianwwhich tell you if it's nova, neutron, misconfiguration, etc21:30
corvusthe exception thing is also nice for when you are grepping timestamps out of logs (i do that frequently and only get the first line of the traceback)21:30
ianwyep, since it's the same record it has the same timestamp21:31
corvusit might be nice to have both things... maybe we can combine them21:33
corvussomething like the adaptor which lets you specify the prefix and pass around the logger between objects, and then the formatter which ensures the exception is formatted21:34
clarkbianw: ya I do a lot of grep -A 10 -B 1021:34
corvusput another way: the thing in nodepool, but with an explicit prefix rather than a magic one based on the thread name21:34
ianwat least for the launchers, the thread is fairly helpful21:35
ianw2018-10-25 05:11:53,515 ERROR nodepool.NodeLauncher-000341278621:35
ianwe.g.21:35
clarkbianw: that is the node id?21:37
corvusyep, though with an explicit identifier, we could have just the node id (without the unecessary text) and other info like request number, tec21:37
corvusetc21:37
ianwclarkb: yep21:38
corvusit looks like the two things we're talking about really do need two implementations.  so to combine them, i think we'd need to make an adaptor class to handle the explicit prefix, then a formatter class to attach it to the exceptions21:39
corvusbut i think if we did that, we could use the same thing pretty much everywhere in nodepool and zuul21:41
caphrim007_anyone encountered this when viewing a job in the zuul web ui? http://paste.openstack.org/show/733742/21:43
ianwcoruvs: i gotta go for a bit, i'll have to context switch in the logging adapter stuff.  if you'd like to put some breadcrumb comments on 613196 i can look21:44
corvusianw: cool, done21:52
caphrim007_corvus: does zuul periodically run merger to update the zuul configs it knows about in the various untrusted-projects it is configured for? or how does that happen?22:01
corvuscaphrim007_: for github/gerrit it watches for merge events and updates immediately; for the plain git driver, it polls periodically22:07
*** rlandy is now known as rlandy|bbl22:26
caphrim007_corvus: any idea what i might look at to resolve this? http://paste.openstack.org/show/733744/22:28
caphrim007_i'm stumped on the 'NoneType' object has no attribute 'project'22:29
corvuscaphrim007_: neat.  that's an unhandled error.  my guess is that it's due to the name "noop" which is a special internal-only job in zuul (it's the only such job).22:32
corvuscaphrim007_: i think if you change the name, it'll work.  and we should add a test / fix that error reporting :)22:32
caphrim007_oh goodie. i just picked that name. go me22:32
caphrim007_lemme try a name change22:32
corvuscaphrim007_: great minds think alike22:32
caphrim007_corvus: is noop-jobs also reserved like seen here? http://git.openstack.org/cgit/openstack-infra/project-config/tree/zuul.d/projects.yaml#n878922:33
caphrim007_or is that a safe name to use22:33
corvuscaphrim007_: on a related note, that job is defined internally and does what the description says, so you don't have to define it.  :)  (depending on whether your goal is to execute a noop job, or you're working through the process of making incrementally more complex jobs)22:34
corvuscaphrim007_: that template name is fine to use22:34
caphrim007_corvus: at this point I think I'm still fumbling. i just want to create a periodic noop job so that i can see it doing "stuff"22:34
corvuscaphrim007_: (that template is not already defined, so if you want something like that, you'll need to define it yourself.  ours is defined here: http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/zuul.d/project-templates.yaml#n18 )22:35
caphrim007_okie doke22:36
corvuscaphrim007_: the internal noop job really does nothing, so it's useful for exercising triggering / reporting, but doesn't generate any logs or anything.22:36
caphrim007_ok. good to know22:37
caphrim007_corvus: should project-templates be in config-projects? or untrusted-projects?22:40
corvuscaphrim007_: either one at your convenience (there's no functional difference for templates)22:42
caphrim007_corvus: if i want to shared it across projects, the path of least resistence is config-project, aye?22:42
corvuscaphrim007_: all the config items within a tenant are globally accessible, so even that will work either way22:43
caphrim007_oh. ok, was no aware22:43
caphrim007_not*22:43
*** caphrim007_ has quit IRC22:45
kmalloccorvus: you're going to be in berlin, right?22:46
* kmalloc assumes so... but.22:46
corvuskmalloc: yes22:46
kmalloccorvus: cool22:46
kmalloc:)22:46
*** ianychoi has joined #zuul23:35

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!