| *** sambetts_ has quit IRC | 00:00 | |
| *** sambetts_ has joined #zuul | 00:02 | |
| corvus | zuul knows the starting and end lines of the configuration stanza where an error occurs, but not the exact line. should we leave the line comment on the first line or the last line of the stanza? | 00:08 |
|---|---|---|
| clarkb | I find it easier to read them at the end in gerrit | 00:08 |
| mordred | yeah - I was going to say at the end | 00:08 |
| clarkb | because then the yellow comment doesnt break up the text | 00:08 |
| mordred | corvus: is it possible in the api to highlight a section of lines when leaving the inline comment? | 00:09 |
| mordred | if so - it might be nice to leave it as a comment on the range of lines | 00:09 |
| corvus | i don't think i've seen that in the api; has anyone seen that in gerrit webui? | 00:10 |
| mordred | https://review.openstack.org/#/c/577035/6/doc/source/user/jobs.rst | 00:10 |
| mordred | that comment I left you in those docs did that | 00:10 |
| mordred | you click and drag in the web ui, then when you hit comment, it associates the comment with the selection | 00:10 |
| mordred | you can also do it with individual words | 00:10 |
| mordred | like here: https://review.openstack.org/#/c/577035/6/tests/unit/test_gerrit.py | 00:11 |
| corvus | cool -- i'm going to -1 https://review.openstack.org/577035 with that, because we should put that in zuul's file-comment plumbing | 00:11 |
| clarkb | ya you have to highlight then hit c | 00:11 |
| mordred | neat | 00:11 |
| mordred | I think this is going to be a super awesome feature | 00:12 |
| corvus | yeah. when we figure out how to do that with the api, i think highlighting the whole config snippet is the right answer to that UI question :) | 00:12 |
| mordred | ++ | 00:13 |
| corvus | mordred, clarkb: is that highlight whole lines, or partial lines? | 00:14 |
| corvus | mordred: oh, your second example answeres that question :) | 00:14 |
| mordred | corvus: looks like this: | 00:14 |
| openstackgerrit | Merged openstack-infra/zuul master: Add openstacksdk to executor extras https://review.openstack.org/586717 | 00:15 |
| clarkb | its arbitrary strings | 00:15 |
| clarkb | contiguous strings | 00:15 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Report config errors as line comments https://review.openstack.org/581908 | 00:15 |
| corvus | okay, well, that ^ leaves comments at the end, and would have been ready for review except for the highlight thing. i'll circle back on those two changes and add that | 00:16 |
| mordred | http://paste.openstack.org/show/726771/ | 00:16 |
| mordred | corvus: that's a captured payload | 00:16 |
| mordred | in pidgin-yaml | 00:16 |
| corvus | oh, and character is character on line, isn't it? not index in file | 00:17 |
| mordred | I think so yeah | 00:17 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Report config errors as line comments https://review.openstack.org/581908 | 00:17 |
| mordred | yes | 00:17 |
| corvus | updated patch to save the end column :) | 00:18 |
| corvus | mordred: yep here's the docs, looks like your capture: https://review.openstack.org/Documentation/rest-api-changes.html#comment-info | 00:19 |
| corvus | so should just be a matter of adding a range with start/end lines/chars | 00:19 |
| mordred | woot! | 00:19 |
| mordred | corvus: I left a comment with the link to that paste above - and with the inline comment that produced it :) | 00:20 |
| corvus | mordred: cool, thanks | 00:20 |
| corvus | i think i had better go work on dinner now, but this shouldn't take long to fix up i think. | 00:21 |
| clarkb | yes on the dinner. I need to figure out what I can do withthis csa box. Last night was stir fry | 00:22 |
| corvus | i'm pretty sure that supporting range will be forward-compatible; if it is, i'll remove my -1 and add it in a followup. | 00:24 |
| openstackgerrit | Merged openstack-infra/zuul master: Report to gerrit over HTTP https://review.openstack.org/577027 | 00:45 |
| *** swest has quit IRC | 01:12 | |
| *** swest has joined #zuul | 01:26 | |
| *** openstackstatus has quit IRC | 01:46 | |
| *** openstackstatus has joined #zuul | 01:49 | |
| *** ChanServ sets mode: +v openstackstatus | 01:49 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: Add role to fetch zuul logs from nodes https://review.openstack.org/583346 | 01:51 |
| corvus | also *of course* line numbers are base-1 and characters are base-0. | 02:09 |
| *** ianychoi has quit IRC | 02:11 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Support line comments in Gerrit https://review.openstack.org/577035 | 02:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Report config errors as line comments https://review.openstack.org/581908 | 02:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add support for line comment ranges https://review.openstack.org/586733 | 02:19 |
| corvus | okay that's the whole deal | 02:19 |
| *** ianychoi has joined #zuul | 03:22 | |
| *** maeca has quit IRC | 04:57 | |
| *** fbouliane has quit IRC | 07:47 | |
| *** fbouliane has joined #zuul | 07:48 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Support job pause https://review.openstack.org/585389 | 08:47 |
| *** bhavik1 has joined #zuul | 08:47 | |
| *** bhavik1 has quit IRC | 09:06 | |
| *** goern has quit IRC | 09:18 | |
| *** sambetts_ has quit IRC | 09:59 | |
| *** sambetts_ has joined #zuul | 10:00 | |
| *** sshnaidm|off has quit IRC | 10:26 | |
| *** sshnaidm|off has joined #zuul | 12:10 | |
| *** _ari_ has quit IRC | 12:34 | |
| *** _ari_ has joined #zuul | 12:34 | |
| openstackgerrit | Merged openstack-infra/zuul master: Support line comments in Gerrit https://review.openstack.org/577035 | 15:42 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: Add a role to return file comments https://review.openstack.org/579033 | 16:05 |
| *** xhku_ has joined #zuul | 18:15 | |
| *** fbouliane has quit IRC | 18:17 | |
| *** sshnaidm|off has quit IRC | 18:50 | |
| *** sshnaidm|off has joined #zuul | 22:02 | |
| *** elyezer has quit IRC | 23:05 | |
| *** elyezer has joined #zuul | 23:08 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!