Wednesday, 2018-06-20

corvusmwhahaha: if you add the "debug: true" setting to the project-pipeline config (i recommend you do this in the change where you're also changing the config, it'll only apply to that one so it won't be global) when zuul reports back, it will include a bunch of info about which variants did/did not match00:49
mwhahahaOk I'll have to try that. It wasn't honoring my change to branches in the results00:50
corvusyeah, add that to that change and it should tell you why00:53
corvushttps://zuul-ci.org/docs/zuul/user/config.html#attr-project.%3Cpipeline%3E.debug00:54
*** ianychoi_ has quit IRC02:27
*** ianychoi has joined #zuul02:30
openstackgerritFergus Yu proposed openstack-infra/zuul master: Fix indent error for layout.yaml-sample.  https://review.openstack.org/57668402:52
*** mnaser has quit IRC03:42
*** mnaser has joined #zuul03:45
*** mwhahaha has quit IRC03:48
*** sdoran has quit IRC03:48
*** robcresswell has quit IRC03:49
*** LinuxJedi has quit IRC03:49
*** jtanner has quit IRC03:49
*** zxiiro has quit IRC03:49
*** gregdek has quit IRC03:49
*** mattclay has quit IRC03:49
*** spsurya has quit IRC03:49
tristanCcorvus: Shrews: could we do a nodepool-3.0.2 or 3.1.0 release soon? The last 3.0.1 is missing the paused handler and the connection-port (for static nodes) fix03:49
*** jbryce has quit IRC03:49
*** maxamillion has quit IRC03:49
*** gundalow has quit IRC03:50
*** portdirect has quit IRC03:50
*** abelur has quit IRC03:50
*** TheJulia has quit IRC03:50
*** hogepodge has quit IRC03:50
*** mnaser has quit IRC03:51
*** fdegir has quit IRC03:51
*** patrickeast has quit IRC03:51
*** Guest19794 has quit IRC03:51
*** mrhillsman has quit IRC03:51
*** kmalloc has quit IRC03:51
openstackgerritMerged openstack-infra/zuul master: Add a CVE-2018-12557 release note  https://review.openstack.org/57654504:06
*** openstack has joined #zuul04:32
*** ChanServ sets mode: +o openstack04:32
*** gundalow has joined #zuul05:23
*** abelur has joined #zuul05:25
*** TheJulia has joined #zuul05:25
*** zxiiro has joined #zuul05:25
*** jtanner has joined #zuul05:28
*** mwhahaha has joined #zuul05:28
*** sdoran has joined #zuul05:28
*** patrickeast has joined #zuul05:30
*** LinuxJedi has joined #zuul05:30
*** maxamillion has joined #zuul05:31
*** mattclay has joined #zuul05:34
*** fdegir has joined #zuul05:35
*** kmalloc has joined #zuul05:40
*** mnaser has joined #zuul05:42
*** swest has quit IRC05:47
*** spsurya has joined #zuul05:47
*** mnaser has quit IRC05:51
*** mnaser has joined #zuul05:51
*** robcresswell has joined #zuul05:53
*** abelur has quit IRC05:55
*** mnaser has quit IRC05:56
*** mwhahaha has quit IRC05:56
*** jtanner has quit IRC05:56
*** kmalloc has quit IRC05:56
*** sdoran has quit IRC05:57
*** gundalow has quit IRC05:57
*** spsurya has quit IRC05:57
*** zxiiro has quit IRC05:57
*** maxamillion has quit IRC05:57
*** robcresswell has quit IRC05:58
*** LinuxJedi has quit IRC05:58
*** TheJulia has quit IRC05:58
*** fdegir has quit IRC05:58
*** patrickeast has quit IRC05:58
*** mattclay has quit IRC05:58
*** mnaser has joined #zuul06:10
*** nchakrab has joined #zuul06:13
*** patrickeast has joined #zuul06:20
*** mrhillsman has joined #zuul06:20
*** TheJulia has joined #zuul06:20
*** jbryce has joined #zuul06:21
*** zxiiro has joined #zuul06:21
*** Rohaan has joined #zuul06:21
*** portdirect has joined #zuul06:21
*** portdirect has quit IRC06:21
*** portdirect has joined #zuul06:21
*** maxamillion has joined #zuul06:23
*** mattclay has joined #zuul06:23
*** kmalloc has joined #zuul06:23
*** fdegir has joined #zuul06:23
*** gundalow has joined #zuul06:24
*** abelur has joined #zuul06:24
*** jtanner has joined #zuul06:24
*** mwhahaha has joined #zuul06:25
*** LinuxJedi has joined #zuul06:26
*** spsurya has joined #zuul06:26
*** robcresswell has joined #zuul06:26
*** sdoran has joined #zuul06:26
*** gtema has joined #zuul06:44
*** gregdek has joined #zuul06:55
*** Guest19794 has joined #zuul06:59
*** hogepodge has joined #zuul07:00
*** Rohaan___ has joined #zuul07:12
*** Rohaan has quit IRC07:12
*** hashar has joined #zuul07:20
*** swest has joined #zuul07:43
*** Rohaan___ has quit IRC07:48
*** Rohaan___ has joined #zuul07:49
*** Rohaan___ has quit IRC08:05
*** pcaruana has joined #zuul08:11
*** Rohaan___ has joined #zuul08:24
*** swest has quit IRC08:24
*** wei_liu_ has joined #zuul08:46
*** spsurya has quit IRC08:46
*** wei_liu_ has quit IRC08:48
*** sshnaidm|afk is now known as sshnaidm08:57
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: github: prevent KeyError in getProjectBranches when rate limitted  https://review.openstack.org/57679909:13
corvustristanC: can the nodepool release wait till next week?09:26
openstackgerritIan Wienand proposed openstack-infra/zuul-base-jobs master: Add validate-host and log-inventory  https://review.openstack.org/57680209:28
tristanCcorvus: sure09:28
*** electrofelix has joined #zuul09:34
openstackgerritJens Harbott (frickler) proposed openstack-infra/zuul-jobs master: Log output and exception when traceroute fails  https://review.openstack.org/57635109:45
*** jesusaur has quit IRC09:49
*** jesusaur has joined #zuul09:53
*** nchakrab_ has joined #zuul09:58
*** nchakrab has quit IRC10:01
*** nchakrab_ has quit IRC10:02
*** nchakrab has joined #zuul10:19
*** jpena is now known as jpena|lunch11:09
*** gtema has quit IRC11:37
*** nchakrab has quit IRC11:43
*** spsurya has joined #zuul11:43
Shrewswe really should do a np restart to get that paused handler fix in11:46
Shrewsand i forgot a release note for that fix. will make one11:48
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Add release note for paused handler fix  https://review.openstack.org/57682711:54
*** nchakrab has joined #zuul12:09
*** jpena|lunch is now known as jpena12:15
*** nchakrab_ has joined #zuul12:17
*** nchakrab has quit IRC12:21
*** rlandy has joined #zuul12:22
tobiashShrews: +312:33
openstackgerritMerged openstack-infra/nodepool master: Add release note for paused handler fix  https://review.openstack.org/57682712:43
openstackgerritMerged openstack-infra/zuul master: Fix indent error for layout.yaml-sample.  https://review.openstack.org/57668412:45
*** myoung|off is now known as myoung12:48
*** gtema has joined #zuul12:52
*** nchakrab has joined #zuul13:17
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Make streaming test run longer than connection timeout  https://review.openstack.org/57252213:19
*** nchakrab_ has quit IRC13:20
Shrewsfyi: I will be leaving in 30m for another dr appt13:21
mordredShrews: good luck with that13:23
Shrewsthx13:28
*** nchakrab_ has joined #zuul13:31
*** nchakrab has quit IRC13:34
*** maxamillion has quit IRC13:38
*** maxamillion has joined #zuul13:38
*** hashar is now known as hasharAway13:39
*** Rohaan___ is now known as Rohaan13:45
*** nchakrab has joined #zuul13:48
*** nchakrab_ has quit IRC13:51
tristanCShrews: good luck, hope it goes well!14:04
*** nchakrab_ has joined #zuul14:16
*** nchakrab has quit IRC14:19
*** Rohaan has quit IRC14:58
*** nchakrab_ has quit IRC15:04
*** acozine1 has joined #zuul15:09
*** acozine1 has quit IRC15:10
*** acozine1 has joined #zuul15:16
*** rlandy is now known as rlandy|mtg15:48
*** hasharAway is now known as hashar16:01
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] web: add tenant-scoped autohold, enqueue  https://review.openstack.org/57690716:26
*** rlandy|mtg is now known as rlandy16:46
*** sshnaidm is now known as sshnaidm|off16:52
tobiashcorvus, mordred: do you find these messages useful (the starting finished queue processor)? http://paste.openstack.org/show/723945/17:05
tobiashcorvus, mordred: I'm asking because they are log that for every pipeline in every tenant17:06
tobiashcorvus, mordred: this spams 150 lines every few seconds in our deployment17:06
*** jpena is now known as jpena|off17:07
tobiashcorvus, mordred: I'm not asking about the 'what do the pipelines' but just about the start and end of each pipeline processing step17:07
mordredtobiash: I don't personally - but I don't commune with the scheduler logs as deeply as corvus does17:09
tobiashthe start/finish messages actually make it hard for me to spot the actual work within our now 78 pipelines distributed over 13 tenants17:14
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] web: add tenant-scoped autohold, enqueue  https://review.openstack.org/57690717:18
*** spsurya has quit IRC17:23
*** gtema has quit IRC17:23
*** gtema has joined #zuul17:25
*** gtema has quit IRC17:33
pabelangerso, I've noticed the fetch-zuul-cloner role doesn't take into account the git URL in the CLI, for example17:45
pabelangerthe zuul-cloner role sets repo_src_dir: "/home/zuul/src/review.rdoproject.org" then the following fails:17:46
pabelanger/usr/zuul-env/bin/zuul-cloner -m clonemap.yaml --cache-dir /opt/git git://git.openstack.org openstack/tripleo-quickstart17:46
pabelangerbecause it looks in the wrong directory17:46
*** SpamapS has quit IRC17:46
pabelangerto fix it , I think we need to set repo_src_dir and update the zuul-cloner copy script to parse out the correct URL and append it to reps_src_dir17:47
pabelangerotherwise, have to do a bunch of symlinks for mulitple zuul connections17:47
*** electrofelix has quit IRC17:59
*** bhavik1 has joined #zuul18:10
*** hashar is now known as hasharAway18:10
*** myoung is now known as myoung|lunch18:11
mordredpabelanger: well, it's supposed to be a short-lived tool with no features18:26
mordredpabelanger: if I were you, I'd fork it for rdo so you can not be stuck while getting folks off of it18:27
mordred(just because that way you can just hard-code rdoproject.org in the fork, right?)18:27
*** gtema has joined #zuul18:28
*** bhavik1 has quit IRC18:28
*** yolanda_ has joined #zuul18:35
goernhey all, I have extended one job (the linter) but my part requires coala (which is not installed by default) what are the keywords to search for?18:35
*** ianychoi has quit IRC18:36
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Allow fetch-zuul-cloner to support multiple connections  https://review.openstack.org/57693318:37
pabelangermordred: sure, we say it is short-lived, but it lives in zuul-jobs. So, I'd expect people to consume it.  I don't have an issue forking it, but makes migrating from JJB harder.  Maybe it should just be in openstack-zuul-jobs18:38
pabelangeralso, what I am thinking for an update ^18:38
pabelangerbut will break openstack-infra today, because of REPO_SRC_DIR default, we'd need to stage the change18:38
pabelangeralso, totally untested18:38
*** yolanda__ has joined #zuul18:39
*** yolanda has quit IRC18:39
*** yolanda_ has quit IRC18:40
mordredgoern: heya! so ... 'it depends' (I know, everyone's favorite answer)18:44
mordredgoern: is this the linter job in zuul-jobs you're talking about extending?18:44
fungigoern: what linter job did you extend? if it runs under tox, then adding your additional linter dependency to your test-requirements.txt would probably work, or to a deps list in the specific testenv in your tox.ini18:44
mordredgoern: (and do you have a link I could look at?)18:44
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Allow fetch-zuul-cloner to support multiple connections  https://review.openstack.org/57693318:45
mordredpabelanger: I'm not opposed to fixing it in zuul-jobs- just mostly was thinking that, as you mention, doing that is going to require _care_ - and I didn't want you to get too blocked on improving a thing we'd eventually like to delete18:47
mordredpabelanger: but maybe I'm wrong about the deleting thing and maybe it should stay around in zuul-jobs for longer to facilitate migrations for people?18:48
mordredpabelanger: (thinking out loud)18:48
pabelangeryah, I think we should maybe discuss the jenkins migration story a bit more. While I've been able to make some good progress with zuul-migrate and rdoproject.org, there is still a lot it doesn't cover. But I'd say 80% of the jobs are functional by running it.  Which, is an easy win to move to zuul18:50
pabelangerbut also agree, we can just fork it in rdo to keep moving forward18:50
mordredpabelanger: ++18:51
mordredpabelanger: I mostly want to make sure I'm not making your life harder while we discuss it18:52
mordredoh - and yeah - zuul-migrate is ... imperfect at best18:52
pabelangerworked well for single node jobs18:53
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Allow fetch-zuul-cloner to support multiple connections  https://review.openstack.org/57693318:53
mordredpabelanger: yah. the extra complicated stuff is where it goes south18:55
pabelangeryup, I think we if ever revisit. Maybe strip out everything but stuff for single node jobs. More complicated jobs (eg: multinode) just need to be native zuulv3 jobs18:57
mordredyah. there's just no way to do them automatically18:59
goernmordred, fungi ja... it is ... https://github.com/goern/thoth-zuul-test-jobs/blob/feature/adding-linter-coala/roles/linters/tasks/lint_coala.yaml and we are using Pipenv all over the place.. rather then tox or requirements.txt19:01
goernmordred, fungi so the questions seems to be: how to use Pipenv with jobs?19:02
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Allow fetch-zuul-cloner to support multiple connections  https://review.openstack.org/57693319:06
*** myoung|lunch is now known as myoung19:06
*** SpamapS has joined #zuul19:06
*** SpamapS has quit IRC19:07
*** SpamapS has joined #zuul19:07
*** yolanda_ has joined #zuul19:08
*** yolanda_ has quit IRC19:09
*** yolanda_ has joined #zuul19:10
fungigoern: it's mostly a question of methodology i guess. we settled on tox as an entrypoint for executing those sorts of jobs because that way there's a single, simple command our developers can also run to repeat the same tests locally. this allows us to provide a more consistent experience in the ci system as in their local dev environments19:10
goernfungi, sounds about right19:11
fungigoern: so the way i'd approach it is first ask what you've documented that your developers should run locally to test their changes, and orchestrate the same set of steps in your job definitions19:11
*** yolanda__ has quit IRC19:12
fungiif that's some assortment of shell commands including pipenv and pip install and running coala from the env or whatever, then encode the same steps in your job definitions19:12
fungiwe found that if jobs perform substantially different steps than the devs run locally, they get confused, frustrated, even angry when they can't reproduce failures the ci system is reporting back to them19:13
goernfungi, ja... we are coming from travis... so its `pipenv install; pipenv run coala`19:13
fungiin that case, that's probably what i'd recommend putting in the job. how does pipenv install know to install coala?19:14
fungii'm admittedly not that familiar with pipenv... presumably a requirements file or something?19:14
goernfungi, it has a look at a file called Pipfile in the / of the repo19:14
fungiahh, okay, that sounds familiar. so if your pipfile includes coala then in theory that should just do what you want right?19:15
goernfungi, ja, but I need to pip install --user pipenv first, right? $HOME/.local/bin is in the path of that jobs... so it would find subsequent pipenv calls19:15
fungigoern: sure. if you expect your developers to install and use pipenv then ideally your job would install it the same way they do19:16
mordredyah - in our tox jobs, we actually have a base job that installs tox - so I think potentially a similar base job that installs pipenv that can be used by people using pipenv is not a terrible idea19:16
goernfungi, ack. is there a base/general job that handles tox?19:16
fungithere is. it's in the zuul-jobs standard library19:17
mordred(also, that's the sort of base job that would make sense in zuul-jobs)19:17
mordredhttps://github.com/openstack-infra/zuul-jobs/blob/master/zuul.yaml#L1519:17
mordredgoern: ^^19:17
*** yolanda_ has quit IRC19:17
mordredgoern: fwiw, there's another tool we use that we have plumbed in that may or may not be useful to you called bindep19:18
goernmordred, I'll basically copy that job and make it install pipenv19:18
mordredgoern: ++19:18
*** zaro__ has joined #zuul19:18
mordredgoern: bindep is how we have people specify distro package depends they need - and the base jobs there will install what's needed - you don't have to do anything with it if you don't want to - but it's a use case that comes up so I figured I'd mention it19:19
fungialso known as http://git.zuul-ci.org/cgit/zuul-jobs/tree/zuul.yaml#n1519:19
mordredfungi: good point19:19
*** yolanda has joined #zuul19:19
fungior https19:20
goernmordred, fungi bindep sounds like binary dependency... install moar RPM or DEB?! pipenv is a python module19:20
mordredhttps://git.zuul-ci.org/cgit/zuul/tree/bindep.txt <-- is an example in case that helps19:20
mordredgoern: oh- totally19:20
mordredgoern: we use ot more for things like "lxml requires libxml-dev to be installed for pip to be able to install it"19:20
goernmordred, gotthat19:21
fungigoern: right. tox uses pip to install things but you could make a pipenv job which did a `pip install --user pipenv;pipenv install` and as mordred says that would probably be a great addition to the zuul-jobs standard library upstream19:21
fungiit would probably also do `pipenv run {something}` which was then parameterized so it could be overloaded to run whatever a specific inheriting job wanted to run with pipenv19:22
goernfungi, ack, where do I add the job in https://github.com/goern/thoth-zuul-test-jobs so that I can work on it and migrate/sendPr later on19:22
goernzuul.d/_included-jobs.yaml seems to be wrong?!19:23
goernjust add a zuul.d/base-pipenv.yaml?19:23
mordredgoern: yah - all the files in the directory get read19:24
goernmordred, on, any proposed name to match your schemata?19:25
mordredthey do get read in alphnumeric order - which is I imagine why that file was written with a _ in it19:25
mordredgoern: we typically just make a file called "jobs.yaml"19:25
*** zaro__ has quit IRC19:25
mordredgoern: but honestly whatever works for you - when we lift it into zuul-jobs later, we can just copy the yaml section in19:25
goerntrue19:25
*** zaro__ has joined #zuul19:26
pabelangerokay cool, so https://review.openstack.org/576933/ does work but will break jobs. as show by jobs failing, I'll fork for now until we can come up with plan19:26
mordredpabelanger: sweet19:26
pabelangermordred: indeed, depends-on cross project is awesome!19:26
mnasermordred: another crazy frontend idea that i hope one day i get around is to enable logins to the dashboard19:28
mnaseri.e. login via gerrit or github19:28
mnaserand seeing only your jobs in the dashboard19:29
* mnaser has wanted something like that for a while19:29
mordredmnaser: there's some discussion somewhere about what authentication looks like for zuul api in general  - I don't think that use case has been mentioned19:33
mnaseri think it's one to keep in mind19:33
mnasercould introduce all sorts of cool ideas like19:34
mnaserretriggering jobs as a user from the ui rather than a comment19:34
fungiright, i think we've wanted an authenticated rpc for stuff like that far back into zuul v2 time, just never got time to spec it out and grapple with the security concerns it brings19:36
fungicertainly retriggering jobs without having to leave hacky comments in a code review system has been one of the primary use cases19:36
*** gtema has quit IRC19:36
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] web: add tenant-scoped autohold, enqueue  https://review.openstack.org/57690720:19
*** pcaruana has quit IRC20:41
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] web: add tenant-scoped autohold, enqueue  https://review.openstack.org/57690720:49
*** acozine1 has quit IRC20:53
*** myoung is now known as myoung|off21:07
*** yolanda has quit IRC21:35
*** yolanda has joined #zuul21:40
corvustobiash, mordred: as annoying as those messages are, the start/stop messages actually are very useful when debugging issues (i used them the other day).  i'd like to keep them in the debug log, but we can make sure they aren't in the regular log.  ideally the normal (info-level) log is what one should use to see what's happening in the system anyway.22:07
*** hasharAway has quit IRC22:25
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] web: add tenant-scoped autohold, enqueue  https://review.openstack.org/57690722:25
*** rlandy has quit IRC23:26

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!