| tristanC | corvus: that makes sense. Thanks for the review, i'll update the patch now. | 00:32 |
|---|---|---|
| tristanC | and thanks a lot for approving 535511 ! | 00:34 |
| *** rlandy|rover has quit IRC | 00:52 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: scheduler: add job's parent name to the rpc job_list method https://review.openstack.org/573473 | 01:01 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/job/{job_name} route https://review.openstack.org/550978 | 02:02 |
| *** D3VIATION has joined #zuul | 02:28 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/projects and /{tenant}/project/{project} routes https://review.openstack.org/550979 | 02:48 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: angular6 fix attempt https://review.openstack.org/573494 | 03:43 |
| openstackgerrit | Artem Goncharov proposed openstack-infra/zuul master: fill `delta`, `start`, `end` for skipped `creates` and `removes` command. https://review.openstack.org/567864 | 04:33 |
| *** ianychoi has quit IRC | 04:44 | |
| *** D3VIATION has quit IRC | 04:52 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Refactor load sensors into drivers https://review.openstack.org/549275 | 05:33 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: WIP: Add cgroup support to ram sensor https://review.openstack.org/549506 | 05:33 |
| *** pcaruana has joined #zuul | 05:57 | |
| -openstackstatus- NOTICE: Zuul stopped receiving gerrit events around 04:00UTC; any changes submitted between then and now will probably require a "recheck" comment to be requeued. Thanks! | 06:03 | |
| *** pcaruana has quit IRC | 06:14 | |
| *** pcaruana has joined #zuul | 06:15 | |
| SpamapS | argh... autoholds don't hold timeout fails. :-/ | 06:22 |
| * SpamapS adds an explicit fail and rechecks that hour long job :-P | 06:22 | |
| *** gtema has joined #zuul | 06:59 | |
| *** hashar has joined #zuul | 07:03 | |
| openstackgerrit | Artem Goncharov proposed openstack-infra/nodepool master: Use openstacksdk instead of os-client-config https://review.openstack.org/566158 | 07:33 |
| fbo_ | corvus: hi, 573438 is the best solution to reduce all these new try/except. Let me know if I can help to finalize this patch. | 07:48 |
| *** D3VIATION has joined #zuul | 07:52 | |
| *** jpena|off is now known as jpena | 07:53 | |
| *** D3VIATION has quit IRC | 07:56 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Don't use GRANT to create new MySQL users https://review.openstack.org/573641 | 09:30 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Add --check-config option to zuul scheduler https://review.openstack.org/542160 | 10:55 |
| *** jpena is now known as jpena|lunch | 11:09 | |
| *** jpena|lunch is now known as jpena | 12:02 | |
| *** mugsie_ is now known as mugsie | 12:14 | |
| *** acozine1 has joined #zuul | 12:30 | |
| *** rlandy has joined #zuul | 12:31 | |
| *** rlandy is now known as rlandy|rover | 12:31 | |
| *** Rohaan has joined #zuul | 12:39 | |
| *** myoung|off is now known as myoung | 12:59 | |
| gtema | mordred: I can contribute to your angular patch fixing sizing of filter box on builds page and adding a loading spinner (new component, so reusable) to builds and jobs. Interested? | 13:10 |
| mordred | gtema: absolutely. feel free to push up a new patch or do a follow up patch (although maybe the spinner wants to be a follow up patch since that patch is so huge anyway) | 13:25 |
| gtema | mordred: I agree it is huge, but permanent rebasing of a followup is also not very nice | 13:29 |
| mordred | this is very true (I have a stack on it) - honestly either way works for me | 13:30 |
| gtema | ok. What is the "expectation" date for the merge? I can wait if it is just couple of days. Also think about upgrading bootstrap to v4 also | 13:31 |
| mordred | gtema: hopefully soon - there's a few bugs in the current one that tristan has some fixes up for - I'm looking at them right now | 13:33 |
| tobiash | corvus, dmsimard: attached a zuul-fix to the story | 13:33 |
| mordred | fbo_: I can also just land that patch if you feel like making a follow up to clean up the try/excepts? | 13:34 |
| mordred | gtema: oh - also, yes - mnaser was also suggesting a bootstrap4 upgrade - definitely agree | 13:39 |
| *** tflink has quit IRC | 13:40 | |
| gtema | bootstrap should be separate patch, I can take care of that | 13:42 |
| mordred | ++ | 13:42 |
| mordred | gtema: I'll get a new version of the main patch up with tristanC's fixes in just a few minutes | 13:43 |
| mordred | gtema: I also have an update for the form ... but the spacing still isn't right | 13:43 |
| gtema | http://paste.openstack.org/show/722975/ - inside of builds.component.html | 13:44 |
| -openstackstatus- NOTICE: A misapplied distro security package update caused many jobs to fail with a MERGER_FAILURE error between ~06:30-12:30 UTC; these can be safely rechecked now that the problem has been addressed | 13:48 | |
| gtema | mordred: another small thing - in the jquery.zuul.js line 419 ".css('display', 'block')" instead of ".css('margin-top', '-6px')". It causes cutted status image in FF | 13:50 |
| mordred | gtema: yes! that's pretty much what I added locally - but the button still seems too close to the last field to me | 13:54 |
| gtema | for me it's perfect in Chrome and FF | 13:56 |
| *** tflink has joined #zuul | 13:56 | |
| gtema | Konqueror - also fits | 13:56 |
| mordred | awesome. there's one difference in yours from what I had - trying that | 13:58 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Upgrade from angularjs (v1) to angular (v6) https://review.openstack.org/551989 | 14:00 |
| mordred | tristanC, gtema: I think this encompases the fixes | 14:00 |
| gtema | mordred: thanks | 14:01 |
| mordred | tristanC: I disagreed with you on one of them - left notes about it in the original review ... but I fixed the logo link in a different manner | 14:01 |
| gtema | what's with gerrit - hangs in "working" | 14:01 |
| gtema | ok, now better | 14:02 |
| mordred | it's working for me - maybe you got lucky? | 14:02 |
| gtema | actually with gerrit I have stucks and troubles since early morning | 14:02 |
| gtema | mordred: now I know why the button is too close for you. I forgot to add tiny css change: http://paste.openstack.org/show/722979/ | 14:03 |
| *** ianychoi has joined #zuul | 14:04 | |
| *** tflink has quit IRC | 14:04 | |
| gtema | mordred: with bootstrapv4 it would be easier without css change | 14:04 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Upgrade from angularjs (v1) to angular (v6) https://review.openstack.org/551989 | 14:06 |
| mordred | gtema: ah - neat. trying that now | 14:07 |
| mordred | gtema: yes! thank you! | 14:07 |
| gtema | welcome | 14:08 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Upgrade from angularjs (v1) to angular (v6) https://review.openstack.org/551989 | 14:09 |
| Rohaan | tristanC: Hi, you there? | 14:09 |
| mordred | tristanC, tobiash, corvus: ^^ ok - I think it's finally actually ready | 14:10 |
| mordred | gtema: the other thing we've talked about, once that patch is in - is reworking the status page to not use jquery and instead use angular components - mnaser did a patch a little while back that started work on that (but using vue.js) ... mostly mentioning it in case you just get excited about making javascript patches | 14:11 |
| mnaser | gtema, mordred: my patch last time was mostly like "lets try and see what we can do" | 14:12 |
| mnaser | the thing that really bothers me is that it cant be jquery and angular, it's one or the other | 14:12 |
| Rohaan | I was trying out your Zuul-openshift integration draft which you shared with me yesterday. But I'm stuck at step 3.1 ; I've applied all the patches specified, but when I try to do `nodepool list --detail`, I get https://pastebin.com/zKMwyiAN | 14:12 |
| mnaser | which means big patch :< | 14:12 |
| mordred | mnaser: yah. | 14:12 |
| mordred | mnaser: luckily we have live previews | 14:12 |
| Rohaan | I'm trying out https://softwarefactory-project.io/draft/zuul-openshift/ | 14:13 |
| mordred | mnaser: I'm going ot rebase your fix-queue-headers patch on the angular patch if that's ok - that patch makes me SO HAPPY | 14:13 |
| mnaser | mordred: yes, please do, i'm a bit overwhelmed with work | 14:14 |
| gtema | mordred: great. I have implemented spinner as a component, so not using plain JS. I will wait for your patch to land before I submit it | 14:14 |
| mordred | mnaser: ZOMG THAT PATCH IS SO MUCH BETTER | 14:18 |
| mnaser | right?! i've been waiting for it to merge | 14:18 |
| mnaser | lol | 14:18 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Hide queue headers for empty queues when filtering https://review.openstack.org/572588 | 14:19 |
| mordred | mnaser: there it is rebased | 14:19 |
| mnaser | it feels so pleasent | 14:19 |
| mordred | yes | 14:19 |
| mnaser | to look at the dashboard | 14:19 |
| mnaser | its much more relaxing imho | 14:19 |
| mnaser | lol | 14:19 |
| mordred | it's gonna be even better to get the page to stop redrawing but instead just kind of morph around | 14:19 |
| mnaser | yeah i just kinda worked it up a little bit | 14:19 |
| mnaser | i knew we were moving to angular so didnt want to super rearchitect the whole thing | 14:20 |
| mnaser | pabelanger: suggested a switch to put finger:// links rather than console | 14:20 |
| gtema | probably then use redux? | 14:20 |
| mnaser | does redux suppliment angular or is it it's own framework | 14:21 |
| pabelanger | Yes please | 14:21 |
| gtema | it's basically own "pattern" of separating UI from the application state | 14:21 |
| gtema | it is possible to integrate it into Angular | 14:21 |
| gtema | s/it/with | 14:22 |
| mnaser | i think maybe we can add another option next to "Expand by default" to say "Use finger links" or something | 14:22 |
| mnaser | finger link-ing good | 14:22 |
| mnaser | (it's friday) | 14:22 |
| corvus | mnaser: or we could put an extra link for finger next to the name of the job (web link) | 14:23 |
| mnaser | ooh yes thats a nice idea | 14:23 |
| mnaser | and actually | 14:23 |
| mnaser | much easier to implement | 14:23 |
| mnaser | maybe like a little console icon | 14:23 |
| pabelanger | with the finger emoji :p | 14:23 |
| *** tflink has joined #zuul | 14:23 | |
| gtema | +1 | 14:24 |
| mnaser | only finger emoji i'm finding | 14:24 |
| mnaser | is not the one we want to use | 14:24 |
| mnaser | :P | 14:24 |
| mnaser | mordred: do you know off the top of your head if we use font awesome in the dashboard? | 14:25 |
| gtema | I guess not | 14:25 |
| corvus | mnaser: i think we will in the future. mordred has a change to use glyphicons, which i think is a good idea, but fontawesome has similar symbols, so i think we should look at using that. | 14:26 |
| corvus | https://review.openstack.org/551992 is change for glyphicons | 14:26 |
| mnaser | https://fontawesome.com/icons/terminal?style=solid | 14:26 |
| corvus | (zuul-ci.org uses fontawesome) | 14:27 |
| mnaser | urgh | 14:27 |
| mordred | yah - I haven't gotten around to changing that to fontawesome yet | 14:27 |
| mnaser | so many nice ones in font awesome | 14:27 |
| mnaser | but they've gone the whole | 14:27 |
| mnaser | "we have a pro version" route | 14:27 |
| mordred | corvus: oh - also - updating this patch reminded me of a thing, I can't remmeber if I wrote this change yet or not ... | 14:28 |
| corvus | mnaser: yeah, i restricted myself to looking at the free ones | 14:28 |
| mnaser | some of the pro ones are nice fits but oh well | 14:28 |
| mnaser | https://fontawesome.com/icons/window?style=regular | 14:28 |
| corvus | i'm not thrilled about open core fonts, but... | 14:29 |
| mnaser | ++ | 14:29 |
| mnaser | out of principle i'd prefer a 100% open version.. even if it doesn't get us much nicer choice | 14:29 |
| corvus | ya | 14:29 |
| mordred | corvus: but I'd like to get the REST API to stop returning stream.html?... in the status json and instead build that url from the build uuid directly in the javascript | 14:30 |
| gtema | agree | 14:30 |
| corvus | (glyphicons is, aiui, in the same situation) | 14:30 |
| corvus | mordred: that seems reasonable.... probably with some info from the info/ endpoint too i'd guess? | 14:31 |
| mordred | yup | 14:31 |
| mnaser | http://fontello.com/ | 14:31 |
| mnaser | this allows us to build our own little font but also it has plenty of choices | 14:31 |
| mnaser | so we might be able to pick and choose and minimize the number of dependencies | 14:31 |
| corvus | mordred: other users will just have to repeat that work, but it's not like it's a big deal | 14:31 |
| mnaser | like just grab 1 or 2 icons | 14:31 |
| mnaser | searching 'terminal' there i like the one under web symbols but anyawys | 14:32 |
| mordred | corvus: yah - the other option would be to have the scheduler return the websocket url instead of the html rendering of it | 14:32 |
| corvus | mnaser: neat -- though we'll want to try to match style as much as possible | 14:32 |
| mordred | corvus: since that's *really* the thing that an API user would want to know | 14:33 |
| mnaser | corvus: ++ | 14:33 |
| * fungi wonders why icons can't just be svg files... overloading font selection to provide graphical elements seems like a hack, but i guess it's hack like that which the web is built on | 14:33 | |
| fungi | somehow it became a de facto standard while i wasn't looking | 14:34 |
| mnaser | fungi: thats a good point too. beyond me, trend that started and just contiuned i guess | 14:34 |
| mordred | fungi: something something rendering speed something something | 14:34 |
| mordred | fungi: but yeah | 14:34 |
| fungi | i suppose a font file gets you a precached set of all the graphical elements you'll be using so the browser doesn't lazy-load rare ones on some pages | 14:34 |
| corvus | mordred: i may not understand what you're saying about the url | 14:35 |
| mordred | corvus: I may not understand what I'm saying | 14:35 |
| Shrews | #topic Web fonts: Good for your CI/CD project, or a waste of bits? Discuss | 14:37 |
| mnaser | one benefit is if your app is accessible via the interwebs, you can use the common CDNs that host these libraries | 14:38 |
| mnaser | so 99% of the time it will likely be precached | 14:38 |
| mnaser | i.e. https://developers.google.com/speed/libraries/ | 14:38 |
| mnaser | i like that they still host script.aculo.us | 14:38 |
| mnaser | last release of that was in 2010 | 14:39 |
| mordred | corvus: but I take another stab- the json has "stream.html?uuid=c72e2f48a42044eebf28ab9e8f227ee2&logfile=console.log" - which is great if the consumer of the api is the dashboard | 14:39 |
| corvus | mnaser: some of us prefer to avoid feeding the giant tracking engines with more data, so we work to make sure that doesn't happen. of course, i don't mind if someone wants to enable that on their own site, but i prefer the software itself not to require that (and we try to avoid it in openstack-infra) | 14:39 |
| mordred | corvus: but a person who is not the dashboard using the api to do things with status who then wants to show you the console stream - would potentially want the finger url to the stream and/or the websocket url | 14:40 |
| *** TheJulia is now known as needssleep | 14:40 | |
| mordred | so - we could either just say "you can construct the finger url or the websocket url from these informations in /info plus the build uuid" - or we could add finger url and websocketurl links to the payload - or we could do both | 14:40 |
| corvus | mordred: gotcha. probably one or the other is better :) | 14:41 |
| mordred | yah | 14:41 |
| mordred | I agree :) | 14:41 |
| corvus | the json blob is big enough as it is :) | 14:41 |
| mordred | corvus: we could always turn it in to a protobuf and make it much smaller ;) | 14:42 |
| mordred | I'm amazed I haven't yet figured out how to suggest protobuf-over-afs as a solution to anything yet | 14:42 |
| Shrews | mordred: lol | 14:42 |
| corvus | btw, i'm only here for a little while longer -- i'm going to be leaving for the day in a little bit. | 14:44 |
| mordred | corvus: if you have brainspace in your short remaining time ... wanna re-look at the latest version of the angular patch? | 14:44 |
| mordred | corvus: I believe all of the concerns from yesterday have been addressed | 14:44 |
| mnaser | corvus: yes, i agree about the tracking engines part, and also i tihnk if we're delivering a software that is self hosted, we shouldn't have external dependencies | 14:46 |
| mordred | mnaser, corvus: it might be nice to make a build-time optin thatwould allow people to tell webpack to use cdn links instead of including things in the bundle if they wanted to | 14:47 |
| mordred | my webpack isn't quite yet good enough to write that patch | 14:48 |
| corvus | mordred: i have no objection to that | 14:48 |
| mordred | corvus: and then for the one we run, we would, of course, not enable that option :) | 14:48 |
| *** Rohaan has quit IRC | 14:51 | |
| *** hashar is now known as hasharAway | 14:54 | |
| *** myoung is now known as myoung|biaf | 14:57 | |
| corvus | mordred: http://logs.openstack.org/94/573494/1/check/zuul-build-dashboard/299d272/npm/html/status.html doesn't look quite right (also, the multi-tenant job failed, but may be unrelated) | 15:10 |
| mordred | corvus: hrm. that doesn't look right does it? | 15:10 |
| corvus | mordred: according to the debug console, the jobs and builds tabs are also trying to fetch the api urls from the log server | 15:11 |
| mordred | how the heck did that break? | 15:11 |
| * mordred cries | 15:11 | |
| corvus | mordred: oh wait, that's the wrong change | 15:11 |
| corvus | mordred: sorry, that was tristan's fix which you squashed | 15:12 |
| gtema | new build is not ready, there is huge queue as far as I can see | 15:12 |
| gtema | 3 min jobs (regular) are being queued for more than 1 hour now | 15:13 |
| mordred | corvus: *phew* | 15:13 |
| mordred | gtema: yah - there were some issues yesterday and overnight - andit's a milestone date for openstack - so the queues are pretty epic | 15:14 |
| gtema | mordred: yup. It might be that we do not get your build today (at least my TZ) ;-) | 15:16 |
| mordred | gtema: yah :) | 15:16 |
| mnaser | mordred: on the subject of throwing cool ideas | 15:26 |
| mnaser | https://github.com/spotz/vancouver18/blob/master/gitandgerrit.pdf | 15:27 |
| mnaser | the slides with zuul status reminded me we had the sparkline for the pipeline | 15:27 |
| mnaser | not sure if we can do something like that still now but it was nice to have an idea of whats going on | 15:27 |
| corvus | mnaser: mordred has a place in the info api endpoint so that we can know if there's a graphite server and add those back in | 15:29 |
| corvus | mnaser: with knowledge of the graphite url, you can just construct an <img> link for them | 15:30 |
| mnaser | that would be cool | 15:30 |
| * mnaser has to find more time in the day | 15:31 | |
| corvus | mordred: i think we're at the point where if your patch works after the test results come back, it's probably ready to merge, so don't wait for me :) | 15:34 |
| corvus | fbo_: i probably won't be able to work on the exception handler patch until tuesday or wednesday next week, so if you have time to make progress on it before then, please do! :) | 15:35 |
| *** myoung|biaf is now known as myoung | 15:37 | |
| hwoarang | Hello. Is it possible to pass a vars file in a zuul job specification? i can only see that we can use 'vars' to pass individual variables but I'd like to pass an entire file of variables instead | 15:38 |
| mordred | mnaser: yes - what corvus said | 15:40 |
| mordred | corvus: do you want me to wait for an update from fbo_ on the execption handler patch before landing it? I was thikning of clicking +A on that patch as it stands and letting fbo_ do a followup - but we could also hold off for a complete patch if you prefer | 15:41 |
| corvus | mordred: incremental is fine | 15:43 |
| *** tflink has quit IRC | 15:45 | |
| *** robled has quit IRC | 15:46 | |
| *** tflink has joined #zuul | 15:46 | |
| *** robled has joined #zuul | 15:47 | |
| *** robled has quit IRC | 15:47 | |
| *** robled has joined #zuul | 15:47 | |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool master: Fail quickly for disabled provider pools https://review.openstack.org/573762 | 15:49 |
| *** robled has quit IRC | 15:50 | |
| *** robled has joined #zuul | 15:51 | |
| *** Guest14735 is now known as sdake | 16:41 | |
| *** gtema has quit IRC | 16:47 | |
| *** tflink has quit IRC | 16:51 | |
| *** tflink has joined #zuul | 16:52 | |
| *** jpena is now known as jpena|off | 16:53 | |
| *** pcaruana has quit IRC | 17:02 | |
| -openstackstatus- NOTICE: The Zuul scheduler was offline briefly to clean up from debugging a nodepool issue, so changes uploaded or approved between 16:50 and 17:15 UTC may need to be rechecked or reapproved (all already queued changes are in the process of being reenqueued now) | 17:25 | |
| *** electrofelix has quit IRC | 17:27 | |
| *** acozine1 has quit IRC | 17:27 | |
| *** myoung is now known as myoung|bbl | 17:36 | |
| *** gtema has joined #zuul | 17:46 | |
| *** hasharAway is now known as hashar | 18:31 | |
| *** acozine1 has joined #zuul | 18:36 | |
| *** elyezer_ has joined #zuul | 19:09 | |
| pabelanger | still working with zuul_filters, but ZUUL_REF doesn't seem to be set by default. Do we know why that is? | 19:29 |
| pabelanger | # intentionally omitted: | 19:30 |
| pabelanger | that explains it | 19:30 |
| pabelanger | do we know why? | 19:30 |
| pabelanger | https://review.openstack.org/512769/ | 19:30 |
| clarkb | yes you cant fetch a zuul ref from a servwr anymore | 19:30 |
| clarkb | instead its already in thr git repo for the job for you | 19:31 |
| pabelanger | right, in the case of RDO, they are using it to fetch logs from log server | 19:31 |
| pabelanger | I can update their JJB jobs to work around it | 19:31 |
| clarkb | the job uuid might bebetter for that? | 19:31 |
| pabelanger | maybe, but that might be a large refactor at this point | 19:32 |
| pabelanger | just easier to add support for {{ zuul.ref }} | 19:32 |
| *** myoung|bbl is now known as myoung | 19:36 | |
| *** gtema has quit IRC | 19:39 | |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool master: Fix 'satisfy' spelling errors https://review.openstack.org/573823 | 19:54 |
| Shrews | ^ that was just annoying me b/c i make that mistake constantly | 19:54 |
| Shrews | i am now satisified | 19:54 |
| tobiash | Shrews: at least it's consistent ;) | 20:01 |
| *** acozine1 has quit IRC | 20:03 | |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool master: Add release note about upgrading for multi-label https://review.openstack.org/573827 | 20:11 |
| Shrews | clarkb: fungi: fyi, the release note ^^ | 20:20 |
| Shrews | feel free to suggest different words | 20:20 |
| clarkb | will look shortly almost back home | 20:21 |
| Shrews | please don't irc and drive | 20:22 |
| Shrews | :) | 20:22 |
| Shrews | do portlanders drive, or is it mostly biking? | 20:23 |
| fungi | hipster pedicabs? | 20:24 |
| clarkb | My wife is driving today. Lots of biking but I'm no one of them | 20:31 |
| clarkb | Shrews: note lgtm | 20:37 |
| *** myoung is now known as myoung|off | 21:34 | |
| clarkb | zuulians do the depends on in a github pr have to go in the comments of the PR or in the commit message or does either work? | 22:02 |
| *** hashar has quit IRC | 22:04 | |
| clarkb | docs say it differs based on gerrit and github :/ | 22:05 |
| clarkb | so now I get to ask what the pull request description is, is that the first comment that is generated from the original commit message? | 22:06 |
| *** rlandy|rover has quit IRC | 22:27 | |
| *** harlowja has joined #zuul | 22:30 | |
| clarkb | anyone know why github can't use depends on in the commit message like gerrit? seems like thats a bit more user friendly since its the unit of work you are modifying | 22:40 |
| clarkb | I guess beacuse a pull request can have moer than one commit? | 22:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!