| *** Wei_Liu has quit IRC | 00:19 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: docs: add Project Testing Interface guide https://review.openstack.org/571420 | 00:21 |
|---|---|---|
| mnaser | i know not everyone is a fan of js reviews but | 00:24 |
| mnaser | https://review.openstack.org/#/q/topic:fix-status+project:openstack-infra/zuul | 00:24 |
| *** harlowja has quit IRC | 00:58 | |
| *** Wei_Liu has joined #zuul | 01:03 | |
| *** mordred has quit IRC | 02:41 | |
| *** Shrews has quit IRC | 02:45 | |
| *** Shrews has joined #zuul | 02:47 | |
| *** mordred has joined #zuul | 02:54 | |
| *** rlandy|rover|bbl is now known as rlandy|rover | 03:31 | |
| *** EmilienM_ has joined #zuul | 03:44 | |
| *** dtruong_ has quit IRC | 03:44 | |
| *** fdegir has quit IRC | 03:44 | |
| *** dvn has quit IRC | 03:44 | |
| *** jamielennox has quit IRC | 03:44 | |
| *** robled has quit IRC | 03:44 | |
| *** zxiiro has quit IRC | 03:44 | |
| *** jbryce has quit IRC | 03:44 | |
| *** Diabelko has quit IRC | 03:44 | |
| *** EmilienM has quit IRC | 03:44 | |
| *** tristanC has quit IRC | 03:44 | |
| *** EmilienM_ is now known as EmilienM | 03:44 | |
| *** EmilienM has quit IRC | 03:46 | |
| *** EmilienM has joined #zuul | 03:46 | |
| *** toabctl has quit IRC | 03:47 | |
| *** toabctl has joined #zuul | 03:49 | |
| *** rlandy|rover has quit IRC | 03:59 | |
| *** harlowja has joined #zuul | 04:17 | |
| *** harlowja has quit IRC | 04:20 | |
| *** bhavik1 has joined #zuul | 04:36 | |
| *** bhavik1 has quit IRC | 06:08 | |
| *** fdegir has joined #zuul | 06:22 | |
| *** hashar has joined #zuul | 06:30 | |
| *** sshnaidm_pto has joined #zuul | 06:35 | |
| *** pcaruana has joined #zuul | 06:40 | |
| *** jpena|off is now known as jpena | 07:04 | |
| *** gtema has joined #zuul | 07:16 | |
| *** D3VIATION has joined #zuul | 07:23 | |
| *** dtruong_ has joined #zuul | 07:47 | |
| *** dvn has joined #zuul | 07:47 | |
| *** jamielennox has joined #zuul | 07:47 | |
| *** zxiiro has joined #zuul | 07:47 | |
| *** robled has joined #zuul | 07:47 | |
| *** jbryce has joined #zuul | 07:47 | |
| *** Diabelko has joined #zuul | 07:47 | |
| *** tristanC has joined #zuul | 07:47 | |
| *** ssbarnea_ has joined #zuul | 07:56 | |
| *** sshnaidm_pto has quit IRC | 08:29 | |
| *** sshnaidm_pto has joined #zuul | 08:30 | |
| *** sshnaidm_pto has quit IRC | 08:36 | |
| *** electrofelix has joined #zuul | 08:37 | |
| *** sshnaidm_pto has joined #zuul | 08:51 | |
| *** sshnaidm_pto has quit IRC | 09:20 | |
| *** corvus has quit IRC | 09:33 | |
| *** corvus has joined #zuul | 09:34 | |
| *** D3VIATION has quit IRC | 09:53 | |
| *** jpena is now known as jpena|off | 09:58 | |
| *** ssbarnea_ has quit IRC | 10:25 | |
| *** sshnaidm_pto has joined #zuul | 11:26 | |
| *** GonZo2000 has joined #zuul | 11:31 | |
| *** GonZo2000 has quit IRC | 11:31 | |
| *** GonZo2000 has joined #zuul | 11:31 | |
| *** GonZo2000 has quit IRC | 11:39 | |
| *** GonZo2000 has joined #zuul | 11:42 | |
| *** GonZo2000 has quit IRC | 11:42 | |
| *** GonZo2000 has joined #zuul | 11:42 | |
| *** GonZo2000 has quit IRC | 12:01 | |
| *** D3VIATION has joined #zuul | 12:25 | |
| *** rlandy has joined #zuul | 12:36 | |
| *** D3VIATION has quit IRC | 12:47 | |
| *** rlandy is now known as rlandy|rover | 12:55 | |
| *** pcaruana has quit IRC | 13:15 | |
| *** Wei_Liu has quit IRC | 13:52 | |
| *** jimi|ansible has quit IRC | 13:55 | |
| *** Wei_Liu has joined #zuul | 13:57 | |
| *** pcaruana has joined #zuul | 14:10 | |
| *** acozine1 has joined #zuul | 14:27 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: WIP Make file matchers overridable https://review.openstack.org/571745 | 14:37 |
| *** pwhalen has quit IRC | 14:47 | |
| *** pwhalen has joined #zuul | 14:49 | |
| *** pwhalen has joined #zuul | 14:49 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Make file matchers overridable https://review.openstack.org/571745 | 16:00 |
| *** harlowja has joined #zuul | 16:11 | |
| *** rlandy|rover is now known as rlandy|rover|brb | 16:14 | |
| *** gtema has quit IRC | 16:29 | |
| *** gtema has joined #zuul | 16:30 | |
| *** EmilienM is now known as EvilienM | 16:40 | |
| *** sshnaidm_pto has quit IRC | 16:44 | |
| corvus | that ^ looks to be ready now too. that's a behavior change, so we'll probably want to call it version 3.1 | 16:49 |
| *** electrofelix has quit IRC | 16:55 | |
| *** rlandy|rover|brb is now known as rlandy|rover | 16:55 | |
| *** electrofelix has joined #zuul | 16:55 | |
| *** gtema has quit IRC | 16:59 | |
| *** electrofelix has quit IRC | 17:01 | |
| *** harlowja has quit IRC | 17:22 | |
| *** hashar is now known as hasharAway | 17:45 | |
| *** myoung is now known as myoung|bbl | 17:47 | |
| *** jimi|ansible has joined #zuul | 17:59 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Handle -/_ ambiguity in package names https://review.openstack.org/571005 | 18:11 |
| fungi | that ^ got pretty thoroughly cross-tested and doesn't look like it should introduce any regressions, but just a heads up that it's touching some python logic in the zuul-jobs stdlib | 18:11 |
| fungi | i _am_ around to help emergency revert if needed (i know, dicey changes late on a friday) | 18:12 |
| clarkb | I noted in the infra channel to that changes author that I think python pacakges are case insensitive as well so we may need to handle that corner case too | 18:13 |
| *** harlowja has joined #zuul | 18:14 | |
| fungi | yeah, shouldn't be hard to add since pkg_resources has a function for that (safe_name i think?) | 18:25 |
| fungi | and it's already importing from there | 18:25 |
| *** openstackgerrit has quit IRC | 19:04 | |
| clarkb | corvus: stack starting at https://review.openstack.org/#/c/563194/5 has +2s fopr 5 or six changes. Did you want to go ahead and approve them? I'm going to keep reviewing towards the end of that stack | 19:10 |
| clarkb | but first lunch | 19:12 |
| *** toabctl has quit IRC | 19:12 | |
| *** toabctl has joined #zuul | 19:16 | |
| corvus | clarkb: ah thanks, i'll go through those soon | 19:19 |
| corvus | oh, whoops, i said i was going to do the files/irrelevent-files change separately. i'll split it out. :) | 19:23 |
| *** myoung|bbl is now known as myoung | 19:30 | |
| *** openstackgerrit has joined #zuul | 19:42 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Make file matchers overridable https://review.openstack.org/571745 | 19:42 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Make files and irrelevant-files matchers exclusive https://review.openstack.org/571804 | 19:42 |
| *** jlvillal is now known as jlvacation | 19:43 | |
| clarkb | corvus: I'm reading https://review.openstack.org/#/c/571745/3/doc/source/user/config.rst and reconciling the removal of "matchers" against the commit message. I think at least part of the old matchers section is still accurate. You can't create a new variant with these matchers | 19:55 |
| clarkb | branches was updated with that info but not files and irrelevant files? I'm making sure I'm not missing something specific to the new expected behavior | 19:56 |
| corvus | clarkb: well, i mostly removed that because the 3 matchers aren't the same anymore | 19:56 |
| clarkb | right branches is different than the other two. I guess my question boils down to should we document that files and its negation don't make a new vairant | 19:56 |
| corvus | oh, hrm, i think our vocabulary may be getting squirrely. every job stanza is a variant. it's just that files used to limit the applicability of that variant, but now it means do-or-don't-run-this-job | 19:59 |
| clarkb | gotcha | 19:59 |
| clarkb | corvus: I guess that is why parent-override-job defined twice with two different files: entries is valid | 20:00 |
| clarkb | ? | 20:01 |
| corvus | clarkb: exactly. you used to be guaranteed only to get one of those. now you'll always get both, and the second one wins. | 20:02 |
| *** pcaruana has quit IRC | 20:03 | |
| corvus | (essentially, that was a test of the ability to alter a job configuration by using a file variant, and that's the feature we lose with that change, so that's why that test changes) | 20:03 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Make file matchers overridable https://review.openstack.org/571745 | 20:15 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Make files and irrelevant-files matchers exclusive https://review.openstack.org/571804 | 20:15 |
| *** hasharAway is now known as hashar | 20:18 | |
| clarkb | question: is the migrate tool intended to be "supported" | 20:30 |
| clarkb | I see pabelanger is making updates to it. | 20:30 |
| clarkb | (I just worry about making changes to it as it doesn't have tests iirc) | 20:30 |
| corvus | that's a good question; i was going to suggest we remove it.... but if it's still useful to someone and it's getting better(?) maybe we keep it? | 20:31 |
| clarkb | iirc we had a test that ran against infras config for it, but I don't think we still ahve that because infras config is transitioned | 20:31 |
| corvus | i feel like it ended up being the "openstack migration tool", so from that pov, if it works for whoever (pabelanger in this case) is making the change, it's probably no worse :) | 20:32 |
| corvus | (by the time we finished, it had a heap of assumptions built into it) | 20:32 |
| clarkb | ya | 20:32 |
| clarkb | maybe if we see continued use for it we should resurrect a test of some sort for it | 20:32 |
| clarkb | corvus: I'm finding a lot of changes with many +2's in zuul. are there any I should hold off an approving if I review them and am happy with them? | 20:35 |
| *** yolanda has quit IRC | 20:35 | |
| clarkb | https://review.openstack.org/#/c/546698/ for example | 20:35 |
| clarkb | (then maybe next week we update the running version in openstack and cut a release with your behavior change too) | 20:35 |
| corvus | clarkb: i'm behind on reviews due to summit prep, so hard to say. i'll go through them right now though if you want to leave any non-trival ones for me to +W. i wouldn't mind catching up :) | 20:41 |
| clarkb | the above one is potentially non trivial since it interacts with zuul. Then the github stack I linked earlier. I'm currently lookin at https://review.openstack.org/#/c/567226/1/zuul/merger/merger.py and trying to figure out if the git cleanup operation needs a lock | 20:43 |
| clarkb | I think the merger gearman tasks are serialized | 20:43 |
| clarkb | but not sure if the executor mergers are | 20:44 |
| clarkb | oh the "root" there is job specific so should be fine | 20:44 |
| clarkb | hrm no it defaults to merge_root = /var/lib/zuul/executor-git | 20:45 |
| clarkb | executor server has a merger_lock perfect | 20:49 |
| clarkb | tobiash: I left a comment on https://review.openstack.org/#/c/567227/1 about handling that general class of problem mroe robustly. Let me know what you think | 20:58 |
| corvus | clarkb: left a -1 on https://review.openstack.org/535680 - what do you think? | 21:03 |
| clarkb | corvus: ++ | 21:04 |
| openstackgerrit | Merged openstack-infra/zuul master: Test more action modules https://review.openstack.org/567007 | 21:05 |
| clarkb | the ansible 2.5 plunge is probably the other big thing we need to do soon | 21:08 |
| openstackgerrit | Merged openstack-infra/zuul master: Add role information to task in zuul_json callback https://review.openstack.org/559998 | 21:08 |
| * clarkb will defer thinking on that until next week | 21:08 | |
| openstackgerrit | Merged openstack-infra/zuul master: Support databases on other hosts during tests https://review.openstack.org/560127 | 21:08 |
| *** hashar is now known as hasharZzz | 21:09 | |
| clarkb | ianws corvus: https://review.openstack.org/#/c/568195/4/zuul/web/__init__.py I think that is superceded by the cherrypy work, can we go ahead and abandon that change? | 21:09 |
| clarkb | (I'm assuming we are moving forward with cherrypy based on it working at this point) | 21:09 |
| corvus | yeah, i think it's ready to go and we should do it | 21:09 |
| openstackgerrit | Merged openstack-infra/zuul master: Only emit parent-change-enqueued if needed https://review.openstack.org/563194 | 21:10 |
| openstackgerrit | Merged openstack-infra/zuul master: Gracefully handle corrupt local git repositories https://review.openstack.org/567226 | 21:10 |
| *** acozine1 has quit IRC | 21:16 | |
| pabelanger | corvus: clarkb: Can understand if we don't want to support it in zuul, I'm only pushing up changes it case anybody else wants to use it. But given the self imported deadline to get rdoproject on zuulv3 ASAP, it is a handy tool. But openstack specific for sure. | 21:16 |
| clarkb | pabelanger: I'm ok with it, mostly just worried about lack of testing if we do support it since the testing was openstack infra specific and now no longer exists aiui | 21:17 |
| *** EvilienM has quit IRC | 21:18 | |
| *** EmilienM has joined #zuul | 21:18 | |
| *** EmilienM has joined #zuul | 21:18 | |
| *** EmilienM is now known as EvilienM | 21:19 | |
| corvus | i'm +2 on the migrate changes; clarkb are you going to review them? | 21:22 |
| clarkb | corvus: ya I'll review them | 21:22 |
| openstackgerrit | Merged openstack-infra/zuul-website master: Add a "zuul: gated" status badge https://review.openstack.org/568975 | 21:23 |
| pabelanger | clarkb: agree about testing, I can see about reverting https://git.zuul-ci.org/cgit/zuul/commit/tools?id=badc54be7eef6d0b244e4cb3881f651f64100c10 to see how testing works | 21:24 |
| pabelanger | or work to iterate on it | 21:25 |
| corvus | SpamapS: https://review.openstack.org/571342 should unblock your github status work | 21:25 |
| corvus | clarkb: looks like the +W on cherrypy is yours :) | 21:26 |
| clarkb | corvus: I'll review that after the migrate cahnges I guess | 21:27 |
| SpamapS | oh neat! | 21:35 |
| openstackgerrit | Merged openstack-infra/zuul master: Remove unnecessary injections https://review.openstack.org/571341 | 21:42 |
| openstackgerrit | Merged openstack-infra/zuul master: Support merged as requirement in github driver https://review.openstack.org/568488 | 21:42 |
| openstackgerrit | Merged openstack-infra/zuul master: Allow templates to be optional for zuul-migrate https://review.openstack.org/570979 | 21:42 |
| clarkb | the two prereq changes to cherrypy have been approved | 21:46 |
| openstackgerrit | Merged openstack-infra/zuul master: Allow for projects only names in zuul-migrate https://review.openstack.org/570980 | 21:47 |
| openstackgerrit | Merged openstack-infra/zuul master: Add the ability for a user to skip macros https://review.openstack.org/571287 | 21:47 |
| clarkb | corvus: what is the purpose of the save params tool? | 22:07 |
| clarkb | that a rest api thing because the api is path based on query string based? | 22:07 |
| corvus | clarkb: yeah, if you use the routes handler, it will pass the path params to the function, but cherrypy will natively do the same thing with get/post params. i didn't want someone to be able to do '/tenant/foo/something?tenant=bar' and override the path param with the query param. | 22:12 |
| corvus | clarkb: i think if we drop routes and go with traversal along with some special handler, we can avoid that in the future. but i wanted to use routes for the first change at least to keep the delta smaller. | 22:13 |
| openstackgerrit | Merged openstack-infra/zuul master: Move SQL web handler to driver https://review.openstack.org/568028 | 22:15 |
| clarkb | corvus: and cherrypy's engine handles each request in its own execution context so we don't ahve to worry about concurrency ourselves right? | 22:16 |
| openstackgerrit | Merged openstack-infra/zuul master: Add never_capture test decorator https://review.openstack.org/569515 | 22:18 |
| corvus | clarkb: yeah, the default server (which we're using) uses thread pools. it's called cheroot: https://github.com/cherrypy/cheroot | 22:18 |
| corvus | cherrypy can be used with other wsgi environments too | 22:18 |
| clarkb | https://chromium.googlesource.com/external/googleappengine/python/+/1e5241cb0e48d0cb192fa944f2e218c4a18b244e/lib/cherrypy/cherrypy/__init__.py?autodive=0%2F#171 | 22:22 |
| corvus | clarkb: probably the only thing to be aware of there is that cherrypy uses thread-local objects for requests. so when a method access 'cherrypy.request' it's accessing "the current request being handled by this thread" | 22:22 |
| clarkb | :) that was what I was just looking aty | 22:22 |
| corvus | clarkb: that's in contrast to other systems where the request is passed in to handlers as an argument | 22:22 |
| corvus | same thing for cherrypy.response | 22:22 |
| clarkb | right | 22:22 |
| clarkb | its "global" but not really | 22:22 |
| clarkb | I guess that makes the code look nice | 22:22 |
| corvus | yeah, i think the idea is that the function arguments and return values are then literally just the input/output from the server-side methods. | 22:24 |
| clarkb | corvus: https://review.openstack.org/#/c/568335/20 question on that. My reading of the code is that we are probvably ok but you may be more familiar with it | 22:35 |
| corvus | clarkb: we should be fine because in web/__init__.py we use the incremental decoder to make sure that we only send valid utf8 chunks over the websocket. so the ws client should only receive valid chunks. | 22:38 |
| *** rlandy|rover has quit IRC | 22:39 | |
| corvus | clarkb: i believe that's the equivalent code to what was there before (ie, aiohttp's client was giving us unicode strings, but ws4py is giving us bytes) | 22:39 |
| clarkb | cool. I think if recieve_message could get half a message we would have to worry about it but it claims to only be called on completely messages at least | 22:40 |
| clarkb | corvus: one last question before I approve. the info parameter to zuulweb seems mostly unused? | 22:43 |
| clarkb | corvus: state to clean out in a followup? | 22:43 |
| corvus | should still be used -- ZuulWebAPI.info() uses it | 22:44 |
| corvus | (via a reference it holds to the zuulweb object) | 22:44 |
| clarkb | corvus: ya that part is fine btu we also pass in info as a distinct reference then don't appear to use it | 22:45 |
| clarkb | er to the connection objects not zuulweb | 22:45 |
| clarkb | sorry half of it is unused the other half is used | 22:45 |
| clarkb | corvus: https://review.openstack.org/#/c/567959/23/zuul/web/__init__.py line 343 | 22:46 |
| clarkb | I've gone ahead and approved the cherrypy change | 22:48 |
| clarkb | I think ^ can be cleaned up in a followup if it does need cleaning up | 22:48 |
| * clarkb writes that patch may be easiest to explain that way | 22:51 | |
| *** D3VIATION has joined #zuul | 22:53 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/zuul master: Cleanup unused connection.getWebController info param https://review.openstack.org/571901 | 22:53 |
| clarkb | corvus: ^ that | 22:53 |
| corvus | clarkb: yeah, i think you hit something with rough edges. we used to set capabilities.job_history inside of the of the sql driver if there was a sql connection. but i dropped that, and there's no tests for it, so i didn't notice it. | 22:54 |
| corvus | i don't think anything actually used it yet either | 22:54 |
| clarkb | as you point out it is accessible from the also passed in ZuulWeb object so I don't think it is necessary even if you want the data later | 22:54 |
| corvus | clarkb: yeah. i think your change is a good next step. i don't think the job_history is a big issue; i'm not even sure the old code was quite correct. if/when we want to make the web interface not have a builds tab if you don't have the sql reporter, we'll need to fix it. but it should be easy to do. no more difficult than under aiohttp. | 22:58 |
| corvus | and when we do, we'll add a test :) | 22:59 |
| corvus | because, as i've helpfully demonstrated, if it's not tested, i will break it | 22:59 |
| clarkb | we need that put on a stone somewhere | 23:00 |
| openstackgerrit | Merged openstack-infra/zuul master: Replace use of aiohttp with cherrypy https://review.openstack.org/567959 | 23:02 |
| openstackgerrit | Merged openstack-infra/zuul master: Convert streaming unit test to ws4py and remove aiohttp https://review.openstack.org/568335 | 23:02 |
| clarkb | corvus: you missed https://review.openstack.org/#/c/563297/7 and its children. I wasn't going to approve them myself as I'm trying to avoid needing to review them :P | 23:04 |
| clarkb | (you have alredy +2'd but not approved) | 23:05 |
| openstackgerrit | Merged openstack-infra/zuul master: Use iterate timeout in streaming tests https://review.openstack.org/571498 | 23:10 |
| openstackgerrit | Merged openstack-infra/zuul master: Use ZuulWebFixture in tests https://review.openstack.org/571499 | 23:10 |
| *** harlowja has quit IRC | 23:18 | |
| fungi | just a general heads up since people running zuulv3/nodepool are almost certain to have a zk cluster... CVE-2018-8012 means that you should really, really be using some sort of firewall to restrict zk communication source addresses | 23:19 |
| fungi | https://zookeeper.apache.org/security.html#CVE-2018-8012 | 23:20 |
| corvus | clarkb: thx | 23:22 |
| *** hasharZzz has quit IRC | 23:27 | |
| openstackgerrit | Merged openstack-infra/zuul master: Extend github testing using app auth https://review.openstack.org/563297 | 23:42 |
| openstackgerrit | Merged openstack-infra/zuul master: Test parent-change-enqueued with github https://review.openstack.org/563242 | 23:42 |
| *** jimi|ansible has quit IRC | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!