Friday, 2018-05-18

*** rlandy has quit IRC00:35
SpamapSderp00:41
SpamapSderp a derp00:41
SpamapSI firewalled off the zuul port00:42
SpamapS;)00:42
*** swest has joined #zuul04:49
openstackgerritTobias Henkel proposed openstack-infra/nodepool master: Log connection port in static driver on timeout  https://review.openstack.org/56933405:59
*** sshnaidm|bbl is now known as sshnaidm|off06:23
openstackgerritTobias Henkel proposed openstack-infra/nodepool master: Correctly use connection-port in static driver  https://review.openstack.org/56933906:23
*** johanssone has joined #zuul06:28
*** threestrands has quit IRC07:17
*** toabctl has quit IRC07:26
*** gtema has joined #zuul07:28
*** jpena|off is now known as jpena07:58
*** gtema has quit IRC07:59
*** gtema has joined #zuul08:00
*** sshnaidm|off has quit IRC10:41
*** toabctl has joined #zuul11:06
*** sshnaidm|off has joined #zuul11:12
*** jpena is now known as jpena|lunch11:49
*** EmilienM is now known as EvilienM12:21
*** rlandy has joined #zuul12:35
*** jpena|lunch is now known as jpena12:44
*** dkranz has joined #zuul13:02
*** myoung|ruck|off is now known as myoung|ruck13:37
mordredSpamapS: those are great stats13:42
*** acozine1 has joined #zuul13:57
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Replace use of aiohttp with cherrypy  https://review.openstack.org/56795914:30
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Convert streaming unit test to ws4py and remove aiohttp  https://review.openstack.org/56833514:30
openstackgerritJames E. Blair proposed openstack-infra/zuul master: DNM: disable test log capture  https://review.openstack.org/56942914:30
openstackgerritMerged openstack-infra/zuul master: Fix race in test_reconfigure_window_fixed  https://review.openstack.org/56912914:58
openstackgerritMerged openstack-infra/zuul master: Revert "Revert "Switch to stestr""  https://review.openstack.org/56894915:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Replace use of aiohttp with cherrypy  https://review.openstack.org/56795915:39
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Convert streaming unit test to ws4py and remove aiohttp  https://review.openstack.org/56833515:39
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Simplify driver API  https://review.openstack.org/56870415:43
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add a "Get Started" button  https://review.openstack.org/56945015:46
corvusfdegir: i was just looking at 565075 and i see the additional bits for centos7 services, but i don't see any updates to the introductory text indicating that the instructions work for centos7 as well as fedora16:00
corvusfdegir: is there another change out there, or do we need to add that still?16:00
corvusfdegir: ah!  it's https://review.openstack.org/564948 i think16:01
fdegircorvus: yes, there are 3 changes, each updating different sections16:01
fdegirhttps://review.openstack.org/#/c/564948/16:02
fdegirhttps://review.openstack.org/#/c/564950/16:02
fdegirhttps://review.openstack.org/#/c/565075/16:02
corvusfdegir: cool, i'm caught up now :)  in the future, it might make sense to stack changes like that on each other.  if you make 3 commits in a row, then run 'git-review' you'll get 3 changes in gerrit, but with a dependency relationship.  that makes it easy to see the final results of all three in the documentation preview, and helps reviewers find the changes.16:03
fdegircorvus: yes - the next ones for ubuntu will be like that16:04
fdegircorvus: for this one, i did it this way on purpose since the structure was heavily impacted and didn't want to have conflicts16:04
corvusok i've approved all 316:04
fdegirthx a lot16:05
fdegircorvus: this one is a bit tricky16:06
fdegircorvus: https://review.openstack.org/#/c/565078/16:06
fdegircorvus: i wanted to fix it properly as Tobias suggested but lack time recently16:06
corvusyeah, we should clean that up soon :)16:07
fdegircorvus: but it would be good to fix service fileto reduce the confusion until the proper fix is there16:07
corvusfdegir: i worry a bit about that since we can't make sure service files are updated; it'd be better to try to fix that properly real quick16:08
openstackgerritMerged openstack-infra/zuul master: Add additional steps for configuring Zuul services on CentOS 7  https://review.openstack.org/56507516:08
fdegircorvus: similar thing is there for nodepool as well - the service file is correct but it lacks command socket support16:09
openstackgerritMerged openstack-infra/zuul master: Add additional steps for configuring Nodepool service on CentOS 7  https://review.openstack.org/56495016:23
SpamapSmordred: heh, we also calculated how much we'd have spent if we had run all of this in AWS...16:24
SpamapSbut that's not really fair16:25
SpamapSbecause we'd probably not do min-ready's ;)16:25
SpamapSand might even use spot instances16:25
corvusSpamapS: the builds db doesn't include time that nodes spend in the ready state, that should be pretty close to actual usage16:26
SpamapScorvus: indeed, I wonder if I could use the nodepool launcher logs16:27
SpamapSBut really, the seconds running jobs is probably within a few percentage points of accurate if we did fully on-demand nodes.16:27
*** electrofelix has quit IRC16:27
clarkbat one time I did math that we were saving over a day of cpu time per day simply by removing the default grub timeout on our images16:28
openstackgerritMerged openstack-infra/zuul master: Add CentOS 7 environment setup instructions  https://review.openstack.org/56494816:29
clarkb(so that pre job time can add up)16:29
SpamapSHah good point16:29
SpamapSwe have a horrible image16:29
SpamapSthat does evil ssh things for the first 60s it is booted16:30
SpamapSso I actually had to write a pre-run that checks if the box has been up for at least 120s and if not, waits that long.16:30
*** dkranz has quit IRC16:57
*** acozine1 has quit IRC16:58
*** dkranz has joined #zuul16:58
*** gtema has quit IRC17:07
*** jpena is now known as jpena|off17:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add more explanatory text to zuul-from-scratch  https://review.openstack.org/56948218:04
corvusShrews: we should figure out how to continue the zfs document.  the next parts of the tutorial are going to be writing a bunch of changes and pushing them up to gerrit or github18:05
corvusShrews: (the github branch already goes further than the gerrit branch in that it sets up a pipeline and exercises it)18:06
corvusShrews: fundamentally, it should be the same process for both, so we probably just need to figure out how to describe actions like "push up a gerrit change / open a github pull request" in neutral terms?18:06
corvusShrews: or maybe mechanically duplicate the content and switch out those terms.18:07
Shrewscorvus: uh, ok. honestly, i haven't put any more thought into that doc. i'm sure it can be improved/expanded18:09
Shrewsglad it's getting some attention from contributors  :)18:10
Shrewsit *is* pretty bare bones, as you point out18:11
corvusyeah, we should honestly probably make it deeper before we make it any broader18:12
corvuswe're about to have a document that tells you how to set up zuul 6 different ways, none of which will run your tests.18:12
Shrewsoh, um, erm...18:13
Shrewsi wanna say that's not unbad18:13
Shrewsdefinitely should expand on the configuration portion18:14
corvusyeah, next we need to walk folks through creating a base job (or using what's in the zuul-base-jobs repo), then constructing a simple job on top of that which actually runs a command.18:15
Shrewswait... that sounds familiar18:16
Shrewshttps://review.openstack.org/49387318:17
corvusShrews: it's going to take a bit more than that to finish, but i'd love your continued assistance.18:22
tobiashwe're planning to write a github zuul settings linter github app for our users18:23
corvustobiash: why not use zuul itself?18:23
tobiashthat will on request check repo and branch protection settings for common pitfalls18:24
tobiashcorvus: would that make sense?18:24
tobiashour idea is that it would be triggered by a command like '/support' and then add a comment with a checklist18:25
tobiashso to do that in zuul itself I think this would be a separate non-pipeline related functionality of the github driver18:26
corvustobiash: in openstack-infra, we have linter jobs which run changes to our project-config repo when people add new projects.  you might consider doing something like that.18:26
corvuscorrection: ...which run *on* changes...18:26
tobiashyeah so we have something similar for our tenant config18:27
tobiashbut what I often get as a support question from users is 'why do I get merge failed after a successful gate'18:27
tobiashor 'why do I get a gate loop'18:27
Shrewscorvus: as long as you can help me define the end product you want delivered, glad to help however i can18:28
tobiashand the branch protection settings are not tracked in any config management18:28
tobiashso our idea was a more or less interactive support bot (which could be zuul itself or a separate app)18:29
corvusShrews: i will take you up on that post-summit :)18:30
tobiashso using a job for this would feel a bit odd because we would have to add it to every project in every tenant into a special support pipeline18:32
corvustobiash: is this something that needs to be checked only when you add a new project, or more often than that?18:32
tobiashcorvus: more often (as users add/remove branches and branch protection via github ui)18:33
tobiashand also preferably directly on request (user see's something odd, adds '/analize' comment and gets a linting report of what could be wrong)18:34
corvustobiash: the project-regex feature could add the support pipeline :)18:35
tobiashYes, but in a multi tenant env that feels clumsy18:36
tobiashSo our idea was a simple github app based on probot (and open source it if it works out)18:36
corvustobiash: you can put the configuration for that in its own repo, and then add that repo to every tenant.  so the tenants don't even have to see it.18:37
corvus(or, if you already have a repo for global configuration which applies to all tenants, you can add it there)18:37
corvustobiash: obviously it's your decision -- but "run an action and leave feedback based on a github pull request event" should be well within zuul's capabalities -- i just want to make sure we're not missing anything :)18:39
*** elyezer has quit IRC18:40
tobiashcorvus: thanks for the input, we will think deeper about that18:42
*** elyezer has joined #zuul18:43
tobiashI think we would need the comment text in the zuul vars so we can support several commands without having 50 pipelines18:43
*** _ari_ has quit IRC18:46
*** _ari_ has joined #zuul18:46
corvustobiash: good point; the idea of selecting jobs based on comment text (or other trigger characteristics) may be relevant too18:47
corvuseither, or both, of those may make that approach more feasible18:47
tobiashIndeed that even was a customer request I got a few days ago18:47
corvus(in openstack, we mostly suggest folks just dynamically change the in-repo config to run whatever jobs they want, in the case where they're trying to work through a specific issue)18:48
corvusotherwise, that needs a bit more thought, because you obviously can't do something like that in a gating configuration18:49
corvusputting the text in a zuul var seems pretty straightforward though :)18:49
tobiashthe user's use case was that there is a very expensive test (too big for check and gate) that should only run if the user wants it to run based on expert knowledge of the risks of a change18:51
tobiashSuch jobs would normally run nightly18:51
corvustobiash: ah, in openstack we use an 'experimental' pipeline for that18:52
tobiashMy advice was a comment triggered experimenal pipeline18:52
tobiash;)18:52
corvusstill, selecting jobs by comment in an experimental pipeline would be nicer, and safe.18:53
corvusso maybe it's a matter of saying "this pipeline allows job selection" and setting that on experimental, but not check/gate.18:53
tobiashInteresting idea18:55
*** xhku_ has quit IRC19:43
*** fbouliane has joined #zuul19:45
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Replace use of aiohttp with cherrypy  https://review.openstack.org/56795920:25
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Convert streaming unit test to ws4py and remove aiohttp  https://review.openstack.org/56833520:25
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add never_capture test decorator  https://review.openstack.org/56951520:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add never_capture test decorator  https://review.openstack.org/56951520:46
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Replace use of aiohttp with cherrypy  https://review.openstack.org/56795920:46
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Convert streaming unit test to ws4py and remove aiohttp  https://review.openstack.org/56833520:46
corvusthe never_capture decorator may as well be named never_fail_now_that_i_can_see_your_output20:46
clarkbheisenbugs?20:48
corvusya20:51
corvusi ran it many hundreds of times locally with no failure :(20:52
SpamapSreally toob ad that aiohttp didn't work out :-P21:15
SpamapSseemed nice.21:16
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add never_capture test decorator  https://review.openstack.org/56951522:44
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Replace use of aiohttp with cherrypy  https://review.openstack.org/56795922:44
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Convert streaming unit test to ws4py and remove aiohttp  https://review.openstack.org/56833522:44
*** xinliang has quit IRC23:08
*** xinliang has joined #zuul23:20
*** rlandy has quit IRC23:34

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!