Thursday, 2018-05-10

*** swest has quit IRC01:55
*** swest has joined #zuul02:11
*** bstinson has quit IRC05:01
*** bstinson has joined #zuul05:18
*** gtema has joined #zuul05:45
*** jhesketh has quit IRC05:58
*** xinliang has joined #zuul06:03
*** gtema has quit IRC06:37
*** pcaruana has joined #zuul06:51
*** threestrands_ has quit IRC06:58
*** jpena|off is now known as jpena07:40
*** sshnaidm|off is now known as sshnaidm|rover08:03
*** toabctl has quit IRC08:04
*** toabctl has joined #zuul08:08
*** ssbarnea_ has joined #zuul08:20
openstackgerritStephen Finucane proposed openstack-infra/zuul-jobs master: Default warning-is-error to True for non-legacy Sphinx projects  https://review.openstack.org/55934808:24
*** jhesketh has joined #zuul08:29
*** jhesketh has quit IRC08:47
*** jhesketh has joined #zuul09:06
*** jpena is now known as jpena|lunch12:06
*** rlandy has joined #zuul12:33
*** pcaruana|afk| has joined #zuul13:03
*** NotPcaruana has joined #zuul13:04
*** dkranz has joined #zuul13:28
*** NotPcaruana has quit IRC13:34
*** pcaruana|afk| has quit IRC13:34
*** jpena|lunch is now known as jpena13:47
*** dmellado has joined #zuul13:47
openstackgerritMerged openstack-infra/zuul master: Improve logging around project branches  https://review.openstack.org/56712814:32
*** mario-goulart has quit IRC15:29
*** ssbarnea_ has quit IRC15:35
*** pcaruana has quit IRC15:52
clarkbcorvus: any reason to not approve https://review.openstack.org/#/c/566186/2 ? I just approved the aprent change which set up opensans font15:58
corvusclarkb: nope i think we can go for it15:59
openstackgerritMerged openstack-infra/zuul-website master: Switch to Open Sans font  https://review.openstack.org/56618516:01
*** acozine1 has joined #zuul16:01
*** ssbarnea_ has joined #zuul16:01
openstackgerritMerged openstack-infra/zuul-website master: Change tagline to dark blue  https://review.openstack.org/56618616:03
openstackgerritMerged openstack-infra/zuul-website master: Update tagline  https://review.openstack.org/56729516:03
corvushttps://zuul-ci.org/ is up to date16:20
pabelangernice16:26
pabelangerlooking at the following, it doesn't seem clear to me:16:26
pabelangerUse the same Ansible to deploy your system and run your tests.16:26
pabelangershould that maybe be Use the same Ansible playbooks...16:26
corvusperhaps?16:26
pabelangeror is it the same version of ansible16:28
openstackgerritPaul Belanger proposed openstack-infra/zuul-website master: Clarify usage of Ansible for users  https://review.openstack.org/56764016:32
*** pcaruana has joined #zuul16:36
*** pcaruana has quit IRC16:44
*** sshnaidm|rover is now known as sshnaidm|off16:52
mordredpabelanger: I just rebased https://review.openstack.org/#/c/564507/ so it picks up the fixes for the pep8 mess ... you wanna +A it again real quick?17:10
*** ssbarnea_ has quit IRC17:17
pabelangergreat17:19
openstackgerritPaul Belanger proposed openstack-infra/zuul-website master: Clarify usage of Ansible for users  https://review.openstack.org/56764017:21
*** ssbarnea_ has joined #zuul17:25
*** ssbarnea_ has quit IRC17:28
pabelangerI think we might want to consider a 3.0.3 release of zuul to pick up: http://git.openstack.org/cgit/openstack-infra/zuul/commit/?id=4b1d92d59bb0848e3aacc748147f46482ad3610017:55
pabelangerright now, zuul from pypi can't be installed on ubuntu-xenial because of it17:55
clarkbI was thinking about that and should we use env markers to allow newer asyncio libs on 3.6?17:57
clarkbwe have tests for 3.6 now right?17:57
pabelangerclarkb: yah, I think that's what was done17:59
pabelangerasync-timeout<3.0.0;python_version<='3.5.2'17:59
clarkbah cool I thought one of the pins was just a < and called it good17:59
pabelangeraiohttp maybe?18:00
clarkbpabelanger: ya aiohttp<3.0.018:00
clarkbit should have the same env marker likely18:00
pabelangerk, let me fix quickly18:00
clarkbunless it doesn't work at all18:00
pabelangernot sure18:00
clarkbbut testing should cover that? there are zuul-web tests at least18:00
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Only cap aiohttp for python 3.5.2 and below  https://review.openstack.org/56766318:03
pabelangerclarkb: looks like we need a +3 on https://review.openstack.org/565881/ for py36 jobs18:03
*** ssbarnea_ has joined #zuul18:03
*** electrofelix has quit IRC18:04
clarkbthe zuul docs have fedora directions which is 3.6 too right? So probably a good thing to add 3.6 testing18:04
clarkbcorvus: ^ do you want to rview that at all?18:04
clarkbpabelanger: we can probably remove the env marker from uvloop;python_version>='3.5' too if we want to clean that up (since I think 3.5 is required anyways)18:07
pabelangerclarkb: sure18:07
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Remove env marker from uvloop  https://review.openstack.org/56766518:08
fungii'm increasingly happy with the https://zuul-ci.org/ site18:14
Shrewsi don't think it uses <blink> nearly enough18:15
clarkbpabelanger: on 567663 I think you need a second aiohttp for >3.5.218:15
fungiShrews: i was also thinking we needed some flaming text and spinning skulls. also where is the barbed wire horizontal rule?18:16
Shrewsfungi: ikr??18:16
pabelangerclarkb: a 2nd entry?18:16
* fungi briefly wonders if geocities still exists, then decides it's better not to check18:17
clarkbpabelanger: ya as is you won't install aiohttp on python 3.6 for example18:17
pabelangerclarkb: wouldn't that also be an issue for async-timeout and yarl?18:17
clarkbpabelanger: no they are aiohttp dependencies aiui so we only pull them in transitively18:17
*** ssbarnea_ has quit IRC18:17
clarkbwhereas we directly use aiohttp18:17
pabelangerclarkb: k, so can I just do aiohttp or do I need to also include env filter18:18
clarkbpabelanger: you need an env filter I think otherwise it will apply to <= 3.5.2 as well18:18
pabelangerokay18:19
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Only cap aiohttp for python 3.5.2 and below  https://review.openstack.org/56766318:23
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Remove env marker from uvloop  https://review.openstack.org/56766518:23
pabelangerclarkb: thanks, haven't really used markers much before18:23
clarkbcool, I think if we can get the 3.6 jobs in then we recheck and go fro mthere18:25
*** jpena is now known as jpena|off18:25
clarkbI don't want to add new jobs to zuul without corvus input though (which is probably why that changes wasn't approved by other reviewers)18:25
clarkbthat said I do think it is a good idea here espceially since our how to docs have people using 3.618:25
corvusi had a previous +W on it, i just reapplied it18:25
clarkbah cool18:25
corvusclarkb, pabelanger: i was going to suggest we release what openstack is running today, but maybe we should cheat and release current master to get the requirements change too?18:26
corvusthe additional changes in master that we aren't running are *probably* okay :)18:26
corvusthe only thing that actually changes anything in zuul is the start/end timestamp in zuul_json change18:27
clarkb7816dfc3aefe6958dcbc00c3d5e99b2a8b346d57 is what openstack is running right?18:27
corvusyep18:27
clarkbthen ya the callback stuff is all I would be concerned about18:27
clarkband its just adding a new field to the results dicts? that seems relatively safe. Has a test too18:30
pabelangerwfm18:30
corvusso how about i tag 1e3e5d33fb140d5dc993eeed6f8b13248105647a as 3.0.3 ?18:35
corvusor do we need any more requirements changes in?18:35
pabelangerI think they could wait, we are just uncapping and cleaning up env markers18:38
pabelanger1e3e5d33fb140d5dc993eeed6f8b13248105647a +118:38
clarkbwfm18:45
*** sshnaidm|off has quit IRC18:47
openstackgerritMerged openstack-infra/zuul master: Add tox-py36 jobs  https://review.openstack.org/56588118:49
fungilooks like a good 3.0.3 candidate to me19:09
fungi7816dfc has been running in production for us ~36 hours, looks like19:10
fungioh, wait, you said 1e3e5d319:11
fungi1b747ca6 is now master branch tip19:12
dmsimardhuh, I'm seeing results from git.zuul-ci.org on google searches.19:12
fungidmsimard: is that bad?19:12
dmsimardNo, I suppose I just don't remember seeing results from git.o.o19:13
fungiis it returning hits for non-zuul repos or anything?19:13
dmsimardnot that I can see, this one is zuul itself19:14
clarkbI noticed recently that google is returning hits for gerrit changes too (not zuul specific)19:14
fungiso after 7816dfc3, 1e3e5d33 seems to add its own py36 testing, the async-timeout pin, a logo for docs, start/end timestamp in the json callback, skips attempting python3-devel install on centos, and adds systemd drop-in files for centos19:16
fungithose seem fairly non-intrusive19:16
fungino, wait, the tox-py36 jobs come even later in 1b747ca619:16
fungialong with logging improvements related to project branches19:16
fungiso 1b747ca6 seems at least as good a 3.0.3 release candidate to me19:17
corvusyeah, just didn't want to include more un-beta-tested code changes than necessary19:47
*** sshnaidm|off has joined #zuul19:49
corvuspushed 3.0.320:21
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add favicon  https://review.openstack.org/56768520:30
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: DNM: test favicon  https://review.openstack.org/56768620:30
*** dkranz has quit IRC20:34
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add favicon  https://review.openstack.org/56768520:39
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: DNM: test favicon  https://review.openstack.org/56768620:39
*** sc68cal_ is now known as sc68cal20:44
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: DNM: test favicon  https://review.openstack.org/56768620:51
*** acozine1 has quit IRC21:20
ianwwhat do you think the chances are that it's something to do with using with_items: that the logging on the *second* an subsequent script calls in ...21:23
ianwhttp://logs.openstack.org/79/566779/38/check/dib-functests-python3/e164153/job-output.txt.gz#_2018-05-10_06_13_30_26043821:23
ianwgoes missing21:23
ianwit's "run dib functional tests" in https://review.openstack.org/#/c/566779/38/roles/dib-functests/tasks/main.yaml21:24
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add favicon  https://review.openstack.org/56768521:25
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: DNM: test favicon  https://review.openstack.org/56768621:25
corvusianw: a with_items + zuul_console problem seems likely.  the good news is that we can actually regression test that now with the zuul-remote tests21:26
ianwcorvus: ok, i'll dig a little deeper.  i'm wondering if the essentially "1> >(logfilter.py)" we do in dib is part of it21:29
ianwbut i'll make up some test scripts and see what goes wrong21:30
*** dkranz has joined #zuul21:40
clarkbcorvus: that latest test worked on firefox21:50
corvusclarkb: ah, so it must have been grabbing one of the other items21:52
corvusi do think i like it better without the word 'zuul'21:52
corvushttp://logs.openstack.org/86/567686/4/check/zuul-website-build/1afdfb7/html/ vs http://logs.openstack.org/86/567686/3/check/zuul-website-build/97055ef/html/21:53
clarkb++21:53
clarkbits a bit more distinct on my tab panel that way. Also it says Zuul: Stop merging broken code just to the right of the icon21:54
corvusheh.  maybe we should use something other than the tagline for the page title.  there's an ambiguous reading when you just read it like that.  sort of like "zuul, stop hitting yourself".21:55
clarkbmaybe just "Zuul"21:57
corvusalways a classic21:57
SpamapSSo I have an interesting problem today22:02
SpamapSUsing our corporate images is proving really difficult22:02
SpamapSOne thing they do is join to our AD domain and restart sshd to enable AD users to ssh in...22:02
SpamapSWhat that means is nodepool marks the node as `ready` and then sshd stops working for a few seconds some time later (~1 minute)22:03
SpamapSWondering if anybody has any quick fixes for this.22:03
clarkbSpamapS: I thought sshd restarts were supposed to be safe for that22:03
SpamapSWhat's happening is that jobs are retry_limit'ing regularly.22:03
SpamapS2018-05-10 14:31:02,579 DEBUG zuul.AnsibleJob: [build: da602c022cbc48d8878a3feef28d7c9a] Ansible output: b'    "msg": "SSH Error: data could not be sent to remote host \\"10.26.15.53\\". Make sure this host can be reached over ssh",'22:04
SpamapSOne way others in the company fix this is by setting a piece of nova metadata that avoids the domain join.22:04
SpamapSbut I don't see any way to configure nodepool to do that.22:05
SpamapSSo before I add that to nodepool, just looking for something that maybe we can do to ansible/zuul to make it be a little more forgiving.22:05
SpamapSone thought I've had is to try and detect if a box has joined to the domain in our base pre-playbook.22:05
SpamapSAnd if it hasn't, just spin for a while waiting for sshd to go away and then come back.22:06
clarkbya you can add metadata to images that are uploaded to glance but I don't think you can do per instance metadata other than ssh keys?22:06
clarkband if you are using preuploaded images that won't help22:06
mordredyah - we don't currently have support for cloud-init metadata because eww22:07
mordredSpamapS: I thnk the pre-playbook idea is a thing you should be able to hack up quickly and should do the job22:08
mordredSpamapS: and at least provide a bit of space for figuring out a possible better solution22:08
SpamapSIt's not cloud-init metadata22:08
SpamapSit's nova metadata22:08
SpamapSlike the same place we set 'groups'22:08
mordredoh - like just an arbitrary metadata?22:09
mordredgotcha22:09
mordredthat seems easier to add support for :)22:09
SpamapSYeah I found the lines where those are set22:09
SpamapSso I can just plumb a thing in from the label.22:09
corvusyeah, adding metadata sounds like a good idea.  i think otherwise, the risk is that the window of non-functionality is racy.22:10
clarkbSpamapS: ya reading the unit for sshd locally it a sighup and should reload config like that gracefully. You might also want to check if your images are doing the right thing22:10
SpamapSclarkb: oh, they're not. ;)22:11
SpamapSbut actually I believe it has to be restarted to pick up the PBIS nss driver changes.22:11
corvusalso perhaps it would be possible to avoid starting sshd until that config was in place?  then nodepool will wait longer before declaring it ready.22:11
clarkbSpamapS: I believe it does a full new process but does socket handoff22:14
clarkbSpamapS: there is a good chance that it would work22:14
clarkb"sshd rereads its configuration file when it receives a hangup signal, SIGHUP, by executing itself with the name and options it was started with, e.g. /usr/sbin/sshd."22:14
SpamapSThe process for me to change the image is far harder than the process to change nodepool.22:15
SpamapSbut that is encouraging22:15
SpamapSand maybe I could fix that22:15
clarkbadditionally (at least on xenial) there is ssh.service enabled by default but also ssh.socket. ssh.socket will use systemd socket activation to queue up connections. This may also help22:18
SpamapSWe're on CentOS 722:20
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Allow upload-logs to toggle compression of console logs  https://review.openstack.org/56769622:20
pabelangerso, ^ is a breaking change and likely needs an email to zuul-discuss, but believe make upload-logs more usable by default, when we disable compression of console logs22:21
clarkbpabelanger: looks like zuul web tests did say it doesn't like newer aiohttp22:23
clarkbI guess that is a good thing to know22:23
pabelangerclarkb: ah, I haven't look at results yet22:23
pabelangernot much help in logs22:25
clarkbya, I think it might be failing a bit more catastrophically than the test framework can pull log sout of22:26
clarkbSpamapS: and I'm guessing you don't want to use your own images because part of what you are testing is that the corp images work?22:30
SpamapSclarkb: right, we want to be using the same image that we'll be deploying to.22:33
pabelangerokay, sent email to ML about upload-logs22:34
SpamapSclarkb: we do a lot of custom images too, when speed is more important than accuracy.22:34
SpamapSbut like, a lot of these are 2 minute tests22:34
SpamapSand it's nice to know that your unittests work on the image.22:34
SpamapSor that your deployment code works on it22:34
clarkbpabelanger: what is the motivation or background on the logs change/22:35
pabelangerclarkb: lets configuration need in apache / nginx out of the box22:35
clarkbpabelanger: I'm not sure I'm a fan of that one. Compressed logs by default is a major win and its super simple to make your browser inflate them22:35
clarkband its only like one extra click if it doesn't22:37
pabelangersorry, click where?22:38
clarkbpabelanger: your browser will open a "open with" dialog and it should default to archive viewr which then opens the file22:38
clarkbat least with firefox22:38
pabelangerchrome forces me to download it22:39
pabelangerthen open it locally with editor22:39
clarkboh interesting ff gives you the option22:39
clarkbits the same dialog with two choices, open with tool or download22:39
pabelangeryah, I imagine there is a why in chrome to do it, but don't think out of box22:40
pabelangerI don't have a strong option if we compress by default, but would like a way to toggle it22:41
pabelangeri just figured, it would be one less thing to configure (web server) to view logs in a browser22:41
clarkbin this particular case I think the rlatively simple web server config (which you hvae to configure anyways) is worth it compared to having lots of easily compressable files that aren't compressed22:42
clarkbif we were serving the files without needing to configure the web server at all I'd probably agree with you, but you have to configure something22:42
pabelangerI agree, I could just place logs into /var/www/html/ and use the default vhost setup by the package also. I do think, we are recommending gzip of console logs out of the box, we'll also want to add documentation around how to configure that.22:46
clarkbpabelanger: I think it may be as simple as 'AddEncoding x-gzip .gz' 'AddType text/plain job-output.txt.gz' ?23:01
clarkb'AddType text/plain .txt.gz' might do it too23:01
clarkber still need the addencoding though23:02
*** rlandy has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!