Wednesday, 2018-04-04

*** odyssey4me has quit IRC00:08
*** odyssey4me has joined #zuul00:08
*** JasonCL has joined #zuul00:14
*** JasonCL has quit IRC00:29
*** JasonCL has joined #zuul00:48
*** JasonCL has quit IRC00:54
*** JasonCL has joined #zuul00:58
*** JasonCL has quit IRC01:03
*** JasonCL has joined #zuul01:10
*** harlowja has quit IRC01:19
*** JasonCL has quit IRC01:19
dmsimardThe ara sqlite middleware is working fairly well but has some rough edges still. I'll try and improve that but I was thinking... at what point can we not just expose the live run while it's running on the executor ?02:17
*** JasonCL has joined #zuul02:17
dmsimardLike in the job frame ( https://i.imgur.com/t2HH0tN.png ) there could be a link to 1) the console stream 2) the live ara results02:19
dmsimardof course ara isn't really super async awesome and etc but eventually maybe02:19
*** JasonCL has quit IRC02:20
*** JasonCL has joined #zuul02:21
*** threestrands has quit IRC02:47
*** JasonCL has quit IRC02:47
*** threestrands has joined #zuul02:47
*** threestrands has quit IRC02:47
*** threestrands has joined #zuul02:47
*** threestrands has quit IRC02:48
*** threestrands has joined #zuul02:49
*** threestrands has quit IRC02:49
*** threestrands has joined #zuul02:49
*** JasonCL has joined #zuul02:56
*** JasonCL has quit IRC03:00
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add a backoff for failed builds  https://review.openstack.org/55868603:21
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add a backoff for failed builds  https://review.openstack.org/55868604:06
*** JasonCL has joined #zuul04:21
*** JasonCL has quit IRC04:26
*** threestrands has quit IRC04:38
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: mqtt: add basic reporter  https://review.openstack.org/53554304:40
*** dtruong2 has joined #zuul05:08
*** dtruong2 has quit IRC05:10
*** harlowja has joined #zuul05:16
*** harlowja has quit IRC05:20
*** hashar has joined #zuul06:13
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Move tmpdir into work root  https://review.openstack.org/54669806:55
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Update to Ansible 2.4  https://review.openstack.org/53578106:56
*** sc68cal has joined #zuul07:03
*** sc68cal- has quit IRC07:04
openstackgerritTobias Henkel proposed openstack-infra/zuul master: DNM: tmpdir test  https://review.openstack.org/55871907:12
openstackgerritTobias Henkel proposed openstack-infra/zuul master: DNM: tmpdir test  https://review.openstack.org/55871907:30
*** electrofelix has joined #zuul07:39
*** jpena|off is now known as jpena07:46
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Move tmpdir into work root  https://review.openstack.org/54669807:56
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Update to Ansible 2.4  https://review.openstack.org/53578107:58
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Disable action and lookup plugins from 2.4  https://review.openstack.org/53583907:58
openstackgerritTobias Henkel proposed openstack-infra/zuul master: DNM: tmpdir test  https://review.openstack.org/55873608:15
*** AJaeger has joined #zuul08:18
*** dtruong_ has joined #zuul10:05
*** colettecello has joined #zuul10:11
*** aluria` has joined #zuul10:12
*** mhu` has joined #zuul10:14
*** weshay_ has joined #zuul10:14
*** gothicmindfood has quit IRC10:15
*** dtruong has quit IRC10:15
*** weshay has quit IRC10:15
*** mhu has quit IRC10:15
*** dmsimard has quit IRC10:15
*** aluria has quit IRC10:15
*** aluria` is now known as aluria10:16
*** aluria has quit IRC10:16
*** aluria has joined #zuul10:16
*** dmsimard has joined #zuul10:18
*** mhu` has quit IRC10:28
*** mhu` has joined #zuul10:28
*** weshay_ has quit IRC10:28
*** weshay_ has joined #zuul10:28
*** JasonCL has joined #zuul10:33
*** JasonCL has quit IRC10:39
*** JasonCL has joined #zuul10:47
*** JasonCL has quit IRC11:06
*** jpena is now known as jpena|lunch11:53
*** JasonCL has joined #zuul12:10
*** odyssey4me has quit IRC12:23
*** odyssey4me has joined #zuul12:23
*** snapiri- has joined #zuul12:38
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul master: Add static driver doc to Zuul From Scratch  https://review.openstack.org/55880212:38
*** jpena|lunch is now known as jpena12:53
*** weshay_ is now known as weshay13:06
*** elyezer_ has joined #zuul13:12
*** pwhalen has joined #zuul13:15
*** pwhalen has joined #zuul13:15
*** elyezer has quit IRC13:16
*** yolanda_ has joined #zuul13:22
*** yolanda has quit IRC13:24
*** SotK has quit IRC13:25
*** hashar is now known as hasharAway13:25
*** dkranz has joined #zuul13:32
*** SotK has joined #zuul13:33
*** mugsie_ is now known as mugsie13:35
*** mugsie has quit IRC13:36
*** mugsie has joined #zuul13:36
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul master: Add sample systemd service files.  https://review.openstack.org/55883014:01
*** gouthamr has joined #zuul14:02
Shrewscorvus: i think i now have all of the content i wanted in docs up in reviews, as well as your suggestions (ending with 558830). We can now debate the content. Anyone can feel free to post new patchsets to help (I suck at docs, as established long ago).14:03
dmsimardI created a story with a shitty mockup for the idea I mentioned last night regarding live ara reports during job execution https://storyboard.openstack.org/#!/story/200178214:25
*** maeca has joined #zuul14:31
*** maeca has quit IRC14:31
*** snapiri- has quit IRC14:40
sshnaidmwhen I run zuul-cloner from command line, I got an error: TypeError: __init__() missing 2 required positional arguments: 'speed_limit' and 'speed_time'  - how can I set them?15:05
*** rcarrillocruz has quit IRC15:05
*** rcarrillocruz has joined #zuul15:08
tristanCsshnaidm: this is being discussed on https://review.openstack.org/#/c/557826/15:08
sshnaidmtristanC, thanks15:10
sshnaidmI wonder how it works here: http://logs.openstack.org/86/558786/1/check/tripleo-ci-centos-7-containers-multinode/027d645/job-output.txt.gz#_2018-04-04_11_51_21_62862315:17
sshnaidmdifferent version..?15:18
pabelangerit is using the fetch-zuul-cloner roles: http://git.openstack.org/cgit/openstack-infra/zuul-jobs/tree/roles/fetch-zuul-cloner15:18
pabelangera shim that Shrews wrote15:18
pabelangerbut, we are planning on removing that from base jobs in the near future, since that is no longer needed with zuul 3.015:19
clarkbsshnaidm: yes see my comment on that change. I expect you are installing the version 2 zuul cloner which is correct I think15:20
clarkbversion 3 has no testing of the tool and we don't use it anymore so I hesitate trying to continue to support it there instead of removing it and pointing at version 2 if you need to tool. But corvus probably has a plan for this in mind15:20
clarkboh pabelanger points out it is the shim that works too15:20
clarkbin any case the code being modified doesn't work it isn't tested and isn't used upstream. Better to use the version that was used and tested15:21
clarkb(if you need it)15:21
sshnaidmI'm trying to workaround zuul issue, when it's not capable to clone dependency from different branch. For example I have patch to "tripleo-ci" master branch which has dependency on "tripleo-upgrade" repo queens patch.  Zuul fails to install this dependency15:26
sshnaidmpabelanger, ^^ any ideas..?15:26
corvusoh yeah, we should have removed the cloner command before the v3 release.  that was an oversight.  :)15:26
sshnaidmthat's why I'm trying to clone this dependency manually with zuul-cloner15:27
pabelangersshnaidm: is this for zuul.o.o or in RDO?15:28
corvussshnaidm: in zuul v3, zuul should prepare all the repos, so the cloner isn't needed.  there is a shim provided to handle jobs which haven't been rewritten for v3 yet: https://zuul-ci.org/docs/zuul-jobs/roles.html#role-fetch-zuul-cloner15:28
sshnaidmpabelanger, for both, but rdo is higher priority15:29
sshnaidmcorvus, please see my message above about zuul issue15:29
corvussshnaidm: rdo is v2, right?  if so, install the cloner command from v2.15:29
corvussshnaidm: show me where v3 isn't doing the right thing.15:29
pabelangeryah, it is likely the DIB images are not capped to use <3.0 of zuul15:29
pabelangerfor RDO15:30
sshnaidmcorvus, https://review.openstack.org/#/c/558189/ in this patch tripleo-upgrade is cloned from master branch, not from dependency15:32
sshnaidmpabelanger, what do you mean?15:32
corvussshnaidm: what job should we look at?15:33
sshnaidmcorvus, for example: http://logs.openstack.org/89/558189/6/check/tripleo-ci-centos-7-containers-multinode/fc3489f/  it uses zuulv315:34
corvussshnaidm: that change is to the master branch, so zuul will check out the master branch of all projects by default15:37
pabelangersshnaidm: before we would create the /usr/zuul-env at image build time with nodepool-builder, it is likely what the RDO project is still doing. If so, you want to update that element to cap zuul<3.0 to fix the exception. We no longer do this in openstack and use the fetch-zuul-cloner role that corvus linked15:39
sshnaidmcorvus, that's exactly the problem :)15:39
corvussshnaidm: i need you to articulate what you want to happen a bit more if you want me to help you15:40
sshnaidmcorvus, I'd expect tripleo-upgrade repo to be cloned according to: ZUUL_CHANGES="openstack/tripleo-upgrade:stable/queens:refs/changes/99/558199/1^openstack-infra/tripleo-ci:master:refs/changes/89/558189/6"15:40
sshnaidmcorvus, queens branch with ref refs/changes/99/558199/115:41
sshnaidmcorvus, like it's set in dependencies15:41
*** dtruong_ has quit IRC15:41
*** dtruong has joined #zuul15:42
corvussshnaidm: dependencies can be on any branch and don't affect the branch which is checked out.  those jobs are all written to operate on "the branch being tested".  in the case you linked, the branch was "master" because that's the change being tested.  however, if you look at the dependent change, when the jobs run on that change, the branch being tested is "queens", and so the queens branch of15:43
corvustripleo-upgrade is checked out in that case.15:43
corvussshnaidm: fwiw, zuul-cloner behaved the same way.15:43
corvussshnaidm: you can see that in action here: this is a job that ran on 558199: http://logs.openstack.org/99/558199/1/check/openstack-tox-linters/73ba9f6/zuul-info/inventory.yaml15:44
sshnaidmcorvus, I understand the current behavior, I just say that I have a different expectations for it. And I don't think I expect something weird15:44
corvussshnaidm: if you look at the bottom of that, you can see it checked out stable/queens there15:44
sshnaidmcorvus, so you say it's in  src/git.openstack.org/openstack/tripleo-upgrade with queens branch and changed applied?15:45
corvussshnaidm: on 558199, tripelo-upgrade is checked out on the queens branch because it's a queens change.  on 558189 tripleo-upgrade is checked out on the master branch because it's a master change.15:46
sshnaidmcorvus, it's master change for tripleo-ci repo, but queens change for tripleo-upgrade repo15:47
sshnaidmcorvus, different repos, where each one has different branch15:47
sshnaidmcorvus, and I expected each repo to be cloned according to its branch, and not some default15:48
corvussshnaidm: sure, but just because the change depends on a change in the queens branch, it doesn't follow that, when testing the master change, the dependent repo should be checked out on the queens branch.15:48
corvussshnaidm: let's consider devstack for a moment.  if a change to nova master happened to be behind a change to glance queens in the queue, it would be strange indeed for us to checkout nova master and glance queens and try to install them.  they are not designed to work together.15:49
sshnaidmcorvus, yeah, but we talk about CI code, where some repos have stable branches and some don't..15:50
sshnaidmcorvus, I agree it's a mess, but zuul could handle it I think15:50
corvusit's not a mess15:50
corvussshnaidm: if a job needs to check out a specific branch of a repo, it can specify it needs that branch15:50
sshnaidmcorvus, I mean cross-branch dependencies15:50
corvussshnaidm: that's needed for certain kinds of jobs.  for example, a job which is designed to run on queens no matter what (ie, a queens ugrade job)15:51
corvussshnaidm: but most jobs are constructed to run on whatever branch is being tested15:51
sshnaidmcorvus, but still, all repos will be cloned for queens, not one15:51
*** acozine1 has joined #zuul15:51
corvussshnaidm: if you specify an override branch?  it depends on how you do it.  you can tell zuul to checkout queens on all projects, or just one.15:52
sshnaidmcorvus, I wonder how can I specify override branch with dependencies15:52
sshnaidmcorvus, it should check if I have dependency on this repo, calculate its branch and then override it15:53
corvussshnaidm: what is it that you're ultimately trying to accomplish?15:53
sshnaidmcorvus, in that patch I linked above I want on my host to be cloned: tripleo-ci repo with master change, tripleo-upgrade repo with queens change (from ZUUL_CHANGES)15:54
corvussshnaidm: that's not what i'm asking.  i'm asking what do you want to test?15:54
sshnaidmcorvus, what do you mean..?15:54
corvussshnaidm: i mean, let's pick a single job and describe what it is you want to do.15:55
sshnaidmcorvus, I test tripleo, but how we test it is out of scope, it's like given situation15:55
corvussshnaidm: are we still talking?15:58
sshnaidmcorvus, I think so :)15:59
sshnaidmcorvus, I gave an example: https://review.openstack.org/#/c/558189/15:59
corvussshnaidm: that's a change.  i need you to pick a job from that change, and describe what the job is supposed to test.16:00
sshnaidmcorvus, sure, it's for example: http://logs.openstack.org/89/558189/6/check/tripleo-ci-centos-7-containers-multinode/fc3489f/16:00
sshnaidmcorvus, it tests tripleo as I said16:00
sshnaidmcorvus, if you want more details - tripleo-upgrade is ansible role, which I need to install in this job (from queens branch with change)16:01
corvussshnaidm: does that job use that role?16:01
sshnaidmcorvus, will use later16:02
sshnaidmcorvus, for now I don't have it to install.. it's cloned from master16:02
corvussshnaidm: if we ignore the dependency for a moment, and i just checked out master of all the repos and ran that job, should it work?16:03
sshnaidmcorvus, the role installation part is not there yet, if you ask this16:04
sshnaidmcorvus, it'll be like "pip install /path/to/repo/tripleo-upgrade"16:05
sshnaidmcorvus, and I hoped to have it somewhere on the host..16:05
corvussshnaidm: what does tripleo-upgrade do?16:06
sshnaidmcorvus, upgrades tripleo16:06
corvussshnaidm: from what to what?16:07
corvussshnaidm: like, if we checkout the master branch of tripleo-upgrade, what would the role do?  upgrade from queens to master?  upgrade from master to rocky?16:08
corvusor if it's easier, if we checkout the queens branch, what does it do?16:09
sshnaidmcorvus, if we checkout queens branch, it will upgrade from queens to ... some target16:10
*** elyezer_ has quit IRC16:10
corvussshnaidm: and the job, tripleo-ci-centos-7-containers-multinode, is that intended to perform this upgrade?16:11
sshnaidmcorvus, no, this is just an example16:11
corvussshnaidm: ah, well, the branch of a repo that's checked out is very much dependent on the job16:11
corvussshnaidm: i think the underlying thing we're missing here is that what determines what gets checked out is not the dependency chain.  it's the combination of the job and the change under test.16:12
corvussshnaidm: so if you're building an upgrade job, you need to start by saying "what upgrade is this job going to test?"16:13
*** elyezer_ has joined #zuul16:13
corvussshnaidm: for instance, if it's going to test an upgrade from queens to rocky, then it will need to check out the queens versions of things, install them, then checkout rocky, and perform the upgrade.  the job should do that if it gets run on a change to queens, *or* if it gets run on a change to rocky (since both sides can affect an upgrade job)16:14
corvussshnaidm: it's a very different process than constructing a job designed to run on any branch (which is what most jobs are)16:14
corvussshnaidm: so the multinode job may very well be behaving exactly as it's supposed to (when it runs on a change to queens, it checks out queens; when it runs on a change to master, it checks out master).  upgrade jobs just need to be constructed differently.16:15
corvussshnaidm: let me expand on something i said a moment ago --16:16
sshnaidmcorvus, that's right, upgrade jobs use "override branch" usually16:16
corvussshnaidm: what determines what gets checked out is not the dependency chain.  it's the combination of the job and the change under test.  the dependency chain holds the possible future state of all the repos.  so if a job needs to check out queens, and there's a queens change in the dependency chain, the dependent change will be in the queens branch.  but the fact that the change is in the dependency chain16:18
corvusdoesn't automatically cause it to get checked out.  it's the job that does that.  and if the job doesn't specify anything specifically (via override-checkout), then it's the change under test that determines what gets checked out.16:18
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul master: Add Gerrit docs to Zuul From Scratch  https://review.openstack.org/55860016:19
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul master: Add static driver doc to Zuul From Scratch  https://review.openstack.org/55880216:19
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul master: Add sample systemd service files.  https://review.openstack.org/55883016:19
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul master: Move zuul jobs config to zuul config section  https://review.openstack.org/55886716:20
sshnaidmcorvus, ok, I see.. seems like I need to review these dependencies chains again..16:20
*** elyezer_ has quit IRC16:24
dmsimardcorvus: random question -- I wonder if we could commission the foundation to work on a Zuul logo like they did with the OpenStack ones :)16:33
dmsimardWould be nice to have a logo/icon/favicon for Zuul16:33
corvusdmsimard: indeed!  they just contacted me about starting to work on one.16:34
dmsimardhuh, odd coincidence :D16:35
corvusthat would have been a good thing to mention at the last meeting :)16:35
dmsimardzuul-discuss worthy perhaps16:35
corvus(well, very recently, not like, a minute ago :)16:35
*** elyezer_ has joined #zuul16:36
pabelangerspooky16:41
*** acozine1 has quit IRC16:46
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP: Check out more appropriate branches of role and playbook repos  https://review.openstack.org/55864316:46
*** acozine1 has joined #zuul16:51
*** pwhalen has quit IRC17:03
*** Shrews has quit IRC17:06
*** Shrews has joined #zuul17:06
*** pwhalen has joined #zuul17:10
*** pwhalen has joined #zuul17:10
*** Shrews has quit IRC17:11
*** Shrews has joined #zuul17:11
*** jpena is now known as jpena|off17:19
*** gouthamr has quit IRC17:24
pabelangercorvus: tristanC: mordred: so, it seems native fedmsg support in zuul might not be something we want to do. Talking with #fedora-admin it seems fedora maybe in the the process of migrating away from it.  So, given that we seemed okay to support both mqtt / fedmsg drivers in zuul, maybe we just do mqtt directly and stand up external fedmsg infra is we still want to go down that path.17:25
pabelangeralso seems debian is no longer using fedmsg either, according to #fedora-admin17:26
clarkbpabelanger: do we know what their reasons are/were? additionally is fedora using it the only reason we'd use it?17:26
mordredpabelanger: that's good information. if debian is no longer using it and fedora may be moving away from it, it doesn't seem like a good thing for us to add support for17:27
mordredclarkb: I think the reason we were drawn to it originally is that it was a bus that existed that both fedora and debian already use17:27
clarkbI ask because this was a major topic at the cross ci event and it seemed like a tool like fedmsg would solve that nicely17:27
clarkbso understanding why people may not want to continue using it and determining if it is still valid for a different use case would be helpful17:28
mordredclarkb: I believe one of the concerns that has been expressed about fedmsg is that it doesn't allow subscribing to a specific topic - all filtering of messages isdone client-side17:28
clarkbah17:28
clarkbsomething that mqtt solves nicely17:28
mordredclarkb: which is one of the reasons firehose uses mqtt - so that a client can only subscribe to a subset of events17:28
mordredyup17:28
clarkbfwiw the big draw for me personally was the ease of setup and somewhat structured data17:29
clarkbbut mqtt is fairly easy to setup and use and we can address the structured data problem if we agree on some common fields and practices17:29
pabelangerclarkb: I get the impression there isn't many active developers on fedmsg any more, so rather then keeping a stack of libraries working (eg: python3) they might just use ZMQ libraries directly17:29
clarkbpabelanger: that seems like the completely wrong direction to take based on our experience of using zmq directly :)17:30
pabelangerThey do seem open to the idea of adding mqtt support into fedmsg, but I'm unsure if we as zuul want to recommend using it, if project is lacking developers17:30
clarkbpabelanger: but not our decision to make :)17:30
pabelangeryah17:31
pabelangerbut since it was an important topic for ci meet up, I don't want to say not use it. But maybe we need to re-evaluate it17:32
pabelangerand spend some development effort updating it for python3 if needed17:32
clarkbconsidering that we would wanted to update fedmsg to mqtt anyways I'm personally happy to just mqtt17:33
pabelangeryah, the main interested for me, was some of the fedmsg tooling we'd get. Eg: fancy JS library or desktop app to subscribe to things17:34
pabelangerbut using mqtt directly seems just as good too17:34
*** Diabelko has quit IRC17:38
ShrewsI asked LinuxJedi how his zuul demo went earlier. Since I hadn't heard back, I'm assuming that it went SO well that they immediately dragged him out for some extreme vodka drinking.  :)17:44
ShrewsI hear that do that kind of thing in Finland17:45
*** gouthamr has joined #zuul17:45
pabelangerHa17:45
*** electrofelix has quit IRC17:47
*** Diabelko has joined #zuul18:13
LinuxJediShrews: close, currently having food and wine 🙂. I’ll fill you in when I get back to the hotel later.18:13
LinuxJediVodka is tomorrow18:14
Shrewsw00t18:14
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP: Check out more appropriate branches of role and playbook repos  https://review.openstack.org/55864318:28
corvusandreaf, mordred: there's a surprising amount of subtle errors in the executor with respect to roles (and playbooks) on branches.  i've been working on that ^ for most of the morning, and it will probably still take at least the rest of the day before it's finished.18:29
mordredcorvus: nod18:31
*** sshnaidm is now known as sshnaidm|afk18:51
*** hasharAway is now known as hashar19:07
*** harlowja has joined #zuul19:10
pabelangerHmm, are we still using /bin/kill -HUP $MAINPID to reload zuul service? I thought some of that was moved into commandsocket19:49
*** gouthamr has quit IRC19:52
pabelangeryah, seems only the scheduler. I could have thought we moved it into zuul-scheduler reload, I guess not19:57
pabelangeror19:57
pabelangerreconfigure19:57
*** myoung is now known as myoung|mtg20:10
*** snapiri has quit IRC20:28
*** snapiri has joined #zuul20:30
*** snapiri has quit IRC20:33
*** snapiri has joined #zuul20:33
*** hashar has quit IRC20:48
*** myoung|mtg is now known as myoung21:03
*** acozine1 has quit IRC21:08
*** elyezer_ has quit IRC21:09
*** elyezer_ has joined #zuul21:22
*** elyezer_ has quit IRC21:29
dmsimardJust a heads up, there'll be a 0.15.0 release of ARA. 1.0 is still some ways off and there's some fairly easy backports which would be helpful to us and some other users -- especially performance related21:34
dmsimardmordred: ^ I've started working on a model for nested jobs in ARA's gate, I'll try and see if I can leverage what you did for the functional zuul_stream job to get a nested zuul or something21:35
dmsimardI'm fairly certain there's nothing to change in our current implementation -- there'll be a sqlite middleware update but that's on the log server and backwards compatible21:36
*** elyezer_ has joined #zuul21:41
mordreddmsimard: neat21:43
*** dkranz has quit IRC21:44
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP: Check out more appropriate branches of role and playbook repos  https://review.openstack.org/55864322:43
corvusandreaf, mordred, clarkb, tobiash: ^ that's getting pretty close to ready -- enough that it may be worth a look to familiarize yourself with it.  i suspect i'll be ready to talk about it tomorrow.22:49
clarkbcorvus: a roles project is any project that defiens a role?22:54
corvusclarkb: it's a project that's listed in the 'roles' attribute of a job22:54
clarkbaha22:55
corvus(though if it's listed there, it must define roles, or it's an error)22:55
clarkbcorvus: and being listed in that manner is what sets the roles type to zuul I assume?22:55
corvusclarkb: that's specified too.  it's like "roles: [{zuul: projectname}]"22:56
corvusclarkb: so that we can later have "roles: [{zuul: projectname, galaxy: otherrolename}]"22:57
clarkbcool I was just making sure that check against role type was coming from where I assumed it was given ^22:57
clarkbsounds like it is22:57
corvusah yep.  if it's not a zuul role, it'll be a galaxy role, and none of this applies.  but only zuul roles exist now.  that's future proofing.22:58
clarkbskimming it the logic makes sense22:59
corvuscool.  i'm going to sleep on it to give my brain a chance to come up with any other edge (or test) cases23:00
clarkbzuul isn't really happy with it currently but I'm assuming thats largely just needing cleanup23:01
mordredcorvus: dude. I read the commit message and believe I understand the first time - good commit message!23:02
corvusclarkb: hopefully; the new test passes locally, i didn't run the whole thing.  so either it's cleanup... or fundamental flaw.  :)23:04
corvus(or, it could actually be a behavior change affecting other tests)23:04
corvusthis very much could alter current jobs -- but if so, they should hopefully be easy to fix23:05
clarkbfeature request can we put the job name and change number in the streaming console parameters list? the server can totally ignore them its just a nice cue to browser users for what they are looking at23:06
clarkbI can probably attempt to hack the js to do that if people are opposed23:06
clarkb(I assume the server side won't error if it gets params it doesn't know about but maybe it will)23:07
corvusclarkb: what if we put them at the top of the console output -- and maybe the title?23:07
clarkbcorvus: that would probably work too. Though scrolling is also weird23:08
clarkbI'd volnteer to fix scrolling btu expect that is beyond my js abilities23:08
corvusclarkb: (i'm slightly resistant to adding them to the url on usability grounds -- it suggests a feature that isn't there)23:08
clarkbin particular if autoscroll is on even if you scroll up it will scroll back down (so not just auto scroll at bottom) and if you disable autoscroll I have a hard time scrolling down from the top23:08
corvusclarkb: setting <title> should help with the scrolling case23:08
corvusoh yeah, i've noticed that too23:09
clarkbbut ya generally putting it in a title would probably work23:10
mordredclarkb, corvus: I've got a streaming rework patch up23:11
mordredclarkb, corvus: so if you do decide to try to poke at things, you might want to do it on top of that23:11
corvus++23:11
mordredhttps://review.openstack.org/#/c/558646/ ftr23:12
*** acozine1 has joined #zuul23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!