Wednesday, 2018-03-21

« Tuesday, 2018-03-20 Index Thursday, 2018-03-22 »
*** xinliang has quit IRC00:07
*** odyssey4me has quit IRC00:10
*** odyssey4me has joined #zuul00:10
*** xinliang has joined #zuul00:19
*** harlowja has quit IRC01:07
*** elyezer has quit IRC01:09
*** myoung|afk is now known as myoung02:23
*** myoung is now known as myoung|afk02:27
*** rlandy|bbl is now known as rlandy03:15
*** pbrobinson has quit IRC04:11
*** pbrobinson has joined #zuul04:11
*** harlowja has joined #zuul04:39
*** rlandy has quit IRC04:39
*** harlowja has quit IRC04:56
*** swest has joined #zuul06:11
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Pass NODEPOOL_ZK_HOST variable for py35 test  https://review.openstack.org/55481006:46
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Allow external zookeeper in tox py35 runs  https://review.openstack.org/55481006:52
tobiashjhesketh: did you see mordred's response on https://review.openstack.org/536882 ?06:56
jheskethtobiash: will look now06:57
*** logan- has quit IRC06:58
*** logan- has joined #zuul06:58
jheskethtobiash: lgtm :-)07:05
tobiash:)07:05
tobiashfungi: I commented on https://review.openstack.org/55435207:11
*** flepied_ has quit IRC07:14
openstackgerritMerged openstack-infra/zuul master: Switch to stestr  https://review.openstack.org/53688207:14
*** hashar has joined #zuul07:33
*** flepied_ has joined #zuul07:48
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix zuul-web port in zuul-from-scratch doc  https://review.openstack.org/55482908:20
*** jpena|off is now known as jpena08:43
*** electrofelix has joined #zuul09:14
*** jesusaur has quit IRC09:21
*** jesusaur has joined #zuul09:24
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add trigger driver  https://review.openstack.org/55483909:25
*** jimi|ansible has joined #zuul09:33
*** jimi|ansible has joined #zuul09:33
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add trigger driver  https://review.openstack.org/55483909:54
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: web: add reenqueue button  https://review.openstack.org/55485609:54
*** JasonCL_ has joined #zuul10:20
*** JasonCL has quit IRC10:23
*** JasonCL has joined #zuul10:27
*** JasonCL_ has quit IRC10:30
*** JasonCL_ has joined #zuul10:32
*** JasonCL__ has joined #zuul10:33
*** JasonC___ has joined #zuul10:35
*** JasonCL has quit IRC10:36
*** JasonCL has joined #zuul10:37
*** JasonCL_ has quit IRC10:38
*** JasonCL__ has quit IRC10:39
*** JasonCL_ has joined #zuul10:39
*** JasonC___ has quit IRC10:40
*** JasonCL__ has joined #zuul10:40
*** JasonCL has quit IRC10:42
*** JasonCL_ has quit IRC10:44
*** JasonCL has joined #zuul10:59
*** JasonCL__ has quit IRC11:00
*** sshnaidm|sick is now known as sshnaidm11:08
*** snapiri has quit IRC11:28
*** snapiri has joined #zuul11:28
*** jpena is now known as jpena|off11:39
*** jpena|off is now known as jpena11:40
*** JasonCL_ has joined #zuul11:48
*** JasonCL has quit IRC11:50
*** odyssey4me has quit IRC12:03
*** odyssey4me has joined #zuul12:03
*** JasonCL_ has quit IRC12:09
*** JasonCL has joined #zuul12:10
*** jpena is now known as jpena|lunch12:20
openstackgerritJoshua Hesketh proposed openstack-infra/zuul master: WIP Retry merge jobs  https://review.openstack.org/55489012:27
*** rlandy has joined #zuul12:35
*** dkranz has joined #zuul13:06
dmsimardtobiash: (not v3 release related, ignore if you want) I created a story about the reporting bits I told you about https://storyboard.openstack.org/#!/story/200171513:06
*** elyezer has joined #zuul13:11
*** elyezer has quit IRC13:17
*** myoung|afk is now known as myoung13:18
*** snapiri has quit IRC13:19
*** jpena|lunch is now known as jpena13:25
*** elyezer has joined #zuul13:29
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add trigger driver  https://review.openstack.org/55483913:33
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Upgrade from angularjs (v1) to angular (v5)  https://review.openstack.org/55198914:04
mordredtobiash: your 554810 looks great - but 535882 conflicts with it now14:05
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Allow external zookeeper in tox py35 runs  https://review.openstack.org/55481014:13
tobiashmordred: ^14:13
*** JasonCL has quit IRC14:16
*** JasonCL has joined #zuul14:18
*** JasonCL has quit IRC14:18
mordredtobiash: +214:18
tobiashthx :)14:18
*** JasonCL has joined #zuul14:18
*** myoung is now known as myoung|rover14:19
*** myoung|rover is now known as myoung|rover|mtg14:20
*** JasonCL has quit IRC14:24
*** JasonCL has joined #zuul14:26
*** JasonCL has quit IRC14:32
*** JasonCL has joined #zuul14:33
dmsimardmordred: built dashboard on logs appears to be working again, great job \o/ http://logs.openstack.org/89/551989/10/check/zuul-build-dashboard/6e2ecf4/npm/html/status.html14:34
mordreddmsimard: \o/14:35
mordreddmsimard: oh - wait - it's still not quite right14:38
*** hashar is now known as hasharAway14:39
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Revert "Switch to stestr"  https://review.openstack.org/55494314:50
corvusmordred: i just tried stestr, and i ran into 3 problems we need to discuss.  i'd rather not do it right now.  i'd rather be able to have things continue to work as they have until we release.  then we can take time to do this properly.  is that okay?14:51
mordredcorvus: sure.14:51
corvusmordred: can you +3 https://review.openstack.org/554943 ?14:54
mordredcorvus: done14:55
corvustobiash, jhesketh: ^ fyi14:56
tobiashcorvus: sorry, I didn't anticipate problems during review14:58
tobiashcorvus, mordred: 554829 might be v3 related (just a small doc change)15:00
openstackgerritMerged openstack-infra/zuul-jobs master: Uninstall and reinstall siblings one at a time  https://review.openstack.org/55429715:03
*** electrofelix has quit IRC15:12
corvustobiash: left a comment there15:21
tobiashcorvus: ok, that's an argument, agreed15:22
corvusmordred, Shrews: the initial zuul-stream tests are ready for review https://review.openstack.org/55471415:24
openstackgerritMerged openstack-infra/zuul master: Revert "Switch to stestr"  https://review.openstack.org/55494315:27
pabelangerHmm, autohold doesn't seem to be working if there is a failure in pre-run.  Trying to confirm that.15:48
*** JasonCL has quit IRC15:49
*** JasonCL has joined #zuul15:49
corvuspabelanger: that will fail with 'retry_limit'; maybe autohold doesn't check for that15:49
pabelangercorvus: yah, that is what I am seeing now, 'retry_limit'. Peaking at code now15:50
clarkbI think it explicitly checks for failure15:50
pabelanger2018-03-21 15:39:49,037 ERROR zuul.Scheduler: Unable to process autohold for None:15:50
clarkb(I was just looking at that code to try and fix the thing that tobiash has already fixed)15:50
pabelangeris what I see in debug.log currently15:50
clarkbpabelanger: ya thats the thing tobiash has fixed that we need a scheduler restart to pick up15:51
pabelangerokay, great15:51
pabelangerthanks tobiash!15:51
clarkbbut I'm still not sure it will fix your thing15:51
*** JasonCL has quit IRC15:51
clarkbif build.result != "FAILURE": return15:51
clarkbfrom _processAutohold15:51
tobiashclarkb: that should be easy to also check for retry limit15:52
tobiashmaybe also do the check for post failure at the same time15:52
corvus++15:52
*** JasonCL has joined #zuul15:53
*** JasonCL has quit IRC15:53
*** JasonCL has joined #zuul15:54
pabelangerokay, working on patch15:56
pabelangerif build.result == "SUCCESS": return?15:58
corvuspabelanger: i'd rather list the explicit failures we want to hold.  i don't think we want to hold an 'ABORTED' job.15:59
pabelangerwfm15:59
tobiashcorvus, clarkb: updated story for the upcoming sec fix16:04
corvustobiash: thanks.16:06
corvusdmsimard: have you reconfirmed the issue you opened?16:06
*** JasonCL has quit IRC16:07
dmsimardcorvus: The development SF environment I'm working with wasn't up to date yesterday and still isn't.. I think we're up to date on our production environment, I'll test there and report back.16:08
*** JasonCL has joined #zuul16:08
Shrewscorvus: thx. taking a look16:12
*** JasonCL has quit IRC16:16
*** JasonCL has joined #zuul16:16
*** yolanda_ has joined #zuul16:19
*** yolanda has quit IRC16:19
*** JasonCL has quit IRC16:19
*** JasonCL has joined #zuul16:19
*** JasonCL has quit IRC16:42
*** myoung|rover|mtg is now known as myoung16:48
*** myoung is now known as myoung|food16:53
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Rename javascript package to @zuul-ci/dashboard  https://review.openstack.org/55199916:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Stop falling back to job name for missing url  https://review.openstack.org/55405616:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Use requests instead of urllib.request in tests  https://review.openstack.org/55405716:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: web: add /{tenant}/jobs/{job_name} route  https://review.openstack.org/55097816:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: web: add /{tenant}/projects routes  https://review.openstack.org/55097916:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: web: add /{tenant}/pipelines route  https://review.openstack.org/54152116:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: dashboard: add /{tenant}/job.html page to display job details  https://review.openstack.org/53554516:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: dashboard: add /{tenant}/projects.html web page  https://review.openstack.org/53787016:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Fix indentation and renable the eslint rule  https://review.openstack.org/54567116:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Shift html templates into components  https://review.openstack.org/55132716:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Upgrade to webpack 4  https://review.openstack.org/55198716:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Upgrade from angularjs (v1) to angular (v5)  https://review.openstack.org/55198916:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Remove dashboard workaround for missing log_url  https://review.openstack.org/55406616:55
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Use glyphicons for status balls  https://review.openstack.org/55199216:55
mordredsorry about that - I promise I'm not pushing up a full restack just for fun :)16:55
*** hasharAway is now known as hashar16:57
*** JasonCL has joined #zuul16:58
Shrewscorvus: tested that remote test locally (ironically) to verify some things. lgtm16:58
*** JasonCL has quit IRC17:10
corvustobiash: do you want me to add some ordering validation to 554714 before we land it, or was that more of a "maybe we should do this in the future if we feel like it" comment?17:11
tobiashcorvus: it was a nice to have but can happen later comment17:12
corvus(i thought about it when i wrote it, and figured it was so unlikely to happen that i didn't bother.  that could just be lack of imagination on my part :)17:12
tobiashI thought in the beginning there was an issue with ordering and loops17:13
tobiashSo I thought that would be a good idea17:14
corvusloops would be a good test to add too :)17:14
tobiashDo you want to land it as is and extend that iteratively?17:15
*** JasonCL has joined #zuul17:19
corvustobiash: yeah, let's do that.  mordred, do you want to review https://review.openstack.org/554714 ?17:23
mordredcorvus: looking at it right now17:23
tobiashcorvus: ok, changed to +217:23
pabelangerso, I've written a testing test_v3 to autohold a RETRY_LIMIT job, I see getting held, but having a hard time actually asserting in code it is held. I see no easy way to ask zuul for a list of held nodes, unlike nodepool17:24
mordredcorvus: love it17:24
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Enable autohold for RETRY_LIMIT  https://review.openstack.org/55499517:28
pabelanger^ is the code path I am trying to test, would love some pointers :)17:28
kklimondapabelanger: is there a reason you are not testing it in test_scheduler.py ?17:36
kklimondathere are a lot of tests around holding nodes, and I think all of them are part of that module17:36
*** andreaf has quit IRC17:39
*** andreaf_ has joined #zuul17:39
openstackgerritMerged openstack-infra/zuul master: Add zuul-stream remote tests  https://review.openstack.org/55471417:41
*** andreaf_ is now known as andreaf17:41
*** myoung|food is now known as myoung17:45
corvuspabelanger: it's not working because the pre-playbook configuration uses an empty nodeset.  the tests kklimonda reference in test_scheduler have an actual nodeset.18:03
kklimondacorvus: btw, is there any reason why zuul_return variables are not shared with following playbooks?18:05
corvuskklimonda: i can't think of a reason not to, but i'd like folks with more ansible experience to weigh in on whether that's a good idea.  (mostly, i'm wondering if it would encourage folks to write playbooks that are too zuul-specific when there's a more ansible-like way to handle it.  i agree though that once you share it between jobs, you've probably already crossed that bridge)18:08
pabelangercorvus: kklimonda: ah, okay. Thanks, the reason I moved into test_v3, was I wasn't sure the best way to trigger RETRY_LIMIT in test_scheduler.18:11
kklimondacorvus: how about sharing between ansible runs? my usecase is retrieving something from a remote server within trusted context, and wanting to share it with  untrusted playbooks - right now I use `zuul_return` in trusted playbook and then `include_vars` in a role loaded from untrusted playbook.18:12
corvuskklimonda: yeah, i understand and it makes sense and sounds reasonable at first glance to me.  i just want to get more input on it, probably after we release 3.0.18:14
*** jpena is now known as jpena|off18:14
kklimondacorvus: sure - I just wanted to make sure I'm not missing anything obvious there18:14
kklimondait's very simple to workaround it anyway, with a small role that does `include_vars` on results.json18:15
*** flepied_ has quit IRC18:15
*** EmilienM is now known as mimi18:21
*** mimi is now known as EmilienM18:21
*** harlowja has joined #zuul18:24
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Upgrade from angularjs (v1) to angular (v5)  https://review.openstack.org/55198918:32
tobiashcorvus: I also like the variable propagation to the following playbooks which could make some things easier18:33
tobiashbut sure, post 3.0 ;)18:34
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Enable autohold for RETRY_LIMIT  https://review.openstack.org/55499518:43
pabelangercorvus: thanks for pointers, that was the issue18:44
pabelangerdmsimard: yah, let me add POST_FAILURE to autohold18:44
dmsimardpabelanger: ++18:44
tobiashcorvus, clarkb, mordred: updated the story with a slightly different approach18:53
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix zuul-web port in zuul-from-scratch doc  https://review.openstack.org/55482918:56
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Enable autohold for RETRY_LIMIT / POST_FAILURE  https://review.openstack.org/55499519:12
pabelangercorvus: tobiash: dmsimard: ^updates autohold19:14
pabelangerclarkb: too^19:14
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Enable autohold for RETRY_LIMIT / POST_FAILURE  https://review.openstack.org/55499519:16
tobiashpabelanger: did I overlook it or is there no failing pre playbook in the test?19:18
tobiashI've seen the case with failing post playbook19:19
tobiashbut I don't see a corresponding failing pre playbook which would be run by test_pre_playbook_fail_autohold19:19
pabelangertobiash: it uses the existing playbooks19:20
pabelangerfrom test_pre_playbook_fail19:20
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Return CORS headers on all requests  https://review.openstack.org/55502719:20
pabelangeronly difference, is autohold creates a nodeset19:20
tobiashah, ok19:21
*** myoung is now known as myoung|biab19:22
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Allow external zookeeper in tox py35 runs  https://review.openstack.org/55481019:30
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Change test prints to log.info  https://review.openstack.org/55405819:30
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Fix logging in tests to be quiet when expected  https://review.openstack.org/55405419:30
clarkbtobiash: responded19:30
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Add license and downgrade exception to alembic template  https://review.openstack.org/55405519:30
pabelangertobiash: thanks19:32
openstackgerritMerged openstack-infra/zuul master: Fix zuul-web port in zuul-from-scratch doc  https://review.openstack.org/55482919:40
tobiashclarkb: responded19:44
*** elyezer has quit IRC20:21
*** dkranz has quit IRC20:26
*** elyezer has joined #zuul20:34
openstackgerritMerged openstack-infra/zuul master: Allow external zookeeper in tox py35 runs  https://review.openstack.org/55481020:46
*** myoung|biab is now known as myoung20:47
pabelangerclarkb: corvus: do you mind adding https://review.openstack.org/554995/ to your review pipeline, I'd like to see if we could merge and even restart scheduler to help debug some RETRY_LIMIT we are seeing on fedora nodes20:54
*** flepied_ has joined #zuul21:01
openstackgerritMerged openstack-infra/zuul master: Enable autohold for RETRY_LIMIT / POST_FAILURE  https://review.openstack.org/55499521:15
pabelangerthanks!21:16
pabelangermnaser: We seem to be in good shape with vexxhost, how does it look on your side?21:23
pabelangersorry, wrong channle21:23
corvusi've started work on creating git.zuul-ci.org -- https://review.openstack.org/55506321:31
pabelangeryay21:33
*** elyezer has quit IRC21:39
*** flepied_ has quit IRC22:10
*** threestrands has joined #zuul22:29
*** threestrands has quit IRC22:30
*** threestrands has joined #zuul22:30
*** threestrands has quit IRC22:30
*** threestrands has joined #zuul22:30
*** hashar has quit IRC22:45
« Tuesday, 2018-03-20 Index Thursday, 2018-03-22 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!