Wednesday, 2018-03-07

*** xinliang has quit IRC00:41
*** xinliang has joined #zuul00:54
*** harlowja has quit IRC02:13
*** rlandy has quit IRC02:25
openstackgerritIan Wienand proposed openstack-infra/zuul-jobs master: Add arm64 support to mirror setup  https://review.openstack.org/55031202:51
*** dkranz has joined #zuul03:29
openstackgerritMerged openstack-infra/zuul-jobs master: Handle repos with no tags in version-from-git  https://review.openstack.org/55017504:06
openstackgerritMerged openstack-infra/zuul-jobs master: Add arm64 support to mirror setup  https://review.openstack.org/55031205:28
*** snapiri has quit IRC05:56
*** bhavik has joined #zuul05:59
*** bhavik has quit IRC06:43
*** swest has quit IRC06:45
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Fix version-from-git syntax  https://review.openstack.org/55035706:52
*** threestrands_ has joined #zuul07:09
*** threestrands_ has quit IRC07:09
*** threestrands_ has joined #zuul07:09
*** threestrands has quit IRC07:10
*** threestrands_ has quit IRC07:13
openstackgerritMerged openstack-infra/zuul-jobs master: Fix version-from-git syntax  https://review.openstack.org/55035707:20
*** hashar has joined #zuul07:53
*** jpena|off is now known as jpena08:07
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Fix condition in version-from-git  https://review.openstack.org/55038808:22
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Fix condition in version-from-git  https://review.openstack.org/55038808:25
openstackgerritTobias Henkel proposed openstack-infra/zuul master: DNM: run tox-cover job  https://review.openstack.org/55039208:32
*** threestrands has joined #zuul08:32
*** threestrands has quit IRC08:32
*** threestrands has joined #zuul08:32
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Support pagination in the installation map  https://review.openstack.org/55039308:35
tobiashSpamapS: in case you have more than 100 repos in an organization ^08:35
*** threestrands has quit IRC08:36
tobiashone of my users added 600 repos to his org and crashed zuul config with that...08:36
*** abelur has joined #zuul08:44
*** electrofelix has joined #zuul08:47
openstackgerritMerged openstack-infra/zuul-jobs master: Fix condition in version-from-git  https://review.openstack.org/55038808:51
*** swest has joined #zuul08:56
openstackgerritTobias Henkel proposed openstack-infra/zuul master: DNM: run tox-cover job  https://review.openstack.org/55039209:01
openstackgerritFabien Boucher proposed openstack-infra/zuul master: Tenant config can be read from an external script  https://review.openstack.org/53587809:12
openstackgerritMerged openstack-infra/zuul-jobs master: Revert "Revert "Add zuul.{pipeline,nodepool.provider,executor.hostname} to job header""  https://review.openstack.org/51448909:19
openstackgerritMerged openstack-infra/zuul-jobs master: Add Ansible version to job header  https://review.openstack.org/53230409:19
*** swest has quit IRC10:07
*** swest has joined #zuul10:24
openstackgerritAndrea Frittoli proposed openstack-infra/zuul-jobs master: Add known hosts for all users  https://review.openstack.org/54864210:27
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Fix emit-job-header  https://review.openstack.org/55042510:28
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Fix emit-job-header  https://review.openstack.org/55042510:53
openstackgerritAndrea Frittoli proposed openstack-infra/zuul-jobs master: Add known hosts for all users  https://review.openstack.org/54864211:03
openstackgerritMerged openstack-infra/zuul-jobs master: Fix emit-job-header  https://review.openstack.org/55042511:21
*** jpena is now known as jpena|lunch12:03
mordredtobiash: left a note on 55039312:17
mordredtobiash: (which I only konw because I added support for the same thing to openstacksdk about a month ago)12:17
tobiashoh, cool, thx :)12:17
*** myoung|ruck|off is now known as myoung|ruck12:19
*** yolanda has quit IRC12:20
*** yolanda has joined #zuul12:21
*** myoung|ruck is now known as myoung|ruck|mtg12:59
*** jpena|lunch is now known as jpena13:05
*** rlandy has joined #zuul13:19
*** mickt has joined #zuul13:41
micktHi, setting up a zuul v3 system but finding documentation somewhat lacking. Anyone have a link to something useful. Maybe a use case for e.g. openstack-keystone or similar.13:45
tristanCmickt: we wrote some practical zuul usage blog post here: https://blogs.rdoproject.org/?s=zuul13:47
micktCool, I'll take a look. Thanks13:47
clarkbmickt: might help if you could expand a bit more on what particular bits you are struggling with. Is it setting up the services or configuring jobs or something else? also not sure what you mean by a use case for keystone?13:48
clarkbalso the official docs are at https://docs.openstack.org/infra/zuul/13:48
micktjob configuration etc. I'm a newbie to this too, which doesn't help13:48
clarkbmickt: the users guide https://docs.openstack.org/infra/zuul/user/index.html in particular tries to walk you through job configuration13:50
clarkbmickt: I would probably walk through it step by step. If you plan on running your own zuul then start by getting the services up. Then as you push configs to it they will largely be self testing so you can iterate and see how things fit together13:59
clarkband if you have specific questions (like why doesn't this particular bit of ansible work or what is this zuul service doing) we can help sort that out either here or on the mailing list and update docs as appropriate14:00
*** myoung|ruck|mtg is now known as myoung|ruck14:03
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Support pagination in the installation map  https://review.openstack.org/55039314:09
tobiashmordred: ^14:10
mordredtobiash: loks great!14:12
tobiash:)14:14
micktSo clarkb, I have a zuul-merger and two zuul-scheduler processes running. If I make a change to e.g. openstack-keystone repo and submit for review I would see the tests performed and failed etc.?14:15
clarkbdoes github gracefully give you fewer results if you say ask for 1000 per page? (thinking that would be useful if they lower then limit in the future)14:15
tobiashmordred: that was the outcome of yesterdays lunch firefighting ;)14:15
tobiashclarkb: yes, you can request 1000 but still get 10014:15
clarkbmickt: at the very least you should see the scheduler attempt to queue up some jobs14:16
tobiashmy first try was to request 1000 ;)14:16
clarkbtobiash: perfect (this way they can change without everyone needing to update zuul)14:16
tobiashyes14:16
micktok, so I need to look into 'gear.GearmanError: Unable to submit job to any connected servers'14:24
clarkbmickt: yup. My guess is that you don't have any executors running so no gearman workers are registered14:24
clarkbmickt: you can check that by connecting to port 4730 on the scheduler and entering 'status' without the quotes (thats a gearman command to get back status info including registered jobs)14:25
openstackgerritMerged openstack-infra/zuul master: Support pagination in the installation map  https://review.openstack.org/55039314:37
tobiash\o/14:48
*** electrofelix has quit IRC14:51
*** swest has quit IRC14:51
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Add nodepool provider back to job header  https://review.openstack.org/55049315:01
*** mhu has quit IRC15:02
*** pabelanger has quit IRC15:04
*** rlandy has quit IRC15:09
*** rlandy has joined #zuul15:09
*** rlandy has quit IRC15:10
tobiashmordred: I've a comment on ^15:15
tobiashwould you agree?15:15
*** pabelanger has joined #zuul15:17
openstackgerritPaul Belanger proposed openstack-infra/zuul-jobs master: Fix lint issue with emit-job-header role  https://review.openstack.org/55050115:20
tobiashpabelanger: what is the correct way to remove an image?15:31
pabelangertobiash: remove from nodepool.yaml?15:31
tobiashI set the label to min-ready 0, then removed the label15:32
tobiashyes15:32
tobiashnow I thought, delete the images15:32
clarkbyou remove the image from all the pools first15:32
tobiashbut they are reuploaded15:32
pabelangeryah, you need to remove image from providers.pool15:32
pabelangerto stop uploads15:32
tobiashdoes it know how to delete it then?15:32
clarkbthat means don't upload this image to the pool15:32
clarkbtobiash: yes it will delete it too iirc15:32
pabelangeryup15:32
tobiashok, trying15:32
pabelangeryou might need to set max-servers: -1 for that image, to delete ready nodes15:33
pabelangerif you have any15:33
tobiashnodes are already gone15:33
pabelangerk15:33
pabelangerthen images: [] in providers.pool should delete them15:33
pabelangerShrews: mind a review adding test coverage in nodepool https://review.openstack.org/540916/15:36
tobiashpabelanger, clarkb: thanks, worked15:37
pabelangeryay15:37
tobiashand after that remove the diskimage?15:37
pabelangerwe really should update docs if lacking15:37
pabelangertobiash: nodepool-builder should, if no providers are using it15:37
tobiashah, it's already gone15:38
pabelangerwoot15:38
Shrewspabelanger: sure. i have several nodepool reviews that could use some love too15:49
Shrewspabelanger: hrm, i do not think that would pass a recheck. corvus made a change to default min_ready to 0 around that time15:52
pabelangeroh, right.15:53
pabelangerI can fix that15:53
Shrewspabelanger: oh, maybe it would. i was looking at the new config. i think it might still be ok15:54
Shrewspabelanger: +3'd15:54
pabelangerokay, if it fails, I can update15:55
Shrewsyep15:55
clarkbif it doesn't fail does that imply the test is also broken?15:55
*** myoung|ruck is now known as myoung|ruck|brb15:55
clarkb(eg not testing what we intend)15:55
Shrewsclarkb: no. only thing broken are my eyes15:56
Shrewsbtw, the zookeeper retry discussion in Zuul Discuss has been pretty eye opening to bugs in our code. very glad that was started15:57
Shrewsthanks tristanC!15:57
openstackgerritMerged openstack-infra/zuul-jobs master: Fix lint issue with emit-job-header role  https://review.openstack.org/55050115:58
pabelangeryah, I'd like to see us fix the start zuul-sceduler with zookeeper firewalled bug. Where kazoo.client will never retry a connection after a few attempts.15:59
Shrewspabelanger: i think we can fix that using part of tristanC's change for the initial connect. it's the code after connect that i have concerns with.16:06
pabelangerShrews: yah, that is what I suspected16:07
openstackgerritMerged openstack-infra/nodepool master: Add unit test for multiple launchers  https://review.openstack.org/54091616:12
ShrewsAnyone want to show these nodepool reviews some love? https://review.openstack.org/545867 , https://review.openstack.org/546303 , https://review.openstack.org/54837616:13
Shrews1st two are dead simple16:13
clarkbShrews: probably a good way for me to fight jet lag and get back into the swing of things. I will take a look16:13
Shrewsclarkb: thx!16:14
micktShould I have a running zuul-executor service or is it run as required?16:14
clarkbmickt: you will need a running zuul-executor service16:14
micktok16:14
dmsimardhttps://landscape.cncf.io/selected=zuul-ci \o/16:15
pabelangermickt: you likely also want zuul-web, zuul-fingergw.  zuul-merger would be optional, but maybe needed as you grow more projects / git operations16:17
*** myoung|ruck|brb is now known as myoung|ruck16:17
mordreddmsimard: \o/ indeed16:20
*** rlandy has joined #zuul16:23
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Add copy of emit-job-header to test header change  https://review.openstack.org/55051816:29
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Add nodepool provider back to job header  https://review.openstack.org/55049316:30
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Remove test-emit-job-header  https://review.openstack.org/55052116:31
*** tobasco is now known as tobasco|away16:35
*** weshay is now known as weshay|PTO16:38
openstackgerritMerged openstack-infra/nodepool master: Simplify launcher cleanup worker  https://review.openstack.org/54586716:38
openstackgerritMerged openstack-infra/nodepool master: Add additional builder debug logging  https://review.openstack.org/54630316:47
clarkbShrews: for 548376 a couple of questions. Why does the label list need to be sorted? (you chose not to use a set because you can't sort them but its not clear to me why sorting is necessary). And if A provider is removed from the launcher config we don't seem to remove the registration from zookeeper? we will remove it when the launcher loses its connection to zk due to the ephemeral = true though16:59
Shrewsclarkb: good questions. I think I wanted them always sorted for comparison purposes, mostly. Though I'm sure we'd also want them sorted during display too. For the 2nd question, that's a good point. When we register, we aren't considering the labels from the provider sections, only what labels are defined in the outer 'labels' config. I suppose it's possible to have a label defined there that actually isn't17:05
Shrewssupplied by a provider?17:05
clarkbShrews: ya I think that is my concern that we'll tell zuul that we support a label but not actually be able to boot one17:05
clarkbright now its "ok" because we don't really have a contract with zuul on what is available it just asks for stuff and gets what it can17:06
Shrewsclarkb: let me put some thought into that bit. i want to see if nodepool will reject a label that isn't used in a provider (don't think it does), and if it doesn't, see if i can only pull the ones that we can really supply17:07
Shrewsclarkb: feel free to -1 for that if you want17:08
clarkbok will do17:08
Shrewsclarkb: thanks for reviewing17:08
micktSo of all the zuul services, which should be always running? Currently I have scheduler, merger & executor.17:24
clarkbmickt: the bare minimum is scheduler and executor I think. The executor will act as its own merge if there is not explicit merger service. And all the web stuff is for ux but shouldn't prevent jobs from running17:25
tobiashmickt: if you connect to github also zuul-web is a must17:25
tobiashif not it is a *really want have*17:25
tobiashmerger is optional and only needed for scaling17:26
pabelangerzuul-fingergw allows for streaming jobs too17:26
*** myoung|ruck is now known as myoung|lunch17:40
*** jpena is now known as jpena|off17:42
*** abadger1999 has left #zuul18:39
*** myoung|lunch is now known as myoung|ruck18:49
*** harlowja has joined #zuul19:26
SpamapSwas zuul-fingergw built into scheduler before?19:39
SpamapSI need to rebase my local stack and rework my ansible if so. :-P19:39
tobiashSpamapS: no, it never was19:40
clarkbSpamapS: I don't think it existed atall instead you had to talk to the executors finger port directly19:40
clarkbSpamapS: fingergw basically acts as a multiplexor for finger to the executors and is new19:40
tobiashSpamapS: it was already a separate daemon when it was introduced19:40
clarkbthis allows you to run the executors on non privileged ports too which is nice19:41
SpamapSclarkb: OH ok19:42
SpamapSI only have one executor. ;)19:42
tobiashSpamapS: but the javascript zuul-web stuff has landed so you might want to check if you have to change something for zuul-web deployment19:42
tobiashe.g. yarn is a new dependency19:43
SpamapSYeah I'll have to adapt some19:49
SpamapShttp://paste.openstack.org/show/693716/19:49
SpamapSI think ultimately it gets simpler. :)19:49
SpamapSI just wish we had like, a linux distro that wasn't so dang slow *cough*centos7*cough*19:50
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Store label info with launcher registration  https://review.openstack.org/54837619:52
Shrewsclarkb: i think that ^ will get us what we want19:53
clarkbShrews: cool I'll rereview now19:53
Shrewsclarkb: i also changed to using a set() instead of list() for the labels19:53
clarkbShrews: the check for static vs openstack looks like maybe a bug in our driver interface? (probably not something to fix in this cahnge but something to address before we add a bunch of drivers)19:54
tobiashSpamapS: with the latest zuul-web changes you probably can just skip almost all of your paste ;)19:55
Shrewsclarkb: well, not really a bug so much as each can have a unique configuration19:55
clarkbShrews: ya maybe it shouldn't be unique for the label mapping?19:55
clarkbor maybe we need a driver function to get the labels from it?19:56
Shrewsclarkb: or at least an API call we can depend on to return us that info, yeah19:56
ShrewstristanC: ^^^19:56
Shrewsall new territory  :)19:56
clarkbas a user it might be nice to have some uniformity to the config but I can already foresee that some drivers will be different enough that configs won't all be so similar. Happy to go either way on that one but a driver api for get labels probably the most flexible option19:58
tobiashShrews: are the labels from the pools really sufficient?19:58
Shrewstobiash: are they not?19:58
tobiashwe also have the globally defined labels19:58
tobiashwhere min-ready is defined19:58
tobiashif a label is missing there but defined in a pool, will that be available?19:59
clarkbtobiash: thats a good question19:59
tobiashor is that a config error?19:59
clarkbI woudl expect that to be a config error19:59
Shrewsi thought that would be a config error19:59
Shrewsmaybe not?19:59
clarkbbut I'm not sure that is current behavior19:59
clarkbShrews: you can probably update your test to test that really quickly19:59
Shrewsi get a KeyError from the fake/openstack driver20:01
clarkbcool I think it does the right thing in that situation then20:01
clarkbleft a comment about the driver api thing, but otherwise +220:02
Shrewsstatic driver also gives me a KeyError, but I don't think our config validator catches that for either (doesn't for static)20:03
tobiashyah, defining a non-existent label in a pool should crash here: http://git.openstack.org/cgit/openstack-infra/nodepool/tree/nodepool/driver/openstack/config.py#n20520:04
*** mickt has quit IRC20:47
*** hashar has quit IRC21:00
Shrewsoh yay, that's a fun error from the launcher change. i wonder if i should just log.error() when an invalid driver is encountered, rather than raise an exception?21:40
clarkbShrews: that might make it easier for tristanc to carry patches locally too until we merge more drivers (and fix the config loading of labels thing)21:40
Shrewsclarkb: tobiash: thoughts on that? for reference, http://logs.openstack.org/76/548376/2/check/tox-py35/e68a44b/job-output.txt.gz#_2018-03-07_20_01_55_65777021:40
Shrewsclarkb: yeah21:41
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Store label info with launcher registration  https://review.openstack.org/54837621:42
Shrewsthat failed test passes locally with that change21:43
tobiashShrews: lgtm21:46
tobiashmordred: I have totally no idea of ejs, but could it be that the '-' breaks this?21:54
tobiash<td>{{ tenant.queue-size }}</td>21:54
tobiashI found no other difference to the number of projects21:54
clarkbShrews: one last thought on that is I think this updates the zk api between nodepool and zuul so we should probably consider writing that down somewhere. But probably not in this change? I think current docs of that are the zuul v3 spec?21:55
clarkbShrews: I've approved the change21:56
Shrewsclarkb: this doesn't affect anything between zuul and nodepool, but yes, the only docs we have of that are the v3 spec21:57
Shrewsclarkb: this will be used by the nodepool webapp for /label_list21:57
clarkbShrews: oh I was expecting this to be used by zuul to not queue jobs indefinitely if no providers provide the label21:57
Shrewssomething more formal is definitely called for, though. along with a proper library21:57
Shrewsclarkb: zuul *could* use it21:58
mordredtobiash: oh - maybe so? I was actually planning some follow-up work to switch those files away from using the ejs processor since we don't actually use ejs at all21:58
Shrewsbut doubt it will21:58
mordredtobiash: I'll get some patches up for that as soon as I'm done with my current thing21:58
mordredtobiash: (those should be angular substitutions rather than ejs substitutions, but the fact that the files are in .ejs files makes the situation confusion I believe21:59
tobiashmordred: I'll just try queue instead of queue-size22:00
mordredcool22:00
tobiashbut will try that tomorrow22:02
tobiashtoo late here..22:02
tobiashcya22:02
*** openstackstatus has quit IRC22:13
*** openstack has joined #zuul22:17
*** ChanServ sets mode: +o openstack22:17
*** openstackstatus has quit IRC22:42
*** openstack has joined #zuul22:46
*** ChanServ sets mode: +o openstack22:46
openstackgerritMonty Taylor proposed openstack-infra/zuul master: Actually honor the static_path config value  https://review.openstack.org/55063622:53
*** myoung|ruck is now known as myoung|off23:11
*** threestrands has joined #zuul23:12
openstackgerritMerged openstack-infra/zuul master: Actually honor the static_path config value  https://review.openstack.org/55063623:23
*** threestrands_ has joined #zuul23:34
*** threestrands_ has quit IRC23:34
*** threestrands_ has joined #zuul23:34
*** threestrands_ has quit IRC23:35
*** threestrands_ has joined #zuul23:36
*** threestrands has quit IRC23:36
*** rlandy is now known as rlandy|bbl23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!