Friday, 2018-02-16

openstackgerritIan Wienand proposed openstack-infra/zuul master: nodepool-integration fixes  https://review.openstack.org/54516300:05
openstackgerritIan Wienand proposed openstack-infra/zuul master: nodepool-integration fixes  https://review.openstack.org/54516300:22
SpamapSI feel like there's something that I've done wrong that has made my nodepool and zuul relationship very laggy00:24
SpamapSI have plenty of ready nodes sometimes... but it takes 5+ minutes for that request to be fulfilled00:24
clarkbare the ready nodes all in one provider and the other provider is grabbing the request locks first?00:25
SpamapSyes00:26
SpamapSoh wait no00:26
SpamapSI misread that00:26
SpamapSI have two providers, one set at 0 max-servers, the other at 7500:26
clarkbthe other thing to watch out for is ready nodes label not matching the request node types so they are ignored00:26
SpamapS(this is so that I can fail over if need be)00:26
SpamapSSo most requests say they were rejected by the 0-'d provider fairly quickly00:27
SpamapSNo in the logs I see the launcher saying it has them as Active00:27
SpamapSjust seems like they don't get into a state that they're given back to Zuul for a long time00:27
SpamapSmaybe there's stuff not in the log that it's doing that is important.00:27
clarkbwhat should happen roughly is both provider threads in nodepool poll for new requests. First one with max-servers 0 will decline it due to max servers count. The second will then pick it up and if it has enough ready nodes of the correct type it will hand those over to zuul immediately. Otherwise it boots new instances and then hands them over00:29
clarkbif booting new instances ~5 minutes is probably not an uncommon time to ready period00:29
clarkbbut I would expect no more than a few seconds if handing over existing nodes00:29
clarkbSpamapS: I would check and see if the ready nodes are actually being used or if they are "stuck" and getting stale (probably the timestamp associated with them is sufficient to tell)00:31
SpamapSclarkb: often I see nodes built for the request, and then they sit in 'ready' for a few minutes00:35
SpamapSI have a 5-node job, and 3 AZ's, so even with 15 min-ready, sometimes I don't have 5 in the zone it chooses, and it has to build00:35
SpamapSinstances usually boot within 2 minutes.. but yeah, just seems like it sits there for a while after that00:36
SpamapSwhat I really need is to setup a statsd and see what those stats tell me00:36
openstackgerritIan Wienand proposed openstack-infra/zuul master: nodepool-integration fixes  https://review.openstack.org/54516300:38
openstackgerritPaul Belanger proposed openstack-infra/nodepool master: Use $NODEPOOL_KEY_NAME for dsvm testing  https://review.openstack.org/54517600:39
pabelangerSpamapS: yah, statsd should help see what is going on.00:40
clarkbalso the ready -> in-use transition is done by zuul when it actualyl starts to execute the job00:42
clarkbcould be some slowness on the zuul side maybe?00:42
clarkb"Executing jobs for change %s" is the debug string for when that happens00:43
clarkbmaybe see hwo far apart those are00:43
*** elyezer has quit IRC00:46
*** elyezer has joined #zuul00:46
openstackgerritIan Wienand proposed openstack-infra/zuul master: nodepool-integration fixes  https://review.openstack.org/54516300:49
*** persia has joined #zuul00:54
*** elyezer has quit IRC00:56
*** elyezer has joined #zuul00:57
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make NodeSetParser a regular class  https://review.openstack.org/54514801:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SecretParser a regular class  https://review.openstack.org/54514901:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make JobParser a regular class  https://review.openstack.org/54515001:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make PipelineParser a regular class  https://review.openstack.org/54515101:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SemaphoreParser a regular class  https://review.openstack.org/54515201:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make TenantParser a regular class  https://review.openstack.org/54515301:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ConfigLoader initializer  https://review.openstack.org/54518001:00
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove tenant argument from UnparsedTenantConfig  https://review.openstack.org/54518101:00
*** rlandy|rover|bbl is now known as rlandy|rover01:07
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515801:12
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515801:14
openstackgerritPaul Belanger proposed openstack-infra/nodepool master: Use $NODEPOOL_KEY_NAME for dsvm testing  https://review.openstack.org/54517601:18
openstackgerritPaul Belanger proposed openstack-infra/nodepool master: Add opensuse-tumbleweed to nodepool dsvm testing  https://review.openstack.org/54518301:18
*** JasonCL has quit IRC01:19
*** JasonCL has joined #zuul01:20
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515801:27
*** rlandy|rover is now known as rlandy|rover|bbl01:31
*** JasonCL has quit IRC01:36
*** JasonCL has joined #zuul01:37
*** JasonCL has quit IRC01:41
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515801:45
*** elyezer has quit IRC01:55
*** elyezer has joined #zuul01:57
*** elyezer has quit IRC02:05
*** elyezer has joined #zuul02:06
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515802:23
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515802:38
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515802:46
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515802:59
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Add legacy-copy-jenkins-scripts  https://review.openstack.org/54515803:18
*** harlowja_ has quit IRC03:23
*** rlandy|rover|bbl is now known as rlandy|rover03:27
openstackgerritIan Wienand proposed openstack-infra/zuul master: nodepool-integration fixes  https://review.openstack.org/54516303:28
*** rlandy|rover has quit IRC03:29
*** elyezer has quit IRC03:34
*** elyezer has joined #zuul03:37
*** jaianshu has joined #zuul03:46
*** JasonCL has joined #zuul03:55
*** JasonCL has quit IRC04:00
openstackgerritIan Wienand proposed openstack-infra/zuul master: Fix nodepool-zuul-functional  https://review.openstack.org/54516304:33
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Fix nodepool-zuul-functional  https://review.openstack.org/54515804:33
*** harlowja has joined #zuul04:46
openstackgerritIan Wienand proposed openstack-infra/zuul master: Fix nodepool-zuul-functional  https://review.openstack.org/54516304:50
openstackgerritIan Wienand proposed openstack-infra/zuul master: Add nodepool-zuul-functional as non-voting check job  https://review.openstack.org/54520304:50
*** harlowja has quit IRC04:59
*** harlowja has joined #zuul05:19
*** harlowja has quit IRC05:27
openstackgerritMerged openstack-infra/nodepool master: Use $NODEPOOL_KEY_NAME for dsvm testing  https://review.openstack.org/54517605:44
*** abadger1999 has quit IRC06:13
*** abadger1999 has joined #zuul06:13
*** threestrands has quit IRC06:20
*** openstackstatus has quit IRC06:27
*** openstack has joined #zuul06:31
*** ChanServ sets mode: +o openstack06:31
*** elyezer has quit IRC06:53
*** elyezer has joined #zuul06:57
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Use bindep for nodepool-zuul-functional  https://review.openstack.org/54521907:06
*** elyezer has quit IRC07:07
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove install-distro step for nodepool integration  https://review.openstack.org/54522107:08
*** elyezer has joined #zuul07:08
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Remove copying of legacy install-distro script  https://review.openstack.org/54522207:09
*** threestrands has joined #zuul07:22
*** threestrands has quit IRC07:22
*** threestrands has joined #zuul07:23
*** threestrands has quit IRC07:23
*** threestrands has joined #zuul07:23
*** JasonCL has joined #zuul07:27
*** JasonCL has quit IRC07:32
*** threestrands has quit IRC07:34
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Fix nodepool-zuul-functional  https://review.openstack.org/54515807:38
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Fix nodepool-zuul-functional  https://review.openstack.org/54515807:39
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove install-distro step for nodepool integration  https://review.openstack.org/54522107:40
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Remove copying of legacy install-distro script  https://review.openstack.org/54522207:40
AJaegerianw: but yes, once we remove zuul-cloner for non-legacy jobs, it will fail again - so needs to be done07:41
AJaegerianw: let's merge tools/nodepool-integration-setup.sh into the ansible playbook07:44
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Avoid tools/nodepool-integration-setup.sh from zuul  https://review.openstack.org/54522807:52
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove tools/nodepool-integration-setup.sh  https://review.openstack.org/54522907:52
*** elyezer has quit IRC07:55
*** elyezer has joined #zuul07:56
openstackgerritAndreas Jaeger proposed openstack-infra/nodepool master: Avoid tools/nodepool-integration-setup.sh from zuul  https://review.openstack.org/54522807:57
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove install-distro step for nodepool integration  https://review.openstack.org/54522107:58
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove tools/nodepool-integration-setup.sh  https://review.openstack.org/54522907:58
*** hashar has joined #zuul07:58
openstackgerritAndrea Frittoli proposed openstack-infra/zuul-jobs master: Improve file renaming in stage-output  https://review.openstack.org/54460608:04
*** jpena|off is now known as jpena08:41
*** JasonCL has joined #zuul09:32
*** JasonCL has quit IRC09:38
*** openstackgerrit has quit IRC10:18
*** JasonCL has joined #zuul10:26
*** elyezer has quit IRC10:27
*** JasonCL has quit IRC10:31
*** elyezer has joined #zuul10:40
*** JasonCL has joined #zuul10:52
*** JasonCL has quit IRC10:57
*** JasonCL has joined #zuul11:04
*** elyezer has quit IRC11:33
*** elyezer has joined #zuul11:41
*** jaianshu has quit IRC11:49
*** elyezer has quit IRC11:53
*** elyezer has joined #zuul11:55
kklimondaI have a small problem with zuul-scheduler - executor running jobs died (a problem with logrotate) and never reported back job results, and now scheduler just waits for them - even `lookForLostBuilds` is not doing anything - I'm running a "bit" behind master so it's quite possible that this has been fixed, but is there anything I can do to report to scheduler that those jobs are gone, or do should I just restart it?12:28
kklimondaI can probably upload a new patchset, and that should make scheduler cancel current jobs12:39
rcarrillocruzsomeone mentioned ( i think pabelanger ? ) that there was a patch for dequeue12:46
rcarrillocruznot sure if that would help, but still, a patch, nothing in tree12:46
rcarrillocruzzuul client just have enqueue/promote12:46
*** elyezer has quit IRC12:48
*** jpena is now known as jpena|lunch12:48
*** elyezer has joined #zuul12:51
*** openstackgerrit has joined #zuul12:58
openstackgerritRicardo Carrillo Cruz proposed openstack-infra/nodepool master: WIP Add Nodepool Ansible generic driver  https://review.openstack.org/54528612:58
* Shrews waves hello and attempts to catch up on all-the-things13:04
*** rlandy has joined #zuul13:37
*** rlandy is now known as rlandy|rover13:37
*** jpena|lunch is now known as jpena13:51
pabelangerkklimonda: yah, that is a known issue. Trying to find storey ATM. But, need to restart scheduler currently to clear it.14:01
pabelangerkklimonda: i think it is https://storyboard.openstack.org/#!/story/200089914:04
kklimondapabelanger: thanks, I'll try to get someone to upload a new patchset and see if scheduler decides to restart jobs, but will probably have to find a quiet moment to restart scheduler itself.14:18
kklimondaI'm not quite sure what exactly is zuul doing when "Looking for lost builds" messages is printed14:18
AJaegerianw yesterday started fixing the nodepool-zuul-integration tests and I piled on top of that - reviews of https://review.openstack.org/#/c/545163/ and https://review.openstack.org/#/c/545158/ are welcome by nodepool and zuul cores, please15:38
ShrewsAJaeger: i have to go give someone a ride, but will review when i return. also, one of ianw's fixes duplicates my https://review.openstack.org/540983 which already has two +2s15:47
Shrewsnot sure why it wasn't approved15:47
Shrewsbiab15:47
AJaegerShrews: approve it yourself once you're back...15:47
AJaegerI guess it was not approved since it still fails15:47
AJaegerI can rebase on yours...15:48
pabelangerHmm15:51
pabelangeranybody else get randon disconnects doing15:51
pabelangerfinger 5cd0434d23244c36a24532f1b102891b@zuul.openstack.org15:51
pabelangerrandomly I get stream internal error15:51
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Fix nodepool-zuul-functional  https://review.openstack.org/54516315:52
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Add nodepool-zuul-functional as non-voting check job  https://review.openstack.org/54520315:52
pabelangersorry, Internal stream error15:53
pabelangerthen connection drops15:54
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Fix nodepool integration tests  https://review.openstack.org/54098315:55
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Fix nodepool-zuul-functional  https://review.openstack.org/54516315:56
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove install-distro step for nodepool integration  https://review.openstack.org/54522115:59
openstackgerritAndreas Jaeger proposed openstack-infra/zuul master: Remove tools/nodepool-integration-setup.sh  https://review.openstack.org/54522915:59
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: zuul web: add admin endpoint, enqueue & autohold commands  https://review.openstack.org/53900416:11
*** elyezer has quit IRC16:11
*** elyezer has joined #zuul16:14
*** elyezer has quit IRC17:04
*** elyezer has joined #zuul17:16
clarkbthinking about post-run timeouts. One super simple fix would be to make post-run's timeout max(30 minutes, remaineder of job timeout) and just say you have half an hour to get that done17:36
clarkbnot a super fan of hardcoding here but thats like a failsafe for that case where you had your normal timeout run out17:36
pabelangerwe could also create pre-timeout, timeout, post-timeout settings for jobs, with sane defaults17:37
clarkbone concern I have with ^ is that we use pre like run in some places. iirc shade jobs run devstack in pre17:38
clarkbI kind of see pre and run being in the same timeout class as a result17:38
pabelangerhttp://paste.openstack.org/show/674728/17:40
pabelangerexplains Internal stream error17:40
pabelangernodepool jobs have sleep 1017:41
pabelangerand nothing is transmitted across stream17:41
clarkbpabelanger: so the jobs not writing anything results in the stream having no data to write?17:42
*** harlowja has joined #zuul17:55
pabelangerclarkb: yah, think so17:55
pabelangerI can look more in a moment17:55
Shrewspabelanger: i can see that happening if an executor finger daemon is gone due to oom17:57
Shrewsbut maybe that would happen sooner in the process... on connect. hrm17:58
pabelangerShrews: we actually shouldn't have the OOm issues any more, we replaced kernels this week. And so far no OOM17:58
Shrewsorly?17:59
pabelangerbut in this case, stream process is still running17:59
pabelangerShrews: https://review.openstack.org/544164/17:59
Shrewswell w00t w00t18:00
*** jpena is now known as jpena|off18:09
openstackgerritMerged openstack-infra/zuul master: Fix nodepool integration tests  https://review.openstack.org/54098318:12
corvusclarkb, pabelanger: so maybe we should just add a post-timeout attribute?18:19
pabelangerI'd be okay with that18:20
AJaegercorvus: yes - perhaps with a smaller limit  than our current timeout?18:21
corvusi don't think we have to have immediate symmetry.  pre and post really serve different functions, and pre+run certainly do have a tight relationship.  if we added a pre-timeout, i'd suggest maybe have it default to None, and that means the current behavior of "share the run timeout".  but then if you specify a pre-timeout, it would only apply to pre (that way you could say "if it takes more than 10m to18:21
corvusdownload from pypi, abort")18:21
AJaegerespecially on a 3 hour job ;)18:22
AJaegerI'm fine with post-timeout for now18:23
corvusand post-timeout, in all cases, only covers post.  that way, we set on the base job a 30m default post timeout.  it should never take longer than 30m to upload logs or publish a tarball or whatever.18:23
corvusbut if there's a 'publish diskimage to international space station' job, maybe we up it's post-timeout.18:23
clarkbya that makes sense to me18:24
corvusclarkb: do you want to hack on that?18:25
clarkbcorvus: ya I can take a stab at it18:25
corvuscool, thanks18:26
pabelanger789+56666666666666666666666666666666666666-************************************************************+633333333333333333333333333318:27
corvuspabelanger: you okay?18:28
AJaegerone * is multiplicate, ** is exponentiation but what's that crazy number of *s? ;)18:29
mordredcorvus: reading that - I kind of wonder if maybe post-timeout is a timeout for *each* post playbook would match the model better. if we timeout uploading a tarball we still want to upload logs18:33
pabelangercorvus: yah, sorry. kids got at keyboard. Didn't lock it18:33
corvusmordred: good point18:33
mordredcorvus: and in general post is designed so that all post playbooks get run regardless of status of previous one18:34
corvuspabelanger: glad you're okay!18:34
corvusclarkb: ^ fyi post18:34
clarkbmordred: corvus one problem with that approach is when one fails chances are high the rest will too18:34
clarkbso now you end up just hitting the timeout N times18:34
clarkbbut may be it pays to do our best to log anything in post18:35
mordredclarkb: I think we should do whatever we can do to ensure we do our best to upload logs no matter what18:36
mordredcause a job with missing logs is one of the more frustrating things18:36
corvusyeah, i mean, timeout is kind of a blunt instrument.  it's not going to be optimal for the "ansible+ssh sits there forever" case.  we really just need ansible+ssh to be better about that.18:36
corvusthe good news is that most post tasks aren't going to run of the main playbook has already timed out18:37
corvusso generally, if we're already in that situation, we shouldn't have too many things to run.18:38
mordred++18:40
Shrewscould we invent a new thing for 'post-logs'?18:41
Shrewsmaybe that muddies the water a bit though18:41
*** harlowja has quit IRC18:44
clarkbcurrently it appears that if you don't set a timeout we don't have a timeout at all. Do we want post-timeout to act the same way? default is don't timeout at all?18:44
*** harlowja has joined #zuul18:48
*** weshay is now known as weshay|bbiab18:50
corvusclarkb: that seems reasonable18:54
openstackgerritClark Boylan proposed openstack-infra/zuul master: Add post-timeout setting  https://review.openstack.org/54543919:02
clarkbthats a rough first draft. I need to figure out how to test that properly. But should give people an idea of what the behavior I think we should have is (so we can determine if that behavior makes sense)19:03
*** harlowja has quit IRC19:10
corvusclarkb: i think TestAnsible.test_playbook has a timeout test19:10
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make NodeSetParser a regular class  https://review.openstack.org/54514819:22
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SecretParser a regular class  https://review.openstack.org/54514919:22
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make JobParser a regular class  https://review.openstack.org/54515019:22
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make PipelineParser a regular class  https://review.openstack.org/54515119:22
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SemaphoreParser a regular class  https://review.openstack.org/54515219:23
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make TenantParser a regular class  https://review.openstack.org/54515319:23
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ConfigLoader initializer  https://review.openstack.org/54518019:23
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove tenant argument from UnparsedTenantConfig  https://review.openstack.org/54518119:23
pabelangerclarkb: dmsimard: fungi: should we just delete the old volumes now for logs.o.o? We haven't copied over any data, and I think we're pretty much at 30days now19:25
pabelangerthey are still attached to temp logs server19:26
fungipabelanger: my vote is yes. at this point they're probably almost all past their use-by date19:27
fungialso, you probably meant to ask that in #openstack-infra19:28
pabelangerdoh, yah. asked in wrong room19:28
pabelangerapologies19:28
*** weshay|bbiab is now known as weshay19:50
*** harlowja has joined #zuul19:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make JobParser a regular class  https://review.openstack.org/54515020:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make PipelineParser a regular class  https://review.openstack.org/54515120:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SemaphoreParser a regular class  https://review.openstack.org/54515220:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make TenantParser a regular class  https://review.openstack.org/54515320:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ConfigLoader initializer  https://review.openstack.org/54518020:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove tenant argument from UnparsedTenantConfig  https://review.openstack.org/54518120:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ParseContext class  https://review.openstack.org/54544820:26
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Fix typo in PragmaParser  https://review.openstack.org/54544920:32
openstackgerritMerged openstack-infra/zuul master: Make NodeSetParser a regular class  https://review.openstack.org/54514820:32
openstackgerritMerged openstack-infra/zuul master: Make SecretParser a regular class  https://review.openstack.org/54514920:32
openstackgerritClark Boylan proposed openstack-infra/zuul master: Add post-timeout setting  https://review.openstack.org/54543920:43
clarkbcorvus: ^ test_playbook was indeed 95% of the way there so I just updated it to check this new stuff20:43
corvusclarkb: lgtm20:54
clarkband zuul +1'd it too woot21:02
pabelangerlooking21:03
clarkbI think for ^ we will have to update the scheduler first then restart the clients21:18
clarkbbecause we need to make sure there is a post_timeout value in the executor client args data before the executor server reads it21:18
openstackgerritMerged openstack-infra/zuul master: Add post-timeout setting  https://review.openstack.org/54543921:23
openstackgerritMerged openstack-infra/zuul master: Add host/group vars  https://review.openstack.org/54456221:27
*** hashar has quit IRC21:47
*** JasonCL has quit IRC22:01
*** JasonCL has joined #zuul22:08
*** rlandy|rover has quit IRC22:13
*** JasonCL has quit IRC22:17
*** JasonCL has joined #zuul22:21
*** JasonCL has quit IRC22:30
*** JasonCL has joined #zuul22:42
*** JasonCL has quit IRC22:47
*** JasonCL has joined #zuul23:03
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make PipelineParser a regular class  https://review.openstack.org/54515123:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SemaphoreParser a regular class  https://review.openstack.org/54515223:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make TenantParser a regular class  https://review.openstack.org/54515323:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ConfigLoader initializer  https://review.openstack.org/54518023:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove tenant argument from UnparsedTenantConfig  https://review.openstack.org/54518123:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ParseContext class  https://review.openstack.org/54544823:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Fix typo in PragmaParser  https://review.openstack.org/54544923:07
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove project.unparsed_config  https://review.openstack.org/54548523:07
corvusthat last change is a memory-use reduction.  in my local test, it reduces use by about 50% after several reconfigurations.  i still have more changes planned.23:09
clarkbnice23:10
pabelangerwow23:10
clarkbguess I should try and review that stack again23:10
corvusi ran pep8, test_model, and test_jobs_executed locally, so i think they should pass23:11
*** JasonCL has quit IRC23:12
*** weshay is now known as weshay_PTO23:14
*** JasonCL has joined #zuul23:14
*** JasonCL has quit IRC23:19
fungiwoah, 50% memory reduction on reconfigs?!?23:32
clarkbcorvus: supposedly https://review.openstack.org/#/c/545150/4 cannot merge due to a path change?23:33
clarkbzuul was happy with it thoug23:33
clarkboh also it will need a rebase for my new timeout I think?23:34
clarkbhttps://review.openstack.org/#/c/545150/4/zuul/configloader.py the code around line 636 there was updated to add post-timeout23:35
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make JobParser a regular class  https://review.openstack.org/54515023:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make PipelineParser a regular class  https://review.openstack.org/54515123:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make SemaphoreParser a regular class  https://review.openstack.org/54515223:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Make TenantParser a regular class  https://review.openstack.org/54515323:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ConfigLoader initializer  https://review.openstack.org/54518023:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove tenant argument from UnparsedTenantConfig  https://review.openstack.org/54518123:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add ParseContext class  https://review.openstack.org/54544823:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Fix typo in PragmaParser  https://review.openstack.org/54544923:50
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Remove project.unparsed_config  https://review.openstack.org/54548523:50
*** JasonCL has joined #zuul23:53
*** JasonCL has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!