Friday, 2018-01-26

openstackgerritMerged openstack-infra/zuul-jobs master: Add flag for turning off successful job logs  https://review.openstack.org/53798600:01
corvusmordred: ^00:02
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add initial website content and jobs  https://review.openstack.org/53803900:14
*** rcarrillocruz has quit IRC00:15
*** rlandy|biab is now known as rlandy00:50
*** JasonCL has quit IRC00:52
tristanCcorvus: maybe with https://stackoverflow.com/questions/824349/modify-the-url-without-reloading-the-page ?00:53
*** JasonCL has joined #zuul00:53
*** JasonCL has quit IRC00:58
*** JasonCL has joined #zuul00:59
tristanCcorvus: also an ui update could also enable stacking the filters, it's possible to do project=zuul&project=zuul-jobs for example01:03
corvustristanC: yeah, that sounds fine -- i think this is a fine thing to update the history with too (ie, the back button takes you to the previous query)01:04
corvustristanC: oh, neat, i didn't know about that url trick01:05
tristanCcorvus: is the js makefile thing in the scope of the 3.0 release?01:05
corvustristanC: yeah, mordred's tooling patch is (so we have an automatable way to deploy the static stuff)01:06
corvustristanC: i think it's really close too -- last iteration only had a few things that needed fixing01:06
tristanCcorvus: ok good, then i'll rebase my changes on top of it01:06
corvustristanC: last i looked it hadn't been re-proposed to master01:07
tristanCcorvus: fwiw i've been working on some d3 representations, here is a preview of the job graph: http://38.145.32.112/zuul/local/jobs.html (see the 'toggle graph' button on top right)01:07
corvustristanC: that's cool!01:08
tristanCcorvus: similarly for project pipeline, this one is fun to play with: http://38.145.32.112/zuul/local/project.html?project_name=zuul-distgit01:08
corvustristanC: i bet it's not going to scale to big systems though, so it may be worth thinking about how to keep that managable.  like maybe rather than drawing the whole system, when you're on a job, draw only its graph.01:09
tristanCcorvus: definitely, it's just experiment with d3 to see what could we do with the rest data01:10
corvustristanC: ++ it has potential :)01:11
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add initial website content and jobs  https://review.openstack.org/53803901:14
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Use yarn and webpack to manage zuul-web javascript  https://review.openstack.org/53809901:23
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add initial website content and jobs  https://review.openstack.org/53803901:24
*** yolanda has quit IRC01:30
*** JasonCL has quit IRC02:01
*** harlowja has quit IRC02:16
*** JasonCL has joined #zuul02:31
*** JasonCL has quit IRC02:37
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Use yarn and webpack to manage zuul-web javascript  https://review.openstack.org/53809903:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Add babel transpiling enabling use of ES6 features  https://review.openstack.org/53812503:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Add StandardJS linting and analysis  https://review.openstack.org/53812603:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Fix source_url handling for jobs view  https://review.openstack.org/53812703:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Fix StandardJS warnings and turn them to errors  https://review.openstack.org/53812803:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Add bundle analysis to the lint target  https://review.openstack.org/53812903:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Inject url endpoint information  https://review.openstack.org/53813003:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Make bundle of build web content  https://review.openstack.org/53813103:10
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Remove use strict  https://review.openstack.org/53813203:10
*** JasonCL has joined #zuul03:37
*** JasonCL has quit IRC03:47
*** JasonCL has joined #zuul04:02
*** JasonCL has quit IRC04:06
*** JasonCL has joined #zuul04:39
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add /{tenant}/jobs/{job_name} route  https://review.openstack.org/53554504:41
*** JasonCL has quit IRC04:43
*** harlowja has joined #zuul04:51
*** JasonCL has joined #zuul04:56
*** JasonCL has quit IRC05:00
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add jobs graph rendering  https://review.openstack.org/53786905:17
*** JasonCL has joined #zuul05:26
*** JasonCL has quit IRC05:31
*** JasonCL has joined #zuul05:44
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: /{tenant}/projects.json routes  https://review.openstack.org/53787005:49
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add project pipeline rendering  https://review.openstack.org/53787105:49
*** JasonCL has quit IRC05:55
*** JasonCL has joined #zuul06:07
*** JasonCL has quit IRC06:12
*** JasonCL has joined #zuul06:29
*** JasonCL has quit IRC06:33
*** JasonCL has joined #zuul06:43
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Fix cross source dependencies for github  https://review.openstack.org/53742806:44
*** JasonCL has quit IRC06:48
tobiashcorvus: I'm currently rethinking the parent-change-enqueued and neededby check for github apps06:49
tobiashhttp://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/driver/github/githubconnection.py#n73006:49
tobiashcorvus: what do you think about making that tenant scoped?06:49
tobiashcorvus: that should make that operation much cheaper in multi tenant environments like ours06:50
tobiashcorvus: and I think sacrificing cross-tenant parent-change-enqueued events would be ok in comparison to not being able to use parent-change-enqueued06:51
*** rlandy has quit IRC06:57
*** harlowja has quit IRC07:23
*** JasonCL has joined #zuul07:24
*** JasonCL has quit IRC07:29
*** rcarrillocruz has joined #zuul07:47
*** elyezer has quit IRC08:01
*** elyezer has joined #zuul08:13
*** JasonCL has joined #zuul08:19
*** JasonCL has quit IRC08:23
*** JasonCL has joined #zuul08:40
*** jpena|off is now known as jpena08:43
*** JasonCL has quit IRC08:44
*** JasonCL has joined #zuul09:02
*** JasonCL has quit IRC09:07
*** Cibo has quit IRC09:16
*** electrofelix has joined #zuul09:53
*** JasonCL has joined #zuul09:56
*** JasonCL has quit IRC10:03
*** Cibo has joined #zuul10:18
*** JasonCL has joined #zuul10:57
*** JasonCL has quit IRC11:06
*** sshnaidm|off has quit IRC11:11
*** sshnaidm has joined #zuul11:12
*** JasonCL has joined #zuul11:16
*** jkilpatr has quit IRC11:24
*** JasonCL has quit IRC11:25
*** JasonCL has joined #zuul11:33
*** JasonCL has quit IRC11:39
*** jkilpatr has joined #zuul11:59
*** elyezer has quit IRC12:24
*** elyezer has joined #zuul12:37
*** jpena is now known as jpena|lunch12:39
*** JasonCL has joined #zuul12:53
*** JasonCL has quit IRC13:00
*** elyezer has quit IRC13:03
*** elyezer has joined #zuul13:05
dmsimardtobiash, tristanC: created another zuul-web story https://storyboard.openstack.org/#!/story/2001502 -- "Additional build filters for date and status"13:05
*** JasonCL has joined #zuul13:08
*** rlandy has joined #zuul13:34
*** jpena|lunch is now known as jpena13:45
*** dmellado has joined #zuul13:59
tobiashyay http header case conversions14:06
tobiashgithub webhook tests work, reality not...14:06
tobiashlooks like every http framework messes with header casing and each does it differently14:20
*** yolanda has joined #zuul14:54
openstackgerritMerged openstack-infra/nodepool master: Split out erasing from 'info' command into 'erase'  https://review.openstack.org/53766314:57
Shrewsoh the joys of tox on a Friday: [Errno 25] Inappropriate ioctl for device15:31
dmsimardtobiash: btw we merged the fixes for zuul jobs log uploading now15:33
dmsimardtobiash: is everything ok ?15:33
tobiashdmsimard: thanks15:33
tobiashI personally was not affected as we work with a local mirror15:34
tobiashbut perhaps other people like tristanC work directly with upstream zuul-jobs15:34
mordredtobiash: SOOO ...15:35
corvusat the very least, it meant your couldn't update your local mirror15:35
dmsimardOk, we'll try to be more careful15:35
dmsimardThanks for calling us out on it :)15:35
tobiashcorvus: yeah, we hadn't time to automate that yet ;)15:35
corvustobiash: when you say tenant scoped for needed-by -- you mean: get the installations for all projects in the tenant and search with all of them?  i think that's okay.15:36
corvustobiash: also, i had a conversation with mordred a while ago about the idea of making the change cache persistent (eg, in zookeeper, maybe?) and then potentially relying on that for that query.  that's a long ways off, but i consider anything we do now for this to be a temporary compromise.15:38
mordred++15:38
tobiashcorvus: Yes I mean that15:39
tobiashhrm, now I have a really working webhook over zuul-web and I cannot get that patch through our proxy :/15:41
dmsimardthe zuul autokeep feature I suggested would be quite useful right about now..15:45
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Move github webhook from webapp to zuul-web  https://review.openstack.org/53571115:48
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Move status_url from webapp to web section  https://review.openstack.org/53677315:48
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Remove webapp  https://review.openstack.org/53678015:48
* tobiash shakes fist at mandatory authenticating proxy15:48
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add web server URL tests  https://review.openstack.org/53829115:50
corvustristanC: if you're taking over mordred's yarn/webpack changes -- we need that test ^ to pass before we can merge it.  it currently doesn't, which means that we're not able to actually serve the static content at some urls.15:51
corvustristanC: we also need to update that change to include the submount rewrite you use in softwarefactory15:52
tristanCcorvus: mordred: i didn't meant to take over the yarn thing, i just restore the patch to rebase the new dashboard pages. i may have some time to have a look at it next week15:53
tristanCcorvus: what do you mean by subomunt rewrite?15:53
corvustristanC: can you point me at your rewrite rules again?15:54
corvus(i know you did this 2 weeks ago, but i lost track, sorry)15:54
Shrewswould someone like to +3 tobiash's change here: https://review.openstack.org/537776  It's going to conflict with a change I want to get in, and it's and easy review15:55
Shrewsan* easy review15:55
corvusShrews: will do15:55
Shrewscorvus: thank you15:55
tristanCcorvus: the current apache configuration is https://softwarefactory-project.io/r/gitweb?p=software-factory/sf-config.git;a=blob;f=ansible/roles/sf-gateway/templates/gateway.common.j2;hb=HEAD#l16615:55
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Add web server URL tests  https://review.openstack.org/53829115:57
corvustristanC: there we go ^ take a look at the last class - TestSuburl15:58
tristanCcorvus: though this apache configuration we'll be mostly rewritten to accomodate the new bundled js stuff, either still hosted on the gateway, or just entirely proxy passed to zuul-web15:59
corvustristanC: right -- that test should verify that if you entirely proxy to zuul-web, the bundled js will actually be served.16:00
corvusright now, i believe there's a bug that will cause at least some of those tests to fail.16:01
mordredtristanC, corvus: yah - I'll jump on fixing that stack next week16:01
corvusmordred: cool.  that test should be ready to go -- at least, it has a really basic check for all 3 ways of hosting16:02
tristanCcorvus: mordred: thanks, i'll test this out more thorougly next week16:02
*** myoung|pto has quit IRC16:09
openstackgerritMerged openstack-infra/nodepool master: Default max pool resources to math.inf  https://review.openstack.org/53777616:09
tristanCcorvus: fwiw i used this temporary configuration to plug the npm dev server https://softwarefactory-project.io/paste/show/956/ , not sure if it's already documented/supported16:10
dmsimardmordred: before I go on and fix what I think is a bug.. where did you retrieve that exit code 4 from ? https://github.com/openstack-infra/zuul/blob/master/zuul/executor/server.py#L141516:12
dmsimardmordred: looks to me like exit 4 is about unreachable hosts https://github.com/ansible/ansible/blob/stable-2.3/lib/ansible/executor/task_queue_manager.py#L62-L6716:12
*** myoung has joined #zuul16:13
mordreddmsimard: I *believe* that was from experience?16:13
mordreddmsimard: yah - just tested ... an unparseable yaml returns 416:14
dmsimardo_O16:14
mordreddmsimard: http://paste.openstack.org/show/653664/16:15
mordreddmsimard: it's certainly possible/likely that they're re-using an exit code16:15
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Do not attempt to handle requests when disabled  https://review.openstack.org/53795416:17
mordreddmsimard: I have also verified a 4 returned from an invalid host16:17
mordreddmsimard: http://paste.openstack.org/show/653665/16:17
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Update docs to reflect newer Python requirement.  https://review.openstack.org/53829616:22
Shrewsoopsie in the docs ^^^16:23
dmsimardmordred: re-using the same exit codes for different things is bad16:30
dmsimardincidentally, I was investigating a playbook that failed with exit code 2 which isn't handled by the executor16:30
mordreddmsimard: oh, fascinating16:42
dmsimardmordred: yeah, this one: http://paste.openstack.org/raw/653651/16:45
pabelangerI also had no luck trying to ignore_errors for UNREACHABLE, and confirm just returns -4 from ansible-playbook16:45
dmsimardmordred: I have nothing to work with in the logs, that's like all I have. I have no idea what failed and why it failed -- it's a release job so even requeuing it (especially without the zuul inventory file) is not trivial16:45
pabelangerdmsimard: which executor?16:48
pabelangerlooks like exit code 216:48
pabelangerthen we failed to upload logs,16:49
dmsimardpabelanger: yeah but exit code 2 isn't handled here: https://github.com/openstack-infra/zuul/blob/master/zuul/executor/server.py#L1401-L144516:54
dmsimardand exit code 2 is ambiguous -- I asked #ansible-devel about it and they didn't really manage to explain it every well :)16:55
pabelangerright, exit 2 usually something failed on node, maybe executor16:56
pabelangerwould have to see what the playbook did16:56
dmsimardpabelanger: it's a313a980d05f4526aba5128189f45cd7 on ze05, I was investigating for dhellmann due to a release failure: http://lists.openstack.org/pipermail/release-job-failures/2018-January/000733.html17:01
pabelangerk, lets move back to openstack-infra17:03
dmsimardsure17:03
*** harlowja has joined #zuul17:10
*** jpena is now known as jpena|off17:30
*** jkilpatr has quit IRC17:56
tobiashShrews: any idea how I fix a node which is ready but locked?18:00
tobiashI have one which is in that state since three hours18:00
*** yolanda has quit IRC18:01
*** rlandy is now known as rlandy|brb18:02
*** elyezer has quit IRC18:03
*** elyezer has joined #zuul18:15
*** Cibo has quit IRC18:19
corvustobiash: first thing is probably figure out who has it locked.  telnet to zookeeper port 2181 and type 'dump'18:21
*** Cibo has joined #zuul18:21
corvustobiash: it will show you ephemeral nodes grouped by connection, so look for the lock you're interested in, and also see what else it has locked18:22
tobiashis it possible that a launcher picks its old session on startup?18:22
corvustobiash: it should not18:22
corvushere's an example from our system: http://paste.openstack.org/show/653773/18:23
tobiashearlier today I had this issue and a launcher restart released it18:23
corvus(you can see that's obviously the connection for nl03, and it has a lock on several nodes)18:23
tobiashcorvus: thanks for this tip, that's cool18:24
tobiashunfortunately I already deleted the lock in the zkCli which released it18:24
tobiashbut next time I'll check the dump18:25
corvusyeah, that may help us find the bug18:25
tobiashbtw, I had zookeeper problems throughout the week due to slow disk io18:27
tobiashnow I changed zookeeper to 5 replicas on tmpfs and now it's stable :)18:27
*** rlandy|brb is now known as rlandy18:28
*** Cibo has quit IRC18:28
*** Cibo has joined #zuul18:29
tobiashwhat I observed is that if an fsync takes several seconds (15) to complete (e.g. due to overloaded storage) it can kick nodepool out of the session18:29
*** electrofelix has quit IRC18:30
corvustobiash: oh interesting.  there may be tunables for that, but perhaps it's better to do what you did (since the tunables would just make the system very slow)18:30
tobiashthat's what I also thought18:30
tobiashso my takeaway for this is a few more replicas more to better cope with node crashes18:32
tobiashdraw back is if you have a full system shutdown you have to rebuild all images18:32
tobiashbut that takes us currently at most 1-2 hours so I'll take this risk18:32
*** weshay is now known as weshay|ruck|brb18:43
*** harlowja has quit IRC19:14
*** jkilpatr has joined #zuul19:26
*** weshay|ruck|brb is now known as weshay|ruck19:27
*** harlowja has joined #zuul19:46
*** harlowja_ has joined #zuul19:58
*** harlowja has quit IRC20:00
Shrewstobiash: besides what corvus said, the first thing is to always check the allocated_to value of the node for the request #, then understand what's happening to that request by looking at the debug logs20:34
Shrewstobiash: i've found that there's usually a valid reason for it20:35
Shrewspaused request handler is the usual culprit20:36
Shrewsif that's not it, then the next likely culprit is an unhandled exception causing chaos in our logic20:38
*** jkilpatr has quit IRC20:57
corvusmordred, tobiash, Shrews: i'd appreciate a review on https://review.openstack.org/537655 when you get a chance.  gets the ansible reporting moving.21:22
Shrewscorvus: lgtm21:27
mordredcorvus: bother. I totally reviewed through that already and didn't actually leave a vote21:27
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add initial website content and jobs  https://review.openstack.org/53803921:44
openstackgerritJames E. Blair proposed openstack-infra/zuul-website master: Add initial website content and jobs  https://review.openstack.org/53803921:45
*** rlandy has quit IRC21:49
openstackgerritMerged openstack-infra/zuul master: Use override-checkout to select jobs  https://review.openstack.org/53765521:49
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Don't override allowed-projects  https://review.openstack.org/53835322:29

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!