Wednesday, 2018-01-17

openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add --strip option to encrypt_secret.py  https://review.openstack.org/53054700:32
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Enable direct use of github driver in debug tool  https://review.openstack.org/52960600:36
SpamapSdamn01:05
* SpamapS gets through the backlog01:05
SpamapSwas hoping the "we're CPU bound" discussion would end in "I guess we have to rewrite that calc code in rust"01:05
SpamapS;-)01:05
mrhillsmanis the zuul ML setup already?01:31
mrhillsmani wanted to start a thread regarding zuul behind vpn or environments that do not allow public access01:32
clarkbmrhillsman: it is, lists.zuul-ci.org01:52
mrhillsmanthx01:53
clarkbI don't know how many people are subscribed at this point but you can subscribe and it is functional01:53
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Do pep8 housekeeping according to zuul rules  https://review.openstack.org/52294502:20
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Use same flake8 config as in zuul  https://review.openstack.org/50971502:20
openstackgerritTristan Cacqueray proposed openstack-infra/zuul feature/zuulv3: pep8: ignore E124 rule  https://review.openstack.org/53458802:24
*** rlandy has quit IRC02:27
*** jaianshu has joined #zuul03:57
openstackgerritJens Harbott (frickler) proposed openstack-infra/zuul feature/zuulv3: Fix dependency cycle false positive  https://review.openstack.org/53444404:24
*** bhavik1 has joined #zuul04:32
*** ankkumar has joined #zuul05:08
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Remove unused method term_handler  https://review.openstack.org/53020205:16
*** smyers has quit IRC05:16
*** robled has quit IRC05:19
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix dependency cycle false positive  https://review.openstack.org/53444405:20
*** bhavik1 has quit IRC05:21
*** smyers has joined #zuul05:33
*** robled has joined #zuul05:38
*** robled has quit IRC05:38
*** robled has joined #zuul05:38
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Centrally register stack dump handler  https://review.openstack.org/53020305:47
*** saop has joined #zuul05:53
*** flepied has joined #zuul06:22
*** flepied has quit IRC06:23
*** flepied has joined #zuul06:24
*** flepied has quit IRC06:35
*** threestrands_ has quit IRC07:20
*** jkilpatr has quit IRC07:28
*** jkilpatr has joined #zuul07:39
*** flepied has joined #zuul07:39
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Add memory awareness to system load governor  https://review.openstack.org/50896008:08
*** flepied_ has joined #zuul08:15
*** flepied has quit IRC08:18
*** jpena|off is now known as jpena08:57
*** xinliang has quit IRC09:48
openstackgerritMerged openstack-infra/zuul-jobs master: Adjust check for .stestr directory  https://review.openstack.org/53268809:48
*** flepied__ has joined #zuul09:52
*** sshnaidm|off is now known as sshnaidm09:54
*** flepied_ has quit IRC09:55
openstackgerritMerged openstack-infra/zuul-jobs master: Clean up when conditions in fetch-subunit-output  https://review.openstack.org/53442809:57
*** xinliang has joined #zuul10:00
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Only fail requests if no cloud can service them  https://review.openstack.org/53337210:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: handler: fix support for handler without launch_manager  https://review.openstack.org/52477310:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add a plugin interface for drivers  https://review.openstack.org/52462010:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: builder: do not cleanup image for driver not managing image  https://review.openstack.org/51692010:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a static driver for Nodepool  https://review.openstack.org/46862410:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Refactor run_handler to be generic  https://review.openstack.org/52632510:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Refactor NodeLauncher to be generic  https://review.openstack.org/53245010:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an OpenContainer driver  https://review.openstack.org/46875310:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a Kubernetes driver  https://review.openstack.org/52135610:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an Amazon EC2 driver  https://review.openstack.org/52898210:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test  https://review.openstack.org/53377110:38
tristanCfwiw i've succesfully run some zuul-jobs on aws with 528982, and this last patchset implements proper alien/failed-build node cleaning10:39
*** flepied__ is now known as flepied10:40
saoptristanC, Ansible failing in posting logs to logserver, "msg": "SSH Error: data could not be sent to remote host 'ubuntu'. But we already set private key and manually we are able to ssh, any thing we missed?10:59
tristanCsaop: did you used the add-fileserver role?11:00
saoptristanC, yes we used it11:00
tristanCsaop: the executor is running playbook in a restricted environment, so it probably doesn't have the same access that you have when testing manually11:01
saoptristanC, - hosts: all11:04
saop  tasks:11:04
saop  # add-fileserver role's tasks inlined bellow11:04
saop    - name: Add fileserver to inventory11:04
saop      add_host:11:04
saop        name: 10.13.120.20911:04
saop        ansible_ssh_host: ubuntu11:04
saop        ansible_ssh_private_key_file: "~/.ssh/myserver.rsa"11:04
saop        zuul_fileserver_project_path: /var/www/logs/{{ zuul.project.short_name }}11:04
saoptristanC, that is the add fileserver thing for us11:04
tristanCsaop: yes, "~/.ssh/" shouldn't be available to the playbook running by the executor11:05
tristanCsaop: if you don't want to bother with using a zuul secret, then you can put that myserver.rsa file into a separate directory, e.g. /etc/zuul-keys11:05
saoptristanC, /etc/zuul-keys that is on the nodepool node, or the ansible host?11:06
tristanCsaop: and then, you can map that /etc/zuul-keys directory inside the executor bubblewrap using that option: https://docs.openstack.org/infra/zuul/feature/zuulv3/admin/components.html#attr-executor.untrusted_ro_paths11:07
tristanCsaop: on the executor node running the above playbook11:07
tristanCsaop: oops, you should use "trusted_ro_paths" for config-projects playbook instead11:08
saoptristanC, so this line 'ansible_ssh_private_key_file: "~/.ssh/myserver.rsa"'    ansible_ssh_private_key_file: "/etc/zuul-keys/myserver.rsa" after?11:09
tristanCsaop: yes, and you need to restart the executor after adding that trusted_ro_paths option to zuul.conf11:10
saoptristanC, Thanks11:10
* SpamapS rather likes that feature. :)11:59
*** jkilpatr has quit IRC12:07
*** jkilpatr has joined #zuul12:09
*** sshnaidm is now known as sshnaidm|afk12:11
*** sshnaidm|afk has quit IRC12:16
*** jpena is now known as jpena|lunch12:45
*** sshnaidm|afk has joined #zuul12:55
*** sshnaidm|afk is now known as sshnaidm12:55
saoptristanC, In the 'zuul_return' phase of ansible, its failing with error: 'The error was: KeyError: 'ZUUL_JOBDIR''13:24
tristanCsaop: zuul_return can only be used on localhost13:25
saoptristanC, we are using in localhost only13:25
saoptristanC, ubuntu | MODULE FAILURE while debuging we got this13:25
saoptristanC, okay i got it13:26
saoptristanC, found the missing line delegate_to: localhost13:26
*** rlandy has joined #zuul13:30
*** dkranz has joined #zuul13:31
*** jaianshu has quit IRC13:35
*** ankkumar has quit IRC13:40
*** saop has quit IRC13:43
ShrewstristanC: woah, you've got quite a collection of drivers going there. awesome!13:46
*** jpena|lunch is now known as jpena13:48
Shrewsclarkb: found an issue with 533771. i'm not sure how to do what you want to do there yet. i'm still pre-coffee13:53
tristanCShrews: heh, still trying to figure out a good interface to support different workflow13:53
*** hashar is now known as hasharAway14:06
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Rename _useBuilder method to useBuilder  https://review.openstack.org/53188314:29
*** sshnaidm is now known as sshnaidm|mtg14:46
*** flepied has quit IRC15:05
*** sc68cal has quit IRC15:09
fungiis tests.unit.test_git_driver.Te15:17
fungiugh, stray newlin... is tests.unit.test_git_driver.TestGitDriver.test_ref_updated_event unreliable?15:18
fungiseems i'm running afoul of it on a trivial change to zuul's docs: https://review.openstack.org/53191215:18
tobiashhm, good question15:27
tobiashit looks like today the zuul tests are generally unstable somehow15:27
corvusyeah, that test just has a simple delay that's too short15:39
corvusi think we can fix that systemically by having the git driver used in tests record when it emits an event, that will tell us when we can call waitUntilSettled15:40
*** sc68cal has joined #zuul15:49
*** flepied has joined #zuul15:55
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Stabilize git driver tests  https://review.openstack.org/53481815:58
corvusfungi, tobiash, fbo: ^15:59
*** sshnaidm|mtg is now known as sshnaidm16:19
Shrewsso this is happening today at my place: https://photos.app.goo.gl/v4TEHiYlhESLgi9I316:20
Shrewsquite the rare occurrence16:21
ShrewstristanC: tobiash: re-approved the pep8/flake8 changes16:43
pabelangerShrews: nice snow!16:46
pabelangerlove it16:46
tobiashcorvus: looking16:50
tobiashShrews: cool, so much snow16:50
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components  https://review.openstack.org/53484116:51
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components  https://review.openstack.org/53484116:57
clarkbShrews: hrm ya I guess that is a race. I too don't have any immediate ideas on how to address it16:59
Shrewsclarkb: maybe if you create additional unique labels to each provider, request those first, then request the shared label?17:06
clarkboh ya that should work17:07
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Do pep8 housekeeping according to zuul rules  https://review.openstack.org/52294517:07
*** flepied has quit IRC17:08
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Use same flake8 config as in zuul  https://review.openstack.org/50971517:09
*** flepied has joined #zuul17:11
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test  https://review.openstack.org/53377117:12
clarkbShrews: ^ maybe it is that simple?17:12
mordredcorvus: +2 with comments on https://review.openstack.org/#/c/534841/ - feel free to land17:17
Shrewsclarkb: shouldn't your 2nd request for fake-label go to FAILED with your change? If it ever goes PENDING, that's only a temporary state due to your change, right?17:30
Shrewsclarkb: and i think the first request for fake-label is racey on PENDING to, since it should also transition back to REQUESTED17:31
Shrewsclarkb: oh, no, i'm wrong on the first part of that. 2nd request will pause17:33
clarkbShrews: for the first thing, no thats exactly what we are fixing. We should only fail after all available providers have failed or declined the request. So both fake-labels go to paused one on each provider. Then we delete the existing node on the second provider unpausing its fake-label request. Then we also delete that fake-label node. At this point the only outstanding request is the fake-label on the first17:33
clarkbprovider. We make it fail due to exception then provider2 picks it up and fulfills it17:33
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components  https://review.openstack.org/53484117:33
corvusmordred: tests are failing anyway, so i went ahead and ammended it with your and tobiash's suggested changes17:34
clarkbShrews: and I don't thnk there is a race on PENDING as that is the state that paused requests seem to go in17:34
clarkbShrews: so once both reuqests are paused they are pending17:34
mordredclarkb: cool17:35
Shrewsclarkb: oh, i got confused a sec... we aren't actually testing your change here, which is what i was expecting17:38
clarkbShrews: we arne't?17:38
Shrewsyour change being the exception from run_handler causing the request to go back to REQUESTED17:38
clarkbShrews: we do17:39
clarkbby checking that the second provider ends up fulfilling the request17:39
clarkbwhich it won't do if the request is marked failed instead17:39
clarkbwe are doing a functional test that a cloud failure in fake-provider doesn't prevent fake-provider2 from fulfilling the request. The painful part of the test is that we have to ensure that fake-provider grabs the request first and also declines it due to failure which is why we end up with all those requests to "prime" the system17:41
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Don't fetch coverage report from failing tests  https://review.openstack.org/53485317:45
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Don't fetch coverage report from failing tests  https://review.openstack.org/53485317:47
Shrewssorry... lost power for a minute17:47
Shrewsclarkb: ok, yeah. i see now. i confused myself for a bit17:48
clarkbShrews: It took me like 5 hours to sort out that test because its a bit confusing :)17:48
Shrewsbtw, if i disappear, it's probably b/c of a power loss and I went to find someplace warm17:48
clarkbalso that is like the 4th appraoch I took17:49
clarkbdealing with different provider threads racing each other is ufn17:49
Shrewsyeah, not so much17:49
corvusit looks like the other zuul tests are failing due to a dependency change, i suspect something aiohttp related.  digging into it now.17:49
corvus(probably they made a release because of that dep that we had to pin)17:50
Shrewscorvus: aiohttp... now THAT'S fun17:50
corvusheh, yeah, aiohttp made a release which works with yarl 1.0 but not yarl<1.017:52
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Stabilize git driver tests  https://review.openstack.org/53481817:54
corvusok, that should fix both things17:54
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components  https://review.openstack.org/53484117:54
*** jpena is now known as jpena|off18:17
corvusmordred: 534841 and parent are passing tests and ready now18:31
corvusparent will unblock gate18:31
mordredcorvus: +A to both18:33
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Don't fetch coverage report from failing tests  https://review.openstack.org/53485318:54
*** flepied_ has joined #zuul19:09
*** flepied has quit IRC19:10
corvuszuul/nodepool don't have a backlog -- should we restart them to pick up the CSD changes?19:18
corvusoops, wrong channel19:18
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test  https://review.openstack.org/53377119:36
clarkbnow with pep8 fixes19:36
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Stabilize git driver tests  https://review.openstack.org/53481819:43
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Only fail requests if no cloud can service them  https://review.openstack.org/53337219:47
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test  https://review.openstack.org/53377119:47
clarkbrebased because testing api changed19:47
SpamapSHave we ever talked about how we might support tags in playbooks?19:48
pabelangeryah, I think there is a story for it in SB19:49
SpamapSI have a few playbooks that work well directly run by Ansible, but that I'd like to be able to test with a mix of tags.19:49
pabelangertripleo wanted to use them19:49
SpamapSrun by Zuul I mean.19:49
pabelangerSpamapS: https://storyboard.openstack.org/#!/story/200135319:50
SpamapSpabelanger: thanks. Couldn't find it. :-P19:58
*** hasharAway is now known as hashar20:04
*** corvus is now known as jeblair20:37
*** jeblair is now known as corvus20:37
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Don't gather host keys for non ssh connections  https://review.openstack.org/50316620:41
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Add connection-port to provider diskimage  https://review.openstack.org/50411220:41
Shrewsleifmadsen_: oy, did you pick a bad time to come to Raleigh20:52
SpamapSwoot, fb-re2/pyre2 maintainer lives. :)20:54
leifmadsen_Shrews: no shit!21:01
leifmadsen_Shrews: every bloody time I come to the south, it snows21:01
leifmadsen_our training got cancelled today... so, I may or may not be sitting in a bar21:02
Shrewsleifmadsen_: sitting in a bar may, or may not, be an excellent choice21:04
*** hashar has quit IRC21:16
*** hashar has joined #zuul21:27
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Document connection information for components  https://review.openstack.org/53484121:28
leifmadsen_Shrews: :D21:36
*** threestrands_ has joined #zuul21:44
*** hashar has quit IRC21:44
*** threestrands_ has quit IRC21:45
*** threestrands_ has joined #zuul21:45
*** threestrands_ has quit IRC21:45
*** threestrands_ has joined #zuul21:45
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle secrets in branches  https://review.openstack.org/53495621:50
corvuswe also need to do the same thing as that ^ for nodesets i think21:51
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Make ZuulDaemonApp an abstract base class  https://review.openstack.org/53020422:28
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle secrets in branches  https://review.openstack.org/53495622:40
*** jkilpatr has quit IRC22:54
corvusfungi, clarkb, mordred, tobiash, SpamapS: i sent an email to -discuss about ^: http://lists.zuul-ci.org/pipermail/zuul-discuss/2018-January/000003.html23:03
clarkbShrews: can you rereview https://review.openstack.org/#/c/533771/9 and its parent now? I think I've addressed the review comments and the rebase got tests working again so should be good to go23:05
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Register term_handler for all zuul apps  https://review.openstack.org/53020523:07
Shrewsclarkb: done23:16
*** persia has quit IRC23:18
*** persia has joined #zuul23:18
*** rlandy has quit IRC23:40
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle nodesets in branches  https://review.openstack.org/53497423:51
*** persia has quit IRC23:53
*** dkranz has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!