Tuesday, 2018-01-09

mordredcorvus: heh:  Sending result: {"result": "ERROR", "error_detail": "Project ansible/ansible does not have the default branch master"}00:01
clarkbit doesnt?00:02
mordredno- they have no master branch and instead use devel00:02
mordredI've added an override-branch setting to the required-projects00:04
clarkbwhy do projects do that?00:04
clarkbthat value isnt replicated on pushes its a git failing but means you should just use master00:04
mordredyah. I don't grok it myself00:05
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add job for testing against devel of ansible  https://review.openstack.org/53193400:06
clarkbit is an unfortunate git behavor but it is what it is00:08
mordredclarkb, corvus: http://zuulv3.openstack.org/stream.html?uuid=6e346ac9d4054654b7db8edabf45aa58&logfile=console.log <-- it's at least past the zuul config error - and I see github.com/ansible/ansible in the projects list00:09
mordred2018-01-09 00:09:21.123535 | controller | Cloning into '/home/zuul/src/github.com/ansible/ansible'...00:09
mordred2018-01-09 00:09:33.674617 | controller | ok: Item: Runtime: 0:00:12.46227500:09
mordredPIDDLE00:14
mordredwell - tox-install-siblings doesn't work with ansible ... patch coming00:15
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Use setup.py if we can't get the name from setup.cfg  https://review.openstack.org/53193600:24
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add job for testing against devel of ansible  https://review.openstack.org/53193400:25
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add /node-list to the webapp  https://review.openstack.org/49996901:54
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add /label-list to the webapp  https://review.openstack.org/50025401:54
*** haint has joined #zuul02:20
*** nguyentrihai has quit IRC02:24
*** harlowja has quit IRC02:32
*** rlandy_ has quit IRC02:37
*** rlandy|bbl is now known as rlandy02:38
*** rlandy has quit IRC02:38
*** xinliang has quit IRC02:43
*** xinliang has joined #zuul02:54
*** JasonCL has quit IRC03:03
*** JasonCL has joined #zuul03:04
*** JasonCL has quit IRC03:09
*** JasonCL has joined #zuul03:19
*** JasonCL has quit IRC03:24
tristanCfwiw, i just proposed a pre-release fedora package for zuulv3 here: https://src.fedoraproject.org/rpms/zuul/pull-request/103:33
*** JasonCL has joined #zuul03:44
*** JasonCL has quit IRC03:49
*** JasonCL has joined #zuul04:01
*** JasonCL has quit IRC04:07
*** JasonCL has joined #zuul04:20
*** JasonCL has quit IRC04:24
*** JasonCL has joined #zuul04:44
*** JasonCL has quit IRC04:49
*** JasonCL has joined #zuul04:51
*** JasonCL has quit IRC04:58
*** JasonCL has joined #zuul05:48
*** JasonCL has quit IRC05:52
*** xinliang has quit IRC05:57
*** bhavik1 has joined #zuul06:07
*** xinliang has joined #zuul06:09
*** xinliang has quit IRC06:09
*** xinliang has joined #zuul06:09
*** JasonCL has joined #zuul06:12
*** JasonCL has quit IRC06:17
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Fix sql reporting with postgres  https://review.openstack.org/53202306:44
*** JasonCL has joined #zuul06:46
*** JasonCL has quit IRC06:51
*** JasonCL has joined #zuul07:01
*** JasonCL has quit IRC07:06
*** jlk has quit IRC07:17
*** jlk has joined #zuul07:21
*** jlk has quit IRC07:21
*** jlk has joined #zuul07:21
*** JasonCL has joined #zuul07:41
gundalowmordred: Could you please let me know a PR when it's created. I want to ensure it doesn't confuse Ansibullbot reading of CI status07:45
gundalowmattclay: fyi ^07:46
*** JasonCL has quit IRC07:46
*** hashar has joined #zuul07:50
*** JasonCL has joined #zuul08:36
*** JasonCL has quit IRC08:40
*** jpena|off is now known as jpena08:45
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add ansible-lint job  https://review.openstack.org/53208308:50
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add ansible-import-to-galaxy job  https://review.openstack.org/53208408:50
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add ansible-spec job  https://review.openstack.org/53208508:50
rcarrillocruztristanC: heya, are you or fabien using the gitdriver to reconsume the upstream jobs yet ?09:08
rcarrillocruzi.e. avoiding the GH apps relationsships between zuuls09:08
*** JasonCL has joined #zuul09:08
tristanCrcarrillocruz: not yet, we still need a gerrit connection when deploying using openstack-infra/zuul-jobs09:08
tristanCrcarrillocruz: but because we also support offline deployment, we actually packaged and setup a known zuul-jobs locally by default09:09
rcarrillocruzah, i see09:10
*** JasonCL has joined #zuul09:10
tristanCe.g. https://softwarefactory-project.io/r/gitweb?p=scl/zuul-jobs-distgit.git;a=tree09:12
*** jlk has quit IRC09:18
*** jlk has joined #zuul09:26
*** jlk has quit IRC09:26
*** jlk has joined #zuul09:26
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: Refactor status functions, add web endpoints, allow params  https://review.openstack.org/53139009:34
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: Add a separate module for node management commands  https://review.openstack.org/53170309:34
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: [WIP] webapp: add optional admin endpoint  https://review.openstack.org/53171809:34
*** bhavik1 has quit IRC09:47
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: zk: automatically retry command when connection is lost  https://review.openstack.org/52364009:54
*** sshnaidm is now known as sshnaidm|afk10:07
*** fbo_ has quit IRC10:08
*** jkilpatr has quit IRC12:18
*** jpena is now known as jpena|lunch12:32
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: [WIP] webapp: add optional admin endpoint  https://review.openstack.org/53171812:35
*** jkilpatr has joined #zuul12:54
*** sshnaidm|afk is now known as sshnaidm13:23
*** rlandy has joined #zuul13:31
*** jpena|lunch is now known as jpena13:32
*** fbo has joined #zuul13:33
*** dkranz has joined #zuul14:02
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: [WIP] webapp: add optional admin endpoint  https://review.openstack.org/53171814:18
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add error handling for pidfile  https://review.openstack.org/53220614:55
pabelangerleifmadsen_: mordred: corvus: ^something we noticed in testing docs, might be helpful to start adding some additional debug information to zuul users14:56
*** sshnaidm is now known as sshnaidm|mtg15:01
*** rlandy is now known as rlandy|mtg15:05
*** JasonCL has quit IRC15:11
*** JasonCL has joined #zuul15:12
dmsimardpabelanger: fyi https://review.openstack.org/#/c/532206/ is tangentially related to https://storyboard.openstack.org/#!/story/200145015:12
dmsimardhttps://storyboard.openstack.org/#!/story/2001445 as well, actually15:13
pabelangerdmsimard: we recently re-factored pidfiles in zuul, so that isn't the case anymore. But agree, we might need to update puppet-zuul or delete the old folders15:15
pabelangereverything is now in /var/run/zuul15:15
tobiashhmpf, sql reporter doesn't work with github15:16
*** JasonCL has quit IRC15:16
tobiashpatchset is the git hash there and the db wants int :/15:16
pabelangeralso, I'm going to push up some systemd files for zuul today, which takes care of creating /var/run/zuul with systemd, but haven't tested across multiple systemd files15:17
rcarrillocruzerm, ok15:18
dmsimardupstart is so 200515:18
dmsimard2006 according to wikipedia, I was close15:18
rcarrillocruzinteresting tobiash , i was going  to containerize mysql for zuul sql reporting in the next few days15:19
*** smyers has quit IRC15:19
tobiashlooks like I need to look at how to write migration scripts15:21
dmsimardtobiash: why does the db want an int ? what do we have there for gerrit ? the change number ?15:22
tobiashdmsimard: gerrit has change number and patchset number15:22
tobiashwhere it made sense to use int and int15:23
tobiashgithub has not patchset number instead there the sha of the head of the pr is used15:23
tobiashwhich is no int ;)15:23
dmsimardtobiash: it would have the pr number? :/15:23
tobiashpr number is like the change number15:24
tobiashps is the change version aka the current head of the pr in gituhub15:24
*** smyers has joined #zuul15:24
dmsimardyeah15:24
tobiashso I need to change the patchset column to text15:24
dmsimarddo we have the change-id somewhere in there ?15:25
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Use setup.py if we can't get the name from setup.cfg  https://review.openstack.org/53193615:25
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Capture and report errors in sibling installation  https://review.openstack.org/53221615:25
dmsimardat what point does the field just become a json blob? :D15:25
tobiashprobably with visual source safe :-P15:25
tobiashthat's the error btw: http://paste.openstack.org/show/641292/15:26
dmsimardgood idea to fix that before v3 is released15:27
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Capture and report errors in sibling installation  https://review.openstack.org/53221615:28
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Use setup.py if we can't get the name from setup.cfg  https://review.openstack.org/53193615:28
corvustobiash: "alembic revision" will create a new migration file for you.  you don't need to write a downgrade.  here's an example of altering a column.  you can copy gertty.dbsupport to get that function:  http://git.openstack.org/cgit/openstack/gertty/tree/gertty/alembic/versions/56e48a4a064a_increase_status_field_width.py15:29
tobiashcorvus: thanks :)15:29
corvustobiash: and http://git.openstack.org/cgit/openstack/gertty/tree/gertty/dbsupport.py15:30
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Add support for a secure ZooKeeper configuration  https://review.openstack.org/53188215:38
corvuspabelanger: regarding 532206 i don't understand -- line 184 here should raise an exception if the pidfile is not writable, does it really not?  http://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/cmd/__init__.py?h=feature%2Fzuulv3#n18215:40
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add error handling for pidfile  https://review.openstack.org/53220615:42
pabelangercorvus: yah, in testing, nothing happens for that logic. Not errors are raised15:44
pabelangerbut I can look into why that is now15:44
Shrewscorvus: pabelanger: yeah, i've seen that before too when testing the finger stuff. if the pid had the wrong owner, just a silent fail15:46
* Shrews needs to make 1 more cup of coffee before a meeting15:50
corvusShrews, pabelanger: oh, because that should be entering the pidfile context, not daemon context.  it should be "with pid".  let's fix that first.  ;)15:52
pabelangercool, easy fixes are the best fixes15:54
clarkbShrews: responded to your question on the secure file change15:58
Shrewsclarkb: hrm, we can't really know which file the values come from. what if i put invalid values in the normal config that won't work?15:59
clarkbShrews: ya that, I think you put invalid different values in the normal file, then override with good values in the secure file. Then just double check that you are using the good values15:59
clarkbin addition to things functioning15:59
Shrewsclarkb: ok. i'll do that after this meeting16:01
* Shrews reminds mordred and corvus about said meeting16:01
tobiashcorvus: is there a reason why there is no alembic.ini there?16:20
*** jkilpatr_ has joined #zuul16:24
pabelangercorvus: re: with pid, should we wrap in try / except or output default traceback?16:25
*** jkilpatr has quit IRC16:26
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Change patchset column to string  https://review.openstack.org/53223716:32
tobiashcorvus: ^^ I used alter_column as we use it already in another migration script16:33
tobiashIf we want to support sqlite this should be a separate change16:33
tobiashhowever the dbsupport script didn't work out of the box due to the foreign key16:33
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Use setup.py if we can't get the name from setup.cfg  https://review.openstack.org/53193616:38
*** rlandy|mtg is now known as rlandy16:41
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: [WIP] webapp: add optional admin endpoint  https://review.openstack.org/53171816:42
clarkbmordred: did you see my comment on ps1 of 531936?16:48
mordredclarkb: nope - looking now, thanks16:54
*** jkilpatr has joined #zuul17:09
*** jkilpatr_ has quit IRC17:09
*** JasonCL has joined #zuul17:10
*** sshnaidm|mtg is now known as sshnaidm17:10
corvustobiash: i have no idea why there's no alembic.ini; seems like there probably should be one?17:11
tobiashit required at least a minimal one with the script location17:12
corvustobiash: if you have one handy you can add, that's be great :)17:12
tobiashok, no problem17:12
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Add alembic.ini  https://review.openstack.org/53226017:14
tobiashcorvus: ^^17:14
*** hashar is now known as hasharAway17:17
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Fix error handling for pidfile  https://review.openstack.org/53220617:25
pabelangercorvus: Shrews: how's that^17:25
dmsimardtobiash: I wonder if changing the column type has side effects (for example if the webapp exposes sqlreporter data and expects an int for some reason)17:26
tobiashdmsimard: just looked at the zuul-web code and it doesn't like like it's doing anything with this column17:29
tobiashso I believe it's save17:29
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Use setup.py if we can't get the name from setup.cfg  https://review.openstack.org/53193617:31
corvuspabelanger: why not just leave the bare exception?17:32
corvuspabelanger: or if you want to mask it, maybe something more helpful like "Unable to write to pidfile {pidfile} error: {e}"17:34
pabelangercorvus: http://paste.openstack.org/show/641397/ is would be the output, was a little verbose17:34
pabelangerbut, can remove the print statement if you'd like17:35
pabelangersure, let me try that17:35
corvuspabelanger: what's the output with your statement?17:35
pabelangerERROR: Problem with pidfile (failed to create /var/run/zuul/zuul.pid) is current patchset17:35
pabelangertrying your updates now17:36
corvuspabelanger: that's the less useful of the two exceptions; if we reduce it to one, then we need the other one17:36
corvuspabelanger: basically, we should either let the exception through unaltered, or, if you want to mask it, the result should include "PermissionError: [Errno 13] Permission denied: '/var/run/zuul/zuul.pid'17:37
corvusthat's the actionable part of the error17:37
pabelangerokay, lets pass though unaltered exception, let me update17:38
dmsimardwe need something similar for /var/lib/zuul/*17:38
dmsimarddocumented it in https://storyboard.openstack.org/#!/story/200144517:39
dmsimardwhen I had remounted /var/lib/zuul into it's own partition on the reinstalled ze09, the permissions were not right and there was nothing in logs hinting at the issue17:40
corvusyep17:40
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Fix error handling for pidfile  https://review.openstack.org/53220617:40
pabelangeryah, I can get that one next17:40
pabelangerwe had the same issue in quickstart docs17:41
dmsimardalso, are those stack traces actually going to show up in logs ?17:41
dmsimardthat's the important part17:41
dmsimardsome traces appear when trying to start the process in foreground but they don't show up in logs ..17:41
clarkbdmsimard: the init scripts should set the permissions17:42
dmsimardmaybe17:43
clarkb(so in addition to better error reporting, there is maybe a bug in the init script)17:43
pabelangersystemd has a setting now to automafically create /var/run directories17:43
dmsimardright, I was about to mention it's two separate improvement opportunities17:43
clarkbchown $USER $PIDFILE_DIR is in the script at least17:43
clarkbmaybe it needs to set the group too?17:43
dmsimardclarkb: /var/lib/zuul != /var/run/zuul17:43
pabelangerbut, currently is stdout17:43
pabelangerfor pidfile17:43
clarkboh the dir where the repos are kept, ya17:44
clarkbdmsimard: we should add that to the init script too17:44
pabelangerclarkb: zuul attempts to create it, but needs write permissions17:44
pabelangerso, we can raise exception if that fails17:45
corvusdmsimard: the pidfile check error will be printed to stderr before logging is set up, and will cause the process to exit nonzero.17:47
pabelangerah, I think i see the issue.  Currently daemon.DaemonContext will set stdout/stderr to None, which doesn't log some of our exceptions.17:54
pabelangerdaemon.DaemonContext(pidfile=pid, stderr=sys.stderr) seems enable them again17:54
pabelangerthen you get the following: http://paste.openstack.org/show/641416/17:55
clarkbpabelanger: that is intentional because traditional daemonizing is supposed to close all file descriptors17:55
clarkbthat assumption sort of changes when you start using tools like systemd though as they expect you will write logs to those fds and then handle them for you17:55
clarkb(upstart too)17:55
pabelangerclarkb: yah, for systemd it's not possible for it to daemonize itself and just use -d flag with zuul17:56
clarkbpabelanger: it should be possible to let systemd do the work and pair that with -d on the zuul size17:57
SpamapSupstart is dead17:57
SpamapSlong live systemd17:57
* SpamapS dies a little more inside17:57
clarkbs/size/side/17:57
SpamapSsystemd _can_ handle traditional daemons, but they recommend either foreground or systemd-specific "readiness"17:57
clarkbbasically what happened aiui is very few applications daemonized prperly so modern init systems said fine we'll do it for you17:57
SpamapSYeah most things exit the parent before the children are actually "ready"17:58
pabelangerclarkb: yes, how I've been testing things myself with systemd and -d.  So, unsure if we want to have the discussion of just letting systemd do that now17:58
SpamapSAnd many, as you say, don't do all the right things.17:58
pabelangerand remove daemon from zuul17:58
corvusnope17:58
corvuszuul will not depend on systemd17:58
SpamapSWe should keep daemonization in zuul. How are we going to get people to run it on FreeBSD? ;-)17:58
clarkbya I think we shouldn't remove that functionality, but we may not use it if using systemd unit files for zuul in those unit files17:59
corvusthe current approach of detecting errors which prevent startup before daemonizing is the right one.17:59
corvusclarkb: that's a choice someone could make, though i don't think we should recommend it, at least, not yet.18:03
clarkbthats fine. I also think intentionally breaking daemonization (not closing fds like stderr) may not be the best approach if we aren't going to only support something like systemd18:06
clarkbbut thats a tricky situation18:07
corvusclarkb: agreed.  we should not break daemonization.18:07
corvusthe approach should be to detect any errors which will prevent daemonization or logging further exceptions before performing the daemonization.18:08
corvusto that end, we may want to enter the pidfile context manager ourselves, before entering the daemonize context manager.  so maybe something like "enter pidfile, verify log config, daemonize"18:10
corvus(ie, enter and stay entered, rather than enter/exit/enter)18:11
*** jkilpatr has quit IRC18:17
*** jpena is now known as jpena|off18:29
mordredcorvus, clarkb, Shrews: woot - http://zuulv3.openstack.org/stream.html?uuid=8838e564afae4ef7adce227b6d42c147&logfile=console.log seems to be correctly running with src/github.com/ansible/ansible18:30
*** jkilpatr has joined #zuul18:38
pabelangernice18:43
clarkbcorvus: I think  Icaptured the corrupted git repo situation and what we can do about it in zuul properly in https://storyboard.openstack.org/#!/story/200145318:47
clarkbis tox-py35-on-zuul still sometimes failing?18:48
clarkbmordred: is there already a story for logging more than command/shell?18:49
clarkbspecific case on the zuulv3-issues ehterpad is the pat module18:49
*** robled has quit IRC18:50
mordredclarkb: you mean streaming the logs of non-command/shell?18:52
mordredclarkb: unfortunately no, not in zuul - we'll have to wait until we get streaming upstreamed into ansible to be able to support that18:52
clarkbya18:53
*** robled has joined #zuul18:55
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: [WIP] webapp: add optional admin endpoint  https://review.openstack.org/53171818:56
clarkbmordred: do we want a story to track that on the zuul side?18:56
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Use setup.py if we can't get the name from setup.cfg  https://review.openstack.org/53193619:01
mordredclarkb: yah - probably so19:01
*** harlowja has joined #zuul19:33
*** harlowja_ has joined #zuul19:41
*** harlowja has quit IRC19:43
*** harlowja_ has quit IRC19:55
*** harlowja has joined #zuul19:55
mordredcorvus, clarkb, Shrews: http://logs.openstack.org/34/531934/3/check/zuul-tox-py35-ansible-devel/a1a9d08/tox/py35-siblings.txt <-- install-siblings correctly installed tip of ansible/ansible19:56
Shrewswoo!19:56
mordredShrews: now - the tests TOTALLY fail19:59
mordredbutI think at the moment that's likely expected, given we had work to do to shift from 2.3 to 2.4 and whatnot20:00
pabelangervery cool20:02
Shrewsmordred: oh, well that work is ready i think: https://review.openstack.org/53100920:02
corvusif only we had cross-source-deps :)20:04
pabelangercould you set the branch to stable-2.3 for tox siblings? I haven't spent much time looking at sibligs20:04
mordredpabelanger: yup20:04
pabelangergood to know20:04
mordredcorvus, pabelanger, Shrews, clarkb: how do we want to handle https://review.openstack.org/531009 and the corresponding upgrade of ansible on the executors to 2.4?20:05
clarkbmordred: probably put 2.4 on a single executor and see how it does?20:06
clarkbthen rollout to the others if it is happy20:06
pabelangerI would imagine some playbooks some where would not react well to 2.4, so we should be on standby to help address that.20:07
clarkbya ^ is probably the biggest concern20:08
clarkbmaybe we need to make sure we expose the ansible version somewhere if not already?20:08
clarkbso that zuul users don't have to guess what version of ansible is breaking them20:08
corvusclarkb: i bet there's an ansible version variable already20:10
corvushttp://docs.ansible.com/ansible/latest/playbooks_variables.html#ansible-version20:10
corvusmaybe we should print that from our info role we run at the start of jobs?20:11
mordredyah20:11
mordredcause it sisn't in the host vars we print20:11
Shrewswhich is suprising20:12
mordredmaybe in the job header ... since we don't actually need it per-test-node20:12
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Add Ansible version to job header  https://review.openstack.org/53230420:15
mordredsomethign like that?20:15
Shrewslgtm20:16
mordredShrews, clarkb, corvus, pabelanger, dmsimard: https://review.openstack.org/#/c/532216/ and https://review.openstack.org/#/c/531936 are good to go now20:17
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: [WIP] webapp: add optional admin endpoint  https://review.openstack.org/53171820:34
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Add support for a secure ZooKeeper configuration  https://review.openstack.org/53188220:49
Shrewsmordred: Wow. Your header change worked... but also didn't work20:54
Shrewsthat's neat20:55
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Switch to python3-dev / python3-devel in bindep.txt  https://review.openstack.org/53231020:57
mordredShrews: oh - hah. nice20:58
SpamapSDoes ansible-playbook have a "fail on warning" mode we could run jobs with at some point? Would be good to let people turn that on per-job to basically say "this job is warning free" that way it would be free from deprecated things.21:01
mordredSpamapS: not to my knowledge, no21:01
SpamapSGuess we could have a POST that fails after in log collection.21:02
mordredShrews: weird ... http://logs.openstack.org/04/532304/1/check/openstack-infra-base-integration-centos-7/6081fe4/ara/result/fc028c65-a7ba-43ae-a221-adc2ec3ad023/21:03
SpamapSdon't know why that's a POST and not post-run ;)21:03
mordredSpamapS: you're putting your rests in your zuuls!21:03
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Add support for a secure ZooKeeper configuration  https://review.openstack.org/53188221:03
mordreddmsimard: I'm confused by the integration test errors for this change: https://review.openstack.org/#/c/532304/21:05
mordreddmsimard: any chance they make sense to you?21:05
dmsimardthat rings me a bell21:06
dmsimardsomething about include_vars including vars from the playbook directory instead of the role directory21:06
SpamapSmordred: or maybe I just like to yell POST21:06
dmsimardI've fixed something like that before, I forget where21:06
dmsimardtrying to remember.........21:06
clarkbdmsimard: mordred it looks like fact gathering on localhost i afiling for trying to read things outside of the builds working dir?21:07
dmsimardwell there you go -- http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/roles/configure-unbound/tasks/main.yaml#n4121:07
dmsimardsee how I prefix {{ role_path }} before..21:07
dmsimardhmm21:07
dmsimardthat's exactly where things are failing though21:08
clarkboh ara claims its on the test node though21:08
clarkband not on localhost21:08
mordredbut include_vars is going to run on the executor21:08
mordredsince it's an ansible include21:08
dmsimardis role_path not inside work/ ?21:09
mordredand I'm guessing role_path is including one of the source dirs perhaps?21:09
dmsimardit's wherever the role is located21:09
mordreddmsimard: it's a good question ... maybe we should print it21:09
dmsimardsure, let me add a debug somewhere in there21:09
mordreddmsimard: this is a fun one :)21:09
dmsimardmordred: the real issue is more sinister but more on that later21:10
dmsimardmordred: so the playbook that runs the tests is here: http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/tests21:11
dmsimardand there's a vars dir there (because some tests have OS-specific things)21:11
dmsimardWELL, it turns out that when you do an include_vars, playbook/vars has a higher precedence than <role>/vars21:12
mordred\o/21:12
dmsimardthat was especially confusing, considering the include_vars is happening inside the role21:12
dmsimardI never managed to figure out if it was intended behavior21:12
dmsimardmaybe a pro like Shrews or gundalow knows21:13
mordreddmsimard: I think it is - playbook local paths are supposed to win21:13
mordreddmsimard: we could cheat and just rename tests/vars to something else ...21:13
dmsimardbut then if we do that, the include_vars from a playbook file would no longer work (or, well, we'd need to supply the different name there)21:14
mordredyah21:14
dmsimardIMO vars/ from the scope (playbook or role) should win, and then go seek out something else in order of priority21:14
dmsimardbut I dunno21:14
dmsimardso anyway, role path print is here: https://review.openstack.org/#/c/532314/21:15
dmsimardand also, I'd like to think that the current implementation works or else it wouldn't have merged so I'm not entirely sure why your thing is not working -- maybe the role_path is different because it's supplied by zuul (through zuul-jobs <-> openstack-zuul-jobs) while I would've landed the patch directly in o-z-j (in the work directory?)21:16
Shrewsdmsimard: it's an easy mistake to assume that because I work for Ansible, that I am also an Ansible pro21:16
mordreddmsimard: how about I also add a role_path debug in my patch - we can compare them21:16
dmsimardmordred: sure, that's actually a good idea since my patch is in o-z-j21:17
dmsimardShrews: I work on "computers" and I'm suddenly a pro in printers, faxes, VHS players and such :D21:17
* dmsimard holidays are always painful21:18
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: DNM print role_path  https://review.openstack.org/53231921:18
*** rlandy is now known as rlandy|brb21:35
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Move CRD tests to test_gerrit_legacy_crd  https://review.openstack.org/53188621:39
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add skipped CRD tests  https://review.openstack.org/53188721:39
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Replace change.equals with __eq__  https://review.openstack.org/53233321:39
clarkbShrews: nodepool secure file lgtm21:43
clarkbShrews: thanks21:43
*** threestrands has joined #zuul21:44
*** threestrands has quit IRC21:44
*** threestrands has joined #zuul21:44
*** JasonCL has quit IRC21:49
mordredclarkb, Shrews, corvus: any reason to not +A the secure.conf nodepool patch? it's got 3x+2 now21:51
clarkbmordred: I don't think so should handle no secure.conf just fine21:51
mordredossum21:51
clarkbthen we can add one whenever we add tls/auth to zk21:51
mordreddmsimard: role_path from my change: Role Path: /var/lib/zuul/builds/d1902e3d8aaa4390a4d7ffef408915bf/work/src/git.openstack.org/openstack-infra/zuul-jobs/roles/emit-job-header21:52
dmsimardand mine /var/lib/zuul/builds/24449f8a0fab45c98ec37631b61aa0e9/work/src/git.openstack.org/openstack-infra/openstack-zuul-jobs/roles/configure-unbound21:53
* mordred is confused21:53
mordredcause it says: Accessing files from outside the working dir /var/lib/zuul/builds/d1902e3d8aaa4390a4d7ffef408915bf/work is prohibited21:53
mordredbut /var/lib/zuul/builds/d1902e3d8aaa4390a4d7ffef408915bf/work/src/git.openstack.org/openstack-infra/zuul-jobs/roles/emit-job-header is not outside of /var/lib/zuul/builds/d1902e3d8aaa4390a4d7ffef408915bf/work21:53
dmsimardmordred: your change doesn't expose what I talked about21:53
dmsimardmordred: we need to print role_path from within zuul-jobs21:53
dmsimardso your patch should depends-on my patch21:54
mordredkk. lemme do that21:54
dmsimardthe behavior is around implied roles that zuul prepares I think21:54
mordredgotcha21:54
SpamapSeverybody watch out. harlowja has fallen in love with YAML and Zuul21:55
mordredSpamapS: WOOT21:55
harlowjaummm21:55
SpamapShe's SO smooth at writing zuul jobs now21:55
harlowjai understand it, not sure love yet21:55
harlowjalol21:55
* mordred hands harlowja a nice fluffy bunny21:55
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: DNM print role_path  https://review.openstack.org/53231921:55
harlowjathere are a few things that i think jenkins is doing better, that may be needed to really take it over21:55
SpamapSand even better, his zuul jobs write YAML to run kolla which is in YAML and it's all YAML21:55
SpamapSYAAAAMMMLLLL21:55
harlowjajenkins (though its plugins suck) is imho doing them better (ie, shared roles/libraries)21:56
SpamapSWe need to get shirts that show the zuul monster eating yams.21:56
harlowjaso that's one thing21:56
SpamapSWe can call the zuul mascot "the yaminal"21:56
harlowjajenkins also has slightly different parallel abilities than zuul21:56
*** JasonCL has joined #zuul21:56
harlowjajenkins (in groovy) can dynamically grab slaves (of ?? any ?? amount)21:56
harlowjathat's sorta different than nodeset21:56
mordredharlowja: by 'different' I think you mean 'falls over at a much lower scale'21:56
SpamapSharlowja: yeah that was one that I liked that you showed me. Having run-time nodesets basically.21:56
harlowjaand what else, oh ya, the UI21:57
harlowjafor those that want a nice UI, i think the blueocean stuff may be nicer (for simpler things)21:57
harlowjaSpamapS ya, something like runtime nodesets21:57
SpamapSSo instea dof like "I want a box named foo" it's "I want a box per value in this variable"21:57
harlowjahttps://jenkins.io/blog/2017/09/25/declarative-1/#parallel-stages21:57
harlowja^ the groovy thing21:57
harlowjaparallel really takes a map of functions (string key, value function)21:58
SpamapSwould be good for DRY'ing when you have a generic job.21:58
mordredyah - so - this is a conceptual difference - there are things that jenkins treats as job functions in groovy that in zuul v3 almost always should actually be in the ansible rather than in the zuul21:58
SpamapSAlso I do think there is a missing model in Zuul, and we've talked about it a few times, which is the "thing that follows a change from PR->package"21:59
harlowjamordred idk, need more description of what u think the difference is21:59
harlowjaSpamapS PR -> package -> next -> next -> next21:59
harlowjahttps://jenkins.io/doc/pipeline/steps/ is also increasing (weekly) - for better/worse22:00
mordredharlowja: from my pov, jenkins pipelines are equivilent to ansible playbooks not to zuul jobs22:00
harlowjasorta like playbooks, yes22:00
clarkbSpamapS: jenkins doesn't have that model either though right?22:01
*** rlandy|brb is now known as rlandy22:02
SpamapSclarkb: build#22:02
SpamapSit does22:02
mordredyah, so basically, we have no interest in having zuul grow features in the way that jenkins pipelines have - that's ansible's job ... that said, the 'this job will want different types of nodes at different times' has come up from a few different people, so it seems lke something that needs to be addressed, even if addressing it is documentation or something22:02
harlowjathe thing that jenkins doesn't have is the nodeset concept22:02
harlowjawhich is nice to be able to have22:02
SpamapSclarkb: because jenkins pipelines go across what zuul calls pipelines.22:02
*** JasonCL has quit IRC22:02
harlowja(in jenkins u can't at least not now request for a node then later use it, u have to use it immediatly)22:03
harlowjau can't get X nodes, then decide how u want to use them in a later part of the script (afaik)22:03
clarkbSpamapS: sort of, jenkins pipelines don't mix multiple triggers aiui its more a waterfall from some origination event right?22:03
SpamapSclarkb: yep, they take the change from start to stop22:03
clarkbSpamapS: oh so there are checkpoints where it waits for next event to happen? TIL22:04
clarkbharlowja: ya that limitation was why our multinode testing was always so weird22:04
clarkbharlowja: where we hacked in nodesets by giving jenkins the "primary" node then it could discover the rest of the set22:05
harlowjaclarkb ya, i have a feeling they have to eventually fix that22:05
SpamapSclarkb: well more like, it does the thing and then keeps moving forward22:05
harlowjai mean, with groovy is so close, lol22:05
harlowja*it is so close22:05
clarkbSpamapS: except you don't want to build the package until the change merges, and you don't want to run th gate builds until the change has been approved22:05
SpamapSclarkb: so like, it gets a trigger to land a commit, builds stuff.. runs tests, lands commit, keeps going22:05
clarkbSpamapS: each of those requires a checkpoint to prevent the single event from cascading through it all22:06
SpamapSThat's not how jenkins pipeline users use jenkins. :)22:06
clarkbSpamapS: right they are fundamentally different22:06
mordredyah. jenkins is an arbitrary ad-hoc automation platform with a web gui22:07
clarkbso jenkins pipelines don't cross zuul pipelines22:07
clarkbjenkins is just run jobs one after another and if that works for you thats great22:07
SpamapSAgreed, but the fact that I get to keep my gate artifacts as the end-artifacts is huge.22:07
SpamapSwell they do cross from what we call gate to post.22:07
SpamapSthe pipeline will gate and then post all in one pipeline run.22:08
clarkbI see22:08
SpamapScarrying the build# through22:08
clarkbso its a psecial case of checkpoint where gate has to pass to do post22:08
clarkbdoes jenkins do the git merging too?22:08
corvusthe constant between a pre-merge pipeline and a post-merge pipeline is the change.  one could store gate artifacts keyed by change and then use them in post.22:08
SpamapSthat I don't know.22:08
mordredcorvus: yah. that22:08
corvusSpamapS: is there something preventing that approach ^?22:08
SpamapScorvus: I don't have access to a consistent "change" in post.22:09
SpamapSI get a Branch effectively.22:09
SpamapSwith a different sha22:09
corvusSpamapS: you use github, right?  isn't there a pr-merged event or something?22:09
SpamapSno it's a push, IIRC22:09
SpamapSI could be wrong22:09
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: webapp: add optional admin endpoint  https://review.openstack.org/53171822:10
corvusSpamapS: we created our post pipeline based on ref-updated due to a very specific gerrit behavior, i would prefer to build it on change-merged (and would probably spend some effort doing so if it were important to workflow)22:10
clarkbwe could also do a lookup22:11
clarkbeither in zuul or the job, but find out what the change was for this project + branch + changeid combo22:11
clarkbsince that is the key tuple for looking up changes22:11
corvusclarkb: yeah, that's a possibility22:12
corvusthere is a pull request closed event, however i'm not sure of 2 things: 1) what would be involved in differentiating merged vs abandoned.  2) whether the merge sha is provided (this is the same piece of info missing from gerrit that led us to use ref-updated)22:13
SpamapSYeah IIRC we punted on that for Bonny for similar reasons.22:14
corvusat any rate, generally speaking, having a trigger with both the change id and sha solves a lot of problems -- it makes the workflow under discussion easier, and it lets us do things like provide retrospective reports on changes.22:14
corvuszuul's drivers are getting sophisticated enough it may be worth correcting the github and gerrit deficiencies in this by doing lookups.22:15
SpamapSthat would be nice.22:15
SpamapSfor now, just ignore harlowja22:15
corvus3.1 :)22:15
SpamapShe's just jelly ;)22:15
mordredSpamapS: I've always thought of him more as a marmalade myself22:16
*** dkranz has quit IRC22:19
harlowjaya, ignore me, lol22:34
SpamapSyou see the burning envy on display^^22:34
SpamapS;)22:34
*** JasonCL has joined #zuul22:43
openstackgerritMatthieu Huin proposed openstack-infra/nodepool feature/zuulv3: webapp: add optional admin endpoint  https://review.openstack.org/53171822:46
clarkbmordred: fyi https://storyboard.openstack.org/#!/story/2001459 filed for the apt et al task logging22:57
*** jlk is now known as Guest7623:03
*** hasharAway has quit IRC23:04
Guest76corvus: Sorry I missed it. I'm at orientation for my new gig all week.23:05
*** Guest76 is now known as jlk23:06
jlkuh23:06
jlkcorvus: Sorry I missed, I'm at orientation for my new gig all this week.23:06
clarkbShrews: that secure.conf change retry limited on a pep8 change?23:15
clarkbcurrent opnstack gate also has a timeout on a unittest change23:15
clarkbwe may need to dig in and look at zuul stability23:15
clarkbload average: 25.27, 17.15, 12.63 on ze10 may explain http://logs.openstack.org/36/531836/1/gate/cross-neutron-py27/605a6da/job-output.txt.gz timing out23:18
clarkbhrm actually that job may just have a timeout that is too short to run neutron unittest but the ze10 load does seem high23:20
*** jlk is now known as Guest7623:29
mordreddmsimard: why did it work this time????? https://review.openstack.org/#/c/532319/23:40
mordreddmsimard: like, there is no reason why depends-on on your ozj job should fix it ...23:46
mordreddmsimard: OH ...23:46
SpamapShm... trying to add sql reporter to my zuul and it is kind of just freezing up23:46
mordredSpamapS: also, be aware there is a github/sql-reporter bug that tobiash was working on a fix for23:46
mordredSpamapS: https://review.openstack.org/#/c/532237/23:47
mordredSpamapS: column type issue23:47
SpamapSaha23:47
SpamapSwell then I will just back that change right out23:47
SpamapSwell actually23:48
* SpamapS fires up gertty23:48
mordreddmsimard: having ozj in the depends-on path means that zuul will have checked out the role potentially into a different path23:48
mordredSpamapS: I just now hit +A - I think you want to *add* that change to your local install if you want to use sql-reporter and github23:48
mordredSpamapS: I don't know why it would cause a hang though23:49
mordredbut I didn't do any of the troubleshooting on it23:49
SpamapSYeah I don't think that's the hang problem23:49
SpamapSI'm stracing to figure that out23:49
SpamapSbecause there's no logs or anything23:49
SpamapSit's just stuck in 'futex'23:49
*** ianw has quit IRC23:50
mordredSpamapS: silly futex23:51
SpamapSoh my..23:51
SpamapSsomething is eating my stderr23:51
SpamapS[pid  7915] write(2, "ImportError: No module named 'py"..., 39ImportError: No module named 'pymysql'23:51
*** ianw has joined #zuul23:51
mordredSpamapS: maybe the stderr eating is related to the earlier conversation about appropriate behaviors in daemonizing and non-daemonizing modes? (I will admit I wasn't paying perfect attention to them)23:52
SpamapSmordred: I'm running under systemd with -d23:53
SpamapSand nor was I paying attention23:53
SpamapSfor that matter23:53
SpamapSI forgot to pay attention to my stomach23:53
* SpamapS afks for refueling23:53
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Change patchset column to string  https://review.openstack.org/53223723:57
SpamapS\o/23:57
* SpamapS rebases local branch on that23:57
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Slack driver  https://review.openstack.org/53052123:59
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Add support for a secure ZooKeeper configuration  https://review.openstack.org/53188223:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!