Tuesday, 2018-01-02

openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Slack driver  https://review.openstack.org/53052100:29
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Slack driver  https://review.openstack.org/53052100:36
SpamapSHrm.. this is an interesting conundrum. I want to use Slack threading to report all the things related to a commit into a single thread. I guess I can keep a commit<->thread_ts cache in the driver.00:45
tristanCSpamapS: congrats on zuulception :-) Did you find a way to auto restart the scheduler?01:02
tristanCperhaps we could add a graceful stop to the scheduler so that we can start another one with the new code...01:03
*** xinliang has joined #zuul01:29
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: DNM: negative test  https://review.openstack.org/52243801:43
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: DNM: negative test  https://review.openstack.org/52243801:47
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: unittests: make bindep role optional  https://review.openstack.org/52225501:54
SpamapStristanC: No I didn't. I just do it manually.03:00
SpamapStristanC: what we really need is a SIGUSR2 or something that means "save queue, re-exec, slurp queue, after all running jobs finish"03:01
*** jaianshu has joined #zuul04:12
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add buildset-artifacts-location role  https://review.openstack.org/53067904:49
*** bhavik1 has joined #zuul05:31
*** bhavik1 has quit IRC05:34
tobiashSpamapS: currently I have the scheduler as a statefulset05:41
tobiashAnd no lifecycle stuff yet05:42
tobiashThe plan is to at least save queues periodically on a volume and reenqueue the items on startup05:43
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add linter job and roles  https://review.openstack.org/53068205:55
*** jaianshu_ has joined #zuul06:16
*** jaianshu has quit IRC06:20
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add buildset-artifacts-location role  https://review.openstack.org/53067906:20
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Slack driver  https://review.openstack.org/53052106:21
SpamapSjhesketh: ^ your config concerns were spot on. There's an updated version that makes more sense I think.06:21
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Slack driver  https://review.openstack.org/53052106:27
SpamapStobiash: ^ Also I addressed your review comments there. Thanks for the feedback.06:27
SpamapStobiash: Ah I'm so used to not having statefulset .. that should work fine.06:29
* SpamapS has a super old k8s :-P06:29
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add buildset-artifacts-location role  https://review.openstack.org/53067906:32
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Add linter job and role  https://review.openstack.org/53068206:41
openstackgerritTristan Cacqueray proposed openstack-infra/zuul-jobs master: Fix pep8/yamllint errors  https://review.openstack.org/53068506:43
*** hashar has joined #zuul08:29
*** yolanda has quit IRC09:13
*** yolanda has joined #zuul09:16
*** jaianshu__ has joined #zuul10:15
*** jaianshu_ has quit IRC10:18
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: Make Zuul able to start with a broken config  https://review.openstack.org/52906011:29
*** jkilpatr has joined #zuul12:07
*** rlandy has joined #zuul13:07
*** rlandy is now known as rlandy|ruck13:14
*** jaianshu__ has quit IRC13:33
*** dkranz has quit IRC13:57
*** maxamillion has joined #zuul14:34
*** pall is now known as pabelanger14:45
*** dkranz has joined #zuul14:59
*** rlandy|ruck is now known as rlandy|ruck|mtg15:00
*** jaianshu has joined #zuul15:37
*** rlandy|ruck|mtg is now known as rlandy|ruck16:01
*** kmalloc has joined #zuul16:09
Shrewsnodepool git history seems to indicate we had issues with the new quota feature. Did that get resolved?16:19
clarkbShrews: yes I think it did.16:20
Shrewscool16:20
*** rlandy|ruck is now known as rlandy|ruck|mtg16:21
clarkbShrews: I466e64a999ebf867ada9462a0c00a90de4b70125 and Id488c070df991a554570c5717dc85aec351fed45 were both changes to address the problems we had16:21
corvusi think there's one thing that's still reverted out -- we now mark requests as failed if they hit an unexpecetd over-quota error16:22
corvusthat was also the old behavior16:22
Shrewsyeah, was just looking those over16:22
corvusthe new quota patches changed that to make it a non-fatal error, but there were structural issues with that, so we just went back to the old behavior16:22
corvus(i'm sure it can be fixed, just needs some thought)16:23
Shrewsclarkb: corvus: thx for the catchup16:24
*** jaianshu has quit IRC17:01
*** jaianshu has joined #zuul17:01
SpamapSbtw I am finding nodepool to be a real joy to work with. I haven't been part of infra running it, so it's all new to me, and I find myself wishing all my apps were backed by nodepool.17:06
SpamapSI actually think nodepool might be a really great way to run Kubernetes clusters actually.17:06
SpamapSso many actuallies17:07
*** rlandy|ruck|mtg is now known as rlandy|ruck17:07
pabelanger+117:08
corvusSpamapS: \o/  i think the request model is going to open a lot of doors in the future17:08
SpamapSJust the idea of actually treating cloud instances like the ephemeral things that they're so good at being... with pools, mins, builders going on in the background. It's a nice experience.17:09
corvusi looked over the todo list, and i'm going to start work on the 'support cross-source dependencies' task.  so i'm going to be spending big chunks of time focusing on that.17:10
SpamapSThat was the one that scared me the most so I stayed away from it. ;)17:10
corvusi think i'm ready for it.  i can do this.  i know i can.17:11
clarkbI've not even made caffeine yet17:11
corvusi had some yesterday.  that should be enough.17:11
clarkbI found ginger mate tea17:12
*** jaianshu has quit IRC18:10
*** harlowja has joined #zuul18:12
Shrewscorvus: If you get a moment, I'm very confused as to why https://review.openstack.org/520664 does not run the new nodepool-functional-devstack-py35 job I'm trying to define.18:13
corvusShrews: my guess: devstack has no feature/zuulv3 branch so there's no matching devstack job for that branch....18:25
openstackgerritJames E. Blair proposed openstack-infra/nodepool feature/zuulv3: WIP: Convert from legacy to native devstack job  https://review.openstack.org/52066418:25
corvusShrews: but we added a neat thing to zuul in december so you can ask it questions like that:  ^18:26
Shrewsneat18:26
corvusShrews: so, erm, we'll have confirmation of that in 40 mins :)18:26
Shrewscorvus: fwiw, the fingergw didn't automatically start (was it supposed to?) so i started it by hand on zuulv318:27
openstackgerritJames E. Blair proposed openstack-infra/nodepool feature/zuulv3: WIP: Convert from legacy to native devstack job  https://review.openstack.org/52066418:27
corvusShrews: ^ i dropped all the other jobs so we should get the answer faster18:27
Shrews++18:27
corvusShrews: that sounds right.  i like to avoid having puppet auto-start services.  but it'll be configured to start on boot.18:28
corvusShrews: thanks for doing that.  does it work? :)18:28
Shrewscorvus: looks like we might need to open access to port 7918:28
corvusoh yep18:28
corvusShrews: i think that's in system-config if you want to take that18:28
Shrewssure18:28
corvusShrews: meanwhile, i'll think about how to solve that devstack job problem.18:29
Shrewscorvus: thx. i still find the way zuul handles branch jobs perplexing. i should spend some time studying that18:31
corvusShrews: the results are in on https://review.openstack.org/#/c/520664/18:38
Shrewscorvus: yeah, trying to decipher the results18:39
corvusShrews: look at the review message zuul left on there (if you're using the web ui, you may need to hit toggleci; if you're using gertty, you may want to use the webui because of the superlonglines)18:39
Shrews"No matching parent for 'devstack'"18:40
corvusShrews: yeah, and the lines above show the branches where there is a 'devstack' defined.  so i think that confirms the hypothesis18:40
Shrewsshouldn't that be found in openstack-dev/devstack/.zuul.yaml@master ?18:40
corvusShrews: it is, but that only matches changes on master, not feature/zuulv318:41
corvusShrews: (so, iow, one way to 'solve' this is to merge nodepool feature/zuulv3 into nodepool master)18:41
Shrewscorvus: so if i derive from another job in another repo, that other repo has to have the same branch?18:42
corvusShrews: if the other repo is branched, yes18:42
ShrewsTIL18:42
corvusthis doesn't apply to project-config, zuul-jobs, etc18:42
Shrewsmordred: fyi, since we were both confused about that native devstack job ^^^18:43
corvusbut it's what makes "this is how to run devstack on pike" and "this is how to run devstack on ocata" work.18:43
Shrewscorvus: ok. i can pick that back up when we merge back to master then18:43
Shrewsthat makes sense18:43
corvusShrews: we should probably come up with another solution though, just to solve this use case...18:43
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: Fix sphinx publishing  https://review.openstack.org/53079018:44
corvusmaybe we need to have a fallback branch when looking for parent jobs.  or maybe we need to drop the implicit branch matcher from the master branch of devstack.18:44
Shrewscorvus: a 'parent-branch' option?18:44
Shrewsto be explicit about it18:45
corvusShrews: yeah -- that would be basically an explicit fallback branch for parents...we could also consider having an implicit fallback branch...18:45
*** jkilpatr has quit IRC18:46
corvusi'm not coming up with a reason not to do a fallback branch when searching for parents.  it needs to only happen if there are no matches (ie, you don't always want to use master if, say, pike matches).  but other than that i think it would be okay.18:49
Shrewsseems like logical behavior to me, IMO18:51
corvusthere is a way we can make this work now, though it requires a (benign) change to the devstack repo...18:52
corvuser, i'd link to the docs, but they haven't been updated due to the bug being discussed in #-infra18:53
Shrewscorvus: it's not urgent to get it working now. just some cleanup that eventually should be done18:54
corvushttp://logs.openstack.org/05/527805/2/gate/build-openstack-sphinx-docs/67ee106/html/user/config.html#attr-pragma.implied-branches18:54
Shrewsi'm just happy to understand the problem now18:54
corvusShrews: there's the draft docs build for the change i'm thinking of ^18:54
corvusif we added ['master', 'feature/zuulv3'] to implied-branches in the devstack repo, the job would work.  however, i don't think we should do that -- devstack has no business knowing there's such a thing as a feature/zuulv3 branch.18:55
corvusi think adding an explicit branch matcher to devstack that matches master or a negative lookahead which matches everything except stable/* would be okay though.18:56
Shrewscorvus: yeah, bad knowledge inversion there18:56
corvusi'm inclined to think that either that ^ or the fallback branch is the way to solve it.18:56
Shrews++ for fallback (either implicit or explicit or both)18:57
corvusi'll cipher on this a little more, then maybe write up a description18:58
*** jkilpatr has joined #zuul19:00
*** JasonCL has joined #zuul19:36
*** jkilpatr has quit IRC20:27
*** dkranz has quit IRC20:37
*** dkranz has joined #zuul20:38
*** jkilpatr has joined #zuul20:41
*** JasonCL has quit IRC21:01
*** jkilpatr has quit IRC21:04
*** jlk` has joined #zuul21:05
*** jlk has quit IRC21:06
*** JasonCL has joined #zuul21:13
*** jlk` is now known as jlk21:15
*** jlk has quit IRC21:16
*** jlk has joined #zuul21:16
*** jkilpatr has joined #zuul21:33
*** dkranz has quit IRC21:43
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Support cross-source dependencies  https://review.openstack.org/53080622:21
SpamapSpabelanger: btw, my memory governor patches conflict badly with recent executor changes, I basically have to rewrite half of it from scratch. Haven't found time to do that just yet.22:33
pabelangerkk, I was going to look into it in the morning22:34
pabelangerso much push up a patchset if I can figure it out :)22:34
SpamapSIt's a simple patch.22:46
SpamapSJust that things got moved around a lot and git is confused.22:46
SpamapSAlso we need to switch the virtual memory total we use so that we don't count cache/buffer as "used" so we don't get thrashing.22:47
SpamapS(Though I'd argue we should consider having a third governor and not accepting jobs if we're really low on cache/buffer too)22:47
openstackgerritClark Boylan proposed openstack-infra/zuul-jobs master: Fix sphinx publishing  https://review.openstack.org/53079022:49
*** hashar has quit IRC23:05

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!