Tuesday, 2017-12-12

*** mwhahaha has joined #zuul00:05
*** fdegir has joined #zuul00:10
*** Shunde has joined #zuul00:40
ShundeHello, I am new to zuulv3, just wondering which is the stable version of zuulv3?00:41
clarkbShunde: there hasnt been a zuulv3 release yet that is considered stable (major progress is being made though)00:43
jeblairwe're hoping to finish everything up and release early next year00:45
Shundethanks guys. can I use it in prod by then?00:46
dmsimardShunde: OpenStack runs it's production on it at peak more than a 1000 concurrent jobs. It works for us but not what we'd call stable release quality.01:10
dmsimardReal soon now, though.01:12
ShundeOK. I'd like to give it a try. Is there any document I can follow if I want to install and have a play?01:13
jlkShunde: https://docs.openstack.org/infra/zuul/ is updated with the v3 content01:15
pabelangerodd, that should still be v2 for that URL. https://docs.openstack.org/infra/zuul/feature/zuulv3/ is likey the latest on zuulv301:18
pabelangerpossible we need to retrigger a master build to fix that01:18
*** Shunde has quit IRC01:27
*** jhesketh has quit IRC01:59
*** shunde has joined #zuul02:05
*** dmellado has quit IRC02:42
*** dmellado has joined #zuul02:48
*** shunde has quit IRC03:17
*** Wei_Liu has quit IRC03:34
*** dmellado has quit IRC03:37
*** dmellado has joined #zuul03:38
SpamapSso.. how do I get Builds and Jobs for my zuulv3?03:47
SpamapSis it hiding somewhere in zuul-web and I just need to plumb it through with my nginx frontend?03:48
SpamapS(Those are really neat btw)03:48
jlkyeah I think it's hanging off of zuul-web, or is about to be03:50
*** Wei_Liu has joined #zuul03:51
SpamapSCool03:58
SpamapSfunny story.. did you all know that kubernetes has a du-based disk accounting feature too? But it kind of stinks, because they launch a du-per-volume. I was thinking maybe we should help them by changing it to be more like the executor's disk accountant which saves a lot of IO by doing all of the active work dirs at one time.03:59
SpamapS(This is for the 'emptyDir' volume driver, which is a way to get writable disk space that survives node reboots and container crashes)04:02
jlkSpamapS: wanna learn some Go? :)04:03
jlkI sat through a number of "serverless" talks, from people bringing functions as a service to k8s, which was super neat. The concept of a tiny bit of code that's ready to go, a router (LB) that can send tasks to the function, and the ability to use in-built metrics to quickly scale out (and back) the number of pods that can handle the request fits REALLY WELL with a CI system.04:05
SpamapSzomg04:05
SpamapShttps://github.com/gitpython-developers/GitPython/releases/tag/2.1.804:05
SpamapS @Byron Byron tagged this 12 hours ago ยท 0 commits to master since this tag04:05
jlkIt had me thinking of ways to bend Zuul to be more "serverless", and then I just had to stop, and realize that Zuul in k8s could also use the metrics for doing horizontal scaling of executors, web handlers04:05
SpamapS\o/04:05
SpamapS'tis up on pypi04:06
jlkWas there something significant to the GitPython release?04:06
SpamapSpy3 fixes and a gc-induced performance regression04:06
jlkah04:06
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Drop local fork of GitPython for 2.1.8 release  https://review.openstack.org/52729804:07
SpamapSI'm guessing somebody poked them to ask for release/merge04:07
SpamapSSo I'm probably stealing their thunder. ;)04:08
jlkI saw some issues with certain git features that if you cloned via gitpython, you got some bad stuff04:08
jlkdunno, there was a bunch of activity around the Fedora packaging tools that I wrote a long time ago wrt new git and gitpython releases04:08
*** shunde has joined #zuul04:10
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Drop local fork of GitPython for 2.1.8 release  https://review.openstack.org/52729804:10
* SpamapS adds storyboard tags04:10
SpamapSjlk: I've seen some weirdness too04:11
shundeHi, is it possible to start zuulv3 without a connection? and create a job with cli tools?04:11
SpamapSshunde: sort of, but it's not really effective.04:11
SpamapSshunde: there's a "git only" driver in the works for that, but it's half done.04:11
SpamapShttps://storyboard.openstack.org/#!/story/200133604:12
SpamapSleifmadsen: btw, how is the getting started guide going? I might have a little time to work on it next week.04:13
SpamapSHrm. I need a slack reporter so I can whine if a post job fails. Email is so gauche.04:15
jlklol04:15
clarkbgitpython has its issues if you look in the merger git code you'll find ee found quite a few of them04:21
clarkbmy favroite is needing to ignore the first error on git fetch and try again tonsee if the error is real04:22
SpamapSif you can't trust gitpython... who can you trust?04:24
SpamapSoh fun, latest pull seems to have broken my status.json.. hrm04:32
SpamapSgah broke all webhooks too hrm04:37
SpamapShttp://paste.openstack.org/show/628673/04:43
SpamapShrm that doesn't look good04:43
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Remove unused setup_tables  https://review.openstack.org/52697004:50
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Support table prefix for sql reporter  https://review.openstack.org/52683504:50
SpamapSok scheduler apparently needed a hard restart04:54
SpamapSbut now I'm getting static html that requests /static/js/stuff but there is no /js/ dir in static04:55
SpamapSoh look there's a README buried in there04:56
dmsimardSpamapS: I was reading your k8s storage stuff05:07
dmsimardWe had the same "du" thing in OpenShift, we ended up killing it I think. It was for telemetry/monitoring and we didn't care.05:07
dmsimardAlso, emptydir doesn't survive pod destruction so it depends on the use case I guess, we use hostpath05:09
SpamapSdmsimard: emptyDir is the only thing we alow on our internal k8s clusters. I am not sure if we care either.05:10
dmsimardjlk: oh wow scaling executors in k8s would be wild (in a good way)05:11
dmsimardIn our context, maybe nodepool could provision ephemeral executors ??05:12
dmsimardHuh, that'd be kinda cool. Maybe.05:13
SpamapSYeah that's one possibility.05:13
SpamapSEntirely doable now actually.05:14
dmsimardYeah I was thinking05:14
dmsimardWe even have load and disk governor05:14
* SpamapS translates the zul-web static README into some ansible for his far-flung fork of hoist05:14
dmsimardWe could autoscale automatically05:15
*** shunde has quit IRC05:15
SpamapSdmsimard: well I kind of think we'd stop relying on that actually05:15
SpamapSdmsimard: let a normal k8s autoscaler do it with heapster05:15
SpamapSif you want to do it with nodepool tho, yeah, the load/disk thing would be one possibility. Whenever you trigger the "stop accepting jobs" you could also tell nodepool you wish you had another node.05:16
dmsimardk8s and heapster, that's a complicated stack for something we can already do :p05:16
SpamapSbut it's also a lighter weight solution if you already have k8s :)05:20
* SpamapS didn't necessarily want to be building ansible to minify javascript this evening.. but it seems worth it to get the new pretty zuul-web05:34
tobiashSpamapS: so you're running zuul on k8s?05:36
tobiashI'm running it also on k8s (openshift in our case)05:37
SpamapSno, I would like to, but for now, I have a VM with our old BonnyCI hoist pointed at it.05:37
tobiashah05:37
SpamapSand many many local changes to suit GoDaddy's specialness05:37
SpamapSmostly CentOS 7 :-P05:37
tobiashthe lovely centos :-P05:38
SpamapSYeah honestly I don't get why folks use CentOS. Just go Fedora or pay up for the real RHEL ;)05:38
SpamapStobiash: I recall you were running in Alpine, yes?05:39
tobiashthe container yes05:39
tobiashMy openshift now runs on centos atomic05:39
*** robcresswell has quit IRC05:39
SpamapSWe have k8s running on CentOS VMs running on OpenStack. I'm using Zuul to CI the automation that deploys that k8s and I keep thinking "why don't we.. like.. run the zuul there?"05:41
SpamapStobiash: for zuul-web and the like, are you running an nginx/apache in a container too?05:41
tobiashyes05:41
SpamapSWould be nice if we could just use the built-in k8s LB/ingress.05:41
SpamapSbut I don't think it's smart enough05:42
tobiashwell that doesn't support url rewriting05:42
tobiashI use route - apache - zuul-web05:43
tobiashBecause my zuul runs under /zuul05:44
tobiashAnd zuul-web doesn't support that05:44
SpamapSyeah I've got nginx in front of mine05:45
SpamapSalso github hooks still live in the scheduler05:45
*** fungi has quit IRC05:45
tobiashthe github hooks are close to being moved to zuul-web05:46
SpamapSYeah that should make my nginx pretty stupid at that point. :)05:46
*** fungi has joined #zuul05:48
clarkbhow do you do data storage for the zk if you only have ephemeral disk? just hope you dont lose all computes running zk at same time?05:52
clarkbthis is specifically for SpamapS based on earlier disk storage discussion)05:53
tobiashclarkb: currently I don't05:53
tobiashclarkb: but planning to use persistent volumes05:53
SpamapSclarkb: have a bunch in your ensemble and use node-anti-affinity would be the elegant answer. :)05:54
tobiashas a workaround as my log storage (will be artifactory) is not yet available I host the logs on the executor on a persistent volume05:54
SpamapSzomg it works!05:56
SpamapSthis new dashboard is sooooo nice05:56
tobiash:)05:56
tobiashyay, the sql table prefix merged :)05:56
tobiashso now I also can start pushing results into sql :)05:57
SpamapSassuming console streaming works as I expect... I can probably delete half my nginx conf.05:57
SpamapStobiash: nice05:57
tristanCtobiash: i'm surprise you didn't picked it in your staging container ;)05:58
clarkbSpamapS: at least losing nodepools zk isnt the end of the world but not sure I would rely on that for data I really cared about05:58
clarkbI suppose you could "offsite" backup too05:58
tristanCtobiash: are you running nodepool with the new quota?05:58
tobiashtristanC: actually this was a saturday morning idea that I want this and I had no time to add this to my staging branch ;)05:59
tobiashtristanC: I have the nodepoo quota patches in my staging branch since they exist05:59
tristanCtobiash: lucky you to get a patch merged in 3 days :-)06:00
tobiashwell the quota patches are still not merged, but I think they will be soon06:01
SpamapSclarkb: Agreed. The word on k8s for stateful services is "soon"06:01
SpamapSthere _are_ volume drivers06:01
SpamapSMy users desperately want us to hook k8s up to cinder.06:02
SpamapSWhich is apparently possible.. but.. for now emptyDir, a good ensemble (n+1, so 5 or 7) and AZ anti-affinity should do OK. Maybe also ship the snapshots off to object storage too06:03
tobiashSpamapS: that works great if rwo volumes are sufficient for the use case06:03
tobiashremove build ssh key failed on https://review.openstack.org/#/c/526971/06:06
tobiashI'll do a recheck06:06
tobiashtristanC: re https://review.openstack.org/#/c/503838/18/nodepool/driver/openstack/handler.py@34706:12
*** xinliang has quit IRC06:13
tobiashthis is currently a private method within the openstack handler06:13
tobiashwhat would change with the refactoring you mentioned?06:13
tristanCtobiash: the run_handler would be part of the generic code, and a driver would implement the checkquota method to verify early if it can create a specific node label06:15
tristanCtobiash: see line 359 of https://review.openstack.org/#/c/526325/3/nodepool/driver/__init__.py06:16
tristanCtobiash: where i had to take into account if a provider has a max-servers or not... with your quota change, this refactor would be easier, we would just call the driver checkProviderQuota06:17
tobiashah I see06:17
tobiashso you're moving and generalizing the run_handler out of the openstack driver06:18
*** tflink has quit IRC06:18
tobiashtristanC: I understand this now, so the question is should this be renamed upfront or during the refactor?06:20
tristanCtobiash: as you want, i don't mind either way :)06:21
tristanCtobiash: maybe keep it private for now, it will be simple to remove the '_' prefix when it's part of the driver api06:21
tobiashtristanC: because like the codebase currently is it should be a private function which would need a rename during the refactor anyway06:22
tobiashok06:22
*** tflink has joined #zuul06:23
*** xinliang has joined #zuul06:26
*** xinliang has quit IRC06:26
*** xinliang has joined #zuul06:26
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Add cloud quota handling  https://review.openstack.org/50383806:28
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Don't fail on quota exceeded  https://review.openstack.org/50305106:28
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Make max-servers optional  https://review.openstack.org/50428206:28
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Support cores limit per pool  https://review.openstack.org/50428306:28
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Support ram limit per pool  https://review.openstack.org/50428406:28
*** sshnaidm|off is now known as sshnaidm|ruck06:49
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Add cloud quota handling  https://review.openstack.org/50383806:51
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Don't fail on quota exceeded  https://review.openstack.org/50305106:51
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Make max-servers optional  https://review.openstack.org/50428206:51
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Support cores limit per pool  https://review.openstack.org/50428306:51
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Support ram limit per pool  https://review.openstack.org/50428406:51
*** hashar has joined #zuul06:52
*** myoung|rover|bbl is now known as myoung|rover06:53
*** xinliang has quit IRC07:34
SpamapShrm, something in recent commits has made my zuul hit our GHE rate limits... or our GHE has ratcheted them down07:39
*** robcresswell has joined #zuul07:39
*** jpena|off is now known as jpena07:39
tobiashhrm, something seems to be broken, that shouldn't timeout/post_fail https://review.openstack.org/#/c/52697107:47
*** xinliang has joined #zuul07:47
*** xinliang has quit IRC07:47
*** xinliang has joined #zuul07:47
tobiashlooks like some connection issues http://logs.openstack.org/72/526972/1/check/build-openstack-sphinx-docs/54eb9b1/job-output.txt.gz#_2017-12-12_06_24_37_24335607:48
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix line wrapping in github docs  https://review.openstack.org/52697108:15
SpamapSYou know.. getting nginx to match /{{tenant}}/console-stream is really annoyingly hard08:19
tobiashSpamapS: can you match */console-stream?08:24
tobiashSpamapS: isn't nginx able to transparently forward websockets?08:25
tobiashapche is not but I think I read somewhere sometime that nginx can do this08:25
SpamapStobiash: It has to know which things to forward.08:25
SpamapShttp://paste.openstack.org/show/628681/08:27
SpamapSthat seems to work08:27
tobiashthis is my forwarding (apache based): http://paste.openstack.org/show/628682/08:27
SpamapSactually nope, this one doesn't work08:27
SpamapSif I statically put in location /tenant/console-stream it works fine (and doesn't need the rewrite line)08:28
SpamapSbut nginx has something weird about regex+proxy_pass08:28
tobiashSpamapS: what about proxying all stuff to zuul-web (except webhook)?08:32
tobiashand don't handle websockets separately?08:32
tobiashthis might also work for static content in nginx08:33
SpamapStobiash: You have to upgrade to a websocket at the nginx/apache layer.08:33
SpamapSasyncio can't do it.08:33
tobiashSpamapS: yeah, I mean upgrade regardless08:33
SpamapSOh I dunno if that works08:33
tobiashcould be worth a try08:34
tobiashSpamapS: do you need url rewriting?08:34
tobiashif not you might also try out haproxy which doesn't care about websockets08:34
SpamapSNo I think you might be on to something, static URLs are working fine with a catch-all that upgrades everything08:35
SpamapShm but zuul-web doesn't seem to be handling it well08:35
SpamapSLike once the stream starts it's fine, but otherwise there are some tracebacks08:36
tobiashwith haproxy websockets just work without any special config08:36
SpamapShttp://paste.openstack.org/show/628683/08:36
SpamapSThat may be unrelated08:36
SpamapStobiash: thanks, I don't actually need a special rule for streaming. ;)08:37
tobiashI think I saw that also in my environment08:37
SpamapS'twas an assumption based on past experience08:37
SpamapSso my nginx config has gotten even dumber. :)08:37
tobiashyeah, that's the advantage over apache where this doesn't work (one needs a special websocket proxy module for websockets)08:38
tobiashhm, can't get gearman encryption to work08:41
SpamapSSo now my nginx config is just this:08:41
SpamapShttp://paste.openstack.org/show/628686/08:41
tobiashlooks pretty minimal now :)08:42
SpamapS /connection being the github webhook08:42
tobiashthat also can be removed soon08:42
SpamapSYeah that will be sweet :)08:42
tobiashI get a gearman connect loop: http://paste.openstack.org/show/628685/08:42
tobiashconfig is http://paste.openstack.org/show/628684/08:43
tobiashcert, key, ca are existing and cat'able08:43
SpamapSThat sort of looks to me like it's saying the other side of the conn didn't return a cert08:44
SpamapSdoes openssl s_client show a cert?08:44
tobiashchecking, need to get openssl into the container08:46
SpamapShrm... now getting 'Can "Upgrade" only to "WebSocket" in zuul-web logs08:50
tobiashso upgrade all doesn't really work :(08:52
SpamapSmight not.. I'm not really sure what's up08:52
SpamapSit did work once08:52
SpamapSbut now zuul-web is unhappy08:52
SpamapSah ok I think I actually messed it up while consolidating08:55
SpamapShas to be "proxy_pass http://127.0.0.1:9000" without a trailing slash08:56
*** jappleii__ has quit IRC09:10
tobiashok, got one step further with the ssl stuff, the gear server seems to return a valid cert to openssl s_client09:15
*** dmellado has quit IRC09:17
*** flepied_ has quit IRC09:27
*** dmellado has joined #zuul09:48
*** jhesketh has joined #zuul10:04
*** dmellado has quit IRC10:07
*** flepied_ has joined #zuul10:16
*** dmellado has joined #zuul10:20
*** rcarrillocruz has quit IRC10:46
*** dmellado has quit IRC10:50
*** rcarrillocruz has joined #zuul10:52
*** dmellado has joined #zuul10:59
*** rcarrillocruz has quit IRC11:02
*** dmellado has quit IRC11:16
*** dmellado has joined #zuul11:18
*** dmellado has quit IRC11:20
*** dmellado has joined #zuul11:24
*** jkilpatr has quit IRC11:32
*** dmellado has quit IRC11:32
*** dmellado has joined #zuul11:33
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver  https://review.openstack.org/52561411:38
*** jkilpatr has joined #zuul12:05
*** hashar is now known as hasharAway12:22
*** jpena is now known as jpena|lunch12:32
*** rcarrillocruz has joined #zuul12:58
*** baiyi has quit IRC13:07
*** weshay|sickday is now known as weshay13:15
*** jpena|lunch is now known as jpena13:28
*** hasharAway is now known as hashar13:33
dmsimardtobiash: does the new zuul-web query the scheduler somehow ?14:04
dmsimardor how does it get it's data ?14:04
*** hashar has quit IRC14:10
*** toabctl has quit IRC14:10
*** toabctl has joined #zuul14:11
Shrewsdmsimard: gearman is usually used for communication between the things14:12
Shrewsdmsimard: the websocket portion of zuul-web queries the scheduler via gearman to find which executor is executing a particular build (for example)14:13
dmsimardShrews: zuulv3 memory is nuts and something definitely happened yesterday: http://cacti.openstack.org/cacti/graph.php?action=view&local_graph_id=63979&rra_id=all14:14
dmsimardIt would be odd to be zuul-web14:14
dmsimardbut trying to understand how it could've spiked so bad after being stable for a long while14:14
*** dkranz has joined #zuul14:14
Shrewsyeah, that's totes nuts. i don't know what changes have gone in recently to those though (been heads down in other things)14:14
Shrewsi saw jeblair restarted something yesterday after a force merge of a fix14:15
odyssey4methis is all still on a single host though isn't it? IIRC it was a v4 thing to allow horizontal scaling14:15
odyssey4meperhaps a bigger instance needs to be scheduled to give more headroom14:16
Shrewsdmsimard: why do you suspect zuul-web?14:16
dmsimardShrews: no particular reason, looking for things that have landed recently14:16
dmsimardShrews: jeblair sent an email yesterday to openstack-dev about the dashboard and maybe caused a bunch of people to start looking at it14:16
dmsimardthe zuul-web process itself doesn't use a lot of memory14:17
Shrewszuul-scheduler is currently taking 87.7% of total MEM. next is zuul-web with 0.4%14:17
*** hashar has joined #zuul14:28
jtannerI heard a rumor that zuul has hacked in a way to get realtime output from an ansible module call ... is that true? where could I go to find the implementation code?14:48
jtannerjlk: ^14:51
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver  https://review.openstack.org/52561414:52
rcarrillocruzI guess you mean the zuul stream stuff for streaming shell tasks14:53
clarkbjtanner: the two pieces are in https://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/ansible/library/command.py which writes to a file and then https://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/ansible/library/zuul_console.py reads it back and streams it to you14:53
clarkband ya I think its currently limited to command and things implemented with command14:54
jtannerah, thank you14:57
dmsimardjtanner: mordred would surely love to talk to you about it15:03
jtannernot for me, for someone else15:03
jtannercode refs were good enough for now15:04
tobiashdmsimard: yes, zuul-web gets the status.json via gearman from the scheduler15:28
dmsimardtobiash: ok, thanks15:29
tobiashI don't know if there is some caching15:29
tobiashdmsimard: zuul-web caches the status.json15:32
tobiashJust double checked15:32
dmsimardok, so it doesn't need to poke it every time then -- just making sure (especially around searching jobs, builds)15:33
tobiashdmsimard: maybe the duplicate key check which merged yesterday is somehow related15:36
dmsimardtobiash: we're troubleshooting in #openstack-infra-incident15:37
dmsimardJim is poking at it15:37
tobiashAh, ok, then all will be good soon :)15:38
gundalowAnyone know how the RDO cloud work is going, seems like it's still down15:56
dmsimardgundalow: probably not the right channel to ask this in but I have an answer for you ayway :D15:57
dmsimardgundalow: yes, there's still ongoing upgrades15:57
dmsimardrcarrillocruz, gundalow: this is affecting you guys I guess ?15:58
rcarrillocruzyah15:58
rcarrillocruzgundalow: there'a channel on internal redhat IRC15:58
rcarrillocruzgo to mojo, connect to it15:59
rcarrillocruz#rhos-ops15:59
rcarrillocruzdmsimard: yup, we have our CI there15:59
dmsimardrcarrillocruz: ok, yeah that channel is best to stay up to date15:59
gundalowdmsimard: yup, completly abusing this channel, though I wasn't aware of where else16:02
gundalowThanks :)16:02
rbergeronjeez, it's like an ansible party in here16:24
rcarrillocruz:D16:30
gundalowWOOT WOOT16:32
gundalowrbergeron: you said that like it's a bad thing16:32
pabelanger<3 ansible16:36
*** jpena is now known as jpena|off16:44
rbergerongundalow: def. not a bad thing :) was just funny to switch into this channel and see like... alllll the ansipeeps chatting16:46
*** JasonCL has joined #zuul16:47
gundalowrbergeron: oh that's my fault as I'm not on internal IRC, so I came here to cause trouble as I knew smart kids in here would know the answers16:47
*** hashar has quit IRC17:00
*** JasonCL has quit IRC17:01
*** JasonCL has joined #zuul17:01
*** JasonCL has quit IRC17:03
*** JasonCL has joined #zuul17:06
*** JasonCL has quit IRC17:10
*** flepied__ has joined #zuul17:33
*** flepied_ has quit IRC17:35
rbergerongundalow: i avoid that thing. mostly because it means i have to like... get on the vpn and be sad17:38
Shrewsgrrr, our common code for zuul daemon's does not allow for setting uid/gid/umask. going to have to change that for the finger gateway18:08
Shrewsoh poo. that affects grabbing the privileged listening socket18:09
Shrewshrm, i have a chicken and egg thing here with pid files and sockets18:10
clarkbShrews: because your pid changes when you fork the child to remove privileges?18:11
Shrewsclarkb: the user does, which means it cannot remove the pid file on exit18:12
Shrewsbut if i let the daemon module change the user, i can't grab port 7918:12
clarkbcan you chown before you switch users?18:12
Shrewsclarkb: oh, that might be the simplest solution18:13
*** electrofelix has quit IRC18:20
SpamapSOoo I just hit a weird bug with Github18:31
SpamapSscenario: PR against the wrong base (so I made a patch against a backport/stable branch)...18:31
SpamapSZuul immediate is like "hey this is broken t3h broke, can't merge FYI" and marks check as failed18:32
SpamapSI go "oops" close the PR, and reopen against the right base (backport branch)18:32
SpamapSthe backport branch doesn't have a 'check' pipeline because it's old 'n busted18:32
SpamapSbut the _hash_ is already marked with a check-failed18:32
SpamapSso the PR now looks like it failed tests18:32
gundalowSpamapS: FYI, In GitHub if you click the edit button (like you editing the title of the PR) you can alter the branch18:32
SpamapSgundalow: that I did not know. But either way, same problem. I need to clear that failed status.18:33
gundalowah. yes, I see18:33
SpamapSit's happening because with the github status API, statuses are against source commit hashes, not merge results/PR's18:33
clarkbthat seems liek a data model bug18:34
SpamapSso we might need to make zuul able to clear statuses it pushed if a PR is closed.18:34
SpamapSclarkb: It _SO_ is18:34
SpamapSlike, 100%18:34
SpamapSbut we're kind of working around GH's weird data model already18:34
SpamapSso we might have to work around it more.18:34
SpamapSI think the right thing is for closed PR's to cause status reports to be cleared.18:35
SpamapSso Zuul would need to see a closed PR, look at the commits in it, and clear any statuses it set as a result of that PR. I'm not 100% sure it can do that.. because I'm not 100% sure we have enough metadata in the statuses to know for sure that we set them as a result of said PR.18:36
*** Wei_Liu has quit IRC18:36
SpamapSBTW this also manifests in the rare case where the git merge method results in a "backwards" merge parent/child relationship. We set status on the last commit hash, but git goes "oh hey this changed so much, it's easier to flip the parent/child order" and then we end up with the PR showing "pending" on the gate status.18:37
SpamapS(that one is fixable if we ever teach zuul to push merges though)18:37
*** Wei_Liu has joined #zuul18:58
*** myoung|rover is now known as myoung|rover|bia18:58
*** myoung|rover|bia is now known as myoung|rover|bbl19:00
*** JasonCL has joined #zuul19:41
*** JasonCL has quit IRC19:43
*** JasonCL has joined #zuul19:44
*** JasonCL has quit IRC19:49
kklimondajeblair: when you mention "repl" on -incident, is this a local patch not yet merged? the only mention of REPL I can find is https://review.openstack.org/#/c/508793/19:51
jeblairkklimonda: yes, that patch, which i have applied locally19:52
kklimondamhm19:52
*** JasonCL has joined #zuul19:59
*** JasonCL has quit IRC20:02
*** JasonCL has joined #zuul20:02
*** myoung|rover|bbl is now known as myoung|rover20:05
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver  https://review.openstack.org/52561420:17
*** flepied__ has quit IRC20:17
openstackgerritMerged openstack-infra/zuul-jobs master: releasenotes: Remove package install  https://review.openstack.org/52685020:19
*** dmellado has quit IRC20:32
*** umbarkar has joined #zuul20:33
*** jkilpatr has quit IRC20:33
*** openstackgerrit has quit IRC20:34
*** dmellado has joined #zuul20:34
*** patriciadomin has quit IRC20:35
*** tflink has quit IRC20:35
*** tumbarka has quit IRC20:35
*** _ari_ has quit IRC20:35
*** myoung|rover has quit IRC20:35
*** myoung has joined #zuul20:39
*** tflink has joined #zuul20:39
*** patriciadomin has joined #zuul20:40
*** _ari_ has joined #zuul20:40
*** adam_g has quit IRC20:45
*** kmalloc has quit IRC20:45
*** clarkb has quit IRC20:45
*** clarkb has joined #zuul20:45
*** kmalloc has joined #zuul20:45
*** adam_g has joined #zuul20:46
*** myoung is now known as myoung|rover20:47
*** patriciadomin has quit IRC20:47
*** JasonCL has quit IRC20:47
*** JasonCL has joined #zuul20:48
*** patriciadomin has joined #zuul20:50
SpamapSFYI, I submitted my github issues as a story here; https://storyboard.openstack.org/#!/story/200140320:50
*** JasonCL has quit IRC20:52
*** openstackgerrit has joined #zuul21:00
openstackgerritJeremy Stanley proposed openstack-infra/zuul-base-jobs master: Add generic base and base-test jobs/playbooks  https://review.openstack.org/52614021:00
*** JasonCL has joined #zuul21:07
*** qwc has quit IRC21:07
*** qwc has joined #zuul21:09
*** JasonCL has quit IRC21:20
*** JasonCL has joined #zuul21:21
*** jappleii__ has joined #zuul21:23
*** JasonCL has quit IRC21:24
*** jappleii__ has quit IRC21:24
*** JasonCL has joined #zuul21:25
*** jappleii__ has joined #zuul21:25
*** jappleii__ has quit IRC21:26
*** JasonCL has quit IRC21:26
*** jappleii__ has joined #zuul21:27
*** flepied__ has joined #zuul21:27
*** JasonCL has joined #zuul21:27
*** jappleii__ has quit IRC21:27
*** jappleii__ has joined #zuul21:28
*** JasonCL has quit IRC21:34
*** dkranz has quit IRC21:40
*** JasonCL has joined #zuul21:50
*** JasonCL has quit IRC21:51
*** JasonCL has joined #zuul21:52
*** JasonCL has quit IRC21:59
*** jkilpatr has joined #zuul22:04
*** JasonCL has joined #zuul22:24
*** JasonCL has quit IRC22:26
*** JasonCL has joined #zuul22:26
*** JasonCL has quit IRC22:31
*** JasonCL has joined #zuul22:46
openstackgerritDavid Moreau Simard proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job""  https://review.openstack.org/52666622:49
*** JasonCL has quit IRC22:50
*** JasonCL has joined #zuul22:56
*** JasonCL has quit IRC23:00
*** JasonCL has joined #zuul23:08
*** JasonCL has quit IRC23:12
*** JasonCL has joined #zuul23:25
*** JasonCL has quit IRC23:30
*** JasonCL has joined #zuul23:54
*** JasonCL has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!