Friday, 2017-12-08

*** threestrands has joined #zuul00:01
openstackgerritMerged openstack-infra/zuul-jobs master: Add sphinx_python variable to sphinx role and job  https://review.openstack.org/52568800:11
*** ricky_vaca has quit IRC00:15
*** harlowja has quit IRC02:03
*** Wei_Liu has quit IRC03:14
*** Wei_Liu has joined #zuul03:27
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: handler: fix support for handler without launch_manager  https://review.openstack.org/52477304:24
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add a plugin interface for drivers  https://review.openstack.org/52462004:24
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: builder: do not cleanup image for driver not managing image  https://review.openstack.org/51692004:24
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a static driver for Nodepool  https://review.openstack.org/46862404:24
*** bhavik1 has joined #zuul04:48
*** bhavik1 has quit IRC04:56
*** tflink has quit IRC05:13
*** tflink has joined #zuul05:14
*** threestrands has quit IRC05:24
*** harlowja has joined #zuul05:37
*** threestrands has joined #zuul05:39
*** threestrands has quit IRC05:39
*** threestrands has joined #zuul05:39
*** harlowja has quit IRC06:14
*** xinliang has quit IRC06:22
*** threestrands has quit IRC06:28
*** Wei_Liu has quit IRC06:31
*** Wei_Liu has joined #zuul06:31
*** xinliang has joined #zuul06:35
*** xinliang has quit IRC06:35
*** xinliang has joined #zuul06:35
*** vivsoni__ has quit IRC06:51
*** persia has quit IRC07:07
*** odyssey4me has quit IRC07:08
*** persia has joined #zuul07:08
*** nguyentrihai has joined #zuul07:09
*** nguyentrihai has quit IRC07:11
*** odyssey4me has joined #zuul07:12
*** patriciadomin has quit IRC07:17
*** patriciadomin has joined #zuul07:17
tristanCShrews: i went a step further and merged the NodeLaunchManager into the RequestHandler, about to submit a new PS...07:34
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a generic run_handler  https://review.openstack.org/52632507:36
tristanCthere, i think the openstack and static handler looks much better in 52632507:37
*** hashar has joined #zuul07:58
*** baiyi has joined #zuul08:32
baiyiWhen I run zuul, job will stop for a few minutes08:37
baiyi2017-12-08 08:30:24.852581 | TASK [bindep : create temp dir for bindep]08:38
baiyi2017-12-08 08:32:25.371500 | ubuntu-xenial | changed08:38
baiyiDoes anyone have the same problem?09:06
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a generic run_handler  https://review.openstack.org/52632509:11
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an OpenContainer driver  https://review.openstack.org/46875309:11
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a Kubernetes driver  https://review.openstack.org/52135609:11
*** bbc1__ has joined #zuul09:11
tobiashbaiyi: the executor logs would be helpful09:20
*** flepied has joined #zuul09:51
*** baiyi1 has joined #zuul10:19
*** baiyi has quit IRC10:19
*** baiyi has joined #zuul10:22
*** baiyi has left #zuul10:22
*** baiyi has joined #zuul10:22
*** baiyi1 has quit IRC10:24
baiyiBetween 10:11 and 10:13 pause for two minutes, I don't know why, not every time     http://paste.openstack.org/show/628439/   http://paste.openstack.org/show/628441/10:24
baiyiThe pause task is different every time10:25
*** baiyi has quit IRC10:30
*** electrofelix has joined #zuul10:30
*** JasonCL has quit IRC11:07
openstackgerritJens Harbott (frickler) proposed openstack-infra/zuul-jobs master: Revert "Add sphinx_python variable to sphinx role and job"  https://review.openstack.org/52665711:10
*** openstackgerrit has quit IRC11:17
*** jkilpatr has quit IRC11:28
*** JasonCL has joined #zuul11:30
*** jkilpatr has joined #zuul12:23
*** openstackgerrit has joined #zuul12:31
openstackgerritMerged openstack-infra/zuul-jobs master: Revert "Add sphinx_python variable to sphinx role and job"  https://review.openstack.org/52665712:31
openstackgerritAndreas Jaeger proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job""  https://review.openstack.org/52666612:33
openstackgerritAndreas Jaeger proposed openstack-infra/zuul feature/zuulv3: Update sphinx jobs to use python3  https://review.openstack.org/52569012:34
*** flepied_ has joined #zuul12:41
*** flepied has quit IRC12:44
*** dkranz has joined #zuul12:47
*** bbc1__ has quit IRC13:02
*** nguyentrihai has joined #zuul13:26
*** Wei_Liu has quit IRC13:37
*** jkilpatr has quit IRC13:53
*** JasonCL has quit IRC15:06
*** JasonCL has joined #zuul15:19
*** Wei_Liu has joined #zuul15:23
*** JasonCL has quit IRC15:24
*** JasonCL has joined #zuul15:25
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: WIP: Git driver  https://review.openstack.org/52561415:47
*** JasonCL has quit IRC16:05
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks  https://review.openstack.org/52623316:12
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup  https://review.openstack.org/52623416:12
clarkbtobiash: ^ lets see if that helps, also thanks for the reviews. As for testing that I'm not really sure. Maybe we construct something that manually executes the cleanup worker then manually execute the request handler polling?16:14
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver  https://review.openstack.org/52561416:14
*** weshay|ruck is now known as weshay|ruck|MOD16:15
*** flepied__ has joined #zuul16:24
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks  https://review.openstack.org/52623316:25
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup  https://review.openstack.org/52623416:25
*** flepied_ has quit IRC16:27
*** hashar has quit IRC16:29
Shrewsclarkb: just added another comment on https://review.openstack.org/526234 (in case you missed it)16:32
clarkbShrews: thanks will work on a new patch16:35
*** JasonCL has joined #zuul16:40
clarkbShrews: you are saying treat the missing lock exception in poll() as not an error?16:43
Shrewsclarkb: as for testing that race, it's difficult, but I think it could be done. take a look at test_node_assignment_at_quota and how it uses client.pause_creates. before you unpause that, you could remove the request and the lock (may need to manually do that), then unpause16:43
Shrewsclarkb: treating your new exception as not an error, yes16:44
*** d0ugal has joined #zuul16:44
*** JasonCL has quit IRC16:48
*** d0ugal has quit IRC16:52
*** JasonCL has joined #zuul16:58
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup  https://review.openstack.org/52623417:03
clarkbShrews: something like ^ ?17:03
clarkbI'll work on that test after tea17:03
Shrewsclarkb: perfect, yes17:05
clarkbShrews: node requests are fulfilled when zuul is given the nodes right? not when zuul hands the nodes back?17:28
clarkb(sorting out how this test will look)17:28
*** JasonCL has quit IRC17:29
SpamapShrm.. confusing syntax error17:31
SpamapShttp://paste.openstack.org/show/628472/17:31
SpamapSrequired-projects can be a list of dicts according to https://docs.openstack.org/infra/zuul/user/config.html17:32
Shrewsclarkb: correct. the NodeRequest.nodes[] element is filled with node IDs, then the status is set to FULFILLED and the request is unlocked.17:32
Shrewsclarkb: then zuul handles it from there17:32
clarkbSpamapS: override branch looks funny to me too17:33
clarkbSpamapS: needs more indentation and possibly more :'s17:33
clarkbShrews: perfect, thanks17:33
*** jkilpatr has joined #zuul17:34
pabelangeryah, needs to lined with name above?17:34
clarkbSpamapS: re required projects I'm guessing the docs are just wrong?17:34
clarkbbut coulkd be a schema bug17:34
pabelangerbut maybe just formatting issue in debug log17:34
*** JasonCL has joined #zuul17:35
Shrewsclarkb: you know what... i think you've inadvertantly found another bug17:36
pabelangeroverride-branch: "1.3" ?17:36
pabelangermaybe it thinks 1.3 is float?17:36
Shrewsclarkb: oh, no you didn't. nothing to see here  :)17:37
* Shrews returns to his own test writing17:37
SpamapSclarkb: that format is just how the errors come out. In the source, override-branch is in the dict with name.17:39
SpamapSI'll look and see if the feature is tested.17:39
*** jkilpatr has quit IRC17:39
SpamapSOh that's true17:40
SpamapSyep, float17:40
SpamapSdoh17:40
openstackgerritFabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver  https://review.openstack.org/52561417:41
SpamapSpabelanger: well spotted.17:41
SpamapSI'd test it but my VPN just went down doh17:42
*** JasonCL has quit IRC17:43
pabelangeryay17:44
clarkbShrews: figuring out a test for this is slightly mind bending particularly with a cold17:50
clarkbShrews: I think how this happens now is the request basically went stale for 8 hours or more and eventually was fullfilled17:51
clarkbbecause cloud madness or something?17:51
*** jkilpatr has joined #zuul17:53
Shrewsclarkb: i'm unsure what conditions led up to the problem17:58
*** openstackgerrit has quit IRC18:03
*** JasonCL has joined #zuul18:03
*** jkilpatr has quit IRC18:06
*** JasonCL has quit IRC18:07
*** jkilpatr has joined #zuul18:22
*** electrofelix has quit IRC18:28
*** openstackgerrit has joined #zuul18:42
openstackgerritDavid Moreau Simard proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job""  https://review.openstack.org/52666618:42
*** JasonCL has joined #zuul18:45
*** JasonCL has quit IRC18:53
*** JasonCL has joined #zuul18:55
clarkbsoI think I have a test that mostly works except it completely breaks the main run loop which breaks shutdown of threds check in the tests :P19:10
openstackgerritDavid Moreau Simard proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job""  https://review.openstack.org/52666619:19
*** harlowja has joined #zuul19:21
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks  https://review.openstack.org/52623319:38
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup  https://review.openstack.org/52623419:38
clarkbShrews: ^ ok I think I finally got it19:38
clarkbturns out the trick is to set min ready to 0 if you don't want to fight the normal scheduler19:39
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul feature/zuulv3: Add finger gateway  https://review.openstack.org/52527620:05
Shrewsomg omg omg... un-WIP'd ^^^20:05
* Shrews celebrates with the drinking of scotch20:05
Shrewsbecause it's Friday and why not and stuff20:05
Shrewsclarkb: awesome. we should try to get those changes in ASAP20:08
Shrewsand restart launchers with them20:08
*** ChanServ has quit IRC20:17
*** ChanServ has joined #zuul20:24
*** barjavel.freenode.net sets mode: +o ChanServ20:24
*** JasonCL has quit IRC20:39
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Make all zuul-web urls relative  https://review.openstack.org/52677020:42
*** JasonCL has joined #zuul20:43
*** jkilpatr has quit IRC20:47
*** JasonCL has quit IRC20:48
pabelangerShrews: looking at finger gateway, does that mean the finger_port setting in zuul.conf [executor] could be updated to a different port now? maybe something like tcp 2003 (gnu finger) or 107979?20:51
pabelangerShrews: also left a comment about CommandSocket support20:52
Shrewspabelanger: it could be, yes. it's a separate change to remove the need to start executor as root20:52
pabelangerokay cool, thats what I figured20:53
Shrewspabelanger: could you point me to that commandsocket change?20:53
Shrewspabelanger: nm, found one20:55
*** JasonCL has joined #zuul20:57
pabelangerk20:58
Shrewspabelanger: oh, i see what that is now. is that something needed for the gateway?20:59
Shrewsnot sure what commands we'd send it20:59
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks  https://review.openstack.org/52623321:00
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup  https://review.openstack.org/52623421:00
Shrewspabelanger: oh, i guess 'stop' would be valid. not sure i understand the reasoning behind that, but yeah, I can add it.21:05
Shrewspabelanger: how is that used?21:05
pabelangerShrews: for example, zuul-executor stop21:06
pabelangerwould stop the process21:07
Shrewsah21:07
pabelangerjeblair added that a while back, I guess it is better?21:07
pabelangerI admit, I'm not really sure why that would be21:07
Shrewsoh, those just landed yesterday. no wonder i didn't see that change21:08
Shrewsbad timing21:08
tobiashreload config via command socket on the scheduler could also be useful in a containerized context (k8s) where it can be hard to get directly into the container to issue sighup21:09
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Serve keys from canonical project name  https://review.openstack.org/50480721:18
*** sc68cal has joined #zuul21:22
pabelangertobiash: ah, good point21:23
tobiashpabelanger: the port thingy?21:24
tobiashpabelanger: misunderstanding, had some other thing in my mind ;)21:25
pabelangertobiash: reload config21:31
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul feature/zuulv3: Add finger gateway  https://review.openstack.org/52527621:31
Shrewspabelanger: ^^^ does not yet address your commandsocket thing. only tobiash's random port comment. will get to the commandsocket probably monday based on current time21:44
tobiashShrews: :)21:48
Shrewspabelanger: shouldn't send_command() close the socket?21:54
*** JasonCL_ has joined #zuul21:57
*** JasonCL has quit IRC22:00
clarkbShrews: I'll have new patchset up momentarily addressing your review. Just rerunning tests locally22:03
openstackgerritClark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup  https://review.openstack.org/52623422:04
clarkbthere we go22:04
Shrewsclarkb: lgtm22:08
Shrewsok, i'm going to have to wait until Monday to look at this new CommandSocket stuff. something isn't computing for me. going to blame it on being late on a Friday.22:09
Shrewslike, i'm not sure why we can't just catch the commands in cmd/whatever.py and call the appropriate object method there, rather than having a thread in the object receive the command via a file socket.22:14
Shrewsanyway... maybe monday. night all22:14
ShrewsOh, duh. Not the same as the running object. *sigh*22:17
clarkbprobably the scotch22:24
clarkb:)22:24
*** hashar has joined #zuul22:49
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Pin to npm4 until npm 5.6.0 comes out  https://review.openstack.org/52679923:22
*** Wei_Liu has quit IRC23:27
*** hashar has quit IRC23:47
*** flepied__ has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!