| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: experiment with late-binding inheritance https://review.openstack.org/511352 | 00:01 |
|---|---|---|
| SpamapS | odd quirk of Github Depends-On's.. | 00:02 |
| SpamapS | they're based not on the commit message, but the description of the PR | 00:03 |
| SpamapS | so I can land things that have no Depends-On, but have Depends-On in the PR. | 00:03 |
| openstackgerrit | Clark Boylan proposed openstack-infra/zuul feature/zuulv3: Make the git web url a template https://review.openstack.org/515168 | 00:08 |
| clarkb | jeblair: ^ tehre is an attempt and I just realized I ran tox on it but not pep8 | 00:08 |
| jeblair | i just wrote the words "secret inheritance" | 00:11 |
| clarkb | is that like a secret garden? | 00:11 |
| openstackgerrit | Clark Boylan proposed openstack-infra/zuul feature/zuulv3: Make the git web url a template https://review.openstack.org/515168 | 00:11 |
| clarkb | sure enough I missed something pep8 didn't like | 00:11 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: experiment with late-binding inheritance https://review.openstack.org/511352 | 01:03 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 01:03 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: experiment with late-binding inheritance https://review.openstack.org/511352 | 01:12 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 01:12 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Switch to late-binding inheritance https://review.openstack.org/511352 | 01:48 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 01:48 |
| dmsimard | So ansible 2.4.1 is finally out | 01:49 |
| dmsimard | I've tagged ara 0.14.5rc1, will sanity check it tomorrow and release it -- 2.4.0 is blacklisted | 01:49 |
| dmsimard | mordred, Shrews ^ | 01:50 |
| SpamapS | dmsimard: neat | 03:17 |
| SpamapS | jeblair: I trust my name appears in the document in which you wrote "secret inheritance" followed by a large dollar amount or percentage. | 03:18 |
| *** smyers has quit IRC | 04:23 | |
| *** smyers has joined #zuul | 04:38 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Switch to late-binding inheritance https://review.openstack.org/511352 | 04:49 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 04:49 |
| SpamapS | You know, there's this weird effect having a nice set of nodepool and zuul to iterate patches on... | 05:05 |
| SpamapS | When a job takes 10 minutes to run | 05:05 |
| SpamapS | it's long enough to context switch | 05:05 |
| SpamapS | you git push / git review and then switch tasks for a long time ( longer than 10 minutes ) | 05:06 |
| SpamapS | but when a job is 4 minutes.. | 05:06 |
| SpamapS | it's like waiting for the tea kettle. | 05:06 |
| tobiash | yay, configuring branch matching for the noop job in a project pipeline works out of the box :) | 05:40 |
| *** ruijie has joined #zuul | 05:51 | |
| *** ruijie has left #zuul | 05:51 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Remove pep8/pyflakes https://review.openstack.org/515041 | 05:55 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: DNM: Test binary data in zuul stream https://review.openstack.org/515283 | 06:03 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Do late decoding of log stream buffer https://review.openstack.org/515043 | 06:46 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: DNM: Test binary data in zuul stream https://review.openstack.org/515283 | 06:47 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Do late decoding of log stream buffer https://review.openstack.org/515043 | 07:00 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: DNM: Test binary data in zuul stream https://review.openstack.org/515283 | 07:23 |
| openstackgerrit | Andrea Frittoli proposed openstack-infra/zuul-jobs master: Add a generic stage-output role https://review.openstack.org/509233 | 07:25 |
| *** yolanda has joined #zuul | 07:27 | |
| tobiash | jamielennox: thanks, I think I found it | 07:31 |
| tobiash | jamielennox: this one rihgt? https://review.openstack.org/#/c/471175/ | 07:31 |
| tobiash | will try that out when I | 07:32 |
| tobiash | when I'll dig deeper into github workflows (probably in a few weeks) | 07:32 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Do late decoding of log stream buffer https://review.openstack.org/515043 | 07:35 |
| tobiash | SpamapS, kklimonda: now with backslashreplace and tests ^ | 07:35 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Default change and patchset to NULL in SQLReporter https://review.openstack.org/514423 | 07:58 |
| kklimonda | tobiash: nice - I'll see if I can give it a try today | 08:01 |
| *** hashar has joined #zuul | 08:41 | |
| *** hashar is now known as hasharAway | 08:49 | |
| *** bhavik1 has joined #zuul | 09:00 | |
| *** smyers has quit IRC | 09:02 | |
| *** electrofelix has joined #zuul | 09:03 | |
| *** bhavik1 has quit IRC | 09:05 | |
| *** smyers has joined #zuul | 09:14 | |
| *** sambetts|afk is now known as sambetts | 10:09 | |
| *** bhavik1 has joined #zuul | 10:17 | |
| *** bhavik1 has quit IRC | 11:02 | |
| *** _ari_ has quit IRC | 11:38 | |
| *** _ari_ has joined #zuul | 11:43 | |
| jkt | hi there, I'm on Zuul v2, and I'm wondering how can I persuade the zuul merger to also serve git submodules | 12:32 |
| jkt | do I have to somehow include them in Zuul's project dependencies? | 12:33 |
| *** yolanda has quit IRC | 13:04 | |
| jkt | hmmmmmm, my submodules are just mirrors of random git repositories from github. I do not have any jobs defined for them; they are really just mirrors | 13:08 |
| jkt | reading zuul's source, it seems that it must process some event about a particular project in order to start "merging" it, and that makes sense | 13:09 |
| jkt | right, so apparently it's enough to set up a noop job in a pipeline for ref-updated, and ensure that a matching event gets through (such as pushing and removing a throw-away branch) | 13:42 |
| tobiash | jkt: this will only work if you have exactly one merger | 13:47 |
| tobiash | if you have several mergers this will work or not by luck | 13:47 |
| jkt | tobiash: because it's random which merger I hit when cloning, right? | 13:53 |
| tobiash | jkt: yes | 13:53 |
| jkt | I suppose this is changed in v3, isn't it? | 13:54 |
| tobiash | so they will have different (if any) copies | 13:54 |
| tobiash | submodules are currently not really supported | 13:54 |
| tobiash | in v3 you can add the submodule as required project | 13:54 |
| tobiash | then you can rely on that it's at least there and then you job can put it in the correct place | 13:55 |
| tobiash | s/you job/your job/ | 13:55 |
| jkt | tobiash: thanks; also, I have just one merger | 13:56 |
| tobiash | jkt: you probably will want to clone it from the merger and update (clone if the merger doesn't have it cached) it from upstream | 13:58 |
| openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Remove unreachable code https://review.openstack.org/506137 | 14:12 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 14:35 |
| clarkb | tobiash: jeblair https://review.openstack.org/#/c/515168/ has been updated and passes tests to use a template string instead of a different config option for all the git hosts | 15:34 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add implied branch matchers on 'master' https://review.openstack.org/514459 | 15:53 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Switch to late-binding inheritance https://review.openstack.org/511352 | 15:54 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 15:54 |
| jeblair | clarkb: lgtm +3 | 15:57 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Make the git web url a template https://review.openstack.org/515168 | 16:09 |
| jeblair | in my email, i used 'meta' as the config object to use when disabling implicit branch matchers... but i'm thinking 'pragma' might be a better choice? | 16:19 |
| jeblair | it is actually an instruction to the parser on how to treat the content of that file | 16:20 |
| SpamapS | jkt: submodules would be discouraged IMO | 16:21 |
| SpamapS | in all cases | 16:21 |
| SpamapS | jkt: ultimately, submodules are a separate system from git, built in to git. | 16:22 |
| SpamapS | They're no better than a bash script that checks out a bunch of stuff, IMO. | 16:23 |
| SpamapS | jkt: what I've done with them is just ignore the submodule, and symlink in the zuul managed repo where the submodule would normally be. | 16:24 |
| SpamapS | But that's just temporary while I get things working.. they'll be factored out eventually | 16:26 |
| *** bhavik1 has joined #zuul | 16:33 | |
| clarkb | jeblair: my only concern with pragma is that they are external to the language in eg C. Implying that different zuul config parsers could implement pragmas differently | 16:34 |
| clarkb | jeblair: but I think something like implicit branch matchers should have consistent behavior (even when overridden?) | 16:35 |
| clarkb | that may also be overthinking it | 16:35 |
| jeblair | clarkb: in some ways, i feel like this is external to the language a bit. it instructs the parser to behave differently when it parses the main config | 16:36 |
| mrhillsman | are public ip addresses for VMs required if I am running Zuul locally | 16:36 |
| jeblair | clarkb: eg https://etherpad.openstack.org/p/pUH31hBvui | 16:37 |
| jeblair | clarkb: it's going to change how those jobs are parsed, because it's in the same file. but it won't affect how jobs are parsed in other files. so it doesn't really form a part of the configuration. | 16:37 |
| jeblair | mrhillsman: for the nodepool vms? | 16:37 |
| mrhillsman | yeah | 16:38 |
| mrhillsman | infra page says VMs need public addresses | 16:38 |
| mrhillsman | s/page/peeps | 16:38 |
| jeblair | mrhillsman: the vms need to be accessible from the zuul executor(s) and the nodepool launcher(s) | 16:38 |
| mrhillsman | ok thx | 16:38 |
| jeblair | mrhillsman: aside from that, they don't need to be public, per-se | 16:38 |
| clarkb | since infra runs on multiple contients in multiple clouds with no relation to each other we need them to be properly public | 16:39 |
| clarkb | we could work around that but it would require a bit of work | 16:39 |
| jeblair | but an internal zuul doesn't need that | 16:39 |
| clarkb | right | 16:39 |
| mrhillsman | got it, figured that was the casr | 16:39 |
| mrhillsman | thx gentlemen | 16:41 |
| tobiash | SpamapS: I answered on your comment at 515043 | 16:43 |
| tobiash | SpamapS: I can move the piggybacked fix to a followup real quick, but testing this could get tricky probably | 16:44 |
| *** bhavik1 has quit IRC | 16:49 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: DNM: test ansible crash logging https://review.openstack.org/515470 | 16:56 |
| *** sambetts is now known as sambetts|afk | 16:58 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: DNM: test ansible crash logging https://review.openstack.org/515470 | 16:59 |
| SpamapS | tobiash: I think you could leave it as-is | 17:05 |
| SpamapS | tobiash: that's why I still +2'd | 17:05 |
| SpamapS | tobiash: testing it would likely involve monkeypatching stuff. | 17:05 |
| tobiash | SpamapS: lets see if ^^ can trigger it | 17:06 |
| tobiash | SpamapS: if yes, then that's low hanging fruit and I'll separte this | 17:06 |
| SpamapS | oh yeah fascinating :) | 17:07 |
| tobiash | the idea is that the shell task kills its python process provoking a not sending of the end tag | 17:07 |
| tobiash | not sure if this works, but we'll see | 17:07 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 17:49 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add pragma directive https://review.openstack.org/515483 | 17:49 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: DNM: test ansible crash logging https://review.openstack.org/515470 | 17:49 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: WIP: remove implied run https://review.openstack.org/515487 | 17:58 |
| SpamapS | hrm.. I have 'comment: false' on my success actions and the github driver is still commenting. | 18:03 |
| tobiash | that sounds like a bug | 18:05 |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Copy Gerrit delay to GitHub driver https://review.openstack.org/515224 | 18:05 |
| SpamapS | tobiash: yeah, digging for it now | 18:06 |
| SpamapS | the code is pretty straight forward, not sure why it is still commenting. | 18:14 |
| *** electrofelix has quit IRC | 18:14 | |
| *** jkilpatr has joined #zuul | 18:16 | |
| tobiash | SpamapS: in the merge path it doesn't consider comment | 18:17 |
| tobiash | ah, on merge failure | 18:17 |
| tobiash | that sounds ok | 18:18 |
| SpamapS | if I'm reading it right, the config for a reporter is passed in when the result happens. | 18:19 |
| SpamapS | everything else from that config is happening | 18:19 |
| jlk | SpamapS: how do you have it configured in the YAML? Can you post it somewhere? | 18:28 |
| SpamapS | jlk: yeah let me paste | 18:28 |
| SpamapS | jlk: http://paste.openstack.org/show/624742/ | 18:29 |
| jlk | interesting. Yeah, You'll probably have to debug capture it in githubreporter.py | 18:30 |
| jlk | Unless this is a stupid thing where the YAML value of false is not being interpreted as a boolean | 18:32 |
| jlk | it SHOULD, the schema is a bool | 18:32 |
| jlk | SpamapS: does it do it on pending as well? | 18:38 |
| jlk | rather on 'start' ? | 18:38 |
| SpamapS | jlk: no, I only get comments on success and failure | 18:43 |
| SpamapS | and the status URL is correctly set on both | 18:43 |
| jlk | that's really bizarre. Do you have any other versions of the config in a different branch? When you start up scheduler, it spits out a overall config, what does that show? | 18:44 |
| SpamapS | http://paste.openstack.org/show/624743/ | 18:45 |
| SpamapS | flamel converts yaml to json | 18:45 |
| SpamapS | ^^ shows it interprets as false | 18:45 |
| SpamapS | this is interesting | 18:46 |
| SpamapS | 2017-10-26 11:41:54,990 DEBUG zuul.GithubReporter: Reporting change <Change 0x7f64fc007898 144,513e2621a074c805249535430ca816f8d0fab4ab>, params {'status': 'pending', 'comment': False, 'status-url': 'https://zuul.cloud.int.godaddy.com/status/'}, context: GoDaddy/check, state: pending, description: check status: pending, url: https://zuul.cloud.int.godaddy.com/status/ | 18:46 |
| SpamapS | pending shows 'comment': False | 18:46 |
| SpamapS | 2017-10-26 11:02:58,577 DEBUG zuul.GithubReporter: Reporting change <Change 0x7f64fc0cce80 5,f8a6d40db753e30f0e270ce79dedba17fc906640>, params {'status': 'success', 'status-url': 'https://zuul.cloud.int.godaddy | 18:47 |
| SpamapS | .com:8080/logs/{tenant.name}/{pipeline.name}/{change.project.canonical_name}/{change.number}/{buildset.uuid}/'}, message: Build succeeded. | 18:47 |
| SpamapS | but 'success' does not show a comment field at all | 18:47 |
| jlk | HUH | 18:47 |
| SpamapS | nor does failure | 18:47 |
| jlk | it's not in self.config | 18:48 |
| SpamapS | it gets defaulted later to True | 18:49 |
| jlk | oh hrm, these loggings are from the individual reporting types | 18:49 |
| jlk | merge, comment, status, etc. | 18:49 |
| SpamapS | unfortunately, I have to run .. be back in ~90 | 18:49 |
| jlk | k | 18:49 |
| jlk | I'm at a loss as to why this would happen, from looking at the code | 18:52 |
| *** harlowja has quit IRC | 19:46 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Copy Gerrit delay to GitHub driver https://review.openstack.org/515224 | 19:56 |
| *** hasharAway has quit IRC | 19:56 | |
| * jlk lunches | 19:57 | |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul-jobs master: WIP: Silence ansible-lint https://review.openstack.org/515520 | 20:28 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul-jobs master: WIP: Silence ansible-lint https://review.openstack.org/515520 | 20:29 |
| *** jamielennox has quit IRC | 20:30 | |
| *** harlowja has joined #zuul | 20:33 | |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul-jobs master: WIP: Silence ansible-lint https://review.openstack.org/515520 | 20:33 |
| *** jamielennox has joined #zuul | 20:34 | |
| jeblair | hi, if folks wanted to start looking at the inheritance changes, i think they're ready for review. i'm finishing up the implied-run "bonus" change now. but the others (514459, 511352, 515249, 515483) are ready. | 20:35 |
| Shrews | jeblair: awesome. plan to dig in on those tomorrow | 20:37 |
| jeblair | Shrews: cool. my hope is to restart with those in place tomorrow, (projects are starting to bump into the issues they fix). but your tomorrow starts earlier than mine so that should be fine. :) | 20:39 |
| *** jamielennox has quit IRC | 20:54 | |
| *** jamielennox has joined #zuul | 20:55 | |
| *** smyers has quit IRC | 22:04 | |
| *** smyers has joined #zuul | 22:05 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Move test_job_auth_inheritance to test_v3 https://review.openstack.org/515249 | 22:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add pragma directive https://review.openstack.org/515483 | 22:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove implied run https://review.openstack.org/515487 | 22:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Support file extension in playbook path https://review.openstack.org/515535 | 22:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Update test fixtures to use explicit run https://review.openstack.org/515536 | 22:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Validate that a job has a run playbook on freeze https://review.openstack.org/515537 | 22:31 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Update test fixtures to use explicit run https://review.openstack.org/515536 | 23:05 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove implied run https://review.openstack.org/515487 | 23:05 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Validate that a job has a run playbook on freeze https://review.openstack.org/515537 | 23:05 |
| jeblair | that stack is complete and green | 23:32 |
| clarkb | friday morning reading? | 23:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!