Tuesday, 2017-08-08

*** jkilpatr has quit IRC00:13
jeblairpabelanger: can you take a look at http://docs-draft.openstack.org/35/491635/1/check/gate-zuul-sphinx-docs-ubuntu-xenial/bedaf26//doc/build/html/examples.html#roles and tell me what you think?00:20
jeblairpabelanger: it's still not possible to make a section heading inside of a role documentation section, but that shows what it would look like if we started using the zuul:var directive for role/job variables00:21
jeblairpabelanger: i made "Role Variables" bold as a sort of pseudo-section-header.00:22
pabelangerjeblair: okay, cool. tomorrow okay?00:23
pabelangermight also try it out00:23
*** harlowja has quit IRC00:25
jeblairpabelanger: oh of course!  :)00:41
*** fbouliane has quit IRC02:17
*** rbergeron has quit IRC02:18
*** rbergeron has joined #zuul02:19
*** fbouliane has joined #zuul02:23
openstackgerritMerged openstack-infra/zuul-jobs master: Update the zuul-sphinx extension config  https://review.openstack.org/49113403:44
*** harlowja has joined #zuul04:35
*** harlowja has quit IRC05:14
tobiash\o/ rebased my deployment and it uncovered a spelling error in my project config05:44
*** bhavik1 has joined #zuul06:05
openstackgerritTobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Fix detail headers order for nodepool list  https://review.openstack.org/49167806:25
tobiashShrews: important bugfix for 'nodepool list --detail'...  ;)    ^^^06:26
*** bhavik1 has quit IRC06:53
*** amoralej|off is now known as amoralej07:36
*** electrofelix has joined #zuul08:46
*** jkilpatr has joined #zuul10:58
*** amoralej is now known as amoralej|lunch11:22
*** amoralej|lunch is now known as amoralej12:49
*** dkranz_ has joined #zuul13:21
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180513:30
mordredjeblair, pabelanger (and other folks) ^^ very beginnings of a migration tool13:31
mordredI have learned some things about some topics that are going to be difficult that we should discuss13:31
mordredspecifically - project-templates make this hard - there is at least one template that is check: gate-{name}-ubuntu-xenial gate: gate-{name}-ubuntu-xenial13:33
mordredif we expand templates as part of migration, that's not a problem - we can generate a gate-toci-glance-ubuntu-xenial job and add it to the right pipelines of the project and do re-consolidation as a followup13:34
mordredhowever, if we keep the project-templates, we don't have a great way to deal with situations like that. I mean - we can just add entries for them to the mapping file - but that's going to reuqire MUCH more careful examination by us of the output13:39
mordredhrm. I should say all of that in the infra channel actually13:39
*** xinliang has quit IRC14:01
*** xinliang has joined #zuul14:13
jeblairmordred: i'm having trouble understanding why that template is problematic -- maybe i don't have enough background on the approach you're taking14:28
mordredjeblair: I have sent an email with more words14:57
mordredjeblair: (sorry - I had written the email about an hour ago but didn't manage to hit send)14:57
mordredjeblair: fwiw, I'm leaning towards option 3 in the email the more I poke at it14:58
*** dmsimard is now known as dmsimard|afk15:00
*** dmsimard|afk is now known as dmsimard16:43
pabelangermordred: mind a review of https://review.openstack.org/490643, simple playbook to role convert.16:46
pabelangermordred: jeblair: https://review.openstack.org/490576 is also ready to be painted. Our 2 -tarball / -branch-tarball publishing jobs16:47
pabelangermind loop when into the migration tool above16:47
*** electrofelix has quit IRC17:24
*** amoralej is now known as amoralej|off18:00
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add comments about base jobs  https://review.openstack.org/49189719:45
jeblairmordred: have a sec to +3 491610 ?  when it lands, i'll start work on rejiggering our base jobs for it19:46
mordredjeblair: done19:47
jeblairmordred: er 491610 is the one that needs the +W :)19:58
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180520:03
mordredjeblair: whoops :)20:04
mordredwell - +3 on the other one too20:04
mordredjeblair, pabelanger: so - for ad-hoc / one-off / simple jobs - 'src/{{ zuul.executor.canonical_name }}' is a bit of a mouthfull20:14
mordredalso - I can't even get it right when I type it here, since that's not the variable name20:15
mordredhttps://review.openstack.org/#/c/491805/2/playbooks/zuul-migrate.yaml for example20:15
pabelangermordred: ya, it results in a lot of copypasta of zuul_work_dir to playbooks and role vars20:16
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Remove base job  https://review.openstack.org/49190720:16
*** jkilpatr has quit IRC20:16
mordredwhat if we added a zuul.project.src_dir ? it's not a ton less characters, but it's maybe a little clearer as to what it contains?20:17
pabelangerwe could also add it to our base job20:19
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Require a base job  https://review.openstack.org/49161020:20
jeblairmordred, pabelanger: both of those sound viable20:22
jeblairi guess the question is, if you put it on the base job, what do the vars sections of the other playbooks/jobs look like?  what do they have for a default for zuul_work_dir20:23
pabelangerAgree, no preference. zuul.project.src_dir might be nicer, if we consider adding it to zuul.items20:23
mordredlemme make a quick patch and see what y'all think20:24
jeblairpabelanger: yes, all the "project-like" objects in the variables should stay in sync20:24
jeblairmordred:  ^^20:24
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add zuul.project.src_dir variable  https://review.openstack.org/49191520:33
mordredjeblair, pabelanger: ^^20:33
pabelangermordred: left -1 about adding ansible assert, but looks good20:36
*** jkilpatr has joined #zuul20:37
jeblairpabelanger: why does that variable need an assertion?20:39
jeblairpabelanger: do we want to add all of them?20:39
jeblairpabelanger: also you didn't actually leave a -120:39
pabelangerjeblair: most of them should be asserted, but I don't think we have all yet. But figured it should be helpful to test that we are actually setting up the variables for ansible properly20:40
pabelangerYa, didn't actually -1, should have said +0 :)20:41
jeblairpabelanger: you sent a mixed signal, for sure.  :)20:41
pabelangerjeblair: Ya, didn't want to block it, so if we don't want to, thats okay. Will add +2 then20:42
mordredI'm happy to add an assert though ...20:42
jeblairmordred: i -1'd for a whitespace nit of all things.  sorry.20:43
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add zuul.project.src_dir variable  https://review.openstack.org/49191520:43
mordredah20:43
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add zuul.project.src_dir variable  https://review.openstack.org/49191520:44
mordredjeblair: fixed. thanks20:44
jeblairlgtm20:44
pabelanger+320:45
pabelangerthanks!20:45
jeblairpabelanger, mordred: can you +3 491906?  i expect that to break currently running v3 but be required for the next restart20:45
jeblairso i'd like to land it now and do a restart20:45
pabelangerlooking20:46
mordredjeblair: wfm20:47
pabelanger+320:48
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add zuul.project.src_dir variable  https://review.openstack.org/49191520:49
mordredGAH STAB STAB20:49
mordredsorry20:49
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add zuul.project.src_dir variable  https://review.openstack.org/49191520:50
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180520:50
* mordred had a local rebase problem20:50
jeblairmordred: neat; the gerrit votes are all intact on 91520:51
pabelanger490643 could use a +3, should be straighforward20:52
mordredpabelanger: ++20:57
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180520:58
openstackgerritMerged openstack-infra/zuul-jobs master: Create fetch-tox-output role  https://review.openstack.org/49064320:59
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180521:01
mordredsweet. that one should work and you should be able to see the output21:04
mordredjeblair, pabelanger: that has project-templates project pipelines, depedencies and  adding variants for node suffixes - next up is actually mapping those up with the jjb jobs themselves, then dealing with the regex/variant mapping, then emitting job content21:07
mordredat which point it should be far enough along that we can tweak it as we find corner cases while working on jobs21:07
jeblairmordred: cool.  we'll probably have to wait until the restart to see that run21:08
jeblairapparently puppetmaster ansible is a couple hours behind21:09
mordredjeblair: question ... I defined zuul-migrate job in openstack-infra/zuul with required-projects: project-config ...21:09
mordredjeblair: if I add it to the check pipeline for project-config patches in the project-config repo (so that we see it run when changes are made to the mapping.yaml)21:09
mordredjeblair: I assume it'll do the right thing and get both openstack-infra/zuul and openstack-infra/project-config yeah?21:10
pabelangermordred: nice21:10
jeblairmordred: it will need zuul listed as a required project21:10
jeblairmordred: (consider: it's not testing zuul, it's using zuul in the job)21:11
jeblair(when used that way)21:11
mordredjeblair: ok. so adding zuul to the required projects in the zuul repo is kosher21:12
jeblairyep21:12
jeblairi think that's the only thing to change you'll need for that to work21:12
jeblairwords order wrong, but idea get you21:12
mordredyah21:12
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180521:13
jeblairokay, zuul has been upgraded, i'm going to restart it now21:13
mordredcool21:14
mordredI found one more thing I need to change21:15
jeblairokay, restarted and loading the ansible config :)21:16
pabelangerthanks!21:16
*** dkranz_ has quit IRC21:16
jeblairsomething doesn't seem right with status.json21:19
pabelangeragree21:19
jeblairah21:20
jeblair2017-08-08 21:16:14,427 ERROR zuul.Scheduler: Error starting Zuul:21:20
jeblairzuul.configloader.ConfigurationSyntaxError: Zuul encountered a syntax error while parsing its configuration in the21:21
jeblairrepo openstack-infra/project-config on branch master.  The error was:21:21
jeblairexpected a list for dictionary value @ data['success']['mysql']21:21
jeblairwe need to update the mysql reporter syntax too21:21
mordredjeblair: I though there was a patch for thatup already21:24
jeblairmordred: i don't see a conflicts-with for it :/21:25
mordredjeblair: maybe I was just remember the docs update patch - your patch is +321:25
mordredjeblair, pabelanger: fwiw - I just did a quick double-check and we do have data in our mysql :)21:27
mordredzuul_buildset: 272 rows in set (0.00 sec) zuul_build: 1030 rows in set (0.01 sec)21:28
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add comments about base jobs  https://review.openstack.org/49189721:29
jeblairmordred: \o/21:30
jeblairrestarting again21:50
jeblairand up21:50
jeblairseems to be working21:51
jeblairi rechecked mordred's change and it's running now21:51
mordred\o/21:52
jeblairhttp://zuulv3.openstack.org/static/stream.html?uuid=be4258d38f9d4d1fb4c7b4f725c4ea0e&logfile=console.log21:52
mordredjeblair: there's a bug I have fixed locally - want me to wait til that fails until I push it up?21:52
jeblairmordred: nah go for it21:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add migration tool for v2 to v3 conversion  https://review.openstack.org/49180521:53
mordredhttp://zuulv3.openstack.org/static/stream.html?uuid=37f99614f19b452295adf122caf97e6a&logfile=console.log21:54
mordredjeblair: watching repos copy is not exciting21:58
jeblairmordred: seems to be taking too long22:02
jeblairmordred: like, i'm not sure we're seeing anything past that point22:03
jeblaircould there be a behavior change?22:03
jeblairi ran finger too to verify they're stuck at the same spot, so it's not a web thing22:04
mordredjeblair: I agree with you - and also am not sure what's up22:05
jeblairi checked a work dir, job-output.txt is also stuck there, so not a finger thing22:05
mordredyup. I concur22:05
jeblairit looks like the base pre playbook is still running22:06
mordredjeblair: zuul      1061     1  0 21:54 ?        00:00:00 /usr/bin/python2 /tmp/ansible_9kPUu6/ansible_module_zuul_console.py is the only thing running on the node22:06
mordredjeblair: did we maybe only get half of the streaming fix from tobiash deployed?22:07
mordredso there's maybe a handshake going wrong?22:07
jeblairi'm stracing an rsync process which seems to be doing things but slowly22:07
mordredoh. ok22:08
mordredjeblair: oh - you know what22:09
mordredjeblair: our base job doing the repo rsync is ... suboptimal22:09
mordredjeblair: I don't think it's making use of the repos in /opt/git22:09
jeblairmordred: it's not supposed to; we're trying to drop those in v322:10
mordredoh - ok. nevermind then :)22:10
jeblair(so we can have smaller images)22:11
mordredyah22:11
jeblairbut it is looking like right now the rsync is very very slow22:11
jeblairi don't think it was in the past22:11
mordredmaybe infracloud is laggy atm?22:12
jeblairmaybe... clarkb and fungi were onlining some hosts there earlier; maybe we should check what compute hosts our nodes landed on22:16
jeblairalso, we are now running the disk space watcher thing, but it seems to be be fairly low impact.22:17
fungivanilla or chocolate?22:18
jeblairlooking now22:18
fungiclarkb: did chocolate a few hours ago, i'm poking at vanilla right now22:18
jeblairoh neat, nodepool list doesn't show the ip any more22:18
jeblairwe need to add that back :)22:19
fungii managed to bring one defunct compute node back online in vanilla by rebooting it through ironic22:19
jeblairi need to map 15.184.70.243 to a node22:19
funginow i'm waiting a bit to see what vm uuids stick around past reasonable job durations22:19
jeblair2017-08-08 21:54:27,577 DEBUG nodepool.NodeLauncher-0000017006: Node 0000017006 is running [region: RegionOne, az: nova, ip: 15.184.70.243 ipv4: 15.184.70.243, ipv6: ]22:19
jeblair| 0000017006 | infracloud-chocolate | nova | ubuntu-xenial | 2a5f60f1-3f05-4430-9157-2cc038cd7c48 | in-use | 00:00:24:02 | locked   |22:20
jeblairthere we go, chocolate22:20
fungiand well after clarkb had finished doing things in there22:20
clarkbhttp://paste.openstack.org/show/617816/ is the list of what I cleaned up22:20
clarkb2af is not in that list22:20
jeblairlet me see if i can find a vanilla node that's slow22:20
clarkbalso I cross checked against nova list so should only have gotten nodes nova didn't know about22:21
jeblair| 0000017001 | infracloud-vanilla   | nova | ubuntu-xenial | 27f44b59-1448-4a38-bc8a-c95a1667e938 | in-use | 00:00:24:32 | locked   |22:22
jeblairthat's similarly slow22:22
jeblairso it's both regions22:22
clarkboh things are slow22:22
jeblair(to be clear, no idea if this is an infracloud or zuul problem)22:22
clarkbwe are running at capacity right now and have been all day22:23
clarkbwe could just be oversubscribed?22:23
clarkbI would definitely check the hypervisor(s) you are running on and get some performance data there22:23
jeblairclarkb: could be, and of course we have no visibility on our network, so we could be maxing that out22:23
jeblairclarkb: rysincing the git repos from ze01 to the nodes was unusually slow.  so either slow disk or network bottleneck on ze01 (unlikely based on cacti graphs) or infracloud.22:24
clarkbI think we know the disk is slow there which is why we have turned on the "we don't care about our data" flag in kvm22:25
clarkbbut ya could be network too22:25
mordredjeblair, clarkb: 2017-08-08 21:54:59.848771 | TASK [prepare-workspace : Synchronize src repos to workspace directory.]22:25
mordred2017-08-08 22:18:32.777985 | ubuntu-xenial | Output suppressed because no_log was given22:25
jeblairit took 24minutes to sync them22:25
mordredyah22:25
mordredand that's just doing zuul and project-config22:25
clarkbyou can test disk io fairly easily thlough so maybe start with that22:26
clarkbnetwork is harder without insight to the networking but should be able to draw reasonable conclusions comparing hypervisor to hypervisor against internet to hypervisor (maybe to a ramdisk to avoid slow disk as well)22:26
jeblaira total of about 2.5G of data22:26
jeblairmordred, pabelanger: what do you make of http://logs.openstack.org/05/491805/7/check/tox-py35/07fad41/job-output.txt.gz#_2017-08-08_22_31_10_966898  ?22:39
jeblairmordred: that looks like maybe an error in our local plugin?22:39
mordredjeblair: yes. that looks like that - and it looks like an error in the recent fix we landed - I'm looking at that right now22:40
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Don't pass self to a bound method  https://review.openstack.org/49194622:43
mordredjeblair: I'm concerned that that got through testing22:43
mordredjeblair: but I'll put that on the list to sort out as a follow up22:43
Shrewsjeblair: nodepool list --detail23:23
Shrews(to get IP and other info)23:24
jeblairShrews: thx23:25
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Don't pass self to a bound method  https://review.openstack.org/49194623:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!