Saturday, 2017-06-10

pabelangerjeblair: Hmm, which other job do you see it on.  So far I am only seeing it with tox/pre.yaml but the execption appears to move around.  I noticed it on a tox/docs.yaml too00:01
pabelangerbut, agree. maybe they are not related00:02
jeblairpabelanger: oh, do they always show up together?00:02
pabelangerI thought they did, but looking at 4899d90de7c842b0a00134a46b835da9 is is a different location00:03
pabelangerwarning seems to always be with tox/pre.yaml00:03
pabelangerI'll have to play with it more00:05
jeblairpabelanger, mordred: i think the log error is because of this:00:07
jeblair2017-06-10 00:04:02.752414 | Selecting previously unselected package mysql-server-5.7.00:07
jeblair(Reading database ... 26703 files and directories currently installed.)00:07
jeblair2017-06-10 00:04:02.768363 | Preparing to unpack .../mysql-server-5.7_5.7.18-0ubuntu0.16.04.1_amd64.deb ...00:07
jeblairi'm not sure how we ended up with that line...00:07
jeblairpossibly some \r trickery?00:08
jeblairyes00:09
jeblair2017-06-10 00:03:59.265564 | (Reading database ... ^M .... is the actual line00:10
pabelangerah, neat00:10
jeblairi don't see what about that could cause that error though00:14
jeblairthis is probably about the time we need to re-enable the 'zuul-executor verbose' command.00:15
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Enable verbose/unverbose zuul-executor commands  https://review.openstack.org/47286800:20
clarkbjeblair: mordred I dropped a simple native python version of the pid discovery in the change. I have it working locally but I think it needs much more error handling00:34
clarkbanyways I too need to weekend so won't get that cleaned up until later00:34
*** jamielennox is now known as jamielennox|away00:39
openstackgerritTristan Cacqueray proposed openstack-infra/zuul feature/zuulv3: executor: add support for custom ansible_port  https://review.openstack.org/46871001:19
*** jamielennox|away is now known as jamielennox01:44
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add support for custom ssh port  https://review.openstack.org/46875201:56
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Add webapp port and listen_address configuration  https://review.openstack.org/47212802:20
*** jamielennox is now known as jamielennox|away02:36
*** jamielennox|away is now known as jamielennox02:40
*** bhavik1 has joined #zuul05:05
*** bhavik1 has quit IRC05:09
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a static driver for Nodepool  https://review.openstack.org/46862406:50
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Extend Nodepool configuration syntax to support multiple drivers  https://review.openstack.org/46875106:50
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Collect request handling implementation in an OpenStack driver  https://review.openstack.org/46875006:50
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Abstract Nodepool provider management code  https://review.openstack.org/46874906:50
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Abstract Nodepool request handling code  https://review.openstack.org/46874806:50
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an OpenContainer driver  https://review.openstack.org/46875306:50
*** yolanda has quit IRC07:49
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an OpenContainer driver  https://review.openstack.org/46875308:07
*** tobiash has quit IRC08:34
*** tobiash has joined #zuul09:35
*** bhavik1 has joined #zuul09:57
openstackgerritRicardo Carrillo Cruz proposed openstack-infra/nodepool feature/zuulv3: Expose key-name parameter on cloud-images  https://review.openstack.org/47289511:13
openstackgerritRicardo Carrillo Cruz proposed openstack-infra/nodepool feature/zuulv3: Expose key-name parameter on cloud-images  https://review.openstack.org/47289511:19
rcarrillocruzhey folks, ^ to inject keypairs on cloud images11:19
rcarrillocruzi tested on my rdo cloud11:19
rcarrillocruzpabelanger, mordred ^11:19
rcarrillocruzalhtough11:31
rcarrillocruzwait, i think i got confused with the current nodepool docs11:31
rcarrillocruzthe current doc point key-name to be an image-name11:31
rcarrillocruzimage param sorry11:31
rcarrillocruzbut code shows key-name is now a provider param11:32
rcarrillocruzso putting it on provider should just work11:32
* rcarrillocruz goes check11:32
*** bhavik1 has quit IRC11:32
mordredrcarrillocruz: yah. I believe pool-label is what you want12:26
mordredthe image section just describes the image to create - the label describes how to boot something12:27
rcarrillocruzyah, just made it work12:27
rcarrillocruz         Starting Execute cloud user/final scripts...12:28
rcarrillocruzci-info: +++++++++++++++++Authorized keys from /home/ubuntu/.ssh/authorized_keys for user ubuntu++++++++++++++++++12:28
rcarrillocruzci-info: +---------+-------------------------------------------------+---------+---------------------------------+12:28
rcarrillocruzci-info: | Keytype |                Fingerprint (md5)                | Options |             Comment             |12:28
rcarrillocruzci-info: +---------+-------------------------------------------------+---------+---------------------------------+12:28
rcarrillocruzci-info: | ssh-rsa | 23:c7:0b:25:fa:28:99🆎2b:77🇨🇨57:19:dd:e5:ca |    -    | ricardo.carrillo.cruz@gmail.com |12:28
rcarrillocruzci-info: +---------+-------------------------------------------------+---------+---------------------------------+12:28
rcarrillocruzthe current docs confused me :/12:28
rcarrillocruzsorry for the noise12:28
mordred:)12:28
mordredand \o/12:28
rcarrillocruzbtw, super cool this, i was very worried nodepool was just a diskimage game, thankfully pabelanger put me on track with this new pool thing12:29
rcarrillocruzwhich is not the same as the old snapshot thing, but allwos me to do cloud images12:29
rcarrillocruzbtw, i'm going to put up a nodepool for network CI this week, will show to my peers12:29
rcarrillocruzprolly put a nightly job with ansible for our integration tests12:29
rcarrillocruzour nodepool will be made of ios, arista eos, juniper12:30
rcarrillocruzlol, interesting use case here12:30
mordredrcarrillocruz: oh - you were able to configure a pool with an existing cloud image?12:38
mordredrcarrillocruz: that was a thing we've talked about enabling, but I didn't think we'd actually done the work to enable that12:39
rcarrillocruzyeah, problem i had is that i did not know how to put key-name to injcet it12:39
rcarrillocruzputting it on the provider->pool->label did the trick12:39
mordredcool - I didn't realize it would look for an image in the cloud by name - I thought the image name was referring to an image nodepool knew about in zk12:39
rcarrillocruzwell, that's other thing12:40
rcarrillocruzif i put the cloud-image by name12:40
rcarrillocruzi get failure12:40
rcarrillocruzby ID i don't12:40
rcarrillocruzso i guess a patch is needed here12:40
mordredoh. fascinating12:40
rcarrillocruzi'll investigate next week12:40
mordredyah - that's definitely a use-case people have expressed wanting12:40
mordredso if we're one patch away from it being a thing, that's great12:41
rcarrillocruzyeah, i don't think it would be further away, ID works, so...12:41
mordredneat12:41
mordredrcarrillocruz: so you put the openstack id in the diskimage field of the label?12:47
mordredrcarrillocruz: OH - wait - "cloud_image"is what you use on the label for images already in the cloud13:02
mordredrcarrillocruz: did you see the "cloud-images" section of the docs?13:04
rcarrillocruzYah, cloud-image13:24
rcarrillocruzNow if I put the name attribute as image name13:24
rcarrillocruzIt fails13:24
rcarrillocruzWith id works13:24
pabelangerNice, I was planning trying cloud-images, but haven't yet13:26
rcarrillocruzI get a shade exception about invalid field attribute xenial13:26
rcarrillocruzCos well, my image is xenial13:26
pabelangerwe likely can update nodepool dsvm job too, and use cirros image for test13:26
rcarrillocruzI can share my nodepool yaml13:26
rcarrillocruzSec13:26
rcarrillocruzhttp://paste.openstack.org/show/612191/13:27
rcarrillocruzpabelanger , mordred ^13:27
mordredrcarrillocruz, pabelanger: oh! I think I see where we're missing something13:28
rcarrillocruznext step, upload an IOS or EOS image13:28
rcarrillocruzand write the ansible scaffolding to create groups per inventory13:29
rcarrillocruzand kick our integration runs13:29
rcarrillocruzit's unfortunate, but we do not run any integration testing for networking13:29
rcarrillocruzexcept for vyos13:29
rcarrillocruzwhich is why the intent of this, put up an internal CI, couple it with ARA and run it periodically13:30
rcarrillocruzthen move on to zuul and check it out the GH support13:30
rcarrillocruzall this is going to be big for us, most vendors will just use Zuul as 3rd party13:30
rcarrillocruzcos, we can't have every possible gear they have out there or wokring on on our side13:31
rcarrillocruzit's exactly the same thing for neutron 3rd party and cinder 3rd party13:31
rcarrillocruzjust for ansible network modules work13:31
pabelangerrcarrillocruz: nice13:38
pabelangerjust removed zmq-publishers from ansible role, no longer used13:38
openstackgerritMonty Taylor proposed openstack-infra/nodepool feature/zuulv3: Support booting cloud-images by name or id  https://review.openstack.org/47295913:53
mordredrcarrillocruz: ^^ that should fix you13:53
mordredrcarrillocruz: also - we have group support for inventories in zuul now13:54
mordredrcarrillocruz: so you hopefully shouldn't need to create any scaffolding for that13:55
mordredrcarrillocruz: oh - unless you're just using nodepool at the moment and not yet using zuul for the job running13:55
jeblairrcarrillocruz, mordred: https://review.openstack.org/458073 is the patch that added it14:08
mordredjeblair: cool- the patch to update it mostly just fixes a little logic error14:09
jeblairya looking it over now14:09
jeblairlgtm14:13
mordredsweet. rcarrillocruz if you're in a position to see if that fixes you for listing image by name, let us know14:15
jeblairmordred: https://review.openstack.org/472868 is an easy saturday review14:16
mordredjeblair: easy like sunday morning?14:16
jeblairit is easier than going 16-0 in the finals14:16
jeblairthat is, apparently, hard.14:16
mordredjeblair: this is what I hear14:18
mordredjeblair: that patch looks fine to me - how do we set verbose to true?14:18
jeblairmordred: "zuul-executor verbose"  and  "zuul executor unverbose"14:18
SpamapSbusy bees in here14:19
mordredah. neat14:19
jeblairmordred: i believe the commands are still plumbed through the cli14:19
mordredjeblair: oh! yes - I see it now14:19
mordredjeblair: I'm feeling like maybe we should emit debug logs from the zuul_stream callback to the stdout debug all the time but to the build log itself if -vvv is passed - what do you think?14:20
mordredso that we always catch it in tests, but only emit to build logs if we toggle verbose? or do you think we should just set verbose in the tests and not emit to either place unless verbose is toggled?14:21
jeblairmordred: i kind of like our ansible-log/executor-log split now -- if we can have consistent output into ansible log, but then control the verbosity of what ends up in executor log (so that an operator can debug zuul or ansible issues), i think that would be ideal.  so then in tests, just 'vvv' all the time.14:22
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add shutdown option for zuul_console  https://review.openstack.org/47286714:36
mordredjeblair: cool14:36
mordredjeblair, clarkb: ^^ thereis the clarkb code incorporated into the change -  Ihave not added additional error handling14:36
mordredI _did_ add reading /proc/net/tcp6 after testing it on one of our build nodes14:37
mordredbut it works in that state on a node running zuul_console14:37
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add shutdown option for zuul_console  https://review.openstack.org/47286714:38
mordredgiving clarkb credit in the commit :)14:38
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Enable verbose/unverbose zuul-executor commands  https://review.openstack.org/47286814:38
jeblairclarkb, mordred: did any of that code get borrowed from psutil?  if so, we should annotate it.14:39
jeblairit certainly has a different shape, so maybe it's all original.14:40
jeblairjust wanted to double check14:40
jeblairleft comments with the only 2 things i'd do for error handling.14:40
mordredjeblair: yah - my hunch from reading it was that it was clarkb code14:44
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add shutdown option for zuul_console  https://review.openstack.org/47286714:53
mordredjeblair: now with error handling14:53
jeblairmordred: 2 comments14:55
mordredah - good call14:56
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add shutdown option for zuul_console  https://review.openstack.org/47286714:56
mordredjeblair: I have validated that the code still works when it works :)14:57
mordredand neat - I just killed a zuul_console process with it and then verified that it correctly returned an error but not an exception when I tried it again14:59
clarkbjeblair: mordred my code is all original other than verifying scanning /proc that way is sane in psutil15:00
clarkbbecause pur use case is more constrained it was simpler to just focus on that then make general.solution fit15:01
jeblairclarkb: cool.  thought it might be, but just wanted to double check in case it slipped our attention.15:04
mordredclarkb: woot15:04
mordredclarkb: it works great - thanks for figuring that out15:04
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add shutdown option for zuul_console  https://review.openstack.org/47286715:07
mordredjeblair, SpamapS: ^^ pep8 fix15:07
openstackgerritMonty Taylor proposed openstack-infra/nodepool feature/zuulv3: Support booting cloud-images by name or id  https://review.openstack.org/47295915:16
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add shutdown option for zuul_console  https://review.openstack.org/47286715:30
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Use display.display for executor debug messages  https://review.openstack.org/47284015:54
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Use threads instead of processes in zuul_stream  https://review.openstack.org/47285015:54
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Don't wait for forever to join streamer  https://review.openstack.org/47283915:54
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Use display.display for executor debug messages  https://review.openstack.org/47284015:56
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Don't wait for forever to join streamer  https://review.openstack.org/47283915:56
mordredjeblair, SpamapS: reorganized that stack so that we don't have the add/remove of terminate() call15:56
mordredand also fixed the [Zuul] prefix thing15:56
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Make logging helper method in zuul_stream  https://review.openstack.org/47296316:15
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Only prepend hostname on multi-node plays  https://review.openstack.org/47296416:15
* SpamapS reviews a few things then goes back to rusting for pleasure16:22
*** jkilpatr has joined #zuul16:29
mordredSpamapS: mmm. rusting17:26
SpamapSmordred: tokio is making rustygear so much more comprehensible18:03
SpamapSAnd I get to drop my _AWFUL_ networking code18:04
mordredSpamapS: what's tokio18:38
*** dkranz has quit IRC20:17
SpamapSmordred: the mio author's long term vision for Rust IO20:19
SpamapSmordred: quite nice separation of codec/protocol from net code.20:19
*** dkranz has joined #zuul20:21

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!