| *** jkilpatr has quit IRC | 00:19 | |
| jlk | incoming...... | 00:45 |
|---|---|---|
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add cachecontrol to requests to github https://review.openstack.org/461587 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL https://review.openstack.org/446782 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status https://review.openstack.org/449390 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement trigger require/reject-approvals https://review.openstack.org/463387 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates https://review.openstack.org/453844 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement github trigger requirement status https://review.openstack.org/463386 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews https://review.openstack.org/453845 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Actually filter status triggers https://review.openstack.org/463385 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Create github client each time it's called. https://review.openstack.org/463421 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Use integration_id with github https://review.openstack.org/463420 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Refactor integration key loading to always load https://review.openstack.org/463423 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Represent github change ID in status page by PR number https://review.openstack.org/460716 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Decode JSON body once for requests https://review.openstack.org/463422 | 00:45 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Include tenant name in github context https://review.openstack.org/463871 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Test gerrit and github drivers in same tenant https://review.openstack.org/448257 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Save installation ids to a cache and fetch them per project https://review.openstack.org/463424 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Catch integration key file not found in zuul https://review.openstack.org/463425 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Include exc_info in reporter failure https://review.openstack.org/460765 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise https://review.openstack.org/449258 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review https://review.openstack.org/449365 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Ensure PRs arent rejected for stale negative reviews https://review.openstack.org/460700 | 00:46 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Comment on PRs if a remote call to merge a change failed https://review.openstack.org/460762 | 00:46 |
| *** jkilpatr has joined #zuul | 00:57 | |
| jamielennox | jeblair: for when you're here, what do you think about like a NO_JOBS or something state here: https://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/manager/__init__.py?h=feature/zuulv3#n746 | 01:09 |
| jamielennox | when our github trigger fires the start action sets the job status to pending on github | 01:10 |
| jamielennox | however in the situation of no jobs (like what will happen after signup but before you've set anything up) no actual event is triggered to the reporter and so nothing will ever move the status out of pending state | 01:11 |
| jamielennox | i can see why it shouldn't be success, it definitely shouldn't be a failure | 01:12 |
| jamielennox | so maybe we can add a 'nothing happened' state that gerrit can ignore and github can use to either clear the status altogether or set success (not sure what we'd do yet) | 01:12 |
| jamielennox | the other option is to not call start when there are no jobs, but i don't think we can know that information in addChange | 01:17 |
| *** jkilpatr has quit IRC | 01:17 | |
| *** smyers has quit IRC | 01:43 | |
| tobiash | jamielennox: that sounds similar like a bug I encountered where zuulv3 reports start on every project on the gerrit | 04:45 |
| tobiash | jamielennox: I have a fix (still needs a bit of polishing) for that: https://review.openstack.org/#/c/455711/ | 04:45 |
| jamielennox | tobiash: yea, that will be exactly the same - but at least in the gerrit reporter you can opt out of a start message | 04:46 |
| tobiash | jamielennox: maybe that also solves your issue | 04:46 |
| jamielennox | oh, that's a bit more involved - i didn't realize it would report for everything | 04:47 |
| tobiash | yeah, I also was surprised when I saw "Starting check jobs" messages on completely unrelated projects ;) | 04:47 |
| jamielennox | tobiash: oh, interesting - so at the moment i don't have a gerrithub start job on | 04:48 |
| jamielennox | but i'm connected to, and receiving messages for everything that happens on gerrithub | 04:48 |
| jamielennox | so that's probably really lucky | 04:48 |
| jamielennox | in the github case things are a little more obvious bevcause you're probably only receiving webhooks for repos that you actually care about | 04:49 |
| tobiash | ok, that hides the broader scope it has for gerrit | 04:50 |
| jamielennox | hmm, so yea, that's a big problem - similar, but not exactly the same. In my case i have the project registered and in a queue, but there are no jobs run and so there is an escape instead of setting success/failure | 04:53 |
| jamielennox | but i will have to play with that patch a bit as well | 04:53 |
| jamielennox | and we should consider both cases when thinking if we want to emit a start message from addChange or later | 04:53 |
| *** Cibo_ has joined #zuul | 06:38 | |
| *** hashar has joined #zuul | 06:46 | |
| *** jamielennox is now known as jamielennox|away | 06:53 | |
| *** DangerousDaren has joined #zuul | 08:15 | |
| *** Cibo_ has quit IRC | 08:57 | |
| *** Cibo_ has joined #zuul | 08:57 | |
| *** Cibo_ has quit IRC | 09:07 | |
| *** Cibo_ has joined #zuul | 09:17 | |
| *** Cibo_ has quit IRC | 11:00 | |
| *** jkilpatr has joined #zuul | 11:12 | |
| *** Cibo_ has joined #zuul | 12:06 | |
| tobiash | jamielennox: my patch seems to be broken now and needs to be rethought of... | 12:09 |
| *** jamielennox|away is now known as jamielennox | 12:30 | |
| *** Cibo_ has quit IRC | 13:06 | |
| *** pabelanger has quit IRC | 13:36 | |
| *** pabelanger has joined #zuul | 13:36 | |
| *** DangerousDaren has quit IRC | 13:36 | |
| *** DangerousDaren has joined #zuul | 13:37 | |
| *** smyers has joined #zuul | 14:19 | |
| openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Fix CleanupWorker exception messages https://review.openstack.org/461019 | 14:33 |
| *** dkranz_ has joined #zuul | 15:05 | |
| *** dkranz_ has quit IRC | 16:01 | |
| *** dkranz_ has joined #zuul | 16:01 | |
| *** DangerousDaren has quit IRC | 16:16 | |
| *** Cibo_ has joined #zuul | 16:47 | |
| *** Cibo_ has quit IRC | 16:55 | |
| jlk | jeblair: should some of the earlier github patches get merged in, or do you want to wait until the entire (or most of) the stack is approved so they all go in at once? | 17:05 |
| *** Cibo_ has joined #zuul | 17:07 | |
| SpamapS | it's such a big stack, would be nice to land anything that is done. | 17:15 |
| jlk | mordred: are you back? Do you have some bandwidth to pass some judgement on the github-v3 patch series? | 17:19 |
| mordred | jlk: yes! let me clear just a few other things off of my brainstack then I will do that | 17:20 |
| jlk | mmmm tasty brainstack. | 17:21 |
| *** jkilpatr has quit IRC | 17:26 | |
| *** jkilpatr has joined #zuul | 17:28 | |
| *** Cibo_ has quit IRC | 17:53 | |
| *** Cibo_ has joined #zuul | 17:55 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Rename nodepool.py to launcher.py https://review.openstack.org/463807 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Ensure zookeeper_servers is a list https://review.openstack.org/463880 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use six.moves.urllib for python3 compat https://review.openstack.org/463595 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Update exception message handling for python3 https://review.openstack.org/464034 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Sort flavors with operator.itemgetter('ram') https://review.openstack.org/463998 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Use raise Exception for python3 https://review.openstack.org/463594 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Add waitForImage to test_lost_request https://review.openstack.org/464075 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Replace dict.iteritems() with dict.items() for python3 https://review.openstack.org/464026 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Switch to next(generator) for python3 https://review.openstack.org/464040 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Fix imports for python3 https://review.openstack.org/463808 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Remove FakeFile from fakeprovider.py https://review.openstack.org/463587 | 18:10 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool feature/zuulv3: Python 3.x incompatible use of print operator https://review.openstack.org/463586 | 18:10 |
| SpamapS | pabelanger: aint python3 fun? | 18:16 |
| pabelanger | SpamapS: indeed. But learning stuff | 18:17 |
| SpamapS | I actually like that it forces explicit thinking about when to use unicode. | 18:19 |
| SpamapS | but zomg that breaks so much | 18:19 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Move playbook out of zuul https://review.openstack.org/462210 | 18:39 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Remove pipeline argument from various report fncts https://review.openstack.org/464252 | 18:48 |
| * jlk picks off a TODO I saw. | 18:48 | |
| *** jkilpatr has quit IRC | 18:50 | |
| pabelanger | Shrews: So, I see a bunch of locked nodes in nl01.o.o, I believe this is a result of running out of HDD space the other day | 18:50 |
| pabelanger | Shrews: how would you like to proceed? | 18:50 |
| Shrews | pabelanger: zuul holds the locks. Stopping it will release the locks. Don't know what will happen with the jobs | 18:55 |
| pabelanger | we'd lose jobs, unless we dumped queues | 18:56 |
| pabelanger | I think that is okay, since they would just fail because tests we broken | 18:56 |
| pabelanger | let me do that | 18:56 |
| *** jkilpatr has joined #zuul | 18:57 | |
| *** harlowja has quit IRC | 19:02 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Add jobs back to .zuul.yaml https://review.openstack.org/462212 | 19:20 |
| pabelanger | \o/ | 19:20 |
| pabelanger | jobs will be working again | 19:20 |
| mordred | SpamapS: I think my experience with Drizzle, and now with python2->python3 has taught me that moving from non-unicode to unicode in a project is a "yes, it's the correct thing, but is so fraught with peril that it's probably not the right thing" | 19:23 |
| mordred | all the assumptions related to this stuff go DEEEEEP | 19:23 |
| *** hashar has quit IRC | 19:38 | |
| SpamapS | mordred: it's worth having a chimera string in between I think | 20:16 |
| SpamapS | like, something a little better than py2's magic | 20:17 |
| SpamapS | but I wouldn't mind if py3 had a mode where low level stuff returned a str that tried really hard to work like utf-8 bytes unless it just can't. | 20:17 |
| SpamapS | mordred: also it's not just the implementation you're working with's fault. Protocols.. file formats.. the whole world screwed this up | 20:18 |
| *** morgan_ has joined #zuul | 20:19 | |
| *** morgan_ has quit IRC | 20:20 | |
| *** yolanda has quit IRC | 20:35 | |
| *** yolanda has joined #zuul | 20:43 | |
| mordred | SpamapS: they really did | 20:43 |
| mordred | SpamapS: but I think for things like python or mysql that also have their own users with content - _changing_ the default has the potential to break so many things ... I haven't seen such a change go well yet | 20:44 |
| mordred | (changes of default from vague to strict pretty much always wind up punching someone in the face) | 20:44 |
| *** jkilpatr has quit IRC | 21:04 | |
| *** harlowja has joined #zuul | 22:40 | |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Remove uncalled test code https://review.openstack.org/464276 | 22:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!