SpamapS | The way I've seen py3 transitions work well is to start by finding all the tests that pass on py3, and skipIf'ing the others when running under 3 | 00:23 |
---|---|---|
SpamapS | Then you can just do like the test-reenablement... one by one pick them off | 00:24 |
jlk | soudns familiar | 00:29 |
*** jkilpatr has quit IRC | 00:35 | |
SpamapS | is there a succinct place that lists all the vars zuul exposes to playbooks by default? | 00:45 |
SpamapS | I need the build UUID | 00:45 |
adam_g | SpamapS: i needed to know the same, captured this for reference http://paste.ubuntu.com/24514310/ | 00:48 |
clarkb | yes in zuul docs | 00:48 |
SpamapS | that's handy | 00:48 |
SpamapS | not sure what that uuid is tho | 00:49 |
pabelanger | looks like I'll have to talk with Shrews about nodepool python3. The fun looks to be around encoding / decoding for kazoo | 00:49 |
SpamapS | pabelanger: it's not hard to just build a facade in front of it. | 00:50 |
SpamapS | was looking at doing that in zuul too | 00:50 |
SpamapS | we can even call it TextKazoo or something ;) | 00:50 |
SpamapS | pabelanger: note I did the same for gear | 00:50 |
SpamapS | it's still a WIP though... easy to miss things and accidentally be looking in a dict for the key "b'foo'" instead of "foo" | 00:51 |
pabelanger | Ya, nodepool seem to have something already, strToDict() / dictToStr for the data. Just need to switch from str to bytes | 00:51 |
adam_g | SpamapS: zuul.uuid is the build uuid, AFAICS from working with some of the ansible tests atm | 00:51 |
SpamapS | adam_g: yeah I think that's the one I want. :) | 00:51 |
pabelanger | yes, we use zuul.uuid to hash logs on zuulv3-dev.o.o/logs ATM | 00:52 |
jlk | I see some defined in zuul/executor/client.py | 00:52 |
SpamapS | yeah I just want to make sure we build the right number of SSH keys :) | 00:53 |
* SpamapS rebases things | 01:11 | |
SpamapS | gah | 01:12 |
SpamapS | remote: (W) No changes between prior commit ba373c6 and new commit 5069772 | 01:12 |
SpamapS | I know.. can you just.. fix that for me? :-P | 01:12 |
clarkb | this is why cherry picking is painful with gerrit | 01:12 |
clarkb | always use the rebase | 01:12 |
SpamapS | I didn't cherry pick | 01:13 |
SpamapS | maybe pabelanger did when he rebased my stack on it :-P | 01:13 |
clarkb | did you edit then not edit? | 01:13 |
clarkb | rebase will do the right thing (tm) as far as gerrit is concerned as long as somethign actually changes | 01:13 |
clarkb | or it will nop if nothing does | 01:14 |
SpamapS | in this case I was reordering things | 01:14 |
SpamapS | and I moved things before it, then thought better of that | 01:14 |
clarkb | pretty sure changing parents is sufficient to make gerrit happy | 01:14 |
SpamapS | so now I have to rebase mine on the original :-P | 01:14 |
clarkb | cherry picking is problematic because it will (in some case) only update the timestamp and consequently the sha1 | 01:15 |
clarkb | which gerrit then complains about | 01:15 |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Add SSH Agent Primitives and usage https://review.openstack.org/462712 | 01:15 |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Add support for bwrap https://review.openstack.org/453851 | 01:15 |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Create a temporary SSH key and distribute it https://review.openstack.org/462768 | 01:15 |
SpamapS | alright | 01:15 |
SpamapS | that's still pretty WIP.. and I need to EOD.. but it captures my thinking and I think handles everything from the etherpad | 01:15 |
* SpamapS shakes fist at trailing spaces | 01:16 | |
jamielennox | jeblair: so the failure in https://review.openstack.org/#/c/461981/ is because http://git.openstack.org/cgit/openstack-infra/zuul/tree/tests/unit/test_connection.py?h=feature/zuulv3#n29 has 2 gerrit connections pointing at the same host with different users | 01:44 |
jamielennox | so it's receiving events with one user and commenting with another | 01:45 |
jamielennox | this change would explicitly break that case | 01:45 |
jamielennox | preference on a fix? | 01:45 |
jamielennox | need to afk for a bit, but i'll check log when i'm back | 01:46 |
*** jamielennox is now known as jamielennox|away | 01:55 | |
*** jamielennox|away is now known as jamielennox | 02:19 | |
*** yolanda has joined #zuul | 02:26 | |
*** Cibo_ has joined #zuul | 07:38 | |
*** Cibo_ has quit IRC | 07:40 | |
*** Cibo_ has joined #zuul | 07:40 | |
*** hashar has joined #zuul | 08:33 | |
*** Cibo has joined #zuul | 09:39 | |
*** Cibo_ has quit IRC | 09:41 | |
*** TaylorH has joined #zuul | 10:48 | |
*** jkilpatr has joined #zuul | 10:51 | |
*** TaylorHuang has quit IRC | 10:51 | |
*** Cibo has quit IRC | 10:52 | |
*** yolanda has quit IRC | 11:10 | |
*** Cibo has joined #zuul | 11:18 | |
*** yolanda has joined #zuul | 12:33 | |
*** Cibo has quit IRC | 12:44 | |
*** yolanda has quit IRC | 13:02 | |
*** jkilpatr has quit IRC | 13:02 | |
*** hashar has quit IRC | 13:02 | |
*** hashar has joined #zuul | 13:04 | |
*** yolanda has joined #zuul | 13:08 | |
*** jkilpatr has joined #zuul | 13:10 | |
*** Cibo has joined #zuul | 14:09 | |
jeblair | jamielennox: hrm, tricky. only thing i can think of atm is to compare the hostname. | 14:31 |
*** Cibo has quit IRC | 14:44 | |
*** hashar is now known as hasharDisappear | 14:55 | |
*** herlo has quit IRC | 15:22 | |
*** herlo has joined #zuul | 15:41 | |
*** herlo has joined #zuul | 15:41 | |
*** yolanda has quit IRC | 16:23 | |
*** herlo has quit IRC | 16:29 | |
*** herlo has joined #zuul | 16:35 | |
*** herlo has left #zuul | 16:35 | |
*** jkilpatr has quit IRC | 16:50 | |
*** jkilpatr has joined #zuul | 16:52 | |
*** yolanda has joined #zuul | 16:54 | |
*** harlowja has quit IRC | 17:03 | |
openstackgerrit | Adam Gandelman proposed openstack-infra/zuul feature/zuulv3: Abort jobs if JobDir disk usage exceeds an optional maximum https://review.openstack.org/463022 | 17:46 |
openstackgerrit | Adam Gandelman proposed openstack-infra/zuul feature/zuulv3: Abort jobs if JobDir disk usage exceeds an optional maximum https://review.openstack.org/463022 | 17:49 |
openstackgerrit | Adam Gandelman proposed openstack-infra/zuul feature/zuulv3: Abort jobs if JobDir disk usage exceeds an optional maximum https://review.openstack.org/463022 | 17:51 |
*** jkilpatr has quit IRC | 18:12 | |
*** jkilpatr has joined #zuul | 18:17 | |
*** openstackgerrit has quit IRC | 18:18 | |
*** harlowja has joined #zuul | 19:48 | |
*** dkranz_ has quit IRC | 19:53 | |
*** harlowja has quit IRC | 19:56 | |
*** openstackgerrit has joined #zuul | 19:59 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Store initial repo state in the merger https://review.openstack.org/461176 | 19:59 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Use previously stored repo state on executor https://review.openstack.org/461177 | 19:59 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Wait for merger to complete before item is ready https://review.openstack.org/463054 | 19:59 |
*** Cibo has joined #zuul | 20:03 | |
*** hasharDisappear is now known as hashar | 20:18 | |
jeblair | jlk: i've picked up reviewing the github branch again; i've left a couple of notes so far. (mostly this is a wake event on the semaphore, in case you were waiting on that. :) | 20:31 |
*** dkranz_ has joined #zuul | 20:54 | |
*** yolanda has quit IRC | 21:01 | |
*** jkilpatr has quit IRC | 21:10 | |
*** Cibo has quit IRC | 21:25 | |
*** SotK_ is now known as SotK | 21:29 | |
*** harlowja has joined #zuul | 21:34 | |
*** jkilpatr has joined #zuul | 21:47 | |
*** hashar has quit IRC | 22:37 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!