Thursday, 2017-03-30

openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: Perform pre-launch merge checks  https://review.openstack.org/44627500:19
openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: Perform pre-launch merge checks  https://review.openstack.org/44627501:36
*** adam_g has quit IRC04:44
*** adam_g has joined #zuul04:45
tobiash_jeblair: no worries, I didn't have in mind of swapping the asserts. For consistency I'll just stick like the rest of the code.04:59
*** dmellado has quit IRC05:14
*** pabelanger has quit IRC05:14
*** dmellado has joined #zuul05:16
*** pabelanger has joined #zuul05:20
*** jasondotstar has quit IRC05:31
*** jasondotstar has joined #zuul05:35
*** isaacb has joined #zuul06:25
*** eventingmonkey has quit IRC06:30
*** eventingmonkey has joined #zuul06:32
tobiash_jeblair: what are the longtem plans with gearman/zookeeper? Is it planned to get rid of gearman completely?07:06
tobiash_This maybe could ease use cases like automatic/transparent restart of jobs when an executor shuts down07:07
tobiash_Maybe useful for automatic zuul-executor scaling later on07:08
tobiash_or persistent job queues for maintenance breaks07:09
*** openstackgerrit has quit IRC08:03
*** hashar has joined #zuul08:04
lennybhi, is it OK that zuul quires changes from the gerrit from the projects that are not listed in layout.yaml?09:04
*** openstackgerrit has joined #zuul10:30
openstackgerritJoshua Hesketh proposed openstack-infra/nodepool feature/zuulv3: Merge branch 'master' into feature/zuulv3  https://review.openstack.org/44532510:30
openstackgerritJoshua Hesketh proposed openstack-infra/nodepool feature/zuulv3: Fix test_leaked_node_not_deleted for v3  https://review.openstack.org/44937510:46
openstackgerritJoshua Hesketh proposed openstack-infra/nodepool feature/zuulv3: Merge branch 'master' into feature/zuulv3  https://review.openstack.org/44532510:46
*** hashar is now known as hasharAway11:00
*** hasharAway is now known as hashar12:00
Shrewsjhesketh: sorry that merge has been a PITA. thx for doing that12:44
Shrewsi wonder if we should just delete the nodepool_id code rather than fixing the test_leaked_node_not_deleted test12:44
Shrewstobiash_: spec mentions that gearman will remain for v3. https://specs.openstack.org/openstack-infra/infra-specs/specs/zuulv3.html#ansible12:48
Shrewsat least on the zuul side of things. nodepool doesn't need it now12:48
jheskethShrews: all good.. if we can get it merged before more patches land in master that'd be handy :-)13:02
jhesketh(or v3 for that matter)13:02
jheskethShrews: I also have the follow up to those tests: https://review.openstack.org/#/c/449375/713:02
Shrewsjhesketh: yup. already +2'd the first. the 2nd is the one i'm wondering whether we should skip and just delete the nodepool_id code13:03
Shrewsi might toss that up today while you sleep13:04
jheskethShrews: right.. that probably needs some discussion. mordred had thought it may still be of use13:04
Shrewsk13:05
*** isaacb_ has joined #zuul13:55
*** isaacb has quit IRC13:58
jeblairjhesketh, Shrews: i think the results of the most recent discussion is that we should not port nodepool_id to v314:12
pabelangermorning!14:14
jheskethjeblair, Shrews: sure.. I can do that in a follow up commit, I think it makes more sense than in the merge (and simplifies it)14:26
tobiash_Shrews: thx14:28
jeblairtobiash_, Shrews: we've talked about replacing more of gearman with zk in zuul, but much later, after v3 is finished.  i call it zuul v4.  :)  there's a note about it here: http://specs.openstack.org/openstack-infra/infra-specs/specs/nodepool-zookeeper-workers.html#future-work14:29
tobiash_jeblair: ah, just wanted to ask if that was a decision or posponed to v4 ;)14:31
jeblairtobiash_: i don't think we've quite decided to do it yet, but it's a possibility for us to consider later.  i think it's promising.14:32
tobiash_jeblair: fully distributed zuul, pretty challenging, but a killer feature :)14:36
*** isaacb_ has quit IRC14:41
*** tobiash_ is now known as tobiash14:42
mordred++14:44
*** isaacb_ has joined #zuul14:47
*** hashar has quit IRC15:01
openstackgerritMonty Taylor proposed openstack-infra/nodepool feature/zuulv3: Add ability to select flavor by name or id  https://review.openstack.org/44978415:04
mordredjeblair: ok - I think that ^^ has it now15:04
mordredjeblair: maybe we want to add in a voluptuous thing to encode "you have to at least have one of flavor-name or min-ram"15:05
*** isaacb__ has joined #zuul15:11
*** isaacb_ has quit IRC15:15
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Fetch list of AZs from nova if it's not configured  https://review.openstack.org/45034515:31
openstackgerritJames E. Blair proposed openstack-infra/nodepool feature/zuulv3: Cleanup from config syntax change  https://review.openstack.org/45186815:33
openstackgerritJames E. Blair proposed openstack-infra/nodepool feature/zuulv3: Validate flavor specification in config  https://review.openstack.org/45187515:43
jeblairmordred: lgtm, and i think that ^ should do that15:43
*** isaacb__ has quit IRC15:56
Shrewsthose lgtm, too, and i'm ready to +3 them, but i'd rather see jhesketh's merge get done first15:56
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add canonical hostname to source object  https://review.openstack.org/45111015:56
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add source to projects  https://review.openstack.org/45159615:56
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add a project index to Tenant  https://review.openstack.org/45159715:57
jeblairShrews: good point, i'll review that now15:57
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Merge branch 'master' into feature/zuulv3  https://review.openstack.org/44532516:03
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Remove support for nodepool_id  https://review.openstack.org/45188916:09
SpamapSjeblair: idea for cool feature for gertty... a key binding that does "diff against patchset of the last review I performed"17:03
jeblairSpamapS: ++17:11
SpamapSbtw, presentty and cowsay were saved, and will be in the next Debian stable release. :)17:12
jeblairSpamapS: whew!17:13
jeblairSpamapS: http://paste.openstack.org/show/604899/17:15
SpamapShaha17:18
SpamapSIt's all thanks to the cowsay maintainers. ;)17:18
clarkbwait does presentty dep on cowsay in debain so was going to be removed if cowsay was removed?17:20
clarkbalso is cowsay being removed because everyone using ansible hates it now?17:20
clarkbI guess not actually remvoed but was that the argument?17:21
SpamapSclarkb: yes, no, perhaps it should have been. ;)17:22
SpamapSclarkb: cowsay was going to be removed because some of the cow ascii art had no license.17:22
SpamapSclarkb: but they removed the ones that had unclear licensing.17:23
clarkbah that makes sense17:23
clarkbalso cowsay is perfectly useable if you remove all the art from the project itself17:23
clarkb(you can provide your own)17:23
SpamapSWell most of the art did have licensing.17:24
SpamapSJust a few didn't.17:24
SpamapSAnd a few were poorly documented, so I believe it has been resolved now, and meow, bong, and beavis, have been removed.17:24
SpamapSoh no, hm.. those were moved to cowsay-off which are offensive cows17:25
SpamapSor something. who cares. :)17:26
jeblairi would attend a cowsay-off contest where the best cowsayers compete.  like at a cownty fair.17:31
SpamapSwould we invite all of the moovers and shaykers?17:35
jeblairdefinitely all the Prime talent17:36
SpamapSI suspect you're just ribbing me. One cud take that personally.17:42
Shrewscows go moo17:45
Shrewsam i playing right?17:45
SpamapSShrews: you're milking it a little....17:46
jlkThis channel is just bovine, but can we steer things back into a more serious direction?17:46
SpamapSjlk: good idea. I think we should make zuul executors more like cattle.. less like pets..17:48
jeblairoh good! a chance to trot out my cattle/pets thing!  cattle sell for something like $1500 a head, so when they get sick, you better believe the rancher has a vet take a look at them.17:52
SpamapSjeblair: you can get a good look at a T-bone by SSH'ing into the bull, but I'd rather take the sysadmin's word for it.17:53
*** unrahul_ has joined #zuul17:55
*** TheJulia_ has joined #zuul17:56
*** colettecello has joined #zuul17:57
*** TheJulia has quit IRC17:59
*** phschwartz has quit IRC17:59
*** clarkb has quit IRC17:59
*** gothicmindfood has quit IRC17:59
*** jlk has quit IRC17:59
*** unrahul has quit IRC17:59
*** mordred has quit IRC17:59
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Pass source to project instantiations  https://review.openstack.org/45159617:59
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add a project index to Tenant  https://review.openstack.org/45159717:59
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Use new tenant project index for zuul role refs  https://review.openstack.org/45192817:59
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused Tenant.getRepo method  https://review.openstack.org/45192917:59
*** jlk has joined #zuul18:00
*** jlk has quit IRC18:00
*** jlk has joined #zuul18:00
*** phschwartz has joined #zuul18:00
*** clarkb has joined #zuul18:01
*** mordred has joined #zuul18:02
*** unrahul_ is now known as unrahul18:03
*** colettecello has quit IRC18:10
*** gothicmindfood has joined #zuul18:10
Shrewsjeblair: did you ever write up your zuul test environment tips somewhere?18:46
*** TheJulia_ is now known as TheJulia18:56
jlkgetting so tired of reading tox logs18:57
Shrewsjlk: use ttrun and read stdout instead19:00
jlkwell that's basically what I'm doing19:00
jlkI'm reading stdout, of the tox run19:00
jeblairShrews: er, no.  :(19:11
Shrewsi found ZUUL_TEST_ROOT. good enough for now, and was the thing i noted to remember a while back19:13
Shrewsbut didn't note it anywhere :/19:14
SpamapSjlk: I use ttrun and pipe through ccze -A ...19:44
SpamapSsounds silly, but breaking up the grey monotony with a few red/yellow/green words helps19:44
jeblair(might ccze be a good ttrun option?)19:45
SpamapSperhaps. It's meant as a generic log highlither. So it makes words like "error" red, and "OK" green.19:46
SpamapShighlither's are very flexible tho19:46
*** yolanda has quit IRC19:47
fungiokay, i've finally managed to work my way through the encrypted secrets stack (twice so i knew what i was looking at the second time) and it all lgtm19:52
fungialso reread the ml thread so i could be sure it matched what was discussed19:53
* fungi will need an extra beer tonight19:53
SpamapSI just found my way through it too19:55
SpamapSSeems solid19:55
jeblairfungi: thank you!  (also, are you planning on reviewing it a 3rd time with beer goggles?)19:55
jeblairSpamapS: you too :)19:55
* SpamapS stacks yaml thing on top of it19:55
SpamapSjesusaur: did you still want a second set of eyes on test fails in your merge conflict patches?19:57
fungijeblair: not a terrible idea ;)19:57
jesusaurSpamapS: yeah, specifically around the failures in post queues, such as in test_client_enqueue_ref19:58
jesusaurSpamapS: I'm currently looking into why the check queue isn't reporting start (and possibly not running jobs) in test_delayed_merge_conflict19:58
SpamapSoooo TIL I learned a new vim trick19:59
SpamapS:e **/**<partialfilename>[tab]19:59
SpamapSit uses fuzzy matches too19:59
SpamapSfinds the file somewhere under cwd19:59
SpamapSjesusaur: Ok I'll attack the post queues fails.20:00
jeblairjesusaur: oh i hadn't noticed the new patchset, sorry.  i'll get in line after SpamapS.  :)20:01
jlk  py27: commands succeeded20:02
jlk  congratulations :)20:02
jlk^^^ that has begun to make me unreasonably happy.20:02
jeblairhaven't seen that in a while, myself20:04
SpamapShah20:04
pabelangerso much scroll back20:04
SpamapSwell this yaml change seems to get it to you about 1 minute faster.. so there's that.20:05
jesusaurSpamapS: awesome, it takes me like 20 minutes to run the full set of tests locally20:08
* SpamapS just confirmed Ansible does prefer libyaml/cparser/etc20:08
SpamapSjesusaur: oh, we can help with that.20:08
jesusaurI guess my laptop isn't quite powerful enough to run tox and firefox at the same time20:08
SpamapSassuming you're on Ubuntu/Debian..20:09
SpamapSnone /var/lib/zookeeper tmpfs defaults 0 020:09
SpamapSadding that to your fstab helps a bit20:09
jesusauroooh20:09
* jesusaur does the thing20:09
SpamapSand then pointing ZUUL_TEST_ROOT to a tmpfs will get you a lot too20:09
clarkbjust don't run a real zookeeper there20:10
SpamapSclarkb: if you're doing it right, it's fine. ;)20:10
SpamapSassuming you don't reboot all three+ at once.20:10
SpamapSbut yeah, best to persist to disk for real zk :)20:10
SpamapShrm20:13
SpamapSI still get some Alarmclock fails20:13
SpamapSsetting OS_TEST_TIMEOUT=120 fixes it20:15
SpamapScouple tests are just slow for some reason20:15
SpamapSjesusaur: ever thought of porting Zuul to use this: https://github.com/libgit2/pygit2 ?20:16
SpamapSThe bulk of the CPU load during these tests is system load.. and I think it's from all the forking of git20:17
clarkbwhats the git lib that Zara was looking at recently? that one looked pretty good20:18
clarkbdulwich20:18
SpamapSThis one looks pretty solid.20:18
clarkbiirc it had weird licensing due to the C lib?20:18
SpamapSseems like an area where an optimized C implementation would win.20:18
SpamapSew yeah20:19
SpamapSit's GPLv2 with linking exception to open source projects20:19
SpamapSso, like MySQL20:19
SpamapSProlly not Apache 2.0 compatible20:19
jeblairwe need to be able to create merges, primarily the way cgit does it (which is *very good*), but also being able to approximate what gerrit does (which cgit also does).  that's the primary driver that got us to gitpython.  i have not re-evaluated the others for that recently.20:19
clarkbdulwich is more like jgit in design I think, so possibly not great in that respect20:20
clarkbit give you proper python primitives for doing things20:20
SpamapSit's complicated enough that I think one needs more reasons to switch than "the test suite is slow"20:21
SpamapSPerhaps when somebody runs it at scale we can re-evaluate ;)20:21
jeblairimplementing our own octomerge algorithm is not high on my list of things to do (and i like writing code!)20:21
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Pass source to project instantiations  https://review.openstack.org/45159620:25
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add a project index to Tenant  https://review.openstack.org/45159720:25
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused Tenant.getRepo method  https://review.openstack.org/45192920:25
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Use new tenant project index for zuul role refs  https://review.openstack.org/45192820:25
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add source to project and remove unused tenant attrs  https://review.openstack.org/45196920:25
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fully qualify project configuration names  https://review.openstack.org/45197020:25
SpamapSRan 210 (+16) tests in 820.741s (+46.911s)20:39
SpamapSFAILED (id=39, failures=2 (-2), skips=30)20:39
SpamapSStill hit the timeout even with OS_TEST_TIMEOUT=120 .. trying with 9999 now20:40
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fully qualify project configuration names  https://review.openstack.org/45197020:52
openstackgerritDirk Mueller proposed openstack-infra/nodepool master: [WIP]: Add opensuse 42.2 DIB testing  https://review.openstack.org/45004521:17
*** dkranz has joined #zuul21:23
openstackgerritDirk Mueller proposed openstack-infra/nodepool master: [WIP]: Add opensuse 42.2 DIB testing  https://review.openstack.org/45004521:25
*** dkranz has quit IRC21:28
jheskethMorning21:54
*** harlowja has quit IRC22:02
mordredit's a jhesketh22:07
jeblairjesusaur, SpamapS: i think i spotted the issue with test_client_enqueue_ref; left comments on 44627522:08
jesusaurjeblair: cool, thanks22:21
*** jlk has quit IRC22:43
*** jlk has joined #zuul22:44
*** jlk has quit IRC22:44
*** jlk has joined #zuul22:44
SpamapSoh yay, I had gotten side-tracked by tests that timeout22:46
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fully qualify project configuration names  https://review.openstack.org/45197022:51
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add source to project and remove unused tenant attrs  https://review.openstack.org/45196922:51
jesusaurjeblair: your comment says that the current code schedules a merge for Refs, but one of the issues I was seeing was tracebacks in the merger when a merge was scheduled for a Ref because zuul_ref couldn't be constructed (+ not defined for types str and NoneType, because a Ref doesn't have a branch attribute)22:52
jesusaurjeblair: are you sure that we currently schedule merge jobs for post pipeline jobs?22:52
jeblairjesusaur: er, yeah, my comment is wrong.  sorry.  (that would only happen for a ref which changes the config and the updatesConfig method of Refs always returns false).  so let's strike that paragraph.22:55
jesusaurok22:55
jesusaurI'm going to test with setting merge_state to COMPLETE if we try to merge a Ref and see how that fares22:59
jesusaurjeblair: also, the other possible path to getLayout is from handling either ReconfigureEvent or TenantReconfigureEvent, do we need to worry about scheduling a merge if we are handling those events?23:03
jesusaurw00t, ok, down to 2 failures23:15
jesusauri might actually get this working this week \o/23:15
SpamapSnice23:15
* mordred hands jesusaur a somewhat unused pancake23:16
jesusaurmordred: lol23:16
SpamapSI'm still getting hard alarm clock timeouts, even on feature/zuulv3 tip on my laptop...23:16
SpamapSstarting to think there's something else b0rken23:16
jesusaurSpamapS: yeah, I've taken to rerunning with --failing until the number of failing tests doesn't change; i really hope i'm not introducing a race somewhere23:17
SpamapSwell thing is.. I'm running with OS_TEST_TIMEOUT=9999 ... so I'm not sure where the alarm clock is even coming from at this point.23:18
jesusauroh, huh23:18
jeblairjesusaur: what's the path from ReconfigureEvent to getLayout?23:22
*** harlowja has joined #zuul23:24
jeblairjesusaur: the paths i'm seeing all go through processOneItem, so should be okay i think.  unless i'm missing something.23:33
jesusaurjeblair: reEnqueueItem calls getLayout, which is called in _reenqueueTenant23:34
jeblairjesusaur: ah there it is :)23:34
SpamapS  PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND23:37
SpamapS16862 clint     20   0 3977472 1.336g   8136 D 106.3  8.7   8:36.40 python23:38
SpamapS16856 clint     20   0 3400540 1.253g   8232 R  51.5  8.1   8:45.11 python23:38
SpamapSoops23:38
SpamapSmeant to pastebin that..23:38
SpamapSbig RAM :-P23:38
jeblairjesusaur: it shouldn't need to schedule one (the normal algorithm will do that), but it does need to be state machine aware, so it should probably at least still keep the check for COMPLETE and otherwise return None.23:41
*** openstack has joined #zuul23:46
SpamapSSo, in addition to going a bit faster.. I believe the libyaml patch also saves memory usage.23:53
* SpamapS just trying to figure out how to run things reliably on a 16GB laptop23:53
openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: Perform pre-launch merge checks  https://review.openstack.org/44627523:53
SpamapSjesusaur: so I am going to EOD soon, been watching you and jeblair and have held back diving in again. You're down to 2 fails you say?23:54
jesusaurSpamapS: actually just one now: my new test case around delayed merge conflicts23:55
jesusaurI'm going to EOD soon as well, but I think I'll be able to figure out my issue with the number of reports tomorrow, and then it'll be ready for review23:57
SpamapSsweet23:57
SpamapSI'll focus on some other stuff23:57
jesusaurcool23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!