| jlk | HOLY SHIT TESTS ARE PASSING | 00:17 |
|---|---|---|
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support GitHub PR webhooks https://review.openstack.org/439834 | 00:43 |
| *** jamielennox|away is now known as jamielennox | 00:43 | |
| jeblair | jlk: maybe we should set that as the "success-message:" for the zuulv3 py27 job? :) | 01:07 |
| jlk | hahaha. | 01:07 |
| jlk | well, a tiny subset of my tests are passing. I think scheduler tests are stuck in an infinite loop? seem to be going on and on and on | 01:08 |
| jeblair | jlk: yeah, that's a pretty common failure mode for the way the tests are constructed. that's where running in the foreground and looking for the first traceback helps. | 01:09 |
| jlk | ah, well, looks like something is loading a BaseTestCase without overriding the config_file, so something is loading tests/fixtures/zuul.conf, and failing to load the tenant config | 01:13 |
| jlk | oh weird | 01:15 |
| jlk | that happens even on HEAD of the branch | 01:15 |
| jlk | python -m testtools.run tests.test_scheduler.TestScheduler.test_jobs_launched does that fail immediately for you? | 01:16 |
| jeblair | no that sounds strange | 01:19 |
| *** saneax is now known as saneax-_-|AFK | 01:20 | |
| jlk | I'm probably down a crazy rabbit hole | 01:20 |
| jlk | hrm nope I just cleaned my tox, and tried it again | 01:21 |
| jeblair | jlk: you're in an activated env (like .tox/py27)? | 01:21 |
| jlk | yeah, and I just did .tox/py27/bin/python -m testtools.run tests.test_scheduler.TestScheduler.test_jobs_launched to try again | 01:21 |
| jlk | I'm on 96cb8afd4522c10e54858f3e3ba60727a5cbb96b | 01:22 |
| jeblair | jlk: oh, on zuulv3 we moved the tests down a level to tests.unit | 01:22 |
| jlk | oh hahaha docs fail :) | 01:22 |
| jeblair | jlk: so maybe some .pyc files the level up or something? | 01:22 |
| jeblair | (because that should have failed with an import error) | 01:23 |
| jlk | .tox/py27/bin/python -m testtools.run tests.unit.test_scheduler.TestScheduler.test_jobs_launched worked | 01:23 |
| jeblair | and yes, also docs fail | 01:23 |
| jlk | fixing docs | 01:23 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Update testing doc to reflect unit subdir move https://review.openstack.org/440891 | 01:24 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove job trees from pipelines https://review.openstack.org/435944 | 01:25 |
| *** jamielennox is now known as jamielennox|away | 01:29 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused mergeChangeQueue method https://review.openstack.org/435950 | 01:30 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Use hostname in Nodepool requests https://review.openstack.org/435949 | 01:30 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Clarify Job/Build/BuildSet docstrings https://review.openstack.org/435948 | 01:30 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add note about pipelines and dynamic layouts https://review.openstack.org/435947 | 01:30 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove inscrutable TODO https://review.openstack.org/435946 | 01:30 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle merge mode in repeated project configs https://review.openstack.org/435945 | 01:30 |
| *** jamielennox|away is now known as jamielennox | 01:36 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Re-enable test_idle https://review.openstack.org/430568 | 01:38 |
| jlk | alright, progress. I know it's broken now | 01:56 |
| *** bhavik1 has joined #zuul | 05:18 | |
| *** saneax-_-|AFK is now known as saneax | 05:51 | |
| *** bhavik1 has quit IRC | 05:54 | |
| *** bhavik1 has joined #zuul | 06:02 | |
| *** bhavik1 has quit IRC | 06:50 | |
| *** Cibo has quit IRC | 07:14 | |
| *** hashar has joined #zuul | 07:15 | |
| *** Cibo has joined #zuul | 07:19 | |
| *** Cibo has quit IRC | 08:22 | |
| *** hashar has quit IRC | 10:03 | |
| *** Cibo has joined #zuul | 11:23 | |
| *** hashar has joined #zuul | 12:48 | |
| *** pabelanger has quit IRC | 12:55 | |
| *** pabelanger has joined #zuul | 12:57 | |
| *** hashar has quit IRC | 14:31 | |
| *** Cibo has quit IRC | 15:27 | |
| *** Cibo has joined #zuul | 15:41 | |
| *** hashar has joined #zuul | 15:46 | |
| *** saneax is now known as saneax-_-|AFK | 15:57 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool feature/zuulv3: Use devstack's zookeeper support https://review.openstack.org/441209 | 16:21 |
| Shrews | mordred: oh, neato ^^^ | 16:26 |
| mordred | Shrews: \o/ | 16:27 |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Invalidate flavor and image cache on 400 errors https://review.openstack.org/441215 | 16:30 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused mergeChangeQueue method https://review.openstack.org/435950 | 16:57 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Use hostname in Nodepool requests https://review.openstack.org/435949 | 16:57 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:05 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Re-enable test_timer https://review.openstack.org/430968 | 17:07 |
| *** Cibo has quit IRC | 17:12 | |
| jeblair | SpamapS: you signed up for https://storyboard.openstack.org/#!/story/2000781 right? | 17:13 |
| jeblair | (i just assigned that to you based on that recollection) | 17:13 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:14 |
| jeblair | SpamapS: i tagged https://storyboard.openstack.org/#!/story/2000893 lhf | 17:15 |
| jeblair | and https://storyboard.openstack.org/#!/story/2000771 | 17:15 |
| jeblair | and https://storyboard.openstack.org/#!/story/2000782 | 17:16 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:16 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove job trees from pipelines https://review.openstack.org/435944 | 17:18 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:21 |
| jeblair | SpamapS: i created https://storyboard.openstack.org/#!/story/2000894 | 17:24 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:26 |
| jeblair | i also created https://storyboard.openstack.org/#!/story/2000895 | 17:26 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:31 |
| jeblair | should probably complete this exercise as homework before we add the container stuff to the launcher: https://raw.githubusercontent.com/fedoradesign/coloringbook-containers/master/Print-Ready/Web.pdf | 17:34 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:34 |
| pabelanger | jeblair: I'm totally giving that to my kids to color today | 17:35 |
| Shrews | pabelanger: why should kids have all the fun? just do it yourself :) | 17:37 |
| jeblair | pabelanger: your kids may ask for a rhel subscription by the end... | 17:38 |
| pabelanger | :) | 17:38 |
| jeblair | (they should put a coupon for a free rhel subscription and x-ray specs on the back cover) | 17:39 |
| *** rbergero1 has joined #zuul | 17:40 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:40 |
| *** jhesketh_ has joined #zuul | 17:41 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused mergeChangeQueue method https://review.openstack.org/435950 | 17:41 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Use hostname in Nodepool requests https://review.openstack.org/435949 | 17:41 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Clarify Job/Build/BuildSet docstrings https://review.openstack.org/435948 | 17:41 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add note about pipelines and dynamic layouts https://review.openstack.org/435947 | 17:41 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove inscrutable TODO https://review.openstack.org/435946 | 17:41 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle merge mode in repeated project configs https://review.openstack.org/435945 | 17:41 |
| *** adam_g_ has joined #zuul | 17:42 | |
| *** mgagne_ has joined #zuul | 17:42 | |
| *** greghayn1 has joined #zuul | 17:42 | |
| *** mgagne has quit IRC | 17:43 | |
| *** rbergeron has quit IRC | 17:43 | |
| *** saneax-_-|AFK has quit IRC | 17:43 | |
| *** jhesketh has quit IRC | 17:43 | |
| *** adam_g has quit IRC | 17:43 | |
| *** greghaynes has quit IRC | 17:43 | |
| *** adam_g_ is now known as adam_g | 17:43 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:44 |
| *** saneax-_-|AFK has joined #zuul | 17:47 | |
| *** hashar has quit IRC | 17:50 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 17:56 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 18:00 |
| pabelanger | Okay, let see if that is green | 18:01 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Update testing doc to reflect unit subdir move https://review.openstack.org/440891 | 18:09 |
| pabelanger | jeblair: Shrews: mordred: jlk: 438281 is ready for some ansible reviewers! Adds generic tox jobs | 18:09 |
| jlk | cool, tab opened | 18:09 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Correct the quota/availability algorithm https://review.openstack.org/440780 | 18:14 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Only use ready nodes from the same provider. https://review.openstack.org/441270 | 18:16 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Only use ready nodes from the same provider. https://review.openstack.org/441270 | 18:18 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Correct the quota/availability algorithm https://review.openstack.org/440780 | 18:18 |
| Shrews | jeblair: the git diff is a bit weird in 440780 since it's actually less code change than it's calculating | 18:20 |
| Shrews | oh, i should move that note docstring | 18:22 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Only use ready nodes from the same provider. https://review.openstack.org/441270 | 18:25 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Correct the quota/availability algorithm https://review.openstack.org/440780 | 18:25 |
| Shrews | pabelanger: how come the pep8 logs aren't accessible for 438281 ? | 18:32 |
| pabelanger | Shrews: checking | 18:32 |
| pabelanger | Shrews: Oh | 18:32 |
| Shrews | still using 'server' | 18:32 |
| pabelanger | that is just a noop job | 18:33 |
| pabelanger | in project-config | 18:33 |
| pabelanger | so, nothing actually happens on that | 18:33 |
| Shrews | oh. i haven't been able to catch up enough yet | 18:33 |
| Shrews | pabelanger: so, how come these new tox jobs aren't part of project-config? they seem generic enough to use everywhere | 18:35 |
| pabelanger | Shrews: right now, project-config is a trusted repo. So, we couldn't do inrepo testing, like we can with zuul today | 18:36 |
| pabelanger | so, we are using openstack-infra/zuul to iterate faster vs merging code, then testing | 18:36 |
| Shrews | ah, makes sense | 18:36 |
| jeblair | [that pep8 job is sort of a placeholder since the first addition of a project to a pipeline can't happen dynamically (since the project isn't attached to the pipeline; it's a bit of a catch-22), and we wanted to do all of this dynamically so we can try it out faster] | 18:36 |
| jeblair | pabelanger: we've actually landed some jobs in the zuul repo, right? | 18:37 |
| pabelanger | jeblair: yes! | 18:37 |
| pabelanger | python-linters | 18:37 |
| jeblair | pabelanger: i think that's enough for us to remove the jobs from project-config then | 18:37 |
| pabelanger | WFM | 18:37 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Switch to yaml.safe_load https://review.openstack.org/441285 | 18:38 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Report YAML parse errors https://review.openstack.org/441286 | 18:38 |
| jeblair | clarkb: ^ moar error reporting | 18:38 |
| jeblair | parse errors come with line and column numbers! :) | 18:38 |
| Shrews | I'm hoping that once I tackle a couple of more nodepool things that I can pay more attention to zuul | 18:39 |
| jeblair | Shrews: w00t! | 18:39 |
| pabelanger | \o/ | 18:40 |
| *** rbergero1 is now known as rbergeron | 18:48 | |
| *** rbergeron has quit IRC | 18:48 | |
| *** rbergeron has joined #zuul | 18:48 | |
| jeblair | okay, it's time for some folks to review some zuul changes. Please look at 435944 435945 435946 435947 435948 435949 436950 439887 440760 440789 441285 441286. All of them are ready and passing tests; many have been hanging out for a few days. | 18:49 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Create run-cover role https://review.openstack.org/441332 | 18:50 |
| pabelanger | ack | 18:50 |
| jeblair | i'm noticing an increase in spurious test failures because of our git.repo GC check. | 18:52 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Create run-cover role https://review.openstack.org/441332 | 19:07 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add run-docs role and tox-docs job https://review.openstack.org/441345 | 19:07 |
| pabelanger | jeblair: it would be cool if we could get mordred finger patch going too. I am not sure what needs to be done for that right now | 19:10 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add extra debugging around git.repo gc leaks https://review.openstack.org/441347 | 19:10 |
| jeblair | I'm going to restack a whole bunch of stuff on top of that in the hopes that we get data | 19:11 |
| jeblair | sorry about this | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Report YAML parse errors https://review.openstack.org/441286 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused mergeChangeQueue method https://review.openstack.org/435950 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Use hostname in Nodepool requests https://review.openstack.org/435949 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Clarify Job/Build/BuildSet docstrings https://review.openstack.org/435948 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Switch to yaml.safe_load https://review.openstack.org/441285 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add note about pipelines and dynamic layouts https://review.openstack.org/435947 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove inscrutable TODO https://review.openstack.org/435946 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle merge mode in repeated project configs https://review.openstack.org/435945 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Catch gear.InterruptedError https://review.openstack.org/440789 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove job trees from pipelines https://review.openstack.org/435944 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Re-enable test_timer_smtp https://review.openstack.org/430983 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Report dynamic layout config errors https://review.openstack.org/439887 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Re-enable test_dependent_behind_dequeue https://review.openstack.org/437076 | 19:13 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Report layout config errors for config repos https://review.openstack.org/440760 | 19:13 |
| *** Cibo has joined #zuul | 19:17 | |
| pabelanger | jeblair: I think I'm ready to look into plumbing the workspace job variable, want to confirm that we're thinking it would be added to the zuul_params in vars.yaml file? EG: environment: zuul.workspace | 19:17 |
| jeblair | pabelanger: i think we were thinkning that it didn't need to go into zuul code at all. but instead we could make it a variable on the base job and have the git repo role use it | 19:18 |
| pabelanger | right, that works too and how I was initially going to test it | 19:18 |
| pabelanger | I'll do that now | 19:19 |
| *** greghayn1 is now known as greghaynes | 19:33 | |
| *** Cibo has quit IRC | 19:42 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Rename prepare-workspace role to bootstrap https://review.openstack.org/441440 | 19:50 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Create zuul_workspace_root job variable https://review.openstack.org/441441 | 19:50 |
| jeblair | great. no gc errors. :/ | 19:53 |
| jeblair | clarkb, pabelanger: can you review https://review.openstack.org/441347 please? it's not too difficult, but it's now at the bottom of a stack. | 19:54 |
| pabelanger | +2 | 19:55 |
| clarkb | looking | 20:03 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Create zuul_workspace_root job variable https://review.openstack.org/441441 | 20:06 |
| clarkb | jeblair: it took me half a minute t orealize it was python gc not git gc for some reason | 20:06 |
| jeblair | clarkb: hehe, understandable :) | 20:09 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Add extra debugging around git.repo gc leaks https://review.openstack.org/441347 | 20:16 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Re-enable test_timer_smtp https://review.openstack.org/430983 | 20:16 |
| *** hashar has joined #zuul | 20:32 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Re-enable test_dependent_behind_dequeue https://review.openstack.org/437076 | 20:44 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Report dynamic layout config errors https://review.openstack.org/439887 | 20:45 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 20:46 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Group nodes by availability zone https://review.openstack.org/441470 | 20:51 |
| Shrews | jeblair: w00t ^^^ | 20:52 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 20:52 |
| jeblair | Shrews: sweet! | 20:53 |
| jeblair | clarkb: https://review.openstack.org/440760 https://review.openstack.org/441285 and https://review.openstack.org/441286 are all up your alley | 20:53 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 20:53 |
| Shrews | pabelanger: have you by any chance done anything with adding back the nodepool stats? If not, I'm going to start on that now. | 20:53 |
| pabelanger | Shrews: I have not, and it would be awesome if you could | 20:53 |
| Shrews | k | 20:54 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 20:55 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 20:58 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 21:00 |
| jeblair | Shrews: that whole stack looks great :) | 21:00 |
| Shrews | \o/ | 21:00 |
| Shrews | jeblair: adding back stats is the last piece, i believe, for feature completeness. | 21:03 |
| jeblair | Shrews: do we have leaked-node-cleanup yet? | 21:03 |
| Shrews | doh! | 21:03 |
| Shrews | nope | 21:03 |
| * Shrews wonders how that escaped his TODO list | 21:03 | |
| jeblair | it leaked | 21:04 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 21:04 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 21:05 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 21:07 |
| jeblair | Shrews: maybe we see if we can get clarkb or mordred to review your stack too? | 21:09 |
| Shrews | jeblair: that would be awesome if we could get clarkb or mordred to review the stack | 21:09 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 21:09 |
| Shrews | jeblair: how could we possibly get clarkb or mordred to review the stack? | 21:09 |
| Shrews | maybe if we said 'clarkb' or 'mordred' enough.... | 21:10 |
| jeblair | Shrews: i don't know. maybe someone should ask clarkb or mordred to review the stack? | 21:10 |
| jeblair | Shrews: i'll ask clarkb if you want to ask mordred. | 21:10 |
| jeblair | Shrews: unless you want to ask mordred and i'll ask clarkb. | 21:10 |
| * Shrews waits for the throwing of wet, angry cats | 21:10 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add revoke-sudo role and update tox jobs https://review.openstack.org/441467 | 21:11 |
| pabelanger | okay, that should be green now too | 21:11 |
| jeblair | pabelanger: from the pike ptg etherpad: https://etherpad.openstack.org/p/pike-ptg-zuul | 21:12 |
| jeblair | pabelanger: do we still have to do the zuul-server -> zuul-scheduler init script? | 21:12 |
| pabelanger | jeblair: I think clarkb did that already. Let me confirm | 21:14 |
| pabelanger | jeblair: ya, I see it in puppet-zuul now | 21:14 |
| jeblair | cool | 21:14 |
| jeblair | pabelanger: do you know what "remove /home/nodepool/.ssh/id_rsa.pub" means? | 21:15 |
| pabelanger | jeblair: that is on nl01.o.o, no longer needed since we are removing ready-script support in nodepool | 21:15 |
| pabelanger | I still have to do that | 21:15 |
| jeblair | pabelanger: i will file a story and assign to you | 21:16 |
| pabelanger | sure | 21:16 |
| jeblair | pabelanger: and now i understand thanks to your explanation :) | 21:16 |
| jeblair | okay, actually i'm not going to create a new story because i can't click the 'save changes' button on storyboard | 21:18 |
| pabelanger | https://review.openstack.org/#/q/topic:zuulv3-ansible | 21:21 |
| pabelanger | a good stack of ansible playbooks / roles that is working | 21:21 |
| pabelanger | basically gives almost the same layout as JJB today | 21:21 |
| pabelanger | also gives us the same test we run on zuulv3 and zuulv2.5 for feature/zuulv3 branch | 21:22 |
| jeblair | pabelanger: https://storyboard.openstack.org/#!/story/2000896 | 21:23 |
| pabelanger | jeblair: danke | 21:24 |
| jeblair | pabelanger, Shrews: https://storyboard.openstack.org/#!/story/2000897 is another thing we talked about at ptg | 21:26 |
| pabelanger | ++ | 21:26 |
| jeblair | i'm going to tag that LHF | 21:27 |
| Shrews | jeblair: that's getting the keypair from nova, yeah? | 21:28 |
| *** jamielennox is now known as jamielennox|away | 21:29 | |
| pabelanger | don't think nova provides it (yet?), so we'd have to call ssh-keyscan our self | 21:30 |
| jeblair | right, last i heard nova didn't think they could do that (but we can continue to hope). so that's nodepool doing it | 21:32 |
| pabelanger | I like that nodepool does it, as it still provides our networking to the VM :) | 21:33 |
| jeblair | pabelanger: provides a test of that? yeah. also, nodepool launchers might be topologically closer to the vms. maybe. :) | 21:34 |
| pabelanger | yes, provides a test... | 21:35 |
| jeblair | pabelanger: "test_mutex" is on the etherpad -- any ideas what that means? | 21:35 |
| pabelanger | jeblair: sorry no | 21:35 |
| jeblair | maybe just that it failed or something | 21:35 |
| jeblair | which, i guess it will keep reminding us.... | 21:36 |
| openstackgerrit | Cullen Taylor proposed openstack-infra/zuul feature/zuulv3: Re-enable test_tags https://review.openstack.org/439858 | 21:52 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add ansible-lint to tox (pep8) https://review.openstack.org/438276 | 22:24 |
| SpamapS | jeblair: sorry for not being super responsive. On-site at a conference the last 2 days. | 22:32 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add a test for a broken config on startup https://review.openstack.org/441499 | 22:35 |
| jeblair | SpamapS: np. you will not be bored when you get back! :) | 22:36 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add ansible-lint to tox (pep8) https://review.openstack.org/438276 | 22:36 |
| jeblair | SpamapS: i have put many things into storyboard, and tagged several of them as LHF. I may be ratcheting up the lhf threshold a little bit, but that's sort of where we are in the process. | 22:38 |
| *** hashar has quit IRC | 23:01 | |
| pabelanger | https://github.com/willthames/ansible-lint/pull/248 | 23:05 |
| pabelanger | something we likely need is we want to run ansible-lint on our playbooks / roles. | 23:05 |
| pabelanger | because, ya: https://review.openstack.org/#/c/438276 :) | 23:06 |
| *** saneax-_-|AFK is now known as saneax | 23:09 | |
| pabelanger | also heard about ansible-review a few times from rbergeron, going to look into it this weekend | 23:11 |
| pabelanger | see what the differences are | 23:11 |
| jeblair | i addded text/plain mime type to .log so i could see what you meant :) | 23:23 |
| jeblair | "ANSIBLE0012 Commands should not change things if nothing needs doing" | 23:23 |
| pabelanger | ya | 23:23 |
| pabelanger | basically, we should be using args.creates for the shell scripts, but haven't done that yet | 23:24 |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add ansible-lint to tox (pep8) https://review.openstack.org/438276 | 23:36 |
| pabelanger | ansible-review is kinda need | 23:51 |
| pabelanger | I could see use using it in project-config, to import our formatting checks | 23:52 |
| pabelanger | impose* | 23:52 |
| pabelanger | and with that, EOD | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!