Friday, 2017-02-24

openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770000:25
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770000:31
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770000:40
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher!  https://review.openstack.org/43770000:49
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770000:53
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770000:56
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770000:59
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770001:02
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770001:09
pabelangerokay, that is it for tonight. Log collection from worker to zuul-launcher is working01:18
SpamapSsweet01:19
openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: Add support for 'repos' job configuration  https://review.openstack.org/43671201:28
openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: A couple small test improvements  https://review.openstack.org/43759201:59
mordredpabelanger: you are amazing02:11
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Change log streaming link to finger protocol  https://review.openstack.org/43776402:46
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: WIP Put real information in log streaming link  https://review.openstack.org/43776502:46
mordredjeblair: ^^ am I on the right track with change #2 there?02:46
mordredjlk: oh - piddle - also, I think I changed too many tests in the first change02:47
mordredgah02:47
mordredjeblair: ^^02:48
jeblairmordred: yes i think so02:55
mordredawesome02:55
jeblairmordred: can probably drop the trailing /002:56
mordredwhat is the trailing /0 ?02:56
jeblairmordred: also, i reckon we probably want finger://unique@server -- job isn't really necessary there02:57
mordredjeblair: ++02:57
jeblairmordred: 'finger://{unique}@{server}/job/{job}/0/'  --> 'finger://{unique}@{server}'02:58
mordred++02:59
mordredjeblair: how do I get the list of builds from a job?03:05
mordredor, rather - let me ask that differenting03:06
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Change log streaming link to finger protocol  https://review.openstack.org/43776403:08
mordredjeblair: I put in a HELP comment in that one - I'll keep poking around but if you hav ea quick/easy answer that would be neat03:08
jeblairmordred: status_jobs[X]['uuid'] should have it03:14
jeblairmordred: that's *barely* testing that, but it's something :)03:14
jeblairmordred: if we were to do something more robust, it would involve also comparing that to the internal data structure and is a bit more work... considering we didn't think it was worthwhile to do that in the rest of the test, checking it against the sibling json data is probably fine :)03:15
mordredjeblair: :) cool, thanks! (I was thinking about checking the internal data structure, but happy to keep it simple for the first pass)03:21
jeblairmordred: ya, if we wanted to do that, it's self.sched.abide[tenant].layout.pipelines...03:22
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Change log streaming link to finger protocol  https://review.openstack.org/43776403:24
*** saneax-_-|AFK is now known as saneax04:13
*** saneax is now known as saneax-_-|AFK04:25
*** hashar has joined #zuul08:45
*** Cibo_ has joined #zuul09:04
*** saneax-_-|AFK is now known as saneax09:07
*** Cibo_ has quit IRC09:09
*** pleia2 has quit IRC09:27
*** anteaya has quit IRC09:27
*** pleia2 has joined #zuul09:28
*** anteaya has joined #zuul09:30
*** Cibo_ has joined #zuul11:07
*** openstackgerrit has quit IRC12:18
rcarrillocruzclarkb: https://review.openstack.org/#/c/435933/ is slowly getting there12:19
rcarrillocruzi'll clean up a bit the task names and other stuff12:19
rcarrillocruzbut is now passing the overlay setup and running the full tempest12:19
rcarrillocruz(on dvr)12:19
rcarrillocruzi'll ping you again soon when i think i've ironed out a few cosmetic things, but let me know if you spot any functional issue12:20
clarkbok12:40
*** Cibo_ has quit IRC13:11
pabelangermorning13:17
pabelangerdown on level 1 ATM13:17
Shrewslooks like lots of good things happened yesterday13:25
*** openstackgerrit has joined #zuul13:39
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Create python-linters job  https://review.openstack.org/43705913:39
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Copy logs to launcher  https://review.openstack.org/43770013:39
jeblairShrews: yes, and more today i hope!13:50
jeblairpabelanger: sorry, i'm getting a late start; i'll try to join you in about an hour13:51
pabelangerjeblair: no rush13:51
*** saneax is now known as saneax-_-|AFK14:18
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Delete node request locks after a delay  https://review.openstack.org/43792214:34
Shrewsjeblair: pabelanger: I realized last night that we could hit the scenario detailed in the commit message of ^^^^14:35
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Delete node request locks after a delay  https://review.openstack.org/43792214:38
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Delete node request locks after a delay  https://review.openstack.org/43792214:39
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793815:03
*** jamielennox|away is now known as jamielennox15:07
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793815:07
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793815:25
jeblairShrews: remind me again why we need to cleanup request locks out of band?  i get that since a request can disappear and the lock isn't a child, it needs to be separately deleted; but if we locked the request, i know that we also check to make sure it's still around.  wouldn't we unlock it in the normal course of events?15:26
Shrewsjeblair: unlock != deleted15:27
jeblairShrews: should we delete the lock file at the time we unlock?15:27
Shrewsjeblair: the lock is a directory (non-ephemeral) with ephemeral children15:27
jeblairShrews: ah, that could be bad because it may race a new lock, yeah?15:27
Shrewsyep15:28
jeblairokay, i think i'm caught up.  thanks.  :)15:28
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Delete node request locks after a delay  https://review.openstack.org/43792215:32
Shrewsoh, pabelanger... you were asking about test openshift accounts. i learned there is this thing: https://github.com/minishift/minishift15:35
jeblairmordred: pabelanger suggests that we publish zuulv3 logs to an apache running on zuulv3-dev for a while so we don't put the static.o.o key on the system until we're more secure15:37
mordredjeblair: wfm15:37
jeblairmordred: clarkb has questions about bubblewrap; specifically, the permissions needed to run it.15:40
mordredjeblair: so - with the finger change - we seem to be reporting streaming link and final publication link the same15:41
jeblairmordred: yeah, we need to do something about the log path pattern15:41
clarkbright if its setuid and escalating via that binary isn't the exposure surface still quite large?15:41
mordredjeblair, clarkb: it should not require elevated permissions to run15:41
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793815:42
mordredclarkb: well - I think the idea is that it's a small setuid binary that is easily auditable15:42
*** Cibo_ has joined #zuul15:42
clarkbok I think where I am mostly confused is this is how docker operates too iirc. And docker lets you do all the things15:44
clarkbbut in this case the assertion is bubblewrap restricts those operations to some minimal set that is harder t oabuse and is small and audited to help avoid break outs?15:45
clarkbthe other thing I noticed is it uses tmpfs which will restrict the number of concurrent launchers being run within bubblewrap (based on available memory and size of job storage)15:46
*** Cibo_ has quit IRC15:47
mordredclarkb: so we may want to make a director for the workdir and have it mount that in15:47
mordredbut yeah - restricting the operations is key - and also it's trying to make use of user_capabilities as the kernel picks them up15:47
mordredso over time it should trend towards using the non-privileged containment features of the kernel15:48
mordredclarkb: there's a guy on my team at RH who has worked on it some I could ping if we want to go deeper with questions - and also tristanC landed a patch to it recently, so he may also know things15:49
clarkbya jeblair asked if tristanC was here (is not unfortunately)15:49
*** Cibo_ has joined #zuul15:49
clarkbmordred: I think it would be good to properly understand what the risk is there before we assert it fixes some of the problems we face15:49
mordredjeblair: so for now should we just update the tests of the success url to use the same status url and then deal with success url later?15:51
mordredclarkb: agree15:51
mordredclarkb: I pinged vbatts and will try to grab him so we can ask some deeper questions15:53
*** yolanda has quit IRC15:53
rbergeronrandom squirrel thought: (maybe not since you guys seem to be talking about kubernetes things?) -- i saw this thing yesterday https://github.com/coreos/zetcd15:57
rbergeron"A ZooKeeper "personality" for etcd. Point a ZooKeeper client at zetcd to dispatch the operations on an etcd cluster.15:58
rbergeron"15:58
mordredrbergeron: wow. that seems like a TERRIBLE idea15:59
rbergeronnot sure if that might help with kubernetes cluster things (as in, hook zookeeper to etcd so we don't have to have multiple things?) but um, who knows?15:59
rbergeronor it could be a terrible idea?15:59
rbergeron:)15:59
rbergeroni just bring things to y'all, sometimes it's terrible, that happens :)15:59
mordredrbergeron: well, the reason we chose zookeeper instead of etcd is that zookeeper can support fair locking and etcd can't do so fully safely, so emulating zookeeper with an etcd backend would work for many things, but then the semantics of operation of some of the things would fail in dangerous ways16:00
mordredAIUI16:00
clarkbya there are lock queuing and thundering herd issues16:00
mordredclarkb: chatted briefly with vbatts, he suggested we grab alexlarsson on Monday (he's in Sweden so timezones)16:02
mordredalso apparently it will function without the setuid, but may not be able to do all the things16:02
clarkbinteresting16:02
mordredI think it uses the setuid power to do the things that haven't grown user-capability support yet16:03
clarkbya so feature set likely dependent on kernel version16:03
mordredyah16:03
clarkbmordred: you know apt and dib things can you review https://www.openstack.org/software/ocata/ ?16:05
clarkbdangit16:05
clarkbhttps://review.openstack.org/#/c/437425/116:05
clarkbis the actual url16:05
mordredclarkb: I don't know what /var/lib/apt/list is16:06
clarkbmordred: its the indexes from repos16:06
mordredmordred@camelot:~/src/github.com/ansible/ansible$ ls /var/lib/apt/list16:06
mordredls: cannot access '/var/lib/apt/list': No such file or directory16:06
mordrednot on my computer it isn't16:06
clarkbneat16:07
mordred:)16:07
clarkbdo you have a /var/lib/apt?16:07
mordredyes. AH - it's lists16:07
mordredand yes, there they are16:07
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Change log streaming link to finger protocol  https://review.openstack.org/43776416:10
jeblairmordred: jhesketh is going to work on the reporting url16:18
mordredjeblair: \o/16:25
jeblairmordred: https://review.openstack.org/43770716:30
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add --safe-links to synchronize invocations  https://review.openstack.org/43756816:33
*** bhavik1 has joined #zuul16:35
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add support for 'repos' job configuration  https://review.openstack.org/43671216:36
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Fix synchronize action issue with mode  https://review.openstack.org/43770716:38
*** abregman has joined #zuul16:51
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Change log streaming link to finger protocol  https://review.openstack.org/43776416:55
mordredjeblair: ok. it's going to pass tests this time16:55
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add more variables to ansible  https://review.openstack.org/43799917:02
* jeblair lunches17:03
*** abregman is now known as abregman|afk17:05
*** bhavik1 has quit IRC17:06
mordredwhen folks get back, they may or may not enjoy these: https://review.openstack.org/#/c/436455/ and https://review.openstack.org/#/c/436452/17:33
*** yolanda has joined #zuul17:40
*** Cibo_ has quit IRC17:47
*** hashar has quit IRC17:48
*** yolanda has quit IRC17:52
*** yolanda has joined #zuul17:54
jeblairmordred: how might we go about having a playbook provide structured data back to the launcher (eg, the logfile copy playbook returns a url back to the launcher)?18:07
jeblairmordred: also, jenkinsectomy++ :)18:07
jeblairmordred: i think i might suggest we hold off on the infra-manual change for a bit longer though since currently "Jenkins" does report, and it may be confusing to new users.18:09
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: WIP testing log urls  https://review.openstack.org/43802818:10
jheskethjeblair: https://review.openstack.org/#/c/438028/118:12
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: WIP testing log urls  https://review.openstack.org/43802818:23
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793818:26
pabelangerjhesketh: jeblair: can we land 437707 please18:29
jeblairmordred: wow.  what is going on in the unit test output of 437764?18:29
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path!  https://review.openstack.org/43793818:33
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix synchronize action issue with mode  https://review.openstack.org/43770718:36
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: WIP testing log urls  https://review.openstack.org/43802818:38
SpamapSjeblair: timed out by zuul?18:41
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fix keyerror with synchronize  https://review.openstack.org/43804318:41
jeblairSpamapS: ^ probably18:41
SpamapSoh, yeah that makes sense18:42
mordredjeblair: that's impressive18:45
*** yolanda has quit IRC18:47
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793818:47
mordredjeblair: as for the other thing, there 2 options I can think of are a) we ignore stdout from our callback plugin anyway - have it write json to stdout that we can then consume b) have the logfile copy playbook write a file with info into a known location that zuul can read from18:49
mordredjeblair: neither are _great_ options though - let me noodle on it for a bit ...18:49
* mordred afks for an errand18:49
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path!  https://review.openstack.org/43793818:49
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path  https://review.openstack.org/43793818:54
pabelanger2017-02-24 18:55:05,170 DEBUG zuul.AnsibleJob: Ansible output:  [WARNING]: Failure using method (v2_playbook_on_task_start) in callback plugin18:55
pabelangermordred: ^18:55
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path.  https://review.openstack.org/43793818:58
SpamapSmordred: fyi, bsd finger reads and writes one character at a time, until the finger server closes the socket18:59
SpamapS    while ((c = getc(fp)) != EOF) {19:00
SpamapSmordred: so we probably don't need a rust one that does that more efficiently ;)19:00
openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: A couple small test improvements  https://review.openstack.org/43759219:01
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: WIP testing log urls  https://review.openstack.org/43802819:02
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path.  https://review.openstack.org/43793819:03
*** abregman|afk has quit IRC19:05
*** yolanda has joined #zuul19:06
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path.  https://review.openstack.org/43793819:07
*** yolanda has quit IRC19:12
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path.  https://review.openstack.org/43793819:12
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path.  https://review.openstack.org/43793819:15
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Test rsync_path.  https://review.openstack.org/43793819:20
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: Simplify the log url  https://review.openstack.org/43802819:33
pabelangerhttp://zuulv3-dev.openstack.org/logs/19:33
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: Simplify the log url  https://review.openstack.org/43802819:34
openstackgerritJoshua Hesketh proposed openstack-infra/zuul feature/zuulv3: Simplify the log url  https://review.openstack.org/43802819:38
*** herlo has joined #zuul19:52
*** herlo has joined #zuul19:52
*** herlo has left #zuul19:52
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix keyerror with synchronize  https://review.openstack.org/43804319:55
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add more variables to ansible  https://review.openstack.org/43799919:56
*** jamielennox is now known as jamielennox|away19:57
* jeblair is at airpoirt20:19
jesusaurpabelanger: cool!20:23
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix getInfoRefs call from getProjectBranches  https://review.openstack.org/43680120:30
*** eventingmonkey has joined #zuul20:57
dmsimardpabelanger: nice, I gotta feed ara in there now :p22:44
openstackgerritK Jonathan Harker proposed openstack-infra/zuul master: Optionally require a zuul-ref when cloning  https://review.openstack.org/22795523:12

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!