Wednesday, 2017-02-22

*** rcarrillocruz has quit IRC00:50
*** rcarrillocruz has joined #zuul00:52
*** openstackgerrit has quit IRC01:23
*** openstackgerrit has joined #zuul01:34
openstackgerritK Jonathan Harker proposed openstack-infra/zuul feature/zuulv3: Add support for 'repos' job configuration  https://review.openstack.org/43671201:34
jesusaurand now with tests :)01:34
*** saneax is now known as saneax-_-|AFK01:35
*** isaacb has joined #zuul05:09
*** isaacb has quit IRC05:19
*** saneax-_-|AFK is now known as saneax05:48
*** bhavik1 has joined #zuul06:20
*** bhavik1 has quit IRC06:23
*** isaacb has joined #zuul07:11
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Fix getInfoRefs call from getProjectBranches  https://review.openstack.org/43680107:35
openstackgerritTobias Henkel proposed openstack-infra/zuul feature/zuulv3: Use ssh for git-upload-pack  https://review.openstack.org/43680207:35
*** hashar has joined #zuul08:07
*** abregman_ has joined #zuul08:24
*** abregman_ is now known as abregman08:47
*** rzetikx has quit IRC08:54
*** isaacb has quit IRC11:20
*** hashar has quit IRC12:05
*** hashar has joined #zuul13:27
*** yolanda has quit IRC13:29
*** jamielennox|away is now known as jamielennox14:16
SpamapSjeblair: 'morning. I'm here today mostly so I can hack with zuul people. Let me know if/where we can create an impromptu Zuul hacking space today. :)14:19
*** yolanda has joined #zuul14:26
pabelangero/14:30
pabelangerchecking zuulv3 topic for open reviews14:31
pabelangercurrently on level 114:31
jeblairSpamapS, pabelanger: clarkb and i found a space in salon c level 314:37
SpamapSjeblair: lovely. I'll be down in a few.14:38
pabelangersure, heading up14:38
jeblairjesusaur: neat!14:41
jeblairjesusaur: that change looks good; i think we still need to do the zuul-cloner style branch selection at some point (if the change under test is stable/foo, try to checkout stable/foo of all the "repos", but fall back to master if it doesn't exist)14:48
jeblairjesusaur: oh, i think i see something related to that which we should change in your patch... i'll leave a comment14:53
mordredjeblair: lib/ansible/plugins/__init__.py15:05
rbergeronhttps://github.com/willthames/ansible-review/blob/master/README.md15:18
rbergeronhttp://ndemengel.github.io/2015/01/20/ansible-modules-and-action-plugins/15:31
*** saneax is now known as saneax-_-|AFK15:43
openstackgerritDavid Moreau Simard proposed openstack-infra/nodepool master: Clarification about the rate parameter  https://review.openstack.org/43699315:45
openstackgerritDavid Moreau Simard proposed openstack-infra/nodepool master: Clarification about the rate parameter  https://review.openstack.org/43699315:46
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add hello_world test job  https://review.openstack.org/43654415:51
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add hello_world test job  https://review.openstack.org/43654415:54
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Add hello_world test job  https://review.openstack.org/43654415:56
*** bhavik1 has joined #zuul16:09
dmsimardthat looks super amazing ^16:09
bhavik1here, I was looking for mail notification on failure, I couldn't find way to setup "TO" mail list per repo? any help how to setupt that ?16:11
clarkbbhavik1: I think reporters are per pipeline and so you can't do a different one per repo unless you have a pipeline per repo?16:12
bhavik1clarkb: pipeline per repo doesn't seem right way (just for mail), I'll skip mail thing in that case16:17
dmsimardbhavik1: just an idea -- a publisher on jobs that knows who to notice ?16:18
dmsimardrather than at the pipeline level16:18
bhavik1dmsimard: not jobs, but project do .. mistakenly I use "repo" instead of mentioning "project" name16:21
*** isaacb has joined #zuul16:23
mordredclarkb: https://github.com/emonty/ansible/tree/fix-recursive-super16:49
*** hashar has quit IRC16:52
*** abregman has quit IRC16:59
*** jamielennox is now known as jamielennox|away17:03
*** yolanda has quit IRC17:10
*** isaacb has quit IRC17:16
*** bhavik1 has quit IRC17:49
jesusaurhow's the ptg going?18:17
pabelangerGood, we have jobs running on zuulv3-dev.o.o: https://review.openstack.org/#/c/436544/18:22
pabelangerbut still working on a few hiccups18:22
pabelangermore with Ansible then zuul18:22
jesusaurcool18:25
SotKthat looks exciting :D18:26
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705918:43
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705918:45
*** isaacb has joined #zuul18:48
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fix infinite recursion on action module import  https://review.openstack.org/43706618:51
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Import ansible synchronize correctly  https://review.openstack.org/43706718:56
jeblairjesusaur: ohai!  thanks for the patch, i left some comments :)18:57
*** jamielennox|away is now known as jamielennox18:57
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705919:02
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Revert "Run everything in secure mode while debugging"  https://review.openstack.org/43707219:02
jesusaurjeblair: ya, thanks for the comments. I'm looking through ZuulTestCase to see how to check the jobdir; it looks like self.test_root might be what I want19:08
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Re-enable test_dependent_behind_dequeue  https://review.openstack.org/43707619:12
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Add host ssh keys to known hosts  https://review.openstack.org/43663419:12
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fix infinite recursion on action module import  https://review.openstack.org/43706619:17
jeblairjesusaur: it'll be something deep under there that is per-job.  you may need to hold a job while it's running and then maybe see if you can get the ansiblejob from the launcher to find the jobdir for that job... or maybe add a playbook that inspects the git directory in the jobdir (like the playbooks that set the 'flag' files in test_v3)19:20
jesusaurjeblair: ah, ok. I was just noticing that the test I was looking at (TestMergerRepo) is actually doing the cloning itself with a git.Repo object19:23
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705919:23
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Fix infinite recursion on action module import  https://review.openstack.org/43706619:32
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Import ansible synchronize correctly  https://review.openstack.org/43706719:34
jlkhuh, I can't load gerrit19:35
jlkoh it finally went.19:36
clarkbjlk: you are at ptg ya?19:36
jlkno :(19:37
clarkbok we thought maybe local net issues but jeblair says high load on gerrit now19:37
jlknod19:37
jlkjeblair: 437067  patch set 2 uses a new function, did that new function get added in a different review?19:38
*** jamielennox is now known as jamielennox|away19:38
jeblairjlk: yes, its parent is 43706619:39
jlkn/m I see it19:39
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Fix all action plugins to import safely  https://review.openstack.org/43709719:43
jeblairclarkb, jlk:  ^19:46
jeblairi've blocked my synchronize change since SpamapS included it in his19:46
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Fix all action plugins to import safely  https://review.openstack.org/43709719:47
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix infinite recursion on action module import  https://review.openstack.org/43706619:48
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Revert "Run everything in secure mode while debugging"  https://review.openstack.org/43707219:48
*** jamielennox|away is now known as jamielennox19:48
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul feature/zuulv3: Fix all action plugins to import safely  https://review.openstack.org/43709719:49
*** nibz is now known as nibalizer19:52
*** abregman has joined #zuul19:57
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705919:58
*** abregman has quit IRC20:01
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Fix all action plugins to import safely  https://review.openstack.org/43709720:01
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:06
*** hashar has joined #zuul20:07
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:07
*** isaacb has quit IRC20:08
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:08
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:10
*** abregman has joined #zuul20:11
*** abregman has quit IRC20:11
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:12
*** yolanda has joined #zuul20:13
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:18
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:19
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Expose the jobdir git root as a variable  https://review.openstack.org/43711820:20
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:22
openstackgerritJames E. Blair proposed openstack-infra/zuul feature/zuulv3: Expose the jobdir git root as a variable  https://review.openstack.org/43711820:30
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:32
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:34
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705920:36
*** jamielennox is now known as jamielennox|away20:39
*** jamielennox|away is now known as jamielennox20:44
openstackgerritMerged openstack-infra/zuul feature/zuulv3: Expose the jobdir git root as a variable  https://review.openstack.org/43711820:49
jesusaurjeblair: I think I've become confused about the various copies of the git repos again. What's the purpose of the launcher git_root?21:05
jesusauris that primarily for compiling the .zuul.yaml files?21:06
jesusaurjeblair: in your review comment you say that each job gets a new copy of their repos in a temporary jobdir, but I'm not seeing that happen in any tests21:09
jeblairjesusaur: the launcher has a directory where it keeps copies of all the repos it sees21:22
jeblairjesusaur: that's LaunchServer.merge_root21:22
jeblairjesusaur: and yeah, the internal merger that it has uses that to collect .zuul.yaml files21:23
jeblairjesusaur: then, there's an AnsibleJob for every job it runs21:23
jeblairjesusaur: AnisibleJob.jobdir is a temporary directory that exists only as long as the job is running21:24
jeblairjesusaur: AnsibleJob.jobdir.git_root is a subdirectory of that where we check out the changes being tested21:24
jeblairjesusaur: that's the thing we want to check on here21:24
jesusaurjeblair: ah, ok, thanks21:35
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705921:41
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705921:44
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705921:49
*** jamielennox is now known as jamielennox|away21:52
openstackgerritPaul Belanger proposed openstack-infra/zuul feature/zuulv3: Add pre-run playbook to copy git repos to worker  https://review.openstack.org/43705921:55
openstackgerritJames E. Blair proposed openstack-infra/nodepool feature/zuulv3: Add some lock debug lines and an exception handler  https://review.openstack.org/43717922:36
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Support launch failures in FakeProviderManager  https://review.openstack.org/43657422:39
*** hashar has quit IRC22:42
openstackgerritMerged openstack-infra/nodepool feature/zuulv3: Send min-ready requests only when images are ready  https://review.openstack.org/43603822:43
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Remove color from callback logs  https://review.openstack.org/43603922:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Change 'secure' to 'trusted'  https://review.openstack.org/43596922:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Consume display_args_to_stdout in zuul_stream  https://review.openstack.org/43596222:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add initial callback plugin to handle log streaming  https://review.openstack.org/43596122:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add daemon subprocess to read remote log content  https://review.openstack.org/43604022:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Add placeholder for doing the actual streaming  https://review.openstack.org/43601422:53
openstackgerritMonty Taylor proposed openstack-infra/zuul feature/zuulv3: Reorganize the job dir to include a work dir  https://review.openstack.org/43718222:53
Shrewsclarkb: fyi, i -1'd 437179 after your +3. If it gets merged, a followup is fine.22:53
clarkbI can remoce approval22:54
*** saneax-_-|AFK is now known as saneax23:18
SpamapSmordred: I was just looking at the way the normal plugin works and I think it can be got around if any non-127 IP of the server is known by doing set_fact: hostvars['target']['ansible_ssh_hostname']=1.2.3.423:42
SpamapShm no23:42
SpamapSit will still not be able to ssh23:42
SpamapSthough we should be careful to block SSH from ourselves just in case.23:43
SpamapS(or maybe we can somehow freeze the variables that feed into the ssh connection plugin23:43
SpamapSjeblair, mordred: FYI, I added this story so we don't forget to test the ansible plugins. :) https://storyboard.openstack.org/#!/story/200087823:47

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!