Wednesday, 2017-01-11

*** jamielennox is now known as jamielennox|away00:07
*** harlowja has quit IRC00:09
*** jamielennox|away is now known as jamielennox00:11
*** jasondotstar has quit IRC00:11
*** zaro has quit IRC00:12
*** zaro has joined #zuul00:12
*** _ari_ has quit IRC00:12
*** _ari_ has joined #zuul00:17
*** jasondotstar has joined #zuul00:18
*** harlowja has joined #zuul00:25
*** saneax is now known as saneax-_-|AFK01:48
*** Shuo has quit IRC02:44
*** Cibo has quit IRC05:15
*** Cibo has joined #zuul05:28
*** bhavik1 has joined #zuul05:54
*** bhavik1 has quit IRC06:03
*** saneax-_-|AFK is now known as saneax06:45
*** hogepodge has quit IRC07:56
*** Cibo_ has joined #zuul08:16
*** bhavik1 has joined #zuul09:06
*** bhavik1 has quit IRC09:23
*** hashar has joined #zuul10:26
openstackgerritMerged openstack-infra/zuul: Add Zookeeper to tests  https://review.openstack.org/41324111:55
*** saneax is now known as saneax-_-|AFK12:45
*** jamielennox is now known as jamielennox|away14:14
*** saneax-_-|AFK is now known as saneax14:27
*** Shuo has joined #zuul16:39
*** dmsimard is now known as dmsimard|afk17:08
openstackgerritJames E. Blair proposed openstack-infra/nodepool: Merge branch 'master' into feature/zuulv3  https://review.openstack.org/41905417:14
jeblairShrews: check that out locally and see if the tree looks correct please17:14
jeblairhere's the list of files touched: http://paste.openstack.org/show/594598/17:17
Shrewsjeblair: quick inspection looks good17:21
Shrewsgerrit doesn't make it easy to compare, but some 'show-branch' comparisons show everything to be there17:23
jeblairShrews: gertty makes it easy17:24
jeblairShrews: it will conflict with your current stack.  do you want to land the merge commit and rebase the stack, or land the stack and i can re-do the merge commit?17:25
Shrewsjeblair: i'll keep it easy on you and just rebase my stuff17:26
jeblaircool -- the merge commit didn't have any conflicts, so i kind of lean toward that anyway -- it'll be easier and safer to resolve the conflicts in the individual commits in your stack17:26
jeblairclarkb: would you mind approving 419054?17:27
openstackgerritMerged openstack-infra/nodepool: Update configuration docs for network and pool settings  https://review.openstack.org/41769117:30
clarkbjeblair: sure just git back in from dealing with snow17:38
ShuoIs there a talk session, either in OpenStack Summit or outside, that explains the details of the current OpenStack Infra? (under the hood architecture details, daily operational statistics, and etc.)17:40
Shuothat I can find on Youtube?17:40
*** hashar has quit IRC17:41
clarkbpleia2: ^ do you have a recent one handy?17:42
* Zara finds https://www.youtube.com/watch?v=b5PRk69EMuA from Barcelona17:42
Zara(pleia2's keynote on the infra)17:43
clarkboh right that17:45
clarkbjeblair: I am impressed that with that many changes the only resolved conflict was the branch in .gitreview17:47
jeblairyeah, i had it easy :)17:49
clarkb(I think that means we are properly compartmentalizing the work post initial merging back and forth)17:49
*** Cibo_ has quit IRC17:58
*** saneax is now known as saneax-_-|AFK18:03
openstackgerritPaul Belanger proposed openstack-infra/nodepool: Drop 'template' from default value of template-hostname  https://review.openstack.org/41151518:07
openstackgerritPaul Belanger proposed openstack-infra/nodepool: Drop 'template' from default value of template-hostname  https://review.openstack.org/41151518:08
pabelangerjeblair: clarkb: mind reviewing https://review.openstack.org/#/c/414385/ ? Drops our RAM usage for ubuntu DIBs in nodepool dsvm, and fixes a bug in our check script18:09
openstackgerritPaul Belanger proposed openstack-infra/nodepool: Support AFS mirrors for nodepool diskimages  https://review.openstack.org/41427318:19
clarkbpabelanger: rereading the help on nova flavor-create any idea what root disk size 0 means?18:24
clarkbpabelanger: maybe we get a disk that grows as necessary?18:24
clarkb(its what the old flavor did so approving change now, but curious what that is doing)18:24
pabelangerclarkb: not sure actually, it was just copied from the previous flavor-create command.18:26
pabelangerwill read up and find out18:26
clarkbpabelanger: ya its not a regression so not worried just confused :)18:26
openstackgerritMerged openstack-infra/nodepool: Reduce min-ram for ubuntu images for devstack  https://review.openstack.org/41438518:27
openstackgerritMerged openstack-infra/nodepool: Merge branch 'master' into feature/zuulv3  https://review.openstack.org/41905418:30
ShuoZara: thanks18:52
Shrewsstack rebase bomb inbound....18:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Remove --no-builder nodepoold option  https://review.openstack.org/41801318:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Add ZK API methods for node requests  https://review.openstack.org/41667118:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Handle provider removal from config  https://review.openstack.org/41811218:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Create per-provider ZK work threads  https://review.openstack.org/41799418:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Remove Gearman and ZMQ  https://review.openstack.org/41712818:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Set valid states per data model class  https://review.openstack.org/41748218:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Disable tests for nodepoold changes  https://review.openstack.org/41710818:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Remove --no-launches nodepoold option  https://review.openstack.org/41800118:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Minor code cleanup  https://review.openstack.org/41719918:53
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Add framework for handling node requests  https://review.openstack.org/41858518:53
Shrews*BOOM*18:54
mordredShrews: nice18:54
Shrewsmordred: it really is quite mordred-esque, isn't it?18:54
mordredShrews: if it was mordred, you'd have messed up pep8 on the first patch and follow that bomb with an immediate second one :)18:55
Shrewsthere's still a chance18:58
*** hashar has joined #zuul19:52
*** morgan_ is now known as morgan19:58
ShuoI found (and watched) this talk very helpful, which help me answer some preliminary question and think deeper ones, just to answer my own previous question20:56
*** dmsimard|afk is now known as dmsimard21:00
*** jamielennox|away is now known as jamielennox21:01
ShuoI found (and watched) this talk very helpful, which help me answer some preliminary question and think deeper ones, just to answer my own previous question (missed the link just now) https://www.youtube.com/watch?v=R4EmE1QEvNU21:02
openstackgerritMerged openstack-infra/nodepool: Add ZK API methods for node requests  https://review.openstack.org/41667121:43
jeblairi'm approving the rebased changes in the stack (carrying over reviews for ones that had rebase conflicts)21:44
jeblairpabelanger: you reviewed all the other changes in the stack, did you want to see https://review.openstack.org/417994 ?21:44
pabelangerjeblair: I likely skipped because my threads programming isn't the best.21:46
pabelangerbut I can look now21:46
openstackgerritMerged openstack-infra/nodepool: Disable tests for nodepoold changes  https://review.openstack.org/41710821:46
openstackgerritMerged openstack-infra/nodepool: Remove Gearman and ZMQ  https://review.openstack.org/41712821:46
openstackgerritMerged openstack-infra/nodepool: Minor code cleanup  https://review.openstack.org/41719921:47
openstackgerritMerged openstack-infra/nodepool: Set valid states per data model class  https://review.openstack.org/41748221:48
* SpamapS staring at merge branch code for the last 20 minute22:04
Shrewsjeblair: awesome. now i can put some thinking in how to limit the number of requests handled concurrently.22:09
Shrewsthinking i'll have to track the threads spawned and compare alive count with the max22:10
pabelangerShrews: 1 thread per vm that is launched right?22:11
pabelangererr, per provider22:12
Shrewspabelanger: well, 1 thread per provider, but each provider thread can spawn N threads to handle N requests22:12
pabelangerright22:12
Shrewswe *might* want to put a limit on N22:13
Shrewsi also suspect we might be hitting ZK pretty hard to traverse the request queue. that worries me a bit22:15
jeblairShrews: we could get clever then and set a child watch on it and only traverse it when it updates?22:17
jeblair(could probably do that later to avoid premature optimization)22:17
jeblair(oh, but perhaps sometimes our own situation will change and we may want to revisit earlier requests...)22:18
jeblairforget i said anything until we have a better handle on the algorithm :)22:18
* Shrews forgets all the things22:19
jeblairShrews: i'm seeing phrases like "15k requests per second" in relation to single zookeeper servers...22:19
Shrewshopefully that's not followed by "is waaaaay beyond the maximum"22:20
Shrewsi may be worrying about nothing. i like to get the worrying out of the way early in the software development lifecycle22:20
jeblairShrews: it was preceded by "is still able to process" :)22:21
jeblairlook, a graph!  https://wiki.apache.org/hadoop/ZooKeeper/ServiceLatencyOverview22:21
jeblairand that includes almost half as write operations22:21
jeblairShrews: what? me worry?22:22
Shrewswell, i'm inclined to believe the Internet. sweeeet  :)22:22
Shrewswe'll have to remember to make our own shiny ZK graphs when this is done22:22
* Shrews smells a talk topic22:22
jeblairoh yeah, we should start shipping data over to graphite so we can grafana it22:22
pabelangerwas looking at fedmsg again today22:26
pabelangerreally need to get up a server to play with22:26
* SpamapS trying to understand what actually lands the commits in the local git repos when using fakegerritconnection22:33
jeblairSpamapS: FakeChange.setMerged22:35
SpamapSjeblair: ty.. just found that, then alt-tabbed back here to say that. ;)22:46
SpamapSI'm trying to re-enable test_build_configuration_branch and the commits seem to be overriding previous commits (so, A, B, and C, all land individually, and in the end, only C is in the branch)22:48
*** hashar has quit IRC22:49
jeblairSpamapS: i think that test is using the merger repo rather than the upstream repo to perform that validation -- it's checking that the repo state it prepared for the job including all 3.22:54
jeblairSpamapS: the fake gerrit isn't sophisticated enough to merge changes as needed (it only fast-forwards to whatever you tell it is merged)22:54
jeblairs/including/includes/22:56
SpamapSjeblair: the fake gerrit seems to only be able to land one commit in the upstream repo.22:56
jeblairSpamapS: right, it just sets the pointer to that commit22:57
SpamapSit does in fact overrite whatever the previous head was, with the current change22:57
SpamapSoverwrite even :-P22:57
SpamapSjeblair: ok, so that's just not behavior we can test, and the old test was able to rely on the merger keeping the ref..22:58
jeblairSpamapS: right.  we could make fakegerrit do that without too much trouble, but it may be easier to do the v3 equivalent of that, which is to check what's in the jobdir for the change.22:59
SpamapSjeblair: indeed, I'm looking at that right now23:00
jeblairSpamapS: if we grab a build for the last change, we should be able to do build.hasChanges(A,B,C) i think23:00
jeblairor something like that23:00
SpamapSoh that would be slick, but would that test the same thing?23:00
jeblairyeah, i think that would be as close to a straight port of the test as we can manage23:00
jeblair(i think the test would probably be improved by make fakegerrit more sophisticated and testing that, but that's probably best deferred)23:01
jeblairi feel like i butchered that sentence23:02
jeblair(i think the test would probably be improved by making fakegerrit more sophisticated and testing that changes landed upstream as expected, but that's probably best deferred)23:02
jeblairredo ^23:02
*** saneax-_-|AFK is now known as saneax23:20
Shrewsjeblair: mordred: pabelanger: can one of you +A https://review.openstack.org/418585? It has two +2's23:28
jeblairdone23:30
jeblairShrews: and parents23:31
jeblairShrews: can you take a look at https://review.openstack.org/412160 ?23:31
jeblair(not urgent)23:31
openstackgerritMerged openstack-infra/nodepool: Create per-provider ZK work threads  https://review.openstack.org/41799423:33
openstackgerritMerged openstack-infra/nodepool: Remove --no-launches nodepoold option  https://review.openstack.org/41800123:34
openstackgerritMerged openstack-infra/nodepool: Remove --no-builder nodepoold option  https://review.openstack.org/41801323:35
Shrewsjeblair: thanks, and yes. first thing in the morning (or after making dinner tonight)23:35
openstackgerritMerged openstack-infra/nodepool: Handle provider removal from config  https://review.openstack.org/41811223:35
openstackgerritMerged openstack-infra/nodepool: Add framework for handling node requests  https://review.openstack.org/41858523:35

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!