openstackgerrit | Adam Gandelman proposed openstack-infra/zuul: Re-enable test_success_pattern as test_success_url https://review.openstack.org/400455 | 00:48 |
---|---|---|
jeblair | jamielennox: nope! they will need their configuration updated to the new form (or maybe they can use one of the configurations we've already written like 'single-project'), and some of the test assert methods, fakes, etc need updating. but the thing they're testing is really the same, so they'll be great intro-to-v3 tests. | 00:49 |
jeblair | (they probably want their own configuration files though) | 00:50 |
jamielennox | jeblair: excellent, it seemed like some of that had moved but i have at least one that is passing, just trying to make sure now i haven't done anything silly | 00:51 |
jamielennox | mostly i just didn't want to dive into something that was going to be a dead end | 00:53 |
*** yolanda has joined #zuul | 00:56 | |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Skip individual test_requirements tests https://review.openstack.org/401018 | 01:01 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-newer-than tests https://review.openstack.org/401019 | 01:01 |
pabelanger | Shrews: True, I was just looking to validate the image was on disk properly, without layering a top of the upload logic | 01:33 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-newer-than tests https://review.openstack.org/401019 | 01:37 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-older-than tests https://review.openstack.org/401027 | 01:37 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-username tests https://review.openstack.org/401028 | 01:37 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-email tests https://review.openstack.org/401029 | 01:37 |
jamielennox | i might wait until someone has a look at those to see i'm doing it right, the rest of the file will just be repeating the same formula | 01:39 |
pabelanger | jamielennox: looks good so far, maybe just have tests/fixtures/config/requirement-tests as the base, since all seem to use 2 projects, then have per test layout files in the git sub folder. Should mean less org_project1/README / org_project2/README directories we need to carry. | 01:45 |
jamielennox | pabelanger: is there an example of that layout already in tests? because this is configured with common-config i'd have to change how the fixture worked to do that right? | 01:48 |
jamielennox | pabelanger: i don't mind changing the fixture, just is that something supported already | 01:49 |
jamielennox | oh, main.yml is something i provide to the fixture | 01:51 |
jamielennox | ok, that's easy | 01:51 |
pabelanger | jamielennox: test_check_smtp_pool is an example | 01:53 |
pabelanger | yup | 01:53 |
*** jamielennox is now known as jamielennox|away | 02:30 | |
*** jamielennox|away is now known as jamielennox | 02:59 | |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-older-than tests https://review.openstack.org/401027 | 03:43 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-username tests https://review.openstack.org/401028 | 03:43 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-email tests https://review.openstack.org/401029 | 03:43 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-newer-than tests https://review.openstack.org/401019 | 03:43 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-older-than tests https://review.openstack.org/401027 | 05:09 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-username tests https://review.openstack.org/401028 | 05:09 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-email tests https://review.openstack.org/401029 | 05:09 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement-newer-than tests https://review.openstack.org/401019 | 05:09 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement vote tests https://review.openstack.org/401061 | 05:09 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement status tests https://review.openstack.org/401062 | 05:09 |
openstackgerrit | Jamie Lennox proposed openstack-infra/zuul: Re-enable requirement reject tests https://review.openstack.org/401063 | 05:09 |
*** abregman has joined #zuul | 06:36 | |
*** willthames has quit IRC | 06:53 | |
*** hashar has joined #zuul | 10:07 | |
*** jamielennox is now known as jamielennox|away | 10:21 | |
*** yolanda has quit IRC | 10:41 | |
*** yolanda has joined #zuul | 11:11 | |
*** yolanda has quit IRC | 11:55 | |
*** yolanda has joined #zuul | 11:55 | |
*** openstackgerrit has quit IRC | 12:03 | |
*** openstackgerrit has joined #zuul | 12:04 | |
*** abregman is now known as abregman|mtg | 12:21 | |
*** yolanda has quit IRC | 13:29 | |
*** abregman|mtg is now known as abregman | 13:35 | |
*** saneax-_-|AFK is now known as saneax | 13:36 | |
*** dmsimard|away is now known as dmsimard | 13:45 | |
*** abregman has quit IRC | 13:55 | |
*** Zara has quit IRC | 14:04 | |
*** Cibo has joined #zuul | 14:04 | |
*** SotK has quit IRC | 14:04 | |
*** SotK has joined #zuul | 14:05 | |
*** abregman has joined #zuul | 14:07 | |
*** Zara has joined #zuul | 14:09 | |
*** abregman is now known as abregman|mtg | 14:19 | |
*** yolanda has joined #zuul | 14:21 | |
pabelanger | o/ | 14:26 |
pabelanger | catching train back to Ottawa this morning | 14:26 |
openstackgerrit | Merged openstack-infra/zuul: Skip individual test_requirements tests https://review.openstack.org/401018 | 14:35 |
pabelanger | jeblair: jamielennox|away: Looking at 401019, I would have expected the job to fail because project1-job doesn't exist in the updated layout.yaml | 14:44 |
*** abregman_ has joined #zuul | 15:01 | |
*** abregman|mtg has quit IRC | 15:05 | |
*** abregman_ has quit IRC | 15:11 | |
*** abregman has joined #zuul | 15:11 | |
*** abregman is now known as abregman|mtg | 15:58 | |
*** hashar has quit IRC | 16:50 | |
*** abregman|mtg has quit IRC | 17:28 | |
*** hogepodge has joined #zuul | 17:28 | |
*** hogepodge has quit IRC | 17:33 | |
*** hogepodge has joined #zuul | 17:43 | |
*** hashar has joined #zuul | 18:03 | |
*** hashar is now known as hasharAway | 18:04 | |
*** abregman has joined #zuul | 19:31 | |
*** abregman is now known as abregman|afk | 19:38 | |
*** hasharAway is now known as hashar | 19:40 | |
*** Cibo has quit IRC | 19:57 | |
*** abregman|afk has quit IRC | 20:21 | |
*** jamielennox|away is now known as jamielennox | 21:22 | |
jamielennox | pabelanger: replied on review | 21:28 |
jhesketh | Morning | 21:28 |
jamielennox | jhesketh: nice to see someone else keeping normal hourse | 21:30 |
jamielennox | hours | 21:30 |
jhesketh | :-) | 21:30 |
*** yolanda has quit IRC | 21:50 | |
*** hashar has quit IRC | 22:10 | |
*** willthames has joined #zuul | 23:12 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!