Thursday, 2016-11-03

dmsimardansible 2.2 is out and it's pretty darn fast, amongst other things00:13
*** herlo has joined #zuul02:08
*** herlo has joined #zuul02:08
*** bcoca has quit IRC02:42
*** saneax-_-|AFK is now known as saneax03:15
*** saneax is now known as saneax-_-|AFK04:27
*** bhavik1 has joined #zuul04:45
*** bhavik1 has quit IRC05:12
*** openstackgerrit has quit IRC05:48
*** openstackgerrit has joined #zuul05:49
*** bhavik1 has joined #zuul05:59
*** saneax-_-|AFK is now known as saneax06:43
*** yolanda has joined #zuul06:51
*** yolanda_ has joined #zuul06:51
*** yolanda_ has quit IRC06:52
*** bhavik1 has quit IRC07:02
*** openstackgerrit has quit IRC07:48
*** openstackgerrit has joined #zuul07:49
*** hashar has joined #zuul07:57
*** abregman has joined #zuul08:22
rcarrillocruzjeblair , fungi : seems pycrypto doesn't have support for pkcs7 , it does for pkcs1 (rsa based)10:05
rcarrillocruzhttps://www.dlitz.net/software/pycrypto/api/2.6/Crypto.Cipher-module.html10:06
rcarrillocruzi'll work on a poc patch using it and push so you have a look10:06
*** mmedvede has quit IRC11:09
*** mmedvede has joined #zuul11:22
pabelangerdmsimard: ya, I haven't tested it yet. Wonder how much work it will be to upgrade zuul to start using it12:01
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_needed_changes_enqueue testing  https://review.openstack.org/39300112:16
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_source_cache unit test  https://review.openstack.org/39327812:19
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_one_job_project unit test  https://review.openstack.org/39330413:04
pabelangerjeblair: are you okay with create a new class when we need to use a different tenant_config_file ^? Figured it would be a good time to slim down the single-tenant configuration13:08
fungircarrillocruz: pkcs#7 is closely tied to s/mime, so it's possible we just need to look at a different library. unfortunately the most popular one for doing s/mime and pkcs#7 seems to still be m2crypto, which i think we had abandoned some years ago in openstack for reasons i no longer recall13:17
*** abregman is now known as abregman|afk13:18
pabelangeroh, ya, m2crypto had embedded things IIRC13:19
*** hashar is now known as hasharAway13:20
*** jasondotstar has joined #zuul13:20
openstackgerritMonty Taylor proposed openstack-infra/zuul: Revert "Work with ansible 2.1"  https://review.openstack.org/37976913:27
mordredthat should be good now that 2.2 is out13:27
*** saneax is now known as saneax-_-|AFK13:49
*** yolanda has quit IRC14:22
*** yolanda has joined #zuul14:23
*** abregman|afk is now known as abregman14:31
*** yolanda has quit IRC14:33
*** yolanda has joined #zuul14:38
*** abregman has quit IRC14:44
*** hasharAway is now known as hashar15:44
timrc"Channel created on Sun, 23 Aug 2009 11:50:29" -- really?16:06
Shrewsmost likely. it was originally for a now defunct project. jeblair grabbed the channel through some magic16:07
jeblairShrews: i used the most secret and dark spell i know of on irc -- so mysterious and terrible it is almost never spoken of.  it's name: "ask nicely".16:12
Shrews*shudder*16:13
SotKsounds terrifying16:13
mordredjeblair: I heard that was deprecated and you're supposed to use docker somehow now16:20
jeblairmordred: docker make me a sandwich16:21
timrcmordred: Yeah, you're suppose to run "ask nicely" in a sidekick container.16:21
mgagnedo you know if it's possible to have nested templates in Zuul? Like a template including multiple other templates.16:22
jeblairmgagne: i don't believe so16:23
mgagnealright, thanks!16:25
pabelangerjeblair: speaking of templates, looking at the zuulv3 spec, we say templates are still support, but don't cite an example.  Currently working towards enabling test_job_from_templates_launched and could use some syntax help if you have something handly16:37
jeblairpabelanger: the code exists already, and there's a template test that exercises it in the test_v3 file16:40
jeblairpabelanger: so hopefully you should be able to update the syntax based on the config that test uses16:40
pabelangerjeblair: Ah, thanks. grep is my friend16:41
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_job_from_templates_launched job  https://review.openstack.org/39341216:50
pabelanger^ is a little different in zuulv3, seems using a template variable is no longer valid.16:52
pabelangerbut I might have had my syntax wrong16:52
pabelangerstill working on it16:52
*** bcoca has joined #zuul17:03
jeblairpabelanger: yes, no more variables -- the only one was 'name' and we're retiring the practice of including project names in jobs.17:14
pabelangerjeblair: great17:16
*** harlowja has quit IRC17:43
*** harlowja has joined #zuul17:46
*** abregman has joined #zuul17:56
*** abregman has quit IRC18:09
*** hashar is now known as hasharAway18:33
SpamapSFYI, I'm adding stories to storyboard at the moment.. pretty difficult fighting through bugs in the UI.. but we all should start seeing stories appear in this board...18:38
SpamapShttps://storyboard.openstack.org/#!/board/4118:38
cineramacool18:39
auggythanks for doing that SpamapS !18:44
auggyif you have notes or something somewhere or would like some help, i'm sure folks would be happy to be delegated to, myself included :)18:44
auggyeven if it's just throw some stubs up there and then have some folks in the project here fill them out better18:45
SpamapSauggy: I'm pulling from Jim's notes .. shouldn't be too hard, I've got a system now :)18:46
SpamapSonce they're in, we can treat storyboard as the source of truth for these itesm18:46
auggyok, i have no idea what kind of volume we're talking about here, so if there's any opportunity for other folks to participate, it seemed like a potentially good opportunity for that18:49
SpamapSauggy: I'm about 30% of the way through18:50
SpamapSso.. not so crazy high18:50
auggySpamapS: where are these notes? some of the tickets don't have a lot of information in them and i'd be happy to review the notes and maybe add some context18:57
SpamapSYeah the notes are super sparse18:57
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_layered_templates test  https://review.openstack.org/39344518:57
SpamapSjeblair: to auggy's point, a lot of these stories could use more information to help noobs get started on them. Not sure how we're going to flesh those out.18:58
* SpamapS includes himself in the noobs list :)18:58
auggyjeblair: SpamapS: maybe it's something we could divide and conquer on amongst the interested contributors18:58
auggyie, once we have the list then people can work on getting more info to flesh them out18:59
SpamapSyeah definitely filling in the details will help get us going18:59
* SpamapS has to switch to arch-wg for an hour18:59
auggyoh right i was gonna attend that18:59
auggy:D18:59
SpamapSauggy: I have about 10 left to add18:59
auggywhoohoo!18:59
auggydang you're a machine18:59
SpamapSthen I will definitely revisit them and start filling in descriptions where I can18:59
SpamapS-> #openstack-meeting-alt if you want to attend. :)19:00
auggythx!19:00
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_check_queue_success test  https://review.openstack.org/39345219:15
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_check_queue_success / test_check_queue_failure  https://review.openstack.org/39345219:17
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable 3 disabled tests  https://review.openstack.org/39345219:22
ShrewsI'd add some context to some of those SB things, but I do not seem to be able to edit19:22
openstackgerritPaul Belanger proposed openstack-infra/zuul: Enable test_new_patchset_check test  https://review.openstack.org/39345819:24
mordredShrews: I seem to be able to edit them - but I don't know if that's just because I'm a superadmin19:25
pabelangerstarting to get into a rhythm now19:25
auggyi added a comment to one19:25
mordred\o/19:25
mordredit's about the minor successes19:25
auggyhttps://storyboard.openstack.org/#!/story/200077319:25
* Shrews shrugs and keeps his context to himself19:25
mordredShrews: did you click through to the actual story?19:26
mordredShrews: you can't edit the pop-up window thing19:26
auggythat's where we talked about grouping the tests by feature/functionality/whatever19:26
mordredShrews: but you should be able to edit here: https://storyboard.openstack.org/#!/story/200076719:26
Shrewsmordred: ugh, ANOTHER click? *sigh*19:26
mordredShrews: you saw that jeblair has been working on boartty yeah?19:26
Shrewsi wanted to be super lazy19:26
openstackgerritPaul Belanger proposed openstack-infra/zuul: Enable test_new_patchset_check / test_abandoned_check  https://review.openstack.org/39345819:26
Shrewsmordred: yup19:26
auggyi'm able to edit19:27
auggyi has the power!19:27
Shrewsauggy: ID-10-T error19:27
mordredit's worth pointing out pabelanger's patch above to everyone -- it mentions the concept of an "abide" which is a vocabulary word in v3 - but also always an opportunity to remind people what The Dude does19:28
auggyhahahaha19:29
pabelangerthe dude19:29
*** mmedvede has quit IRC19:29
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable 4 disable tests  https://review.openstack.org/39346119:30
pabelangerI'm sure a lot of this can be squashed if needed, I'm basically going test, by test now19:30
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable 3 disabled tests  https://review.openstack.org/39345219:33
openstackgerritPaul Belanger proposed openstack-infra/zuul: Enable test_new_patchset_check / test_abandoned_check  https://review.openstack.org/39345819:33
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_layered_templates test  https://review.openstack.org/39344519:33
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable 4 disable tests  https://review.openstack.org/39346119:33
mordredpabelanger: you are a machine19:34
pabelangermordred: now to fill my gas tank with some food19:34
timrcpabelanger: I didn't read up completely so maybe this was discussed but re:templated projects...19:37
timrcTake a look at https://review.openstack.org/gitweb?p=openstack-infra/zuul.git;a=tree;f=tests/fixtures/config;hb=ff6582d75c95859d456e588e0e74c602b9664fdb -- are project-template and templated-project fundamentally different?19:38
*** hasharAway is now known as hashar19:46
pabelangertimrc: Ya, they appear to be the same thing. I suspect we can remove templated-project patch19:46
timrcAlso, this is just me thinking outloud here, but do we really consider these templates? It feels like a deviation from what people have come to expect as a template. Can projects just be composed of other projects?20:02
jeblairtimrc: a project is a git repo; i don't think project composition makes sense.  a template is a pattern of pipeline-job configuration which can be applied to multiple projects.  having a project follow the 'publish-to-pypi' template makes sense to me.  it is also exactly what we call templates in zuulv2.20:07
timrcjeblair: I'm just thinking about what the term template means across projects not necessarily what it meant in zuulv2->v3. But yeah, I see how project/sub-project would not work given the definition of a project primitive.20:11
timrcerm20:11
timrcoverloaded the term project there20:11
timrcabout what the term template menas across other software projects (puppet, ansible, django, whatever)20:11
timrceven in jjb is closer to what I'd consider a template, generating something new with input + boilerplate.20:13
jeblairtimrc: i think that's an expansion of the plain english form of the word which allows for use without change -- in fact, a template is used to make the same thing over and over.  i don't expect people to have a problem with it either way.20:15
*** abregman has joined #zuul20:17
openstackgerritPaul Belanger proposed openstack-infra/zuul: Enable test_statsd test  https://review.openstack.org/39347920:28
SpamapSjeblair: FYI, on the board, 'todo' is "next steps", backlog is 'things we think we need to do'20:42
SpamapSthat should probably go in the description20:43
jeblairoh yeah, that'd be a good thing for the board description20:43
SpamapSalso I've been making stories when I'm not sure how isolated things are from one another. The line between story and task I think is sometimes blurry.20:44
jeblairSpamapS: there's something that i'm not quite sure how to express yet, which is that we have a couple of arcs -- in our 3 or 4 phase rollout plan, we have 1) roll out nodepool zk builders; 2) roll out nodepool zk launchers; 3) roll out zuulv320:44
jeblairSpamapS: (indeed... ^ that goes to that point about story/task lines as well)20:45
SpamapSRight, well I think we could manage each of those arcs as a work board.. or just put all the things for arc #1 in todo first, and then leave the rest in backlog20:45
SpamapSI kind of prefer the latter.. but it means the workboard won't be usable as an overall work status view.. it's just for an idea of what's going on _now_.20:46
jeblairSpamapS: yeah.  also, we're totally in "pick something and try it for a bit" mode... so, easy come easy go20:46
jeblairSpamapS: at any rate, in the "roll out nodepool zk builders" plan, we're actually fairly close to that.  we need a few more tasks to flesh it out.  but i think the next one on the list is actually the "switch nodepool zk module to use classes instead of dicts"20:47
SpamapSYep.. the only reason I want the board is so people pick different things from eachother.20:47
jeblairSpamapS: that's in service of "incorporate zk builder back into main nodepool" and "enable more zk builder tests" -- both tasks that i should probably go create right now :)20:47
*** mmedvede has joined #zuul20:48
jeblairbut those are the things that, roughly speaking, i think need to get done before we roll it out into production  (Shrews may also know of some things i'm missing there)20:49
SpamapSjeblair: so I'll get all of these stories/tasks input here in the next few.. and then maybe you can sift through backlog and make sure everything that needs to be is in todo20:51
jeblairSpamapS: k.  i added those two things i just said as tasks on https://storyboard.openstack.org/#!/story/200076720:55
SpamapShooray20:58
SpamapSjeblair: "use ssl with gearman (openstack puppet deployment)20:58
SpamapSthat doesn't seem related?20:58
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_live_reconfiguration test  https://review.openstack.org/39348821:00
pabelanger^ actually exposed a bug I think21:01
openstackgerritPaul Belanger proposed openstack-infra/zuul: Re-enable test_live_reconfiguration test  https://review.openstack.org/39348821:02
SpamapSjeblair: ok, the board now has everything from your email, except ssl with gearman and python3, since I think neither of those are needed for base operational functionality. Though they are needed, I presume, for infra rollout?21:04
SpamapSI have updated the description for https://storyboard.openstack.org/#!/board/4121:07
SpamapSauggy: around? Can you try moving a task around on that? I want to see if non-owner non-users can edit the board21:07
auggySpamapS: sure, i was able to edit the ticket about the tests that you created before21:09
auggylol 400: GET /api/v1/users/preferences: Invalid input for field/attribute user_id. Value: 'preferences'. unable to convert to int21:09
SpamapSauggy: when do you get that?21:10
SpamapSauggy: just trying to move things on the board?21:10
auggyhrm trying but sorryboard doesn't seem to be loading correctly21:10
auggystill working on it21:10
jeblairSpamapS: we need to switch to using gear ssl for openstack infra since we will be shipping credentials across it.  the python3 stuff will be needed for websockets based console log streaming.21:10
auggyhow do you move things across, is dragon drops a thing ?21:12
jeblairSpamapS: so yeah, the gear thing is an infra-specific rollout.  python3 can be kicked down the road if we don't want to include that in the initial release, but i think we need it early on.  it is a feature that is... widely expected.  :)21:12
jeblairauggy: yes21:15
Shrewsjeblair: SpamapS: fwiw, i believe i was the one to add ssl support to gear waaaaaay back when. i hope it works  :)21:15
jeblairShrews: it's tested :)21:15
Shrewsw00t21:15
jeblair(all the gear tests run with both ssl and non-ssl.  that sounds excessive now that i say it.)21:16
Shrewswow, i added that more than 3 years ago. and for the life of me, i cannot remember what for21:17
Shrewsoh, maybe libra21:17
SpamapSjeblair: oh I think socket streaming viewing is in our mvp.21:17
SpamapS"hang on I'm running your job" is a really awful experience21:17
auggyso yeah i have no dragon drops21:18
SpamapSright now I believe gearmand's SSL support is borken because of modern OpenSSL versions.. so gear is ahead of the curve. ;)21:18
SpamapSauggy: so it looks like a static list for you?21:19
auggyyeah when i click on things it just highlights21:19
auggyi can't pick anything up21:19
jeblairSpamapS: yeah.  "telnet" is, of course superior, but requires "user re-education" which is not in the mvp21:19
jeblairSpamapS, auggy: we probably need to add auggy as either a user or owner of the board, not sure what the diff is.21:20
auggyhttps://usercontent.irccloud-cdn.com/file/0In2GwOg/Screenshot%20from%202016-11-03%2014%3A19%3A39.png21:20
auggyso when i click on any one of those cards, nothing happens, when i try to drag, it just highlights the text21:21
jeblairSpamapS: the websockets / python3 thing is going to be tricky.  it's not a simple task -- we need to think carefully about the gear api in python3.  so we should budget appropriately for that.21:21
SpamapSyeah bytes and strings, fun21:21
jeblairzactl21:21
jeblairy21:22
SpamapSthough I think for the most part the thing we found in pysaml2 (which has similar challenges) was "all public api calls ingest and emit strings unless an encoding is already included in the bytes content"21:23
SpamapSthen again, pysaml2 has the benefit of xml21:23
jeblairSpamapS: yeah, the problem arises from you might be using this to send json.  or you might be using it to send jpeg.21:23
SpamapSauggy: ok I'm going to add you as a user..21:23
SpamapSauggy: can you refresh now?21:24
auggySpamapS: ooh it's like tron21:24
jeblair(my *guess*: users can move boxes around, owners can additionally modify the acls)21:24
jeblairauggy: can tell us if that's the case in a minute :)21:24
SpamapSjeblair: yeah with gear, I think bytes may be the thing.21:24
auggyYESH IT WORKS21:25
auggyi has the dragon drops!21:25
SpamapSthough we could definitely duck type and say if you give us a string it's going to get encoded as utf-8.21:25
jeblairSpamapS: anyway, there's a whole ml list chain about it from 5 months ago we can dust off when we're ready.  mostly wanted to convey that it's not just "go sprinkle some six around".21:25
SpamapSbut that doesn't mean it's coming out as a string on the other end, just as bytes.21:25
SpamapSYeah, all things with I/O are challenging with python3.. but if you think long and hard about it, that's what they point was of being explicit.21:26
SpamapSless magic21:26
auggyjeblair: which ml list? infra? maybe we could paste a link to that discussion in the bug for now? i'm happy to do it :)21:26
SpamapSjeblair: forgive me the deep dive.. I've been project managing all day and my engineer muscle is really twitchy ;)21:26
jeblairauggy: yes infra.21:26
auggywhen my dog takes bytes it often comes out as a string of sorts on the other end21:26
SpamapSauggy: ok so we basically have to add everyone who wants to work on zuul to it21:26
SpamapSI feel a feature request coming on21:27
auggyhahaha yeahhh, how do we make storyboard requests?21:27
auggyjust pop into story board and ask?21:28
jeblairauggy: or make a story in storyboard21:28
jeblairor both21:28
auggyalthough i think the idea might be a permissions thing... like do you want non-zuul people to be able to move things around?21:28
auggyor yeah i dk.. i just realized i can modify zuul bugs21:28
auggyso that shouldn't matter21:28
auggythe perms should be consistent either way21:28
* auggy is just thinking about how to file the storyboard bug in storyboard21:29
auggyso many layers to this one whoa21:29
jeblairauggy: i think the idea is that boards are used to set priority, which is the purview of an individual or group, whereas stories are the unfiltered input into that21:29
auggyohhhh right21:30
auggyso it's priority *to you*21:30
auggyso you have to be part of the entity that has whatever that priority perspective is?21:30
jeblairauggy: yep.  so this board will be "our team's priority"21:30
auggyok21:31
auggyhrm so if we wanted to file a ticket for storyboard to change that... what exactly would we want? for anyone to be able to see that perspective?21:31
auggynot see but modify21:31
jeblairauggy: well, the boards are public, so anyone can see "what we think needs to be worked on to make zuulv3 operational", they just can't change what we think needs to be worked on.21:32
auggyright, so when we talk about wanting to file a ticket, is it that we want to change that ability?21:32
auggyhow about if there was some message like "if you want to modify this you need to be part of x group" and a link to add yourself or request to be added?21:33
jeblairauggy: well, i don't actually have anything better to offer the storyboard team right now in terms of ideas other than "just used fixed priority on the story".  so i'm comfortable trying this out the way they thought it might should be used and seeing how it goes.21:33
jeblairauggy: yeah, an explanation might be nice.  even something like "This board is managed by ..."21:34
auggyyeah so one thing i am thinking about now, i didn't even know that modifying that was even an option21:34
jeblairthat would be nice for storyboard to have, though we could probably put that into our description right now...21:34
auggyso some indication of group membership would be useful so people know..21:34
jeblairauggy: can you edit the board description?21:34
auggyyeah as an interim21:34
auggyjeblair: yeah i can21:34
auggywhat's the group that people should belong to?21:35
auggyand how do they request to be in it?21:35
jeblairhrm, let's go to #storyboard21:35
auggywell actually i can't21:35
auggyi thought i could edit it21:35
auggyoh wait i think i get it21:41
auggyso SpamapS did you have to specifically add me to have access to that board?21:41
auggywhereas if we had some generic "zuul team" that had that access, we could just add people to that and then as we run into things, just add that team to have access21:41
jeblairauggy: yes, the board has an acl21:42
jeblairauggy, SpamapS: so i guess for the moment, our process will be "complain if you need to move boxes around and someone will give you access to move boxes around"21:44
auggyhaha21:44
auggyhow can i edit the description to update it with that info?21:44
jeblairauggy: since, yeah, storyboard has "teams" but i can't see that they are able to be used for this21:45
jeblairauggy: do you have a pencil icon next to the board title on https://storyboard.openstack.org/#!/board/41  ?21:45
auggyno pencils for me21:47
auggyonly dragon drops21:47
SpamapSRight, auggy has user access21:47
SpamapSauggy: you can add things right?21:48
auggywell i'm not sure21:48
auggyi'm trying to21:48
auggyah i see21:49
auggyso if you create a new story it doesn't automatically select it for you in the add stories, you still have to search for it first21:50
auggy*sigh*21:50
auggythis is taking dog fooding to a whole new level i see ;D haha21:50
auggySpamapS: yes i can add a story21:50
* auggy needs to go afk for a bit21:53
auggyso if i don't respond immediately... it's cuz i'm not here!21:53
SpamapSauggy: thanks for helping us test21:54
mordredjeblair, SpamapS: I believe we can do the websockets thing without python3 at this point - although I'd like to discuss the various options with people at some point when we're a little futher along21:55
jeblairmordred: okay.  i mean, python3 is a thing we need to do eventually anyway...  the last time we discussed it, the options not involving python3 seemed terrible...  but if they are better, we can certainly reconsider :)21:56
mordredthe python2 options include some things I personally and infra more broadly consider 'ick' - but that aren't necessarily bad if they're properly contained. considering the care gear3 will need, it may be more expeditious to do one of them instead of lose ourselves down the gear3 hole21:56
*** harlowja has quit IRC21:56
jeblairmordred: i actually do not think that the gear3 hole will be that bad.  i think it will be far better than 'ick'.21:57
openstackgerritPaul Belanger proposed openstack-infra/zuul: Enable 4 CRD unit tests  https://review.openstack.org/39349421:58
mordredjeblair: awesome. I mostly wanted to add into the conversation that, depending on how gear3 winds up being scoped, there are phyiscal possibilities that do not necessitate solving gear3. that said - solving gear3 and moving forward cleanly is my preference21:59
jeblairmordred: yeah, i hope we can do that and reserve 'contained ick' as a fallback plan :)22:01
clarkbright I think its a good idea to not have a hard requirement there if it isn't actually a hard requirement. Which is what I think I was trying to argue for in the past22:01
clarkbmakes solving the problems easier that way22:01
openstackgerritPaul Belanger proposed openstack-infra/zuul: Enable 4 CRD unit tests  https://review.openstack.org/39349422:03
pabelangerokay, that's it for me today. If people are interested in reviewing zuulv3 patches: https://review.openstack.org/#/q/status:open+project:openstack-infra/zuul+branch:feature/zuulv3+topic:enable-tests22:03
pabelangerpretty straighforward stuff22:03
SpamapSThe gear3 hole should be pretty shallow. I'm pretty comfortable jumping into that hole actually. :)22:06
SpamapSJust needs careful thought.22:06
mordredSpamapS: yup22:06
mordredclarkb: and yup22:06
mordredI agree with everyone all at the same time!!!22:06
SpamapSAlso I'll have a hard time not also tumbling into the "make geard do the cool things gearmand does" hole at the same time. :)22:06
mordredpabelanger: you're winning at all the things22:07
mordredhttps://review.openstack.org/#/c/393479 is the best patch, btw22:08
jeblairpabelanger: you probably found the one test like that :)22:13
openstackgerritCaleb Boylan proposed openstack-infra/nodepool: Fix subnode deletion  https://review.openstack.org/37045522:30
*** toabctl has quit IRC22:42
*** toabctl has joined #zuul22:42
*** hashar has quit IRC23:03
SpamapSjeblair: btw, gear's functional tests already pass in python3. Is the coverage really bad?23:12
SpamapSwell the whole tox suite passes I should say23:12
jeblairSpamapS: yeah, i think the actual issue is that *using* gear as written in py3 is the worst thing ever23:16
SpamapSyeah playing around, requiring bytes for function names makes very little sense.23:16
jeblairSpamapS: .encode()/.decode() is required on like every call into or out of gear.23:17
SpamapSalso it does not appear to work23:17
SpamapSINFO:gear.Server:Received packet from <gear.ServerConnection 0x7fb65e0ac470 name: None host: 127.0.0.1 port: 60750>: <gear.Packet 0x7fb65e0ac3c8 type: SUBMIT_JOB_BG function: b'foo' unique: b''>23:17
jeblairdetails23:17
SpamapSERROR:gear.Server:Received unhandled packet: <gear.Packet 0x7fb65e0ac3c8 type: SUBMIT_JOB_BG function: b'foo' unique: b''>23:17
jeblairSpamapS: yeah, i don't think the server implements that23:18
SpamapSoh BG's? ok23:18
SpamapSI just use them to get non block, doh23:18
jeblairSpamapS: (the server is very limited in functionality; the client should be fully featured)23:18
mordredSpamapS: do you own the server now too?23:19
mordred(the C one)23:19
*** saneax-_-|AFK is now known as saneax23:19
mordred(of course you do - duh- it's drink o'clock and I don't have a drink yet)23:20
mordredjeblair: what's the thing gear does that we use that never made it in to the C server which prevents us using the C server with zuul/nodepool?23:20
SpamapSmordred: I do23:20
jeblairthe only reason left for us not to use the c server is that we need strict fifo for each of the 3 priorities.  i know that's not the default for the c server, but i don't know if it's possible to coax it into that behavior.23:20
jeblairmordred: ^  (was already typing :)23:20
mordredjeblair: jinx23:21
mordredjeblair: the cancel admin function made it in already, right?23:21
SpamapSstrict fifo?23:21
jeblairmordred: aiui yes23:21
SpamapSdid you ever type that up in a launchpad bug or GH issue?23:21
SpamapSAlso I believe the recent addition of registering many functions at once isn't in gearmand.23:21
SpamapSThough I'd happily merge it.23:22
jeblairSpamapS: no idea.  was years ago.23:22
jeblairSpamapS: yes, though happily we won't need 'mass_do' in zuulv3.  (we will only have like 10 functions)23:22
SpamapSRight23:23
SpamapS(and that's generally been the position of the gearman authors in the past... "Just stuff your sub-job into your payload")23:23
jeblairmordred, SpamapS: i would be happy to switch to the C server if we can (performance yay!), though i'll still use the geard server for zuul unit tests.  and the py3 issue is related to the client api, so it doesn't solve that.23:24
SpamapSyeah23:24
mordred++23:24
SpamapSno I was just poking at _BG... that's not needed23:24
SpamapSIMO most of the interesting uses of gearman do not involve _BG jobs23:25
jeblairSpamapS: here's the last place my brain was on this issue: http://lists.openstack.org/pipermail/openstack-infra/2016-June/004464.html23:26
SpamapSjeblair: thanks, I had been trying to dig that up and gotten distracted23:27
jeblairyeah, i think i was halfway through digging it and then squirrel!23:28
Shrewsjeblair: re: "enable more zk builder tests"... there are surprisingly few tests... 2 really. only 1 is disabled23:34
Shrewsperhaps we should change that to "write new builder tests"23:34
Shrewss/new/additional/23:34
mordredShrews: or maybe the task is really easy and only has one step ;)23:38
clarkbSpamapS: jeblair re making gears api nicer for py3k one of the ideas I liked (and I am not sure who had it or if it was the one settled on) was to keep the core of gear binary, then have wrapper classes for things that would be configured with an encoding at instantiation for people dealing with strings in python23:38
clarkbthen its StringClient('utf8) instead of Client() or whatever23:38
clarkband the raeson for that is gearman is a binary protocol and as you say payload could be jpg23:39
jeblairShrews: well, if we need to.  i'd rather not have more tests than needed.  it does get exercised a lot, so may have better coverage than is apparent.  :)  but at any rate, new tests probably aren't a blocker for initial rollout.23:39
jeblairclarkb: yeah, that idea had slipped my mind.  i think that might be a good solution.23:39
SpamapSclarkb: +123:40
clarkbthere should be quite a few tests that exercise the builder in nodepool23:40
clarkbthere are the cli tests, the normal functioanl tests, and then the builder tests themselves23:40
jeblairclarkb, Shrews: the entire TestNodepool test class is skipped currently because every nodepool test uses the builder23:41
jeblair(can't boot a node without an image)23:41
jeblairso the good news is that, unlike zuul, re-enabling them should be easy...23:42
jeblairwe do the dict/object conversion (so that the zk api is closer to the existing db api), incorporate the zk api into nodepool itself, then the tests should work without significant alteration (should just be the configuration of the test fixtures)23:43
jeblairthen we turn on the devstack test, then production23:43
jeblairclarkb, SpamapS: yeah, i think a gear where all of the function names and unique ids are 'utf8' (i know it's not in the spec, but i'd be comfortable with gear asserting that -- see the first part of my email), and then data is binary by default, but have a StringWorker that gives you decoded data (and possibly a corresponding StringClient) would fit the bill.23:48
SpamapSjeblair: I was just poking at that, but calling it TextWorker and TextClient because String is too overloaded in python land.23:56
SpamapSand it aligns with six.text_type23:56
jeblairSpamapS: it has fewer chrctrs too. ++23:56
SpamapSI'm also just needing to code-nerd-out a bit..23:57
SpamapSthe challenge I have right now is how to test it without rewriting tests23:57
SpamapSjust seeing if I can do it with some testscenarios magic23:57
mordredtestscenarios23:58
mordredSpamapS: also - sorry - I haven't solved the testscenarios/load_tests thing with ttrun yet23:58
jeblair*magic*23:58
mordredSpamapS: just don't want you to think I forgot23:58
SpamapSmordred: I figure you'll get annoyed with that at some point too and do it.23:58
mordredyah23:58
SpamapSthe only way I know to do it is to go ahead and grep subunit the way testr does23:58
SpamapSwhich may defeat the purpose you had23:59
mordredwell - you can do a discover step23:59
mordredwhich, yeah, is slow - but all that really needs to happen is running load_tests in the module23:59
mordredthat you already know23:59
mordredso I _think_ we should be able to do it without too much cost23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!