opendevreview | Brendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks for octavia_api https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860332 | 02:02 |
---|---|---|
opendevreview | Brendan Shephard proposed openstack/tripleo-heat-templates stable/wallaby: Octavia: Remove unnecessary neutronclient package https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860314 | 02:04 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-ci master: Collect configuration files for host crond service https://review.opendev.org/c/openstack/tripleo-ci/+/859771 | 02:10 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: WIP: Offload cron job to host crond https://review.opendev.org/c/openstack/tripleo-heat-templates/+/858929 | 02:13 |
opendevreview | Brendan Shephard proposed openstack/tripleo-ansible master: Add Octavia Worker host_prep_tasks https://review.opendev.org/c/openstack/tripleo-ansible/+/860333 | 02:16 |
opendevreview | Brendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks from THT to tripleo-ansible https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860334 | 02:20 |
opendevreview | Brendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks from THT to tripleo-ansible https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860334 | 02:20 |
opendevreview | Brendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks for octavia worker to Ansible role https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860334 | 02:25 |
opendevreview | Takashi Kajinami proposed openstack/puppet-tripleo master: Remove reference to unused hieradata keys https://review.opendev.org/c/openstack/puppet-tripleo/+/831779 | 02:55 |
opendevreview | Takashi Kajinami proposed openstack/puppet-tripleo master: Remove manifest to deploy OVNDB at host https://review.opendev.org/c/openstack/puppet-tripleo/+/852449 | 02:56 |
opendevreview | Takashi Kajinami proposed openstack/python-tripleoclient master: overcloud node delete: Fix ignored --overcloud-ssh-port-timeout https://review.opendev.org/c/openstack/python-tripleoclient/+/860335 | 03:02 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-ansible master: Make python codes pep8 compliant https://review.opendev.org/c/openstack/tripleo-ansible/+/849179 | 03:08 |
opendevreview | Merged openstack/tripleo-heat-templates master: Fix kill-script search string to match any "/libpod-" https://review.opendev.org/c/openstack/tripleo-heat-templates/+/859454 | 04:48 |
opendevreview | Brendan Shephard proposed openstack/tripleo-ansible master: Add standalone ovn-controller role https://review.opendev.org/c/openstack/tripleo-ansible/+/845653 | 04:59 |
opendevreview | Brendan Shephard proposed openstack/tripleo-ansible master: Add standalone ovn-controller role https://review.opendev.org/c/openstack/tripleo-ansible/+/845653 | 05:03 |
*** marios is now known as marios|ruck | 06:31 | |
opendevreview | Brendan Shephard proposed openstack/tripleo-heat-templates stable/wallaby: Support role specific ContainerImagePrepare https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860315 | 06:43 |
*** yadnesh is now known as yadnesh|away | 06:54 | |
*** amoralej|off is now known as amoralej | 07:27 | |
*** jpena|off is now known as jpena | 07:37 | |
opendevreview | Arx Cruz proposed openstack/openstack-tempest-skiplist master: Add copy release command https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/860390 | 09:47 |
opendevreview | Arx Cruz proposed openstack/tripleo-ci master: Remove pingtest from tripleo https://review.opendev.org/c/openstack/tripleo-ci/+/859526 | 09:52 |
opendevreview | Brendan Shephard proposed openstack/tripleo-ansible master: Add standalone ovn-controller role https://review.opendev.org/c/openstack/tripleo-ansible/+/845653 | 09:54 |
opendevreview | Arx Cruz proposed openstack/openstack-tempest-skiplist master: Add copy release command https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/860390 | 10:40 |
opendevreview | Merged openstack/tripleo-common master: Fix the roles symlink https://review.opendev.org/c/openstack/tripleo-common/+/860259 | 10:53 |
*** amoralej is now known as amoralej|lunch | 11:03 | |
fultonj | bogdando: i wonder if we need a follow up to https://github.com/openstack/tripleo-ansible/commit/6d23b30ce8d22a4495a5ec5f248c6810696244ae | 11:35 |
fultonj | I'm testing your proposed nova_compute review but it fails as this file doesn't exist: | 11:35 |
fultonj | https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#14 | 11:35 |
fultonj | 2022-10-05T11:28:02.641636716+00:00 stderr F ERROR:__main__:MissingRequiredSource: /var/lib/kolla/config_files/src-iscsid/* file is not found | 11:35 |
fultonj | bogdando: ^ or do you have a better idea? I'm not certain. | 11:36 |
opendevreview | Arx Cruz proposed openstack/openstack-tempest-skiplist master: Add zed release to list of skipped tests https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/860403 | 11:38 |
bogdando | fultonj: I'm not sure which role should handle creation of that path | 11:54 |
bogdando | slagle: perchance? | 11:54 |
bogdando | My initial assumption was that should be a meta-dependency standalone role to cover that | 11:54 |
*** blarnath is now known as d34dh0r53 | 11:56 | |
fultonj | https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_container_standalone/tasks/main.yml#L42-L47 | 11:56 |
fultonj | looks like tripleo_container_standalone mkaes a directory and copies files into it but isn't set up to handle aribtrary subdirectories like the ones in https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#14 | 11:57 |
fultonj | so I thought of extending the loop on the config_files to make the directories | 11:59 |
bogdando | makes sense, also maybe we want that role included as meta: dependencies | 12:01 |
bogdando | roles/foo/meta/main.yml:dependencies: [] | 12:01 |
bogdando | bshephar: WDYT? | 12:02 |
bogdando | fultonj: wanna go for it and submit a patch? | 12:02 |
fultonj | bogdando: sure, i'll give it a try | 12:03 |
bogdando | thanks | 12:03 |
fultonj | ok, bogdando thanks for the dicussion | 12:03 |
bshephar | Reading the backlog | 12:12 |
*** jpodivin_ is now known as jpodivin | 12:12 | |
fultonj | hi bshephar feel free to let me know if you have a question on how i hit this | 12:14 |
opendevreview | Harald Jensås proposed openstack/openstack-virtual-baremetal master: dhcp-relay - CentOS Stream 9 https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/857537 | 12:19 |
bshephar | fultonj: Yeah, I need to get back into the standalone roles work. I think I get the issue you're describing | 12:19 |
fultonj | ack | 12:20 |
*** amoralej|lunch is now known as amoralej | 12:31 | |
opendevreview | Mikolaj Ciecierski proposed openstack/tripleo-upgrade stable/train: Make a workload_launch script more robust https://review.opendev.org/c/openstack/tripleo-upgrade/+/860413 | 12:44 |
*** kopecmartin is now known as kopecmartin|sick | 12:56 | |
*** marios|ruck is now known as marios | 13:31 | |
*** dasm|off is now known as dasm | 13:43 | |
opendevreview | Merged openstack/diskimage-builder master: Fix wrong yum.conf name of CentOS 9 Stream https://review.opendev.org/c/openstack/diskimage-builder/+/852408 | 14:50 |
opendevreview | Neil Hanlon proposed openstack/diskimage-builder master: Change rockylinux-9 container to use baseurl instead of mirrorlist https://review.opendev.org/c/openstack/diskimage-builder/+/860428 | 14:52 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations master: Removing six from modules https://review.opendev.org/c/openstack/tripleo-validations/+/860429 | 14:54 |
opendevreview | Francesco Pantano proposed openstack/tripleo-ansible master: Add observability_data_only condition to node-exporter component https://review.opendev.org/c/openstack/tripleo-ansible/+/854176 | 15:07 |
opendevreview | Francesco Pantano proposed openstack/tripleo-heat-templates master: Add observability_data_only bool https://review.opendev.org/c/openstack/tripleo-heat-templates/+/854178 | 15:08 |
opendevreview | John Fulton proposed openstack/tripleo-ansible master: Ensure /var/lib/kolla/config_files sub-directories exist https://review.opendev.org/c/openstack/tripleo-ansible/+/860472 | 15:11 |
opendevreview | David Hill proposed openstack/tripleo-heat-templates master: Set external_ids:ovn-ofctrl-wait-before-clear https://review.opendev.org/c/openstack/tripleo-heat-templates/+/860473 | 15:12 |
*** marios is now known as marios|out | 15:17 | |
opendevreview | David Hill proposed openstack/puppet-tripleo master: Allow an operator to change the crypto policies https://review.opendev.org/c/openstack/puppet-tripleo/+/860124 | 15:17 |
opendevreview | David Hill proposed openstack/puppet-tripleo master: Allow an operator to change the crypto policies https://review.opendev.org/c/openstack/puppet-tripleo/+/860124 | 15:19 |
opendevreview | David Hill proposed openstack/puppet-tripleo master: Allow an operator to change the crypto policies https://review.opendev.org/c/openstack/puppet-tripleo/+/860124 | 15:19 |
*** jpena is now known as jpena|off | 16:38 | |
*** amoralej is now known as amoralej|off | 16:39 | |
opendevreview | John Fulton proposed openstack/tripleo-ansible master: Ensure /var/lib/kolla/config_files sub-directories exist https://review.opendev.org/c/openstack/tripleo-ansible/+/860472 | 16:54 |
slagle | fultonj: i was just looking at that :) | 16:55 |
fultonj | slagle: ah ok :) | 16:55 |
slagle | i don't think the issue is that src-iscsid doesn't exist | 16:55 |
slagle | it's that /var/lib/config-data/ansible-generated/iscsid is empty on the host | 16:55 |
slagle | so that glob doesn't find anything, which apprently makes kolla unhappy | 16:56 |
fultonj | i removed the glob but got the same complaint | 16:56 |
fultonj | https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#14 | 16:56 |
fultonj | but i had to combine the glob removal and my patch to create the subdirs | 16:57 |
fultonj | i'll confirm one more time | 16:57 |
* fultonj undoes his patch and removes the dir to test again | 16:57 | |
slagle | it looks like your patch would create /var/lib/kolla/config_files/src-iscsid/ on the host? | 17:00 |
fultonj | yes | 17:00 |
slagle | yea, that's not needed. | 17:00 |
slagle | the "source" there is telling kolla-start where to read from inside the container | 17:01 |
fultonj | just like how https://review.opendev.org/c/openstack/tripleo-ansible/+/853700 did | 17:01 |
fultonj | "where to read from inside the container" | 17:02 |
fultonj | ok, so i've undone my patch | 17:02 |
fultonj | and removed the glob from https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#14 | 17:02 |
fultonj | and my compute_contaienr hasn't crashed | 17:02 |
fultonj | supporting what you're proposing | 17:02 |
fultonj | slagle: so i guess i'll abandon my patch | 17:03 |
slagle | /var/lib/kolla/config_files on the host is for the kolla configuration files | 17:03 |
fultonj | right | 17:04 |
fultonj | on my host i see a src directory in /var/lib/kolla/config_files | 17:04 |
fultonj | 12:55 <slagle> it's that /var/lib/config-data/ansible-generated/iscsid is empty on the host | 17:05 |
fultonj | yes it's empty | 17:05 |
fultonj | slagle: should the fix then just be to not have the glob in tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2 line 14 ? | 17:05 |
slagle | fultonj: short term fix is probably to comment out that whole key for now | 17:07 |
slagle | long term fix is to make iscsid role actually generate a config file. then we could leave the glob, which is what we want | 17:07 |
slagle | sorry, when i say "key", i mean that list item starting at line 14 | 17:08 |
fultonj | ok, so the config_files list would only have two items in the short term | 17:09 |
slagle | right | 17:09 |
fultonj | ok, thanks. i'll abandon the patch and leave a comment in https://review.opendev.org/c/openstack/tripleo-ansible/+/843659 | 17:10 |
opendevreview | Merged openstack/ansible-role-chrony master: Add tasks for run and sync to chrony role https://review.opendev.org/c/openstack/ansible-role-chrony/+/842223 | 17:17 |
opendevreview | John Fulton proposed openstack/tripleo-ansible master: DNM: Workaround missing items in tripleo_nova_compute https://review.opendev.org/c/openstack/tripleo-ansible/+/860483 | 17:49 |
opendevreview | Merged openstack/python-tripleoclient master: Replace some unnecessary os.path.join() https://review.opendev.org/c/openstack/python-tripleoclient/+/859188 | 18:03 |
fultonj | tkajinam: would you mind re-reviewing this when you get a chance https://review.opendev.org/c/openstack/tripleo-ansible/+/851198 ? thx | 20:45 |
rcastillo|ruck | issue with a container image hitting gate jobs https://bugs.launchpad.net/tripleo/+bug/1991846 | 21:16 |
*** dviroel is now known as dviroel|afk | 21:17 | |
*** dasm is now known as dasm|off | 21:34 | |
*** dkehn_ is now known as dkehn | 23:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!