greghaynes | clarkb: https://review.openstack.org/#/c/127683/ | 00:05 |
---|---|---|
*** ChuckC has joined #tripleo | 00:12 | |
*** chuckC_ has joined #tripleo | 00:15 | |
*** pradeep has joined #tripleo | 00:53 | |
*** pcrews has quit IRC | 00:54 | |
*** pcrews has joined #tripleo | 00:54 | |
*** Andy_Yan has joined #tripleo | 00:59 | |
*** rainya has joined #tripleo | 01:07 | |
*** pcrews has quit IRC | 01:25 | |
*** ChuckC___ has joined #tripleo | 01:27 | |
*** ChuckC___ has quit IRC | 01:32 | |
*** otoolee has quit IRC | 01:38 | |
*** marun has quit IRC | 01:51 | |
*** otoolee- has joined #tripleo | 01:56 | |
*** hewbrocca has quit IRC | 02:03 | |
*** hewbrocca has joined #tripleo | 02:03 | |
*** rainya has quit IRC | 02:06 | |
*** ramishra has joined #tripleo | 02:10 | |
*** rainya has joined #tripleo | 02:31 | |
*** ramishra has quit IRC | 02:35 | |
*** rainya has quit IRC | 02:44 | |
*** enterprisedc has joined #tripleo | 02:51 | |
*** noslzzp has joined #tripleo | 02:59 | |
*** tzumainn has quit IRC | 03:01 | |
*** untriaged-bot has joined #tripleo | 03:01 | |
untriaged-bot | No untriaged bugs so far! \o/ | 03:01 |
*** untriaged-bot has quit IRC | 03:01 | |
*** wuhg has joined #tripleo | 03:01 | |
*** rainya has joined #tripleo | 03:04 | |
*** rainya has quit IRC | 03:06 | |
*** rainya has joined #tripleo | 03:09 | |
*** rainya has quit IRC | 03:18 | |
*** rainya has joined #tripleo | 03:23 | |
*** otoolee- is now known as otoolee | 03:25 | |
greghaynes | lifeless: SpamapS Do you know if diskimage-builder patches are actually CI'd or do we have the same issue where we alway do tripleo-ci against dib master | 03:48 |
greghaynes | code and logs make me think we should actually be testing the patch up for review (because we call dib out of /opt/stack/new), but im not seeing something in the logs that *really* should be ther | 03:49 |
*** rushiagr_away is now known as rushiagr | 04:16 | |
*** pradeep1 has joined #tripleo | 04:20 | |
*** pradeep has quit IRC | 04:22 | |
*** pradeep has joined #tripleo | 04:22 | |
*** pradeep1 has quit IRC | 04:24 | |
*** rushiagr is now known as rushiagr_away | 04:31 | |
SpamapS | greghaynes: we do not call pull-tools when ZUUL_REF is present precisely so that we can test patches to dib | 04:39 |
*** pradeep has quit IRC | 04:41 | |
*** rushiagr_away is now known as rushiagr | 04:45 | |
clarkb | spamaps so in my change we an echo to the cleanup that is dying and a set -x neither appear to take affect | 04:46 |
clarkb | * we added an echo | 04:46 |
greghaynes | yea, I read the code as we should be testing head, I was having a hard time reconciling this with the logs | 04:53 |
greghaynes | but ok, sounds like we were on the right page | 04:54 |
greghaynes | clarkb: time to make a bigger explosion in a patch and verify it in the logs? | 04:54 |
clarkb | ya probably | 04:54 |
clarkb | so I am rereading through the code and trap_cleanup is running | 05:05 |
clarkb | however I am attempting to removing the exit handler when exiting cleaning | 05:05 |
clarkb | *exiting cleanly | 05:05 |
clarkb | when trap EXIT is in finish_image that means the ramdisk creation removes the trap_cleanup via trap EXIT | 05:05 |
clarkb | so running the cleanup at all is failing | 05:06 |
*** jml has quit IRC | 05:06 | |
clarkb | heh save_image is just an alias for finish_image... | 05:08 |
*** jml has joined #tripleo | 05:09 | |
*** jtomasek has joined #tripleo | 05:16 | |
clarkb | THERE IS A DIFFERENT CLEANUP! | 05:17 |
* clarkb goes to drink heavily | 05:17 | |
clarkb | greghaynes: I think the issue is we are not calling the correct cleanup | 05:17 |
clarkb | greghaynes: its wants to call the cleanup in ramdisk functions | 05:18 |
clarkb | we are calling cleanup in regular functions | 05:18 |
clarkb | all hell breaks loose when you run the wrong cleanup | 05:18 |
clarkb | and thats it for me | 05:18 |
*** noslzzp has quit IRC | 05:26 | |
greghaynes | clarkb: wow | 05:30 |
greghaynes | So I grepped all over expecting that but guess I missed it :/ | 05:30 |
*** yamahata has joined #tripleo | 05:34 | |
clarkb | so it works today because the cleanup is unset | 05:35 |
clarkb | my change leaves it set and wrong this is called | 05:35 |
*** Andy_Yan has quit IRC | 05:37 | |
*** Andy_Yan has joined #tripleo | 05:52 | |
*** jtomasek has quit IRC | 05:52 | |
*** wuhg has quit IRC | 05:53 | |
*** ccrouch has joined #tripleo | 05:53 | |
*** ccrouch has quit IRC | 05:53 | |
*** ccrouch has joined #tripleo | 05:56 | |
*** jtomasek has joined #tripleo | 05:57 | |
*** ccrouch has quit IRC | 06:00 | |
*** yamahata has quit IRC | 06:00 | |
*** jtomasek has quit IRC | 06:06 | |
*** jerryz has joined #tripleo | 06:27 | |
*** dshulyak_ has joined #tripleo | 06:43 | |
*** Andy_Yan has quit IRC | 07:24 | |
*** zigo has quit IRC | 07:26 | |
*** zigo has joined #tripleo | 07:27 | |
*** jerryz has quit IRC | 07:51 | |
*** pensu has joined #tripleo | 08:01 | |
*** dshulyak_ has quit IRC | 08:04 | |
*** killer_prince has joined #tripleo | 08:07 | |
*** lazy_prince has quit IRC | 08:10 | |
*** killer_prince is now known as lazy_prince | 08:10 | |
*** yamahata has joined #tripleo | 08:12 | |
*** akuznetsov has joined #tripleo | 08:12 | |
*** akuznetsov has quit IRC | 08:32 | |
*** jang2 has joined #tripleo | 08:32 | |
*** pensu has quit IRC | 08:32 | |
*** untriaged-bot has joined #tripleo | 09:01 | |
untriaged-bot | No untriaged bugs so far! \o/ | 09:01 |
*** untriaged-bot has quit IRC | 09:01 | |
*** yamahata has quit IRC | 09:28 | |
*** akuznetsov has joined #tripleo | 09:32 | |
*** ramishra has joined #tripleo | 09:34 | |
*** akuznetsov has quit IRC | 09:44 | |
*** pensu has joined #tripleo | 09:48 | |
*** ramishra has quit IRC | 09:52 | |
*** dshulyak_ has joined #tripleo | 09:53 | |
*** dshulyak_ has quit IRC | 10:41 | |
*** pensu has quit IRC | 10:42 | |
*** lazy_prince has quit IRC | 10:43 | |
*** pensu has joined #tripleo | 10:54 | |
*** jpeeler has quit IRC | 10:58 | |
*** killer_prince has joined #tripleo | 11:08 | |
*** killer_prince is now known as lazy_prince | 11:09 | |
*** jtomasek has joined #tripleo | 11:12 | |
*** jang2 has quit IRC | 11:19 | |
*** lazy_prince has quit IRC | 11:22 | |
*** killer_prince has joined #tripleo | 11:32 | |
*** killer_prince is now known as lazy_prince | 11:32 | |
*** jtomasek has quit IRC | 11:41 | |
*** pensu has quit IRC | 11:42 | |
*** weshay has quit IRC | 11:54 | |
*** jang2 has joined #tripleo | 12:05 | |
*** rhallisey has quit IRC | 12:12 | |
*** rhallisey has joined #tripleo | 12:18 | |
*** lazy_prince has quit IRC | 12:34 | |
*** killer_prince has joined #tripleo | 12:42 | |
*** killer_prince is now known as lazy_prince | 12:42 | |
*** noslzzp has joined #tripleo | 12:51 | |
*** openstackgerrit has joined #tripleo | 13:01 | |
*** ccrouch has joined #tripleo | 13:13 | |
*** ramishra has joined #tripleo | 13:17 | |
*** lazy_prince has quit IRC | 13:21 | |
*** killer_prince has joined #tripleo | 13:23 | |
*** killer_prince is now known as lazy_prince | 13:23 | |
*** lazy_prince has quit IRC | 13:30 | |
*** jtomasek has joined #tripleo | 13:32 | |
*** dsneddon_ has quit IRC | 14:06 | |
*** dsneddon_ has joined #tripleo | 14:08 | |
*** noslzzp has quit IRC | 14:24 | |
*** akuznetsov has joined #tripleo | 14:29 | |
*** yamahata has joined #tripleo | 14:39 | |
*** rainya has joined #tripleo | 14:42 | |
*** rainya has quit IRC | 14:42 | |
*** dsneddon_ has quit IRC | 14:48 | |
*** rainya has joined #tripleo | 14:48 | |
*** dsneddon_ has joined #tripleo | 14:49 | |
*** untriaged-bot has joined #tripleo | 15:01 | |
untriaged-bot | No untriaged bugs so far! \o/ | 15:01 |
*** untriaged-bot has quit IRC | 15:01 | |
*** mugsie has quit IRC | 15:05 | |
*** ramishra has quit IRC | 15:30 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/os-apply-config: Updated from global requirements https://review.openstack.org/127770 | 15:55 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/os-cloud-config: Updated from global requirements https://review.openstack.org/127771 | 15:55 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/os-collect-config: Updated from global requirements https://review.openstack.org/120606 | 15:55 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/os-refresh-config: Updated from global requirements https://review.openstack.org/127772 | 15:55 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-tuskarclient: Updated from global requirements https://review.openstack.org/126684 | 15:56 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/tuskar: Updated from global requirements https://review.openstack.org/122674 | 15:57 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/127799 | 15:57 |
*** Dafna has quit IRC | 16:11 | |
*** pensu has joined #tripleo | 16:38 | |
*** rainya has quit IRC | 17:00 | |
*** dsneddon_ has quit IRC | 17:14 | |
*** dsneddon_ has joined #tripleo | 17:16 | |
*** yamahata has quit IRC | 17:41 | |
*** rainya has joined #tripleo | 17:46 | |
*** jsidhu has joined #tripleo | 18:39 | |
*** jsidhu has quit IRC | 18:52 | |
*** jml has quit IRC | 19:14 | |
*** jml has joined #tripleo | 19:17 | |
*** rhallisey has quit IRC | 20:42 | |
*** marun has joined #tripleo | 20:57 | |
*** untriaged-bot has joined #tripleo | 21:00 | |
untriaged-bot | No untriaged bugs so far! \o/ | 21:00 |
*** untriaged-bot has quit IRC | 21:00 | |
*** akuznetsov has quit IRC | 21:06 | |
*** akuznetsov has joined #tripleo | 21:07 | |
*** akuznetsov has quit IRC | 21:07 | |
*** rushiagr is now known as rushiagr_away | 21:08 | |
*** dsneddon_ has quit IRC | 22:02 | |
*** dsneddon_ has joined #tripleo | 22:04 | |
*** rainya has quit IRC | 22:15 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/os-cloud-config: Updated from global requirements https://review.openstack.org/127771 | 22:37 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/os-collect-config: Updated from global requirements https://review.openstack.org/120606 | 22:37 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-tuskarclient: Updated from global requirements https://review.openstack.org/126684 | 22:38 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/tuskar: Updated from global requirements https://review.openstack.org/122674 | 22:38 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/127799 | 22:38 |
*** pensu has quit IRC | 22:41 | |
*** pcrews has joined #tripleo | 22:54 | |
*** jang2 has quit IRC | 22:57 | |
*** pcrews has quit IRC | 23:06 | |
*** dsneddon_ has quit IRC | 23:08 | |
*** dsneddon_ has joined #tripleo | 23:10 | |
*** jml has quit IRC | 23:27 | |
*** jml has joined #tripleo | 23:30 | |
*** jml has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!