| *** bhagyashris has joined #tacker | 01:54 | |
| *** janki has joined #tacker | 05:08 | |
| *** dkushwaha has joined #tacker | 05:31 | |
| *** dkushwaha has quit IRC | 05:42 | |
| *** dkushwaha has joined #tacker | 05:42 | |
| *** sm806 has quit IRC | 06:17 | |
| *** sm806 has joined #tacker | 06:18 | |
| *** sm806 has quit IRC | 06:31 | |
| *** sm806 has joined #tacker | 06:31 | |
| *** hyunsikyang has quit IRC | 06:42 | |
| *** hyunsikyang has joined #tacker | 06:42 | |
| *** joxyuki_ has joined #tacker | 07:40 | |
| dkushwaha | Dear all, Do we have some specific topic for today meeting? | 08:03 |
|---|---|---|
| dkushwaha | otherwise we can skip it for today and will continue on this channel | 08:04 |
| shubham_potale | dkushwaha: hi | 08:07 |
| dkushwaha | shubham_potale, hello | 08:07 |
| shubham_potale | dkushwaha: Just wanted to review https://review.openstack.org/#/c/622888/ reservation patch | 08:08 |
| *** JangwonLee has quit IRC | 08:09 | |
| *** tpatil_ has joined #tacker | 08:09 | |
| dkushwaha | shubham_potale, do you want to review that patch ? | 08:10 |
| tpatil_ | dkushwaha: Hi | 08:10 |
| dkushwaha | please go ehead | 08:10 |
| dkushwaha | ahead | 08:10 |
| dkushwaha | tpatil_, hi | 08:10 |
| tpatil_ | dkushwaha: would like to discuss about patch https://review.openstack.org/#/c/639621/ | 08:11 |
| tpatil_ | dkushwaha: since the functional tests are running with concurrency 2, sometimes the tests might be skipped | 08:11 |
| dkushwaha | tpatil_, ok, let it it be rechecked then | 08:12 |
| tpatil_ | dkushwaha: If we change concurrency to 1, the execution time would increase which is not a good thing to do | 08:12 |
| tpatil_ | dkushwaha: you can noticed that on PS2, reservation tests are passing | 08:13 |
| tpatil_ | dkushwaha: http://logs.openstack.org/21/639621/2/check/tacker-functional-devstack-multinode-python3/171f9ac/testr_results.html.gz | 08:13 |
| tpatil_ | dkushwaha: passing on py35, skipped on py27 | 08:14 |
| dkushwaha | tpatil_, i see. looks fine then | 08:14 |
| shubham_potale | dkushwaha: i want to discuss about the test cases for openstack module. | 08:15 |
| tpatil_ | dkushwaha: Good to hear that | 08:15 |
| dkushwaha | tpatil_, let me go through one more time, and if ok then i will merge it | 08:16 |
| shubham_potale | dkushwaha:I am writing unit test cases for openstack module, from this module many calls going to the heat-client for that I am mocking lot of stuff of heat-client.py module, so instead of mocking this is it ok to write fixtures for heat-client?. I have taken the refference of novaclient fixtures, and created heat-client fixture. also tried two sample test cases for openstack module and it is working fine. I want to conform | 08:16 |
| tpatil_ | dkushwaha: Sure, Thank you | 08:17 |
| dkushwaha | shubham_potale, I think creating a fixer would be a good approach. | 08:19 |
| dkushwaha | shubham_potale, have you your patch link? | 08:19 |
| dkushwaha | I mean, is it submitted ? | 08:20 |
| shubham_potale | dkushwaha:no it is not in community gerrit. | 08:20 |
| dkushwaha | shubham_potale,ok | 08:21 |
| shubham_potale | dkushwaha: Thanks for your conformation regarding approach. after local review I will submit it to community. | 08:22 |
| *** JangwonLee has joined #tacker | 08:23 | |
| dkushwaha | shubham_potale, np | 08:23 |
| *** tpatil_ has quit IRC | 08:37 | |
| *** bhagyashris has quit IRC | 09:38 | |
| *** janki has quit IRC | 11:22 | |
| *** openstackgerrit has joined #tacker | 11:48 | |
| openstackgerrit | Merged openstack/tacker master: Add reservation support https://review.openstack.org/622888 | 11:48 |
| openstackgerrit | Merged openstack/tacker master: Add functional test for reservation support https://review.openstack.org/639621 | 11:49 |
| *** sm806 has quit IRC | 12:33 | |
| *** joxyuki_ has quit IRC | 12:33 | |
| *** sm806 has joined #tacker | 12:34 | |
| *** janki has joined #tacker | 13:17 | |
| *** sm806 has quit IRC | 13:31 | |
| *** sm806 has joined #tacker | 13:32 | |
| *** janki has quit IRC | 14:12 | |
| *** janki has joined #tacker | 14:12 | |
| *** openstackgerrit has quit IRC | 15:28 | |
| *** sm806 has quit IRC | 15:39 | |
| *** sm806 has joined #tacker | 15:40 | |
| *** janki has quit IRC | 16:41 | |
| *** janki has joined #tacker | 16:41 | |
| -openstackstatus- NOTICE: Gerrit is being restarted for a configuration change, it will be briefly offline. | 17:12 | |
| *** sm806 has quit IRC | 19:27 | |
| *** sm806 has joined #tacker | 19:27 | |
| *** janki has quit IRC | 21:29 | |
| *** binh_ has quit IRC | 22:55 | |
| *** binh_ has joined #tacker | 22:55 | |
| *** hyunsikyang has quit IRC | 23:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!