| *** bhagyashris has joined #tacker | 01:13 | |
| *** Dinesh_Bhor has joined #tacker | 01:48 | |
| *** bhagyashris has quit IRC | 03:34 | |
| *** bobh has quit IRC | 04:19 | |
| *** bobh has joined #tacker | 04:21 | |
| *** bobh has quit IRC | 04:26 | |
| *** bobh has joined #tacker | 04:35 | |
| *** bobh has quit IRC | 04:40 | |
| *** bobh has joined #tacker | 05:32 | |
| *** bobh has quit IRC | 05:36 | |
| *** openstackgerrit has joined #tacker | 06:41 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker master: Enable skipped test cases for context https://review.openstack.org/633878 | 06:41 |
|---|---|---|
| *** phuochc has joined #tacker | 07:08 | |
| *** phuoc has quit IRC | 07:08 | |
| *** phuochoang has joined #tacker | 07:09 | |
| *** phuochc has quit IRC | 07:13 | |
| *** bobh has joined #tacker | 07:19 | |
| *** bobh has quit IRC | 07:24 | |
| *** bhagyashris has joined #tacker | 08:07 | |
| *** Dinesh_Bhor has quit IRC | 08:44 | |
| *** Dinesh_Bhor has joined #tacker | 08:44 | |
| *** bobh has joined #tacker | 08:47 | |
| *** bobh has quit IRC | 08:51 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker master: Move to use only kestone v3 api https://review.openstack.org/632725 | 09:23 |
| *** janki has joined #tacker | 09:29 | |
| *** bhagyashris has quit IRC | 09:32 | |
| openstackgerrit | Shubham Potale proposed openstack/tacker master: Improve code coverage of plugin module https://review.openstack.org/634188 | 09:32 |
| *** bobh has joined #tacker | 09:59 | |
| *** bobh has quit IRC | 10:04 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker master: Parameter changed from mgmt_url to mgmt_ip_address https://review.openstack.org/490471 | 10:08 |
| *** Dinesh_Bhor has quit IRC | 10:54 | |
| *** bobh has joined #tacker | 11:00 | |
| *** bobh has quit IRC | 11:05 | |
| *** janki has quit IRC | 11:51 | |
| *** nguyenhai has quit IRC | 11:56 | |
| *** nguyenhai has joined #tacker | 11:56 | |
| *** nguyenhai has quit IRC | 12:00 | |
| *** nguyenhai has joined #tacker | 12:00 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker master: [TrivialFix]: Improve exception handling. https://review.openstack.org/634217 | 12:32 |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker-horizon master: fix tox python3 overrides https://review.openstack.org/606727 | 13:02 |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker-horizon master: update python version in setup.cfg https://review.openstack.org/617096 | 13:05 |
| *** shubham_potale has joined #tacker | 13:09 | |
| *** bobh has joined #tacker | 13:19 | |
| shubham_potale | dkushwaha:Hi | 13:49 |
| dkushwaha | shubham_potale, hi | 13:49 |
| shubham_potale | want to discuss regarding review comments on https://review.openstack.org/#/c/634188/1/tacker/tests/unit/vnfm/test_plugin.py | 13:50 |
| shubham_potale | I am not clear about second comment "where is Exception" | 13:50 |
| dkushwaha | In Line#61, Exception class is used, but I could not see where is imported | 13:51 |
| dkushwaha | shubham_potale, i might be overlooked it, just realized it would be python standard class. | 13:54 |
| shubham_potale | yes | 13:54 |
| dkushwaha | On the other hand you can also use object only. i.e class MyException(object) | 13:55 |
| dkushwaha | both should be fine | 13:55 |
| shubham_potale | ok ....for first review comment is it ok to change name from MyException to FakeHeatClientException | 13:56 |
| dkushwaha | shubham_potale, you can also just use "FakeException" only | 13:58 |
| shubham_potale | ok thank you | 13:58 |
| *** bobh has quit IRC | 14:18 | |
| openstackgerrit | Shubham Potale proposed openstack/tacker master: Improve code coverage of plugin module https://review.openstack.org/634188 | 14:25 |
| nnsingh | review request https://review.openstack.org/#/c/622888/ | 14:39 |
| *** bobh has joined #tacker | 14:58 | |
| *** bobh has quit IRC | 17:39 | |
| *** bobh has joined #tacker | 17:45 | |
| *** bobh has quit IRC | 18:11 | |
| *** bobh has joined #tacker | 19:29 | |
| *** bobh has quit IRC | 19:43 | |
| *** bobh has joined #tacker | 20:07 | |
| *** bobh has quit IRC | 20:39 | |
| *** bobh has joined #tacker | 20:54 | |
| *** bobh has quit IRC | 21:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!