*** longkb has joined #tacker | 00:44 | |
*** Dinesh_Bhor has joined #tacker | 01:01 | |
*** gongysh has joined #tacker | 01:35 | |
*** links has joined #tacker | 02:30 | |
*** links has quit IRC | 02:30 | |
openstackgerrit | Cong Phuoc Hoang proposed openstack/tacker master: Implement VNFFG support for NS https://review.openstack.org/558166 | 02:54 |
---|---|---|
openstackgerrit | Cong Phuoc Hoang proposed openstack/python-tackerclient master: Add 'vnf_ids' and 'vnffg_id' in network service list command https://review.openstack.org/578638 | 02:59 |
*** joxyuki has joined #tacker | 04:53 | |
*** janki has joined #tacker | 05:00 | |
*** gongysh has quit IRC | 05:06 | |
*** gongysh has joined #tacker | 05:31 | |
*** openstackgerrit has quit IRC | 05:34 | |
*** openstackstatus has quit IRC | 05:51 | |
*** openstackstatus has joined #tacker | 05:54 | |
*** ChanServ sets mode: +v openstackstatus | 05:54 | |
*** egonzalez has joined #tacker | 05:57 | |
*** openstackgerrit has joined #tacker | 06:06 | |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 06:06 |
openstackgerrit | wu.chunyang proposed openstack/python-tackerclient master: Add release note link in README https://review.openstack.org/578690 | 06:11 |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 07:07 |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 07:08 |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 07:09 |
*** akozhevnikov has joined #tacker | 07:59 | |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 08:29 |
*** joxyuki has quit IRC | 08:54 | |
*** akozhevnikov has quit IRC | 09:26 | |
*** nitesh has joined #tacker | 09:30 | |
*** Dinesh_Bhor has quit IRC | 09:34 | |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 09:38 |
*** gongysh has quit IRC | 10:52 | |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 10:52 |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 11:03 |
*** nitesh has quit IRC | 11:32 | |
*** nitesh has joined #tacker | 11:33 | |
*** gongysh has joined #tacker | 11:36 | |
nitesh | gongysh: Hi | 11:37 |
gongysh | hi | 11:37 |
nitesh | gongysh: Would you please review the patch >> https://review.openstack.org/#/c/570337/ | 11:38 |
gongysh | nitesh, I have reviewed | 11:39 |
gongysh | did you see my comment? | 11:39 |
nitesh | gongysh : Yes we require that software i have referred at >> https://review.openstack.org/#/c/571633/3/tacker/tests/unit/api/v1/test_vim.py@130 | 11:42 |
gongysh | commented | 11:44 |
*** ShilpaSD has joined #tacker | 11:45 | |
nitesh | gongysh: I have seen your comment , if ddt is not used will have to add test case of each condition. Are you suggesting me to have four different test cases\ | 11:48 |
gongysh | besides https://review.openstack.org/#/c/571633/3/tacker/tests/unit/api/v1/test_vim.py@130, where it is used? | 11:49 |
gongysh | nitesh, ok | 11:50 |
gongysh | but why not change the test-requirement.txt at https://review.openstack.org/#/c/571633? | 11:50 |
nitesh | gongysh: I referred it here too >> https://review.openstack.org/#/c/570337/5/tacker/tests/unit/api/v1/test_vim.py@114 | 11:50 |
openstackgerrit | Eduardo Gonzalez proposed openstack/tacker master: WIP: Add multinode jobs https://review.openstack.org/578170 | 11:52 |
nitesh | gongysh: Because >> https://review.openstack.org/#/c/571633 is the child patch depended on >> https://review.openstack.org/#/c/570337 where i have made the required changes in the test-requirements.txt | 11:53 |
gongysh | make sense | 11:56 |
gongysh | done | 11:56 |
nitesh | gongysh: Thank you for reviewing:) | 11:57 |
nitesh | gongysh: Now will my patches get merged | 11:58 |
openstackgerrit | Merged openstack/tacker master: VIM should accept valid boolean values for is_default https://review.openstack.org/570337 | 12:24 |
openstackgerrit | Merged openstack/tacker master: Validate type parameter for empty string https://review.openstack.org/571633 | 12:24 |
*** longkb has quit IRC | 12:30 | |
*** longkb has joined #tacker | 13:51 | |
*** bobh has joined #tacker | 13:59 | |
*** longkb has quit IRC | 14:34 | |
*** gongysh has quit IRC | 15:00 | |
*** egonzalez has quit IRC | 15:01 | |
*** bobh has quit IRC | 15:07 | |
*** bobh has joined #tacker | 16:08 | |
*** longkb has joined #tacker | 16:17 | |
*** janki has quit IRC | 16:25 | |
*** longkb has quit IRC | 16:26 | |
*** raopajay has quit IRC | 16:26 | |
*** bobh_ has joined #tacker | 17:23 | |
*** bobh has quit IRC | 17:23 | |
*** phuoc_ has joined #tacker | 17:26 | |
*** phuoc has quit IRC | 17:29 | |
*** bobh_ has quit IRC | 17:33 | |
*** bobh has joined #tacker | 17:33 | |
*** bobh_ has joined #tacker | 17:33 | |
*** bobh has quit IRC | 17:38 | |
*** ShilpaD has joined #tacker | 18:44 | |
*** ShilpaSD has quit IRC | 18:48 | |
*** ShilpaSD has joined #tacker | 18:51 | |
*** ShilpaD has quit IRC | 18:54 | |
*** bobh_ has quit IRC | 19:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!