*** trinaths1 has joined #tacker | 00:11 | |
*** uck has quit IRC | 00:15 | |
*** bobh has joined #tacker | 00:16 | |
*** Aqsa has quit IRC | 00:18 | |
openstackgerrit | Merged openstack/tacker master: Update cirros image to 0.3.5 disk image in sample files https://review.openstack.org/447471 | 00:29 |
---|---|---|
openstackgerrit | Merged openstack/tacker master: Provide a tool to generate a VNFC image https://review.openstack.org/445848 | 00:38 |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 00:58 |
*** gongysh has joined #tacker | 01:33 | |
*** s3wong has quit IRC | 01:43 | |
*** trinaths1 has left #tacker | 02:00 | |
*** KanagarajM has joined #tacker | 02:08 | |
*** vishnoianil has quit IRC | 02:13 | |
*** bobh has quit IRC | 02:13 | |
*** KanagarajM has quit IRC | 02:23 | |
*** tbachman has quit IRC | 02:26 | |
*** xianghui has joined #tacker | 02:34 | |
*** bobh has joined #tacker | 02:35 | |
*** bobh has quit IRC | 03:00 | |
*** links has joined #tacker | 03:12 | |
*** links has quit IRC | 03:38 | |
*** links has joined #tacker | 03:52 | |
*** diga has joined #tacker | 04:01 | |
*** Zhou_Zhihong has joined #tacker | 04:06 | |
*** diga has quit IRC | 04:18 | |
*** diga has joined #tacker | 04:18 | |
*** links has quit IRC | 04:33 | |
sridhar_ram | gongysh: ping, tacker meeting time? | 04:35 |
gongysh | it is not one hour later? | 04:35 |
sridhar_ram | gongysh: oops, daylight saving .. duh | 04:35 |
gongysh | so what is the time over there now? | 04:36 |
*** links has joined #tacker | 04:49 | |
*** tbachman has joined #tacker | 05:00 | |
*** trinaths has joined #tacker | 05:01 | |
*** YanXing_an has joined #tacker | 05:03 | |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 05:05 |
*** KanagarajM has joined #tacker | 05:17 | |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 05:24 |
*** tbh has joined #tacker | 05:28 | |
gongysh | one minute to meeting channel | 05:29 |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 05:58 |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 06:24 |
*** mohankumar has joined #tacker | 06:30 | |
sridhar_ram | trinaths: there is already a partial effort on osc .. we can start from there | 06:30 |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 06:30 |
trinaths | sridhar_ram: oh okay can you please point me the commit. | 06:32 |
sridhar_ram | trinaths: https://review.openstack.org/#/c/374715/ | 06:32 |
sridhar_ram | trinaths: https://blueprints.launchpad.net/tacker/+spec/tacker-openstackclient-plugin | 06:33 |
trinaths | sridhar_ram: okay. thank you. | 06:33 |
sridhar_ram | trinaths: urw | 06:33 |
* sridhar_ram signing off for the evening | 06:33 | |
gongysh | sridhar_ram, good night. | 06:34 |
gongysh | KanagarajM hi | 06:34 |
trinaths | sridhar_ram: is mox->mock fix dependant on this osc fix ? | 06:34 |
sridhar_ram | trinaths: it shouldn't | 06:35 |
gongysh | trinaths, not | 06:35 |
sridhar_ram | gongysh: thanks | 06:35 |
openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 06:35 |
trinaths | sridhar_ram: okay. | 06:35 |
*** tung_doan_ has quit IRC | 06:48 | |
*** YanXing_an has left #tacker | 06:55 | |
tbh | sridhar_ram, https://review.openstack.org/#/c/438211/ ccan you please review? | 07:08 |
tbh | dkushwaha, ^^ | 07:08 |
KanagarajM | gongysh, hi | 07:15 |
gongysh | KanagarajM, hi | 07:15 |
*** bobmel has joined #tacker | 07:15 | |
gongysh | about the unique index name, https://review.openstack.org/#/c/439719/ | 07:16 |
KanagarajM | gongysh, is the format used for name of index is importnat | 07:17 |
gongysh | KanagarajM, yes. with this, DuplicateEntry exception will contain the columns of the index, so we can tell which unique index the code is touching. | 07:18 |
*** xianghui has quit IRC | 07:18 | |
KanagarajM | i try to test the code using tacker command it was working. so let me know if we need to really change the naming format | 07:18 |
gongysh | KanagarajM, Yes, I know the code can work. but we can make it more robust. | 07:19 |
gongysh | to think about too unique index on one table. | 07:19 |
KanagarajM | gongysh, you mean, the index name should be part of the DuplicateEntry exception ? | 07:19 |
gongysh | how do you tell which unique index you are working on if DuplicateEntry happens? | 07:20 |
*** bobmel has quit IRC | 07:20 | |
KanagarajM | which i observed while testing. but i skippe the index name in DuplicateEntry exception as its internal and user should not be known about it | 07:20 |
gongysh | I don't think the index name will be there, but the columns will be in DuplicateEntry. | 07:20 |
gongysh | KanagarajM, you can check the columns in DuplicateEntry object. | 07:21 |
KanagarajM | DuplicateEntry already having the column names | 07:21 |
*** diga has quit IRC | 07:21 | |
KanagarajM | its DuplicateEntity and i already added required column name with values | 07:21 |
gongysh | KanagarajM, but you did not check it all: https://review.openstack.org/#/c/439719/8/tacker/db/vnfm/vnfm_db.py | 07:22 |
KanagarajM | ok i got what do you mean ..... you want to capture the message from the sqlalchmy eception and put them in the DuplicateEntity execption | 07:23 |
KanagarajM | i will give anoth patch with this change. thanks gongysh | 07:23 |
gongysh | the standard way is: name the index with uniq_<tablename>0column10column2 | 07:24 |
gongysh | and then to tell DuplicateEntity contains just column1 and column2 . | 07:25 |
gongysh | KanagarajM, we just need to abide by the practice here. | 07:25 |
*** Zhou_Zhihong has quit IRC | 07:26 | |
KanagarajM | gongysh, you mean, the column values are not required to be reported in the DuplicateEntity, just colum names are sufficient ? | 07:27 |
KanagarajM | but with values it would be more evident for user to understand. | 07:28 |
gongysh | I means: use column names to tell the DuplicateEntity exception is for your index, not others. | 07:28 |
gongysh | system may have many unique index on a table. | 07:29 |
KanagarajM | but same has been reproted to user | 07:29 |
gongysh | except DBDuplicateEntry: | 07:30 |
gongysh | raise exceptions.DuplicateEntity( | 07:30 |
gongysh | _type="nsd", | 07:30 |
gongysh | entry=dict(name=vnfd.get('name'), | 07:30 |
gongysh | tenant_id=tenant_id)) | 07:30 |
gongysh | for example. this is for name and tenant_id duplication. | 07:30 |
KanagarajM | yes, i tried to keep them like this so that its useful info to user. | 07:30 |
gongysh | if I need to add one more unique index on nsd table for example, "descript" and 'id' , what do you do? | 07:31 |
gongysh | this time, we should tell user, the id and descri is duplicated. | 07:32 |
gongysh | not name and tenant_id. | 07:32 |
KanagarajM | exactly that is what missing, we will get the list of column names from the DBDuplicateEntry and pass it to DuplicateEntity | 07:32 |
KanagarajM | i will add them in the next patch as mentioned earlier :) | 07:33 |
gongysh | and also to change the index name please. | 07:33 |
gongysh | this is openstack way. | 07:33 |
KanagarajM | sure. ok | 07:34 |
gongysh | trinaths, https://bugs.launchpad.net/python-tackerclient/+bug/1674906 | 07:53 |
openstack | Launchpad bug 1674906 in python-tackerclient "failed to update is-default attribute of vim" [Undecided,New] | 07:53 |
trinaths | gongysh: ok. looking into it | 07:59 |
trinaths | gongysh: when can --config-file be enforced? | 08:00 |
gongysh | just make them all optional. | 08:00 |
trinaths | gongysh: ok | 08:01 |
gongysh | and have a functional test. | 08:01 |
gongysh | if server reports error, file bug on tacker server. | 08:01 |
gongysh | thanks | 08:01 |
*** Aqsa has joined #tacker | 08:01 | |
trinaths | gongysh: ok | 08:01 |
trinaths | gongysh: for all the commands or only vim based commands? | 08:05 |
gongysh | trinaths, only vim-update | 08:05 |
trinaths | gongysh: ok | 08:06 |
*** diga has joined #tacker | 08:06 | |
*** amotoki has joined #tacker | 08:20 | |
trinaths | gongysh: as I see the code, --config-file is the keystone based file. | 08:41 |
trinaths | gongysh: with all auth credentials. | 08:41 |
gongysh | yes | 08:42 |
trinaths | gongysh: dont we need that file while updating the vim info ? | 08:42 |
gongysh | trinaths, we can just update name, description | 08:43 |
gongysh | or something | 08:43 |
trinaths | gongysh: agree. but with all those params, config-file with keystone credentails is required. | 08:45 |
gongysh | trinaths, why? | 08:46 |
trinaths | gongysh: since those credentials are used to authenticate at server and update the data. | 08:46 |
trinaths | gongysh: see, def args2body_vim at v1_0/nfvo/vim_utils.py | 08:47 |
gongysh | trinaths, I know, you can pass that if user not pass in config-file | 08:49 |
gongysh | this is just for target vim, not the tacker's credential. | 08:49 |
trinaths | gongysh: ok | 08:50 |
*** trinaths has left #tacker | 09:15 | |
openstackgerrit | gongysh proposed openstack/tacker master: Continue to avoid temporary connection error to target VIM https://review.openstack.org/448466 | 09:31 |
openstackgerrit | gongysh proposed openstack/tacker master: Continue to avoid temporary connection error to target VIM https://review.openstack.org/448466 | 09:34 |
*** gongysh has quit IRC | 09:36 | |
diga | hi | 09:49 |
openstackgerrit | Merged openstack/tacker master: Access the controller's mistral endpoint instead of VIM https://review.openstack.org/438211 | 10:33 |
*** tbh has quit IRC | 11:40 | |
*** gongysh has joined #tacker | 11:49 | |
openstackgerrit | gongysh proposed openstack/tacker master: move the left cirros 3.4 into 3.5 disk image https://review.openstack.org/448527 | 11:57 |
*** trinaths has joined #tacker | 11:58 | |
trinaths | gongysh: hi | 12:08 |
gongysh | hi | 12:09 |
trinaths | gongysh: wrt to your comments, at test_shell.py, I get a mispatch while I give the arguments. http://paste.openstack.org/show/603745/ so I'm assertig whether the function itself is called or not | 12:09 |
trinaths | gongysh: auth and session params | 12:09 |
trinaths | gongysh: in the actual call. | 12:10 |
trinaths | s/mispatch/mismatch/ | 12:11 |
gongysh | trinaths, show me the code position | 12:12 |
gongysh | or your code | 12:13 |
trinaths | gongysh: my code, http://paste.openstack.org/show/603748/ | 12:13 |
trinaths | gongysh: this works well, http://paste.openstack.org/show/603749/ | 12:15 |
trinaths | gongysh: without args | 12:15 |
gongysh | trinaths, without args, the test does not make sense. | 12:16 |
trinaths | gongysh: agreed. but how to generate auth and session ? | 12:18 |
gongysh | that is easy. the auth and session is not the main role. so you can just use mock.ANY | 12:19 |
trinaths | gongysh: agree. with too I get this error. http://paste.openstack.org/show/603750/ | 12:21 |
gongysh | trinaths, pleas compare two, you should add some in expected part. | 12:23 |
trinaths | gongysh: yes, auth and session | 12:25 |
trinaths | gongysh: auth and session traceable in expected call | 12:29 |
trinaths | gongysh: got a fix. | 12:30 |
trinaths | gongysh: let me test that and get back to you | 12:31 |
gongysh | dkushwaha, hi | 12:33 |
*** tbachman has left #tacker | 13:06 | |
openstackgerrit | gongysh proposed openstack/tacker master: Continue waiting to avoid temporary connection error with target VIM https://review.openstack.org/448466 | 13:24 |
*** janki has joined #tacker | 13:31 | |
*** jchhatbar has joined #tacker | 13:34 | |
*** gongysh has quit IRC | 13:35 | |
*** janki has quit IRC | 13:38 | |
*** KanagarajM has quit IRC | 13:41 | |
*** jchhatbar has quit IRC | 13:47 | |
*** janki has joined #tacker | 13:48 | |
openstackgerrit | gongysh proposed openstack/tacker master: Continue waiting to avoid temporary connection error with target VIM https://review.openstack.org/448466 | 13:50 |
*** luisnho223 has joined #tacker | 14:01 | |
luisnho223 | hi everyone. Im new to tacker and i have some doubts. I just installed devstack with tacker and i want to connect net0, net1 and net_management to my private network that i created | 14:03 |
luisnho223 | It is needed to launch VNF instances? | 14:03 |
*** bobh has joined #tacker | 14:03 | |
*** bobh has quit IRC | 14:04 | |
*** bobh has joined #tacker | 14:04 | |
*** Aqsa has quit IRC | 14:05 | |
*** Aqsa has joined #tacker | 14:08 | |
openstackgerrit | gongysh proposed openstack/tacker master: Put vnfm cases into discovered case list https://review.openstack.org/448601 | 14:16 |
*** diga has quit IRC | 14:20 | |
*** links has quit IRC | 14:21 | |
*** trinaths has left #tacker | 14:23 | |
openstackgerrit | gongysh proposed openstack/tacker master: Continue waiting to avoid temporary connection error with target VIM https://review.openstack.org/448466 | 14:24 |
luisnho223 | hi everyone. Im new to tacker and i have some doubts. I just installed devstack with tacker and i want to connect net0, net1 and net_management to my private network that i created. It is needed to launch VNF instances? | 14:26 |
*** janki has quit IRC | 14:41 | |
*** Aqsa has quit IRC | 15:15 | |
*** bobmel_ has joined #tacker | 15:37 | |
*** Aqsa has joined #tacker | 16:15 | |
*** Aqsam has joined #tacker | 16:16 | |
*** luisnho223 has quit IRC | 16:17 | |
*** Aqsa has quit IRC | 16:19 | |
*** tbh has joined #tacker | 16:21 | |
*** bobmel has joined #tacker | 16:46 | |
*** links has joined #tacker | 16:48 | |
*** bobmel_ has quit IRC | 16:50 | |
*** uck has joined #tacker | 16:52 | |
*** bobmel has quit IRC | 17:00 | |
*** uck_ has joined #tacker | 17:21 | |
*** uck has quit IRC | 17:21 | |
*** links has quit IRC | 17:39 | |
*** uck_ has quit IRC | 18:04 | |
*** uck has joined #tacker | 18:04 | |
*** trinaths has joined #tacker | 18:18 | |
*** bobmel has joined #tacker | 18:34 | |
*** bobmel has quit IRC | 18:34 | |
*** bobmel has joined #tacker | 18:34 | |
*** uck_ has joined #tacker | 18:49 | |
*** uck has quit IRC | 18:49 | |
*** vishnoianil has joined #tacker | 18:49 | |
*** Aqsam has quit IRC | 18:55 | |
*** bobmel has quit IRC | 19:33 | |
*** trinaths has left #tacker | 19:43 | |
*** Aqsa has joined #tacker | 19:51 | |
*** uck_ has quit IRC | 19:56 | |
*** tbh has quit IRC | 20:12 | |
*** vishwanathj has quit IRC | 20:18 | |
*** vishwanathj has joined #tacker | 20:18 | |
*** uck has joined #tacker | 20:19 | |
*** bobmel has joined #tacker | 20:34 | |
*** bobmel has quit IRC | 20:39 | |
*** Aqsa has quit IRC | 21:08 | |
*** bobmel has joined #tacker | 21:35 | |
*** bobmel has quit IRC | 21:40 | |
*** Aqsa has joined #tacker | 21:43 | |
*** bobmel has joined #tacker | 21:46 | |
*** bobmel has quit IRC | 21:51 | |
*** uck has quit IRC | 22:40 | |
*** uck has joined #tacker | 22:40 | |
*** bobmel has joined #tacker | 22:47 | |
*** bobmel has quit IRC | 22:52 | |
*** Aqsa has quit IRC | 23:10 | |
*** bobh has quit IRC | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!