dkushwaha | sridhar_ram, Sorry. I missed the meeting again. | 00:09 |
---|---|---|
sridhar_ram | dkushwaha: np, i know it is in an odd time for ur tz | 00:09 |
dkushwaha | sridhar_ram, :( | 00:10 |
dkushwaha | sridhar_ram, could you please have a look in https://review.openstack.org/#/c/351242/ | 00:12 |
*** sripriya has quit IRC | 00:26 | |
*** sripriya has joined #tacker | 00:50 | |
*** uck has quit IRC | 00:51 | |
*** uck has joined #tacker | 00:52 | |
*** arturt__ has quit IRC | 00:55 | |
*** arturt__ has joined #tacker | 00:55 | |
*** uck has quit IRC | 00:56 | |
*** arturt__ has quit IRC | 00:59 | |
*** bobh has joined #tacker | 01:03 | |
*** yifei has joined #tacker | 01:06 | |
*** bobh has quit IRC | 01:06 | |
*** bobh has joined #tacker | 01:06 | |
*** bobh has quit IRC | 01:06 | |
*** prashantD_ has joined #tacker | 01:10 | |
*** prashantD has quit IRC | 01:11 | |
openstackgerrit | dharmendra kushwaha proposed openstack/python-tackerclient: Add support for multi delete https://review.openstack.org/349806 | 01:20 |
sridhar_ram | dkushwaha: sure, will review | 01:29 |
dkushwaha | sridhar_ram, thanks | 01:29 |
dkushwaha | sridhar_ram, For curiosity, Can we not change the api return code even if it wrong ? | 01:34 |
dkushwaha | sridhar_ram, As commented in https://review.openstack.org/#/c/349930/ | 01:34 |
*** sripriya has quit IRC | 01:49 | |
*** bobh has joined #tacker | 01:51 | |
*** arturt__ has joined #tacker | 01:51 | |
*** s3wong has quit IRC | 01:51 | |
*** gongysh has joined #tacker | 02:05 | |
*** gongysh has quit IRC | 02:10 | |
*** prashantD__ has joined #tacker | 02:15 | |
*** arturt__ has quit IRC | 02:18 | |
*** arturt__ has joined #tacker | 02:18 | |
*** prashantD_ has quit IRC | 02:18 | |
*** arturt__ has quit IRC | 02:23 | |
*** bobh has quit IRC | 02:34 | |
*** gongysh has joined #tacker | 02:35 | |
openstackgerrit | Merged openstack/python-tackerclient: Adds audit support in client https://review.openstack.org/349722 | 02:39 |
*** bobh has joined #tacker | 02:44 | |
*** arturt__ has joined #tacker | 02:54 | |
*** arturt__ has quit IRC | 02:58 | |
*** sripriya has joined #tacker | 03:08 | |
*** sripriya has quit IRC | 03:09 | |
openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix ImportError when Jenkins check gate-python-tackerclient-python34 https://review.openstack.org/353924 | 03:15 |
*** bobh has quit IRC | 03:33 | |
*** trozet has quit IRC | 03:45 | |
openstackgerrit | Tim Rozet proposed openstack/python-tackerclient: Add client support for VNFFG in NFVO https://review.openstack.org/341389 | 03:53 |
*** links has joined #tacker | 03:54 | |
*** arturt__ has joined #tacker | 03:54 | |
*** arturt__ has quit IRC | 03:59 | |
*** trozet has joined #tacker | 03:59 | |
openstackgerrit | venkatamahesh proposed openstack/tacker: [DOC] Update the manual installation guide to rectify errors https://review.openstack.org/353258 | 04:03 |
openstackgerrit | Lu lei proposed openstack/tacker: Fix formats for doc's information https://review.openstack.org/341281 | 04:11 |
openstackgerrit | Tim Rozet proposed openstack/python-tackerclient: Add client support for VNFFG in NFVO https://review.openstack.org/341389 | 04:17 |
*** amotoki has joined #tacker | 04:38 | |
sridhar_ram | dkushwaha: it is better to do things (and other) API cleanups using a v2 api | 04:54 |
*** arturt__ has joined #tacker | 04:56 | |
*** arturt__ has quit IRC | 05:00 | |
*** neel has joined #tacker | 05:01 | |
dkushwaha | sridhar_ram, yes, it make sense. Thanks | 05:02 |
*** tbh has joined #tacker | 05:07 | |
*** trozet has quit IRC | 05:25 | |
*** janki|afk has joined #tacker | 05:34 | |
*** prashantD__ has quit IRC | 05:45 | |
*** arturt__ has joined #tacker | 05:57 | |
*** arturt__ has quit IRC | 06:01 | |
*** haiwei has joined #tacker | 06:09 | |
*** janki|afk has quit IRC | 06:27 | |
*** amotoki has quit IRC | 06:50 | |
*** arturt__ has joined #tacker | 06:57 | |
*** arturt__ has quit IRC | 07:02 | |
openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix NotImplementedError when Jenkins checkout gate-python-tackeclient-py34 https://review.openstack.org/356265 | 07:03 |
openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix ImportError when Jenkins check gate-python-tackerclient-python34 https://review.openstack.org/353924 | 07:10 |
openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix ImportError when Jenkins check gate-python-tackerclient-python34 https://review.openstack.org/353924 | 07:20 |
*** neel has quit IRC | 07:28 | |
openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix NotImplementedError when Jenkins checkout gate-python-tackeclient-py34 https://review.openstack.org/356265 | 07:29 |
*** neel has joined #tacker | 07:31 | |
*** lulei has joined #tacker | 07:42 | |
*** tbh has quit IRC | 07:45 | |
*** neel has quit IRC | 07:49 | |
*** arturt__ has joined #tacker | 07:58 | |
*** amotoki has joined #tacker | 08:02 | |
*** amotoki has quit IRC | 08:02 | |
*** amotoki has joined #tacker | 08:03 | |
*** arturt__ has quit IRC | 08:03 | |
*** amotoki_ has joined #tacker | 08:08 | |
*** amotoki has quit IRC | 08:08 | |
*** Jaison has joined #tacker | 08:35 | |
*** links has quit IRC | 08:37 | |
*** arturt__ has joined #tacker | 08:59 | |
*** arturt__ has quit IRC | 09:05 | |
*** neel has joined #tacker | 09:06 | |
openstackgerrit | Lu lei proposed openstack/tacker: Modify vfn/vfnd spelling mistakes in test_vnfm_param.py https://review.openstack.org/351723 | 09:09 |
openstackgerrit | xu-haiwei proposed openstack/python-tackerclient: Add client support for VNFFG in NFVO https://review.openstack.org/341389 | 09:15 |
openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: Make Name parameter positional argument in DOCs and devstack lib https://review.openstack.org/353935 | 09:21 |
openstackgerrit | Lu lei proposed openstack/tacker: Add exception handle to delete vnfd in functional tests https://review.openstack.org/352009 | 09:24 |
*** manikanta_tadi has joined #tacker | 09:35 | |
openstackgerrit | qinchunhua proposed openstack/tacker: Python 3: dict.itervalues() https://review.openstack.org/346291 | 09:35 |
openstackgerrit | qinchunhua proposed openstack/tacker: Python 3: dict.itervalues() https://review.openstack.org/346291 | 09:37 |
openstackgerrit | qinchunhua proposed openstack/tacker: Python 3: dict.itervalues() https://review.openstack.org/346291 | 09:37 |
openstackgerrit | qinchunhua proposed openstack/tacker: Python 3: dict.itervalues() https://review.openstack.org/346291 | 09:38 |
openstackgerrit | qinchunhua proposed openstack/tacker: Python 3: dict.itervalues() https://review.openstack.org/346291 | 09:39 |
openstackgerrit | qinchunhua proposed openstack/tacker: Python 3: dict.itervalues() https://review.openstack.org/346291 | 09:39 |
openstackgerrit | xu-haiwei proposed openstack/python-tackerclient: Add client support for VNFFG in NFVO https://review.openstack.org/341389 | 09:42 |
*** openstack has joined #tacker | 10:19 | |
openstackgerrit | bharaththiruveedula proposed openstack/tacker-specs: Tacker VNFC support https://review.openstack.org/339798 | 10:25 |
*** janki has quit IRC | 10:26 | |
*** janki has joined #tacker | 10:32 | |
*** janki has quit IRC | 10:40 | |
*** arturt__ has joined #tacker | 11:02 | |
*** arturt__ has quit IRC | 11:07 | |
*** neel has quit IRC | 11:07 | |
*** gongysh has quit IRC | 11:08 | |
openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: Store the right description of VNF given from Horizon/CLI. https://review.openstack.org/331039 | 11:08 |
*** tbh has joined #tacker | 11:10 | |
openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: Store the right description of VNF given from Horizon/CLI. https://review.openstack.org/331039 | 11:20 |
openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker-specs: Tacker VNFC support https://review.openstack.org/339798 | 11:23 |
*** prashantD__ has joined #tacker | 11:41 | |
*** prashantD__ has quit IRC | 11:46 | |
*** arturt__ has joined #tacker | 12:03 | |
*** arturt__ has quit IRC | 12:08 | |
*** amotoki_ has quit IRC | 12:13 | |
*** amotoki has joined #tacker | 12:19 | |
*** bobh has joined #tacker | 12:40 | |
*** nagarjung has joined #tacker | 12:49 | |
openstackgerrit | bharaththiruveedula proposed openstack/tacker-specs: Tacker VNFC support https://review.openstack.org/339798 | 12:50 |
*** mike_m has joined #tacker | 13:03 | |
*** arturt__ has joined #tacker | 13:04 | |
*** bobh has quit IRC | 13:04 | |
*** arturt__ has quit IRC | 13:08 | |
*** trozet has joined #tacker | 13:15 | |
openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: Remove the service id from vnfd-create command output https://review.openstack.org/348874 | 13:18 |
*** Vijayendra has quit IRC | 13:18 | |
*** manikanta_tadi has quit IRC | 13:33 | |
*** bobh has joined #tacker | 13:44 | |
*** Jaison has quit IRC | 13:46 | |
*** bobh has quit IRC | 13:50 | |
*** nagarjung has quit IRC | 13:53 | |
*** Vijayendra has joined #tacker | 14:03 | |
*** arturt__ has joined #tacker | 14:05 | |
*** amotoki has quit IRC | 14:05 | |
*** arturt__ has quit IRC | 14:09 | |
*** amotoki has joined #tacker | 14:12 | |
*** prashantD__ has joined #tacker | 14:35 | |
*** prashantD__ has quit IRC | 14:36 | |
*** KanagarajM has joined #tacker | 14:38 | |
*** bobh has joined #tacker | 14:47 | |
*** bobh has quit IRC | 14:51 | |
*** arturt__ has joined #tacker | 14:53 | |
*** openstackgerrit has quit IRC | 15:03 | |
*** openstackgerrit has joined #tacker | 15:04 | |
*** amotoki has quit IRC | 15:10 | |
*** sripriya has joined #tacker | 15:23 | |
*** arturt__ has quit IRC | 15:39 | |
*** arturt__ has joined #tacker | 15:39 | |
*** apsarshaik has joined #tacker | 15:39 | |
*** shaikapsar has quit IRC | 15:40 | |
openstackgerrit | Trevor McCasland proposed openstack/tacker: unit test refactoring trivial changes https://review.openstack.org/320546 | 15:42 |
openstackgerrit | Merged openstack/tacker: Implement tacker workflows https://review.openstack.org/341164 | 15:44 |
*** apsarshaik has quit IRC | 15:46 | |
*** apsarshaik has joined #tacker | 15:46 | |
*** bobh has joined #tacker | 15:47 | |
*** KanagarajM has quit IRC | 15:49 | |
*** arturt__ has quit IRC | 15:52 | |
*** bobh has quit IRC | 15:52 | |
*** arturt__ has joined #tacker | 15:52 | |
*** arturt___ has joined #tacker | 15:54 | |
*** arturt__ has quit IRC | 15:55 | |
*** arturt___ has quit IRC | 15:56 | |
*** arturt___ has joined #tacker | 15:56 | |
*** amotoki has joined #tacker | 15:56 | |
*** arturt___ has quit IRC | 16:01 | |
*** lulei has quit IRC | 16:02 | |
*** uck has joined #tacker | 16:07 | |
*** uck has quit IRC | 16:12 | |
*** uck has joined #tacker | 16:13 | |
*** janki has joined #tacker | 16:14 | |
*** sripriya has quit IRC | 16:24 | |
*** sripriya has joined #tacker | 16:31 | |
*** manikanta_tadi has joined #tacker | 16:45 | |
*** janki has quit IRC | 16:46 | |
*** bobh has joined #tacker | 16:48 | |
*** apsarshaik has quit IRC | 16:49 | |
*** bobh has quit IRC | 16:53 | |
*** tbh has quit IRC | 17:04 | |
*** KanagarajM has joined #tacker | 17:11 | |
*** KanagarajM has quit IRC | 17:19 | |
*** amotoki has quit IRC | 17:24 | |
*** amotoki has joined #tacker | 17:25 | |
*** amotoki has quit IRC | 17:28 | |
*** manikanta_tadi has quit IRC | 17:34 | |
*** ShaikApsar has joined #tacker | 17:43 | |
*** uck has quit IRC | 17:47 | |
*** s3wong has joined #tacker | 17:59 | |
*** uck has joined #tacker | 18:10 | |
*** bobh has joined #tacker | 18:22 | |
*** vishnoianil has quit IRC | 18:37 | |
openstackgerrit | Sripriya Seetharam proposed openstack/tacker: Better handle vim domain exception https://review.openstack.org/351431 | 18:40 |
trozet | sripriya: ping? | 19:10 |
sripriya | trozet: pong | 19:10 |
trozet | sripriya: thanks for reviewing vnffg. I'm looking at your comment and don't understand it | 19:11 |
trozet | "please revisit the new db tables/columns schema that is created here. many columns refer to foreign key 'id' which cannot be true. this breaks FK constraint errors on newer sql versions >=5.6." | 19:11 |
trozet | sripriya: i see in the multisite_vim tables, it referes to id as a FKC? | 19:11 |
trozet | refers* | 19:12 |
sripriya | trozet: i’m referring to the attributes which are foreign keys , example: https://review.openstack.org/#/c/344522/18/tacker/db/migration/alembic_migrations/versions/507122918800_adds_vnffg.py@79 | 19:13 |
trozet | sripriya: oh, you are talking about the nullable=True part? | 19:14 |
sripriya | trozet: here nfp_id is a FK of vnffgnfp.id which is PK and is not nullable | 19:14 |
trozet | sripriya: ah now I see what you meant | 19:14 |
trozet | sripriya: ok will fix thanks | 19:15 |
sripriya | trozet: this will complain on newer sql version which apparently was a bug they fixed it recently to handle such mismatches | 19:15 |
trozet | sripriya: sure, understood | 19:15 |
sripriya | trozet: and for rest of attributes such as name, status, etc, they are not nullable=true | 19:16 |
trozet | sripriya: yeah fixing it now | 19:16 |
sripriya | trozet: they are mandatory in the api layer | 19:16 |
sripriya | trozet: thanks | 19:16 |
trozet | sripriya: this is what happens when I create the alembic migration by hand :) | 19:17 |
trozet | sripriya: one more question, why in hte migration do you say to remove the downgrade section? | 19:17 |
sripriya | trozet: i still did not get why this wasn't autogenerated. | 19:17 |
trozet | sripriya: it is because before I was using dual FKC on 2 tables, so there was a dependency between both tables, and alembic can't figure out how to do the alter | 19:18 |
sripriya | trozet: downgrades are complex and error prone, so openstack community officially stopped supporting downgrades on db . refer https://specs.openstack.org/openstack/openstack-specs/specs/no-downward-sql-migration.html | 19:18 |
trozet | sripriya: but i removed that dual FKC, and just continued editing manually | 19:18 |
trozet | sripriya: ah ok | 19:19 |
sripriya | trozet: is it possible to retry generating script. it is for the same reason folks insist using alembic script to be generate and not handwritten | 19:19 |
trozet | sripriya: right now I'd rather not go down that road due to time | 19:20 |
sripriya | trozet: i understand, but worth giving a quick try by backing your original script. you would then spend lesser time fixing fk related errors. if it doesn’t help, you can continue with what you are doing. | 19:23 |
trozet | sripriya: my openstack setup is screwed up right now, i don't want to spend time fixing it. I'm going to fix these comments and add missing code + unit tests. Once that is all there and I feel like the patch is more complete I will go fix my openstack setup and can test alembic there | 19:25 |
*** vishnoianil has joined #tacker | 19:26 | |
sripriya | trozet: ok. another suggestion would be to test on mariab 10.1.x versions and ensure scripts work smoothly (a follow on task) | 19:26 |
sripriya | mariadb* | 19:27 |
trozet | sripriya: I believe the openstack setup i was using is using 10 | 19:27 |
sripriya | trozet: ah thats cool then. | 19:27 |
trozet | [root@overcloud-controller-0 ~]# rpm -q mariadb | 19:27 |
trozet | mariadb-10.1.12-4.el7.x86_64 | 19:27 |
trozet | sripriya:^ | 19:27 |
*** bobh has quit IRC | 19:28 | |
sripriya | trozet: yep, good to test on this, since our dsvm gate runs ubuntu+mysql 5.5 version, and many bugs were fixed in mysql >5.5 | 19:28 |
sripriya | trozet: helps catch these errors | 19:28 |
trozet | sripriya: ok cool | 19:29 |
*** ShaikApsar has quit IRC | 19:30 | |
vishwanathj | hello, anyone know background on why pagination_support is set to false at https://github.com/openstack/python-tackerclient/blob/master/tackerclient/tacker/v1_0/__init__.py#L553 | 19:34 |
sripriya | vishwanathj: by default pagination support will be false for list command, if the resource needs to support list command with pagination support, it cna override the default and set it to true, then the pagination method would send the required attributes to the tacker server for pagination support | 19:42 |
vishwanathj | sripriya Thanks | 19:43 |
sripriya | vishwanathj; sure np | 19:46 |
-openstackstatus- NOTICE: The volume for logs.openstack.org filled up rather suddenly, causing a number of jobs to fail with a POST_FAILURE result and no logs; we're manually expiring some logs now to buy breathing room, but any changes which hit that in the past few minutes will need to be rechecked and/or approved again | 19:46 | |
*** bobh has joined #tacker | 19:52 | |
*** mike_m has quit IRC | 19:53 | |
trozet | sripriya, sridhar_ram: ping? | 20:39 |
sridhar_ram | trozet: sorry, i'm locked up to finish something over next 2 - 3hrs.. will be available later in the evening | 20:46 |
trozet | sridhar_ram: np. It was a quick question. Was wondering if you care if I add to some of these files from tacker._18n import _ | 20:46 |
trozet | sridhar_ram: pycharm thinks they are all errors because the module is loaded somewhere else when tacker service starts | 20:47 |
sridhar_ram | trozet: i don't see any issues .. it is the right thing to do, just though it might be unrelated to the actual ffg related logic | 20:48 |
trozet | sridhar_ram: ok thanks. Helps me to see the green symbol that my file is error free :) | 20:48 |
sridhar_ram | trozet: i can totally relate to that feeling, giving in to our OCDs ;-) | 20:49 |
openstackgerrit | Tim Rozet proposed openstack/tacker: [WIP] Implements VNFFG into NFVO https://review.openstack.org/344522 | 21:20 |
openstackgerrit | Tim Rozet proposed openstack/tacker: [WIP] Implements VNFFG into NFVO https://review.openstack.org/344522 | 21:21 |
*** sripriya has quit IRC | 21:23 | |
openstackgerrit | Tim Rozet proposed openstack/tacker: [WIP] Implements VNFFG into NFVO https://review.openstack.org/344522 | 21:25 |
*** sripriya has joined #tacker | 21:44 | |
*** uck_ has joined #tacker | 21:53 | |
*** uck has quit IRC | 21:53 | |
*** uck has joined #tacker | 21:54 | |
*** uck_ has quit IRC | 21:54 | |
*** amotoki has joined #tacker | 22:09 | |
*** amotoki_ has joined #tacker | 22:10 | |
*** amotoki has quit IRC | 22:14 | |
*** bobh_ has joined #tacker | 22:19 | |
*** bobh_ has quit IRC | 22:20 | |
*** bobh has quit IRC | 22:21 | |
*** sripriya has quit IRC | 22:22 | |
*** amotoki_ has quit IRC | 22:50 | |
*** manikanta_tadi has joined #tacker | 22:56 | |
*** amotoki has joined #tacker | 23:08 | |
*** sripriya has joined #tacker | 23:11 | |
*** amotoki has quit IRC | 23:13 | |
*** sripriya has quit IRC | 23:31 | |
*** amotoki has joined #tacker | 23:35 | |
*** amotoki has quit IRC | 23:41 | |
*** manikanta_tadi has quit IRC | 23:46 | |
haiwei | hi sridhar_ram, can you review this patch again? https://review.openstack.org/#/c/323192/ | 23:56 |
*** bobh has joined #tacker | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!