| *** mageshgv has quit IRC | 00:41 | |
| sripriya | tacker cores: reminder to please review https://review.openstack.org/#/c/303092/ | 00:42 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tacker: Updated from global requirements https://review.openstack.org/307779 | 00:43 |
| *** bobh has joined #tacker | 00:52 | |
| *** bobh has quit IRC | 00:57 | |
| *** bobh has joined #tacker | 01:13 | |
| *** prashantD has quit IRC | 01:23 | |
| *** lhcheng has quit IRC | 01:34 | |
| *** sripriya has quit IRC | 01:52 | |
| *** s3wong has quit IRC | 02:03 | |
| *** dkushwaha has quit IRC | 02:11 | |
| *** bobh has quit IRC | 02:12 | |
| *** vishnoianil has quit IRC | 02:31 | |
| *** sridhar_ram has quit IRC | 02:38 | |
| *** amotoki has joined #tacker | 02:44 | |
| *** bobh has joined #tacker | 02:46 | |
| *** gongysh_ has quit IRC | 02:51 | |
| *** dkushwaha has joined #tacker | 02:59 | |
| *** lhcheng has joined #tacker | 03:02 | |
| openstackgerrit | Bob Haddleton proposed openstack/tacker: Fix monitoring of TOSCA VNFDs https://review.openstack.org/299737 | 03:31 |
| *** bobh has quit IRC | 03:32 | |
| *** gongysh has joined #tacker | 03:40 | |
| *** prashantD has joined #tacker | 03:51 | |
| *** gongysh has quit IRC | 04:08 | |
| dkushwaha | lhcheng, hi | 04:28 |
| lhcheng | dkushwaha: hey | 04:29 |
| dkushwaha | lhcheng, Regarding https://review.openstack.org/#/c/291032/ , could you please help me to fix on horizon side | 04:30 |
| dkushwaha | lhcheng, please have a look in last comment for traces in https://review.openstack.org/#/c/291032/ | 04:34 |
| lhcheng | looking | 04:34 |
| lhcheng | dkushwaha: do you have a way to modify and test the horizon code? | 04:54 |
| lhcheng | I don't have tacker setup, I don't have a way to test it | 04:55 |
| dkushwaha | lhcheng, yes, I have. | 04:55 |
| lhcheng | dkushwaha: try removing the try-except code in https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L133-L137 | 04:56 |
| lhcheng | the get_data call is handled here: https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1538 | 04:56 |
| lhcheng | this already handles the case when the object has been removed | 04:57 |
| *** sripriya has joined #tacker | 05:01 | |
| dkushwaha | lhcheng, I had already tried by removing https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L136L137 . but stuck somewhere. | 05:01 |
| dkushwaha | lhcheng, ok, I will retry and let you know. Thanks | 05:03 |
| lhcheng | dkushwaha: remove this line too: https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L94 | 05:04 |
| lhcheng | :) | 05:04 |
| lhcheng | and shift indention | 05:04 |
| lhcheng | I assume you already did that? | 05:04 |
| *** vishnoianil has joined #tacker | 05:07 | |
| *** prashantD has quit IRC | 05:16 | |
| dkushwaha | lhcheng, just tried with mentioned modification. But issue could not be resolved. | 05:25 |
| *** sridhar_ram has joined #tacker | 05:25 | |
| lhcheng | what's the behavior now? | 05:26 |
| dkushwaha | lhcheng, After modification, error message was not appeared, but vnf row still exist with status PENDING_DELETE . | 05:28 |
| lhcheng | dkushwaha: at least one of the problem went away | 05:34 |
| lhcheng | can you tell me more about the recent change in delete? | 05:34 |
| lhcheng | I'm not that familiar with the tacker domain, so please explain it to me like a newbie :) | 05:35 |
| dkushwaha | lhcheng, I have removed try statement https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L94 | 05:35 |
| dkushwaha | lhcheng, and its corresponding except as https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L133-L137 | 05:36 |
| lhcheng | this line seems will never be executed: https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L107 | 05:39 |
| lhcheng | cause api.tacker.get_vnf(vnf_id) will raise an exception and not return an empty vnf_instance | 05:39 |
| *** sripriya_ has joined #tacker | 06:36 | |
| *** sripriya has quit IRC | 06:39 | |
| *** janki has joined #tacker | 06:41 | |
| dkushwaha | lhcheng, hi | 06:41 |
| dkushwaha | lhcheng, just tested again, no issue observed at https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L107 | 06:42 |
| lhcheng | no issue because it won't get hit :P | 06:45 |
| *** sridhar_ram has quit IRC | 06:45 | |
| lhcheng | https://github.com/openstack/tacker-horizon/blob/master/tacker_horizon/openstack_dashboard/dashboards/nfv/vnfmanager/tables.py#L101 | 06:45 |
| lhcheng | vnf_instance will never be empty, because get_vnf will throw an exception if the record does not exist | 06:46 |
| *** lhcheng has quit IRC | 06:50 | |
| *** vishnoianil has quit IRC | 07:14 | |
| *** Berezin has joined #tacker | 07:23 | |
| *** sripriya_ has quit IRC | 07:24 | |
| *** vishnoianil has joined #tacker | 07:26 | |
| *** mbound has joined #tacker | 08:07 | |
| *** zeih has joined #tacker | 08:29 | |
| *** zeih has quit IRC | 08:58 | |
| *** janki has quit IRC | 09:13 | |
| *** vishnoianil has quit IRC | 09:20 | |
| *** zeih has joined #tacker | 09:29 | |
| *** vishnoianil has joined #tacker | 09:32 | |
| *** zeih has quit IRC | 09:33 | |
| *** mbound has quit IRC | 09:59 | |
| *** mbound has joined #tacker | 10:02 | |
| *** mbound has quit IRC | 10:04 | |
| *** mbound has joined #tacker | 10:05 | |
| *** Berezin has quit IRC | 10:09 | |
| *** mbound has quit IRC | 10:19 | |
| *** mbound has joined #tacker | 10:20 | |
| *** mbound has quit IRC | 10:23 | |
| *** mbound has joined #tacker | 10:25 | |
| *** gongysh has joined #tacker | 10:57 | |
| *** zeih has joined #tacker | 11:02 | |
| *** zeih has quit IRC | 11:18 | |
| *** zeih has joined #tacker | 11:22 | |
| *** trozet has quit IRC | 11:31 | |
| *** bobh has joined #tacker | 11:33 | |
| *** mageshgv has joined #tacker | 11:39 | |
| *** thatsdone has joined #tacker | 11:46 | |
| *** bobh has quit IRC | 12:25 | |
| *** bobh has joined #tacker | 13:19 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/tacker-horizon: Raise correct error when api.tacker.get_vnf fail https://review.openstack.org/308329 | 13:34 |
| *** gongysh has quit IRC | 13:50 | |
| *** trozet has joined #tacker | 13:55 | |
| *** vishwanathj has joined #tacker | 13:58 | |
| vishwanathj | bobh hi | 13:59 |
| bobh | vishwanathj: hello | 13:59 |
| vishwanathj | bobh I was thinking that we probably merge the SR-IOV support patchset,,,,I will co-author https://review.openstack.org/#/c/299737/ with you to fix the data files, what do you say? | 14:01 |
| bobh | sridhar_ram wanted to merge 299737 ASAP to support the team doing the demo in Austin - he was just waiting for Jenkins | 14:02 |
| vishwanathj | I see, I plan to do demo of SR-IOV and EVP features as well | 14:02 |
| bobh | :-) dueling demos! | 14:03 |
| vishwanathj | I am on vacation Friday | 14:03 |
| bobh | Really makes no difference to me - whichever patchset merges first will cause a merge conflict with the other | 14:03 |
| vishwanathj | sridhar has given his +2, I need your +2 and merge | 14:04 |
| vishwanathj | all the tests have passed as well | 14:04 |
| bobh | any idea what the jenkins backlog looks like this morning? If it's not bad I'll +2 it and rebase 299737 | 14:04 |
| vishwanathj | 104 in the queue as compared to 500, the past 2 days | 14:05 |
| bobh | need a fastpass :-) | 14:05 |
| bobh | ok - I'll merge yours and rebase mine and resubmit - no problem | 14:05 |
| vishwanathj | thanks a bunch | 14:07 |
| openstackgerrit | Merged openstack/tacker: Implements SR-IOV support https://review.openstack.org/300903 | 14:09 |
| openstackgerrit | Bob Haddleton proposed openstack/tacker: Fix monitoring of TOSCA VNFDs https://review.openstack.org/299737 | 14:15 |
| *** mbound has quit IRC | 14:20 | |
| *** twm2016 has joined #tacker | 14:22 | |
| *** srwilkers has joined #tacker | 14:32 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/tacker: Updated from global requirements https://review.openstack.org/307779 | 14:34 |
| openstackgerrit | Bob Haddleton proposed openstack/tacker: Fix monitoring of TOSCA VNFDs https://review.openstack.org/299737 | 14:49 |
| *** gongysh has joined #tacker | 14:56 | |
| gongysh | vishwanathj, hi | 14:57 |
| gongysh | do you have any update on that ppt? | 14:57 |
| *** bobh has quit IRC | 15:02 | |
| *** prashantD has joined #tacker | 15:08 | |
| *** prashantD_ has joined #tacker | 15:10 | |
| *** prashantD has quit IRC | 15:13 | |
| *** prashantD_ has quit IRC | 15:30 | |
| *** gongysh has quit IRC | 15:40 | |
| *** bobh has joined #tacker | 15:43 | |
| *** sridhar_ram has joined #tacker | 15:45 | |
| *** uck has joined #tacker | 15:50 | |
| *** thatsdone has quit IRC | 15:52 | |
| *** twm2016 has quit IRC | 15:54 | |
| *** lhcheng has joined #tacker | 16:02 | |
| openstackgerrit | Merged openstack/tacker: Updated from global requirements https://review.openstack.org/307779 | 16:03 |
| *** zeih has quit IRC | 16:13 | |
| *** twm2016 has joined #tacker | 16:29 | |
| *** lrensing has joined #tacker | 16:34 | |
| lhcheng | dkushwaha: did you made progress on troubleshooting the issue? | 16:56 |
| *** amotoki has quit IRC | 16:59 | |
| *** mbound has joined #tacker | 17:06 | |
| *** mbound has quit IRC | 17:26 | |
| *** sridhar_ram has quit IRC | 17:29 | |
| *** s3wong has joined #tacker | 17:35 | |
| openstackgerrit | Larry Rensing proposed openstack/tacker: Ignore test classes in .coveragerc https://review.openstack.org/308497 | 17:45 |
| *** sripriya has joined #tacker | 17:53 | |
| *** lrensing has quit IRC | 18:26 | |
| *** sridhar_ram has joined #tacker | 18:39 | |
| *** vishnoianil has quit IRC | 18:46 | |
| *** vishwanathj has quit IRC | 18:50 | |
| *** vishwanathj has joined #tacker | 18:50 | |
| sridhar_ram | trozet: ping | 18:58 |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Apply vcpu and memory definitions to numa node for a VM https://review.openstack.org/306635 | 19:05 |
| *** srwilkers has quit IRC | 19:10 | |
| *** sridhar_ram_ has joined #tacker | 19:11 | |
| *** lhcheng has quit IRC | 19:11 | |
| *** uck has quit IRC | 19:12 | |
| *** lhcheng has joined #tacker | 19:25 | |
| *** sridhar_ram is now known as sridhar_ram_afk | 19:27 | |
| trozet | sridhar_ram_, sridhar_ram_afk: hi | 19:27 |
| *** vishnoianil has joined #tacker | 19:39 | |
| *** uck has joined #tacker | 20:13 | |
| *** uck has quit IRC | 20:18 | |
| *** lhcheng has quit IRC | 20:25 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds sample TOSCA VNFDs for EVP features https://review.openstack.org/306241 | 20:39 |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds sample TOSCA VNFDs for EVP features https://review.openstack.org/306241 | 20:56 |
| *** lhcheng has joined #tacker | 21:08 | |
| *** sridhar_ram_afk is now known as sridhar_ram | 21:12 | |
| sridhar_ram | bobh: a quick help on https://review.openstack.org/#/c/299737 .. | 21:19 |
| bobh | sridhar_ram: y | 21:19 |
| sridhar_ram | bobh: .. can you update the commit mesg w/ "Implements: bp/tosca-parser-integration" | 21:19 |
| sridhar_ram | bobh: .. as this is follow through of that bp | 21:19 |
| *** lhcheng has quit IRC | 21:20 | |
| sridhar_ram | bobh: trying to take care of gongysh's comment so that we can merge this asap | 21:20 |
| bobh | sridhar_ram: ok - just for master? | 21:20 |
| sridhar_ram | yes... | 21:20 |
| openstackgerrit | Bob Haddleton proposed openstack/tacker: Fix monitoring of TOSCA VNFDs https://review.openstack.org/299737 | 21:21 |
| sridhar_ram | bobh: btw, did you do a manual cherrypick for https://review.openstack.org/#/c/308297/ ? | 21:21 |
| bobh | sridhar_ram: yes - is that bad? | 21:21 |
| sridhar_ram | bobh: I don't see the cherrypick comments that gerrit typically adds | 21:21 |
| sridhar_ram | bobh: preferred option is to use gerrit (assuming there is no merge conflict)... | 21:22 |
| sridhar_ram | bobh: can you just update the commit mesg with something similar to ... | 21:22 |
| bobh | I did it through the gerrit interface - pressed the button | 21:22 |
| * sridhar_ram looking up | 21:22 | |
| sridhar_ram | bobh: https://review.openstack.org/#/c/307966/ | 21:22 |
| sridhar_ram | bobh: see the line (cherry picked from commit <uuid>) | 21:23 |
| sridhar_ram | bobh: hmm.. perhaps gerrit didn't add because the source didn't merge yet | 21:23 |
| bobh | easier to abandon and re-cherry-pick after it merges? | 21:24 |
| sridhar_ram | bobh: that would work too | 21:41 |
| bobh | sridhar_ram: ok - I'll watch for the merge and then do it again | 21:41 |
| *** lhcheng has joined #tacker | 21:44 | |
| sripriya | sridhar_ram: bobh: s3wong: please review cherrypick https://review.openstack.org/#/c/308037/ | 21:48 |
| *** sridhar_ram_ has quit IRC | 21:54 | |
| *** sripriya_ has joined #tacker | 22:02 | |
| *** sridhar_ram1 has joined #tacker | 22:03 | |
| *** sridhar_ram has quit IRC | 22:04 | |
| *** sripriya has quit IRC | 22:05 | |
| *** lhcheng has quit IRC | 22:18 | |
| *** bobh has quit IRC | 22:21 | |
| *** lhcheng has joined #tacker | 22:27 | |
| *** twm2016 has left #tacker | 22:34 | |
| *** bobh has joined #tacker | 23:32 | |
| *** sridhar_ram1 has quit IRC | 23:41 | |
| *** uck has joined #tacker | 23:41 | |
| *** sripriya has joined #tacker | 23:42 | |
| *** sripriya_ has quit IRC | 23:44 | |
| *** sridhar_ram has joined #tacker | 23:46 | |
| *** bobh has quit IRC | 23:56 | |
| *** mageshgv has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!